Commit graph

2 commits

Author SHA1 Message Date
Pierre Gayvallet
c5546f4a39
Add globalSearch x-pack plugin (#66293)
* add skeleton for global_search plugin

* base implementation of the server-side service

* add utils tests

* add server-side mocks

* move take_in_array to common folder

* implements base of client-side plugin

* add tests for server-side service

* fix server plugin tests

* implement `navigateToUrl` core API

* extract processResults for the client-side

* fetch server results from the client side

* factorize process_results

* fix plugin start params

* move things around

* move all server types to single file

* fix types imports

* add basic FTR tests

* add client-side service tests

* add tests for addNavigate

* add getDefaultPreference & tests

* use optional for RequestHandlerContext

* add registerRoutes test

* add base test for context

* resolve TODO

* common nits/doc

* common nits/doc on public

* update CODEOWNERS

* add import for declare statement

* add license check on the server-side

* add license check on the client-side

* eslint

* address some review comments

* use properly typed errors for obs

* add integration tests for the find endpoint

* fix unit tests

* use licensing start contract

* translate the error message

* fix eslint rule for test_utils

* fix test_utils imports

* remove NavigableGlobalSearchResult, use `application.navigateToUrl` instead.

* use coreProvider plugin in FTR tests

* nits

* fix service start params

* fix service start params, bis

* I really need to fix this typecheck oom error

* add README, update missing jsdoc

* nits on doc
2020-06-04 16:18:02 +02:00
Pierre Gayvallet
e5f56ad7a7
[RFC] Global search API (#64284)
* initial file import

* update types

* update RFC PR number

* first draft complete

* draft v1.1.0

* initial self review

* nits and comments

* add 'preference' option

* change meta type to Record<string, Serializable>

* specify cancellation

* remove generic for GlobalSearchResponse, use distinct type on client and server

* use plain string instead of enum for GlobalSearchResult.type

* remove terminology from unresolved questions

* update pros/cons of core vs plugin

* GS is exposed from a plugin instead of core

* remove the server.publicAddress proposal, return mixed abs url / rel paths instead

* distinguish result type between GS api and result providers

* return batched results, no longer sort

* remove request from GlobalSearchProviderContext

* add maxResults to GlobalSearchProviderFindOptions

* nit/typo
2020-05-18 18:05:24 +02:00