Brian Seeders
54c3ca142e
[CI] Buildkite support with Baseline pipeline ( #100492 )
2021-06-01 13:11:07 -04:00
Brandon Kobel
4584a8b570
Elastic License 2.0 ( #90099 )
...
* Updating everything except the license headers themselves
* Applying ESLint rules
* Manually replacing the stragglers
2021-02-03 18:12:39 -08:00
John Schulz
380fa5b3f6
[bundle optimization] Update to semver 7.x to get tree-shaking ( #83020 )
...
## What's changed in this PR
### Update to latest available `semver`: `7.3.2`
* `semver` 5.x pulls in the entire library in one large file (~38k uncompressed / ~9k gz), when we might only use 1-2K.
* `semver` 7.0+ supports tree-shaking: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#700
### Update paths to only import individual function(s) used instead of the entire library
* Getting the smaller bundle requires a different import style [as shown in the docs](https://github.com/npm/node-semver#usage )
* Only changed code in `public` & `common` folders; not `server`. We could also update `server` as well for consistency, but I skipped because the new import style is more verbose and the filesize didn't seem as important on the server
### Results
The build stats show a 10K+ improvement for initial page bundles https://github.com/elastic/kibana/pull/83020#issuecomment-724724432
| id | [before](c6afc47f32213bb52a8chttps://github.com/elastic/kibana/pull/83020#issuecomment-724859130
### Possible issues
Moving 2 major versions. We're currently on 5.7 and the latest available is 7.3.
* changelog says 5.x (our current) to 6.0 should be safe: https://github.com/npm/node-semver/blob/master/CHANGELOG.md#60
* There 6.x & 7.x changes all appear to be new features or bugfixes around the `includePrerelease` flag added in 5.6, but I'm not sure if those "fixes" will break existing code
* https://github.com/npm/node-semver/blob/master/CHANGELOG.md#613
* https://github.com/npm/node-semver/blob/master/CHANGELOG.md#722
### Stats / screenshots
generated with `node scripts/build_kibana_platform_plugins.js --profile --focus=ingestManager`
<details><summary><b>Ingest Manager in `master`</b>: imports entire `semver` lib, totals 40k+, only 1 large file (orange arc below)</summary>
<img width="972" alt="Screen Shot 2020-11-09 at 6 50 23 PM" src="https://user-images.githubusercontent.com/57655/98666188-a50ac380-231a-11eb-9b8a-6ca784752714.png ">
</details>
<details><summary><b>Ingest Manager in PR after upgrade to 7</b>: still imports entire lib. file size *increased* to ~60k, but now individual files are imported (orange arcs below)</summary>
<img width="825" alt="Screen Shot 2020-11-09 at 5 46 30 PM" src="https://user-images.githubusercontent.com/57655/98666355-e602d800-231a-11eb-803f-bc04beb4eaf1.png ">
<img width="963" alt="Screen Shot 2020-11-09 at 5 47 06 PM" src="https://user-images.githubusercontent.com/57655/98666357-e69b6e80-231a-11eb-92d3-c66904f92c30.png ">
</details>
<details><summary><b>Ingest Manager in PR after changing `import`s:</b> total imported size down to ~20k. Can see individual imported files</summary>
<img width="926" alt="Screen Shot 2020-11-10 at 6 10 23 AM" src="https://user-images.githubusercontent.com/57655/98667058-e64fa300-231b-11eb-9690-5e36ed6475e0.png ">
<img width="895" alt="Screen Shot 2020-11-10 at 6 10 53 AM" src="https://user-images.githubusercontent.com/57655/98667059-e780d000-231b-11eb-8abf-98d8bdbcf061.png ">
</details>
### Checklist
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html ) were updated or added to match the most common scenarios
2020-11-14 07:32:02 -05:00
Pierre Gayvallet
0d09cea436
Remove legacy plugins support ( #77599 )
...
* remove ALL the things.
* adapt some types and tests
* restore ensureValidConfiguration
* fix legacy service tests
* adapt uiRender mixin
* remove legacy types
* update generated doc
* restore legacy plugin schema
* update generated doc
* remove remaining code of x-pack/legacy
* adapt imports due to merge
* cleanup CODEOWNERS
* cleanup gitignore & i18nrc
* cleanup tsconfig.json
* remove unused i18n keys
* add back `"legacy/plugins/**/*",` to tsconfig until legacy space plugin is deleted
* fix create_jest_config
* remove references from eslintrc
* more eslint cleanup
* remove `x-pack/index.js`
* fix xpack gulp scripts
* fix bug with default + named imports from boom
* remove rules from eslintrc
* remove LegacyInternals
* review comments
* update generated doc
* cleanup legacy metadatas
* revert changes to eslintrc
* update generated doc
2020-09-23 09:52:51 +02:00
restrry
bf04235dae
apply prettier styles
2020-05-22 09:08:58 +02:00
Jonathan Budzenski
76d475a64c
Refactor test entry by runner ( #44679 )
...
Over the last few years we've increased the number of test runners.
Entry points by test type have become too lage of a category for unique
names, so this moves top level test scripts under yarn and replaces test
types with the runner name.
e.g. `yarn test:browser` -> `yarn test:karma`
Closes #41133
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-02-18 16:21:36 -06:00
renovate[bot]
445fa434d5
Update gulp related packages (major) ( #46665 )
...
* Update gulp related packages
* ts-ify and gulp4-ify x-pack tasks, remove unused canvas tasks
* remove unnecessary gulp.TaskFunction usage
* fix old references
* update renovate config
* move constants into helpers directory
* typo
* compact tasks a bit, remove unnecessary paths
* fix build directories
* deprecate testonly task
* rather than justifying an unjustifiable ts-ignore, ts-ify the imported module
* update renovate config
* update browser download tests to mock axios
* add root index.d.ts to tsconfig
* export BrowserType
* remove unnecessary `@ts-ignore`
* use consistent casing
2019-10-05 07:53:47 -07:00
Mengwei Ding
c3b8142f8f
[Code] reenable code mocha tests ( #40189 )
...
* [Code] reenable code mocha tests
* skip multi node test
2019-07-02 23:15:28 -07:00
Corey Robertson
ef2b551e48
[Canvas] Convert Function tests to Jest ( #39176 )
...
* Convert function tests to jest
* Fix some bad merge conflict resolutions
* Exclude Server tests from being included in mocha run
* Remove code leftover from testing
* Fix rebase
* Fix paths for running Jest tests
* do not run function server tests as part of test:server
* Move Jest tests to be alongside files
2019-06-28 16:52:16 -04:00
Corey Robertson
253886c089
Update paths to legacy/plugins ( #39721 )
...
* Update paths to legacy/plugins
* Disable Code server test runs
2019-06-28 10:17:07 -04:00
Court Ewing
2d171c92f5
Fix path references into and out of x-pack/legacy
2019-06-20 13:34:48 -04:00
Fuyao Zhao
f877c78e95
Revert "[Code]: disable code by default in 7.2 ( #38757 )" ( #38802 )
...
This reverts commit 4886c4bb21
2019-06-12 10:42:01 -07:00
Fuyao Zhao
4886c4bb21
[Code]: disable code by default in 7.2 ( #38757 )
2019-06-12 08:56:14 -07:00
Fuyao Zhao
c41010760e
Run mocha test (for review) ( #35924 )
...
* [Code]: Make sure code mocha test could be run on CI
* [Code] fix lsp_service tests
* [Code] fix a problem that process can't exit normal when running gulp
* Ignore cert check for mocha tests
* Don't reuse root
2019-05-03 12:26:41 -07:00
Court Ewing
2ce51a5be5
Update paths to ui, server, deprecation, plugin_discovery in src/legacy
...
This commit accompanies the four that precede it. Rather than squash
them altogether, the four previous commits all do nothing except move
files to help avoid conflicts.
2019-02-11 10:41:37 -05:00
Jonathan Budzenski
fa8237d197
[build] Support version-qualifier flag ( #21663 )
...
* [build] Support version-qualifier flag
* add help description
* fix test
* is-release
* temp: re-add alpha1 to package.json
* use version qualifier in build
* fix merge
* Revert "temp: re-add alpha1 to package.json"
This reverts commit a70688542c
2018-11-02 09:39:12 -05:00
Joe Fleming
ef4b694e83
Chore: Reorg the x-pack gulp tasks ( #22785 )
...
- Removes deprecated, non-functional lint scripts
- Removes some unused (and barely used) dependencies
- Replaces deprecated `gulp-util` dependency
- Adds eslint rule to prevent future use of deprecated `gulp-util` dependency
- Moves all gulp tasks into `tasks` path
- Moves `gulp_helpers` into `tasks/helpers`
- All tasks in `gulpfile.js` were moved into `tasks` and broken up by domain
This is basically a no-op moving files around PR. All the existing tasks appear to work the same with these changes.
<img width="334" alt="screenshot 2018-09-06 15 42 45" src="https://user-images.githubusercontent.com/404731/45188971-8618c000-b1eb-11e8-9b26-b072ccc7ddb7.png ">
2018-09-07 09:43:17 -07:00
