Commit graph

18761 commits

Author SHA1 Message Date
Aleh Zasypkin f659802d96
[6.x] TypeScriptify src/utils. (#24638) 2018-10-29 12:54:13 +01:00
Maryia Lapata e197a30f37
Remove unnecessary path in i18n config (#24476) (#24626) 2018-10-29 14:27:08 +03:00
Maryia Lapata 8ca84c0d0c
[i18n] Fix typos in translations ids and messages (#24480) (#24625)
* Fix typos in translations ids and messages

* Fix typos
2018-10-29 14:26:47 +03:00
Leanid Shutau 46b83db605
[I18n] Add pseudo-localization to i18n engine (#24130) (#24635)
* [I18n] Add pseudo-localization to i18n engine

* Add pseudo-localization to React

* Remove lookbehind from regex

* Resolve comments

* Add comment
2018-10-29 13:54:26 +03:00
Leanid Shutau 94637b538f
[Tools] Forbid i18n filter usage outside of interpolation expressions (#23982) (#24644)
* [I18n] Forbid i18n filter usage outside of interpolation expressions

* Add tests

* Add usage examples to JSDoc
2018-10-29 13:53:09 +03:00
Matt Apperson 9487c012f6 [BeatsCM] Beats without tags should return an empty array via the config API (#24665) 2018-10-28 20:59:10 -04:00
Jason Rhodes 7f9773292e
Polish 6.5 (#24556) (#24688)
* Updates waterfall item design for timeline rows

* Adjusts span and tx flyouts and updates tooltips to EUI

* Heading size fixes and clean up

* Updates tooltip snapshots

* Review tweaks and snapshot updates

* Revert experiment :)

Co-Authored-By: jasonrhodes <jason.matthew.rhodes@gmail.com>

* Fixes bug with v1 waterfall state

* Fixes bug with timeline bar height

* Updates snapshot tests

* Updated test so it doesn't mount and rely on EUI makeId() which is non-deterministic per test run
2018-10-26 22:47:33 -04:00
Josh Dover 306d06c0e9
[6.x] Upgrade Hapi in legacy platform to v17 (#21707) (#24608)
* Upgrade Hapi in legacy platform to v17 (#21707)

* Disable even-better monitoring

* Upgrade to Hapi v15

* Upgrade to Hapi v16

* Handle optional req params correctly

* Update http and kbnServer

* Get mocha tests passing

* Convert `reply` usages [wip]

* Fix Joi and Plugin incompatibilities

* Get server up and running

* Get basic logging working

* Fix optimizer

* Fix recent route handlers

* Various fixes

* Fix recent routes

* Upgrade wreck for async/await

* Fix mocha tests

* Fix joi issues

* Fix xpack jest tests

* Fix recent routes

* Fix tests

* Fix index setup

* Decouple monitoring stats collection from good plugin

* Update reload logging test to work

* Reimplement logging with updated good plugin

* Fix unit tests

* Fix getConnections back

* Make LegacyLoggingServer compatible with Hapi v17

* Update joi types

* Fix x-pack unit tests

* Remove stray debugger

* Remove hapi-compat

* Fix API integrations

* Upgrade boom

* Fix security plugin

* Misc fixes

* bump

* Fix licensePreRoutingFactory

* Fix failing integration tests

* Remove unnecessary test change

* Remove hapi-latest package

* fx

* Various cleanup

* Fix race condition in oppsy events

* Use elastic/good fork

* Fix boom.wrap and hapi-latest changes

* Simplify LegacyLoggingServer updates

* package.json cleanup + test fix

* yarn.lock cleanup

* Change good tag

* Fixes

* Change return err -> throw err in routes

* Fix await returns

* Fix new load_data test

* Make cookie security flags consistent

* tmp doc

* Fix types

* Fix tests

* Upgrade canvas plugin

* Move good package to published @elastic/good one

* Fix SO test

* Fix logging reloading

* Update APM apis

* Fix error logging

* Fix logging test

* Convert spaces plugin

* Add validation error shim

* Remove 7.0 release notes

* Await renderApp

* Fix ccr routes

* Prevent header popovers from scrolling with page content (#23850)

* Fix spaces test

* new yarn.lock-s

* Fix spaces tests

* Remove h2o2-latest

* Fix @types/hapi

* Upgrade InfraOps plugin

* Fix package.json

* Add back isSameSite: false

* Upgrade beats_management plugin

* Update snapshot

* Fix InfraOps

* Upgrade kql_telemetry

* Merge upstream/master

* Upgrade apm and ml

* Put snapshot test back

* Fx beats

* Upgrade rollups

* Update boom usages in new plugins

* Update url shortener

* Don't throw errors in optimizer (#24660)
2018-10-26 16:37:05 -05:00
Catherine Liu fe94151059 Fixed label position on progress elements (#24623) 2018-10-26 13:27:19 -07:00
Catherine Liu ebc404c9b5 Upgrades Tinymath (#24457)
* Bumped tinymath to v1.0.0

* Bumped tinymath version to 1.1.0
2018-10-26 10:05:07 -07:00
Catherine Liu 393708ff70 Fix: select field updates on change (#24288)
* Replace defaultValue with value

Added default value for size in text_style_picker

Made page_config select compressed

Added default values for props in appearance_form

Switched select to superselect in border_form

Refactored datacolumn

refactored simple_math_function

Fixed page_config

* Added an euispacer to border form
2018-10-26 10:01:11 -07:00
Joe Fleming dc55efb1f8 Feat/expression threading (#24598)
Replaces https://github.com/elastic/kibana/pull/23301
Closes https://github.com/elastic/kibana/issues/23080

---

This is a minimal threading implementation for Canvas. There's still a lot to be done to make this concept great, but this is a start. 

What it does:
- Creates a server side abstraction on top of the interpreter
- Determines where to send the expression by checking the first function to be run
- Loads common functions in a separate worker thread on the server. 
- Routes to a single forked worker (thread), the main thread (server), or the browser (browser), in that order
- Defers back to the router when a function isn't found. Fails if the function isn't found in any of the above 3 environments
- Times out the worker if it takes too long, and respawns it as needed.
- Simplifies the error dialog to remove the stack. 

What is does not.:
- Round robin a pool of workers
- Queue. If one expression in the threaded env fails then anything sent to it in the meantime will fail. The upstream environment handles managing timeouts. I think this would only make sense todo with a pool.
- Client side. This doesn't implement web workers, but we could use roughly the same architecture. 
- Implement a specific, pluggable `worker` environment on the server. Right now it's just common functions, so plugin authors will always end up in a thread if they put their function in the common directory.

What I don't like:
- The socketProvider code. This was reused across the server & browser, but now that it's only used in the browser there's no good reason for the abstraction
- The serialize/deserialize stuff feels messy. Do we really need serialization?
2018-10-26 09:50:24 -07:00
spalger 366cfca980 [dev/build] fix invalid assertion
(cherry picked from commit 214ccfcf5f)
2018-10-26 08:23:43 -07:00
spalger 8cdd294593 [kbn-pm] update kbn-pm build 2018-10-26 07:57:57 -07:00
Spencer 8afa15f7be
[6.x] [uiSettings] only try to autoCreateOrUpgrade once (#24605) (#24613)
* [uiSettings] only try to autoCreateOrUpgrade once (#24605)

## Summary

When tests override the `savedObjectsClient.get()` call to always return a 404 an out of memory error is triggered in the tests that's caused because `uiSettings._read()` is constantly trying to recover by running `createOrUpgradeSavedConfig()` and then retrying the `_read()`. Instead we should behave like `_write()` and only try to auto-recover on the first request, then call read with `_read({ ...options, autoCreateOrUpgradeIfMissing: false })` which will prevent the auto-recovery the second time and avoid the OOM.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)

* [monitoring/tests] disable tests that are broken until snapshots updated
2018-10-26 07:30:30 -07:00
Felix Stürmer 500e727b5a Increment version number from 6.5.0 to 6.6.0 (#24634)
* Increment version number from 6.5.0 to 6.6.0

* Add branch 6.5 to backportrc, sync versions with master

* Undo removal of older version from backportrc
2018-10-26 07:44:49 -04:00
Andrew Cholakian e88008849a Fix windows instructions for uptime add data UI (#24587)
* Fix windows instructions for uptime add data

The windows instructions had three separate issues:

1. Redundant/unclear instruction to edit ES output settings removed
2. Incorrect invocation of the heartbeat binary without .\ prefix
3. Incorrect verbiage for modifying the `heartbeat.yml` file
2018-10-25 16:51:53 -05:00
Felix Stürmer c7effa5100
[InfraOps] Remove broken links to APM (#24568) (#24583) 2018-10-25 20:36:27 +02:00
Lisa Cawley 298680947c
[DOCS] Updates version info for 6.x branch (#24595) 2018-10-25 10:55:53 -07:00
Chris Roberson 2182e273e7
[Monitoring] Rename ccr fields based on changes in ES (#24519) (#24593)
* Rename ccr fields based on changes in ES

* More renames

* Update archive data

* Update snapshot

* Skip the api integration tests for now
2018-10-25 13:06:37 -04:00
Lisa Cawley 4c37443cbf [DOCS] Fixes broken links to Stack Overview (#24592) 2018-10-25 09:17:59 -07:00
Lisa Cawley a615cb408a [DOCS] Adds security for monitoring steps (#24052) 2018-10-25 08:13:43 -07:00
Josh Dover 81aae3f448
Disable unused beats_management tests (#24543) (#24544) 2018-10-25 09:09:19 -05:00
Leanid Shutau 204af32833
[Tools] Add "values" property validation (#22538) (#24573)
* [Tools] Add "values" property validation

* Fix values validation

* Fix typo in values regex

* Fix whitespaces handling

* Fix curly braces in regex

* Fix missing/unused values differentiation

* Use intl-messageformat-parser for parsing values from defaultMessage
2018-10-25 16:36:33 +03:00
Tim Roes 85e67d7b26
Preserve nested tables in table vis (#24377) (#24571)
* Add legacy response handler for table vis.

The new legacy response handler introduced a regression in how nested
tables were handled within table vis. This adds a new table-specific
response handler to ensure splitting is preserved.

This is a short term solution and will be removed once we are able to
update table splitting to be consistent with other vis types.

* Ensure formatted dates are preserved in table titles.

* Update legacy table response handler based on feedback.

* Ensure AggConfigResult.rawData is preserved in legacy table response handler.

* Move legacy table response handler to core_plugins.

* Legacy table response handler - style cleanup.

* Remove unneeded aggConfigResult.rawData from legacy table response handler.

* Add basic unit tests for legacy table response handler.

* In table vis, exclude split columns when showing metrics at all levels.

* Add functional tests
2018-10-25 15:04:22 +02:00
Robert Monfera 97995062d2
Fixes loading element icon color (#24551) (#24566)
* Fixed loading element icon color

* Fixed package.json

* Fixed loading component test

* Revert "Fixed package.json"

This reverts commit 033fc8477d.
2018-10-25 14:17:21 +02:00
Pete Harverson ab5a1d2c54
[ML] Edits to the text on the Data Visualizer landing pages (#24518) (#24547) 2018-10-25 08:05:45 +01:00
Caroline Horn d0c368de57
Added temporary hotfix for flyouts not in portals (#24515) (#24552)
…when the K7 header is turned on
2018-10-25 03:04:50 -04:00
Oliver Gupte 755f6b8cc1
[APM] Add contextual docs links for PropertiesTable with no data #22755 (#24181) (#24553)
* [APM] Add contextual docs links for PropertiesTable with no data #22755

* [APM] tweak style of table info header according to PR feedback #22755

* [APM] fix StickeyProperties style regression in ErrorGroupDetails

* [APM] update the layout of the StickeyProperties in ErrorDetails
2018-10-24 23:39:23 -07:00
CJ Cenizal 30d69b365b
[Rollups] Rollup support in Kibana, phase 1 (#21117) (#24554)
Enabled:
- View/Manage/Create rollup jobs

Disabled:
- Create a rollup index pattern
- Create rollup visualizations
- Add rollup visualizations to dashboards
- View raw rollup documents in Discover
2018-10-24 20:29:30 -07:00
James Gowdy 5041605782
[ML] Fix semi structured text last line issue (#24520) (#24536) 2018-10-25 04:25:54 +01:00
Catherine Liu aa55718e5e
Clears timeout for done handler (#24471) (#24537) 2018-10-24 19:22:49 -07:00
Catherine Liu 7cb035e371
Enable canvas functional tests (#24450) (#24549) 2018-10-24 19:22:25 -07:00
Catherine Liu 350f03d461
Fixes shape element with NaN viewBox (#24470) (#24548)
* Fixes shape viewbox calculations

* Fixed border

* Cleaned up viewbox calculations
2018-10-24 19:11:59 -07:00
CJ Cenizal c4534b6f2b
Introduce date histogram time base configuration to EditorConfig (#22344) (#24555)
* Add `default` and `baseInterval` configuration ability to date histogram EditorConfig
* Change EditorConfig `warning` to `help`, show `help` below date histogram and histogram interval inputs
2018-10-24 18:06:10 -07:00
Catherine Liu 68ade4a220
Switches to dashed border style (#24538) (#24539) 2018-10-24 16:01:03 -07:00
Bill McConaghy 855651f699
console: update documentation links for ingest node (#24535) (#24546) 2018-10-24 18:39:39 -04:00
Matt Bargar 5db29f5b10
Introduce query bar update button with dirty checking (#24529) (#24545)
Reintroduced submit button removed in the react migration of the query bar. Added dirty state indications.
2018-10-24 18:08:49 -04:00
Tim Roes a2ccf779ba
Fix courier issues causing showMetricsOnAllLevels to break (#24488) (#24530)
* Fix courier tabify caching issue

* Better code style

* Change to named lodash import

* Fix missing DSL parameters on hierarchical query

* Add functional test for hierarchical agg configs
2018-10-24 23:58:36 +02:00
CJ Cenizal 66a8307a1a
Add repositionOnScroll to popovers within the Inspector and the Index Management detail panel. (#23856) (#24514) 2018-10-24 14:49:22 -07:00
Ryan Keairns 9c0bb67e8f
[WIP] Adds 'upload data from file' to Kibana home page (#24226) (#24533)
* adds upload file and functionbeat to home

* removes functionbeat, adds ml file upload href

* remove functionbeat callout, add ml file url

* fix tests for basepath

* less caveman sounding

* update code editor snapshot

* make link conditional, copy changes

* update ml link

* move mlEnabled to ml plugin

* copy edits
2018-10-24 16:30:05 -05:00
Tim Sullivan 5858dd2ada
[Reporting/Fix] Improve text of pending status in job listing (#24300) (#24504)
* [Reporting/Fix] Improve text of pending status in job listing

* status message change from feedback
2018-10-24 14:01:14 -07:00
Tim Sullivan 4ccb343b29
[Reporting] queue.pollEnabled setting adds ability to disable polling for idle jobs (#24295) (#24505)
* [Reporting] New queue.pollEnabled setting adds ability to disable polling for idle jobs

* add an info log line

* note in docs
2018-10-24 14:01:01 -07:00
Matt Bargar 42017d5a97
Suggestion text needs to be a string (#24526) (#24540)
* suggestion text needs to be a string

* deduplicate after calling toUser since a string and object version of
the same query could both exist in the persisted log, resulting in
identical strings after toUser runs

* don't put empty strings in the recent search history
2018-10-24 16:54:34 -04:00
Walter Rafelsberger b616418b77
[ML] Improve sampling and normalization of population chart. (#24402) (#24508)
This optimizes how contextual data is fetched for the population analysis chart.
2018-10-24 21:56:48 +02:00
Caroline Horn 73e8260d3e
Remove wrapper around manage spaces button in menu (#24506) (#24525)
Fixes #23544
2018-10-24 15:51:08 -04:00
Felix Stürmer 7e251463fe
[6.x] [InfraOps] Add button to check again for log message if previously exhausted (#24500) (#24524)
Backports the following commits to 6.x:
 - [InfraOps] Add button to check again for log message if previously exhausted  (#24500)
2018-10-24 21:34:08 +02:00
Chris Roberson 8122f5e6db
[Monitoring] Add handles graph for beats (#24265) (#24522)
* Add handles graph

* Add limits in the UI

* Remove debug

* Update api tests

* Fix tests

* Fix snapshots

* Skip this test for now

* Fix this test and re-enable it
2018-10-24 15:23:57 -04:00
Marco Vettorello 876567a9b9
Fixes pie charts on empty time window (#24031) (#24516)
* Fix missing check on empty response

* Fix test order and remove applying on each entered filter

* Change quotes on addNewFilterAggregation testsubject

* Rename test hasPieChartError method to expectPieChartError

* Refactor piechart zero-value slices data cleaning.

The previous implementation used to remove zero-value slices by mutating the vis data from the legend logic.
We moved the logic of "cleaning" the zero-value slices before rendering the piechart and/or the legend, so now piechart and legends are rendering themselves with the same data structure.

* Reverting _validatePieData method to the old one
2018-10-24 21:20:47 +02:00
Jason Rhodes 6d45d2bfa8
Adds beta messages to traces overview and timeline (#24447) (#24512)
* Adds beta messages to traces overview and timeline

* Left over formatting fix

* Fixes bug with inaccurate types for transaction.context.system

* Updates TraceLink to be called TransactionLink more accurately

* Updated learn more about DT link

* Snapshot update for number format change

* Updates to asDecimal to preserve decimal place significance in service list
2018-10-24 14:15:19 -04:00