- Moves all DOM manipulation to a ref callback for the ChartTooltip react component. The service mlChartTooltipService no longer touches the DOM, it just passed around data and triggers the chartTooltip$ observable which the ChartTooltip is subscribed to. The code infers positioning now from the tooltips parent element and we no longer rely on hard-coded Kibana classnames. Besides that the code to determine the position remains the same (with some offset tweaking).
- The mocha tests for mlChartTooltipService have been migrated to jest.
* We have a NP plugin! :celebration:
* Redirecting to login on all 401s
* Adding commented out code for when credentials are omitted
* Fixing types
* Respond 403 when user changes password with incorrect current password
* Adding AnonymousPaths where we ignore all 401s
* Adding anonymous path tests
* Extracted a dedicated SessionExpires class and added tests
* Fixing plugin after refactoring to add SessionExpired
* Beginning to work on the session timeout interceptor
* Fixing UnauthorizedResponseInterceptor anonymous path test
* Removing test anonymous path
* Trying to improve readability
* Displaying session logout warning
* Mocking out the base path
* Revert "Mocking out the base path"
This reverts commit 824086c168.
* Changing coreMock to use a concrete instance of BasePath
* Adding session timeout interceptor tests
* Adding session timeout tests
* Adding more tests for short session timeouts
* Moving some files to a session folder
* More thrashing around: renaming and reorganizing
* Renaming Interceptor to HttpInterceptor
* Fixing some type errors
* Fixing legacy chrome API tests
* Fixing other tests to use the concrete instance of BasePath
* Adjusting some types
* Putting DeeplyMocked back, I don't get how DeeplyMockedKeys works
* Moving anonymousPaths to public core http
* Reading sessionTimeout from injected vars and supporting null timeout
* Doesn't extend session when there is no response
* Updating docs and snapshots
* Casting sessionTimeout injectedVar to "number | null"
* Fixing i18n issues
* Update x-pack/plugins/security/public/plugin.ts
Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
* Adding milliseconds postfix to SessionTimeout private fields
* Even better anonymous paths, with some validation
* Adjusting public method docs for IAnonymousPaths
* Adjusting spelling of base-path to basePath
* Update x-pack/plugins/security/public/session/session_timeout.tsx
Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>
* Update src/core/public/http/anonymous_paths.ts
Co-Authored-By: Josh Dover <me@joshdover.com>
* Update src/core/public/http/anonymous_paths.ts
Co-Authored-By: Josh Dover <me@joshdover.com>
* AnonymousPaths implements IAnonymousPaths and uses IBasePath
* Removing DeeplyMocked
* Removing TODOs
* Fixing types...
* Now, ever more normal
* Update dependency del to v5
* unify del/rimraf usage with del v5
* update yarn.lock
* update kbn-pm distributable
* remove poorly transformed code
* force some deletes from tmp
* mock less of the fs module
* force tmp deletion in a few more suites
* please make this the last force
* [APM] Refactor & scope aggregation types
Iterate on the APM aggregation types, make them more readable and explicitly scope them as APM-specific.
ES typings:
- Refactored aggregation types (mostly better naming, slightly less hacks)
- Do not add APM typings to `elasticsearch` module to explicitly scope them as APM specific
- Make restTotalHitsAsInt a type option rather than a separate type
- `terms` bucket key type now accounts for the fact it can be both number and string
`mergeProjection`:
- Type check arguments for compatibility with ESSearchRequest
- Require valid aggregation objects in source parameter. Seems less brittle, and surfaces errors closer to the source
Other changes:
- Sort options in some cases need `as const`, type casts or type guards
- Simplify types for metric aggregations
* Add type casts for bucket keys in remaining places
* Review feedback
* follow redirects when downloading node.js
* always download node to test redirects
* pass -L in non-windows block too
* Revert "always download node to test redirects"
This reverts commit 36dfe8b80a.
* First version of change view functionality
* Adds the 'replace view' functionality to dashboard edit mode
* Fixed type_check errors
* Make action part of dashboard_embeddable_container
* Fixed import paths for type check errors
* Fixed i18n errors
* Renamed action to 'Replace panel' and adjusted jest tests to pass type check
* test: add functional tests
Closes#43900
* Move sourceIndex fields check from flyout open to source index selection
* reset sourceIndex checks when switching job type. add helpful text for no field options for regression
* update types. use FormattedMessages
* use comboBox options format to store sourceIndex title/id in one place
* small refactors and remove loadIndexPatterns from resolver
* refactor destinationIndexPatternTitleExists checks in reducer
- Updated internal permissions docs.
- Fixes regression to change data_frame to transform for privileges.
- Fixes error messages for wizard source table. An error triggered by Elasticsearch would not properly be passed through, just a generic JS error would be reported. Now the error for both source table and pivot preview get passed through.
- Fixes correctly reporting an error if the wizard fails to create the transform, previously a success toast would show in any case.
- The screenshot below also shows the fix for #46434: A snipped of the full error message is now shown within the toast.
* Add error when there is no histogram agg when using parent pipeline
* Update error message
* Update message
* Add vis title to state
* Revert unrelated changes
* Update vis title when vis is renamed
* Update title in url when renaming
