Tyler Smalley
baf56d80c4
[7.x] Updating the License ( #88343 ) ( #88745 )
...
* Updating the Licenses, except for applying eslint, building
* Applying ESLint rules,building @kbn/pm, regenerating api docs
Co-authored-by: kobelb <brandon.kobel@elastic.co>
2021-01-19 17:54:11 -08:00
Mikhail Shustov
5bb0186c15
Remove dynamic mapped types from UiActions ( #87075 ) ( #87274 )
...
* Remove dynamic mapped types from UiActions
* Remove import between data <-> embeddables
* remove outdated comments, export action types from discover_enhanced
* fix notice.txt
Co-authored-by: restrry <restrry@gmail.com>
Co-authored-by: Josh Dover <me@joshdover.com>
2021-01-05 13:27:11 +01:00
Mikhail Shustov
e8a05ae57b
Add TS projects for src/plugins & x-pack/plugins ( #78440 ) ( #78946 )
...
* bump query-string version to remove manual type definitions
* remove manual type declaration
* add kibana_utils tsconfig
* add refs to kibana_utils tsconfig
* add kibana_utils to the project list
* add kibana_react project
* add support for x-pack/tsconfig.refs.json
* add ts project for x-pack licensing plugins
* add glob for ts projects in src/plugins & x-pack/plugins
* add refs to projects in examples
* fix ref paths in x-pack/test
* address mistic comments
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
# src/plugins/kibana_utils/kibana.json
2020-09-30 17:10:04 +02:00
Mikhail Shustov
ee8bc62637
Extract src/core in a separate TS project ( #76785 ) ( #77509 )
...
* break dependency on data plugin TS code
* move global typings to @kbn/utility-types
* import types from @kbn/utility-types
* remove type dependency on plugins
* add intermediate js files to break dependency on outter TS code
* temp type declaration for query-string
* declare src/core project
* export types to reference in the built d.ts files
* reference core project
* move jest types out of kbn/utility-types due to a clash with mocha types
* fix wrong es_kuery path and ts project paths
* reference core from packages consuming it
* x-pack & oss should use the same lodash version
* Revert "x-pack & oss should use the same lodash version"
This reverts commit 79cec5781e
2020-09-16 07:51:42 +02:00
Mikhail Shustov
bd66fab861
Introduce TS incremental builds & move src/test_utils to TS project ( #76082 ) ( #76632 )
...
* move test_helpers to the core
* create base tsconfig
* all tsconfigs use the base one
* use test_helpers exposed from the src/core
* move getFieldFormatsRegistry to data plugin
* add test_utils project
* compile types after checkout
* add a stub for platform tsconfig.json
* fix broken import
* fix broken path to the base config
* set tsBuildInfoFile for project without outDir
* do not commit tsbuildinfo file
* do not check output d.ts files
* fix type error
* use separate config to build types
* rollback changes to include paths
* mute import zone error
* rename files to avoid references to tsd
* do not use tsd for type tests
* include all ts files in project
* run buildRefs before type check to ensure the latest version
* store tsbuildinfo locally
* update paths to base config
* comment out core/tsconfig.json
* remove ui path
* fix wrong tsbuildinfo path
2020-09-03 23:02:05 +02:00
spalger
e535aa6446
Revert "Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 ) ( #71355 )" ( #71382 )"
...
This reverts commit c45fa3dd58
2020-07-10 20:13:28 -07:00
Brian Seeders
c45fa3dd58
Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 ) ( #71355 )" ( #71382 )
...
This reverts commit 243a864359
2020-07-10 23:07:01 -04:00
Spencer
243a864359
[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 ) ( #71355 )
...
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
# packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
# src/plugins/embeddable/kibana.json
# src/plugins/telemetry/kibana.json
# src/plugins/ui_actions/kibana.json
# x-pack/plugins/apm/kibana.json
# x-pack/plugins/upgrade_assistant/kibana.json
2020-07-10 09:37:22 -07:00
Stacey Gammon
edd9af0b16
more propagated bad examples ( #66920 ) ( #67012 )
2020-05-19 13:32:53 -04:00
Stacey Gammon
2901b93157
KP plugins shouldn't need package.json ( #66654 ) ( #66745 )
...
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-05-15 14:24:33 -04:00
Vadim Dalecky
62a947c535
Drilldowns ( #61219 ) ( #65087 )
...
* Add drilldown wizard components
* Dynamic actions (#58216 )
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡ ️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638 )
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653 )
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823 )
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834 )
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854 )
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876 )
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885 )
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938 )
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977 )
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099 )
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103 )
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104 )
* Drilldowns review 1 (#60139 )
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264 )
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336 )
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339 )
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357 )
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309 )
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371 )
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510 )
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
* fix: 🐛 pass in uiActions to visualize_embeddable
* fix: 🐛 correctly register action
* fix: 🐛 fix type error
* chore: 🤖 remove unused translations
* Dynamic actions to xpack (#62647 )
* feat: 🎸 set up sample action factory provider
* feat: 🎸 create dashboard_enhanced plugin
* feat: 🎸 add EnhancedEmbeddable interface
* refactor: 💡 move DynamicActionManager to x-pack
* feat: 🎸 connect dynamic action manager to embeddable life-cycle
* test: 💍 fix Jest tests after refactor
* fix: 🐛 fix type error
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* refactor: 💡 move action factories to x-pack (#63190 )
* refactor: 💡 move action factories to x-pack
* fix: 🐛 use correct plugin embeddable deps
* test: 💍 fix Jest test after refactor
* chore: 🤖 remove kibana.yml flag (#62441 )
* Panel top right (#63466 )
* feat: 🎸 add PANEL_NOTIFICATION_TRIGGER
* feat: 🎸 add PanelNotificationsAction action
* test: 💍 add PanelNotificationsAction unit tests
* refactor: 💡 revert addTriggerAction() change
* style: 💄 remove unused import
* fix: 🐛 fix typecheck errors after merge
* support getHref in drilldowns (#63727 )
* chore: 🤖 remove ui_actions storybook config
* update docs
* fix ts
* fix: 🐛 fix broken merge
* [Drilldowns] Dashboard to dashboard drilldown (#63108 )
* partial progress on async loading / searching of dashboard titles
* feat: 🎸 make combobox full width
* filtering combobox polish
* storybook fix
* implement navigating to dashboard, seems like a type problem
* try navToApp
* filter out current dashboard
* rough draft linking to a dashboard
* remove note
* typefix
* fix navigation from dashboard to dashboard
except for back button - that would be addressed separatly
* partial progress getting filters from action data
* fix issue with getIndexPatterns undefined
we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull
* fix filter / time passing into url
* typefix
* dashboard to dashboard drilldown functional test and back button fix
* documentation update
* chore clean-ups
fix type
* basic unit test for dashboard drilldown
* remove test todos
decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env
* remove config
* improve back button with filter comparison tweak
* dashboard filters/date option off by default
* revert change to config/kibana.yml
* remove unneeded comments
* use default time range as appropriate
* fix type, add filter icon, add text
* fix test
* change how time range is restored and improve back button for drilldowns
* resolve conflicts
* fix async compile issue
* remove redundant test
* wip
* wip
* fix
* temp skip tests
* fix
* handle missing dashboard edge case
* fix api
* refactor action filter creation utils
* updating
* updating docs
* improve
* fix storybook
* post merge fixes
* fix payload emitted in brush event
* properly export createRange action
* improve tests
* add test
* post merge fixes
* improve
* fix
* improve
* fix build
* wip getHref support
* implement getHref()
* give proper name to a story
* use sync start services
* update text
* fix types
* fix ts
* fix docs
* move clone below drilldowns (near replace)
* remove redundant comments
* refactor action filter creation utils
* updating
* updating docs
* fix payload emitted in brush event
* properly export createRange action
* some more updates
* fixing types
* ...
* inline EventData
* fix typescript in lens and update docs
* improve filters types
* docs
* merge
* @mdefazio review
* adjust actions order
* docs
* @stacey-gammon review
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
* fix docs
* nit fixes
* chore: 🤖 remove uiActions from Embeddable dependencies
* chore: 🤖 don't export ActionInternal from ui_actions
* test: 💍 remove uiActions deps in x-pack test mocks
* chore: 🤖 cleanup ui_actions types
* docs: ✏️ add JSDoc comment to addTriggerAction()
* docs: ✏️ regenerate docs
* Drilldown demo 2 (#64300 )
* chore: 🤖 add example of Discover drilldown to sample plugin
* fix: 🐛 show drilldowns with higher "order" first
* feat: 🎸 add createStartServicesGetter() to /public kibana_util
* feat: 🎸 load index patterns in Discover drilldown
* feat: 🎸 add toggle for index pattern selection
* feat: 🎸 add spacer to separate unrelated config fields
* fix: 🐛 correctly configre setup core
* feat: 🎸 navigate to correct index pattern
* chore: 🤖 fix type check errors
* fix: 🐛 make index pattern select full width
* fix: 🐛 add getHref support
* feat: 🎸 add example plugin ability to X-Pack
* refactor: 💡 move Discover drilldown example to X-Pack
* feat: 🎸 add dashboard-to-url drilldown example
* feat: 🎸 add new tab support for URL drilldown
* feat: 🎸 add "hello world" drilldown example
* docs: ✏️ add README
* feat: 🎸 add getHref support
* chore: 🤖 cleanup after moving examples to X-Pack
* docs: ✏️ add to README.md info on how to find drilldowns
* feat: 🎸 store events in .enhancements field
* docs: ✏️ add comment to range trigger title
* refactor: 💡 move Configurable interface into kibana_utils
* chore: 🤖 simplify internal component types
* refactor: 💡 move registerDrilldwon() to advanced_ui_actions
* test: 💍 update functional test data
* merge
* docs: ✏️ make drilldown enhancement comment more general
* fix: 🐛 return public type from registerAction() call
* docs: ✏️ add comment to value click trigger title field
* docs: ✏️ improve comment
* fix: 🐛 use second argument of CollectConfigProps interface
* fix: 🐛 add workaround for Firefox rendering issue
See:
https://github.com/elastic/kibana/pull/61219/#pullrequestreview-402903330
* chore: 🤖 delete unused file
* fix: 🐛 import type from new location
* style: 💄 make generic type variable name sconsistent
* fix: 🐛 show "Create drilldown" only on dashboard
* test: 💍 add extra unit test for root embeddable type
* docs: ✏️ update generated docs
* chore: 🤖 add example warnings to sample drilldowns
* docs: ✏️ add links to example warnings
* feat: 🎸 add URL drilldown validation and https:// prefixing
* fix: 🐛 disable drilldowns for lens
* refactor: 💡 remove PlaceContext from DrilldownDefinition
* fix: 🐛 fix type check error
* feat: 🎸 show warning message if embeddable not provided
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
# Conflicts:
# .github/CODEOWNERS
2020-05-04 18:20:37 +02:00
Spencer
63a2d4433b
[7.x] update typescript version in all packages to avoid warni… ( #59816 )
...
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-03-10 13:57:24 -07:00
Stacey Gammon
60f6131d45
Further improve type checking for actions and triggers ( #58765 ) ( #59319 )
...
* wip
* review follow up
* make ACTION a prefix, not SUFFIX
* fix path
* add warnings about casting to ActionType
* Make context an object in examples, not a string
* require object context, which seems to fix the partial requirement in type and thus the type issue
* mistake
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-03-05 08:38:27 -05:00
Stacey Gammon
f0eaad05d7
Improve action and trigger types ( #58657 ) ( #58909 )
...
* Improve types so emitting the wrong context shape complains, as does using a trigger id that has not been added to the trigger context mapping.
* remove unneccessary code
2020-02-28 16:40:10 -05:00
Vadim Dalecky
7d2b8d9ffc
Local actions ( #57451 ) ( #57805 )
...
* feat: 🎸 create UiActionsService
* feat: 🎸 add UiActionsServvice.fork() method
* feat: 🎸 instantiate UiActionsService in plugin
* feat: 🎸 add UiActionsService.registerTrigger(), remove old
* feat: 🎸 move attach/detachAction() methods to UiActionsService
* refactor: 💡 move remaining actions API to UiActionsService
* chore: 🤖 clean up /trigger folder
* test: 💍 move registry tests into UiActiosnService tests
* fix: 🐛 fix TypeScript typecheck errors
* test: 💍 add .fork() trigger tests
* feat: 🎸 remove actionIds from ui_actions Trigger interface
* fix: 🐛 remove usage of actionIds
* fix: 🐛 attach hello world action to trigger in plugin lifecycle
* feat: 🎸 fork also trigger to action attachments
* fix: 🐛 clear mapping registry in .clear(), improve type
2020-02-17 16:57:44 +01:00
Stacey Gammon
1358b90630
Ui Actions explorer example ( #57006 ) ( #57315 )
...
* wip
* Move action registration out of AppMountContext fn
* Move all registration to setup
* Fix type error
2020-02-11 12:01:37 -05:00
