Joe Reuter
dfa0c67f3b
Kibana app and presentation ts projects ( #87639 ) ( #88035 )
2021-01-13 11:53:40 +01:00
Luke Elmers
620f5326ca
App Services: Remove remaining uiActions, expressions, data, embeddable circular dependencies. ( #82791 ) ( #86608 )
...
* Move applyFilter, selectRange, valueClick triggers to data/embeddables.
* Update imports.
* Remove embeddable references to non-existent data plugin dependency.
* remove data mocks from embeddable
* Remove query, filters, timeRange from EmbeddableInput and move to apps.
* Remove data plugin imports from embeddable test samples.
* Remove circular dependencies caused by expressions renderer handlers.
* Update circular deps allowList.
* Remove data dependency on embeddable.
* Revert accidental data plugin change.
* Fix new circular deps issues.
* Update generated docs.
* Fix type errors in vis_type_xy
* Fix inspector data table.
2020-12-20 15:53:54 -07:00
Anton Dosov
aec05c49a8
Use saved object references for dashboard drilldowns ( #82602 ) ( #83293 )
2020-11-12 18:05:14 +01:00
Vadim Dalecky
432e60e63d
Drilldowns in examples ( #75640 ) ( #79623 )
...
* feat: 🎸 add telemetry for in-chart "Explore underlying data"
* feat: 🎸 add telemetry for in-chart "Explore underlying data"
* refactor: 💡 move all drilldowns into a sub-folder
* feat: 🎸 setup example app section for ui_actions_enhanced
* feat: 🎸 set up Drilldown Manager section
* feat: 🎸 open drilldown manager from example plugin
* refactor: 💡 rename supportedTriggers -> triggers prop
* feat: 🎸 show dev warning if triggers prop is empty
* refactor: 💡 rename "supportedTriggers" -> "triggers" props
* feat: 🎸 open and close drilldown manager from example plugin
* feat: 🎸 add sample ML job trigger
* feat: 🎸 add sample ML URL drilldown
* refactor: 💡 move KibanaURL to share plugin
* refactor: 💡 add index file to ml drilldown
* feat: 🎸 add AbstractDashboardDrilldown
* refactor: 💡 make dashboard drilldown use abstract drilldown
* refactor: 💡 rename dashboard drilldown to embeddable drilldown
* feat: 🎸 add Dashboard drilldown to sample plugin
* feat: 🎸 open dashboard drilldown in list view
* feat: 🎸 add drilldown execute button
* refactor: 💡 move drilldown React hooks into /hooks folder
* test: 💍 fix tests after renaming triggers
* chore: 🤖 populate "requireBundles"
* fix: 🐛 fix TypeScript errors
* fix: 🐛 fix Kibana plugin dependency
* chore: 🤖 remoe unused import
* feat: 🎸 persist drilldown manager state across app navigations
* refactor: 💡 move no-embeddable example into a seprate file
* feat: 🎸 set up example with embeddable
* feat: 🎸 improve embeddable example
* refactor: 💡 rename without embeddable example
* feat: 🎸 set up no-embeddable single click example
* feat: 🎸 add dashboard drilldown to single button example
* fix: 🐛 remove unused margin
* fix: 🐛 make "Get more actions" translation static
* chore: 🤖 remove old dashboard drilldown definition
* refactor: 💡 rename samples to generic names
* refactor: 💡 make app 1 example drilldown "hello world"
* chore: 🤖 remove unused required bundle
* chore: 🤖 add dashboardEnhanced back
* [kbn/optimizer] only build xpack examples when building xpack plugins
* move alerting_example into x-pack/examples
* remove filter for alertingExample plugin in oss plugins CI step
* revert unrelated change
* fix: 🐛 use correct prop name
* test: 💍 fix embeddable-to-dashboard drilldown mock
* test: 💍 fix a test after refactor
* chore: 🤖 remove unused import
* chore: 🤖 add dashboard_enahcned to example plugin
* chore: 🤖 address review comments
* feat: 🎸 add description to UI Actions Enhanced examples
* docs: ✏️ improve docs of example plugin
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-06 13:03:16 +02:00
Anton Dosov
8d69dd625f
Use "Apply_filter_trigger" in dashboard drilldown ( #71468 ) ( #73780 )
...
* attach dashboard drilldown to apply filter trigger
* fix types
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
# src/plugins/data/public/public.api.md
2020-07-30 14:00:41 +02:00
spalger
e535aa6446
Revert "Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 ) ( #71355 )" ( #71382 )"
...
This reverts commit c45fa3dd58
.
2020-07-10 20:13:28 -07:00
Brian Seeders
c45fa3dd58
Revert "[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 ) ( #71355 )" ( #71382 )
...
This reverts commit 243a864359
.
2020-07-10 23:07:01 -04:00
Spencer
243a864359
[7.x] [kbn/optimizer] implement "requiredBundles" property of KP plugins ( #70911 ) ( #71355 )
...
Co-authored-by: Josh Dover <me@joshdover.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
# packages/kbn-optimizer/src/integration_tests/__snapshots__/basic_optimization.test.ts.snap
# src/plugins/embeddable/kibana.json
# src/plugins/telemetry/kibana.json
# src/plugins/ui_actions/kibana.json
# x-pack/plugins/apm/kibana.json
# x-pack/plugins/upgrade_assistant/kibana.json
2020-07-10 09:37:22 -07:00
Anton Dosov
51c900d2df
[refactor] remove drilldown plugin, move components to uiActionsEnhanced ( #69403 ) ( #69509 )
...
* refactor: remove drilldown plugin by moving components to uiActionsEnhanced
* fix
* fix mistake in test
* fix i18n
2020-06-18 18:11:15 +02:00
Vadim Dalecky
223827963a
advanced_ui_actions 👉 ui_actions_enhanced ( #68258 ) ( #68364 )
...
* chore: 🤖 rename advanced_ui_actions to ui_actions_enhanced
* chore: 🤖 rename exported interface to "enhanced"
2020-06-05 16:41:16 +02:00
Vadim Dalecky
62a947c535
Drilldowns ( #61219 ) ( #65087 )
...
* Add drilldown wizard components
* Dynamic actions (#58216 )
* feat: 🎸 add DynamicAction and FactoryAction types
* feat: 🎸 add Mutable<T> type to @kbn/utility-types
* feat: 🎸 add ActionInternal and ActionContract
* chore: 🤖 remove unused file
* feat: 🎸 improve action interfaces
* docs: ✏️ add JSDocs
* feat: 🎸 simplify ui_actions interfaces
* fix: 🐛 fix TypeScript types
* feat: 🎸 add AbstractPresentable interface
* feat: 🎸 add AbstractConfigurable interface
* feat: 🎸 use AbstractPresentable in ActionInternal
* test: 💍 fix ui_actions Jest tests
* feat: 🎸 add state container to action
* perf: ⚡ ️ convert MenuItem to React component on Action instance
* refactor: 💡 rename AbsractPresentable -> Presentable
* refactor: 💡 rename AbstractConfigurable -> Configurable
* feat: 🎸 add Storybook to ui_actions
* feat: 🎸 add <ErrorConfigureAction> component
* feat: 🎸 improve <ConfigureAction> component
* chore: 🤖 use .story file extension prefix for Storybook
* feat: 🎸 improve <ErrorConfigureAction> component
* feat: 🎸 show error if dynamic action has CollectConfig missing
* feat: 🎸 render sample action configuration component
* feat: 🎸 connect action config to <ConfigureAction>
* feat: 🎸 improve <ConfigureAction> stories
* test: 💍 add ActionInternal serialize/deserialize tests
* feat: 🎸 add ActionContract
* feat: 🎸 split action Context into Execution and Presentation
* fix: 🐛 fix TypeScript error
* refactor: 💡 extract state container hooks to module scope
* docs: ✏️ fix typos
* chore: 🤖 remove Mutable<t> type
* test: 💍 don't cast to any getActions() function
* style: 💄 avoid using unnecessary types
* chore: 🤖 address PR review comments
* chore: 🤖 rename ActionContext generic
* chore: 🤖 remove order from state container
* chore: 🤖 remove deprecation notice on getHref
* test: 💍 fix tests after order field change
* remove comments
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Drilldown context menu (#59638 )
* fix: 🐛 fix TypeScript error
* feat: 🎸 add CONTEXT_MENU_DRILLDOWNS_TRIGGER trigger
* fix: 🐛 correctly order context menu items
* fix: 🐛 set correct order on drilldown flyout actions
* fix: 🐛 clean up context menu building functions
* feat: 🎸 add context menu separator action
* Add basic ActionFactoryService. Pass data from it into components instead of mocks
* Dashboard x pack (#59653 )
* feat: 🎸 add dashboard_enhanced plugin to x-pack
* feat: 🎸 improve context menu separator
* feat: 🎸 move drilldown flyout actions to dashboard_enhanced
* fix: 🐛 fix exports from ui_actions plugin
* feat: 🎸 "implement" registerDrilldown() method
* fix ConfigurableBaseConfig type
* Implement connected flyout_manage_drilldowns component
* Simplify connected flyout manage drilldowns component. Remove intermediate component
* clean up data-testid workaround in new components
* Connect welcome message to storage
Not sure, but use LocalStorage. Didn’t find a way to persist user settings. looks like uiSettings are not user scoped.
* require `context` in Presentable. drill context down through wizard components
* Drilldown factory (#59823 )
* refactor: 💡 import storage interface from ui_actions plugin
* refactor: 💡 make actions not-dynamic
* feat: 🎸 fix TypeScript errors, reshuffle types and code
* fix: 🐛 fix more TypeScript errors
* fix: 🐛 fix TypeScript import error
* Drilldown registration (#59834 )
* feat: 🎸 improve drilldown registration method
* fix: 🐛 set up translations for dashboard_enhanced plugin
* Drilldown events 3 (#59854 )
* feat: 🎸 add serialize/unserialize to action
* feat: 🎸 pass in uiActions service into Embeddable
* feat: 🎸 merge ui_actions oss and basic plugins
* refactor: 💡 move action factory registry to OSS
* fix: 🐛 fix TypeScript errors
* Drilldown events 4 (#59876 )
* feat: 🎸 mock sample drilldown execute methods
* feat: 🎸 add .dynamicActions manager to Embeddable
* feat: 🎸 add first version of dynamic action manager
* Drilldown events 5 (#59885 )
* feat: 🎸 display drilldowns in context menu only on one embed
* feat: 🎸 clear dynamic actions from registry when embed unloads
* fix: 🐛 fix OSS TypeScript errors
* basic integration of components with dynamicActionManager
* fix: 🐛 don't overwrite explicitInput with combined input (#59938 )
* display drilldown count in embeddable edit mode
* display drilldown count in embeddable edit mode
* improve wizard components. more tests.
* partial progress, dashboard drilldowns (#59977 )
* partial progress, dashboard drilldowns
* partial progress, dashboard drilldowns
* feat: 🎸 improve dashboard drilldown setup
* feat: 🎸 wire in services into dashboard drilldown
* chore: 🤖 add Storybook to dashboard_enhanced
* feat: 🎸 create presentational <DashboardDrilldownConfig>
* test: 💍 add <DashboardDrilldownConfig> stories
* test: 💍 use presentation dashboar config component
* feat: 🎸 wire in services into React component
* docs: ✏️ add README to /components folder
* feat: 🎸 increase importance of Dashboard drilldown
* feat: 🎸 improve icon definition in drilldowns
* chore: 🤖 remove unnecessary comment
* chore: 🤖 add todos
Co-authored-by: streamich <streamich@gmail.com>
* Manage drilldowns toasts. Add basic error handling.
* support order in action factory selector
* fix column order in manage drilldowns list
* remove accidental debug info
* bunch of nit ui fixes
* Drilldowns reactive action manager (#60099 )
* feat: 🎸 improve isConfigValid return type
* feat: 🎸 make DynamicActionManager reactive
* docs: ✏️ add JSDocs to public mehtods of DynamicActionManager
* feat: 🎸 make panel top-right corner number badge reactive
* fix: 🐛 correctly await for .deleteEvents()
* Drilldowns various 2 (#60103 )
* chore: 🤖 address review comments
* test: 💍 fix embeddable_panel.test.tsx tests
* chore: 🤖 clean up ActionInternal
* chore: 🤖 make isConfigValid a simple predicate
* chore: 🤖 fix TypeScript type errors
* test: 💍 stub DynamicActionManager tests (#60104 )
* Drilldowns review 1 (#60139 )
* refactor: 💡 improve generic types
* fix: 🐛 don't overwrite icon
* fix: 🐛 fix x-pack TypeScript errors
* fix: 🐛 fix TypeScript error
* fix: 🐛 correct merge
* Drilldowns various 4 (#60264 )
* feat: 🎸 hide "Create drilldown" from context menu when needed
* style: 💄 remove AnyDrilldown type
* feat: 🎸 add drilldown factory context
* chore: 🤖 remove sample drilldown
* fix: 🐛 increase spacing between action factory picker
* workaround issue with closing flyout when navigating away
Adds overlay just like other flyouts which makes this defect harder to bump in
* fix react key issue in action_wizard
* don’t open 2 flyouts
* fix action order
https://github.com/elastic/kibana/issues/60138
* Drilldowns reload stored (#60336 )
* style: 💄 don't use double equals __
* feat: 🎸 add reload$ to ActionStorage interface
* feat: 🎸 add reload$ to embeddable event storage
* feat: 🎸 add storage syncing to DynamicActionManager
* refactor: 💡 use state from DynamicActionManager in React
* fix: 🐛 add check for manager being stopped
* Drilldowns triggers (#60339 )
* feat: 🎸 make use of supportedTriggers()
* feat: 🎸 pass in context to configuration component
* feat: 🎸 augment factory context
* fix: 🐛 stop infinite re-rendering
* Drilldowns multitrigger (#60357 )
* feat: 🎸 add support for multiple triggers
* feat: 🎸 enable Drilldowns for TSVB
Although TSVB brushing event is now broken on master, KibanaApp plans to
fix it in 7.7
* "Create drilldown" flyout - design cleanup (#60309 )
* create drilldown flyout cleanup
* remove border from selectedActionFactoryContainer
* adjust callout in DrilldownHello
* update form labels
* remove unused file
* fix type error
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
* basic unit tests for flyout_create_drildown action
* Drilldowns finalize (#60371 )
* fix: 🐛 align flyout content to left side
* fix: 🐛 move context menu item number 1px lower
* fix: 🐛 move flyout back nav chevron up
* fix: 🐛 fix type check after refactor
* basic unit tests for drilldown actions
* Drilldowns finalize 2 (#60510 )
* test: 💍 fix test mock
* chore: 🤖 remove unused UiActionsService methods
* refactor: 💡 cleanup UiActionsService action registration
* fix: 🐛 add missing functionality after refactor
* test: 💍 add action factory tests
* test: 💍 add DynamicActionManager tests
* feat: 🎸 capture error if it happens during initial load
* fix: 🐛 register correctly CSV action
* feat: 🎸 don't show "OPTIONS" title on drilldown context menus
* feat: 🎸 add server-side for x-pack dashboard plugin
* feat: 🎸 disable Drilldowns for TSVB
* feat: 🎸 enable drilldowns on kibana.yml feature flag
* feat: 🎸 add feature flag comment to kibana.yml
* feat: 🎸 remove places from drilldown interface
* refactor: 💡 remove place in factory context
* chore: 🤖 remove doExecute
* remove not needed now error_configure_action component
* remove workaround for storybook
* feat: 🎸 improve DrilldownDefinition interface
* style: 💄 replace any by unknown
* chore: 🤖 remove any
* chore: 🤖 make isConfigValid return type a boolean
* refactor: 💡 move getDisplayName to factory, remove deprecated
* style: 💄 remove any
* feat: 🎸 improve ActionFactoryDefinition
* refactor: 💡 change visualize_embeddable params
* feat: 🎸 add dashboard dependency to dashboard_enhanced
* style: 💄 rename drilldown plugin life-cycle contracts
* refactor: 💡 do naming adjustments for dashboard drilldown
* fix: 🐛 fix Type error
* fix: 🐛 fix TypeScript type errors
* test: 💍 fix test after refactor
* refactor: 💡 rename context -> placeContext in React component
* chore: 🤖 remove setting from kibana.yml
* refactor: 💡 change return type of getAction as per review
* remove custom css per review
* refactor: 💡 rename drilldownCount to eventCount
* style: 💄 remove any
* refactor: 💡 change how uiActions are passed to vis embeddable
* style: 💄 remove unused import
* fix: 🐛 pass in uiActions to visualize_embeddable
* fix: 🐛 correctly register action
* fix: 🐛 fix type error
* chore: 🤖 remove unused translations
* Dynamic actions to xpack (#62647 )
* feat: 🎸 set up sample action factory provider
* feat: 🎸 create dashboard_enhanced plugin
* feat: 🎸 add EnhancedEmbeddable interface
* refactor: 💡 move DynamicActionManager to x-pack
* feat: 🎸 connect dynamic action manager to embeddable life-cycle
* test: 💍 fix Jest tests after refactor
* fix: 🐛 fix type error
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* refactor: 💡 move action factories to x-pack (#63190 )
* refactor: 💡 move action factories to x-pack
* fix: 🐛 use correct plugin embeddable deps
* test: 💍 fix Jest test after refactor
* chore: 🤖 remove kibana.yml flag (#62441 )
* Panel top right (#63466 )
* feat: 🎸 add PANEL_NOTIFICATION_TRIGGER
* feat: 🎸 add PanelNotificationsAction action
* test: 💍 add PanelNotificationsAction unit tests
* refactor: 💡 revert addTriggerAction() change
* style: 💄 remove unused import
* fix: 🐛 fix typecheck errors after merge
* support getHref in drilldowns (#63727 )
* chore: 🤖 remove ui_actions storybook config
* update docs
* fix ts
* fix: 🐛 fix broken merge
* [Drilldowns] Dashboard to dashboard drilldown (#63108 )
* partial progress on async loading / searching of dashboard titles
* feat: 🎸 make combobox full width
* filtering combobox polish
* storybook fix
* implement navigating to dashboard, seems like a type problem
* try navToApp
* filter out current dashboard
* rough draft linking to a dashboard
* remove note
* typefix
* fix navigation from dashboard to dashboard
except for back button - that would be addressed separatly
* partial progress getting filters from action data
* fix issue with getIndexPatterns undefined
we can’t import those functions as static functions, instead we have to expose them on plugin contract because they are statefull
* fix filter / time passing into url
* typefix
* dashboard to dashboard drilldown functional test and back button fix
* documentation update
* chore clean-ups
fix type
* basic unit test for dashboard drilldown
* remove test todos
decided to skip those tests because not clear how to test due to EuiCombobox is using react-virtualized and options list is not rendered in jsdom env
* remove config
* improve back button with filter comparison tweak
* dashboard filters/date option off by default
* revert change to config/kibana.yml
* remove unneeded comments
* use default time range as appropriate
* fix type, add filter icon, add text
* fix test
* change how time range is restored and improve back button for drilldowns
* resolve conflicts
* fix async compile issue
* remove redundant test
* wip
* wip
* fix
* temp skip tests
* fix
* handle missing dashboard edge case
* fix api
* refactor action filter creation utils
* updating
* updating docs
* improve
* fix storybook
* post merge fixes
* fix payload emitted in brush event
* properly export createRange action
* improve tests
* add test
* post merge fixes
* improve
* fix
* improve
* fix build
* wip getHref support
* implement getHref()
* give proper name to a story
* use sync start services
* update text
* fix types
* fix ts
* fix docs
* move clone below drilldowns (near replace)
* remove redundant comments
* refactor action filter creation utils
* updating
* updating docs
* fix payload emitted in brush event
* properly export createRange action
* some more updates
* fixing types
* ...
* inline EventData
* fix typescript in lens and update docs
* improve filters types
* docs
* merge
* @mdefazio review
* adjust actions order
* docs
* @stacey-gammon review
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: streamich <streamich@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
* fix docs
* nit fixes
* chore: 🤖 remove uiActions from Embeddable dependencies
* chore: 🤖 don't export ActionInternal from ui_actions
* test: 💍 remove uiActions deps in x-pack test mocks
* chore: 🤖 cleanup ui_actions types
* docs: ✏️ add JSDoc comment to addTriggerAction()
* docs: ✏️ regenerate docs
* Drilldown demo 2 (#64300 )
* chore: 🤖 add example of Discover drilldown to sample plugin
* fix: 🐛 show drilldowns with higher "order" first
* feat: 🎸 add createStartServicesGetter() to /public kibana_util
* feat: 🎸 load index patterns in Discover drilldown
* feat: 🎸 add toggle for index pattern selection
* feat: 🎸 add spacer to separate unrelated config fields
* fix: 🐛 correctly configre setup core
* feat: 🎸 navigate to correct index pattern
* chore: 🤖 fix type check errors
* fix: 🐛 make index pattern select full width
* fix: 🐛 add getHref support
* feat: 🎸 add example plugin ability to X-Pack
* refactor: 💡 move Discover drilldown example to X-Pack
* feat: 🎸 add dashboard-to-url drilldown example
* feat: 🎸 add new tab support for URL drilldown
* feat: 🎸 add "hello world" drilldown example
* docs: ✏️ add README
* feat: 🎸 add getHref support
* chore: 🤖 cleanup after moving examples to X-Pack
* docs: ✏️ add to README.md info on how to find drilldowns
* feat: 🎸 store events in .enhancements field
* docs: ✏️ add comment to range trigger title
* refactor: 💡 move Configurable interface into kibana_utils
* chore: 🤖 simplify internal component types
* refactor: 💡 move registerDrilldwon() to advanced_ui_actions
* test: 💍 update functional test data
* merge
* docs: ✏️ make drilldown enhancement comment more general
* fix: 🐛 return public type from registerAction() call
* docs: ✏️ add comment to value click trigger title field
* docs: ✏️ improve comment
* fix: 🐛 use second argument of CollectConfigProps interface
* fix: 🐛 add workaround for Firefox rendering issue
See:
https://github.com/elastic/kibana/pull/61219/#pullrequestreview-402903330
* chore: 🤖 delete unused file
* fix: 🐛 import type from new location
* style: 💄 make generic type variable name sconsistent
* fix: 🐛 show "Create drilldown" only on dashboard
* test: 💍 add extra unit test for root embeddable type
* docs: ✏️ update generated docs
* chore: 🤖 add example warnings to sample drilldowns
* docs: ✏️ add links to example warnings
* feat: 🎸 add URL drilldown validation and https:// prefixing
* fix: 🐛 disable drilldowns for lens
* refactor: 💡 remove PlaceContext from DrilldownDefinition
* fix: 🐛 fix type check error
* feat: 🎸 show warning message if embeddable not provided
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Matt Kime <matt@mattki.me>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: ppisljar <peter.pisljar@gmail.com>
# Conflicts:
# .github/CODEOWNERS
2020-05-04 18:20:37 +02:00