Commit graph

18385 commits

Author SHA1 Message Date
Larry Gregory
632c63ab21
[6.x] Spaces Phase 1 (#21408) (#23639)
Backports the following commits to 6.x:
 - Spaces Phase 1  (#21408)
2018-10-01 09:53:43 -04:00
Walter Rafelsberger
dfe08d1d9b
[ML] Fix view link regression. (#23604) (#23607)
Fixes a regression introduced in #23494. The view link was broken because it expects a callback with an action instead of just the link.
2018-10-01 13:02:37 +02:00
Tim Sullivan
3f03551575
Developer documentation for integrating with the telemetry service (#23295) (#23361)
* Developer documentation for integrating with the telemetry service

* open with a bang

* more faqs

* thing about tracking ui interactions

* talk to the plat team

* create and register
2018-09-28 15:25:19 -07:00
Catherine Liu
f77be52bf1
Feat: Progress Elements (#23176) (#23618)
* Adds progress function and elements

Added progress elements

Added progress view

Added unit tests for progress common function

Fixed prop type in toggle arg

Renamed vert -> vertical and horiz -> horizontal

Adjusted progress element dimensions

Removed check for null context in progress function

Refactored progress shapes

Added unicorn shape

Adds labelPosition arg

Added tests for labelPosition

* Added percentage column to demodata

* Updated elements to use percent_uptime in demodata

* Updated demodata percent values

* Refactored progress to use SVGs instead of shape defs

* Added barWeight arg to progress function

* Removed labelPosition arg. Set static label position for each progress shape

* Added label to unicorn shape

* Fixed element images
2018-09-28 12:54:14 -07:00
Rashid Khan
739e3b2c7f Remove debug messages in Canvas 2018-09-28 07:41:56 -07:00
Walter Rafelsberger
6e4ffe9228
[ML] Improve Explorer Chart labels. (#23494) (#23597)
Improves the display of the Explorer Chart labels to fix the following issues:
- Long chart labels could be cut off, so it's not possible to tell what entity fields a chart is referring to. A workaround is to hover the info icon tooltip but that's really slow and cumbersome if you have to do it for every chart.
- The list of entity fields and its values is an unformatted text blob which makes it hard to read and tell which values refer to which field.

Changes:
- If any of the chart labels is longer than 60 chars, the entity fields will wrap to a new line (for all charts to a achieve a consistent look).
- Entity fields use EuiBadge and some custom formatting to make it easier to see field/value pairs.
- If the detector description is too long, it still uses ellipsis for text-overflow:
- If the entity badges are too long, they will be just cut off to the right. There's no simple CSS fix for that, we cannot use ellipsis and we don't want to wrap those badges again because then multiple charts could have different heights. I experimented with gradients but that turned out to be somewhat unreliable. I still consider this a good enough improvement compare to the previous version and would like to leave a tweak for that to a follow up PR.
- If there are mixed detectors with and without entity fields and the existing one wrap, multiple charts are aligned considered the height of the entity fields on display:
- Additionally, this changes the link to the single series viewer from custom code using a Font Awesome icon to use EuiButtonEmpty with the same EUI based icon and a tooltip.
2018-09-28 11:34:27 +02:00
Tim Roes
02065756bd
Add ElastAlert Kibana Plugin to known plugins list (#23598) (#23599)
* Add ElastAlert Kibana Plugin to known plugins list

* Add author of ElastAlert plugin
2018-09-28 10:53:38 +02:00
Catherine Liu
6f90ceb5f4
Added dataurl=null to default image expression (#23582) (#23594) 2018-09-27 22:37:12 -07:00
Caroline Horn
f3a4f30b03
More Kibana plugin LESS 2 SASS (#23413) (#23591)
This PR removes the LESS files for dev_tools, context, console, and inspector_views and replaces them with Sass.
2018-09-27 21:02:24 -04:00
Nathan Reese
4a48cd8598
Migrate report listing management to react and EUI (#22928) (#23589)
* EUIify report management page

* wire ReportListing component together

* fetch jobs and display content in EuiPage

* display jobs in table

* add title and remove page size dropdown

* format date and display date in status column

* add poller

* add download button

* report error button

* remove old reporting table

* fix page styling

* create type for job

* remove job queue service

* remove angular-paging dependency from x-pack

* make download lib, update job notification hack to use jobQueueClient

* fix some more typescript stuff

* remove last angular service

* make report object type subdued color and small text

* update import in canvas

* stricter typing

* fix stuff lost in branch merge

* add return types to JobQueueClient

* wrap javascript code in {} in JSX
2018-09-27 17:09:04 -06:00
Robert Monfera
d8f5fc9889
Feat: ad-hoc grouping (#23249) (#23585)
* Feat: ad-hoc grouping

* Feat: deleting ad-hoc group constituents

* Chore: deleted the former removeElement action

* Feat: make group snap to guides

* Feat: make group snap to guides 2

* Feat: make group snap to guides 3
2018-09-27 23:23:06 +02:00
Justin Kambic
87f67eaa1a [Logstash Management] Euify pipeline (#22902)
* Begin replacing pipeline editor KUI elements.

* WIP build out EUI rendering of Create Pipeline view.

* Add settings components.

* Add close functionality.

* Add save functionality.

* Add temporary dependency hack for testing purposes until EUI XY Chart replaces jquery-flot.

* Add delete pipeline button/capability.

* Add delete modal.

* Remove TODO comment.

* Added toasts.

* Switch to global toast system.

* Add toast for inactive license and readonly state.

* Remove pipeline edit template.

* Add notify on PUT and DELETE errors.

* Add null check for username prop of securityService return value.

* Add disable save button if invalid ID.

* Remove pipeline id field when editing existing pipeline.

* Remove obsolete code.

* Move PipelineEditor component to dedicated file.

* Add EUI table to pipeline list view.

* Add search to pipelines table.

* Add create/delete pipelines buttons.

* Add pagination stubs. Complete after EUI bug resolved.

* Added unselectable for non-centrally-managed pipelines.

* Add clone button to pipelines list.

* Add min page height. Fix bug with edit pipeline link.

* Remove obsolete pipeline list code.

* Remove obsolete tooltip, edit, list code.

* Disable create pipeline if id is empty.

* Move PipelineList component to dedicated file.

* Add empty state to pipeline list. Add selection messages.

* Update loading message.

* Move methods to more logical positions in component.

* Add info alerts to pipeline list.

* Remove obsolete angular template.

* Remove obsolete imports from pipeline list directive.

* Define UpgradeFailure component.

* Move UpgradeFailure subcomponents to dedicated files. Write tests.

* Move PipelineEditor subcomponents to dedicated files.

* Write tests for pipeline editor subcomponents.

* Move bare strings into constants.

* Move PipelineEditor constant values into constants file.

* Break subcomponents of InfoAlerts component into dedicated files.

* Remove obsolete constants.

* WIP - write tests for PipelineList, break table into separate component, add error empty prompt message.

* Move ConfirmDeleteModal component to dedicated file and test.

* Add TODO comment.

* Add test tags to react components.

* Add 'data-test-subj' prop to fields for func tests. Minor layout update. Run prettier on some files.

* Add data-test-subj prop to button. Disable two tests until pagination is re-added.

* Re-enabled pagination for pipeline list.

* Remove wallaby hack.

* Update pagination options, remove obsolete code.

* Fix bug introduced in refactor to display delete button at appropriate time.

* Handle max_bytes setting correctly. Add theme/mode to code editor.

* Update snapshot for new pagination.

* Remove angular template for UpgradeFailure view.

* Move bare text from Modal functional component to constant file. Update test + snapshot.

* Ran prettier on all changed documents.

* Remove obsolete TODO comments.

* Re-enable disabled functional test. Clean up TODO code.

* Fix unresolved promise in functional tests.

* Pipeline delete button hidden unless enabled, move to left.

* Make filter title more readable.

* Apply width to clone column on Pipeline List.

* Modify pipeline edit view to use 's'-size icons.

* Change pipeline editor delete button to empty button.

* Move pipeline edit actions to bottom left of form.

* Add propTypes for PipelineEditor.

* Update test snapshots.

* Update pipeline list delete button func test.

* Add pipeline edit test. Add heading to pipeline edit page.

* Move constant files to modules where they are consumed.

* Move UPGRADE_FAILURE constants into module that consumes them.

* Remove redundant tests and remove text constant imports from tests.

* Give initial values to id and description text fields to make them controlled components.

* Clean up pipeline ID form regex validation and add tests.
2018-09-27 17:12:02 -04:00
Walter Rafelsberger
1e0f9d005f
[ML] Fixes Anomaly Explorer IE11 issues (#23558) (#23576)
Fixes two issues in IE11 for Anomaly Explorer:
- The format of the string returned from element.attr('transform') is different in IE11 so the regex based on it would fail. This fixes the issue and adds tests for the different formats. The code was also changed to gracefully return NaN in case the regex wouldn't return results, the previous version triggered a JS error.
- The migration of the swimlanes to React caused the cell selection to malfunction in IE11. This fixes it by updating the dragSelect library to use the new method setSelectables. The previous method we used (addSelectables) didn't play well with how React rerenders the swimlanes. Note this lib update using the new method will require to run yarn kbn bootstrap.
2018-09-27 21:11:39 +02:00
Lisa Cawley
21a90bd7b7 [DOCS] Adds TLS info to licensing page (#20638) 2018-09-27 10:16:18 -07:00
Josh Dover
5794396834
Fix plugin generator when using hacks and SCSS [ci skip] (#23579) (#23580) 2018-09-27 12:10:06 -05:00
CJ Cenizal
3a1c702aa4
Add Vanilla JS example to kbn-i18n README (#23556) (#23570)
Rename Node.js to Vanilla JS and give example of internationalizing a string constant.
2018-09-27 08:59:53 -07:00
Aleh Zasypkin
fd70b4faf3
Upgrade eslint/tslint/prettier plugin versions. (#23562) 2018-09-27 14:17:45 +02:00
Maryia Lapata
b5508683b0
Translate metric_vis (#23187) (#23561)
* Translate metric_vis

* Close span tag

* Remove space code

* Update ids

* Translations for color mode list
2018-09-27 14:08:39 +03:00
liza-mae
b54cac72bf
Add argument passing to jenkins cloud job (#23538) (#23549) 2018-09-26 17:46:11 -06:00
CJ Cenizal
a5482d84b8
Add SearchError for surfacing courier search errors. (#23382) (#23543) 2018-09-26 14:42:56 -07:00
Ryan Keairns
fed1525b61 fix home page width for IE11 (#23491) 2018-09-26 11:38:04 -07:00
Brandon Kobel
de2863ae9f
Saved Object Namespaces (#23378) (#23536)
* Use an instance of SavedObjectsSerializer for migrations and the repository

* Fixing spelling of serialization

* Making the serializer conditionally include and prepend id with ns

* Adding repository tests for the namespaces

* Implementing find

* Modifying the SOCs to pass the options with the namespace

* Centralizing omitting the namespace when using serializer.rawToSavedObject

* Passing the schema through to the SavedObjectRepositoryProvider

* Changing the schema to work with undefined ui exports schemas

* Adding schema tests

* Making the complimentary serialization test use the namespace

* Fixing uiExports

* Fixing some tests

* Fixing included fields for the find

* Fixing include field tests, they're checking length also...

* Updating Repository test after adding namespace to always included
fields

* Renaming UIExportsSavedObjectTypeSchema to SavedObjectsSchemaDefinition

* Completing rename... forgot to save usages

* Fixing issue with the serialization.isRawSavedObject and the trailing :
2018-09-26 10:12:09 -07:00
Tim Roes
2cb1f3e9db
Remove last mentions of spy panels (#23527) (#23533) 2018-09-26 19:08:12 +02:00
Catherine Liu
67adddecb6
Removed tr hover style in datatable (#23305) (#23517) 2018-09-26 10:01:11 -07:00
James Gowdy
9f42042aec
[ML] Fixing duplicate influencers when cloning a job via a wizard (#23484) (#23495) 2018-09-26 09:42:22 +01:00
Ryan Keairns
889e19e9d1
removes unused less styles for ace editor (#23425) (#23505) 2018-09-25 17:20:54 -05:00
Ryan Keairns
2a99cdef0f
fixes modal width and element capitalization (#23250) (#23506) 2018-09-25 14:19:15 -05:00
Ryan Keairns
a855557e8b
Fixes IE color issues on Welcome screen graphics (#23281) (#23504)
* fixes opacity issues on bg graphics

* tweak gradients
2018-09-25 14:19:01 -05:00
Aleh Zasypkin
1611c1cf53
[6.x] Correctly pass timestamp from the core to the legacy Kibana. Do not try to stop legacy Hapi server if it does not exist. (#23502) 2018-09-25 20:48:03 +02:00
Melissa Alvarez
61e4a1bbdb
Add context to job picker for accessibility (#23483) (#23496) 2018-09-25 18:38:05 +01:00
Matt Bargar
7b38c7e23c
Mention license change for autocomplete 2018-09-25 12:46:00 -04:00
James Gowdy
59ca4666b5
[ML] Fixing issue when editing script fields in advanced job creator (#23475) (#23485) 2018-09-25 17:41:51 +01:00
Nathan Reese
cc66f3bafa
Create re-usable IndexPatternSelect component (#23335) (#23400)
* Migrate index pattern select to ui/public/index_patterns

* get rest of jest tests working

* migrate remaining part of IndexPatternSelect to IndexPatternSelectFormRow
2018-09-25 08:11:09 -06:00
pavel06081991
4c331b1348
Update versions of @babel/parser and @babel/types (#23268) (#23469)
Update versions of @babel/parser, @babel/types, eslint, babel-eslint
2018-09-25 16:18:05 +03:00
James Gowdy
faf538369d
[ML] Fixing missing field when cloning a distinct count job (#23439) (#23454) 2018-09-25 13:37:10 +01:00
liza-mae
0fe8b14735
Cleanup from PR 22608, remove esInstallDir (#23450) (#23456) 2018-09-24 18:30:57 -06:00
liza-mae
0d66bcd894
Add option to functional test server to run elasticsearch from instal… (#22608) (#23447)
* Add option to functional test server to run elasticsearch from install dir

* Fix variable

* Fix server CLI test

* Updates to include install path in esFrom command line option

* Fix snapshot

* Update args/cli tests

* Keep default snapshot in args/help
2018-09-24 13:52:37 -06:00
Nathan Reese
a5950b7db6
display hits and total hits for courier inspector requests (#23434) (#23449)
* display hits and total hits for courier inspector requests

* update Hits help text to explain difference between total hits

* fix functional test
2018-09-24 13:46:22 -06:00
Chris Roberson
c51ec363a3
[Monitoring] APM Monitoring UI (#22975) (#23444)
* Merge in boilerplate branch

* Manually copy over the specific metrics and UIs

* Add api integration tests

* Fix tests

* Remove unused metrics

* Update snapshot

* Fix tests

* Remove types agg

* Use ApmClusterMetric

* provide description for apm-server monitoring metrics (#23331)

* Vis LESS to SASS (cont.) (#23199)

* Tweak migrations integraiton tests to have a stable sort (#23265)

* Fix: plugin api route with security enabled (#23334)

Closes https://github.com/elastic/kibana/issues/23266

This is more of a quick fix than the final solution. The issue was that Canvas tries to check the plugins API without checking to see if the user it logged in. As a result, instead of the plugins response, it gets the HTML from the login page and that causes an error to be thrown when attempting to parse the results.

For now, this PR just disables the auth requirement on the Canvas plugin API endpoint.

* [migrations/tests] sort results before assertion (#23347)

There have been several failures in this test, seemingly caused by a lack of sorting in the results. It makes sense that since both migrations are run simultaneously that sometimes one would succeed and sometimes another would, so I've just sorted the results before checking.

![image](https://user-images.githubusercontent.com/1329312/45791153-44e9cc80-bc3d-11e8-88c4-760d4c7b35bd.png)

cc: @chrisdavies

* [ML] Moves custom URL editor Add button and form to top of flyout (#23326)

* [ML] Moves custom URL editor Add button and form to top of flyout

* [ML] Edits to custom URL editor class name

* Graph LESS to SASS (#23348)

* Developer documentation for integrating with the telemetry service (#23295)

* Developer documentation for integrating with the telemetry service

* open with a bang

* more faqs

* thing about tracking ui interactions

* talk to the plat team

* create and register

* Fix a bug where ES sends a string and migrations expect a boolean (#23313)

* chore: use cheerio in i18n.html.getDirectiveMessages (#23342)

this was only using jsdom to parse html, but cheerio allows parsing html without requiring a dom. cheerio was also already in the dependency list.

* [core/utils] add shareWeakReplay() operator (#23333)

* Chore: fix canvas test runner (#23336)

Blocked by https://github.com/elastic/kibana/pull/23342

This fixes the local test runner in Canvas. It should not affect anything else, including the CI test runner.

- Bumps JSDOM to ^12.0.0
  - I matched Kibana's version on migration, but nothing else in X-Pack uses JSDOM, so we can use the newer version (which has a very different API)
  - I had to match it because of a script that enforces version matching, but #23342 removed jsdom from Kibana, so we no longer have a version to match
- Restores the local `.babelrc` file
  - I thought it was only used for building plugins; I was wrong 😢

* Convert Discover open top nav to EUI flyout (#22971)

* move find logic to SavedObjectFinder component since savedObjectClient is no longer coupled to angular

* implement flyout open saved searches

* remove old open stuff

* add jest test for OpenSearchPanel and simplify panel title

* fix functional tests

* fix _lab_mode functional test

* Migrate save top nav in Discover and Visualize to EUI (#23190)

* extract reusable save component from DashboardSaveModal

* update discover search to use SavedObjectSaveModal

* create generic show_save_model that works for both discover and dashboard

* fix last bits of discover save

* remove old save functionallity

* migrate visualize save to EUI

* fix functional tests

* disable save button if title is empty

* mark title input as invalid when title is not provided

* fix funtional tests

* Moves styleSheetPath to uiExports (#23007)

This was previously defined in uiExports.app, which limited plugins which are not an app of providing a stylesheet. This allows any plugin to define a stylesheet which will be available on page load.

* Timelion less to sass (#23339)

* Consistent casing

* Fix snapshot

* Update tests
2018-09-24 14:44:33 -04:00
Walter Rafelsberger
93383c8457
[ML] Fix Limit Dropdown, simplify state management of Anomaly Explorer. (#23388) (#23440)
- This fixes the limit dropdown behavior. The fix for that is actually just the $scope.appState.fetch(); statements in explorer_controller.js, they avoid to run the information stored in appState across modules out of sync.
- Additionally, the aim of this PR is to simplify the state management of Anomaly Explorer in the context of selecting cells in the swimlanes and updating the influencers list, charts and table accordingly.
2018-09-24 18:33:12 +02:00
Walter Rafelsberger
40d2dcda12
[ML] Fixes Anomaly Explorer resize listener. (#23427) (#23429)
Fixes the cleanup of the resize listener once you change to another page within the ML plugin.
2018-09-24 15:37:32 +02:00
Stacey Gammon
5cbc278614
Use concrete assertions, not exists (#23271) (#23392) 2018-09-24 07:36:58 -04:00
Tyler Smalley
b3778f9899 Normalize path for comparison on Windows (#23404)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-09-23 21:14:11 -07:00
James Gowdy
848de4dbfb
[ML] Fixing various issues when cloning a job using a wizard (#23368) (#23412) 2018-09-22 11:44:49 +01:00
Caroline Horn
e4553de816
Timelion less to sass (#23339) (#23405) 2018-09-21 23:17:43 -04:00
Spencer
f1048a8edf
[core/utils] add shareWeakReplay() operator (#23333) (#23370) 2018-09-21 12:57:37 -07:00
Catherine Liu
61b67e316c
Fix: plugin api route with security enabled (#23334) (#23402)
Closes https://github.com/elastic/kibana/issues/23266

This is more of a quick fix than the final solution. The issue was that Canvas tries to check the plugins API without checking to see if the user it logged in. As a result, instead of the plugins response, it gets the HTML from the login page and that causes an error to be thrown when attempting to parse the results.

For now, this PR just disables the auth requirement on the Canvas plugin API endpoint.
2018-09-21 10:05:04 -07:00
Tyler Smalley
b93b868b0f
Moves styleSheetPath to uiExports (#23007) (#23385)
This was previously defined in uiExports.app, which limited plugins which are not an app of providing a stylesheet. This allows any plugin to define a stylesheet which will be available on page load.
2018-09-20 20:42:04 -07:00
Nathan Reese
fe1b90faa5
Migrate save top nav in Discover and Visualize to EUI (#23190) (#23380)
* extract reusable save component from DashboardSaveModal

* update discover search to use SavedObjectSaveModal

* create generic show_save_model that works for both discover and dashboard

* fix last bits of discover save

* remove old save functionallity

* migrate visualize save to EUI

* fix functional tests

* disable save button if title is empty

* mark title input as invalid when title is not provided

* fix funtional tests
2018-09-20 19:40:06 -06:00
Nathan Reese
f750ab71c1
Convert Discover open top nav to EUI flyout (#22971) (#23376)
* move find logic to SavedObjectFinder component since savedObjectClient is no longer coupled to angular

* implement flyout open saved searches

* remove old open stuff

* add jest test for OpenSearchPanel and simplify panel title

* fix functional tests

* fix _lab_mode functional test
2018-09-20 15:05:17 -06:00