Commit graph

27693 commits

Author SHA1 Message Date
Nathan Reese 19262a8e31
[skip-ci][Maps] document EMS request domains (#45739) 2019-09-16 08:58:03 -06:00
Alexey Antonov 16cab29312
Move ui/field_formats to src/plugins/data (#44883) 2019-09-16 16:04:13 +02:00
Kerry Gallagher d059d1f053
[Logs UI] Enhance analysis setup flow (#44990)
* Enhance setup with a steps style flow
2019-09-16 14:54:40 +01:00
Jean-Louis Leysens 8e18a5e337
[Console] Fix leaky mappings subscription (#45646)
* Fix mappings subscription (still needs further refactoring)
Fix app not never unmounting

* More defensive removeChild behaviour on unmount
2019-09-16 15:25:53 +02:00
Artyom Gospodarsky 73ef1cb52e
TypeScriptify index_patterns/index_patterns/flatten_hit.js (#45269)
* Typescriptify flatten_hit.js

* Fix path
2019-09-16 14:10:30 +03:00
Maryia Lapata 71f6150a14
Fix functional test (#45641) 2019-09-16 12:45:16 +03:00
Aleh Zasypkin 15b272a87a
Provide realm name for OIDC/SAML authenticate requests. (#44984) 2019-09-16 10:32:58 +02:00
Aleh Zasypkin a9f5c2f30a
Enable PKI integration tests. (#44115) 2019-09-16 09:30:19 +02:00
Spencer 510566d66b
[kbn-es] make custom snapshot url a feature (#45750)
* [kbn-es] make custom snapshot url a feature

* download es snapshot first
2019-09-15 08:10:43 -07:00
spalger 9e8ea8fd64 override es snapshots from scripts/es so it works locally too 2019-09-15 07:20:22 -07:00
spalger 567d0ef597 force manually created snapshots until live ones are available 2019-09-15 07:03:17 -07:00
Shahzad 337c76f383
[Uptime] Fix/issue 41924 show permission warning if no right for uptime (#44968)
* add not found page

* update error handling and 404 page

* update unit tests snaps

* reverted a small change

* Resolved formatting issues

* update unit tests
2019-09-14 16:40:02 +05:00
Xavier Mouligneau 19867b9709
[SIEM] Fix timeline persistence against url and events viewer (#45657)
* fix timeline  persistence against url and events viewer

* fix reset fields browser for events view

* fix inspect event

* review I

* review II
2019-09-13 20:19:46 -04:00
Nick Peihl a8087c2568
Bump ems landing page URL to v7.4 (#45720) 2019-09-13 16:29:27 -07:00
gchaps 067e577350
[DOCS] Adds docs for snapshot lifecycle management (#45485)
* [DOCS] Adds docs for snapshot lifecycle management

* [DOCS] Incorporates review comments and fixes images
2019-09-13 15:38:30 -07:00
Brian Seeders b8469350cf
GHPRB-derived env vars should be blank when missing, not the string 'null' (#45642) 2019-09-13 17:43:10 -04:00
Nate Archer 334506a96a
[DOCS][CODE]: Fix TOC issue for renamed Code page (#45700)
* [DOCS] Fix beta tag in Code Docs

* Fix TOC issue for renames Code page
2019-09-13 16:40:19 -05:00
Lukas Olson 968c088a27
Add IP, number, and boolean types to the static lookup field formatter (#45585)
* Add number to the types for the static lookup

* Add other types for the static lookup
2019-09-13 14:04:12 -07:00
Lee Drengenberg e142442712
correct path with this missing slash (#45666) 2019-09-13 15:43:57 -05:00
Frank Hassanabad c9a11ee971
[SIEM] Adds process_started ECS fields to Uncommon Process Table (#45664)
## Summary

Adds process_started ECS fields to the uncommon process table for any agents which support it. This removes duplicates from the uncommon process table as well in some cases where we were counting process started and process ended as two different counts.

https://github.com/elastic/kibana/issues/45530

Anyone outside of beats implementing this will need these two fields to show up:

```ts
event.type: process_start
event.category: process,
```

Their ECS record should have this bare minimum:

```ts
  "event": {
    "type:": "process_start",
    "category": "process",
  },
```

To show up
### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)

### For maintainers

- [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2019-09-13 14:37:52 -06:00
spalger 5696b67c92 [Reporting] Skip failing test (#45656)
(cherry picked from commit 40e24547ae)
2019-09-13 13:36:11 -07:00
Nathan Reese 71dc6da5e7
Allow filter editor to open when selectedField is undefined (#45402)
* Allow filter editor to open when selectedField is undefined

* add condition to renderIndexPattern
2019-09-13 14:35:03 -06:00
Lee Drengenberg d9cd4e614e
[Reporting] skip flaky reporting tests (#45659)
* Add option for Internet Explorer IE11

* WIP trying to figure out IE options/capabilities

* more attempts to get IE tests working

* more work, but still can't set font size in Dev Tools Console

* two changes for IE

* revert skip in console test

* this change *appears* to set absolute times but they don't stick

* Shakespeare passing on all 3 browsers

* add config.ie.js, change 'internet explorer' to 'ie'

* increase notifications:lifetime so ew have a chance to see the message

* correct path with this missing slash

* skip flaky tests issues #45499 #42725

* revert these files to master

* revert to master
2019-09-13 15:34:35 -05:00
Yuliia Naumenko c6e78599e8
Create unit test for registerBuiltInActionTypes and move common code (#45648)
* Create unit test for registerBuiltInActionTypes and move common code
2019-09-13 13:16:40 -07:00
Mike Côté 68ffe7e18b
Update alerting docs to mention manage_api_key cluster privilege requirement (#45375)
* Update alerting docs to mention manage_api_key cluster privilege requirement

* Update docs
2019-09-13 15:42:02 -04:00
Brian Seeders e3a3b7fbd8
Fix a few issues related to sending emails in pipeline (#45470) 2019-09-13 15:15:49 -04:00
Tim Sullivan 9a56d426ed
[Reporting/ESQueue] data read/write failures are error logs (#45478)
* [Reporting/ESQueue] data read/write failures are error logs

* fix warning level
2019-09-13 11:39:31 -07:00
Nate Archer 84a56d580a
[DOCS][CODE]: Rename "Getting started with Code" to "Import your first repo" (#44924) (#45471)
* [DOCS] Fix beta tag in Code Docs

* [DOCS][CODE]: Issue #44924 - Rename Get started to Import your first repo
2019-09-13 13:33:09 -05:00
Lisa Cawley 7c75aa2bb2
[DOCS] Moves monitoring content into user folder (#45594) 2019-09-13 11:31:12 -07:00
Spencer ef5c520826
Call failure reporter directly from Jenkinsfile (#45551)
* Run failed_tests/cli once per node

* force failures for testing

* Revert "force failures for testing"

This reverts commit 3ddd9240fe.
2019-09-13 11:15:38 -07:00
Tim Sullivan 4a9dc664c6
[Reporting/Typescript] Fix types for JobParamsPDF, BrowserConfig, ChromiumDriverFactory (#45209)
* [Reporting] Correct PDF Params type definition

* Fix types for BrowserConfig, ChromiumDriverFactory

* remove jobparams type

* spot fixes

* fix guard in compat shim

* fix legacy functional test

* fix jest test
2019-09-13 10:54:41 -07:00
Lisa Cawley 5478b4a610
[DOCS] Moves reporting content into user folder (#45588) 2019-09-13 10:47:55 -07:00
Lisa Cawley 87cdfd2ae1
[DOCS] Moves graph content into user folder (#45591) 2019-09-13 10:10:32 -07:00
Justin Kambic 271be95171
[Uptime] Add TLS cert expiry to GQL schema for individual docs (#44506)
* Add certificate expiration date to uptime GQL schema.

* Update test fixture/snapshot for broken unit test.

* Extract TLS data to two separate GQL types.

* Remove unused field from schema/adapters.

* Update broken functional tests.

* Extract TLS data to two separate GQL types.

* Remove unused field from schema/adapters.

* Update broken functional tests.

* Modify schema/types and parsing code to avoid weird data structure.

* Fix busted test snapshot/mock data.
2019-09-13 12:52:15 -04:00
Alison Goryachev 7e359276be
Address accessibility issues in management apps (#45024) 2019-09-13 12:14:26 -04:00
Ryland Herrick 79d531cecc
[Code] Results change with search context (#45545)
* Clean up test setup

Removes a redundant assignment.

* Update search suggestions after scope changes

Without the additional call to this.updateSuggestions, the autocomplete
suggestions remain from the previous scope and no action is taken until
the user submits the search form.

This also adds a null check on the `onSearchScopeChanged` prop.

* Test search scope change functionality

Adds a basic test around the search scope functionality in the QueryBar
component.

Unfortunately, due to the fact that the searchScope prop is actually
controlled in a parent, this test is of questionable utility.
2019-09-13 10:50:41 -05:00
gchaps af55ea9499
[DOCS] Updates Graph documentation (#45597)
* [DOCS] Updates Graph documentation

* [DOCS] Incorporates review feedback
2019-09-13 07:44:01 -07:00
Walter Rafelsberger d8cc11d87d
[ML] Single metric viewer: Fix race condition when changing jobs. (#45420)
Fixes a race condition where changing jobs in Single Metric Viewer could result in the focus chart being empty.
Applying the job change would cause two events to be triggered which would cause the Single Metric Viewer to refresh twice: The updated time range would be triggered via timefilter, the updated jobs via the globalState listener.
This PR solves the problem by setting a global flag skipRefresh which allows us to skip updating single metric viewer and only update again once both the new time range and jobs are set. The PR also adds some checks to avoid unnecessary updates in d3 code triggered by React render calls.
2019-09-13 07:36:26 -07:00
Joe Reuter 6763836bc7
[Graph] Settings EUI-ification (#44587)
* create graph listing page

* clean up app folder

* remove inline loading menu

* also add badge to workspace route

* fix tests

* fix graph spaces functional test

* generate documentation for new breadcrumb property

* fix test subject names

* remove unused translations

* start implementing save modal flow for Graph

* fix spaces functional test

* wip save modal

* wip save modal

* add and style save modal

* add placeholder to description field

* disable dirty check on breadcrumb navigation and fix delete function

* reactify most of settings

* improve onClick typing on breadcrumb

* fix newline error and use new types in dashboard app controller

* EUIify drilldown

* EUIify drilldown

* fix translation errors

* fix i18n translation for real

* fix icon and work on autoreplace template logic

* use switch instead of checkbox

* code review

* fix i18n phrases

* remove fragments

* add KQL encoder to be able to drill down to discover

* fix flyout overflow issue

* delete old settings logic

* remove obsolete files

* fix tests

* fix i18n phrase typo

* fix most translations

* start implementing review comments

* continue implementing review

* continue cleanup of settings forms

* remove unnecessary max-width and add commentary

* move to async syntax

* clean up implementation

* use description instead of title

* work on settings form

* fix snapshot

* fix drilldown list

* add tests for use_list_keys

* rename stuff and add documentation

* fix translatiojns

* fix some rename references

* start typing saving and loading

* typing persistence stuff

* adress review comments and set width for all save modals

* type serializing logic

* fix bug and improve typing

* fix classname

* wip

* wip

* add notes

* style blacklist group

* remove merge marker

* improve icon rendering

* wip

* start refactoring

* remove js implementation

* remove js implementation

* remove duplicate file

* add some tests

* Design cleanup

* Fix SASS files

* revert style fixes in app.js

* implement todos

* fix errors and prematurely enabling inspect panel

* deselect icon after clicking again

* fix types

* make icon list accessible

* clean up and add some more tests

* improve number handling

* fix deserialization

* polishing drilldown-ui

* rename types

* clean up imports

* fix tests

* add handling for canEditDrillDowns setting

* propagate changes to workspace client

* align tabs with other elements
2019-09-13 15:30:58 +02:00
Walter Rafelsberger ea4900b4c6
[ML] Single metric viewer: Fix cell selection flickering. (#45500)
- Fixes a flickering effect when selecting cells in the Single Metric Viewer's swimlane. Previously, during selection, dragSelect took care of highlighting cells. The dragSelect-selection would then be cleared and the d3-based selection only took over after new data was loaded which resulted in the selection not being visible during loading. Now, the dragSelect-selection is only cleared immediately if only cells not containing any anomalies were selected.
- Also fixes a bug where only the first and last cell in the overall swimlane would be highlighted instead of the full range of selected cells.
2019-09-13 06:18:55 -07:00
Devin W. Hurley 8bc8ae2053
[SIEM] Enable eslint rule for duplicate import statements (#45552)
* enable eslint rule for duplicate import statements

* updates lint warn to an error
2019-09-13 09:15:42 -04:00
Liza Katz e4225a70d9
Rename QueryBar to QueryBarTopRow (#45250)
* rename QueryBar to QueryBarTopRow

* Fixed test typo

* Fixed search bar mock
2019-09-13 16:11:25 +03:00
Walter Rafelsberger ec5d1a9ce9
[ML] Fixes getTab() to always return an array. (#45616)
- Fixes getTabs() to always return an array. I was wondering why TypeScript didn't flag the tabs.map(...) part because tabs could possibly be undefined. It's because Record assumes that every key exists. More on that can be found in this blog post.
- This PR fixes a) the type of TAB_MAP by wrapping it in Partial<...> so it correctly flags the tabs.map() part with tabs possibly being undefined and b) fixes getTabs()'s return value by always returning an array.
2019-09-13 05:39:38 -07:00
Artyom Gospodarsky fa7614b360
Move as_pretty_string.js (#45356)
* Convert asPrettyString to TS

* Migrate asPrettyString() to plugins/data
2019-09-13 14:29:41 +03:00
Xavier Mouligneau f5e91da99c
[SIEM] Fix paginated table state when switching tab (#45487)
* Keep state of host/netwrok table when switching tab

* keep state in the event viewer when switching tab in host page

* refactor test to ensure activePage updates from prop change

* rm comments

* add/fix unit test

* fix i18n

* need to rm weird files

* rm weird files

* fix inspect button for real + loading view between tabs

* cleanups

* commented by mistake

* fix logic loading

* review I

* review II

* review III

* review IV
2019-09-13 07:22:27 -04:00
Maryia Lapata 1223ab97a6
[Vis: Default Editor] EUIficate 'Metrics & Axis' tab (#43772)
* EUIficate pointe-series and grid

* Apply TS

* Show grid on a panel

* Remove extra space

* Add TS

* Use BasicOptions

* Adjust func test

* Add dataTestSubj prop to SelectOption

* Use id instead of data-sest-subj

* Disable show x-axis lines when there is histogram agg

* Add tooltip for disabled 'Show x-axis lines' config

* Add series_options.tsx

* Migrate series

* Improve changeValueAxis

* Create CategoryAxisPanel

* Create ValueAxesPanel

* Create CustomExtentsOptions

* File renaming

* Use TruncateLabelsOption

* Set min value

* Add validation

* Refactoring

* Move types upper

* Convert series logic

* Convert valueAxes logic

* Rename function

* Add validation and refactoring

* Adjust styles

* Fix rotates

* Apply config for other vis

* Remove old directives

* Fix useHook usage

* Update vislib_vis_type.js

* Fix

* Move Threshold line panel into a separate component

* Remove unused translations

* Apply ui suggestions

* Update functional tests

* Remove angular unit test

* Refactoring

* Fix dependencies

* Refactoring

* Add validation

* Add validation for other vis

* Refactoring of onPositionChanged handler

* Refactoring of addValueAxis

* Get rid of a useEffect

* Refactoring of updateAxisTitle

* Update useCallback

* Refactoring

* Refactoring of collections config

* Refactoring of setChartValueByIndex and setValueAxisByIndex

* Update metrics_axes_options.tsx

* Watch current tab for correct accordion height

* Revert axis title logic

* Fix axis id and name number

* Fix code review comments

* Fix functional tests

* Update visualize_page.js

* Move option tabs in common

* Fix code review comments

* Update index.tsx

* Refactoring

* Fix merge conflict

* Show ThresholdPanel when it's configured

* Fix passing a current tab to vis-options

* Localize 'Count' text

* Pass one axis to CategoryAxisPanel

* Fix y-axis name number when x-axis position changed

* Fix Y-axis name number when position Y-axis changed

* Fix refresh loop

* Re-organize controls

* Apply code review comments

* Refactoring

* Fix extents empty value

* Update y_extents.tsx

* Fix code review comments

* Fix updating several seriesParams when removing axis

* Add thresholdLine config to horizontal bar

* Refactoring

* Reset grid.valueAxis when the axis deleted

* Fix refresh loop

* Set interpolate config for line

* Enable "show dots"
2019-09-13 14:12:43 +03:00
Artyom Gospodarsky 680d84662c
Move highlight_html.js (#45372)
* Convert getHighlightHtml() to TS

* Convert htmlTags to TS

* Convert highlightTags to TS

* Convert getHighlightRequest() to TS

* Convert index.js to index.ts

* Move tests to TS

* Move highlight to plugins/data
2019-09-13 12:23:16 +03:00
Søren Louv-Jansen afb989a634
Bump backport to 4.7.0 (#45587)
* Bump backport to 4.7.0

* Bump to 4.7.1
2019-09-13 10:53:17 +02:00
Mike Place 384d2200ce
Respect xpack.monitoring.show_license_expiration (#45537) 2019-09-13 06:42:08 +00:00
Spencer f250b49e2e
don't log warning when env_keys script is reloaded in the same… (#45578)
(cherry picked from commit b47b0d194580e4cd21be05e01b768969637954f8)
2019-09-12 19:13:30 -07:00