Commit graph

9 commits

Author SHA1 Message Date
Jean-Louis Leysens 5c2d0cae9c
Console to NP ready (#43346)
*  General structure of Public w/ legacy brace + autocomplete 🤔
 Refactor Resizer functionality (panel component)
 Refactor Play Button
 Refactor Auto-completion
 Refactor Docs opener
 Refactor Storage

* First refactor of kbn ace keyboard mode to TS+React

* clean up unused props

* console_menu.js -> console_menu.tsx

* Remove unused file from quarantine and added fixed ui ace keyboard mode react hook

* - Refactored history and storage to app-wide services
- Pre-emptive changes to tests
- sense-history -> HistoryList
- removed unused kbn top nav v2 component

* A lot of cleanup, re-introduced editor resize checker, re-introduced history viewer as TS+React. `history` still needs refactoring.

* First iteration of tap nav menu, with history toggle working

* Lots of fixes
Also moved over and integrated remaining three react components

* Moved a lot of files around again, tidied up NP set up

* Replace angular directive

* Remove used code

* Re-order imports and move all ace dependencies to same location

* Remove more unused code

* Revise quarantined setup mocks

* Don't suggest 'undefined' or other null-like values in autocomplete

* Clean up api_server folder

* Re-add missing style

* Updated karma spec mock

* Fix editors cutting of at bottom of screen

* Refactor console editors into single components
Refactor a lot of business logic to main.tsx container
Minor renaming of variables for better readability

* Updated use of contexts with better error message
Fixed broken render sync cycles (using useCallback)
Fixed Main container render cycle (added missing deps to useEffect)
Fixed default input and removed auto indent from being called on init for already formatted text

* Updated test mocks

* Update to be more in line with NP conventions https://github.com/elastic/kibana/blob/master/src/core/CONVENTIONS.md

* Update console history when making new requests
Fixed spacing between editor and console history
Moved registration of keyboard commands to TS
Fixed setup_mocks.js after renaming app to application

* Clean up git merge conflict artifact

* Use updated NP interfaces

* More typings fixed after updating local project dependencies

* Removing some dependencies on KUI and font awesome from legacy editor

* Fix clear history not re-rendering
Refactor prop name to be more descriptive

* Simplify split_panel and add tests

* Fix accessibility tabbing behaviour for ace editor

* Refactor ConsoleEditor into two separate components
Remove unused changeCursor code
Remove unused textArea ref
Use default lodash debounce (remove unnecessary arg)

* Major a11y fix when tabbing
Major fix for ace in IE11 and Edge browsers

* Update comment
2019-09-12 13:28:29 +02:00
Josh Dover b352f67bdb
Add ApplicationService Mounting (#41007)
* Add core-only bundle

* Add ApplicationService mounting

* Add LegacyCore{Setup,Start}

* Fix PR comments

* Add functional tests

* Fix PR comments

* Fix PR comments

* Remove other usages of rootRoute

* Use state field notation

* Add support for open in new tab

* Fix PR comments

* Fix pesky await from the dead

* Update docs

* Bump @types/history
2019-09-03 13:03:05 -05:00
Mikhail Shustov af4bc62954
Route handler interface (#39767)
* route handler rfc

* Update 0005_route_handler.md

* Update 0005_route_handler.md

* typings

* address comments

- headers are strings
- generic --> custom
- add responseError factory

* specify data types. remove confused comment

* update link
2019-07-24 20:29:29 +02:00
Josh Dover b8423952c0
[RFC] ApplicationService mounting (#36477) 2019-06-18 14:32:34 -05:00
Court Ewing 252be3fc43 [RFC] Handler interface (#36509) 2019-06-18 09:51:01 -05:00
nicknak 7b3146d781 [rfc] Adds RFC for saved objects encrypted attributes. (#33740)
Co-authored-by: Nicholas Dziedzic <nicholas.dziedzic@elastic.co>
2019-04-30 08:31:02 +02:00
Court Ewing 7e224b2455
Update RFC-0001 with PR and issue links (#33598) 2019-03-20 14:15:47 -04:00
Court Ewing 8eacfb5a28
[rfc] "setup" lifecycle handler for core and plugins (#32507)
The `setup` lifecycle function for core and plugins will be for
one-time setup and configuration logic that should be completed
in a finite amount of time rather than be available throughout
the runtime of the service.

The existing `start` lifecycle function will continue to serve
only the purpose of longer running code that intentionally only
executes when `setup` is finished.
2019-03-12 16:33:48 -04:00
Josh Dover bae87b0043
Add RFC README and template (#31650) 2019-02-22 10:00:13 -06:00