* Updated to eui@30.4.1, fixed types and unit tests
* Cleanup some imports
* Fix a text color swap, now back to danger text
* Bump EUI to v30.4.2
* Revert snapshot changes from ownFocus modification
* Clean up alert flyout test actions to better represent user actions
* Upgrade EUI to 30.5.1
* More accurate test interaction
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): remove kibana pre-commit hook installation from bootstrap
* chore(NA): add support for git ref flag on run precommit hook script
* chore(NA): integrate quick commit checks within the CI
* chore(NA): introduce logging trap to warn about quick commit checks failure and how to reproduce it
* chore(NA): update quick commit checks message
* fix(NA): quick commit checks function def
* chore(NA): fix quick commit checks message quotes
* chore(NA): fix functional call
* chore(NA): fix script to run
* chore(NA): add unexpected debugger statement to test quick commit checks
* chore(NA): update message to log before quick commit checks
* chore(NA): remove extra debugger statement
* chore(NA): add echo message inline with script execution
* chore(NA): add unexpected debugger statement to test quick commit checks
* chore(NA): remove extra usage of debug statement
* chore(NA): wrapping quick commit checks in a func
* chore(NA): export function to use later
* chore(NA): export function to use later
* chore(NA): use child bash script on github checks reporter
* chore(NA): define dir context for commit_check_runner.sh
* fix(NA): permissions for commit_check_runner.sh
* fix(NA): permissions for commit.sh
* chore(NA): format message to log
* chore(NA): add unexpected debugger statement to test quick commit checks
* chore(NA): remove extra usage of debug statement
* chore(NA): format runner message
* chore(NA): replace log.info by log.warning
* docs(NA): include docs for removing the pre-commit hook auto installation
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): update gitignore to include first changes from moving into a single package.json
* chore(NA): update gitignore
* chore(NA): move all the dependencies into the single package.json and apply changes to bootstrap
* chore(NA): fix types problems after the single package json
* chore(NA): include code to find the dependencies used across the code
* chore(NA): introduce pure lockfile for install dependencies on build
* chore(NA): update clean task to not delete anything from xpack node_modules
* chore(NA): update gitignore to remove development temporary rules
* chore(NA): update notice file
* chore(NA): update jest snapshots
* chore(NA): fix whitelisted licenses to include a new specify form of an already included one
* chore(NA): remove check lockfile symlinks from child projects
* chore(NA): fix eslint and add missing declared deps on single pkg json
* chore(NA): correctly update notice
* chore(NA): fix failing jest test for storyshots.test.tsx
* chore(NA): fix cypress multi reporter path
* chore(NA): fix Project tests check
* chore(NA): fix problem with logic to detect used dependes on oss build
* chore(NA): include correct x-pack plugins dep discovery
* chore(NA): discover entries under dynamic requires on vis_type_timelion
* chore(NA): remove canvas
* chore(NA): add initial code to find circular deps
* chore(NA): ground work to integrate the circular deps scripts
* chore(NA): add correct filtering to find circular dependenices feature
* chore(NA): add ci mode flag into circular deps script
* chore(NA): feature complete circular dependencies detect script
* chore(NA): merge and solve conflicts with master
* chore(NA): remove unwanted changes
* chore(NA): remove unwanted changes on kbn storybook
* chore(NA): hook find circular deps tool into ci
* chore(NA): remove previous find plugin circular deps script
* chore(NA): add type for circular dep list
* chore(NA): add type for circular dep list for allowed list
* chore(NA): allow CI to fail check
* chore(NA): update deps allowed list
* chore(NA): run search circular deps script over examples too
* docs(NA): adds cli description
* chore(NA): use plugin search paths to build entries to find circular deps
* chore(NA): update allowed list
* chore(NA): snapshot update for kbn optimizer test
* chore(NA): update dpdm version
* chore(NA): remove thirdParty flag
* chore(NA): update docs to include info about the new tool
* docs(NA): update to link PR instead of the issue
* chore(NA): update debug logs to always output allowedList
* fix(NA): correctly list found differences number
* chore(NA): remove quiet flag
* fix(NA): correctly fail the CI if circular deps are found
* chore(NA): complete list of found circular deps
* chore(NA): used named capturing group into the regex
* docs(NA): update typescript best practices docs and styleguide
* chore(NA): introduce quick filter option flag
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* bump version to 4.1.1-rc
* fix code to run kbn bootstrap
* fix errors
* DO NOT MERGE. mute errors and ping teams to fix them
* Address EuiSelectableProps configuration in discover sidebar
* use explicit type for EuiSelectable
* update to ts v4.1.2
* fix ts error in EuiSelectable
* update docs
* update prettier with ts version support
* Revert "update prettier with ts version support"
This reverts commit 3de48db3ec.
* address another new problem
Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
# Conflicts:
# test/functional/services/remote/remote.ts
* create kbn-legacy-logging package (#77678)
* create kbn-legacy-logging package and start to move things
* fix rotator tests
* fix logging system test mocks
* move logging format to the package
* move logging setup to package
* adapt legacy logging server
* remove usage of legacy config in the legacy logging server
* move legacy logging server to package
* remove `??` syntax from package
* update generated doc
* fix a few things due to month old merge
* remove typings from project
* move reconfigureLogging to package
* add basic README file
* update generated doc
* remove old typings
* add typing for legacy logging events
* remove `??` from packages
* fix / improve event types usages
* remove suffix from tsconfig
# Conflicts:
# src/legacy/server/config/schema.js
* fix for 7.x branch
* update deps
* update rules
use type-aware @typescript-eslint/no-shadow instead of no-shadow. do not use no-undef, rely on TypeScript instead
* fix or mute all lint errors
* react-hooks eslint plugin fails on ? syntax
* fix wrong typings in viz
* remove React as a global type
* fix eslint errors
* update version to 4.8.1
* fix a new error
## Summary
Update `unpackRegistryPackageToCache` to call `unpackArchiveToCache` instead of duplicating much of it.
Now an archive is iterated & put in cache via the same function regardless of its initial source.
* chore(NA): update gitignore to include first changes from moving into a single package.json
* chore(NA): update gitignore
* chore(NA): move all the dependencies into the single package.json and apply changes to bootstrap
* chore(NA): fix types problems after the single package json
* chore(NA): include code to find the dependencies used across the code
* chore(NA): introduce pure lockfile for install dependencies on build
* chore(NA): update clean task to not delete anything from xpack node_modules
* chore(NA): update gitignore to remove development temporary rules
* chore(NA): update notice file
* chore(NA): update jest snapshots
* chore(NA): fix whitelisted licenses to include a new specify form of an already included one
* chore(NA): remove check lockfile symlinks from child projects
* chore(NA): fix eslint and add missing declared deps on single pkg json
* chore(NA): correctly update notice
* chore(NA): fix failing jest test for storyshots.test.tsx
* chore(NA): fix cypress multi reporter path
* chore(NA): fix Project tests check
* chore(NA): fix problem with logic to detect used dependes on oss build
* chore(NA): include correct x-pack plugins dep discovery
* chore(NA): discover entries under dynamic requires on vis_type_timelion
* chore(NA): remove canvas
* test(NA): fix jest unit tests
* chore(NA): remove double react declaration from storyshot test file
* chore(NA): try removing isOSS check
* chore(NA): support for plugin development
* chore(NA): update logic to fix unit tests and typechecking
* chore(NA): support to run npm scripts in child kbn projects across all envs
* chore(NA): support github checks reporter on x-pack and remove cpy types as the package correctly provides them
* chore(NA): update cpy version
* chore(NA): include last kbn pm changes
* chore(NA): update style on build_production_projects.ts
* chore(NA): remove any cast fom telemetry opt in stats
* chore(NA): remove del and re-use rm -rf again
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
# package.json
# packages/kbn-pm/dist/index.js
# x-pack/package.json
# yarn.lock
* convert pdf.js to TS
* more typescript
* simplify caller
* more typescript
* more typescript
* fix the code to match the expected interface
* very cool comment
* interface correction
* remove unused class method
* add unit test for PdfMaker
* file rename for typo correction
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Upgraded eui to v29.5.0; snapshot updates
* Cleaned up some types
* addresses feedback on types change
* Update EuiIcon snapshots in jest integration tests
* Updated snapshot from rebasing on master
* chore(NA); bump version to 7.11.0
* chore(NA): correctly define kibana version for search examples
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Upgraded EUI to v29.2.0
* Remove hacks on top of EuiHeaderLink(s)
* Actual update to eui@29.2.0
* Resolve typescript issue when omitting a key over a union
* Resolve nav menu test's expectations
* Fix lint issue
* Update to 29.3.0
* [ui-shared-deps] strip proptypes from ui-shared-deps production build
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: spalger <spalger@users.noreply.github.com>
Upgrade to Storybook 6 and attempt to use the declarative configuration.
The goals of this PR (as part of Kibana's Storybook roadmap, are:
Upgrade to Storybook 6
Still allow running Storybooks with yarn storybook plugin_name
Use the declarative configuration to (hopefully) make the configuration simpler to use an easier to understand, as well as avoiding deprecation warnings and loss of future compatibility
The ways in which what I have so far differs from how we do things today are:
In the alias configuration it takes a path to a storybook configuration directory instead of the storybook.js file from before
Each plugin (it doesn't have to be a plugin; can be any directory) has a .storybook/main.js (the aliases file in @kbn/storybook specifies these locations) where they can define their Storybook configuration. You can require('@kbn/storybook').defaultConfig to get defaults and override them
@kbn/storybook has a preset that can provide Webpack and Babel configuration and Storybook parameters and decorators
Instead of dynamically creating the list of stories to import, we define them in the globs of the stories property in .storybook/main.js.
Do not build a DLL. We are using @kbn/ui-shared-deps as externals. Startup time is not quite as fast but still acceptable.
Other things done in this PR:
Allow default exports in .stories. to allow for Common Story Format CSF stories
Add guard in Webpack configuration needed for overriding CSS rules
Update filename casing check to allow for files with required names in Storybook
Clean up observability stories
Rename *.examples.tsx and *.story.tsx to *.stories.tsx
* Storybook 6 and config changes (#75357)
Upgrade to Storybook 6 and attempt to use the declarative configuration.
The goals of this PR (as part of Kibana's Storybook roadmap, are:
Upgrade to Storybook 6
Still allow running Storybooks with yarn storybook plugin_name
Use the declarative configuration to (hopefully) make the configuration simpler to use an easier to understand, as well as avoiding deprecation warnings and loss of future compatibility
The ways in which what I have so far differs from how we do things today are:
In the alias configuration it takes a path to a storybook configuration directory instead of the storybook.js file from before
Each plugin (it doesn't have to be a plugin; can be any directory) has a .storybook/main.js (the aliases file in @kbn/storybook specifies these locations) where they can define their Storybook configuration. You can require('@kbn/storybook').defaultConfig to get defaults and override them
@kbn/storybook has a preset that can provide Webpack and Babel configuration and Storybook parameters and decorators
Instead of dynamically creating the list of stories to import, we define them in the globs of the stories property in .storybook/main.js.
Do not build a DLL. We are using @kbn/ui-shared-deps as externals. Startup time is not quite as fast but still acceptable.
Other things done in this PR:
Allow default exports in .stories. to allow for Common Story Format CSF stories
Add guard in Webpack configuration needed for overriding CSS rules
Update filename casing check to allow for files with required names in Storybook
Clean up observability stories
Rename *.examples.tsx and *.story.tsx to *.stories.tsx
Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
* first shot of the apm configuration loader
* revert changes to kibana config
* remove test files for now
* remove `?.` usages
* use lazy config init to avoid crashing integration test runner
* loader improvements
* add config value override via cli args
* add tests for utils package
* add prod/dev config handling + loader tests
* add tests for config
* address josh's comments
* nit on doc
* [ES UI Shared] Remove 'brace' from es_ui_shared public (#78033)
* major wip
* major wip
* fix worker creation leak
* just copy the file over for now
* Remove xjson from static and from es_ui_shared entirely
- moved expand and collapse logic back to es_ui_shared. It has
nothing to do with ace
- refactor the useXJson hook which bundled XJsonMode with it.
This was convenient but ultimately inflates the amount of code
Kibana needs to first load up in the client. Users will need to
import XJsonMode and instantiate it when they want to use it.
Updated existing usage.
- Cleaned up Monaco namespace from es_ui_shared because of how
useXJsonMode was refactored -- no longer exporting an editor
specific instance means this code does not know about anything
to do with code editors so it is decoupled from ace and monaco.
* fix export of collapse and expand string literals
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
# .github/CODEOWNERS
# src/plugins/es_ui_shared/kibana.json
* import brace json mode in raw vis editor
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Updating the version of the elasticsearch-js Client
* ES Client methods aren't implicitly bound to the Client anymore
* Adjusting mocks to work with prototypical inheritance
* Fixing effects of ping returning a Boolean, now.
* Updating @elastic/elasticsearch to 7.9.1
* Responding to @restrry's feedback
* Now with destructuring...
* adds "Creates timeline" test
* deletes timeline events spec
* completes assertions
* comments assertion
* fixes typecheck error
* waits for all the changes in the timeline to be performed before creating a new timeline and closing the toggle
* fixes failing problem
* fixes loop script
* makes test realiable on visual mode
* fixes merge issue
* makes test more reliable
* fixes typecheck issue
* fixes typecheck
* opens timeline from timeline settings
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
The removed resolutions are no longer needed because the packages that
originally depended on the incompatible versions have either been
removed or upgraded.
* move deprecations and raw loader to package
* move config service to package
* start to adapt the usages
* adapt yet more usages
* update generated doc
* move logging types to `@kbn/logging`
* update generated doc
* add yarn.lock symlink
* merge @kbn-logging PR
* adapt Env.createDefault
* update generated doc
* remove mock exports from the main entrypoint to avoid importing it in production code
* use dynamic require to import `REPO_ROOT` from bootstrap file
* move logger mock to kbn-logging package
* address review comments
* import PublicMethodOf from kbn/utility-types
* fix import conflict
* update generated doc
* use the @kbn/std package
* update generated doc
* adapt plugin service mock
Moves common utility functions to obtain the repository root,
paths (config/data), and Kibana package.json to a @kbn/utils package.
Moving these existing functions allows them to be used in production, in
other packages because of Kibana.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [@kbn/utils] Adds missing dependency (#77536)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* move test_helpers to the core
* create base tsconfig
* all tsconfigs use the base one
* use test_helpers exposed from the src/core
* move getFieldFormatsRegistry to data plugin
* add test_utils project
* compile types after checkout
* add a stub for platform tsconfig.json
* fix broken import
* fix broken path to the base config
* set tsBuildInfoFile for project without outDir
* do not commit tsbuildinfo file
* do not check output d.ts files
* fix type error
* use separate config to build types
* rollback changes to include paths
* mute import zone error
* rename files to avoid references to tsd
* do not use tsd for type tests
* include all ts files in project
* run buildRefs before type check to ensure the latest version
* store tsbuildinfo locally
* update paths to base config
* comment out core/tsconfig.json
* remove ui path
* fix wrong tsbuildinfo path
* Quick pass at restoring support for both zip & tar
Restored unzip functions from https://github.com/elastic/kibana/pull/43764
Persist the `download` value returned by EPR (e.g. `/epr/system/system-0.5.3.zip` or `/epr/system/system-0.5.3.tar.gz`) as "archive key" for a package name/version combo.
The same name&version should return the same archive. The value initially given by the registry.
Based on that value, we decide which decompression to use.
* Use template literal vs JSON.stringify for keygen
* Factor unzip/untar logic out to getBufferExtractor
* Add tests for getBufferExtractor
* Replace `[aA]rchiveKey*` with `[aA]rchiveLocation*`
* Include given name & version in error message
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
# x-pack/plugins/ingest_manager/server/services/epm/registry/cache.ts
* bump ts to v4
* MOAR RAM
* fix type errors for OSS
* first pass on x-pack errors
* second pass on x-pack type errors
* 3rd pass on x-pack type-errors
* mute errors if complex cases
* don't delete if spread suffices
* mute other complex cases
* make User fields optional
* fix optional types
* fix tests
* fix typings for time_range
* fix type errors in x-pack/tests
* rebuild kbn-pm
* remove leftovers from master update
* fix alert tests
* [Telemetry Checker] TS4 Fixes
* bump to 4.0.1-rc
* fix new errors in master
* bump typescript-eslint to version supporting TS v4 syntax
* fix merge commit errors
* update to the stable TS version 4.0.2
* bump ts-eslint to version supporting ts v4
* fix typo
* fix type errors after merge
* update ts in another new package.json
* TEMP: remove me
* Revert "TEMP: remove me"
This reverts commit dc0fc3bae6.
* [Telemetry] Update snapshot for new TS4 SyntaxKind
* bump prettier to support TS v4 syntax
* fix prettier rules
* last style change
* fix new type errors
Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
# Conflicts:
# packages/kbn-i18n/package.json
# x-pack/plugins/uptime/public/components/settings/add_connector_flyout.tsx
# x-pack/plugins/uptime/public/components/settings/alert_defaults_form.tsx