* Improve typings
Custom API Source allow indexing several types of data. We didn't
account for all of them.
For example, geolocation can be array of arrays of numbers.
This commit improves typings.
The following commits mostly fix TS errors
that appear after this commit.
* Remove type castings to account for all possible variable types
* Update helper functions to accept new CustomAPIFieldValue
* Fix TS error: convert url to string before using it in EuiLink
* Update mock and tests to match updated typings
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Update plugin README with beta copy & fancier product info
* Update API dev docs plugin description punctuation
* Update README dev section
- Remote reference to native auth - no longer applicable in 7.14
- Add reference to Getting Started guide (Elastic only)
* Run node scripts/build_plugin_list_docs to update https://www.elastic.co/guide/en/kibana/master/plugin-list.html
* Add link to main Kibana README
- which should link out to their contributing docs
## Summary
In previous pull requests I noticed that there were accidents where Cypress tests were accidentally mutating objects such as rules and mock data since the data is mutable as regular variables. This changes the data to be underneath functions and the functions all return new copies on each invocation. This makes it so that it isn't possible for Cypress tests to accidentally mutate data and mocks between tests. This should also prevent devs from accidentally writing tests that rely on previous tests accidentally mutating data.
I am hoping that this is portable back to 7.14 since it's just test changes and will make it easier to do any other bug fixes without conflicts if tests are updated. If it's not easily portable, then I will mark and update it as only 7.15 backported.
* Changes the mocks underneath `objects/<type>` to use getter functions that return objects.
* Updates the cypress tests
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
* [Fleet] Fix enrollment flyout with fleet server from policy page
* Fix tests
* Show enrollment instructions for add agent from fleet server policy
* Fix conditions to show fleet server setup in flyout
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [TSVB] Refactor top-hit aggregation to work with fields instead of _source
* Allow select date strings for top_hit aggregation in table, metric, and markdown
* Fix agg_with handling for top_hit and add some tests
* Refactor get_agg_value and fix type check for _tsvb_chart
* Refactor top_hit.js
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [ML] Fixes unnecessary too many buckets warning on anomaly chart embeddable
* [ML] Update jest tests for number of axis ticks.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
## Summary
See https://github.com/elastic/kibana/issues/100433 for details and test instructions.
This is considered critical and a small fix for 7.14.0 has been requested.
* Wrote Cypress test that exercises the bug
* Fixed mutation in one part of the Cypress Test
* Decided to remove the "missing" that we were telling users was "others" since missing is not the same as others. It no longer errors, but some users might be asking why we don't show "others" anymore. The reality is that we only showed "missing" which isn't adding value to the preview of what detections will end up looking like.
* Later if we want a true "others" we should implement it as a larger feature request and not a bug fix IMHO
Before you would get errors in your network panel:
![errors_threshold](https://user-images.githubusercontent.com/1151048/125126681-b0380e00-e0b8-11eb-9f2c-a75e2909754c.png)
After you now get the `source.ip` without errors:
<img width="1074" alt="Screen Shot 2021-07-09 at 1 28 24 PM" src="https://user-images.githubusercontent.com/1151048/125127326-94813780-e0b9-11eb-9367-bb3b406ff55a.png">
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
* Remove the "view threat intel data" button from the alert summary
This can be accomplished by clicking the tab itself; there's no real
need for this button.
* Remove section title from alert summary view
This made sense when we had both alert and threat sections, but we no
longer do.
Removes the corresponding translation, and the analogously unused title
from the defunct threat summary view.
* Smaller spacer on alert summary tab
This is distractingly large as compared to other tabs.
* Move "no enrichments" panel below our threat details table
* Remove old import
* Move inspect button inline with rest of header
* Add HR separator to top of NoEnrichmentsPanel
This should arguably be added a level above so as to keep this panel
context-agnostic, but it's currently only used in one place and will
always require the HR, so YAGNI for now.
* Adds more space between title and description on "no data" panel
It has been suggested that the NoEnrichmentsPanel should be following
the guidelines of the EuiEmptyPrompt. If we end up needing e.g. centered
text, we're better off rewriting NoEnrichmentsPanelView in terms of an
EuiEmptyPrompt.
* StyledEuiInMemoryTable has no header row height
We have never provided column names to this component. However, there is
default padding on the thead tds such that even without content they
take up vertical height.
This has resulted in some extra top-margin on historical uses of this
table (which are just the Alert Details views). However, the addition of
a sibling table (ThreatSummaryView) made the extra margin noticable,
since it made the two tables appear disjointed even though they're right
up against each other.
This fixes the issue by removing the padding, allowing the thead to take
no height.
And now that that space isn't taken up by the table header, we need to
add a little bit of space between the header and table on the Threat
Details view.
* Move test to appropriate location
The ThreatDetailsView is no longer responsible for displaying the "no
data" components, that's now a level above in EventDetails.
* Prune unused translations
These have been changed in the latest designs.
* Only add HR if panel is preceded by enrichments
We do not want an HR if there's nothing above the panel.
* Fix ent-search authentication to show the error connecting screen
Missed this in #103555
* [Misc] updoot handleConnectionError order/spacing to match
- why? because i've lost control of my life, probably