Commit graph

3010 commits

Author SHA1 Message Date
Tim Roes
5f3f1966cb
Rename Visual Builder to Timeseries (#38777) 2019-06-13 14:44:53 +02:00
Vitali Haradkou
a15b15aae3
[TSVB] [AT] time series formatter duration (#38256)
* Add new tests for the duration formatter
2019-06-13 15:31:26 +03:00
Maryia Lapata
386619e577
[Vis: Default editor] EUIficate Sub agg control (#37979)
* EUIficate metric agg control

* Fix translation errors

* Display agg error underneath the last bucket agg form control

* Update functional test

* Update error message

* Update parent_pipeline_agg_controller.js

* Fix validation when metricAgg is invalid

* Show error message when a filed is selected

* Delete _terms_helper.tsx

* Remove extra empty line

* Update parent_pipeline_agg_helper.js

* Update selector for test
2019-06-13 11:18:26 +03:00
Philipp B
722559129d
[Accessibility] A <label> for time bucket size selector on discover (#38396)
* Replace <span> with a <label for=''> used as a label for a dropdown <select>
* Change CSS selector for functional test
2019-06-12 21:46:10 +03:00
Vitali Haradkou
a7abe1999d
[TSVB] [AT] new markdown tests (#38545)
* perform new markdown tests
2019-06-12 14:25:36 +03:00
Matthias Wilhelm
a33201cf39
Support for date_nanos type timestamps in context view (#38023)
* Reenable context view for time_nanos based index patterns
2019-06-11 15:04:54 +02:00
Spencer
3bc5595ce3
[testFailureReporting] only run on master/version jobs (#38497) 2019-06-10 07:04:32 -07:00
Frank Hassanabad
fdd4621601
[SIEM] Add build step to find cyclic deps in SIEM project (#38329)
## Summary

* Adds a build step to find cyclic deps and error out in the SIEM project when found as part of a build step.

* Fixes typescript files that have cycles with their constants and types.

You run this like so:

```
cd kibana/x-pack/plugins/siem
node scripts/check_circular_deps.js
```

And get this message:
<img width="846" alt="Screen Shot 2019-06-07 at 11 22 24 AM" src="https://user-images.githubusercontent.com/1151048/59121970-b629f680-8916-11e9-8683-326a881c4725.png">

Or you will get an error with a listing of deps that need to be updated which have cycles in them.

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~
~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2019-06-07 14:40:06 -06:00
Stacey Gammon
bd484391fc
Embeddable API V2 (#37510)
* Embeddable API plugin

* Expose new embeddableActions uiExport endpoint

* Add missing getInjectedUIAppVars to Server type

* Add jest tests

* Most basic skeleton of the sample plugin to see if it still kills ci

* strip even more out to see if it passes ci

* It passed, put back init fn

* add back in a uiExport to see if that is what is killing ci

* Passed again, add back embeddableActions uiExports and require kibana line

* Add everything back but the sass import

* Found two bugs with customize panel title action, added jest test coverage and fixes

* Functionally test embeddable explorer plugin

* Addressing review feedback part 1

* Simplify action context menu - remove support for nested actions/child panels, which was never exposed anyway.

* More review feedback

* Spread out orders to let developers inject their own actions in the middle.

* Remove check for overwriting ApplyFilterAction

* use createRegistry for EmbeddableFactoryRegistry

* Add comment for getInheritedInput

* Use kbn-es-query Filter types

* Fix missed file after createRegistry switch over for EmbeddableFactoryRegistry

* Use delete instead of setting to undefined

* upgrade EUI to match kibana version

* Add getIsContainer on base embeddable class

* Run functional tests of sample plugin

* move all tests classes outside __test__ and inside test_samples folder so not to potentially create issues with mocha

* fix: 🐛 remove unused imports

* fix: 🐛 set to undefined explicitly

* chore: refactored getRoot functionality

* fix: refactor miss from folder rename __test__ -> test_samples

* fix: add eui switch to let the user indicate “hide this title” to improve ux.

* fix: customize panel flout test

* Try to fix issue with multiple rxjs bundles I hit before.

See https://github.com/ReactiveX/rxjs/issues/3828

* Use an rxjs polyfill to work around the issue of multiple rxjs bundles

* chore: change customize panel flyout to modal post design feedback

* capitalize Reset

* fix: type errors in customize panel modal

* fix: remove extra line added to prevent EUICallout overflow from spilling over panel edges

The bug this was intended to fix doesn’t appear yet because dashboard isn’t using this, and it causes other issues, so for now, just remove.

* Clean up some classes and SASS

* Inline styles needed to get the containers to take up the full height of the app.

* Use the same old style of error messaging in panels

* chore: add untilEmbeddableLoaded tests, expose on interface, and use in embeddable_child_panel

* Remove unused styles, add padding

* Verify trigger Context containers an array of Filters for apply filter action

* Remove panel.embeddableId param, use panel.explicitInput.id instead

* Check `isCompatible` as well as the type guard needed for typescript.

* executeTriggerActions should account for getHref

* Remove unnecessary check for context being defined

* use npStart instead of getNewPlatform

* Conform to latest NP changes

* Use new np_mocks in all the tests

* Address review feedback on rxjs polyfill
2019-06-07 13:30:55 -04:00
Nathan Reese
8dbfbddb53
Fetch options for input control child select boxes (#38148) 2019-06-07 06:57:56 -06:00
Spencer
acba93a38c
[jest] don't be crazy, run with caching enabled (#38332) 2019-06-06 16:56:52 -07:00
spalger
c655a11ece [ci] disable firefox tests 2019-06-06 14:26:53 -07:00
Matthias Wilhelm
e11277fc89
Undo setting of $scope.refreshInterval at dashboard (#37175)
* Add test for passing on dashboard url params to timepicker values

* Revert unnecessary setting of $scope.refreshInterval

refreshInterval is set at $scope.model, no need to set it directly at $scope like in discover and vis
2019-06-06 19:33:03 +02:00
Josh Dover
02ff1adcbd
[new-platform] Simplify the frontend integration with the legacy platform (#37734) 2019-06-05 17:46:03 -05:00
Luke Elmers
1e016a62a9
Fix broken filtering on metric visualizations. (#38029) 2019-06-05 11:48:30 -06:00
Vitali Haradkou
a7dedb63d5
[TSVB] [AT] implement new test cases for time series formatter (#37506)
* implement new test cases for time series formatter
2019-06-05 18:13:04 +03:00
Dmitry Lemeshko
27e219e20b
functional tests/firefox wait for loading after page refresh (#38082) 2019-06-05 16:52:48 +02:00
Lee Drengenberg
e9938a54b1
Add 1/2 second sleep to fix test (#37903) 2019-06-04 11:16:52 -05:00
Chandler Prall
86fea48875
Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui (#36316)
* Upgrade EUI to 11.0.1; support dynamic import() calls in UI code + eui

* update snaps

* Clicking on the svg itself once loaded

* updated snaps

* update icon in snapshots

* Fix snapshot
2019-06-03 12:01:01 -04:00
Dmitry Lemeshko
f82e92a077 FTR: add support for Firefox browser (#32509)
* skip and adjust functional tests for Firefox

* downgrade geckodriver to 0.22.0

* [ftr] add firefox specific config file

* remove hard coded firefox adjustments

* remove firefox specific screenshot directory

* run functional tests in firefox in x-pack

* pass the logger to readConfigFile()

* rename local var

* skip xpack firefox config

* run xpack firefox functional tests in separate command

* update report name for XPack firefox results

* adjust viz shared item test

* skip shared item test

* [test/feature_controls] increase timeout to 20 sec & use forceLogout

* FF timeout on TSVB, refresh page on failure for url navigation

* [feature_controls/visualize_security] increase timeout to 20 sec

* skip dev_tools_spaces tests on FF

* run all groups 3 times

* skip more func tests

* skip more tests

* skip all feature controls tests for Firefox

* revert back changes in feature controls tests

* rename xpack report for chrome

* skip tile map for FF, wait for render before saving

* Revert "run all groups 3 times"

This reverts commit 12b4f69627.

* revert refresh on login

* apply feedback
2019-05-31 15:49:18 -07:00
Maryia Lapata
64e36abef0
Import func tests "_metric_chart" to ciGroup10 (#36623)
* Add metric_chart tests to job and update them

* Revert removing file

* Remove obsolete test

* Move _metric_chart.js to ciGroup10
2019-05-31 14:03:29 +03:00
Vitali Haradkou
b969fbf3ca
revert missing test for TSVB Time Series (#37336) 2019-05-31 14:01:06 +03:00
Matthias Wilhelm
953930be49
Support Elasticsearch date_nanos datatype (#36111)
* Add date_nanos to date type in kibana field types
* date_nanos by default is formatted by "Date Nanos" format
* Format computed date_nanos field to strict_date_time to prevent rounding
* Hide Discover - "View surrounding documents" btn for date_nanos (will be subject of another PR)
* Append number of nano seconds to formatted timeField
* Add new key dateNanosFormat to UI setting defaults
2019-05-31 08:52:32 +02:00
Nick Peihl
1ea3431c69
Skip tilemap zoom warning functional test on cloud (#37570) 2019-05-30 16:37:58 -07:00
Justin Kambic
109d10fcf5
Add a function to the time picker page object to set a commonly-used timespan option. (#37374) 2019-05-30 07:33:56 -04:00
Tim Roes
58ef3a3c49 Add addError function to toastNotifications (#32187) 2019-05-29 13:24:35 -05:00
Daniil Suleiman
a2542d35c6 [Vis: Default editor] EUIficate order_agg param editor (#36984)
* EUIficate order_agg param editor

* Update browser tests

* Add types

* Update enzyme version in x-pack

* Fix functional tests

* Changes due to comments

* Update_terms_helper.tsx

Co-Authored-By: Maryia Lapata <mary.lopato@gmail.com>

* Fix code review comments

* Update yarn.lock
2019-05-29 15:53:06 +03:00
Vitali Haradkou
8007c3fb1b
[TSVB] [AT] TimeSeries refactor (#36987)
* move tsvb timeseries tests into new file
2019-05-29 12:10:27 +03:00
Daniil Suleiman
38b95b1cc1 [Vis: Default editor] EUIficate top_sort param editor (#36629)
* EUIficate top_sort param editor

* Set field if only one available

* Remove unused translations

* Fix functional tests

* Fix browser tests

* Rewrite functional test for combo_box field select

* Remove unused translations

* Update label
2019-05-29 11:43:47 +03:00
Dmitry Lemeshko
ddc24b8255
[visualize/_shared_item] skip test due to #37130 (#37131) 2019-05-28 22:51:07 +02:00
Dmitry Lemeshko
7c556ca337
TSVB: functional test for color picker, preview disable and series clone (#37186)
* [visualize/_tsvb_chart] test for color picker, changing  preview and cloning series
2019-05-28 14:44:46 +02:00
Vitali Haradkou
ed29276c5f
[TSVB] markdown variables(revert fix) (#34067)
* add markdown tests
2019-05-28 00:26:28 +03:00
Vitali Haradkou
3c0bc3086a
Tsfy screenshot service and comparepng internal lib (#37177) 2019-05-28 00:09:18 +03:00
Lee Drengenberg
67dc8a45aa
Split ciGroup3 and ciGroup5 (#36928)
* split large x-pack ciGroup5 into 3 groups

* split large x-pack ciGroup3 into 2 groups

* Add groups to the jenkins xpack ci group file

* Re-level some more work

* move es_search_source test to new describe block

* move es_search_source to first in ciGroup7
2019-05-24 14:20:43 -05:00
Chris Roberson
eb2ede6ca2
[Monitoring] Fix 500 error from /api/stats (#36986)
* Fix 500 and add test for it

* Return an empty object so the logic later will still execute

* Update tests
2019-05-24 09:11:05 -04:00
Vitali Haradkou
2db82c549f
[TSVB] Table tests (#36762)
* implement table tests
2019-05-24 12:09:35 +03:00
Lee Drengenberg
d21476c453
Check visualize timezone (#36416)
* check newest doc timestamp in diff timezones

* Check that data shifts with the timezone

* use retry.waitFor instead of sleep
2019-05-22 14:11:21 -05:00
Josh Dover
91b167424d
Consolidate Plugin{Setup,Start}Context and Core{Setup,Start} (#36732) 2019-05-22 13:50:31 -05:00
Vitali Haradkou
e9411f4a0c
FTR tsfy combobox service (#35493)
* migrate combobox to typescript
2019-05-21 10:54:47 +03:00
Greg Thompson
671760e924 EUI@10.4.1 (#36711)
* update eui to 10.4.1

* revert lock
2019-05-20 18:10:32 -04:00
Todd Kennedy
5f56c30ffd
[chore] upgrade wreck (#36527)
wreck has been deprecated and will receive no further security updates
in favor of @hapi/wreck
2019-05-13 15:36:22 -07:00
Lee Drengenberg
3c9dc690d0
check newest doc timestamp in diff timezones (#36322) 2019-05-09 15:58:37 -05:00
Nathan Reese
5349f673d3
Allow embeddable to specify edit label (#36296)
* Allow embeddable to specify edit label

* update test plugins

* pass getDisplayName in options parameter to ContextMenuAction constructor in plugin example

* more typescript clean-up magic

* some more typescript error fun

* change maps embeddable edit label i18n prefix

* clean-up localization
2019-05-09 14:26:49 -06:00
Spencer
2605d16083
[ftr/tsvb] retry if the legent count is off (#36375) 2019-05-09 11:04:55 -07:00
Matt Bargar
3070d25e46
Extract QueryBarInput component from QueryBar (#35827)
Solution for use cases that need a query bar without a submit button or date picker that still want KQL and autocomplete. Necessary for the KQL in TSVB and KQL in filters aggregation efforts.
2019-05-09 11:15:50 -05:00
Va Da
c6bfa02d2f
Better scripted field editor (#36064)
* fix: 🐛 make script input field full width

* test: 💍 update Jest snapshots

* feat: 🎸 add Groovy syntax highlighting

* test: 💍 update test snapshot

* test: 💍 fix scripted field form functional test

* test: 💍 fix more functional tests for scripted field input

* refactor: 💡 use import instead of require()
2019-05-09 11:19:19 +02:00
Mike Côté
3efaf756d0
Allow any type of saved object to import / export (#34896)
* Modify the relationships API and UI

* Remove type validation on export

* Update relationship test snapshots

* Change relationships table titles

* Change relationships UI to share one table

* Add server side logic to inject meta data into saved objects from plugins

* Manually enable each type of saved object to support

* Use injected vars to determine what types are import / exportable

* Fix some broken tests

* Remove unused translations

* Fix relationships mocha tests

* Remove tests that ensured types are restricted, functionality removed

* Move kfetch logic into separate file

* Add inAppUrl to missing types

* Add tooltip to management table titles that aren't links

* Make relationships screen support filtering by type

* Fix failing tests

* Add refresh support for inAppUrls

* Add error notifications when export API call fails

* Add relationship direction

* Fix broken tests

* Remove graph workspace from import / export

* Use parent / child terminology for relationships

* Use direct relationship terminology

* Flip view / edit logic in saved object management app

* Make config saved object redirect to advanced settings

* Fix broken tests

* Remove unused translations

* Code cleanup

* Add tests

* Add fallback overwrite confirmation object title

* Enforce supported types on import, export and resolve import errors

* Fix broken tests

* Fix broken tests pt2

* Fix broken tests pt3

* Test cleanup

* Use server.decorate to access savedobjectschemas

* Fix some broken tests

* Fix broken tests, add new title to relationships screen

* Fix some broken tests

* Handle dynamic versions

* Fix inAppUrl structure in tests

* Re-use generic canGoInApp

* Fix broken tests

* Apply maps PR feedback

* Apply PR feedback pt1

* Apply PR feedback pt2

* Add savedObjectsManagement to uiExports

* Fix broken tests

* Fix encodeURIComponent implementation

* Merge 403 and unsupported type errors into single error

* Apply suggestion

* Remove import / exportable by default, opt-in instead

* Fix type config to show up properly in the table

* Change config type title and fix tests

* Remove isImportableAndExportable where set to false (new default)

* Remove comments referencing to authorization

* Add unit tests for spaces

* Add unit tests for security plugin

* Change can* signature to be the same as their equivalent function, apply PR feedback

* Cleanup git diff

* Revert "Change can* signature to be the same as their equivalent function, apply PR feedback"

This reverts commit b657ac8fc1.

* Revert "Add unit tests for security plugin"

This reverts commit 6287a8cecf.

* Revert "Add unit tests for spaces"

This reverts commit 2674a9d78f.

* Revert "Remove comments referencing to authorization"

This reverts commit 9618c2cc3a.

* Revert "Merge 403 and unsupported type errors into single error"

This reverts commit 99aea10c0f.

* Add CUSTOM_ELEMENT_TYPE for import / export

* Fix broken tests

* Fix broken tests pt2

* Prevent crashing app when inAppUrl is undefined
2019-05-06 14:44:43 -04:00
dave.snider@gmail.com
d1b189442c
EUI@10.4.0 (#36085)
* EUI@10.4.0

* Fix TS typing in src/legacy/ui/public/chrome/directives/header_global_nav/components/header.tsx
2019-05-05 21:37:07 -07:00
Dmitry Lemeshko
f5bbe82023
adjust tests to pass on Firefox (#35597)
* adjust tests to pass on Firefox

* update feature controls tests to pass on Firefox

* use xpath to search for index pattern
2019-05-03 20:12:15 +02:00
Maryia Lapata
9c8894c705 [Vis: Default editor] EUIficate time interval control (#34991)
* EUIficate time interval control

* Update tests

* Remove empty option, update fix tests

* Bind vis to scope for react component only

* Combine two interval inputs into one EuiCombobox

* Add error message

* Add migration script; remove unused translations

* Update fuctional tests

* Update unit test

* Update tests; refactoring

* Use flow to invoke several functions

* Update test

* Refactoring

* Reset options when timeBase

* Add type for editorConfig prop

* Add placeholder

* Fix lint errors

* Call write after interval changing

* Fix code review comments

* Make replace for model name global

* Revert error catch

* Remove old dependency

* Add unit test for migration test

* Fix message

* Fix code review comments

* Update functional test
2019-05-03 10:44:14 +03:00