Commit graph

48 commits

Author SHA1 Message Date
Vadim Dalecky 7dc001169b
chore: disable Labeler 2019-08-20 17:55:29 +02:00
Vadim Dalecky 162e145f87
chore: 🤖 add labeler GitHub Action (#43521) 2019-08-20 17:12:16 +02:00
CJ Cenizal d5ce67f5ed Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. 2019-08-04 12:36:53 -07:00
Brandon Kobel a8080b88c9
@elastic/kibana-platform now owns the config/kibana.yml file (#42405) 2019-07-31 15:31:39 -07:00
Ahmad Bamieh 9d7cf53eba
[telemetry] Analytics Package (#41113)
* kbn-analytics

* kbn-analytics

* expose provider

* add logger

* performance and stats reporters

* finalize ui stats metric

* functional tests

* remove readme file for now

* update readme

* add types file into to tsconfigs

* Update packages/kbn-analytics/src/report.ts

Co-Authored-By: Josh Dover <me@joshdover.com>

* fix typechecks

* use enum instead of strings for metric types

* getUiStatsReporter -> createUiStatsReporter

* fix special typo in README

* remove unused stop method

* fix tests

* default debug to false

* use chrome.getInjected

* add METRIC_TYPE to jest module mocks

* mock create fn

* handle enabled:false

* init ui_metric in test setup env

* regenerator runtime

* transform-regenerator

* update lock file

* update babel configs

* runtime dep

* add regenerator

* babel configs

* use env-preset

* merge conflicts

* fix workpad telemetry tests

* regeneratorRuntime attempt to fix number 30000

* env targets

* remove module config

* try again

* try without regenerator

* use kbn/babel-preset/webpack_preset only

* runtime

* just use typescript

* update tsconfig

* Caches trackers by app value for infra useTrackMetric hook
2019-07-23 15:46:56 +03:00
Aleh Zasypkin 6848a985c6
Add ownership of new platform security plugin to security team. (#41748) 2019-07-23 13:40:33 +02:00
Mike Côté 560e672083
Add ownership of task manager to stack services team (#41457) 2019-07-18 10:32:57 -04:00
Jason Rhodes 580c94676e
Adds stack-services example entries to CODEOWNERS (#41241) 2019-07-16 20:56:14 -04:00
Vadim Dalecky f18e7439d9
「AppArch」Interpreter 👉 New Platform (#39329)
* feat: 🎸 set-up NP data plugin

* refactor: 💡 move interpreter functions registry to NP

* refactor: 💡 move interpreter renderer registry to NP plugin

* refactor: 💡 move interpreter typesRegistry to NP

* refactor: 💡 move interpreter types to NP

* chore: 🤖 import typeRegistry from NP and change TS type folder

* refactor: 💡 move interpreter expression types to NP

* refactor: 💡 move rest of interpreter common folder to NP plugin

* fix: 🐛 fix TypeScript errors

* test: 💍 improve typings and test mocks

* refactor: 💡 make Interpreter internal registry impl private

* test: 💍 inline NP backdoor mock creation in test suites

* chore: 🤖 change @kbn/interpreter import paths to try fix errors

* fix: 🐛 improve core Plugin interfaces

* feat: 🎸 add stop() lifecycle to NP data plugins

* refactor: 💡 move interpreter into expressions service data NP

* refactor: 💡 inline Registry @kbn/interpreter class

* refactor: 💡 remove dependency on @kbn/interpreter in data pub

* refactor: 💡 move interpreter common dir into expressions dir

* fix: 🐛 use TS types in kibana_context

* feat: 🎸 add types suggested in PR review

* feat: 🎸 add semantic interpreter registration functions

* refactor: 💡 use require for all @kbn/interpreter imports

* test: 💍 add Karma test mocks, thx @spalger 🙏

* docs: ✏️ update Core docs

* test: 💍 add Sinon stubs for registries

* chore: 🤖 change import syntax in hopes CI will work

* chore: 🤖 set App Architecture as owners of data plugin

* docs: ✏️ add README

* chore: 🤖 change import in hopes to fix optimizer

* fix: 🐛 make stop() plugin life-cycle optional

* docs: ✏️ update Core API docs

* test: 💍 remove unnecessary Jest mock

* chore: 🤖 don't import from deeply inside a plugin

* refactor: 💡 try different interpreter import

* fix: 🐛 fix Karma mocking

* fix: 🐛 fix TypeScript type imports

* test: 💍 fix broken test
2019-07-02 09:07:07 +02:00
Michail Yasonik 5892c972ec
update accessibility issue template (#39359) 2019-06-28 10:35:01 +03:00
Court Ewing 2d171c92f5 Fix path references into and out of x-pack/legacy 2019-06-20 13:34:48 -04:00
Vadim Dalecky 0c34b0d6d3
State containers 📦 (#38758)
* feat: 🎸 add initial createStore() implementation

* test: 💍 test observable $state interface

* style: 💄 apply prettier

* chore: 🤖 upgrade react-redux lib

* refactor: 💡 rename $state -> state$

* feat: 🎸 add initial React context and connect implementation

* feat: 🎸 improve connect()() HOC TypeScript typings

* feat: 🎸 export store methods

* feat: 🎸 implement store mutations

* chore: 🤖 add TODO list

* refactor: 💡 rename .mutations -> .createMutations

* feat: 🎸 use name Redux actions for mutations

* fix: 🐛 fix TypeScript errors

* feat: 🎸 store mutations inside store object

* style: 💄 run Prettier on test file

* refactor: 💡 rename mutation -> mutator

* chore: 🤖 set :AppArch team as code owners of kibana_utils

* chore: 🤖 update x-pack package.json react-redux dependencies

* chore: 🤖 run yarn kbn bootstrap

* chore: 🤖 revert back react-redux package upgrade

* refactor: 💡 rename remaining mutation -> mutator

* feat: 🎸 implement first set of React hooks

* chore: 🤖 revert back react-redux upgrade

* refactor: 💡 use useState() inside <Consumer>

* feat: 🎸 implement useSelector() React hook

* docs: ✏️ add store creation docs

* docs: ✏️ add mutators documentation

* docs: ✏️ add getter and Redux docs

* docs: ✏️ add react reference

* docs: ✏️ typo

* docs: typo

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* docs: typo

Co-Authored-By: Stacey Gammon <gammon@elastic.co>

* docs: remove private link
2019-06-14 16:00:32 +02:00
Spencer 0f5bd4dfcc
Implement renovate config generator (#38369)
* reformat renovate.json5 with json5 cli, add header

* add scripts for rengerating renovate config from ts files

* regenerate renovate config

* verify renovate.json5 is up to date in CI

* add description to the build_renovate_config script

* auto-group types packages

* fix typo

* mention version pinning in doc block

* support disabling renovate for package groups

* scan all package paths for @-types deps

* regenerate renovate config

* regenerate renovate config

* name scoped package regexp

* move some of the new logic out of package_groups.ts

* flatMap in one pass
2019-06-07 13:30:59 -07:00
Rudolf Meijering ea9721ad13
[Core] Rewrite saved objects in typescript (#36829)
* Convert simple files to TS

* Fix jest tests

* Rename saved_objects_client{.js => .ts}

* WIP saved_objects_client

* saved_objects repository{.js => .ts}

* includedFields support string[] for type paramater

* Repository/saved_objects_client -> TS

* Fix tests and dependencies

* Fix saved objects type errors and simplify

* saved_objects/index saved_objects/service/index -> ts

* Fix saved objects export test after switching to typed mock

* Workaround type error

* Revert "Workaround type error"

This reverts commit de3252267eb2e6bf56a5584d271b55a7afdc1c53.

* Correctly type Server.savedObjects.SaveObjectsClient constructor

* saved_objects/service/lib/index.{js -> ts}

* saved_objects/service/lib/scoped_client_provider{js -> ts}

* Typescriptify scoped_client_provider

* Fix x-pack jest imports

* Add lodash/internal/toPath typings to xpath

* Introduce SavedObjectsClientContract

We need a way to specify that injected dependencies should adhere to the
SavedObjectsClient "contract". We can't use the SavedObjectsClient class
itself since it contains the private _repository property which in TS is
included in the type signature of a class.

* Cleanup and simplify types

* Fix repository#delete should return {}

* Add SavedObjects repository test for uncovered bug

Test for a bug in our previous js implementation that can lead to data
corruption and data loss.

If a bulkGet request is made where one of the objects to fetch is of a type
that isn't allowed, the returned result will include documents which have the
incorrect id and type assigned. E.g. the data of an object with id '1' is
returned with id '2'. Saving '2' will incorrectly override it's data with that
of the data of object '1'.

* SavedObject.updated_at: string and unify saved_object / serializer types

* Cleanup

* Address code review feedback

* Don't mock errors helpers in SavedObjectsClient Mock

* Address CR feedback

* CR Feedback #2

* Add kibana-platform as code owners of Saved Objects

* Better typings for SavedObjectsClient.errors

* Use unknown as default for generic type request paramater

* Bump @types/elasticsearch

* Fix types for isForbiddenError

* Bump x-pack @types/elasticsearch
2019-06-06 10:49:13 +02:00
Jason Rhodes b0fec9c3f3
Update infra codeowners team to new team name (#36661) 2019-05-20 06:46:02 -04:00
Jason Rhodes 6377605f07
Adds infra plugin to CODEOWNERS (#36634) 2019-05-17 13:18:01 -04:00
Jen Huang e2222ce7c3
Snapshot Repositories UI (#34407)
* [SR] Snapshot and restore plugin boilerplate (#32276)

* Initial plugin set up

* Set up client shell

* Add initial repository list routes

* Fix merge issues and some typings

* Decouple server from plugin.ts files, tighten up typings

* Use exported constant for required license

* Translate plugin name, more typings

* Fix more types, move list components under /home

* Remove unused var

* Change scss prefix

* Uncouple unmount logic from routing shim, and some other PR feedback

* [SR] Repository list and details UI (#33367)

* Initial pass at repositories list UI

* Add detail panel for file system repositories, and a generic detail panel with json settings view

* Add detail components for other types

* Add detail panel footer, rename `useStateValue` to `useAppState`

* Fix detail panel footer

* Fix unused vars

* PR feedback

* PR feedback

* [SR] Refactor proposal (#33690)

* Move app dependencies to its own context provider

* Add index.ts barrel file for common types

* Move Enums to constants.ts file

* Refactor function component using `React.FunctionComponent<Props>`

* Refactor service folder structure

* Fix type import

* Move REPOSITORY_DOC_PATHS from common to public constants

* Move AppCore and AppPlugins interfaces back to shim and re-export them from app types

* [SR] Create and edit repositories UI (#34020)

* Add routing and placeholder form

* Fix typings

* Set up edit repository route, and basic form UI

* Add typings for wrapCustomError, and copy extractCausedByChain from CCR wrapEsError

* Throw errors that are already boomified

* Create and edit for basic repository types (fs, url, source)

* Add repository verification UI to table and details

* Create and edit for plugin repository types (hdfs, azure, s3, gcs)

* Fix linting

* Fix test

* Fix test

* Remove unused import

* Fix duplicate i18n key

* Fix details opening on cancel edit, remove unnecessary Fragments, definition file for some EUI components to x-pack, rename saveError

* Remove breaks

* Adjust add and edit repo routes so they don't conflict with list route

* Add repo plugin and types doc links to form

* Bootstrap documentation service

* Bootstrap text service and replace RepositoryTypeName component with it

* Bootstrap breadcrumb service and replace usages

* Bootstrap httpService, remove chrome and http from app dependencies(!)

* Add request creator and replace all instances of useRequest and sendRequest with it

* Fix typo

* Simplify update repository and update repository setting methods

* Adjust copy

* Lint

* Remove unused var

* Remove unused import

* [SR] Add API for retrieving snapshots. (#34598)

* [SR] Single and multiple repository delete (#34593)

* Add single/multi repository delete API and UI

* Address PR feedback

* [SR] Add SnapshotTable and SnapshotDetails. (#34837)

* Remove associations between multiple repositories with a single snapshot.
* Retrieve complete snapshot details in getAllHandler.
* Fix cleanup function bug in useRequest hook.
* Fix bug in useRequest which prevented old data from being cleared when subsequent requests returned errors.
* Add initialValue config option to useRequest.
* Add formatDate service to text module.

* [SR] Fix linting and add (de)serialization for repositories (#35031)

* Fix eslint issues and add (de)serialization for repositories

* Add comment about flattening settings

* [SR] Surface repository errors and index failures more prominently (#35042)

* Add links to repositories from Snapshot Table and Snapshot Details.
- Rename services/breadcrumbs to services/navigation and add linkToRepository function.
- Refactor home component to update active tab when URL was changed.
* Add warning callout to let user know when their repositories contain errors.
* Sort failures by shard and add test for snapshot serialization.
* Sort failures and indices.
* Add filter for filtering snapshots by their repository.
* Surface states with humanized text, icons, and tooltips where necessary.
* Fix pluralization of seconds.
* Surface failures tab even if there are none.
- Display a '-' for missing times and durations.
- Create DataPlaceholder component.

* [SR] Polish repositories UX (#35123)

* Refactor repository detail panel to load repository based directly on route param.
* Display repository detail panel while table is loading.
* Make 'Edit repository' table action a link instead of a button.
* Render disabled EuiSelect as a readonly EuiFieldText.
* Prepend HDFS URI with hdfs:// protocol.
* Present scheme options for Read-Only URL repository as a select.

* [SR] Add client-side validation to repository form and link to snapshots from details (#35238)

* Add client side repository form validation, extract `flatten` into common lib

* Add snapshot count to repository details and link to snapshot list

* Reset validation when changing repository type

* Fix snapshot list filter deep linking for repository names with slashes and spaces

* Fix imports

* PR feedback

* [SR] Design and copywriting fixes (#35591)

* Split repository form into two steps; move `clean_settings.ts` to server

* Default to snapshots tab, adjust snapshot empty prompt, add app description

* Add minimum timeout to list view requests to avoid flicker, use EuiEmptyPrompt for loading screen, add doc link to settings step

* Add information about snapshots to delete repository behavior, add doc link for source only toggle, add size notation help text

* Add main doc link

* Copywriting and i18n fixes, and add some common settings to third party repo types

* Add fields to third party repo detail panel

* More copywriting fixes

* Use spinner for duration and end time if snapshotting is still in progress

* Show all repository type options, mark missing plugins

* Revert "Show all repository type options, mark missing plugins"

This reverts commit e34ee47cec.

* Fix space

* [SR] Add permissions UI and Cloud-specific repository type UI branch (#35833)

* Add missing permissions UI and cloud-specific repository type UI branch

* Add ES UI as owners of /snapshot_restore directory

* Add no repository types callout for Cloud edge case

* Redirect invalid section param to repositories

* Add warning empty prompt if all repositories have errrors

* Replace repository cards with EuiCard

* Add snapshot doc link to repository error empty prompt

* Remove auto-verification from list and get routes, add separate verification route, add manual verification to repository detail panel

* Update copy and remove obsolete test

* Remove unused scss files

* Final changes to repository cards
2019-05-13 07:03:37 -07:00
Tiago Costa 2ff272c2f3
Update CODEOWNERS with the paths under kibana operations team supervision (#26374)
* feat(NA): update CODEOWNERS with the code under kibana operations team supervision.

* chore(NA): add suport_node_env to operations codeowners.

* refact(NA): change declaration order.
2019-05-09 23:43:58 +01:00
Aleh Zasypkin 2df3880ac7
Introduce Encrypted Saved Objects plugin (#34526) 2019-05-03 17:44:02 +02:00
Fuyao Zhao 81fa6dcf85
[Code] Add code owners (#35498) 2019-04-24 11:08:32 -07:00
Marco Vettorello 6025d16e0f
Add TSVB external contractors as code owners for TSVB dir (#34848) 2019-04-11 10:29:51 +02:00
Tim Roes 8b99d78937 Add platform team as core codeowner (#32904) 2019-03-11 12:21:36 -04:00
Court Ewing 2ce51a5be5 Update paths to ui, server, deprecation, plugin_discovery in src/legacy
This commit accompanies the four that precede it. Rather than squash
them altogether, the four previous commits all do nothing except move
files to help avoid conflicts.
2019-02-11 10:41:37 -05:00
Court Ewing 7a87f03ec7
Introduce content security policy (CSP) (#29545)
* csp: nonce and unsafe-eval for scripts

To kick things off, a rudimentary CSP implementation only allows
dynamically loading new JavaScript if it includes an associated nonce
that is generated on every load of the app.

A more sophisticated content security policy is necessary, particularly
one that bans eval for scripts, but one step at a time.

* img-src is not necessary if the goal is not to restrict

* configurable CSP owned by security team

* smoke test

* remove x-content-security-policy

* document csp.rules

* fix tsconfig for test

* switch integration test back to regular js

* stop looking for tsconfig in test

* grrr, linting errors not caught by precommit

* docs: people -> you for consistency sake

Co-Authored-By: epixa <court@epixa.com>
2019-02-01 17:11:38 -05:00
Walter Rafelsberger 910bebb38b
[ML] Add ml-ui team to CODEOWNERS. (#29810) 2019-02-01 12:18:12 +01:00
CJ Cenizal a22a5d00ff
Reorganize codeowners and define Elasticsearch UI ownership. (#28873) 2019-01-17 11:18:28 -08:00
Mark Robert Henderson c9dc5414a6
One last update to the accessibility template (#28152) 2019-01-07 12:13:36 -05:00
Mark Robert Henderson d745694d23
Update Accessibility.md (#27750) 2019-01-04 12:27:04 -05:00
Mark Robert Henderson 7dc673721c Creating Accessibility Issue Template (#25515)
* Creating Accessinbility Issue Template

* Update Accessibility.md
2018-12-19 18:38:25 -05:00
Shaunak Kashyap a00163b6fe
Remove stack monitoring (#27163)
We're a super small team (1 UI developer) at the moment and don't want PRs to x-pack/monitoring code to require review from us. We haven't had issues with this approach until now and see no reason to change the policy just yet.
2018-12-13 14:47:21 -08:00
Joe Fleming 8a51814f9b
chore: add canvas to CODEOWNERS (#26376) 2018-11-29 09:27:31 -07:00
Matt Apperson 238e24a09c
Add Beats and stack monitoring to CODEOWNERS (#26413)
* Add Beats and stack monitoring to CODEOWNERS

* Update CODEOWNERS
2018-11-29 08:52:33 -05:00
Larry Gregory 4ccedeeacb
Assigns spaces plugin to the Kibana security team (#26348) 2018-11-28 12:55:05 -05:00
Søren Louv-Jansen 1f92c0c128
Add APM UI to codeowners (#25218) 2018-11-07 10:27:29 +01:00
dave.snider@gmail.com f99c8032f4
kibana design owns .scss files (#23889) 2018-11-06 15:24:21 -08:00
Marco Vettorello 462229e90d
Fix typos in PR requeste template (#24075) 2018-10-17 09:54:25 +02:00
dave.snider@gmail.com abb3fcf53e
[PROPOSAL] Make Kibana's PR template a checklist (#23511)
Kibana now uses a checklist for its PR template. The contributing docs were updated with more detail about release process.
2018-09-28 09:36:31 -07:00
Larry Gregory 70f2eed4e9
introducing CODEOWNERS to Kibana (#22830) 2018-09-14 14:46:03 -04:00
Court Ewing 6d52c9d119
No markdown in "question" issue template
Since the default view for new issues is the edit view, and we don't
intend for folks to submit issues that are created using the question
template, markdown really only makes things harder to read.
2018-05-07 18:59:04 -04:00
Court Ewing 5572242215
Issue templates for features, bugs, and questions (#18892)
The bug report and feature request templates are pretty
straightforward.

The question template will hopefully drive people that just have a
question toward the forums.
2018-05-07 18:52:55 -04:00
Court Ewing 70528f62e6 Removing erroneous github issue template 2018-05-07 16:39:56 -04:00
Court Ewing b2a24a7e20 Update issue templates
Issue templates for bug reports, feature requests, and questions.
2018-05-07 16:37:46 -04:00
Spencer 0fde087ca2 Switch to Yarn (#15485)
* switch to yarn

* cleanup misc references to npm

* [yarn] loosen dependency ranges so yarn will merge more deps

* fix linting error now that moment uses ESM

* [licenses] font-awesome changed the format of its license id

* Use local yarn

* Misc fixes

* eslintignore built yarn file

* Remove mkdir which doesn't do what it should do

* Check build without upgrading lots of versions

* Fix license check

* too many moments

* Better description

* Review fixes

* Lock to angular@1.6.5

* More specific version locks

* Revert "More specific version locks"

This reverts commit 11ef81102e.

* Revert "Lock to angular@1.6.5"

This reverts commit 3ade68c14c.

* rm yarn.lock; yarn

* Forcing a specific version of React, Angular, Moment

* Using vendored version of yarn in ci

* Use --frozen-lockfile

* fixes
2018-01-10 13:23:43 +01:00
Court Ewing 2fbfa531c7 github: PR template checklist in a comment
The checklist of items in the PR description should be in a comment so
you don't have to manually remove them on every pull request.
2017-08-12 10:28:21 -04:00
Jonathan Budzenski e99cd96a3c
Add elasticsearch version to issue template 2016-07-25 11:00:27 -05:00
Matthew Bargar d8d4098dc9 Add browser and browser OS to issue template 2016-07-08 18:06:02 -04:00
Court Ewing a80287fbbe Correct PR template file name
09eb74a introduced a PR template with an incorrect file name, so github
does not use it for pull requests.
2016-06-11 16:46:35 -04:00
Court Ewing 09eb74a013 Issue and PR templates for github
Modeled after the templates used in the elasticsearch repo, these
templates will be used by github to prefill issue and pull request
bodies to help users avoid commonly encountered problems.
2016-06-11 16:41:33 -04:00