* - migrated use of legacy.client to client
- removed use of isEsError to detect legacy errors
- refactored types to use types from @elastic/elasticsearch
instead (where appropriate)
tested get, put, post, delete, simulate and documents endpoints
locally
* remove use of legacyEs service in functional test
* fixing type issues and API response object
* remove id from get all request!
* reinstated logic for handling 404 from get all pipelines request
* clarify error handling with comments and small variable name refactor
* updated delete error responses
* update functional test
* refactor use of legacyEs
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* chore(NA): add warnings both to run and watch commands about Bazel built packages
* chore(NA): add new commands to build and watch bazel packages
* docs(NA): add documentation about how to deal with bazel packages
* chore(NA): addressed majority of the feedback received except for improved error logging
* chore(NA): disable ibazel info notification.
* chore(NA): remove iBazel notification
* chore(NA): remove iBazel notification - kbn pm dist
* chore(NA): move show_results option to kbn-pm only
* chore(NA): patch build bazel command to include packages target list
* chore(NA): add pretty logging for elastic-datemath
* chore(NA): remove double error output from commands ran with Bazel
* fix(NA): include simple error message to preserve subprocess failure state
* docs(NA): missing docs about how to independentely watch non bazel packages
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* First pass at rebuilding nested object structure from fields response
* Always requests TIMELINE_CTI_FIELDS as part of request
This only works for one level of nesting; will be extending tests to
allow for multiple levels momentarily.
* Build objects from arbitrary levels of nesting
This is a recursive implementation, but recursion depth is limited to
the number of levels of nesting, with arguments reducing in size as we
go (i.e. logarithmic)
* Simplify parsing logic, perf improvements
* Order short-circuiting conditions by cost, ascending
* Simplify object building for non-nested objects from fields
* The non-nested case is the same as the base recursive case, so
always call our recursive function if building from .fields
* Simplify getNestedParentPath
* We can do a few simple string comparison rather than building up
multiple strings/arrays
* Don't call getNestedParentPath unnecessarily, only if we have a field
* Simplify if branching
By definition, nestedParentFieldName can never be equal to fieldName, which means
there are only two branches here.
* Declare/export a more accurate fields type
Each top-level field value can be either an array of leaf values
(unknown[]), or an array of nested fields.
* Remove unnecessary condition
If fieldName is null or undefined, there is no reason to search for it
in dataFields. Looking through the git history this looks to be dead
code as a result of refactoring, as opposed to a legitimate bugfix, so
I'm removing it.
* Fix failing tests
* one was a test failure due to my modifying mock data
* one may have been a legitimate bug where we don't handle a hit without
a fields response; I need to follow up with Xavier to verify.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add missing i18n
Oops
* Change button color
* Fix custom source created screen
* Add better empty state to groups
* Align toggle to right side of table
* Update design for security page
* Update ‘How to add’ view
* Update config completed view
* Update add source connect page
* Remove padding on how to add card
Original had no padding.
* CSS cleanup
* Refactor ResultActions component + DRY out link behavior
- Create new separate ResultActions component
- Pass actions array through to header and have haeder in charge of conditional visibility / FlexItem wrapper (this matches the other header items)
- shouldLinkToDetailPage: instead of generating custom JSX, just have it be a standard action and append it to the actions array
Link behavior:
- ResultHeaderItem - switch to EuiLinkTo, no need for extra wrapper
- ResultHeader - DRY out unnecessary extra path generation - instead pass down a conditional documentLink instead of a bool
* PR feedback: Fix test name
* PR feedback: unshift
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* migrator waits for source index to be yellow
otherwise the next request to Elasticsearch can fail
* unskip integration tests that failed due to a red cluster
* log how much the every step lasts
* use Date.now instead of performance.now migration cannot finish in ms
* update tests
* clean log file before running tests
* fix wrong type
* add an integration test for waitForIndexStatusYellow
## Summary
Can now pass a `force=true` parameter to add & remove integrations on hosted policies as originally intended [1] & [2]
* Add `force` param for `POST` `/api/fleet/package_policies` & `/api/fleet/package_policies/delete` to a policy. Update tests to confirm
* Not strictly required, but "while I was in there"
* Updated a few places to throw `IngestManagerError` vs `Error` for `400` response vs `500`. Updated tests.
* removed a few unnecessary `await`s of sync function
[1] https://github.com/elastic/kibana/issues/92426#issuecomment-785092670
[2] https://github.com/elastic/kibana/issues/90445
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [DOC] Index pattern and cluster exclusion examples with CCS
Providing some examples of using Index Pattern and cluster exclusions with CCS
* Update docs/management/index-patterns.asciidoc
* Update docs/management/index-patterns.asciidoc
* Update docs/management/index-patterns.asciidoc
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Fixes the problem where deselecting all fields for the scatterplot would also hide the UI to do the actual selection. Now, when all fields are removed from the combo box, the UI stays visible, just the scatterplot itself will be hidden.
* Workplace Search: Remove redundant Overview breadcrumb from Sources
There is "Source name" breadcrumb that is used for Overview page
* App Search: remove "Overview" breadcrumb from Engine page
So instead of `engines / national-parks-demo / overview (greyed)`
we will have just
`engines / national-parks-demo (greyed)`
* App Search: Add "Engines" breadcrumb to the main App Search page
This needs to be added to 3 states of the page: Normal, Empty and Loading
* Fix failing WS test
* App Search: DRY out SetPageChrome declaration by putting it in header
* Fix failed test "ShallowWrapper::dive() can only be called on components"
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [APM] Moves the Transaction type selector to the search bar (#91131)
* - Replaces the prepend label on the search bar with the transaction type selector
- Adds the transaction type selector to the service overview page
- Removes title from the Transactions list page
* removes unused i18n items
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Move all dashboard inject/extract to be part of embeddable persistable state
* Fixes typescript errors
* Remove comments
* Fixes test
* API Doc changes
* Fix integration tests
* Fix functional testS
* Fix unit tests
* Update Dashboard plugin API to get dashboard embeddable renderer
* Fix Types
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* generate endpoint event filters artifacts
* Add ExperimentalFeature object to the initialization params of ManifestManager
* create event filters artifacts if feature flag is on
* change artifact migration to be less chatty in the logs (also: don't reference Fleet)
* [Discover] Updating a functional test
* [Discover] Support for edit operation
* Fix unit tests
* Fix typescript
* Fixing failing functional test
* Fixing wrongly commented line
* Uncomment accidentally commented line
* Reintroducing accidnetally removed unit test
* Trigger data refetch onSave
* Remove refreshAppState variable
* Bundling observers together
* Clean state before refetch
* Update formatting in data grid
* [Discover] Updating a functional test
* Adding a functional test
* Fixing package.json
* Reset fieldCount after data fetch
* [Discover] Updating a functional test
* Don't allow editing of unmapped fields
* Fix issues with mobile display
* Allow editing if it's a runtime field
* [Discover] Updating a functional test
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
