Fixes https://github.com/elastic/kibana/issues/20099
I made the changes described by Tim at https://github.com/elastic/kibana/issues/20099 and everything seems to be working. I tried to update the typeahead in such a way that it can be made accessible anywhere it is used, even if there are multiple typeahead instances on a single page.
> (optional) an aria-label on the individual suggestions that should be read out to screen reader. By default the content will be used, and that should be fine (unless you figure out there is too much "noise" elements in it.
I did not do this bit since the text that is read seems reasonable to me, but I'm open to changing it if others feel differently.
* Show more of the name column in the Watcher watch table by making the table 100% width of the page, and by increasing the column width to 25%.
* Convert all title attributes to kbnTooltip.
* Add title attributes for columns which have tooltip content different from cell content.
* Add Guideline for i18n engine
* Update Guideline according to changes in i18n engine.
* Update examples in Guideline
* typo
* improve i18n guideline: add table for better view, use single quotes for js strings, fix description for testing, use uniq "message id" name
* fix readme description for guideline
Co-authored-by: maryia-lapata "mary.lopato@gmail.com"
* [ML] [WIP] Adding group selector to jobs management
* adding group name validation
* removing comment
* adding keyboard events
* moving new group input to its own component
* changes based on review
* adding tooltip
* adding better error reporting
* add now query parameter to sample data install endpoint
* joi returns date, so no need to create a new one
* add API functional tests for now parameter
* Typescriptify dashboard panel actions
Doesn't include build_context_menu because that has some eui dependencies, will tackle in another PR.
* early exit
* Add screen reader only text for monitoring charts
* Add aria label for completed recoveries
* Ensure we have aria label coverage for monitoring chart tooltips
* Ensure table rows are tabbable and include the number of results at the top
* Use EuiScreenReaderOnly
* Updated copy
* Use EUI
* Remove kui usage
* Use an id instead of aria-label
* Show results in the table footer
* Revert "Show results in the table footer"
This reverts commit d622eb7eb4.
* Show total row count within the monitoring table
* PR feedback
* PR feedback
* Ensure all charts show an interval in the tooltip
* Fix padding issue with the cluster status
* Convert xpack license check to use banners service.
* Remove notifier directive method.
* Remove notifier banner directive.
* Simplify pullMessageFromUrl and move it into its own appRedirect module.
* [core/public/legacyPlatform] render into a child of the rootDomElement
* [kbn-chrome] use #kibana-body selector for ensuring root height
* after feedback in #20752, clear elements by setting textContent
* [browserTests] mount CoreSystem in a child, we require stuff in <body>
* [core/public] ensure the rootDomElement is full-screen
* add some comments tieing together root style rules
* use `readonly` for unchanged properties
* avoid unnecessary recreation of default param
* comment about why coreSystem is not rendered into body in the tests
* use more destructuring
* rename argument in callback type signature
* fix typo
* [core/public/styles] switch from less to css
a36b87a#diff-aff92ff718af4b68d02f030d8a438754 added an ng-if around the available fields button element. ng-if creates a child scope. The ng-click on the button directly modifies scope state. As a result, when the ng-if was added, that ng-click began modifying the ng-if's child scope instead of the parent scope.
The best solution would be to update the discFieldChooser directive to use the controllerAs property so its scope variables are namespaced. However, this is a bit risky because I'd need to make sure to update every single scope variable reference in the template, and it's a relatively large template. Since we'd like to backport this to 6.4 I've taken the less risky route of adding $parent to the scope reference inside the ng-if block.
* trying new EuiWrappingPopover
* allow button press to close popover
* fix button styling
* start options panel with darkTheme option
* add other options
* remove old options html
* get dashboar state functional test working
* Convert info button and the rest of the page to EUI
* Update other overview pages
* Use Page directive
* Give the tooltip some more space
* Add page body to a couple places
* PR feedback
* Convert beats overview page to use EUI components
* More UI components for beats overview
* Set background color to white
* Update snapshots
* Add PageBody wrapper
* Update snapshots
* Use panels
* PR feedback
* Update snapshots
* Turn reporting snapshot tests back on with new baselines
* Use snapshots generated from chromium. Bump the threshold so phantom comparisons pass
* Increase timeouts because of chromium functional tests.
* remove accidentally checked in session snapshots
* add a better vis baseline, run once through at 0 to check expected threshold
* turn on verbose logs
* Use threshold, turn debug mode on in jenkins
* Wrap both convert pages in the retry
* Update baselines
Preserve layout one got messed up - it was actually a print layout.
* bump threshold even more
* use SavedObjectsClientProvider to provide SavedObjectLoader with an angular wrapped saved object client
* Improve filterBar.addFilter performance
* Add better documentation
* Ease logic of addFilter and add better docs
* Fix old addFilter calls
* [kbn-test] convert kibana-install-dir flag to installDir option
* [kbn-test] replicate kibana-install-dir handling to startServers
* [ftr] try running functional tests in production in CI
* Revert "[ftr] try running functional tests in production in CI"
This reverts commit e5b94aa024.
* [core/public/legacyPlatform] exclude ui/test_harness from the distributable
* [optimizer] fix `process.env.IS_KIBANA_DISTRIBUTABLE` definition
* [optimizer] only define `process.env.IS_KIBANA_DISTRIBUTABLE` when needed
Adding a `webpack.DefinePlugin` slows down the optimizer a small amount,
so only apply it when it is necessary, and skip it if it is going to
be defined as "false".
* [kbn-test/startServer] don't run in --dev mode if running from dist
* [ftr/kibanaServer/version] attach `-SNAPSHOT` suffix to version if running build_snapshot
* Remove implementation detail assertion from objects table test.
* Reset selection state when table state or query state changes.
* Remove total count from title.
