- Fixes getTabs() to always return an array. I was wondering why TypeScript didn't flag the tabs.map(...) part because tabs could possibly be undefined. It's because Record assumes that every key exists. More on that can be found in this blog post.
- This PR fixes a) the type of TAB_MAP by wrapping it in Partial<...> so it correctly flags the tabs.map() part with tabs possibly being undefined and b) fixes getTabs()'s return value by always returning an array.
* Keep state of host/netwrok table when switching tab
* keep state in the event viewer when switching tab in host page
* refactor test to ensure activePage updates from prop change
* rm comments
* add/fix unit test
* fix i18n
* need to rm weird files
* rm weird files
* fix inspect button for real + loading view between tabs
* cleanups
* commented by mistake
* fix logic loading
* review I
* review II
* review III
* review IV
* EUIficate pointe-series and grid
* Apply TS
* Show grid on a panel
* Remove extra space
* Add TS
* Use BasicOptions
* Adjust func test
* Add dataTestSubj prop to SelectOption
* Use id instead of data-sest-subj
* Disable show x-axis lines when there is histogram agg
* Add tooltip for disabled 'Show x-axis lines' config
* Add series_options.tsx
* Migrate series
* Improve changeValueAxis
* Create CategoryAxisPanel
* Create ValueAxesPanel
* Create CustomExtentsOptions
* File renaming
* Use TruncateLabelsOption
* Set min value
* Add validation
* Refactoring
* Move types upper
* Convert series logic
* Convert valueAxes logic
* Rename function
* Add validation and refactoring
* Adjust styles
* Fix rotates
* Apply config for other vis
* Remove old directives
* Fix useHook usage
* Update vislib_vis_type.js
* Fix
* Move Threshold line panel into a separate component
* Remove unused translations
* Apply ui suggestions
* Update functional tests
* Remove angular unit test
* Refactoring
* Fix dependencies
* Refactoring
* Add validation
* Add validation for other vis
* Refactoring of onPositionChanged handler
* Refactoring of addValueAxis
* Get rid of a useEffect
* Refactoring of updateAxisTitle
* Update useCallback
* Refactoring
* Refactoring of collections config
* Refactoring of setChartValueByIndex and setValueAxisByIndex
* Update metrics_axes_options.tsx
* Watch current tab for correct accordion height
* Revert axis title logic
* Fix axis id and name number
* Fix code review comments
* Fix functional tests
* Update visualize_page.js
* Move option tabs in common
* Fix code review comments
* Update index.tsx
* Refactoring
* Fix merge conflict
* Show ThresholdPanel when it's configured
* Fix passing a current tab to vis-options
* Localize 'Count' text
* Pass one axis to CategoryAxisPanel
* Fix y-axis name number when x-axis position changed
* Fix Y-axis name number when position Y-axis changed
* Fix refresh loop
* Re-organize controls
* Apply code review comments
* Refactoring
* Fix extents empty value
* Update y_extents.tsx
* Fix code review comments
* Fix updating several seriesParams when removing axis
* Add thresholdLine config to horizontal bar
* Refactoring
* Reset grid.valueAxis when the axis deleted
* Fix refresh loop
* Set interpolate config for line
* Enable "show dots"
* Translated shortcut descriptions
* Added i18n to HelpMenu and KeyboardShortcutDocs components
* fixed i18n errors
* Removed unnecessary type
* Updated snapshot
* Adds a description for shortcut separator in the KeyboardShortcutsDoc
* Add main nav tabs with sub tabs for new nav
* move transforms to top level main nav
* Make top nav normal font weight
* Update breadcrumbs to take top nav into account
* proper spacing when settings selected
* fix localization error
* Fix functional tests. Update breadcrumbs
* revert analytics breadcrumb update. save for follow up
* ensure main/sub tabs align left
* update dataVisualizer breadcrumbs
* update typescript for tabs
Renamed the misleadingly named AlertInstance.fire to scheduleActions, as it does not in fact "fire" the actions, but rather schedules them to be executed by the Task Manager at the next available opportunity.
## Summary
To indicate they accept droppable data providers, this PR applies highlighting to the Timeline flyout badge and data providers drop area.
Tested in dark and light mode in:
- Chrome `76.0.3809.132`
- Firefox `69.0`
- Safari `12.1.2`
## Timeline data providers (drop area) highlighting behavior
- While a data provider is being dragged, in a page or from within the timeline itself, apply `euiColorSuccess` to the timeline data providers drop area's dashed borders and "plain" text, but NOT to the other primitives, i.e. data provider badges, `AND` / `OR` circular badges, lines, etc
- While a data provider is being dragged, in a page or from within the timeline itself, but NOT hovering over the data providers drop area, apply the `euiColorSuccess` color with `10%` alpha channel to the background of the data providers drop area
- While a data provider is being dragged over the drop target area inside the data providers drop zone, apply the `euiColorSuccess` color with `20%` alpha channel to the background of the data providers drop area
- While a data provider is being dragged over the drop target area inside the data providers drop zone that will add the data provider as an `AND` clause, apply `euiColorSuccess` color to the dashed border, and fill the background with the `euiColorSuccess` color with `30%` alpha channel to the background of the data providers drop area
- Do NOT apply highlighting styles when a column or field (non-data provider) is dragged from the timeline or the `Events` widget
### Dark mode
![timeline-highlighting-dark](https://user-images.githubusercontent.com/4459398/64755303-ebcb1680-d4e7-11e9-8452-0f91ddae85d1.gif)
### Light mode
![timeline-highlighting-light](https://user-images.githubusercontent.com/4459398/64755318-fc7b8c80-d4e7-11e9-8621-a7eb918468aa.gif)
## Flyout button highlighting behavior
- The (default) timeline flyout button is styled as non-filled EUI button
- The button text reads `Timeline ^` (with a trailing caret), instead of `T I M E L I N E`
- Hovering over the flyout button while NOT dragging underlines the flyout button text, but does not fill the background
- When a user starts dragging a data provider, apply `euiColorSuccess` to all visible flyout button properties (e.g. border, text)
- While a data provider is being dragged, in a page or from within the timeline itself, but NOT hovering over the flyout, apply the `euiColorSuccess` color with `10%` alpha channel to the background of the flyout button
- While a data provider is being dragged, in a page or from within the timeline itself, AND hovering over the flyout such that it's in a droppable state, apply the `euiColorSuccess` color with `20%` alpha channel to the background of the flyout button
- While a data provider is being dragged, in a page or from within the timeline itself, AND hovering over the flyout such that it's in a droppable state, replace the `Timeline ^` with a circle containing a `+` plus sign
- Apply `EuiNotificationBadge` styling to the data providers badge count, and position it in the upper left-hand corner
- Do NOT apply highlighting styles when a column or field (non-data provider) is dragged from the timeline or the `Events` widget
### Dark mode
![timeline-badge-dark](https://user-images.githubusercontent.com/4459398/64755512-5ed48d00-d4e8-11e9-9be2-02da70ac4e16.gif)
### Light mode
![timeline-badge-light](https://user-images.githubusercontent.com/4459398/64755531-7449b700-d4e8-11e9-9239-62ee78a6e652.gif)
Resolves https://github.com/elastic/siem-team/issues/457
* Pipeline
* WIP some work for parallelization with ciGroups
* Fix xpack kibana install dir, and add some debugging
* Attempt to quick fix a few tests
* Revert "Revert "Revert "[ci] compress jobs for CI stability" (#44584)""
This reverts commit 078ac2897f.
* Recombine test groups, and try runbld again
* Mostly cleanup, and fix failed_tests reporting to hopefully work for both pipeline and non-pipeline
* Fix typo in shell script
* Remove some debug code
* Add support for changing es transport.port during testing via TEST_ES_TRANSPORT_PORT
* Fix test that uses hard-coded es transport port and add it back in to parallel groups
* Disable checks reporter again for now
* Set env var for TEST_ES_TRANSPORT_PORT in pipeline
* Update Jenkinsfile for shorter testrunner labels
* Fix another hard-coded transport port
* Fix a new test with hard-coded URLs
* Jenkinsfile cleanup and fix one of the groups
* Fix double slash
* Testing vault credentials on jenkins server
* Add a non-existent credential
* Revert "Add a non-existent credential"
This reverts commit 0dc234c465a5483b1a994cb510a182fef766e9cc.
* Try github-checks-reporter again
* github-checks-reporter should only run for elastic/kibana, forks won't work
* Clean up some debug code
* Changing names around to try to make BlueOcean UI a little better
* Add more stages
* Make some changes to stage structure to mirror a nested example from CloudBees
* Handle TODOs, and some cleanup in Jenkinsfile
* Pass GIT_BRANCH when started without GHPRB, fix branch check
* Fix mailer problem and add code that ensures all tests are in cigroups back in
* Test adding worker/job name to junit report paths
* Remove some duplication from ci_setup scripts
* Fix unit test that uses junit path
* Don't reinstall node every time setup_env is run
* Fix yarn install logic
* Fix another unit test that uses junit output dir
* Download latest ES snapshot after kibana builds
* Make sure junit reports are always processed
* Add two failing tests for testing purposes
* Add support to Jenkinsfile for kibana build e-mails
* Remove some debug code for email sending
* Change JOB env handling in junit paths and move it to a sub-directory
* Revert "Add two failing tests for testing purposes"
This reverts commit 5715203e26922a93483feb0ebb8bb3fdcc3daf8c.
* Fix junit report path in test
* Don't send kibana emails on build abort
* Address PR feedback, formatting and use built-in url formatting library
* Fix path formatting for functional test
* Add email sending back in to Jenkinsfile
* Fix another unit test with path problem
* Fix main search bar to top of screen
By allowing overflow on the main content, we implicitly fix the sibling
search bar in position.
elastic/code#1606
* Allow search suggestion text to be truncated
This gives the parent element a width, so that our text-overflow
rules apply to these elements.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1086218#c4 for details
on the issue.
* Fix alignment issue with overflowed search suggestions
If both the icon and the text are allowed to grow/shrink as needed,
flexbox will grow truncated text based on its original width, leading to
subtle sub-pixel alignment issues with other rows.
By fixing the icon to a specific width, we can ensure that the
suggestion text does not grow too big.
* Remove unneeded CSS
We don't need to flex these elements currently as they contain either no
children or inline elements only.
* style: prefer camelCase element names over hyphens
* Fix search result suggestion overflow on IE
Without this directive on the parent, it had no width or flex growth and
didn't respect the parent width. This allows it to take on the correct
flexed width, and thus take on the overflow rules.
* Remove unused CSS rule
We have an overriding align-items declaration immediately after this
one.
* wip to apply kql when refresh on hosts page
* refactor to have less re-render
* add network and timeline page
* fix/add unit testing
* from review remove any effect from render
* clean up + review II
* review II + bug fixes
* review III
This changes the job health check of the log analysis page to consider finished jobs as healthy. This situation is relevant when the job is non-continuous, i.e. created with a definite end date.
At the same time it ensures that datafeeds that failed to be started due to empty indices lead to the jobs being considered unhealthy.
fixes#45180
* SQL template with triple quote in completion
* Slight update to SQL query template and bugfix for collapse/expand of request bodies
* Add comment and slight update to triple quote expansion
* Updated tests after changes to newline behaviour
* Restore old backslash triple quote expansion behaviour
* i18n work on workpad header and a few header ctas
* Convert WorkpadHeader to typescript
* String ordering cleanup
* Addressing some feedback
* Adding state
* lint
* Shortcut type refactor
* Revert "Shortcut type refactor"
This reverts commit d00e48853bcb16fdb14f9bca8b2536c920e8d650.
* Using new State type
* Removing unused type
* Updating state type