* Fix CURRENT_MAJOR_VERSION for use in Elastic docs links
- Was previously just sending (e.g.) "7". instead of "7.9"
* Add App Search DOCS_PREFIX constant
- follow WS's example
* Update all App Search doc links to use prefixed URLs
- except for Enterprise Search setup guide, which should be updated to use a shared URL at some point in any case
* Moved out type for OperatingSystem and moved OS translations one level higher.
* Changed the translation to be consistent between trusted apps and policy.
* Unified translations of OS types between trusted apps and policy.
* Removed unused types.
* Added registered AV form section.
* Changed the property structure to match the format expected by endpoint.
* Fixed the visual alignment of titles in the form and added responsiveness.
* Updated snapshots.
* Moved out type for OperatingSystem and moved OS translations one level higher.
* Added config form heading component.
* Cleaned up translations.
* Fixed type error with initialization.
* Fixed error in trusted app creation form test.
* Removed the guard for now in favour of better initialization.
* Fixed the store test.
* Fixing functional test data.
* Added functional test config option to account for a custom header within security app.
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
resolves https://github.com/elastic/kibana/issues/79785
Until now, the execution status was available in the the event
log document for the execute action. In this PR we add it.
The event log is extended to add the following fields:
- `kibana.alerting.status` - from executionStatus.status
- `event.reason` - from executionStatus.error.reason
The date from the executionStatus and start date in the event
log will be set to the same value.
Previously, errors encountered while trying to execute an
alert executor, eg decrypting the alert, would not end up
with an event doc generated. Now they will.
In addition, there were a few places where events that could
have had the action group in them did not, and one where the
instance id was undefined - those were fixed up.
* [ML] table config in the URL state
* [ML] fix job list on the management page
* [ML] store query filter in the URL
* [ML] fix context for the management page
* [ML] update module_list_card.tsx in Logs UI
* [ML] fix unit tests
* [ML] fix unit tests
* [ML] fix unit tests
* [ML] move utils functions
* [ML] url generator to support both job and group ids
* Add index template link to data stream details
* Fixed ILM policy link and added a check for index template name after navigation
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
## Summary
Packages/Archives aren't limited to the registry any longer. Continue moving file- & cache-related functions from services/registry to services/archive.
Move `getAsset` and `pathParts` to archive/index. The behavior is the same for now, but it's more accurate to separate these from registry namespace.
Registry has `fetch*` and other functions for dealing with the online service.
...and into x-pack.
Also remove `PromiseReturnType` from APM and use the copy in observability everywhere.
All of the additional changes to APM imports are just automatic sorting.
This makes doing #77720 a little easier and removes some implicit circular dependencies for #80508.
Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
* [Workplace Search] Consolidate groups routes
This PR consolidates all of the groups route resgistration functions into a single export so that the `registerWorkplaceSearchRoutes` function only has to call the top-level routes
* Remove redundant test
* [Workplace Search] Add routes for Sources
This change updates the logstash pipeline management plugin to use
pipeline management APIs in Elasticsearch rather than directly
accessing the .logstash index. In Elasticsearch 8.0, direct access to
system indices will no longer be allowed when using standard APIs.
Given this change, a new set of APIs has been created specifically for
the management of Logstash pipelines and this change makes use of the
APIs.
Co-authored-by: Kaise Cheng <kaise.cheng@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ES:#53350
LS:#12291
* Fix detection of 4xx errors in grokdebugger simulate endpoint
- removed code to call simulate endpoint from "KibanaFramework"
- fixed throwing of string value
- using new elasticsearch client instead of legacy
- handle error with shared error handling logic
* added deprecation notice to register route on KibanaFramework
* remove deprecation notice
## Summary
Adds additional cypress tests and utils around value lists so that the percent of test driven development (TDD) possibilities will be easier for us to accomplish around bug fixes towards the next release.
* Changes and adds data test subjects within value based lists
* Fixes a bug where the list fixtures were not being converted to base64 before uploads within Cypress
* Adds a [CIDR](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing) fixture
* Adds tests for export, delete, close and open the dialog, and all the value based list types for the current modal.
### Checklist
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
* Fix threshold rule synthetic signal generation
* Use top_hits aggregation
* Add timestampOverride
* Account for when threshold.field is not supplied
* Ensure we're getting the last event when threshold.field is not provided
* Add missing import
* Set up required types
- creating new schema types for now as part of engine details
+ update shared IEngine type
* Migrate EngineLogic file
- w/ basic Kea updates & http call update
* Opinionated cleanup / changes
- | {} is needed for typescript to stop linting but will result in significant code changes / requirements for existence checks downstream
- setIsLoading and dataLoading were previously not being used in ent-search but I plan to change that so that it is used.
- move some reducers to selectors as more applicable
- add hasSchemaConflicts in preparation for upcoming view conditional
* Update EngineLogic w/ recent ent-search changes
* Write tests for EngineLogic
* [PR feedback] Kea best practices
## Summary
* Separate unpacking an archive from caching it or other side-effects
* Parse and validate an archive before caching it
* Validation has no coupling with caching side-effects or any other code outside the `validation.ts` file
```diff
- const paths = await unpackArchiveToCache(archiveBuffer, contentType);
- const archivePackageInfo = parseAndVerifyArchive(paths);
+ const entries = await unpackArchiveEntries(archiveBuffer, contentType);
+ const { archivePackageInfo } = await parseAndVerifyArchiveEntries(entries);
+ const paths = addEntriesToMemoryStore(entries);
```
### Checklist
- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
* [All] Remove prefixes on simple self-contained type defs
- Types should not be exported
- Types should not be used outside each affected file
* [All][kea] Remove ts prefixes and unnecessary exports
Kea now takes care of type checking for us, so there should virtually never be a need to export our values and actions interfaces going forward
* [shared] Remove createHref type prefixes
* [shared] Remove breadcrumb prefixes
* [shared] Remove telemetry prefixes
* [shared] remove types.ts
Opionionated change: it was only being used for IFlashMessage, and at this point I think it's more useful to go in one level deeper to grab the type you need
* [server] remove route dependencies prefixes
* [server] Various type cleanups
- plugin.ts - remove unnecessary export
- MockRouter - remove prefix for request type, change IMockRouter to match Kibana's IRouter
- check_access - remove prefixes
- callEnterpriseSearchConfigAPI - remove prefixes
- EnterpriseSearchRequestHandler - remove prefixes
* [common] Remove InitialAppData prefix
+ remove unnecessary export from public/plugin.ts
* [common] Remove Meta prefixes
* [common] Remove configured limits prefixes
* [AS] Remove Account and Role prefixes
* [AS] Remove Engine prefixes
* [AS] Remove credentials prefixes
* [AS] Remove log settings prefixes
* [WS] Remove account/organization/initial data prefixes
* [WS] Remove group(s), user, & content source prefixes
+ GroupLogic and GroupsLogic refactor - remove unnecessary defs in actions, it's already defined in the Actions interface above and in some cases (e.g. old History param) is causing out of date issues
* [WS] Misc type fixes
- TSpacerSize -> SpaceSizeTypes
- SourcePriority - remove prefixes
- IComponentLoader - this isn't used anywhere else and appears to be component props so it probably should live only within component_loader.tsx
- Remove recent feed activity prefix
* [WS][Opinionated] Move interfaces not used in server/ out of common/ and to public/
* Fix recently rebased types
* [Maps] saved objects by value
* inject references when unwrapping
* clean up map embeddable initialize
* use attribute service to load savedMap
* clean up
* remove clear ui since each route has its own store instance
* save
* update for API changes
* pass input to stateTransfer
* remove map saved object loader
* remove unused store_operations
* add saved objects to recently accessed
* provide default description
* break originatingApp connection when not returnToOrigin
* clean up file structure
* clean up adding help menu
* use SavedMap in map_embeddable to remove dupicated load attributes code
* clean up
* restore imports
* clean up breadcrumbs to match lens
* fix check for duplicate title
* tslint
* make title map saved object attribute required
* fix jest tests
* fix logic for hasSaveAndReturnConfig to not show save and return button with new map and allowByValueEmbeddables disabled
* tslint
* fix functional test by triggering MapApp render after save
* rename map_app_container to map_page
* move MapApp and redux connector into folder
* review feedback
* use MAP_PATH constant
* update by reference saved object on save and return
* cleanup breadcrumbs and title
* properly handle deleted map saved objects
* tslint cleanup
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [All] Remove prefixes on simple self-contained type defs
- Types should not be exported
- Types should not be used outside each affected file
* [All][kea] Remove ts prefixes and unnecessary exports
Kea now takes care of type checking for us, so there should virtually never be a need to export our values and actions interfaces going forward
* [shared] Remove createHref type prefixes
* [shared] Remove breadcrumb prefixes
* [shared] Remove telemetry prefixes
* [shared] remove types.ts
Opionionated change: it was only being used for IFlashMessage, and at this point I think it's more useful to go in one level deeper to grab the type you need
* [server] remove route dependencies prefixes
* [server] Various type cleanups
- plugin.ts - remove unnecessary export
- MockRouter - remove prefix for request type, change IMockRouter to match Kibana's IRouter
- check_access - remove prefixes
- callEnterpriseSearchConfigAPI - remove prefixes
- EnterpriseSearchRequestHandler - remove prefixes
* [common] Remove InitialAppData prefix
+ remove unnecessary export from public/plugin.ts
* [common] Remove Meta prefixes
* [common] Remove configured limits prefixes
* [AS] Remove Account and Role prefixes
* [AS] Remove Engine prefixes
* [AS] Remove credentials prefixes
* [AS] Remove log settings prefixes
* [WS] Remove account/organization/initial data prefixes
* [WS] Remove group(s), user, & content source prefixes
+ GroupLogic and GroupsLogic refactor - remove unnecessary defs in actions, it's already defined in the Actions interface above and in some cases (e.g. old History param) is causing out of date issues
* [WS] Misc type fixes
- TSpacerSize -> SpaceSizeTypes
- SourcePriority - remove prefixes
- IComponentLoader - this isn't used anywhere else and appears to be component props so it probably should live only within component_loader.tsx
- Remove recent feed activity prefix
* [WS][Opinionated] Move interfaces not used in server/ out of common/ and to public/
* [Lens] Use entire layers, not specific columns
* Fix types
* Move all of state_helpers over
* Fix tests
* Fix crash and add tests to prevent future issues
* Prevent users from dropping duplicate fields
* Respond to review feedback
* Fix review feedback
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Workplace Search] Consolidate groups routes
This PR consolidates all of the groups route resgistration functions into a single export so that the `registerWorkplaceSearchRoutes` function only has to call the top-level routes
* Remove redundant test
