Commit graph

21351 commits

Author SHA1 Message Date
Leanid Shutau b166eda54f
[Tools] Add string concatenation parsing (#25381) 2018-11-09 12:25:36 +03:00
Tiago Costa dc956a0a79
Fix non-conforming licenses on devDependencies and add the ability to whitelisting devOnly licenses (#23859)
* chore(19834): upgraded yargs dependency to 4.8.1 in order to remove pkg-conf dependency license conflict.

* chore(19834): override xmldom to one of the allowed licenses (MIT).

* chore(19834): added some overrides and whitelistenig for Apache2.

* chore(19834): correct overides for some apache2 licenses.

* chore(NA): updated specific dependency needs.

* chore(19834): added some more info on updated licenses.

* chore(19834): small note on dependencies use versions.

* feat(NA): add the ability to white list licenses only valid for dev only dependencies.

* chore(NA): update yarn lock files to include integrity check.

* fix(NA): yarn lock file for kbn ui framework.

* docs(NA): fix uncompleted comment left on the code.
2018-11-09 02:11:17 +00:00
Joe Fleming 830c195b0d
fix: get correct plugins path (#25448)
we can't check the name of the outer path because it can change, instead, just make sure there's a plugins path there
2018-11-08 17:37:17 -07:00
Søren Louv-Jansen d181d4dc8e
[APM] Minor cleanup of constants (#25177)
* [APM] Minor cleanup of constants

* Simplify constants test
2018-11-09 00:20:00 +01:00
Søren Louv-Jansen 65ae04a5bd
[APM] Format as microseconds (#24974)
* [APM] Format as microseconds

* Split interface into `value` and `options`

* Update formatters.test.ts
2018-11-09 00:19:20 +01:00
Brandon Kobel 0fcd992232
Upgrading grunt-contrib-watch (#22818) 2018-11-08 14:09:00 -08:00
CJ Cenizal e2079c6373
Wrap long field names in Rollup Job Wizard tables. (#25405) 2018-11-08 14:00:00 -08:00
liza-mae 66ea68a376
Update clickOptionalAddNewButton method used in createIndexPattern (#25414) 2018-11-08 14:27:14 -07:00
gchaps 9eda63f719
[DOCS] Updates information regarding usage of sample data indices (#25424) 2018-11-08 13:18:16 -08:00
Pete Harverson 000cac77a9
[ML] Fixes the layout of the cards in the Data Visualizer on IE (#25383) 2018-11-08 21:17:40 +00:00
Pete Harverson df0d62f6ed
[ML] Updates job type and APM module icon to new designs (#25380)
* [ML] Updates job type and APM module icon to new designs

* [ML] Use self closing tags for icons

* [ML] Removes unnecessary icon from jobs list
2018-11-08 21:13:59 +00:00
Søren Louv-Jansen 051c23915d
[APM] Fix gap in timeline and fallback when traceroot is missing (#25346)
* Fix gap in timeline

* Show fallback when traceroot is unavailable

* Fix test

* Fix rendering issues with styled-components

* Remove `parentTransactionSkew `

* Minor test fixes
2018-11-08 22:08:39 +01:00
Walter Rafelsberger f2a0b9600c
[ML] angularjs controller initialization tests. (#25382)
* [ML] Confirm Modal Controller Test.

* [ML] Message Bar Controller test.

* [ML] Data Visualizer Controller test.

* [ML] Detector Filter Modal Controller test.

* [ML] Detector Modal Controller test.

* [ML] Save Status Modal Controller test.

* [ML] Multi Metric Create Job Controller test.

* [ML] Population Create Job Controller test.

* [ML] Recognize Create Job Controller test.

* [ML] Single Metric Create Job Controller test.

* [ML] Index Or Search Controller test.

* [ML] Job Type Controller test.

* [ML] Angular Bootstrap Patch Dropdown Controller test.

* [ML] Settings Controller test.

* [ML] Calenders List Controller test.

* [ML] New Event Modal Controller test.

* [ML] New Event Modal Controller test.

* [ML] Create Calendar Controller test.

* [ML] Time Series Explorer Controller test.

* [ML] Fixes typo, clearer test name.

* [ML] Fixes tests by restoring stubs.
2018-11-08 21:21:34 +01:00
Nathan Reese b9e258f766
Update "Debugging server code" instructions in CONTRIBUTING.md (#25397)
* Add more details for debugging Kibana server

* add debugging server code to table to contents
2018-11-08 13:15:03 -07:00
Lisa Cawley 72ac1a9b8b
[DOCS] Clarify security requirements for monitoring (#24881) 2018-11-08 12:03:48 -08:00
gchaps eb923430ae
[DOCS] Adds early draft of Canvas docs (#25395)
* [DOCS] Adds early draft of Canvas docs

* [DOCS] Added images and beta label to Canvas docs
2018-11-08 11:50:51 -08:00
Søren Louv-Jansen d6ad6dfafe [APM] Fix Rison issues (#25377)
* [APM] Fix Rison issues

* Fix CI

* Removed abstractions (and broke tests)

* Slight rework and small bugfix for query param handling

* Removed typo used for visibility testing oops

* Removes unused dep because linting doesnt work apparently
2018-11-08 14:07:18 -05:00
Søren Louv-Jansen 94b2aa4e0d
[APM] Fix missing transaction message (#25353) 2018-11-08 19:25:26 +01:00
Brandon Kobel 37b921b8a2
Using the new ES Realm syntax for SAML (#25223) 2018-11-08 09:28:53 -08:00
Lisa Cawley a0db3c4ca8
[DOCS] Adds data visualizer restriction (#25399) 2018-11-08 09:26:50 -08:00
Chandler Prall a62252ce40
Update EUI to v5.0.0 (#25316)
* update EUI to v5.0.0

* update snapshots

* revert snapshot change

* revert snapshot change (2)
2018-11-08 10:16:44 -07:00
Matthew Kime 96c733cebb
EAH - add typescript to a couple of ui/public/utils files (#23946)
* typescriptin a few ui/public

* remove mistaken commits

* typescript numeric

* ts migrateLegacyQuery

* object or string type

* no need for file extension on import statement

* revert mistaken commit

* type fix - only object

* snake case!
2018-11-08 10:58:59 -06:00
Lisa Cawley 1c86dbdd9d
[DOCS] Fixes typo in Kibana create role example (#25345) 2018-11-08 08:54:35 -08:00
Joe Fleming c79fac22fa
Fix: Asset preservation (#25359)
* fix: proptype error

* fix: correct proptype checking

* fix: add assets placeholder to initial state

* chore: add history formatting function

* fix: load workpad assets when ids change

this causes the correct assets to be used
2018-11-08 09:20:28 -07:00
Clint Andrew Hall 80073b4555
Fix File Upload fatal (#25361)
## Summary (fixes #25342)

There is a fatal when using the File Upload control in the image upload control.  While the fatal appears to originate within the File Upload control, it is actually [coming from](https://github.com/clintandrewhall/kibana/blob/file-upload/x-pack/plugins/canvas/public/components/loading/index.js#L15) `Loading`, which attempts to use `react-redux` to change the `backgroundColor` of the loading indicator based on the page.

I couldn't find an instance where we use this Loading indicator outside of a redux context, so I've opted to simply use the control directly.  @rashidkpc agreed this would be a good fix for the moment.

In addition, I fixed a props error coming from the data-url field that made it read-only, so I fixed that, too, as well as a formatting issue with the Set button.

## Test Plan

Added a `setTimeout` call to simulate load.  Toggled between data url and literal URL.

![screen shot 2018-11-07 at 6 47 32 pm](https://user-images.githubusercontent.com/297604/48171133-20ff4a80-e2c0-11e8-9b9f-71818801744a.png)

- Before
![screen shot 2018-11-07 at 7 11 48 pm](https://user-images.githubusercontent.com/297604/48171320-09749180-e2c1-11e8-8a2a-f87d564944c1.png)
- After
![screen shot 2018-11-07 at 6 57 17 pm](https://user-images.githubusercontent.com/297604/48171134-20ff4a80-e2c0-11e8-9bec-f129cfbfaa18.png)
- Fixed Warning
![screen shot 2018-11-07 at 7 11 57 pm](https://user-images.githubusercontent.com/297604/48171334-142f2680-e2c1-11e8-8ab6-ee06e6231e6b.png)

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~
~~- [ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~
~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
~~- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~
2018-11-08 09:57:51 -06:00
nicknak c2425c1cdd
Auto open browser on server startup (#24843)
* Adds dev dependency on opn for opening browsers and other things.

* Adds a --open option to cli to open browser window.

* Removes unused variable in index.

* Adds opn types to dev dependencies from definitely typed.

* Adds open to the cliArgs type to allow for consistency.

* Updates snapshots that require valid cliArgs types.

* Moves opn to direct dependency since its used in cli.

* [cli] move --open handling to cluster manager

* Adds support for running --open with --no-base-path
2018-11-08 09:12:01 -05:00
Carlos Pérez-Aradros Herce c757990be1 Relax hosts validation in Beats central management (#25376)
Current regexp was disallowing schema part of the URL (https://), so
https hosts couldn't be configured.

I opted for fully relaxing the reg exp here, as Beat will check it
anyway, and report errors in case it's wrong.
2018-11-08 07:47:17 -05:00
Matt Apperson 03d1597903
[BeatsCM] Allow for config based override of default user role (#25364)
* Allow for config based override of default user role

* [beats-cm] convert xpack.beats.defaultUserRole to array of roles

* [beats-cm] keep this context in #checkLicense
2018-11-08 07:12:54 -05:00
Lukas Olson aa61b7a88f Fix Canvas autocomplete to suggest all functions (#25351)
* fix: getFunctionDefinitions to load after the registry has been populated

* fix: use getBrowserRegistries instead of registry itself
2018-11-07 19:01:49 -07:00
Tyler Smalley cb40475a35
[migrations] Disable replicas (#25274)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 16:15:36 -08:00
Tyler Smalley 3fc47bad79
[build] Uses node-archive to zip/tar packages (#25335)
Started digging into an issue where compressing library didn't include empty
directories, which tar/zip should. After investigating the issue I feel it's
best to use a more established project.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 16:11:08 -08:00
Spencer 43ee991b20
[canvas/gulp-scripts] replace script path in argv with gulp path (#25352) 2018-11-07 15:08:43 -08:00
liza-mae a43b7b2ba1
Wait for global loading indicator when creating index pattern (#25329) 2018-11-07 15:38:29 -07:00
Jen Huang 29d8a9de92
[Rollups] Fix day of month only showing ordinals (#25322)
* Fix day of month only showing ordinals
2018-11-07 13:47:02 -08:00
joe fleming bb5af6c4b2 fix: restore canvas error dialog 2018-11-07 14:38:32 -07:00
Matt Apperson f113682c26
[BeatsCM] text update (#25297)
* progress

* add missing text changes

* text tweak

* Update x-pack/plugins/beats_management/public/components/table/assignment_schema.ts
2018-11-07 16:33:56 -05:00
Tyler Smalley a584720286
[migration] Retry attempts for ES service unavailable (#25255)
Resolves a race condition where ES is technically up, but the Kibana
index is not.

Closes #25027

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 13:17:50 -08:00
Andrew Cholakian 698f989366
Fix execution examples for filebeat / metricbeat (#25170)
On windows these binaries are likely not on the path. By using `.\` as a prefix
these commands will correctly execute.
2018-11-07 15:14:29 -06:00
Lisa Cawley ac8ee26f77
[DOCS] Fixes typo in create role API (#25314) 2018-11-07 13:13:25 -08:00
Tyler Smalley fba9cc40ea
Revert "[build] Uses node-archive to zip/tar packages (#25031)" (#25326)
This reverts commit d89cc0ee15.
2018-11-07 13:12:18 -08:00
Jonathan Budzenski b963ebe1a9
[build] make target folder before building packages (#25312) 2018-11-07 14:16:10 -06:00
Brandon Kobel e22151f678
Only loading the default index pattern when it's required (#25175) 2018-11-07 11:02:03 -08:00
Spencer cfaa1783c3
[canvas] move yarn scripts to node scripts (#25258)
* [canvas] move yarn scripts to node scripts

* [canvas/eslint] allow scripts to access devDeps

* [canvas/eslint] remove packageDir override

* [x-pack] move babel-register to deps for canvas

* [canvas] rename scripts from : to _

* [canvas] update readme with correct script paths

* [canvas] remove yarn.lock file

* Remove redundant require
2018-11-07 10:53:06 -08:00
Tyler Smalley d89cc0ee15
[build] Uses node-archive to zip/tar packages (#25031)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-11-07 10:43:10 -08:00
Joe Fleming ac625701f2
Fix: Canvas babel build (#25184)
Closes https://github.com/elastic/kibana/issues/25154

Canvas' threading code uses babel-register for the runtime, much like Kibana does, so we can execute code that uses newer syntax (mostly es modules at this point...). The default configuration of babel-register ignores `node_modules`, and since x-pack is built into `node_modules`, this worked fine in dev mode and not at all in the build.

There was also an issue where Kibana's build step removes all bablerc files, which meant Canvas' threaded runtime also wasn't getting any of the settings.

This PR pulls in the configuration from Kibana, which has an exception for transpiling x-pack code, and allows the runtime to operate correctly in the build.

Huge thanks to @jbudz for helping me sort out the issue!

@spalger ~~know more about babel than I do, if we can just use `@kbn/babel-preset/node_preset` directly instead, that seems less likely to break going forward. I meant to try it but ran out of time yesterday to make another build.~~ Works! PR updated.
2018-11-07 09:56:30 -07:00
Pete Harverson 60bb092aba
[ML] Fixes file data viz file size check and format as bytes (#25295)
* [ML] Fixes file data viz file size check and format as bytes

* [ML] Fix typo in file size error callout
2018-11-07 16:49:05 +00:00
Spencer 5f9337e35b [canvas] unify eslint config in .eslintrc.js (#25260)
Simply remove the remaining eslint config files from canvas and merge with other canvas related overrides in `.eslintrc.js`
2018-11-07 09:33:39 -07:00
Jen Huang f3cf074ffa
Move call to standard index pattern fields for wildcard from client to server (#25270) 2018-11-07 08:24:59 -08:00
Brandon Kobel 8431348bc0
Updating request to ^2.88 (#25236) 2018-11-07 08:12:26 -08:00
Lisa Cawley 6c7d14a4dc
[DOCS] Adds screenshot for Data Visualizer (#25182) 2018-11-07 08:11:39 -08:00