Commit graph

1508 commits

Author SHA1 Message Date
Caroline Horn
f8c7320277
EUI 6.10.0 & Background color fixes (#30136)
* First foray into turning .application background off

* Hopefully fixing the last few plugins

* Update EUI to 6.9.0

* removing hacks

* last fixes

* Remove a few more `100vh`

* Can I remember to copy & REPLACE

* EUI at 6.10.0
2019-02-05 21:29:30 -05:00
Aaron Caldwell
b84a65d415
[Maps] Set maps tab title using same pattern used elsewhere in Kibana (#29976)
* Set maps tab title using same pattern used elsewhere in Kibana

* Include current map title in document title when open

* Only update doc title on /map/:id route. Update doc title on save action

* Remove fluffy formatting

* Remove string literal formatting
2019-02-05 18:01:40 -07:00
CJ Cenizal
3f61ac67cf
Order Elasticsearch Management apps in order of most used to least used. (#30145) 2019-02-05 16:24:34 -08:00
Tim Sullivan
7bec93f1b9
[Task Manager] Ensure putTemplate will only create/update the index template (#28540)
* get template version

* ensure putTemplate only creates/updates the template

* fix tests

* new test for throwing error re old template

* note comment

* clean up test

* test clarification

* store kibana metadata in scheduled task doc

* map `dynamic: false`

* logging

* add kibana uuid

* fix tests

* last todo

* fetching available task uses apiVersion in the query

* scheduledAt

* ts fix

* ts fix

* fix snapshot

* await to fail test if snapshot does not match

* fix bad merge

* remove _.get

* fix typeError happening in tests
2019-02-05 16:55:16 -07:00
Bill McConaghy
b71144074a
fixing React warning about missing prop (#30147)
* fixing React warning about missing prop

* removing redundant aria-label
2019-02-05 18:14:40 -05:00
CJ Cenizal
2f92df5ee3
Add configPrefix to Index Management, License Management, Rollup Jobs, and Upgrade Assistant. (#30149) 2019-02-05 15:00:18 -08:00
Nick Peihl
92ae5baadd
Use Elastic Maps Service v7.0 (#30006)
* Use Elastic Maps Service v7.0
2019-02-05 14:26:28 -08:00
Jen Huang
30989fbca7
[CCR] Follower index CRUD (#27936)
* [CCR] Refactor redux for Auto-follow pattern detail panel (#27491)

* [CCR] Refactor redux for Auto-follow pattern detail panel

* [CCR] Small refactor

* [CCR] Change to present tense

* [CCR] Display auto-follow pattern name even if it does not exist

* [CCR] Use href to edit auto-follow pattern + remove middelware to update "pattern" query params

* [CCR] Fix navigation back bug + set 2 ids for detail and edit an auto-follow pattern

* [CCR] Replace api middleware with redux-thunk action

* [CCR] Show detail footer close button even when cluster is not valid

* [CCR] Add endpoints for fetching and creating follower indices (#27646)

* Add GET /follower_indices endpoint with deserialization logic and tests.

* Add POST /follower_indices endpoint with serialization logic and tests.

* [CCR]  Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable (#27647)

* Use componentDidUpdate instead of getDerivedStateFromProps.

* Add unit tests for RemoteClusterForm, RemoteClusterList, and RemoteClusterTable.

* Add jest mock for eui `makeId()` utility and get deterministic aria IDs for snapshots

* Update snapshot for Remote Cluster list test

* [CCR] Follower indices table and detail panel (#27804)

* Store for follower indices

* Initial work for follower indices table and detail panel

* Fix load auto-follow stats load as middleware was removed

* [CCR] Create follower index UI form (#27864)

* Initial setup Follower Index form

* Working form without client validation

* Add client side validation for follower index

* Add client validation to check if index already exist

* Improve error message when leader index does not exist

* Remove update method for follower index

* Clear api error on field change

* Fix i18n error

* Update snapshots

* [CCR] Add pause, resume, and unfollow actions for follower indices (#28305)

* Add pause and resume follower index routes

* Add unfollow route

* Add api methods for new routes

* Adjust routes to have bulk capabilities, add corresponding actions

* Refresh list after pausing/resuming, remove items after unfollowing

* First pass at UI for pause and unfollow (and resume, but that is not visible due to ES stats response)

* Handle additional conditions needed for unfollowing leader index, add placeholder code to deduce paused status

* PR feedback

* [CCR] Advanced settings UI for follower indices (#28267)

* Add client side validation of advanced settings form
* Move form entry row to separate component
* Add server side serialization for advanced settings
* Ignore advanced settings input when that section is hidden.
  - Cache and restore input when the section is shown again.

* [CCR] Show remote cluster validation in CCR forms, and add edit follower index (#28778)

* [CCR] Advanced settings component

* Remove preview active on toggle settings

* Add client side validation of advanced settings form

* Move form entry row to separate component

* Add title to panel

* Add i18n translation of advanced settings

* Update Follower index form with toggle for advanced settings

* Add server side serialisation for advanced settings

* Make code review changes

* Fix test: mock constant dependency

* Add section to edit follower index

* Show confirm modal before updating follower index

* Add edit icon in table + update server endpoint to pause / resume

* [CCR] Show remote cluster validation in follower index form & auto-follow pattern form

* PR feedback, cleanup form sizes, add redirect to edit remote cluster

* Fix routing, remove unused code, adjust auto follow pattern edit loading error page

* Adjust error messages and make remote cluster not found edit page the same

* Fix functionality as result of merge

* Fix validation, reorder actions, fix tests, and address feedback

* PR feedback and fix validation pt 2

* Adjust remote cluster validation

* Fix i18n

* Fix api error not showing on add follower form

* [CCR]  Integrate new follower index info ES API (#29153)

* Integrate new follower index info ES API

* Collate data from follower stats and info apis when retrieving all followers and single follower
* Add follower settings info to detail panel
* Add paused/active UI state
* Surface follower default settings to UI

* Adjust tests

* Address PR feedback

* Update snapshots

* [CCR] Surface license errors in-app and refine permissions error UI. (#29228)

* Fix camelcasing bug in XPackInfo.
* Silently swallow API error when checking for index name availability.
* Fix typo in followerIndexForm fatal error.
* Add permissions check before allowing user to access the app.

* Refine wording of CCR permission denied page, to specify cluster privileges. (#29533)

* [CCR] Improve form error handling and general UX (#29419)

* Remove unnecessary eslint disable-line

* [CCR] Implement Advanced Settings design feedback (#29543)

* Use EuiSwitch to toggle advanced settings in Create Follower Index form.
* Move 'optional' from each Advanced Setting field to the section heading.
* Change Advanced Settings switch label and description to emphasize that you can customize them or use the defaults.
* Prepopulate Advanced Settings fields with default values.
* When editing a follower index, check if advanced settings have been edited and open them if so.
* Add 'Reset to default' button below advanced settings fields if their values are different than the default.
* Remove 'Default' copy from Advanced Settings descriptions.
* Simplify toggleAdvancedSettings function, add comments, and fix React console error.

* [CCR] Follower index list fixes from design feedback (#29484)

* Delete remote cluster settings before updating

* Fix detail panel z-index

* Remove default descriptor from follower index detail panel setting values

* Follower index confirm action copy adjustments

* Change z-index styling to use EUI vars

* [CCR] Improve remote clusters test coverage (#29487)

* Add Jest test for RemoteClusterForm validation state.
* Extract validation functions out of RemoteClusterForm and add unit tests.
  - Return null instead of undefined from validators.
* Add unit tests for different types of remote clusters in RemoteClusterTable.
* Add unit test for RemoteClusterList empty prompt.
* Add tests verifying behavior for row link, row delete button, and detail panel delete button.
  - Use getRouterLinkProps to assign onClick and href to edit buttons in row and detail panel.

* [CCR] Adjust spacing around descriptions in list views, link to transport port docs, etc (#29789)

* Adjust spacing around description around descriptions in list views so that it's even on top and bottom.
* Add link to transport port docs from Remote Cluster form.
* Move 'View in Index Management' link from the detail panel body into the footer.

* Re-order follower index form sections: remote cluster, leader index, follower index. (#29885)

* Fix deep-linking to follower index after creating/updating it. (#29865)

* [CCR] Copy edits (#29676)

* Use 'Resume/pause data replication' in context menu and row actions.
* Update copy of 'Update' confirm modal for a paused follower index.
* Update copy of 'Update' confirm modal for an active follower index.
* Update copy of 'Pause data replication' confirm modal.
* Update copy of 'Resume data replication' confirm modal.
* Update copy for permissions check.
* Update copy of table empty state.
* Update copy around tables.
* Update form copy.
* Update copy for RemoteClustersFormField callouts.
* Convert 'data replication' -> 'replication'.
* Update copy for Unfollow confirm modal.
* Update copy for form API error and Auto-follow Patterns table.
* Update form save button labels to be 'Create' and 'Update'.
* Move API errors to bottom of form, into same position as sync validation errors. Remove spacer from SectionError implementation.

* [CCR] Open index after unfollowing leader (#29887)

* Open index after unfollowing leader, fix some variable names

* Fix typo

* Add comment

* [CCR] IE and Screen reader accesibility (#29731)

* Fix api endpoit for auto-follow stats

* Prevent letter wrapping in IE for the Remote cluster "connection" table column

* Move inline style to CSS class to fix IE flex bug

* [CCR] Add callout to paused follower index detail panel (#30013)

* Add callout to paused follower index detail panel

* Update copy

* Skip call to ccr stats api if follower index is paused (#30027)

* [CCR] Add integration tests for follower indices (#30064)

* [CCR] Add integration tests for follower indices

* Import advanced settings value from app constants
2019-02-05 14:01:17 -08:00
Andrew Cholakian
486a5d3654
[Uptime] Improve perf / accuracy of overview queries (#29998)
Improves the accuracy and perf of the up/down/total counts
Sets the correct size of 50 for the monitor list. The widget shows 50 entries.
2019-02-05 15:48:55 -06:00
Justin Kambic
529162a044
[Uptime] Responsive snapshot histogram chart (#29649)
* Resize snapshot histogram chart.

* Update busted tests.
2019-02-05 16:47:00 -05:00
Aleh Zasypkin
b61f87f559
Introduce x-pack/translations plugin. (#30115) 2019-02-05 22:31:28 +01:00
Jen Huang
f44dea576c
Enable orderBy and orderAgg in vis editor for rollup visualizations (#29894) 2019-02-05 13:28:38 -08:00
Thomas Neirynck
e961137f8c
[Maps] fix adding kibana tilemap layers (#30094) 2019-02-05 16:08:50 -05:00
Larry Gregory
eca712589d
Support allow_restricted_indices on PUT role api (#30077)
* Support allow_restricted_indices on PUT role api

* update PUT role API test
2019-02-05 15:57:34 -05:00
Tim Sullivan
ef0fba1bd2
[Reporting] Copy Post URL: track layoutID in state (#30029)
* [Reporting] Post URL: track layoutID in state

* I think this code was not supposed to be here

* ts fix

* revert some diff

* Revert "I think this code was not supposed to be here"

This reverts commit b2e5f60afb.

* static getAbsoluteReportGenerationUrl

* ts fix
2019-02-05 13:48:44 -07:00
Bill McConaghy
e36da1bc5a
improving a11y for activating phases (#30101) 2019-02-05 15:43:43 -05:00
Tim Sullivan
5fea0c72c7
[OSS-Telemetry] Make the plugin have the right config prefix (#30005) 2019-02-05 13:33:48 -07:00
Justin Kambic
dcc96365b7
Re-add missing loading states for filter bar and snapshot components. (#30122) 2019-02-05 15:20:29 -05:00
Walter Rafelsberger
3db812b08e
[ML] User Annotations V2 (#29448)
- Fixes a bug where it's not possible to start dragging to create an annotation over a chart tick element.
- Adds an option to edit annotations via the annotations table.
2019-02-05 21:03:44 +01:00
Felix Stürmer
fd061abd4a
[Infra UI] Adapt settings ui to saved object version type change (#30082) 2019-02-05 20:30:31 +01:00
Chris Cowan
4cb86aa5bd
Fixes #30104 - Add check to make sure popover needs to be closed (#30105) 2019-02-05 12:28:03 -07:00
Sophie Chang
9ebddcc8a4 [ML] Update auditbeat modules for ECS (#29934)
* [ML] Initial commit for auditbeat hosts ECS

Rename fields for ECS
Rework dashboards due to bwc

* [ML] Further auditbeat tidy up and consistency changes

Custom urls should link to saved search, not discover
Ensure savedSearchId is used for visualizations
Ensure filter terms are consistent

TODO Decide if we should rename to auditd module
TODO Fix for new saved object format

* [ML] Refinements for auditbeat host module

Remove duplicated title from visState
Shrink panel heights in row 1

* [ML] Refinements to auditbeat module

Update module name from auditd to auditbeat
Add useMargins true for dashboards
Add filter to custom url for
   exists auditd.data.syscall
   not exists container.runtime
   event.module: auditd

* [ML] Initial commit for auditbeat_process_docker_ecs

Update for ECS using
  container.name (instead of container.id)
  container.runtime: docker
  process.executable
  event.module: auditd
  auditd.data.syscall exists

TODOs
Use auditd.message_type: syscall (instead of auditd.data.syscall)
Possibly combine with auditbeat hosts saved objects (depending on host.name being shared)
Possibly combine to single dashboard
Test against live auditbeat data collection
2019-02-05 19:06:25 +00:00
Spencer
0aecd79c17
Remove k7design setting (#29565)
Removes support for the k6 navigation style from master. All but the first commit are targeted at a specific section of Kibana. Please take a look at the areas you're familiar with and check it off the list. We'll plan to merge this right before feature freeze.

- [ ] home
- [ ] discover
- [ ] context
- [ ] visualize
- [ ] dashboard
- [ ] devtools 
- [ ] timelion
- [ ] graph
- [x] monitoring 
- [ ] gis 
- [ ] infra 
- [x] ml 
- [ ] security 
- [ ] uptime
- [x] beatscm

@elastic/kibana-app @elastic/kibana-security @elastic/ml-ui @elastic/infrastructure-ui @elastic/kibana-gis @elastic/stack-monitoring @elastic/es-ui
2019-02-05 12:57:13 -06:00
Walter Rafelsberger
fd8434a823
[ML] Fixes annotations integrity check. (#30102)
With security enabled, the internal user wouldn't have enough permissions to run the integrity check. This changes the check to use the currently logged in user. Also fixes some typos in messages.
2019-02-05 19:45:14 +01:00
Caroline Horn
06181346fe
Dashboard design updates (#29896)
* Dashboard visual pass (initial)

* Adjusted panel header

..And used a different selector for editing mode to fix bug of `.dshPanel--editing` needing a hard refresh to update.

* better positioning of legend toggle

* Fixed legend toggle position

* Fixed some visualize sidebar font sizes

* better position for resize handle

* Consolidated error and warning messages

* Last edits and removing old testing things

* snaps

* Fix tag cloud

* Comment out markdown-it for now, since it’s not working

* update area chart snapshot

* Styled empty dashboard state

* PR feedback

 - background fix
- dark mode highlight color fix
- euiScrollbars
- euiSpacer

* Fix reporting

* More PR comments

- No edit button in mobile
- No markdown comment for panel error
- i18n id addition
- Remove euiHeader sharing fix

* Revert “hide edit button”
2019-02-05 13:42:37 -05:00
Thomas Neirynck
3ccf6793df
[Maps] use geo-tile aggregation instead of geohash precision (#29776) 2019-02-05 13:01:10 -05:00
Chris Roberson
cdf3266f23
Ensure we are showing the cluster name in the breadcrumbs (#30087) 2019-02-05 12:37:35 -05:00
Matt Apperson
59ff1d0056 [BeatsCM] Use new EUI beta badge (#30061)
* [BeatsCM] Use ner EUI beta badge

* only use beta badge on overview page

* Update primary.tsx

* Update no_data.tsx
2019-02-05 12:33:51 -05:00
Justin Kambic
bf6f419c28
Update title copy and remove paragraph from body for empty index prompt. (#30093) 2019-02-05 12:08:06 -05:00
Chris Davies
ebd3a82643
Remove WebSockets from Canvas expressions interpreter (#29792)
This modifies the interpreter to use REST instead of WebSockets.
2019-02-05 11:51:45 -05:00
Aaron Caldwell
55e7b183d7
[Maps] Enh/gis telemetry (#29346)
* Add basic framework for maps telemetry gathering

* Update mappings to cover required maps usage metrics

* Update telemetry to harvest from saved maps

* Consolidate. Clean up

* Harvest telemetry daily at midnight using task manager. Retrieve task mgr state in usage collector

* Organize, clean up

* Reorg

* Add usage collector tests. Add test utils

* Add maps telemetry tests to verify values. Multiple structure changes to support testing

* Review feedback

* More review feedback

* Add capture date/time to telemetry

* Change date to 'type: date'

* Review feedback

* Fix merge issue
2019-02-05 09:45:05 -07:00
Andrew Cholakian
13a213cc61
[Uptime] Remove pointless max search size box (#29992)
This box is just confusing. You can only see 100 results so we should just hard-code that. Having it is left-over from a previous design.
2019-02-05 09:51:16 -06:00
Nathan Reese
ee71a09693
[Maps] fix issues with keyboard input for setting view coordinates (#30031) 2019-02-05 08:45:23 -07:00
Pete Harverson
d0f3b2a068
[ML] Fix filter params in HTTP Access job custom URLs (#30066) 2019-02-05 15:41:55 +00:00
James Gowdy
f351efa7dc
[ML] Fixing the unmounting jobs list react component on page change (#29980) 2019-02-05 14:51:20 +00:00
Chris Cowan
ddd5dc33e9
Fixes #23821 - Change link to traces (#29972) 2019-02-05 07:38:29 -07:00
Sonja Krause-Harder
bbc2ca5138
Tweak z-index. (#30044) 2019-02-05 15:16:03 +01:00
Sonja Krause-Harder
4a4ed6bb55
Honor maxConcurrentShardRequests setting. (#30049) 2019-02-05 15:12:26 +01:00
James Gowdy
2850fd6735
[ML] Job deleting optimisations (#29848)
* [ML] Job deleting optimisations

* fixing force=true

* updating deleting jobs check
2019-02-05 12:29:01 +00:00
James Gowdy
fda6efed1a
[ML] Adding index migration warnings (#28938)
* [ML] Adding index migration warnings

* small refactor

* correctlng comment

* adding upgrade service to manage upgradeInProgress state

* removing missing function
2019-02-05 12:27:32 +00:00
Felix Stürmer
07add3b9b6
[Infra UI] Remove infrastructure breadcrumb from logs page (#29954)
This removes the Infrastructure breadcrumb prefix from the Logs page.

fixes #29472
2019-02-05 12:03:24 +01:00
Casper Hübertz
2e37de7bc0
[APM] Fixes EUI font update typography issues (#29831)
* Decreasing headings size for charts
* Updated Watcher flyout
2019-02-05 11:01:06 +01:00
Walter Rafelsberger
f2e3aff333
[ML] Adds an integrity check to creating, updating and deleting annotations. (#29969)
Adds an integrity check to make sure the required index and aliases are present before creating, updating or deleting annotations.
2019-02-05 10:14:45 +01:00
Sonja Krause-Harder
70d9f45757
[Infra UI] Let drag-selecting a timerange disable autorefresh (#29947)
* Let drag-selecting a timerange disable autorefresh

* Send action to stop livestreaming at better time.
2019-02-05 08:03:50 +01:00
Josh Dover
d166001a88
[upgrade] Add cancel button to reindexing (#29913) 2019-02-05 00:19:13 -06:00
Josh Dover
20ffce229b
Filter out security realm deprecations on Cloud (#30018) 2019-02-05 00:17:47 -06:00
Spencer
b4725b7d34
Remove dependency on doc versions (#29906)
See https://github.com/elastic/elasticsearch/pull/38254

Using the `version` parameter to implement optimistic concurrency is not going to be supported in 7.0, so we need to replace our usage of document version with the new `_seq_no` and `_primary_term` parameters. These fields are returned in the same way that `_version` was returned on all read/write requests except for search, where it needs to be requested by sending `seq_no_primary_term: true` in the body of the search request. These parameters are sent back to Elasticsearch on write requests with the `if_seq_no` and `if_primary_term` parameters, and are functionally equivalent to sending a `version` in a write request before elastic/elasticsearch#38254.

To make these updates I searched the code base for uses of a `version` and `_version`, then triaged each usage, so I'm fairly confident that I got everything but it's possible something slipped through the cracks, so if you know of any usage of the document version field please help me out by double checking that I converted it.

- [x] **Saved Objects**:  @elastic/kibana-platform, @elastic/es-security - for BWC and ergonomics the `version` provided by the Saved Objects client/API was not removed, it was converted from a number to a string whose value is `base64(json([_seq_no, _primary_term]))`. This allows the Saved Objects API and its consumers to remain mostly unmodified, as long as the underlying value in the version field is irrelevant. This was the case for all usages in Kibana, only thing that needed updating was tests and TS types.

- [x] **Reporting/esqueue**: @joelgriffith, @tsullivan - the version parameter was used here specifically for implementing optimistic concurrency, and since its usage was contained within the esqueue module I just updated it to use the new `_seq_no` and `_primary_term` fields.

- [x] **Task Manager**: @tsullivan @njd5475 - Like esqueue this module uses version for optimistic concurrency but the usage is contained with the module so I just updated it to use, store, and request the `_seq_no` and `_primary_term` fields.

- [ ] **ML**: @elastic/ml-ui - Best I could tell the only "version" in the ML code refers to the stack version, 077245fed8

- [ ] **Beats CM**: @elastic/beats - Looks like the references to `_version` in the code is only in the types but not in the code itself. I updated the types to use `_seq_no` and `_primary_term`, and their camelCase equivalents where appropriate. I did find a method that used one of the types referencing version but when investigating its usage it seemed the only consumer of that method was itself so i removed it. 52d890fed7

- [x] **Spaces (tests)**: @elastic/kibana-security - The spaces test helpers use saved objects with versions in a number of places, so I updated them to use the new string versions where the version was predictable, and removed the assertion on version where it wasn't. We test the version in the saved objects code so this should be fine.
2019-02-04 21:13:34 -08:00
Nathan Reese
de2d0b647c
[Maps] ensure resiveChecker exists before calling destroy (#30032) 2019-02-04 22:02:53 -07:00
Shaunak Kashyap
7b68b89ef1
Removing deprecated xpack.monitoring.report_stats setting (#30017)
* Removing deprecated xpack.monitoring.report_stats setting

* Remove from docs

* Update check in xpack_main plugin to not look at monitoring settings any more
2019-02-04 19:37:32 -08:00
Nathan Reese
908b387236
[Maps] add saved objects for all sample data sets (#28797)
* [Maps] add saved objects for all sample data sets

* add functional tests that compare sample data maps to baseline images

* add check for layer loading in functional tests

* try something out in CI

* try map without EMS regions

* add weblogs test but hide region layer

* skip tests with EMS vector layers

* gis-map to map and ES_GEOHASH_GRID to ES_GEO_GRID

* add resolution property to ES_GEO_GRID source descriptor

* move alphaValue from style descriptor to layer descriptor and rename to alpha

* terms join label change 'group by' to 'of'

* ensure sample data sets work with no internet access

* get functional tests working with updated full screen snapshots

* delete gis folder left overs

* give time for visibility to toggle to fire

* make web logs screen comparision more forgiving

* wait for layers to load on full screen
2019-02-04 20:18:11 -07:00