Commit graph

13873 commits

Author SHA1 Message Date
Søren Louv-Jansen f1380e3ac5
[Kuery] Remove Angular dependencies (#17836)
* [kuery] Remove `byName` dependency

* Remove $http from kuery

* Fix test

* Add request headers

* Replace byName with getFieldByName; add isFilterable

* Replace Angular mock with static mock

* Update index pattern for query bar

* manually attach format.convert method to field

* Use KBN_FIELD_TYPES to determine isFilterable

* Bump yarn.lock file

* Add kfetch (Kibana fetch)

* Moved `getFromLegacyIndexPattern` to static index pattern functions

* Fix tests

* Mock out kfetch

* Move value formatting from getRangeScript to buildRangeFilter

* Remove getFieldByName (over abstraction)

* Split kfetch options into two
2018-05-15 00:10:40 +02:00
Søren Louv-Jansen acc3af0c59
Align x-pack and kibana devDeps (#19022)
* Align Node deps

* Added grunt task

* Update name
2018-05-14 19:33:04 +02:00
Chris Roberson 6528ef0d33
The text property is optional (#19034) 2018-05-14 10:29:29 -04:00
Tim Roes f579d2299f
Update React to 16.3 (#18768)
* Update React to 16.3

* Switch off specific eslint rules

* Update enzyme snapshots

* Incorporate PR feedback
2018-05-14 14:05:17 +02:00
Spencer 0f8a00304b
[x-pack] remove use of resolveKibanaPath from plugin helpers (#18979) 2018-05-11 07:46:44 -07:00
Pete Harverson daf01340ba
[ML] Sort Explorer view by swimlane for selected time (#18955)
* [ML] Sort Explorer view by swimlane for selected time

* [ML] Rename swimlane sort array with clearer name
2018-05-11 09:37:26 +01:00
archana d641bfa358
Clarify x-pack functional tests part of README.md (#18984)
* Clarify x-pack functional tests part of README.md

* Update README.md

No reason to use "project" here. Also capitalizing sentences is good.
2018-05-10 16:01:04 -05:00
Jen Huang 45002180a7
Fix ace editor warnings (#18893)
* Fix ace editor warnings
2018-05-10 10:43:49 -07:00
gchaps 7ee5147b26
[COPYEDIT] Fixed capitalization for Basic and Premium licenses (#18969)
* [COPYEDIT] Fixed capitalization for Basic and Premium licenses

* [COPYEDIT] More fixes for upper case in license text, including one code change
2018-05-10 09:31:46 -07:00
Tim Sullivan 782d4d9804
[Monitoring/React] Render ES Indices Listing with Base Controller / React (#18595)
* [Monitoring/React] Render ES Indices Listing with Base Controller

Refactors the ES Indices Listing to use Base Controller and a React component instead of an Angular directive

* fix functional tests

* fix another test

* better default for summary status component

* nicer code for whitespace after label

* apiFn => apiUrlFn

* Deleted / Closed
2018-05-09 21:37:24 -07:00
Tim Sullivan 011e8b2c28
[Monitoring] reorganize metrics per stack product (#18590)
* [Monitoring/Metrics] clean up metric classes and getMetricFields static helpers

* more pull out

* more to break out

* [Monitoring] reorganize metrics per stack product

This organizes the metrics classes per product as a starting point for adding more functions to the metrics so external logic in the `get_metrics` and `get_series` modules can be simplified.

New structure:
```
plugins/monitoring/server/lib/metrics
├── __test__
│   ├── __snapshots__
│   │   └── metrics.test.js.snap
│   └── metrics.test.js
├── beats
│   ├── __test__
│   │   └── cpu_utilization_calculation.test.js
│   ├── classes.js
│   └── metrics.js
├── classes
│   ├── __test__
│   │   ├── latency_metric_calculation.test.js
│   │   └── quota_metric_calculation.test.js
│   ├── cluster_metric.js
│   ├── index.js
│   ├── metric.js
│   └── quota_metric.js
├── elasticsearch
│   ├── __test__
│   │   └── latency_calculation.test.js
│   ├── classes.js
│   └── metrics.js
├── index.js
├── kibana
│   ├── classes.js
│   └── metrics.js
├── logstash
│   ├── classes.js
│   └── metrics.js
└── metrics.js
```

* fix strange test failure

* reduce loc change
2018-05-09 18:23:27 -07:00
archana b58e757794
Functional test setup with kbn-test package (#18568)
Restructure testing with kbn-test package

 - Run with multiple configs, move cli options to config
 - Package-ify kbn-test
 - Eventually we'll have functional_test_runner live in a package
of its own, and then this kbn-test will use that as a dependency,
probably still as a devDependency.
 - Implement functional_tests_server
 - Collapse single and multiple config apis into one command

Use kbn-es

Replace es_test_cluster + es_test_config with kbn/test utils

Implement new createEsTestCluster

Improve scripts, jsdocs, cli top-level tools

Lift error handling to the top level
2018-05-09 18:23:49 -05:00
Chris Earle da1ed1a105
Make "Yes" button unfilled (#18960)
This changes the button from looking like it has been pre-clicked, which
is not the case.
2018-05-09 14:53:39 -04:00
Pete Harverson 875a0eb3bc
[ML] Filter top influencer list based on swimlane selection (#18946)
* [ML] Filter top influencer list based on swimlane selection

* [ML] Edits to Influencer List after review and remove animation
2018-05-09 16:56:35 +01:00
Walter Rafelsberger 79c4d4ef09
[ML] Enable cell range selection. (#18920)
This re-enables the feature flag to support selecting a range of cells in the anomaly explorer. Follow-ups to this PR will tackle limiting the allowed cells to select to avoid problems with too wide selections.
2018-05-09 14:39:22 +02:00
James Gowdy 0d3df613de
[ML] Fixing transfer of dedicated index setting (#18945) 2018-05-09 13:22:44 +01:00
Tim Sullivan 698dfa455c
[Monitoring/Beats] Telemetry Data from Beats (#18833)
* [Monitoring/Beats] Telemetry Data from Beats

* filter apm-server

* ignore results payload if hitsLength === 0

* process each payload as stats are saved to clusters object
2018-05-08 09:19:15 -07:00
Walter Rafelsberger 74868ebb2f
[ML] Fixes time series viewer data binding for forecast data. (#18903)
Fixes the data binding of focusForecastData to renderFocusChart(). An update to focusForecastData in MlTimeSeriesExplorerController wasn't correctly picked up by the directive mlTimeseriesChart because the relevant data wasn't being watched.
2018-05-08 14:58:17 +02:00
James Gowdy b1ca716b80
[ML] Correctly transfer dedicated index setting to advanced job page (#18899)
* [ML] Correcly transfer dedicated index setting to advanced job page

* removing accidentally added code
2018-05-08 13:50:00 +01:00
Pete Harverson 59fb742f80
[ML] Hide Top Influencers list if job has no influencers (#18819)
* [ML] Hide Top Influencers list if job has no influencers

* [ML] Add check for undefined job when hiding influencers list
2018-05-08 13:27:57 +01:00
Walter Rafelsberger 9894355490
[ML] Move the hide() function outside the show() function's scope. (#18900)
The mlChartTooltipService's hide() method was inside the show() method scope. If hide() was called before show() was called for the first time this would result in an error. This could have happened in angular directive's which called hide() on some cleanup action without a previous call to show(). This fix moves the hide() method outside the show() method's scope and adds a unit test to check for the correct structure of mlChartTooltipService.
2018-05-08 13:53:22 +02:00
Spencer 8e3c1c7517
Fix procRunner/x-pack ftr scripts (#18789)
* [x-pack/ftr] call fatalErrorHandler when functional tests fail

* [kbn/dev-tools/withProcRunner] require a log as the first arg

* [kbn/dev-tools/procRunner] use correct promise, convert to getter

* [x-pack/ftr] avoid race condition that prevents success message logging

When starting the kibana server it is possible for log messages to come
after the server is started, so we added a pause that waits for 5
seconds of logging silence before logging the success message. The
observable used fails to complete though if a log message is never
written AFTER the Kibana server starts. To counter this the observable
is started with `null` so it will always start at least one 5 second
timer and always complete even if there is no log data after Kibana
server starts.

* fix typo
2018-05-07 14:50:15 -07:00
Jen Huang 1259007745
Advanced Settings to React/EUI (#17465) 2018-05-07 12:48:27 -07:00
Justin Kambic 637d90dde0
[Logstash Pipeline Management] Fix bottom border of Pipeline Editor (#18834)
* Change pipeline editor markup so bottom border doesn't hide text on last line.

* Add constants for scroll margin size.

* Add comments to editor constants.

* Add PX units to constant names.
2018-05-07 14:08:05 -04:00
Nathan Reese ce3b69fbe9
remove application icon assets in kibana that ship with EUI (#18570)
* remove assets in kibana that ship with EUI

* update home page tests

* replace logstash pipeline svg with EUI icon type
2018-05-07 10:59:39 -06:00
Søren Louv-Jansen 8627dbad14
[APM] Fix docs link and mock ui/metadata (#18857) 2018-05-07 16:22:54 +02:00
Nathan Reese 6d51db6656
upgrade to eui 0.0.46 (#18827)
* upgrade to eui 0.0.46

* update logoElasticsearch

* update x-pack jest snapshots
2018-05-05 09:08:15 -06:00
Søren Louv-Jansen 14876364c7
Replace api calls with ReduxRequest (#18815) 2018-05-04 20:29:00 +02:00
Justin Kambic 3028a6fd80
Fix suboptimal file org/export structure. (#18820) 2018-05-04 14:27:05 -04:00
Justin Kambic 38fd6066f6
[Grok Debugger] Better editor expansion/Fix border hiding bottom line (#18752)
* Update to grok debugger editors: let them grow taller and stop hiding half of bottom line input.

* Update custom pattern size to 10 LOC.

* Remove unnecessary options, add constants for scroll margin.

* Encapsulate editor options in mutate function.

* Move editor helper file and prefer "function" declaration over ES6 const.

* Add test for new helper function.
2018-05-04 12:20:36 -04:00
Shaunak Kashyap 5722c84b2d
Removing line that's causing an error (#18807) 2018-05-04 06:26:51 -07:00
James Gowdy ed7f6983f9
[ML] Data recognizer UI improvements (#18804)
* [ML] Data recognizer UI improvements

* rolling back accidental change
2018-05-04 14:02:43 +01:00
James Gowdy 511a6b0904
[ML] Fixing data recogniser save success issue (#18803) 2018-05-04 11:18:49 +01:00
Pete Harverson 5de7909350
[ML] Convert Explorer Influencers List to EUI/React (#18773)
* [ML] Convert Explorer Influencers List to EUI/React

* [ML] Remove unused abbreviate_whole_number Angular filter

* [ML] Convert React Influencers List to stateless function
2018-05-04 09:22:59 +01:00
Spencer e1a2fcbd96
[uiExports] migrate uiApp "uses" to explicit imports in apps (#17828)
* [uiExports] migrate uiApp "uses" to explicit imports in apps

* [uiApp] update tests for getModules() method

* [optimize/uiExports] improve naming and comments

* [uiExports] sort imports so they load in the same order as before

* [testHarness] load hacks when testing in the browser

* [x-pack/uiExports] use new uiExports modules

* [testHarness] describe why we import uiExports/hacks

* [optimize] remove needless [].concat()

* [optimize/createUiExportsModule] string.includes > string.indexOf

* [uiExports/createUiExportsModule] remove needless capture of module exports
2018-05-03 12:18:50 -07:00
James Gowdy 708810ab30
[ML] Fixing error reporting in message bar (#18781) 2018-05-03 18:33:22 +01:00
Tim Sullivan 3332143d14
[Monitoring/Test] More indices listing tests to prep for refactoring (#18758) 2018-05-03 09:16:31 -07:00
Walter Rafelsberger 9d73c656e8
[ML] Fix Anomaly Table update trigger (#18769)
Fixes an issue with the anomaly table not correctly updating in the anomaly explorer and the anomaly markers not showing up in the time series viewer.
- moves the initialization of scope.anomalyRecords = []; to the controllers of anomaly explorer and time series viewer. having it in the anomaly table directive caused a race condition to overwrite already fetched records.
- use $watchCollection instead of $watch to track anomalyRecords and focusChartData changes.
replaces $timeouts with scope.$evalAsync
- fixes how focusChartData gets updated correctly to fix missing anomaly markers in the time series viewer.
2018-05-03 16:02:32 +02:00
James Gowdy d52729b862
[ML] Converting services to be non-angular imports (#18687)
* [ML] Removing angular from services

* removing commented out code

* fix include path for tests

* adding flag to initPromise

* moving job service for jest tests to pass

* moving initPromise to its own file
2018-05-03 13:11:19 +01:00
James Gowdy a4cfc25e46
[ML] Fixing icon 404 responses in firefox (#18766) 2018-05-03 13:07:19 +01:00
Walter Rafelsberger 0ac0e3dd5d
[ML] Refactor to not rely on broadcast which could result in listeners not picking up changes. (#18717)
Fixes an issue where the anomaly table wouldn't load because a broadcast to renderTable was triggered before the anomaly table directive initialized the corresponding listener. This change replaces the use of broadcast and instead uses $watch to listen on scope changes on the specific attributes relevant to the updates. The updating of code in parent scopes was moved inside the $timeouts instead of the broadcast event.
2018-05-03 10:04:47 +02:00
Tim Sullivan 482953c9b8
[Monitoring/Metrics] clean up metric classes and getMetricFields stat… (#18741)
* [Monitoring/Metrics] clean up metric classes and getMetricFields static helpers

* more pull out

* more to break out

* snapshot update
2018-05-02 17:29:25 -07:00
Spencer d35316642d
Fix loading indicator for uiSettingsClient (#18694)
* [ui/chrome/loadingIndicator] expose VanillaJS hooks for gloabl loading indicator

* [ui/uiSettingsClient] increment/decrement loading count while request in progress

* [ui/loadingIndicator] fix HeaderPage.isGlobalLoadingIndicatorHidden()

* [ui/loadingIndicator] remove rxjs, fix tests

* [ui/loadingIndicator] improve docs

* [ui/loadingIndicator] remove needless unmounts

* [ui/loadingCount] correct typo

* [functionalTests/headerPage] awaitGlobalLoadingIndicatorHidden

* [ui/loadingCount] send subscribers the loading count on subscription

* [ui/loadingIndicator] remove error throwing, cleanup render
2018-05-02 16:37:23 -07:00
Kelly Murphy 6e5a7b941e
Links for Cloud docs (#18754) 2018-05-02 17:57:20 -05:00
spalger 7e41dc5248 [x-pack/readme] remove left-over merge conflict 2018-05-02 13:55:02 -07:00
Lisa Cawley 79efbb61f7
[DOCS] Fixes broken link to built-in users (#18747) 2018-05-02 13:21:33 -07:00
Nathan Reese 9681fd4cf4
add jest instructions to CONTRIBUTING.md (#18620)
* add jest instructions to CONTRIBUTING.md

* remove package language and move x-pack jest instructions to x-pack/README.md
2018-05-02 13:57:10 -06:00
Lisa Cawley e0de10cac2
[DOCS] Enables editing links for X-Pack pages (#18675) 2018-05-02 10:54:26 -07:00
Tim Sullivan 819b35a53e
[Monitoring/Test] More API Integration tests (#18700) 2018-05-02 10:24:03 -07:00
James Gowdy dc21cf29b9
[ML] Increasing calculated model memory limit (#18723)
* [ML] Increasing calculated model memory limit

* updating comment

* updating tests
2018-05-02 18:12:45 +01:00
Bill McConaghy 411b2455d6
fixing issue with cancel button on revert to basic license modal (#18718) 2018-05-02 12:53:08 -04:00
James Gowdy d77cc5676b
[ML] Fixing MS Edge GET request error (#18713) 2018-05-02 14:25:17 +01:00
Pete Harverson 34cc14f445
[ML] Display typical values for lat_long anomalies (#18715) 2018-05-02 13:21:49 +01:00
James Gowdy af1a9b6a13
[ML] Adding ace editor for JSON (#18692)
* [ML] Adding ace editor for JSON

* removing unnecessary require-keys setting
2018-05-02 11:48:48 +01:00
Walter Rafelsberger 7f48d6e5b6
[ML] Adds an mml check to trigger an error when mml value is invalid. (#18678)
This adds an additional check and corresponding error message to the validation of the model memory limit. If the parsing of the memory model limit results in 0 bytes the message will be triggered. This behaviour catches both correctly formatted but invalid strings (like 0mb) and invalid strings (like asdf).
2018-05-02 12:42:13 +02:00
Pete Harverson a565761b94
[ML] Convert Angular filters to formatter functions (#18681)
* [ML] Convert Angular filters to formatter functions

* [ML] Clean up Angular filter wrappers
2018-05-02 09:47:27 +01:00
Walter Rafelsberger 92f05ee9b3
[ML] Omit mml success message when mml checks are not run. (#18659)
Updates the behaviour of the job validation's model memory limit checks: The success messages success_mml gets only returned if the checks were actually run. This omits the success message for example in the single metric and population wizard.
2018-05-02 10:35:12 +02:00
Walter Rafelsberger d6e2464ff0
[ML] Fixes sync issue where a manipulated AppState wouldn't contain the original attribute anymore. (#18653)
Inconcistencies between AppState and derived custom states for UI components like mlSelectLimit and mlSelectInterval could trigger errors because the parent of a nested object attribute could become undefined. This PR adds additional checks to state_factory.js's get/set/reset methods to reinitialize itself with AppState and fall back to its default state should it not be present within AppState anymore. The original issues were hard to reproduce consistently using the UI only. However the error could be triggered when creating a malformed URL, like replacing the mlSelectInterval:(interval:(display:Auto,val:auto)) part of the URL to something like mlSelectInterval:(undefined). This PR includes additional unit tests which simulate this behaviour and fail without the additional checks provided by this PR.
2018-05-02 08:18:31 +02:00
Lisa Cawley 85759b7797
[DOCS] Removes X-Pack release notes (#18702) 2018-05-01 16:59:27 -07:00
Jonathan Budzenski 1eef04551d
[console_extensions] disable when console is disabled (#18673)
* [console_extensions] disable when console is disabled

* [console extensions] has console and enabled

* [console_extensions] fix console_extensions.enabled
2018-05-01 10:54:43 -05:00
Shaunak Kashyap 5de204212e
[Logstash Centralized Management] Hide recently-deleted pipelines (follow up PR) (#18683)
* Renaming constant to be more descriptive

* Less kludgy language for better readabilility

* Removing extraneous newlines
2018-05-01 07:16:39 -07:00
Shaunak Kashyap bf97342356
[Grok Debugger] Adding syntax highlighting for grok expressions (#18572)
* Adding basic syntax highlighting for grok expressions

* Use EUI color palette

* Handle regex tokens, escaped and unescaped

* Return token for escaped content

* Add functional test

* Using higher-contrast colors

* Removing comment I used for developing the highlight rules

* Using object destructuring

* Removing unnecessary method
2018-04-30 12:31:23 -07:00
Shaunak Kashyap 5cf042bfde
[Logstash Centralized Management] Hide recently-deleted pipelines (#18644)
* Extracting constant for reuse

* Keep track of recently-deleted pipelines until Monitoring stops reporting them

* Adding explanatory comment for constant
2018-04-30 12:04:39 -07:00
Bill McConaghy 117e4337c5
passing acknowledge=true with start_trial (#18655) 2018-04-30 12:59:00 -04:00
Tim Sullivan 9e4d4952b6
[Monitoring] add get_clusters_summary to shrink cluster api response (#18596)
This reduces the output from the clusters API in the data processing stage.

Mainly, it throws away a lot of unused fields in `elasticsearch.cluster_stats` and `elasticsearch.cluster_state`

cc @rasroh
2018-04-30 09:11:01 -07:00
gchaps e11c7dac17
[UI Text: Security] Edited text in User, Add user, and Edit user pages (#18618) 2018-04-30 08:58:27 -07:00
Nathan Reese 5a4263ad2d
update to eui 0.0.44 (#18606)
* update to eui 0.0.44

* keep eui dependency in x-pack

* wrap EuiBasic table column in span to avoid className prop from getting overridden

* remove brittle functional tests that are no longer needed with EUI components

* filter field list instead of chaning table size

* update x-pack snapshots
2018-04-27 11:07:15 -06:00
Søren Louv-Jansen fdc24f5b3f
[APM] Minor watcher improvements (#18602)
* [APM] Improve watcher tests

* Update tests
2018-04-26 17:44:31 +02:00
Tim Sullivan 4630548d2c
[Monitoring/React] Render ES Nodes Listing with Base Controller (#18585)
* [Monitoring/React] Render ES Nodes Listing with Base Controller

Refactors the ES Nodes Listing to use Base Controller and a React component instead of an Angular directive

* remove another obsolete file
2018-04-25 17:38:30 -07:00
Tim Sullivan 86d3786d34
[Monitoring/License] copy license LESS instead of reference it (#18591) 2018-04-25 17:29:56 -07:00
Tyler Smalley 5d8cf56532
[kbn-es] Use basic license as default (#18577)
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
2018-04-25 14:00:24 -07:00
Chris Earle 015e94b5fe
[Monitoring] Recognize Write Threadpool (#18147)
This changes the Advanced Node page for Elasticsearch to recognize the
"write" threadpool, while also incorporating the deprecated "index"
threadpool and renamed "bulk" usage (renamed to "write").

This sums the three writing threadpools together and displays it as a
unified view.
2018-04-24 19:26:50 -04:00
Jenkins CI fe4609647d Migrate x-pack-kibana source to kibana 2018-04-24 13:48:10 -07:00