maxmustermann/kibana
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
35685 commits 329 branches 211 tags 6.1 GiB
Commit graph

917 commits

Author SHA1 Message Date
James Gowdy
fb2cac9a8a
[ML] Fixing file import button on basic license (#75458) 2020-08-19 19:13:12 +01:00
Quynh Nguyen
3469e164f4
[ML] Add option for per-partition categorization to categorization job wizard (#75061) 2020-08-19 13:03:00 -05:00
Walter Rafelsberger
e61a4b63a6
[ML] DF Analytics / Transforms: Fix job row actions menu invalid DOM nesting warning (#74499) 
Refactors the action buttons for transforms and analytics job list to no longer produce nested button elements and throw a React error.
 2020-08-19 16:25:00 +02:00
Dima Arnautov
8f7d213944
[ML] Inference models management (#74978) 
* [ML] init tabs

* [ML] init inference API service in UI

* [ML] server-side routes

* [ML] basic table

* [ML] support deletion

* [ML] delete multiple models

* [ML] WIP expanded row

* [ML] fix types

* [ML] expanded row

* [ML] fix types

* [ML] fix i18n id

* [ML] change server-side permission check

* [ML] refactor types

* [ML] show success toast on model deletion, fix models counter

* [ML] update expanded row

* [ML] pipelines stats

* [ML] use refresh observable

* [ML] endpoint to fetch associated pipelines

* [ML] update the endpoint to fetch associated pipelines

* [ML] show pipelines definition in expanded row

* [ML] change stats layout

* [ML] fix headers

* [ML] change breadcrumb title

* [ML] fetch models config with pipelines

* [ML] change default size to 1000

* [ML] fix collections keys, fix double fetch on initial page load

* [ML] adjust models deletion text

* [ML] fix DFA jobs on the management page

* [ML] small tabs in expanded row

* [ML] fix headers text

* [ML] fix models fetching without pipelines get permissions

* [ML] stats rendering as a description list

* [ML] fix i18n id

* [ML] remove an extra copyright comment, add selectable messages

* [ML] update stats on refresh
 2020-08-19 16:22:26 +02:00
Walter Rafelsberger
2559d90551
[ML] Anomaly Explorer / Single Metric Viewer: Fix error reporting for annotations. (#74953) 
Fixes error reporting when annotations fail to load for Anomaly Explorer and Single Metric Viewer.
Previously, Anomaly Explorer ended up with a completely empty page when annotations failed to load. Single Metric Viewer would not fail to load, but it would make no difference for the user if existing annotations failed to load of if there were simply no existing annotations. Only in dev console an error message would be visible.
Now a callout is shown when annotations fail to load.
 2020-08-19 12:07:15 +02:00
Melissa Alvarez
2a212cbad8
Clarify no documents error message when filtering by is_training (#75227) 2020-08-18 08:58:15 -04:00
Melissa Alvarez
8559ed87d1
[ML] DF Analytics creation: display explain error message (#75006) 
* display explain error message to the user

* fix translation

* update error message
 2020-08-14 12:44:42 -04:00
Greg Thompson
bbee1f92b0
Upgrade EUI to v27.4.0 (#74004) 
* eui to 27.1.0

* eui to 27.2.0

* buttoniconside type

* euiselectable type

* update onScroll callback and polyfill size references

* findTestSubject ts

* buttoncontent and collapsiblenav src snapshot updates

* update prop retrieval

* xpack snapshots

* jest updates

* type fixes

* more snapshots

* virtual list changes

* more virtualization changes

* merge

* fix functional tests

* data-test-subj for indexPatter-switcher

* storyshots

* eui to 27.3.1

* Fix unit tests

* Fix broken unit test

* Updated snapshots

* Fixed types

* search for value in euiselectable before selection

* select the correct element

* mock virtualized dep

* ts fix

* reinstate storyshot

* ts fix

Co-authored-by: Chandler Prall <chandler.prall@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-08-14 10:31:15 -06:00
Melissa Alvarez
479a991b98
[ML] DF Analytics: allow failed job to be stopped by force via the UI (#74710) 
* allow force stop from ui if job is failed

* update wording in confirm modal
 2020-08-13 14:17:33 -04:00
Walter Rafelsberger
b249af128e
Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (#74642) 
Refactor to use jest.useFakeTimers().
 2020-08-13 09:38:15 +02:00
Ryland Herrick
4ca52e678a
[Security Solution][Detections] Refactor ML calls for newest ML permissions (#74582) 
## Summary

Addresses https://github.com/elastic/kibana/issues/73567.

ML Users (role: `machine_learning_user`) were previously able to invoke the ML Recognizer API, which we use to get not-yet-installed ML Jobs relevant to our index patterns. As of https://github.com/elastic/kibana/pull/64662 this is not true, and so we receive errors from components using the underlying hook, `useSiemJobs`.

To solve this I've created two separate hooks to replace `useSiemJobs`:

* `useSecurityJobs`
  * used on ML Popover
  * includes uninstalled ML Jobs
  * checks (and returns) `isMlAdmin` before fetching data
* `useInstalledSecurityJobs`
  * used on ML Jobs Dropdown and Anomalies Table
  * includes only installed ML Jobs
  * checks (and returns) `isMlUser` before fetching data

Note that we while we now receive the knowledge to do so, we do not always inform the user in the case of invalid permissions, and instead have the following behaviors:

#### User has insufficient license
* ML Popover:  shows an upgrade CTA
* Anomalies Tables: show no data
* Rule Creation: ML Rule option is disabled, shows upgrade CTA
* Rule Details: ML Job Id is displayed as text
#### User is ML User
* ML Popover:  not shown
* Anomalies Tables: show no data
* Rule Creation: ML Rule option is disabled
* Rule Details: ML Job Id is displayed as text
#### User is ML Admin
* ML Popover:  shown
* Anomalies Tables: show data __for installed ML Jobs__
  * This is the same as previous logic, but worth calling out that you can't view historical anomalies
* Rule Creation: ML Rule option is enabled, all ML Jobs available
* Rule Details: ML Job Id is displayed as hyperlink, job status badge shown

### Checklist

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
 2020-08-12 18:26:06 -06:00
Caroline Horn
5b64a4cdfe
Empty index patterns page re-design (#68819) 
Empty index patterns page re-design
 2020-08-12 15:58:16 -05:00
Robert Oskamp
178afd71fc
[ML] Functional tests - stabilize DFA dependent variable input (#74829) 
This PR stabilizes the dependent variable input during tests by explicitly waiting for the options to load.
 2020-08-12 13:42:43 +02:00
James Gowdy
a81059b14b
[ML] Removing full lodash library imports (#74742) 
* [ML] Removing full lodash library imports

* more has

* fixing missing filter

* removing _

* removing unused file

* removing first use

* removing comment
 2020-08-12 09:24:43 +01:00
James Gowdy
8d9bafeb57
[ML] Fixing schema for custom rule conditions (#74676) 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-08-11 09:01:19 +01:00
James Gowdy
01d8f00b50
[ML] Refactor in preparation for new es client (#74552) 
* [ML] Refactor in preparation for new es client

* removing commented out code

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-08-11 08:53:16 +01:00
James Gowdy
6bea373e8f
[ML] Adding initial file analysis overrides (#74376) 
* [ML] Adding initial file analysis overrides

* using common default sample lines

* correcting bottom padding

* adding missed padding

* code clean up

* fixing translations

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-08-11 08:47:26 +01:00
Melissa Alvarez
4ee483be23
[ML] ML on Kibana Management: Add ability to pass a group ID filter to job management page (#74533) 
* handle group id in url for anomaly detection

* filter analytics list by group id.

* handle list of groupIds

* ensure analytics can handle jobid in url. rename util function

* add tests for getSelectedIdFromUrl and getGroupQueryText

* keep groupIds as array of strings and jobId as single string

* fix tests and update types
 2020-08-10 17:18:36 -04:00
Melissa Alvarez
a6615c6141
add memoryStatus to df analytics page and analytics table in management (#74570) 2020-08-10 11:50:18 -04:00
Walter Rafelsberger
11c74bc03f
[ML] Fix analytics list on management page. (#74254) 
The analytics job page in the Kibana management section didn't have the context provided by React Router and Kibana's own history object so the page crashed on load. The context is necessary to construct the correct URLs to navigate to the ML plugin itself.
This PR fixes it by wrapping the management page in <Router history={history} />. Also adds functional tests to cover navigating to the jobs list pages in stack management.
 2020-08-06 15:35:53 +02:00
Melissa Alvarez
af358c94a3
[ML] DF Analytics: adds functional tests for edit form (#73885) 
* add edit analytics functional test

* adds edit test service

* update edit test wording for clarity

* check flyout closes after edit

* rename testSubj for consitency
 2020-08-05 17:58:40 -04:00
Melissa Alvarez
4150a234c8
update empty prompt in analytics list (#74174) 2020-08-05 12:43:58 -04:00
Mikhail Shustov
88c0631344
Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) 
* bump @typescript-eslint deps

* update rules

* fix errors in pacakges

* fix src/

* fix x-pack

* fix test

* fix typings

* fix examples

* allow _ as prefix and suffix

* roll back prefix and suffix changes

* add eslint-plugin-eslint-comments

* report unused rules

* remove unused eslint comments from tests

* remove unused eslint comments 2nd pass

* remove unused eslint comments from src/

* remove unused comments in x-pack

* use no-script-url and no-unsanitized/property for ts files

* remove unused eslint comments

* eui/href-or-on-click removed when not complained

* no import/* rules for ts files

* cleanup

* remove the unused eslint-disable

* rollback unnecessary changes

* allow underscore prefix & sufix in type name

* update docs

* fix type error in enterprise search plugin mocks

* rename platform hack __coreProvider --> _coreProvider

* rollback space removal in src/core/public/legacy/legacy_service.test.ts

* fix naming convention in APM
 2020-08-05 17:32:19 +02:00
Melissa Alvarez
3fb77fb546
[ML] DF Analytics creation wizard: show link to results (#74025) 
* show view results card once job complete

* update types

* update types and move css to own file
 2020-08-05 10:31:47 -04:00
Dima Arnautov
8231b0ccfc
[ML] Fix initial plugin's bundle size (#74047) 
* [ML] use dynamic imports

* [ML] fix react-use imports

* [ML] change embeddables imports

* [ML] embeddable exports

* [ML] move SCSS import

* [ML] management page styles

* [ML] refactor with types and constants files

* [ML] move declarations
 2020-08-05 13:18:29 +02:00
Robert Oskamp
a25feb6d57
[ML] Functional tests - stabilize waiting for AD, DFA, TFM job list refresh (#74064) 
With this PR, the job list refresh for anomaly detection, data frame analytics and transforms is waiting for the refresh loading indicator to disappear before moving on.
 2020-08-03 17:07:33 +02:00
James Gowdy
278d3249b6
[ML] Add datafeed query reset button (#73958) 
* [ML] Add datafeed query reset button

* changing id

* adding translation

* fix typo

* default query refactor

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-08-03 12:15:07 +01:00
James Gowdy
d19883f624
[ML] Adding combined job and datafeed JSON editing (#72117) 
* [ML] Fixing edit datafeed usablility issues

* updates

* add json editing to all wizard steps

* removing unused include

* adding comments

* updating text

* text update

* wrapping preview in useCallback

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-08-03 11:44:40 +01:00
István Zoltán Szabó
a1872b1a70
[ML] Removes link from helper text on ML overview page (#73819) 2020-07-31 17:11:01 +02:00
Melissa Alvarez
9c5bbe4e5f
[ML] DF Analytics creation wizard: ensure user can switch back to form from JSON editor (#73752) 
* wip: add reducer action to switch to form

* rename getFormStateFromJobConfig

* wip: types fix

* show destIndex input when switching back from editor

* ensure validation up to date when switching to form

* cannot switch back to form if advanced config

* update types

* localization fix
 2020-07-31 10:44:45 -04:00
Walter Rafelsberger
145f2eef57
[ML] Migrate to React BrowserRouter and Kibana provided History. (#71941) 
- Migrate to React BrowserRouter and Kibana provided History including a fallback to redirect legacy hash based URLs.
- Migrate breadcrumbs away from hash based URLs.
- Make sure relative custom urls still work after migration.
 2020-07-31 10:25:01 +02:00
James Gowdy
8b061e3222
[ML] Removing node info check for file data viz import (#73717) 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-07-30 08:48:01 +01:00
Walter Rafelsberger
dd605c4e61
[ML] Transforms/DFA: Change action button size back to 'xs'. 
Changes the button size for the actions for transforms and data frame analytics list from s back to xs to be in line with the Anomaly Detection jobs list.
 2020-07-29 20:10:56 +02:00
James Gowdy
10cbaf5ca1
[ML] Disabling ML if license feature is disabled (#73187) 
* [ML] Disabling ML if license feature is disabled

* disabling UI feature

* removing unused import

* small refactor

* disabling ml using plugin updater

* function rename

* update comment

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-07-29 16:45:32 +01:00
James Gowdy
1b4d4d8a57
[ML] Fixing old _xpack style es endpoint paths (#73667) 
* [ML] Fixing old _xpack style es endpoint paths

* test comment

* removing test comment
 2020-07-29 16:44:40 +01:00
Melissa Alvarez
2dca40ab2f
[ML] DF Analytics results: ensure View link is only enabled when job has successfully completed (#73539) 
* disable view link if job is incomplete or failed

* ensure hooks run before return to avoid react error
 2020-07-29 11:19:53 -04:00
Clint Andrew Hall
719c292a0c
[kbn-storybook] Update Storybook to 5.3.19 (#73320) 
Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
 2020-07-29 10:00:53 -04:00
Larry Gregory
09b11b61f0
Introduce reserved ml privilege for the apm_user role (#72266) 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-07-28 07:44:37 -04:00
Garrett Spong
765c2d1ad3
[Security Solution][ML] Updates siem group name to security (#73218) 
## Summary

Resolves https://github.com/elastic/kibana/issues/69319

Updates `siem` grouping to `security`, and enables cloudtrail module, fixing mis-match between the newly updated modules (https://github.com/elastic/kibana/pull/71696).


<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/88444121-b6b27480-cdd8-11ea-886a-9b4cadbaede8.png" />
</p>

<p align="center">
  <img width="500" src="https://user-images.githubusercontent.com/2946766/88444181-16108480-cdd9-11ea-9fba-aff1e4c38da3.png" />
</p>


Also updates all module icons to be consistent:

Auditbeat (Before/After):
<p align="center">
    <img width="260" src="https://user-images.githubusercontent.com/2946766/88592057-9a9e1580-d01a-11ea-97bb-d1096a4ae85f.png" /><img width="300" src="https://user-images.githubusercontent.com/2946766/88592020-8b1ecc80-d01a-11ea-8f2d-aa5cba94924e.png" />
</p>

Packetbeat (Before/After):
<p align="center">
    <img width="260" src="https://user-images.githubusercontent.com/2946766/88592205-e18c0b00-d01a-11ea-9553-9c87527c600b.png" /><img width="300" src="https://user-images.githubusercontent.com/2946766/88592270-f8caf880-d01a-11ea-94a8-5428d2c6ddea.png" />
</p>

Winlogbeat (Before/After):
<p align="center">
    <img width="260" src="https://user-images.githubusercontent.com/2946766/88592286-fff20680-d01a-11ea-87dd-4150debc988c.png" /><img width="300" src="https://user-images.githubusercontent.com/2946766/88592351-2021c580-d01b-11ea-863f-efd26d0105ab.png" />
</p>



- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [X] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials
  - Working w/ @benskelker on updated ML Jobs & nomenclature
 2020-07-27 19:52:28 -06:00
Pete Harverson
d9a646113c
[ML] Fixes raw data drilldowns for Apache, Nginx, Auditbeat modules (#73280) 2020-07-27 17:36:05 +01:00
James Gowdy
c0968f5726
[ML] Fixing unnecessary deleting job polling (#73087) 2020-07-24 09:15:23 +01:00
James Gowdy
3883e3e239
[ML] Fixing recognizer wizard create job button (#73025) 
* [ML] Fixing recognizer wizard create job button

* updating translations
 2020-07-24 09:14:10 +01:00
James Gowdy
18df677da7
[ML] Fixing file import, module creation and results viewing permission checks (#72825) 
* [ML] Fixing file import and module creation permission checks

* correcting searches on results index

* fixing test

* removing unnecessary index

* updating apidoc

* fixing test

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
 2020-07-23 16:11:15 +01:00
James Gowdy
d4a362018a
[ML] Fixing link to index management from file data visualizer (#72863) 2020-07-23 09:23:19 +01:00
Quynh Nguyen
c9c2158682
[ML] Fix deleting DFA not showing index pattern check (#72904) 2020-07-22 14:05:53 -05:00
Melissa Alvarez
0dfc8a9dcd
[ML] DF Analytics creation wizard: default destination index to job id (#72758) 
* wip: add destIndexSameAsId checkbox

* update functional tests

* switch default to false when cloned job

* move switch below description
 2020-07-22 13:14:03 -04:00
Pete Harverson
a93c327e9d
[ML] Fix layout of anomaly chart tooltip for long field values (#72689) 2020-07-22 09:30:13 +01:00
James Gowdy
fbf41e5379
[ML] Handling data recognizer saved object errors (#72447) 
* [ML] Handling data recognizer saved object errors

* adding text for unknown errors

* fixing typos
 2020-07-21 14:28:10 +01:00
Quynh Nguyen
3760dc4f45
[ML] Fix annotation detector linking & delayed_data(0) (#72468) 2020-07-20 19:34:53 -05:00
Melissa Alvarez
a42a6d02fc
add index-pattern link when error contains 'click here' text (#72470) 2020-07-20 13:47:04 -04:00