Commit graph

599 commits

Author SHA1 Message Date
Diana Derevyankina ffe29f769a
Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0 (#84768)
* Gauge visualization can no longer be clicked to filter on values since Kibana 7.10.0

Closes #84191

* Add functional test to  filtering on gauge
2020-12-15 11:04:01 +03:00
Devon Thomson ac189b8c25
Deangularize Dashboard (#82909)
Deangularized dashboard application
2020-12-10 16:46:50 -05:00
Tre a4bdee898b
[QA][Stack Integration Tests] Fixup telemetry test (#85348)
Dont click on "Stack Monitoring" in this test, per Lee.
Nav to home page, so the test is not order dependendent.
Drop fn from the monitoring page, and
add it to the common page instead,
using a test subj selector over raw css.
2020-12-09 10:16:10 -07:00
Stratoula Kalafateli f2d961df6a
[Functional][TSVB] Wait for markdown textarea to be cleaned (#85128)
* [TSVB] Wait for markdown textarea to be cleaned

* No need for retry
2020-12-09 08:42:35 +02:00
Matthias Wilhelm 95f8d9d1dd
[Discover] New responsive layout using EUI components (#83633)
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Michail Yasonik <michail.yasonik@elastic.co>
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Co-authored-by: Marta Bondyra <marta.bondyra@elastic.co>
2020-12-03 15:42:45 +01:00
Mikhail Shustov 1ec2f1d078
Cleanup tsconfig files (#84396)
* remove unused "paths" from tsconfig

* remove unused test utils, import get-url from kbn/test

* dont pollute globals with jest when importing getUrl

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-30 19:12:00 +01:00
Robert Oskamp a31445f940
Fix advanced settings API integration tests on cloud (#84110)
This PR fixes the advanced settings feature controls API integration tests for cloud and moves some deployment helper methods to a separate service.
2020-11-24 13:46:51 +01:00
Daniil bb023c5c1c
[TSVB] Custom renderer (#83554)
* Implement custom renderer

* Remove legacy code

* Use custom expression

* Convert to typescript

* Remove savedObjectId extra param

* Other updates

* Fix types

* Cleanup

* Fix functional tests

* Bind uiSettings

* Update snapshot

* Update types

* Remove extra params

* Move common types

* Return back validation error message

* Use panel types enum

* Fix types

* Lazy load visualizations
2020-11-23 19:41:26 +03:00
Matthias Wilhelm 0a7f462939
[Discover] Allow custom name for fields via index pattern field management (#70039)
Co-authored-by: Matt Kime <matt@mattki.me>
2020-11-17 13:18:07 +01:00
Nathan Reese a2c91f18c6
[Maps] saved object tagging (#83197)
* add tag selector to save modal

* save tag references onSave

* populate tags when unwrapping attributes

* tslint

* update listing page to show tags

* fix data-test-subj id in functional tests

* i18n cleanup

* tslint

* remove unused import

* use listingTable service for functional tests

* tslint and fix mvt grid layer functional test

* review feedback

* add tags to all privileges and add test user to find, delete, get, get_all, and update tests

* move functions to module scope

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-16 19:52:15 -07:00
Stratoula Kalafateli 5710f6763b
[Visualize] New visualization wizard (#79627)
* [Visualizations] New vis wizard

* Update functional tests

* Create oss plugins for maps and lens and unregister alias function

* Add new plugins to .i18nrc.json

* Add readme and codeowners to the new plugins

* update docs

* fix tests

* fix types

* fixes

* Update development docs

* fix oss functional tests

* Fix jest and x-pack functional tests

* Fix functional test

* changes on the layout

* Cleanup and responsiveness

* cleanup unecessary code

* add common folder to the new OSS plugins

* remove unecessary translations

* Update limits.yml file

* Fix basic label

* Add experimental badge on controls vis

* Nice improvements

* fixes

* Improving styles

* Making modal go full height on smaller screens

* Fixing sass lint warning

* fix lint error

* fix internationalization error

* PR fixes

* PR changes

* Use useCallback where possible

* Remove translations that need to be translated again

* Lazy Load wizard modal

* Remove legacyMapVisualizationWarning

* Import the OSS plugins constants from the plugins

* Export constant from lensOss

* Change the new oss plugins from OSS to Oss

* Add a new line to the kibana.json files of the new plugins

* New nit fix

* Fix spaces

* Change the texts for the first step of the modal

* Fix test

* Fixes some of the PR comments

* Add onClick funtionality to the entire aggregation based card

* Cards description changes, introduce a copyFromRoot method to solve the problem of when disabling the x-pack plugic, to also disable the oss

* Create new FTR for testing the functionality of the wizard when both maps and lens apps are disabled

* fix eslint error

* Change groupTitles and descriptions

* Change input vis description

* Remove the copyFromRoot from the signature of the ConfigDeprecationFactory and export it from the main entrypoint

* Make the disabled cards badge clickable

* Changes from code review

* Fix functional tests failures

* Rename groupTitle to titleInWizard to be more specific

* Change vega vis note

* minor design changes

* fix problem with plugins list docs

* Retrieve maps and lens landing page from docs service and add tracking url param

* Fix funtional test for the new dashboard flow

* Fix logic in alias registry for removing the discardOnRegister alias

* no need to remove the alias entry from the discardOnRegister array

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: miukimiu <elizabet.oliveira@elastic.co>
2020-11-06 18:03:44 +02:00
Alexey Antonov 0faf8c24ee
Use monacco editor in the inspector request panel (#82272)
* Use monacco editor in the inspector request panel

Closes: #81921

* insRequestCodeViewer -> insRequestCodeViewer

* remove uiSettings from props

* fix functional tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-06 11:34:57 +03:00
spalger af73961646 Revert "Index patterns api - load field list on server (#81218)"
This reverts commit e683ece777.
2020-11-04 09:52:15 -07:00
Matthew Kime e683ece777
Index patterns api - load field list on server (#81218)
Index patterns api - load field list on server
2020-11-04 09:18:56 -06:00
Pierre Gayvallet e2cbde3439
SavedObjects management: display explicit import error in case of failure and avoid invalid file to crash the server (#82406)
* display error cause in case of import failure

* avoid server crash when importing invalid file

* remove unused translations

* fix unit tests

* change savedObjects.maxImportPayloadBytes default to 25mb

* fix types and logic
2020-11-04 16:01:45 +01:00
Matthias Wilhelm 82ee8ae6c4
[Discover] Unskip functional sidebar test (#81188) 2020-11-03 17:24:55 +01:00
Pierre Gayvallet d4b2a5145a
SavedObjects tagging MVP (#79096)
* create xpack plugin skeleton, start to implement management section

* add tag creation modal

* first implementation of the tags table

* use InMemoryTable

* add edit modal and delete action

* update plugin list

* add tag list, fix types

* add capabilities check on client-side

* add tag combo box component

* add missing i18n keys

* fix privilege FTR tests

* add base structure for FTR tests

* fix feature ftr test

* use string literals for i18n

* create savedObjectsTaggingOss plugin, move API types to oss plugin, start to wire to SO management page.

* update plugin list

* fix types

* allow to use `_find` with multiple references

* add FTR test for _find API on references fields

* add _find integration tests

* update generated doc

* start to implement tag filtering on SO management section

* update generated docs

* wire tagging API to dashboard listing page

* fix i18n namespace

* fix type & tests

* update dashboard listing snapshots

* adapt FTR listingTable service to search for parsable queries

* wite tagging API to visualize listing

* update tagging plugin limits

* add server-side and client-side validation for tag create/edit

* rename title field to name

* fix types

* fix types bis

* add removeReferencesTo API to SOR/SOC

* update generated doc

* add server-side unit test for `savedObjectsTagging` plugin

* move tagging API types to its own file

* add savedObjectsTaggingOss mock

* add tags_cache tests

* add tests for client-side tag client

* extract uiApi to distinct files

* various API improvements

* add more tests

* add link between tag and so management sections + add connection counts

* add base functional test suite for tagging

* add more FTR tests

* improve feature control func test

* update codeowners

* update generated doc

* fix access to proxy modal

* adapt SO save modal to allow to add tag field

* add SO decorator registry and tag implementation

* add unit tests for SO tag decorator

* add functional tests for visualize integration

* add tag SO read permission for vis/dash feature

* add RBAC api integ tests

* add API integration tests

* add test for getTagConnectionsUrl

* add SOM test suite

* add dashboard integration suite

* remove test line

* add missing unit tests

* improve API types doc

* fix create modal save button label

* remove console.log

* improve doc

* self review

* add refresh interval for tag cache

* improve page object doc

* minor cleanup

* address review comments

* small layout fixes

* add initial focus

* use lazy accessor for tag request handler context

* adapt SOM export and export route to handle references

* remove icon from feature config due to master changes

* fix SO table tests

* update generated docs

* sort tags by name in filter dropdown and listing component

* wire SO tagging to dashboard save modal

* fix types

* - add 'create tag' action in tag selector
- add notifications on update/create/delete from management
- delete modal wording

* add description max length validation

* remove real-time validation

* fix i18n bundle id

* update expected size of savedObjectsTagging plugin

* use own useIfMounted

* update limit again, contract components cannot be lazy loaded atm.

* math is hard

* remove single usage of lodash for bundle size

* add async imports for create/edit modal

* add FTR test for 'create tag' action from tag selector

* allow 'create new' option to prepopulate name field

* extract savedObjectToTag

* add advancedSettings read user for security api_integ suite

* add audit login for security client wrapper

* use import type when possible

* wire SO tagging to lens visualization

* fix lens jest test

* Fix `create tag` option being selected when closing the selector dropdown

* add sorting to tag column from getTableColumnDef

* address some of restrry comments

* rename tag selector's setSelected option to onTagsSelected

* fix audit logging even type for saved_object_remove_references

* update plugin size limit to current size

* adapt maxlength validation wording

* remove selection column until we have batch action menu

* remove connections link when user lack read privilege to savedObjectManagement

* forbid registering multiple SO decorators with the same priority

* add so decorator test

* extract getTagFindReferences and create API mock

* update audit-logging ascidoc

* doc nit

* throw conflict error if update returns any failure

* use refresh=true as default

* wording nits

* export: rename `references` to `hasReference`

* update generated doc

* set description max length to 100

* do not initialize tag cache on anonymous pages

* split fetchObjectsToExport into two distinct functions

* change tag client `delete` call order

* tsdoc nits

* more nits

* add README for oss plugin

* add oss plugin start tests

* SavedObject.find: rename `references` to `hasReference`

* change section description label

* remove url prefix constants

* last nits and comments

* update generated doc
2020-11-03 10:33:18 +01:00
Greg Thompson 6fdc7eb1fa
Upgrade EUI to v30.1.1 (#81499)
* eui to v30.0.0

* removed unused RecentLinks component

* update compressed -> display prop

* euiformrow compressed -> display

* euipopover remove withtitle

* euibuttongroup prop updates

* remove euibuttontoggle

* src snapshot updates

* tutorial euibuttongroup update

* x-pack snapshot updates

* euibuttongroup test updates

* TODO

* misc. js file updates

* remove euinavdrawer scss references

* translation removals

* more x-pack snapshot updates

* update data-test-subj lookup

* icons logoAMP -> logoObservability

* cypress selector updates

* update euibuttontoggle onchange, test interaction

* Fix auto-update toggle in Visualize

* some more change -> click test updates

* idtoselectedmap change

* Fix feature table button group

* Remove empty SASS file

* Fix feature table button group II

* Using `compressed` to also dictate dual range row

* Fix a few security labels

* An ML fix

* Apply suggestions from code review

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>

* remove unused translation

* update view_type_toggle snapshot

* more snapshot updates

* eui to 30.1.0

* undo temp ts-ignore

* more x-pack snapshot updates

* eui to 30.1.1

* update feature privilege text

* Update x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/feature_table/sub_feature_form.tsx

Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>

* reuse i18n token

* Adapt log entry action button to new `minWidth` prop

* clean up label

* Combine auto apply strings into one

* ternary fix

* cases status useCallback

Co-authored-by: cchaos <caroline.horn@elastic.co>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Joe Portner <5295965+jportner@users.noreply.github.com>
Co-authored-by: Felix Stürmer <stuermer@weltenwort.de>
2020-10-30 16:18:27 -06:00
Pierre Gayvallet 21615c16ef
SO management: fix legacy import index pattern selection being reset when switching page (#81621)
* fix legacy import index pattern selection being reset when switching pages

* update snapshots
2020-10-30 12:59:28 +01:00
Nick Partridge e0b6b0ba5c
Vislib visualization renderer (#80744) 2020-10-29 13:34:41 -05:00
Spencer 441890ccb3
[ftr/menuToggle] provide helper for enhanced menu toggle handling (#81709)
Co-authored-by: spalger <spalger@users.noreply.github.com>
2020-10-27 09:09:41 -07:00
Nathan Reese 95516432ec
[Maps] fix refreshing the page causes loss of unsaved change (#81226)
* [Maps] fix refreshing the page causes loss of unsaved change

* fix functional tests

* remove unneeded check for app leave modal

* check for appLeaveConfirmModal for clicking confirmModalConfirmButton

* see failures without closing appLeaveModal

* start clearing unsaved changes warning in maps

* clean up more unsaved state in functional tests

* more cleaning up of unsaved state in functional tests

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-22 15:00:55 -06:00
Pierre Gayvallet 668a4d4366
SOM: fix inspect action when having a basePath (#80950)
* SOM: fix inspect action when having a basePath

* remove explicit login

* remvoe useless object from dump

* review comments
2020-10-19 17:34:10 +02:00
Anton Dosov a23b42301b
[Discover] fix auto-refresh (#80635)
* fix refresh interval in discover
* Also implicitly fixes a subtle bug with excessive re-fetch after deleting already disabled filter

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-16 18:06:50 +02:00
Liza Katz a1831a6d9d
[Search] Client side session service (#76889)
* Add a session service and use it in discover and dashboard

* check unefined

* Start session in visualize

* Fix tests

* docs

* OSS error alignemnt

* Adjust error messages in xpack

* Add getErrorMessage

* Use showError in vizualize
Add original error to expression exception

* Cleanup

* ts, doc and i18n fixes

* Fix jest tests

* Fix functional test

* functional test

* ts

* Update functional tests

* Add unit tests to interceptor and timeout error

* expose toasts test function

* doc

* typos

* lint

* Cleanup

* review 1

* Code review

* doc

* doc fix

* visualization type fix

* fix jest

* Fix xpack functional test

* fix xpack test

* code review

* Add tracking methods to session service

* remove chromium

* Fix ts and jest tests

* jest + docs

* ts fix

* siem test

* Use session service to show a timeout notification per session + more unit tests

* ts and docs

* Remove session service from search source (not needed)

* Code review

* ts

* Single active session in FE session service

* Cleanup

* Don't integrate with dashboard \ visualize
Add functional tests for session toast plugin

* Typescript

* ts

* Improve functional tests

* es

* simplify filter test

* wait until loadedw

* filter test

* delete crypto for now

* Select the correct index 🤦

* timerange

* Adjust functional test logic

* improved test format @dosant

* Handle exceptions

* Don't close sessions automatically, warn instead

* jest

* Adjust functional test

* Remove unused code

* delete export

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-16 12:30:46 +03:00
Matthias Wilhelm 3f3589d74b
[Discover] Loading spinner cleanup (#79819) 2020-10-12 20:11:20 +02:00
IgorG 567100d3b8
Resolver Tree Events tests (#79344)
* commiting change for the dismiss Banner

* Change comments

* Change timeout and gziped data file

* Fixed banner list fail

* Moved dismiss Banner code to the common_page.ts

* Remove find from host_page

* Remove comments from host_page

* Added Expected data to the related Evens
Renamed tests from Child events to Related Events

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-10-07 07:56:09 -07:00
Thomas Watson e31ec7eb54
Give user the option to log out if they encounter a 403 (#75538) 2020-10-06 20:40:28 +02:00
Maja Grubic 0e89431825
[Visualize Editor] Add cancel button when navigating from Dashboard (#77608)
* Add cancel button in the visualize editor

* Fixing i18n namespace

* Always show cancel button

* Always show cancel button

* Adding a fucntional test

* Show confirm dialog only if there are unsaved changes

* Show confirm modal only if there are changes

* Add onAppLeave handler and ditch confirmModal

* Fix functional test

* Only use onAppLeave if coming from dashboard/canvas

* Add actions.default to onSave and onSaveAndReturn

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-06 19:20:53 +01:00
Stratoula Kalafateli 36814aa1ef
Change implementation on TSVB functional when testing the indexPattern switch (#78754)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-10-01 13:30:10 +03:00
Stratoula Kalafateli 108a2302cd
[Functional] Wait for the page to load and then click the new vis button (#78725) 2020-09-30 10:02:16 +03:00
Bhavya RM 9c959947a8
Fixing a11y test failure on discover app (https://github.com/elastic/kibana/issues/59975) (#77614) 2020-09-28 14:21:54 -04:00
Ryan Keairns beb1f83e79
Use new header icon badge for newsfeed button (#77946)
* Use new header icon badge for newsfeed button

* add i18n, fix flyout level

* fix i18n namespace, fix badge test

* update newfeed badge test
2020-09-21 12:51:43 -05:00
Larry Gregory 613509d81a
Improve home screen for limited-access users (#77665) 2020-09-18 08:54:08 -04:00
Matthias Wilhelm 0dc0f1f34c
[Discover] Migrate discover.html Angular template to React (#75784)
Co-authored-by: Andrea Del Rio <delrio.andre@gmail.com>
2020-09-17 07:51:31 +02:00
Lee Drengenberg 23a0dcebe2
scroll to top of #kibana-body before trying to click createIndexButton (#77550)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-16 12:21:19 -05:00
Stratoula Kalafateli 98113eeb1b
[Functional] Fixes cloud failures on TSVB markdown (#77158)
* [TSVB] Remove the char by char typing on markodown

* revert

* Add the markdown to be computed immediately and give some time to compute it

* Add retry to locate TSVB tabs
2020-09-15 17:02:03 +03:00
Dmitry Lemeshko 1ab229aea8
[x-pack/test] convert PO to typescript, improve find/testSubject usage (#77389) 2020-09-15 15:43:56 +02:00
Michail Yasonik 61c4e6fd8d
Stacked headers and navigational search (#72331)
Co-authored-by: Poff Poffenberger <poffdeluxe@gmail.com>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: pgayvallet <pierre.gayvallet@elastic.co>
Co-authored-by: cchaos <caroline.horn@elastic.co>
2020-09-14 14:32:30 -05:00
Stratoula Kalafateli 11be458be3
[Functional] Unskip vega tests and fix flakiness (#76600)
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-07 13:40:13 +03:00
Matthias Wilhelm 1eec83d7b9
[Discover] Fix time zone switch functional test in cloud env (#76396) 2020-09-04 13:22:35 +02:00
Luke Elmers 64b772613b
[data.indexPatterns] Fix broken rollup index pattern creation (#76593) 2020-09-03 08:13:33 -06:00
Pierre Gayvallet 210d6f2df1
Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal (#76482)
* Legacy SO import: Fix bug causing multiple overrides to only show the last confirm modal

* eslint

* fix for loops
2020-09-03 08:50:03 +02:00
Alexey Antonov 7d82e273a6
Add auto interval to histogram AggConfig (#76001)
* Add `auto` interval to histogram AggConfig

Closes: #75438

* fix JEST

* update UI

* add tests

* some changes

* small changes

* cleanup code

* fix PR comment

* fix PR comments

* fix PR comment

* Update src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.test.ts

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

* Change algorithm for auto interval

* Update src/plugins/data/common/search/aggs/buckets/histogram.ts

Co-authored-by: Luke Elmers <lukeelmers@gmail.com>

* added some comments

* Update src/plugins/data/common/search/aggs/buckets/lib/histogram_calculate_interval.ts

Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Wylie Conlon <wylieconlon@gmail.com>
Co-authored-by: Luke Elmers <lukeelmers@gmail.com>
2020-09-02 01:12:17 +03:00
Daniil Suleiman b8c7945b12
[TSVB] Fix panel config updates on history changes (#75896)
* Apply history changes to panel config

* Add functional tests

* Update jest snapshot

* Add waiters for stabilizing vis chart

* Fix comments

* Remove unused method isValidKueryQuery

* Add a waiter for component render

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-09-01 13:29:35 +03:00
Joe Portner 6627d7d9af
Sharing saved-objects phase 1.5 (#75444)
Added UI for sharing saved objects, and updated UI for importing and copying too
2020-08-26 16:52:29 -04:00
Catherine Liu 532f2d70e8
[Home] Elastic home page redesign (#70571)
Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
2020-08-26 13:00:00 -07:00
Marius Dragomir 7eb02d11aa
Handle change in saml VM name (#73808)
* Handle change in saml VM name

* fix lint problem

* Update login_page.ts

* Fix tslint

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-24 15:28:25 +02:00
Bhavya RM 6376bab559
adding additional tests for the awesome new nav by core ui team and checking off a flaky test' (#75494) 2020-08-20 12:40:18 -04:00
Alexey Antonov d158692bf5
Vega is now GA (#75157)
* Bringing Vega out of experimental

Closes: #21721

* fix CI group 12

* remove experimental flag from doc

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-08-20 12:19:21 +03:00