* [Maps] fix refreshing the page causes loss of unsaved change
* fix functional tests
* remove unneeded check for app leave modal
* check for appLeaveConfirmModal for clicking confirmModalConfirmButton
* see failures without closing appLeaveModal
* start clearing unsaved changes warning in maps
* clean up more unsaved state in functional tests
* more cleaning up of unsaved state in functional tests
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* fix refresh interval in discover
* Also implicitly fixes a subtle bug with excessive re-fetch after deleting already disabled filter
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add a session service and use it in discover and dashboard
* check unefined
* Start session in visualize
* Fix tests
* docs
* OSS error alignemnt
* Adjust error messages in xpack
* Add getErrorMessage
* Use showError in vizualize
Add original error to expression exception
* Cleanup
* ts, doc and i18n fixes
* Fix jest tests
* Fix functional test
* functional test
* ts
* Update functional tests
* Add unit tests to interceptor and timeout error
* expose toasts test function
* doc
* typos
* lint
* Cleanup
* review 1
* Code review
* doc
* doc fix
* visualization type fix
* fix jest
* Fix xpack functional test
* fix xpack test
* code review
* Add tracking methods to session service
* remove chromium
* Fix ts and jest tests
* jest + docs
* ts fix
* siem test
* Use session service to show a timeout notification per session + more unit tests
* ts and docs
* Remove session service from search source (not needed)
* Code review
* ts
* Single active session in FE session service
* Cleanup
* Don't integrate with dashboard \ visualize
Add functional tests for session toast plugin
* Typescript
* ts
* Improve functional tests
* es
* simplify filter test
* wait until loadedw
* filter test
* delete crypto for now
* Select the correct index 🤦
* timerange
* Adjust functional test logic
* improved test format @dosant
* Handle exceptions
* Don't close sessions automatically, warn instead
* jest
* Adjust functional test
* Remove unused code
* delete export
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* commiting change for the dismiss Banner
* Change comments
* Change timeout and gziped data file
* Fixed banner list fail
* Moved dismiss Banner code to the common_page.ts
* Remove find from host_page
* Remove comments from host_page
* Added Expected data to the related Evens
Renamed tests from Child events to Related Events
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* Add cancel button in the visualize editor
* Fixing i18n namespace
* Always show cancel button
* Always show cancel button
* Adding a fucntional test
* Show confirm dialog only if there are unsaved changes
* Show confirm modal only if there are changes
* Add onAppLeave handler and ditch confirmModal
* Fix functional test
* Only use onAppLeave if coming from dashboard/canvas
* Add actions.default to onSave and onSaveAndReturn
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This creates new Add Data tutorials for Filebeat modules.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
* [Dashboard][Embeddable] Add placeholder title to embeddable panel, stored 'show panel title' prop in embeddable input.
Co-authored-by: Maja Grubic <maja.grubic@elastic.co>
* feat: 🎸 add grouping to presentable interface
* feat: 🎸 add group to "Explore underlying" data action
* refactor: 💡 return panel list and simplify context creation
* refactor: 💡 simplify context menu builder code
* refactor: 💡 further simplify context menu builder code
* feat: 🎸 add grouping to context menu builder
* feat: 🎸 add icon to drilldowns group
* fix: 🐛 sort in the other order
* feat: 🎸 group drilldown actions in edit mode
* fix: 🐛 fix TypeScript error
* feat: 🎸 wrap long context menu list into a submenu
* feat: 🎸 improve context menu long list wrapping
* feat: 🎸 display drilldowns panel at the bottom of main panel
* feat: 🎸 add separator line for context menu
* test: 💍 add basic context menu builder unit tests
* feat: 🎸 remove meta decoratiosn from generated menu
* test: 💍 add test subject attribute to "More" menu item
* chore: 🤖 remove separator line and add comment about EUI
* test: 💍 update Jest snapshots
* chore: 🤖 revert back change of showing both drilldown options
* test: 💍 add context menu samples to example plugin
* feat: 🎸 collapse long groups into a sub-panel
* test: 💍 add context menu panel edit mode examples
* test: 💍 fix OSS functional test
* test: 💍 fix X-Pack functional tests
* fix: 🐛 re-introduce item sorting by title
* test: 💍 allow explicitly opening more menu
* test: 💍 try opening more panel in functional tests
* test: 💍 disable some tests
* chore: 🤖 remove unused code
* test: 💍 use action test helper in unit tests
* refactor: 💡 add helper utility to generate actions in examples
* test: 💍 disable one more functional test
* test: 💍 improve how inspector is opened in functional tests
* test: 💍 enable functional test
* refactor: 💡 convert test suite to typescript
* test: 💍 move panel replace tests into a separate test suite
* test: 💍 move panel cloning tests to a separate test suite
* test: 💍 set up dashboard context menu test suite
* test: 💍 enable few panel context menu tests
* test: 💍 enable saved search panel tests
* test: 💍 enable expanded panel context menu tests
* test: 💍 remove render complete awaits
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Moves common utility functions to obtain the repository root,
paths (config/data), and Kibana package.json to a @kbn/utils package.
Moving these existing functions allows them to be used in production, in
other packages because of Kibana.
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
* [TSVB] Remove the char by char typing on markodown
* revert
* Add the markdown to be computed immediately and give some time to compute it
* Add retry to locate TSVB tabs
* remove advanced json for count agg
* Remove only advanced json from count agg
* use Constant from data plugin
* add the logic to data plugin
* remove json arg from function definition
* remove unecessary translations
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Catherine Liu <catherine.liu@elastic.co>
Co-authored-by: Ryan Keairns <contactryank@gmail.com>
Co-authored-by: Catherine Liu <catherineqliu@outlook.com>
Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co>
* Bringing Vega out of experimental
Closes: #21721
* fix CI group 12
* remove experimental flag from doc
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Navigate from discover to visualize with registering into a trigger
* Implement the VISUALIZE_FIELD action
* Implementation of the maps app trigger actions with the isCompatible functionality
* clean up discover code and tile map action implementation
* Add typeIsHidden on mocks
* Retrieve filters and query from url state
* functional test for oss and tile map
* include geoshape
* fix functional tests
* fix types
* remove unecessary dependencies
* minor fixes
* Remove tilemaps actios as it is going tobe deprecated
* Add useEffect on discover details and move the map action to a separate folder
* Retrieve map tooltips info from context
* Retrieve query and filters from QueryService
* Building urls with urlGenerators
* replace with constants, fetch initialLayers as array
* remove irrelevant comments
* nice improvements
* Return contextualFields for both triggers
* Add getHref on actions, move capabilities to isCompatible method per action and other fixes
* fix type
* Fix type incompatibility after merging with master
* fixes on maps plugin file after merge
* remove unecessary declarations
* nice improvements
* Refactor maps services code to be inline with master
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* pass originatingApp into App
* save and return top nav option
* clean up
* navigate to originating app
* functional test
* tslint
* cutOriginatingAppConnection
* add functional test for cutting originating app flow
* one more fix for cutting originator app and another functional test to verify
* typo
* review feedback
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* Adds a wait time between setting the index pattern and the time field on tsvb
* Char by char to set indexpattern to give more time to load the time field
* Add more time
* uncomment commented lines
* Rename kibana_breadcrumbs to kibana_chrome
- in anticipation of upcoming refactor where SetPageChrome now handles document title as well as Kibana breadcrumbs
+ cleanup exports
* Add generate_title helpers
- will be used by new set_chrome helper
* Add setDocTitle context + behavior to set_chrome
+ refactor set_chrome.test.tsx:
- add title tests
- add SetWorkplaceSearchChrome test to increase coverage
- clean up inner/outer call in favor of simpler mocks/imports
- simplify isRoot tests
* Update plugins to set product titles
- on mount but before render
* Copy feedback - change pipe separator to hyphen
- to match ' - Elastic'
* Add functional tests confirming that document titles updated
- Better distinction and relationship between IndexPatternField and its spec
- IndexPatternField class is no longer defined via object mutation
- Reduction of dependencies
- UI code moved into Index Pattern class (will be removed in next ticket)
- IndexPattern field list was previously composed of IndexPatternFields or specs, now only IndexPatternFields
- IndexPattern field list was previously redefined when loading fields, now only its contents are replaced.
Fixes#71461 regression since 7.7
New state syncing utils didn't properly handle errors,
Errors happening during URL parsing or writing wasn't handled, so state syncing could stop or in worth case blow out. (see #71461)
There are not much scenarios where missing proper error handling could really impact users, except the one described in #71461:
Kibana users state:storeInSessionStorage
Users often intuitively share hashed dashboard urls directly
When someone opens those urls - there is a blank screen with warning
In 7.6 - dashboard would still load with default state.
Since 7.7 these still could be achieved by removing query params for URL, but it is not obvious for regular users.
This PR makes sure that behaviour is similar to one we had before 7.7.
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* improve test stability
* query string input manager (needed for search demo)
* docs
* dashboard
* Fix jest
* mock fix
* Allow restoring a saved query
* sync url
* Luke's fix to test
* cleanup
* lens jest tests
* docs
* use queryStringManager.getDefaultQuery
Don't sync query to global state
* Update app.test.tsx
lens mock
* jest fix
* jest
* use new api in the example
* Rename state param to query to match url state
* Apply changes to discover
* Update src/plugins/data/public/query/query_string/index.ts
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
* Improve query string state manager
* Cleanup dashboard code
* Handle refresh button
* Set initial dashboard state
* visualize state
* remove unused
* docs
* fix example
* fix jest
* fix filter app state in discover
* fix maps test
* jest
Co-authored-by: Anton Dosov <anton.dosov@elastic.co>
Co-authored-by: Anton Dosov <dosantappdev@gmail.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
