kibana/x-pack/plugins
Scotty Bollinger 0f3e4f415f
[Workplace Search] Fix Chrome issues with GitHub sources (#105680)
* Fix route validation

This param is not always required. Was already fixed for org version but the personal dashboard came later and was not fixed.

Original fix for org:
30d8b1dfa8 (diff-07f094b2a4719e8511f003d8e278a77cd6b808d11b14d1c528705f9b259c328fR373)

* Fix route to account for private github route

Previously had the org route hard-coded

* Move the logic for parsing the query params to template

Because the useEffect call comes after the initial render, the chrome flashes. We originally got around this by hiding the chrome always because in non-github scenarios, this worked fine.

However, because the oauth plugin sends the state in the quert params and uses the same URL, we need to parse that to determine whether this is an org or accoutn route. We now do that logic in the template and set the chrome before calling the useEffect.

We still need to pass both the parsed params and the original quert string because the redirect passes that string to the next view.
2021-07-14 19:44:49 -04:00
..
actions
alerting [RAC] [RBAC] MVP RBAC for alerts as data (#100705) 2021-07-08 15:24:17 -04:00
apm [APM] APM agent config created prior to Fleet migration is not injected into integration policy (#105504) 2021-07-14 15:03:27 -04:00
banners
canvas [Top Menu] Increase size of top menu links to s (#103144) 2021-07-12 12:50:41 -04:00
cases Updating urls to upstream elastic repo (#105250) 2021-07-13 09:10:30 -04:00
cloud
cross_cluster_replication
dashboard_enhanced
dashboard_mode
data_enhanced [Search Sessions] Expire empty sessions after a minute (#105430) 2021-07-13 19:03:31 +02:00
data_visualizer [ML] Fix Index Data Visualizer not gracefully handling error (#104567) 2021-07-13 11:35:39 -05:00
discover_enhanced
drilldowns
embeddable_enhanced
encrypted_saved_objects
enterprise_search [Workplace Search] Fix Chrome issues with GitHub sources (#105680) 2021-07-14 19:44:49 -04:00
event_log
features
file_upload Removing async from file upload and data visualizer plugins start lifecycle (#105197) 2021-07-13 09:08:40 +01:00
fleet [Fleet] Add containerized fleet server instructions to Fleet README (#105669) 2021-07-14 18:59:38 -04:00
global_search
global_search_bar
global_search_providers
graph [KibanaLegacy] Remove unused stuff and make things async if it is easy (#104638) 2021-07-12 15:13:42 +03:00
grokdebugger
index_lifecycle_management
index_management
infra [Logs&Metrics UI] add owner properties to plugin manifest (#105580) 2021-07-14 22:25:17 +02:00
ingest_pipelines [Ingest pipelines] add network direction processor (#103436) 2021-07-13 12:43:10 +03:00
lens [Lens] Fix field stats when multiple runtime fields are used (#105359) 2021-07-13 14:19:49 -04:00
license_api_guard
license_management
licensing
lists [Security Solutions][Detection Engine] Removes dead duplicated code and marks other duplicated code (#105374) 2021-07-13 16:23:58 -06:00
logstash
maps [maps] show actionable message when term joins have no matches (#105161) 2021-07-14 06:20:51 -06:00
metrics_entities
ml [ML] Fix calendar creation during model snapshot restore (#105421) 2021-07-13 19:11:55 +01:00
monitoring [KibanaLegacy] Remove unused stuff and make things async if it is easy (#104638) 2021-07-12 15:13:42 +03:00
observability [Fleet] Remove beta label from observability overview (#105590) 2021-07-14 10:47:47 -04:00
osquery [Osquery] Revert fix Saved Query mapping (#105503) 2021-07-13 18:10:08 -04:00
painless_lab
remote_clusters
reporting updated UI copy (#105184) 2021-07-13 13:48:46 +02:00
rollup
rule_registry [Logs UI] Register log threshold rule as lifecycle rule (#104341) 2021-07-13 11:59:11 +02:00
runtime_fields
saved_objects_tagging
searchprofiler
security
security_solution Fixes cypress flake across two tests (#105645) 2021-07-14 15:03:25 -06:00
snapshot_restore
spaces [Top Menu] Increase size of top menu links to s (#103144) 2021-07-12 12:50:41 -04:00
stack_alerts [Maps] Fix tracking threshold alerts improper handling of elasticsearch epoch millis strings (#105010) 2021-07-09 16:28:02 -04:00
task_manager
telemetry_collection_xpack
timelines [APM] Fixes support for APM data streams in Security and Timelines UIs (#105334) 2021-07-14 00:11:38 -04:00
transform
translations [i18n] Fix some hardcoded translations on Dashboard & Discover (#105555) 2021-07-14 18:11:35 +02:00
triggers_actions_ui [Actions] Swimlane: Change API Token field to a password textfield (#105475) 2021-07-14 11:21:58 +03:00
ui_actions_enhanced
upgrade_assistant
uptime [Logs&Metrics UI] add owner properties to plugin manifest (#105580) 2021-07-14 22:25:17 +02:00
watcher
xpack_legacy