kibana/x-pack
Frank Hassanabad 178c7a48fc
[SIEM][Detection Engine] Adds critical missing status route to prepackaged rules
## Summary

* Fixes a critical bug where the missing status for the REST route was missing
* Fixes a bug with the 400 not being used for the missing index in some cases
* Changes create and update to NO LONGER allow immutable to be passed
* Fixes a bug with the add prepackaged schema to where you could use `immutable: false`. Now it is required to be missing or set to `immutable: true` within it. 
* Cleans up unit tests

To use the critical bug missing status for the REST route:

```ts
GET /api/detection_engine/rules/prepackaged/_status 
```

And you will get back:

```ts
{
  "rules_installed": 252,
  "rules_not_installed": 87,
  "rules_not_updated": 0
}
```

See the script:

```ts
get_prepackaged_rules_status.sh
```

for more details

### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-16 10:37:22 -07:00
..
.github
build_chromium
dev-tools Security - Role Mappings UI (#53620) 2020-01-11 13:26:31 -05:00
legacy [SIEM][Detection Engine] Adds critical missing status route to prepackaged rules 2020-01-16 10:37:22 -07:00
plugins [Endpoint] add Redux saga Middleware and app Store (#53906) 2020-01-16 11:34:32 -05:00
scripts Create UI for alerting and actions plugin (#48959) 2020-01-13 16:16:20 -08:00
tasks run mocha tests from x-pack with root mocha script (#51352) 2019-11-25 11:39:20 -07:00
test [SIEM] Dns histogram enhancement (#54902) 2020-01-16 18:46:22 +08:00
test_utils [Index Management] Add Mappings Editor to Index Template Wizard (#47562) 2020-01-14 17:09:29 -08:00
typings migrate TaskManager Plugin to the Kibana Platform (#53869) 2020-01-13 19:09:57 +00:00
.gitignore
.i18nrc.json Create UI for alerting and actions plugin (#48959) 2020-01-13 16:16:20 -08:00
.kibana-plugin-helpers.json [feature][Canvas] Share Workpads in other Websites (#46278) 2019-10-11 12:15:41 -05:00
gulpfile.js run mocha tests from x-pack with root mocha script (#51352) 2019-11-25 11:39:20 -07:00
index.js Create UI for alerting and actions plugin (#48959) 2020-01-13 16:16:20 -08:00
package.json Upgrade io-ts after fix was merged and update use of some types (#55013) 2020-01-16 13:57:37 +01:00
README.md Updating accessibility guide and contributing readmes (#52038) 2019-12-04 19:11:16 -06:00
tsconfig.json Convert ui/agg_types/buckets to TypeScript / Jest (#47730) 2019-10-15 21:18:34 +03:00

Elastic License Functionality

This directory tree contains files subject to the Elastic License. The files subject to the Elastic License are grouped in this directory to clearly separate them from files licensed under the Apache License 2.0.

Development

By default, Kibana will run with X-Pack installed as mentioned in the contributing guide.

Elasticsearch will run with a basic license. To run with a trial license, including security, you can specifying that with the yarn es command.

Example: yarn es snapshot --license trial --password changeme

By default, this will also set the password for native realm accounts to the password provided (changeme by default). This includes that of the kibana user which elasticsearch.username defaults to in development. If you wish to specific a password for a given native realm account, you can do that like so: --password.kibana=notsecure

Testing

Running specific tests

Test runner Test location Runner command (working directory is kibana/x-pack)
Jest x-pack/**/*.test.js
x-pack/**/*.test.ts
cd x-pack && node scripts/jest -t regexp [test path]
Functional x-pack/test/*integration/**/config.js
x-pack/test/*functional/config.js
x-pack/test/accessibility/config.js
node scripts/functional_tests_server --config x-pack/test/[directory]/config.js
node scripts/functional_test_runner --config x-pack/test/[directory]/config.js --grep=regexp

Examples:

  • Run the jest test case whose description matches 'filtering should skip values of null': cd x-pack && yarn test:jest -t 'filtering should skip values of null' plugins/ml/public/application/explorer/explorer_charts/explorer_charts_container_service.test.js
  • Run the x-pack api integration test case whose description matches the given string: node scripts/functional_tests_server --config x-pack/test/api_integration/config.js node scripts/functional_test_runner --config x-pack/test/api_integration/config.js --grep='apis Monitoring Beats list with restarted beat instance should load multiple clusters'

In addition to to providing a regular expression argument, specific tests can also be run by appeding .only to an it or describe function block. E.g. describe( to describe.only(.

Running all tests

You can run unit tests by running:

yarn test

If you want to run tests only for a specific plugin (to save some time), you can run:

yarn test --plugins <plugin>[,<plugin>]*    # where <plugin> is "reporting", etc.

Debugging browser tests

yarn test:browser:dev

Initializes an environment for debugging the browser tests. Includes an dedicated instance of the kibana server for building the test bundle, and a karma server. When running this task the build is optimized for the first time and then a karma-owned instance of the browser is opened. Click the "debug" button to open a new tab that executes the unit tests.

Run single tests by appending grep parameter to the end of the URL. For example http://localhost:9876/debug.html?grep=ML%20-%20Explorer%20Controller will only run tests with 'ML - Explorer Controller' in the describe block.

Running server unit tests

You can run server-side unit tests by running:

yarn test:server

Running functional tests

For more info, see the Elastic functional test development guide.

The functional UI tests, the API integration tests, and the SAML API integration tests are all run against a live browser, Kibana, and Elasticsearch install. Each set of tests is specified with a unique config that describes how to start the Elasticsearch server, the Kibana server, and what tests to run against them. The sets of tests that exist today are functional UI tests (specified by this config), API integration tests (specified by this config), and SAML API integration tests (specified by this config).

The script runs all sets of tests sequentially like so:

  • builds Elasticsearch and X-Pack
  • runs Elasticsearch with X-Pack
  • starts up the Kibana server with X-Pack
  • runs the functional UI tests against those servers
  • tears down the servers
  • repeats the same process for the API and SAML API integration test configs.

To do all of this in a single command run:

node scripts/functional_tests

Developing functional UI tests

If you are developing functional tests then you probably don't want to rebuild Elasticsearch and wait for all that setup on every test run, so instead use this command to build and start just the Elasticsearch and Kibana servers:

node scripts/functional_tests_server

After the servers are started, open a new terminal and run this command to run just the tests (without tearing down Elasticsearch or Kibana):

node scripts/functional_test_runner

For both of the above commands, it's crucial that you pass in --config to specify the same config file to both commands. This makes sure that the right tests will run against the right servers. Typically a set of tests and server configuration go together.

Read more about how the scripts work here.

For a deeper dive, read more about the way functional tests and servers work here.

Running API integration tests

API integration tests are run with a unique setup usually without UI assets built for the Kibana server.

API integration tests are intended to test only programmatic API exposed by Kibana. There is no need to run browser and simulate user actions, which significantly reduces execution time. In addition, the configuration for API integration tests typically sets optimize.enabled=false for Kibana because UI assets are usually not needed for these tests.

To run only the API integration tests:

node scripts/functional_tests --config test/api_integration/config

Running SAML API integration tests

We also have SAML API integration tests which set up Elasticsearch and Kibana with SAML support. Run only API integration tests with SAML enabled like so:

node scripts/functional_tests --config test/saml_api_integration/config

Running Jest integration tests

Jest integration tests can be used to test behavior with Elasticsearch and the Kibana server.

node scripts/jest_integration

An example test exists at test_utils/jest/integration_tests/example_integration.test.ts

Running Reporting functional tests

See here for more information on running reporting tests.