228d69c708
## Summary
While working on a plugin that was just using the Kibana eslint config, I saw a stream of these messages:
> Warning: React version specified in eslint-plugin-react-settings must be a string; got “object”
Looking into our eslint config, I noticed we're using `semver.coerce` to get the version from the `package.json` file in Kibana. This looked right, except that method actually returns an object:
```js
const ver = semver.coerce('^16.8.0');
console.log(ver);
```
That produces:
```
SemVer {
options: { loose: false, includePrerelease: false },
loose: false,
raw: '16.8.0',
major: 16,
minor: 8,
patch: 0,
prerelease: [],
build: [],
version: '16.8.0' }
```
The [semver package](https://www.npmjs.com/package/semver) includes some examples where they wrap that value in `semver.valid`, which produces a string and fixes the warning.
```js
const ver = semver.valid(semver.coerce('^16.8.0'));
console.log(ver); // outputs 16.8.0
```
### So why don't we see this warning in Kibana?
I'm not sure, but I suspect it's because it's a console warning and our tooling prevents that output from showing up.
This change stops the warning output when you run eslint in my plugin though.
UPDATE: After some more digging, it looks like it's related to the version override in Kibana's eslintrc. Removing the override stops the linter from running, without the changes in this PR.
181 lines
6.2 KiB
JavaScript
181 lines
6.2 KiB
JavaScript
const semver = require('semver');
|
|
|
|
const PKG = require('../../package.json');
|
|
const RESTRICTED_GLOBALS = require('./restricted_globals');
|
|
|
|
module.exports = {
|
|
parser: 'babel-eslint',
|
|
|
|
plugins: [
|
|
'mocha',
|
|
'babel',
|
|
'react',
|
|
'import',
|
|
'no-unsanitized',
|
|
'prefer-object-spread',
|
|
'jsx-a11y',
|
|
],
|
|
|
|
settings: {
|
|
react: {
|
|
version: semver.valid(semver.coerce(PKG.dependencies.react)),
|
|
},
|
|
},
|
|
|
|
env: {
|
|
es6: true,
|
|
node: true,
|
|
mocha: true,
|
|
browser: true,
|
|
},
|
|
|
|
parserOptions: {
|
|
sourceType: 'module',
|
|
ecmaVersion: 6,
|
|
ecmaFeatures: { experimentalObjectRestSpread: true },
|
|
},
|
|
|
|
rules: {
|
|
'block-scoped-var': 'error',
|
|
camelcase: [ 'error', { properties: 'never' } ],
|
|
'comma-dangle': 'off',
|
|
'comma-spacing': ['error', { before: false, after: true }],
|
|
'comma-style': [ 'error', 'last' ],
|
|
'consistent-return': 'off',
|
|
curly: [ 'error', 'multi-line' ],
|
|
'dot-location': [ 'error', 'property' ],
|
|
'dot-notation': [ 'error', { allowKeywords: true } ],
|
|
eqeqeq: [ 'error', 'allow-null' ],
|
|
'guard-for-in': 'error',
|
|
indent: [ 'error', 2, { SwitchCase: 1 } ],
|
|
'key-spacing': ['error', { beforeColon: false, afterColon: true }],
|
|
'max-len': [ 'error', 140, 2, { ignoreComments: true, ignoreUrls: true } ],
|
|
'new-cap': [ 'error', { capIsNewExceptions: [ 'Private' ] } ],
|
|
'no-bitwise': 'off',
|
|
'no-caller': 'error',
|
|
'no-cond-assign': 'off',
|
|
'no-const-assign': 'error',
|
|
'no-debugger': 'error',
|
|
'no-empty': 'error',
|
|
'no-eval': 'error',
|
|
'no-extend-native': 'error',
|
|
'no-extra-parens': 'off',
|
|
'no-extra-semi': [ 'error' ],
|
|
'no-global-assign': 'error',
|
|
'no-irregular-whitespace': 'error',
|
|
'no-iterator': 'error',
|
|
'no-loop-func': 'error',
|
|
'no-multi-spaces': 'off',
|
|
'no-multi-str': 'off',
|
|
'no-nested-ternary': 'error',
|
|
'no-new': 'off',
|
|
'no-path-concat': 'off',
|
|
'no-proto': 'error',
|
|
'no-redeclare': 'error',
|
|
'no-restricted-globals': ['error', ...RESTRICTED_GLOBALS],
|
|
'no-return-assign': 'off',
|
|
'no-script-url': 'error',
|
|
'no-sequences': 'error',
|
|
'no-shadow': 'off',
|
|
'no-trailing-spaces': 'error',
|
|
'no-undef': 'error',
|
|
'no-underscore-dangle': 'off',
|
|
'no-unsanitized/method': 'error',
|
|
'no-unsanitized/property': 'error',
|
|
'no-unused-expressions': 'off',
|
|
'no-unused-vars': [ 'error' ],
|
|
'no-use-before-define': [ 'error', 'nofunc' ],
|
|
'no-var': 'error',
|
|
'no-with': 'error',
|
|
'one-var': [ 'error', 'never' ],
|
|
'prefer-const': 'error',
|
|
quotes: [ 'error', 'single', { allowTemplateLiterals: true } ],
|
|
'semi-spacing': [ 'error', { before: false, after: true } ],
|
|
semi: [ 'error', 'always' ],
|
|
'space-before-blocks': [ 'error', 'always' ],
|
|
'space-before-function-paren': [ 'error', { anonymous: 'always', named: 'never' } ],
|
|
'space-in-parens': [ 'error', 'never' ],
|
|
'space-infix-ops': [ 'error', { int32Hint: false } ],
|
|
'space-unary-ops': [ 'error' ],
|
|
strict: [ 'error', 'never' ],
|
|
'valid-typeof': 'error',
|
|
'wrap-iife': [ 'error', 'outside' ],
|
|
'eol-last': ['error', 'always'],
|
|
yoda: 'off',
|
|
|
|
'object-curly-spacing': 'off', // overridden with babel/object-curly-spacing
|
|
'babel/object-curly-spacing': [ 'error', 'always' ],
|
|
|
|
'jsx-quotes': ['error', 'prefer-double'],
|
|
'react/jsx-uses-react': 'error',
|
|
'react/react-in-jsx-scope': 'error',
|
|
'react/jsx-uses-vars': 'error',
|
|
'react/jsx-no-undef': 'error',
|
|
'react/jsx-pascal-case': 'error',
|
|
'react/jsx-closing-bracket-location': ['error', 'line-aligned'],
|
|
'react/jsx-closing-tag-location': 'error',
|
|
'react/jsx-curly-spacing': ['error', 'never', { allowMultiline: true }],
|
|
'react/jsx-indent-props': ['error', 2],
|
|
'react/jsx-max-props-per-line': ['error', { maximum: 1, when: 'multiline' }],
|
|
'react/jsx-no-duplicate-props': ['error', { ignoreCase: true }],
|
|
'react/no-danger': 'error',
|
|
'react/self-closing-comp': 'error',
|
|
'react/jsx-wrap-multilines': ['error', {
|
|
declaration: true,
|
|
assignment: true,
|
|
return: true,
|
|
arrow: true,
|
|
}],
|
|
'react/jsx-first-prop-new-line': ['error', 'multiline-multiprop'],
|
|
'jsx-a11y/accessible-emoji': 'error',
|
|
'jsx-a11y/alt-text': 'error',
|
|
'jsx-a11y/anchor-has-content': 'error',
|
|
'jsx-a11y/aria-activedescendant-has-tabindex': 'error',
|
|
'jsx-a11y/aria-props': 'error',
|
|
'jsx-a11y/aria-proptypes': 'error',
|
|
'jsx-a11y/aria-role': 'error',
|
|
'jsx-a11y/aria-unsupported-elements': 'error',
|
|
'jsx-a11y/heading-has-content': 'error',
|
|
'jsx-a11y/html-has-lang': 'error',
|
|
'jsx-a11y/iframe-has-title': 'error',
|
|
'jsx-a11y/interactive-supports-focus': 'error',
|
|
'jsx-a11y/media-has-caption': 'error',
|
|
'jsx-a11y/mouse-events-have-key-events': 'error',
|
|
'jsx-a11y/no-access-key': 'error',
|
|
'jsx-a11y/no-distracting-elements': 'error',
|
|
'jsx-a11y/no-interactive-element-to-noninteractive-role': 'error',
|
|
'jsx-a11y/no-noninteractive-element-interactions': 'error',
|
|
'jsx-a11y/no-noninteractive-element-to-interactive-role': 'error',
|
|
'jsx-a11y/no-redundant-roles': 'error',
|
|
'jsx-a11y/role-has-required-aria-props': 'error',
|
|
'jsx-a11y/role-supports-aria-props': 'error',
|
|
'jsx-a11y/scope': 'error',
|
|
'jsx-a11y/tabindex-no-positive': 'error',
|
|
'jsx-a11y/label-has-associated-control': 'error',
|
|
'react/jsx-equals-spacing': ['error', 'never'],
|
|
'react/jsx-indent': ['error', 2],
|
|
'react/no-will-update-set-state': 'error',
|
|
'react/no-is-mounted': 'error',
|
|
'react/no-multi-comp': ['error', { ignoreStateless: true }],
|
|
'react/no-unknown-property': 'error',
|
|
'react/prefer-es6-class': ['error', 'always'],
|
|
'react/prefer-stateless-function': ['error', { ignorePureComponents: true }],
|
|
'react/no-unescaped-entities': 'error',
|
|
|
|
'mocha/handle-done-callback': 'error',
|
|
'mocha/no-exclusive-tests': 'error',
|
|
|
|
'import/no-unresolved': [ 'error', { 'amd': true, 'commonjs': true } ],
|
|
'import/named': 'error',
|
|
'import/namespace': 'error',
|
|
'import/default': 'error',
|
|
'import/export': 'error',
|
|
'import/no-named-as-default': 'error',
|
|
'import/no-named-as-default-member': 'error',
|
|
'import/no-duplicates': 'error',
|
|
'import/no-dynamic-require': 'error',
|
|
|
|
'prefer-object-spread/prefer-object-spread': 'error',
|
|
}
|
|
}
|