kibana/x-pack/plugins/reporting
Tim Sullivan 2340f8a59b
[Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (#67027)
* [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel

commit e195964deaa3e7e8d94704d6514e01498c913a81
Author: Timothy Sullivan <tsullivan@elastic.co>
Date:   Mon Jul 13 10:17:36 2020 -0700

    Squashed commit of the following:

    commit 87c9c496a6cccaf7a60a44b496f7c0c0423cd2ea
    Merge: d531101ab3 ed749eb5ad
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Mon Jul 13 10:17:02 2020 -0700

        Merge branch 'data/allow-custom-formatting' into reporting/csv-date-format-consistency

    commit d531101ab3c2f12628287bd5ad4a02bbf8b5c990
    Merge: 400e2ffba4 17dc0439e2
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Mon Jul 13 10:15:38 2020 -0700

        Merge branch 'master' into reporting/csv-date-format-consistency

    commit ed749eb5ad
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Mon Jul 13 10:12:28 2020 -0700

        move shared code to common

    commit 4e5eebd93b
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Mon Jul 13 09:07:32 2020 -0700

        3td time api doc chagens

    commit 34df3318bf
    Merge: 54fa2fe97f 17dc0439e2
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Mon Jul 13 08:50:21 2020 -0700

        Merge branch 'master' into data/allow-custom-formatting

    commit 400e2ffba4546cf78c53ce96b45a59878f0df076
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Sun Jul 12 21:29:34 2020 -0700

        [Reporting] Data formatting fixes for CSV export in Discover, CSV download from Dashboard panel

    commit 54fa2fe97f
    Merge: 1b6e9e8719 e1253ed047
    Author: Elastic Machine <elasticmachine@users.noreply.github.com>
    Date:   Sun Jul 12 22:18:38 2020 -0600

        Merge branch 'master' into data/allow-custom-formatting

    commit 1b6e9e8719
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Fri Jul 10 15:03:08 2020 -0700

        weird api change needed but no real diff

    commit fc9ff7be61
    Merge: 736e9eecdd 66c531d903
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Fri Jul 10 14:51:51 2020 -0700

        Merge branch 'master' into data/allow-custom-formatting

    commit 736e9eecdd
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 9 17:43:10 2020 -0700

        fix path for tests

    commit 1bebcc83e6
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 9 17:25:09 2020 -0700

        re-use public code in server, add test

    commit 1e1d3c58ab
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 9 16:35:30 2020 -0700

        rerun api changes

    commit 231f793943
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 9 16:31:55 2020 -0700

        fix src/plugins/data/public/field_formats/constants.ts

    commit d42275cfeb
    Merge: 206aed6210 8e2277a667
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 9 16:01:40 2020 -0700

        Merge branch 'master' into data/allow-custom-formatting

    commit 206aed6210
    Merge: 5aa2d802ec 09da11047d
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 9 15:03:12 2020 -0700

        Merge branch 'master' into data/allow-custom-formatting

    commit 5aa2d802ec
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Wed Jul 8 12:12:31 2020 -0700

        api doc changes

    commit 76e2c307e7
    Merge: 1789afcdc9 595e9c2d8d
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Wed Jul 8 12:04:12 2020 -0700

        Merge branch 'master' into data/allow-custom-formatting

    commit 1789afcdc9
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Fri Jul 3 11:23:03 2020 -0700

        simplify changes

    commit 6428455873
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 2 16:05:57 2020 -0700

        add more to tests - need help though

    commit 6aacfbd25d
    Author: Timothy Sullivan <tsullivan@elastic.co>
    Date:   Thu Jul 2 12:04:28 2020 -0700

        [Data Plugin] Allow server-side date formatters to accept custom timezone

        When Advanced Settings shows the date format timezone to be "Browser,"
        this means nothing to field formatters in the server-side context. The
        field formatters need a way to accept custom format parameters. This
        allows a server-side module that creates a FieldFormatMap to set a
        timezone as a custom parameter. When custom formatting parameters exist,
        they get combined with the defaults.

* comments
2020-07-13 17:22:01 -07:00
..
common [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (#67027) 2020-07-13 17:22:01 -07:00
public [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (#67027) 2020-07-13 17:22:01 -07:00
server [Reporting] Formatting fixes for CSV export in Discover, CSV download from Dashboard panel (#67027) 2020-07-13 17:22:01 -07:00
constants.ts [New Platform Migration]: Management - Implement NP API (#66781) 2020-06-03 18:55:06 +03:00
kibana.json [kbn/optimizer] implement "requiredBundles" property of KP plugins (#70911) 2020-07-09 18:43:17 -07:00
README.md [Reporting] Move code out of Legacy (#67904) 2020-06-03 15:40:56 -07:00

Kibana Reporting

An awesome Kibana reporting plugin

Development

Assuming you've checked out x-plugins next to kibana...

  • Run yarn kbn bootstrap
  • Run yarn start to watch for and sync files on change
  • Open a new terminal to run Kibana - use yarn start to launch it in dev mode
    • Kibana will automatically restart as files are synced
    • If you need debugging output, run DEBUG=reporting yarn start instead

If you have installed this somewhere other than via x-plugins, and next to the kibana repo, you'll need to change the pathToKibana setting in gulpfile.js

Conventions

This plugins adopts some conventions in addition to or in place of conventions in Kibana (at the time of the plugin's creation):

Folder structure

export_types/ (contains public and server aspects of the different export types) 
  printable_pdf/ 
    public/
    server/
  csv/
    public/
    server/
public/ (shared public code for all export types)
server/ (shared server code for all export types)

This folder structure treats the different export_types like Plugins, with their public/server code being separate in a folder.