No description
Find a file
Frank Hassanabad 2f679e6df3
[Security Solutions] Critical bug to add network responses to error toasters (#97945)
## Summary

When we updated our codebase to use the newer bsearch/async search, we ended up using error messages which were not the same as we had before which would show the network errors in the full message when the "see full error button" was clicked.

This has been bad lately as users and quality assurance people have been posting screen shots that have very little information, blank error messages, and/or stack traces instead of network errors. This makes them think the code has issues when it is a configuration issue or a networking issue that is happening.

This PR does the following:
* Changes all the bsearch queries to use the use useAppToasts
* Modifies the useAppToasts to be able to transform bsearch with the kibana global notification
* Cleans up the useAppToasts some
* Deprecates the GlobalErrorToaster in favor of the useAppToasts
* Fixes and adds a few i18n missing strings found
* Removes most of the deprecated error dispatch toasters from detection_engine except for 1 place where it is not a hook.
 
Before screen shot of errors with no buttons and messages that were not pointing to network errors:
<img width="422" alt="Screen Shot 2021-04-21 at 4 24 45 PM" src="https://user-images.githubusercontent.com/1151048/115642119-9a942300-a2d7-11eb-955a-b51097a8d3ec.png">


After screen shot where you have a button and that button will show you the network error:
<img width="395" alt="Screen Shot 2021-04-21 at 3 26 12 PM" src="https://user-images.githubusercontent.com/1151048/115642216-c6170d80-a2d7-11eb-8c94-0a1c15186fab.png">

<img width="786" alt="Screen Shot 2021-04-21 at 3 26 21 PM" src="https://user-images.githubusercontent.com/1151048/115642222-ca432b00-a2d7-11eb-9ddd-4ed6c6270b94.png">

You can manually test this easily by making non ECS indexes to cause errors and then add them as a kibana index and use them in the data sourcer.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
2021-04-22 08:57:18 -06:00
.ci Revert "Revert "[ci] skip building ts refs when not necessary (#95739)" (#95746)" (#95750) 2021-04-19 09:45:09 -07:00
.github [Docs][Alerting] Changed overall alerting documentation structure (#95004) 2021-04-19 15:54:54 -07:00
api_docs Track API stats as part of ci (#95733) 2021-04-15 11:36:10 -04:00
config Add config properties for HTTP security headers (#97158) 2021-04-19 13:12:45 -04:00
dev_docs Add section on developer documentation into best practices docs (#95473) 2021-03-25 18:52:07 -04:00
docs chore(NA): chore(NA): moving @kbn/std into bazel (#97771) 2021-04-21 20:50:05 +01:00
examples [Search] enable fun-ctional tests (#97398) 2021-04-19 12:21:50 +03:00
licenses
packages [kbn-es] Increase ES heap (#97905) 2021-04-21 18:37:44 -04:00
plugins
rfcs RFC: URL Service (TTL: expired) (#95416) 2021-04-19 11:57:01 +02:00
scripts Remove the no longer used release-notes script (#97806) 2021-04-21 20:58:39 +02:00
src Block value 0 for terms.min_doc_count aggregation (#97966) 2021-04-22 15:14:17 +02:00
tasks/config [KQL] Use cache and other performance improvements (#93319) 2021-03-08 10:21:15 -07:00
test [flaky-test] Unskip SOM edit_saved_object tests (#97846) 2021-04-22 13:22:42 +01:00
typings [RAC] Rule registry plugin (#95903) 2021-04-09 10:35:44 +02:00
utilities
vars Revert "Revert "[ci] skip building ts refs when not necessary (#95739)" (#95746)" (#95750) 2021-04-19 09:45:09 -07:00
x-pack [Security Solutions] Critical bug to add network responses to error toasters (#97945) 2021-04-22 08:57:18 -06:00
.backportrc.json chore(NA): adds 7.13 branch and bumps 7.x on backportrc (#97804) 2021-04-21 19:08:28 +01:00
.bazelignore chore(NA): stop grouping bazel out symlink folders (#96066) 2021-04-01 14:16:14 -05:00
.bazeliskversion
.bazelrc chore(NA): manage npm dependencies within bazel (#92864) 2021-03-03 12:37:20 -05:00
.bazelrc.common chore(NA): @kbn/pm new commands to support development on Bazel packages (#96465) 2021-04-12 20:24:19 -04:00
.bazelversion
.browserslistrc
.editorconfig .editorconfig MDX files should follow the same rules as MD (#96942) 2021-04-13 11:40:42 -04:00
.eslintignore Remove the no longer used release-notes script (#97806) 2021-04-21 20:58:39 +02:00
.eslintrc.js Remove /src/legacy (#95510) 2021-04-06 09:25:36 +02:00
.fossa.yml
.gitattributes
.gitignore add bazel directory back to .gitignore so it doesn't end up committed 2021-04-01 13:17:56 -07:00
.i18nrc.json
.node-version Bump Node.js from version 14.16.0 to 14.16.1 (#96382) 2021-04-07 14:31:10 -04:00
.npmrc
.nvmrc Bump Node.js from version 14.16.0 to 14.16.1 (#96382) 2021-04-07 14:31:10 -04:00
.prettierignore
.prettierrc
.stylelintignore chore(NA): stop grouping bazel out symlink folders (#96066) 2021-04-01 14:16:14 -05:00
.stylelintrc Amsterdam helpers (#93701) 2021-03-10 10:27:16 -06:00
.telemetryrc.json [Usage collection] Collect non-default kibana configs (#97368) 2021-04-20 11:02:27 -04:00
.yarnrc chore(NA): manage npm dependencies within bazel (#92864) 2021-03-03 12:37:20 -05:00
api-documenter.json
BUILD.bazel chore(NA): moving @elastic/datemath into bazel (#94665) 2021-04-01 22:51:32 +01:00
CODE_OF_CONDUCT.md
CONTRIBUTING.md
FAQ.md
github_checks_reporter.json
Gruntfile.js
Jenkinsfile
jest.config.integration.js
jest.config.js Remove /src/legacy (#95510) 2021-04-06 09:25:36 +02:00
kibana.d.ts Remove /src/legacy (#95510) 2021-04-06 09:25:36 +02:00
LICENSE.txt
NOTICE.txt [kbn-ui-shared-deps] Remove outdated polyfills (#96339) 2021-04-08 08:49:13 -05:00
package.json remove jest-environment-jsdom-thirteen from package.json 2021-04-21 13:03:59 -07:00
preinstall_check.js
README.md
renovate.json5 bump version label in elastic/charts section of renovate config 2021-04-21 15:39:41 -07:00
SECURITY.md
STYLEGUIDE.md
tsconfig.base.json Revert "TS Incremental build exclude test files (#95610)" (#96223) 2021-04-05 11:59:26 -07:00
tsconfig.browser.json
tsconfig.json Extract License service from CCR and Watcher into license_api_guard plugin in x-pack (#95973) 2021-04-15 14:54:49 -07:00
tsconfig.refs.json [Maps] Enable all zoom levels for all users (#96093) 2021-04-05 12:04:20 -04:00
tsconfig.types.json
TYPESCRIPT.md
WORKSPACE.bazel chore(NA): @kbn/pm new commands to support development on Bazel packages (#96465) 2021-04-12 20:24:19 -04:00
yarn.lock chore(NA): chore(NA): moving @kbn/std into bazel (#97771) 2021-04-21 20:50:05 +01:00

Kibana

Kibana is your window into the Elastic Stack. Specifically, it's a browser-based analytics and search dashboard for Elasticsearch.

Getting Started

If you just want to try Kibana out, check out the Elastic Stack Getting Started Page to give it a whirl.

If you're interested in diving a bit deeper and getting a taste of Kibana's capabilities, head over to the Kibana Getting Started Page.

Using a Kibana Release

If you want to use a Kibana release in production, give it a test run, or just play around:

Building and Running Kibana, and/or Contributing Code

You might want to build Kibana locally to contribute some code, test out the latest features, or try out an open PR:

Documentation

Visit Elastic.co for the full Kibana documentation.

For information about building the documentation, see the README in elastic/docs.

Version Compatibility with Elasticsearch

Ideally, you should be running Elasticsearch and Kibana with matching version numbers. If your Elasticsearch has an older version number or a newer major number than Kibana, then Kibana will fail to run. If Elasticsearch has a newer minor or patch number than Kibana, then the Kibana Server will log a warning.

Note: The version numbers below are only examples, meant to illustrate the relationships between different types of version numbers.

Situation Example Kibana version Example ES version Outcome
Versions are the same. 5.1.2 5.1.2 💚 OK
ES patch number is newer. 5.1.2 5.1.5 ⚠️ Logged warning
ES minor number is newer. 5.1.2 5.5.0 ⚠️ Logged warning
ES major number is newer. 5.1.2 6.0.0 🚫 Fatal error
ES patch number is older. 5.1.2 5.1.0 ⚠️ Logged warning
ES minor number is older. 5.1.2 5.0.0 🚫 Fatal error
ES major number is older. 5.1.2 4.0.0 🚫 Fatal error

Questions? Problems? Suggestions?

  • If you've found a bug or want to request a feature, please create a GitHub Issue. Please check to make sure someone else hasn't already created an issue for the same topic.
  • Need help using Kibana? Ask away on our Kibana Discuss Forum and a fellow community member or Elastic engineer will be glad to help you out.