Go to file
Frank Hassanabad 5801de0800
[SIEM][Detection Engine] critical blocker, fixs broken rules versioning
## Summary

* Fixes broken rules versioning
* Fixes unit tests

Implementation is more safe in that it ensures that if you have a factory/immutable rule it will do an early bail out unless the immutable rule is asking for a version change from the file system.

If it's not an immutable it will still _not_ bump the version number if it is a change to the enabled/disabled only.

Testing:
---

* Test that if you enable either a factory or non-factory rule it does not bump the version number. 
* Test that if you go to an immutable rule on the file system and bump the version number on the file system and reinitialize it either through the UI or backend scripts then it will bump the version number.
* Test that if you update a non-factory rule then it does auto-increment the version number.

Things to look out for
---
Did I forget to whitelist anything in the code that would cause it to _not_ bump the version number for some reason?

## Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~- [ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~

~~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~

~~- [ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~

- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios

~~- [ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~

### For maintainers

~~- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~

- [x] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
2020-01-24 13:54:07 -07:00
.ci Fix number of executions per agent in flaky test job (#54311) 2020-01-09 09:48:22 -05:00
.github Update .github/CODEOWNERS (#55728) 2020-01-23 19:07:40 +01:00
bin Update node options Initialization on our scripts (#40302) 2019-08-15 16:09:22 +01:00
common/graphql
config Instrument Kibana with APM RUM agent (#44281) 2019-12-18 12:16:15 +01:00
data [folder structure] plugins/.data -> data 2016-07-05 14:06:16 -05:00
docs Revert "[csp] allow blob styles when running from source (#54991)" 2020-01-23 23:32:10 -07:00
examples bfetch (2) (#53711) 2020-01-16 05:33:52 -08:00
licenses Migrate x-pack-kibana source to kibana 2018-04-24 13:48:10 -07:00
packages Revert "[csp] allow blob styles when running from source (#54991)" 2020-01-23 23:32:10 -07:00
rfcs [RFC][skip-ci] Prevent plugins from blocking Kibana startup (#45796) 2019-12-18 14:52:18 +01:00
scripts 📕 Storybook for everyone (take 2) (#43529) 2020-01-15 12:30:59 -08:00
src fix URL for handlebar docs for markdown, and make sure they are https (#55866) 2020-01-24 13:58:31 -05:00
style_guides Updating accessibility guide and contributing readmes (#52038) 2019-12-04 19:11:16 -06:00
tasks Generate a static parser, move tests to vis_type_timelion (#55299) 2020-01-21 17:38:28 +03:00
test Revert "[csp] allow blob styles when running from source (#54991)" 2020-01-23 23:32:10 -07:00
typings [State Management] State syncing utilities (#53582) 2020-01-10 17:14:33 +03:00
utilities remove use of experimental fs.promises api (#53346) 2019-12-25 06:27:21 -07:00
vars Code coverage setup on CI (#49003) 2020-01-08 21:08:48 +01:00
webpackShims [kbn/ui-shared-deps] include polyfills, required by some deps (#54667) 2020-01-14 11:35:35 -07:00
x-pack [SIEM][Detection Engine] critical blocker, fixs broken rules versioning 2020-01-24 13:54:07 -07:00
.backportrc.json add 7.6 branch to backportrc (#54975) 2020-01-15 18:21:39 -05:00
.browserslistrc [autoprefixer] upgrade to 9.6.1, unify browserslist handling (#41038) 2019-07-15 09:33:33 -07:00
.editorconfig [editorconfig] disable insert_final_newline for package.json 2019-04-18 09:44:17 -07:00
.eslintignore Generate a static parser, move tests to vis_type_timelion (#55299) 2020-01-21 17:38:28 +03:00
.eslintrc.js Disallow importing Joi client side (#55018) 2020-01-24 15:38:44 +01:00
.gitattributes [canvas] Color fixes + Storybook 5 (#34075) 2019-04-02 11:21:51 -05:00
.gitignore [APM] Script optimization of APM-specific tsconfig (#49868) 2019-11-11 14:35:29 +01:00
.i18nrc.json Timelion api migration (#53005) 2020-01-23 18:19:33 +01:00
.node-version Update Node.js to version 10.18.0 (#52865) 2019-12-18 13:07:14 +01:00
.nvmrc Update Node.js to version 10.18.0 (#52865) 2019-12-18 13:07:14 +01:00
.prettierrc Increase prettier line width to 100 (#20535) 2018-07-09 22:50:37 +02:00
.sass-lint.yml Shim vis_type_vislib (#53536) 2020-01-15 15:48:19 -06:00
.yarnrc [kbn-pm] Use yarn workspaces for dependencies (#24095) 2018-11-12 12:38:11 -06:00
CONTRIBUTING.md Update CONTRIBUTING.md --ssl documentation to mention it covers Elasticsearch as well (#55876) 2020-01-24 15:35:04 -05:00
FAQ.md propose language changes (#10709) 2017-03-05 12:10:32 -05:00
github_checks_reporter.json
Gruntfile.js autofix all violations 2019-12-13 23:17:13 -07:00
Jenkinsfile Add PR comments to pipeline (#51504) 2019-12-03 18:06:30 -05:00
kibana.d.ts Update eslint related packages (#48513) 2019-10-21 16:32:31 -07:00
LICENSE.txt Migrate x-pack-kibana source to kibana 2018-04-24 13:48:10 -07:00
NOTICE.txt Bump year in NOTICE.txt 2019-12-31 21:46:25 -05:00
package.json [SIEM] Fix Detections page breadcrumbs (#55173) 2020-01-21 19:20:53 +01:00
preinstall_check.js
README.md chore: point issue links to choose (#49616) 2019-10-29 15:54:27 +01:00
renovate.json5 De-angularize vis tooltips (#54954) 2020-01-21 10:46:56 -06:00
STYLEGUIDE.md Upgrade to TypeScript 3.7.2 (#47188) 2019-11-15 10:33:29 +01:00
tsconfig.browser.json
tsconfig.json [Metric] convert mocha tests to jest (#54054) 2020-01-17 12:00:35 -06:00
tsconfig.types.json
TYPESCRIPT.md Update deprecated React.SFC and React.StatelessComponent types (#50852) 2019-11-21 20:53:54 +01:00
yarn.lock [SIEM] Fix Detections page breadcrumbs (#55173) 2020-01-21 19:20:53 +01:00

Kibana

Kibana is your window into the Elastic Stack. Specifically, it's a browser-based analytics and search dashboard for Elasticsearch.

Getting Started

If you just want to try Kibana out, check out the Elastic Stack Getting Started Page to give it a whirl.

If you're interested in diving a bit deeper and getting a taste of Kibana's capabilities, head over to the Kibana Getting Started Page.

Using a Kibana Release

If you want to use a Kibana release in production, give it a test run, or just play around:

Building and Running Kibana, and/or Contributing Code

You might want to build Kibana locally to contribute some code, test out the latest features, or try out an open PR:

Documentation

Visit Elastic.co for the full Kibana documentation.

For information about building the documentation, see the README in elastic/docs.

Version Compatibility with Elasticsearch

Ideally, you should be running Elasticsearch and Kibana with matching version numbers. If your Elasticsearch has an older version number or a newer major number than Kibana, then Kibana will fail to run. If Elasticsearch has a newer minor or patch number than Kibana, then the Kibana Server will log a warning.

Note: The version numbers below are only examples, meant to illustrate the relationships between different types of version numbers.

Situation Example Kibana version Example ES version Outcome
Versions are the same. 5.1.2 5.1.2 💚 OK
ES patch number is newer. 5.1.2 5.1.5 ⚠️ Logged warning
ES minor number is newer. 5.1.2 5.5.0 ⚠️ Logged warning
ES major number is newer. 5.1.2 6.0.0 🚫 Fatal error
ES patch number is older. 5.1.2 5.1.0 ⚠️ Logged warning
ES minor number is older. 5.1.2 5.0.0 🚫 Fatal error
ES major number is older. 5.1.2 4.0.0 🚫 Fatal error

Questions? Problems? Suggestions?

  • If you've found a bug or want to request a feature, please create a GitHub Issue. Please check to make sure someone else hasn't already created an issue for the same topic.
  • Need help using Kibana? Ask away on our Kibana Discuss Forum and a fellow community member or Elastic engineer will be glad to help you out.