b399fb03d1
## Summary By default the upload time limit for payloads is 10 seconds. This is really too short and we were getting internal QA bug reports that uploads are timing out on large value list importing. This PR adds the plumbing and unit tests to make the timeout configurable for routes. * Adds a single timeout option for routes and then normalizes that through Hapi for the socket, payload, and server timeouts. * Adds unit tests which test the various options * Adds integration tests which test the various options * Adds some NOTES about where there are odd behaviors/bugs within Hapi around validations and the timeouts * Adds a configurable 5 minute timeout to the large value lists route **Manual testing of the feature** You can manually test this by adding a configurable option to your chrome network throttle like so below where you throttle upload by some configurable amount. I chose to use 300 kbs/s upload <img width="556" alt="Screen Shot 2020-07-23 at 11 26 01 AM" src="https://user-images.githubusercontent.com/1151048/88318015-5ab3f700-ccd7-11ea-9d9b-7e3649ec65de.png"> And then run an import of large value lists using a large enough file that it will exceed 5 minutes:  After 5 minutes you should see this message within your server side messages if you have configured your kibana.dev.yml to allow for these messages: ```ts server respons [10:52:31.377] [access:lists-all] POST /api/lists/items/_import?type=keyword 408 318292ms - 9.0B ``` Note that it should show you that it is trying to return a `408` after `318292ms` the timeout period. Sometimes you will get the 408 in the browser and sometimes the browser actually will not respect the 408 and continue staying in a pending state forever. This seems to be browser side issue and not a client/user land issue. If you get the browser message it will be this error toaster  ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md) - [x] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
30 lines
813 B
TypeScript
30 lines
813 B
TypeScript
/*
|
|
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
|
|
* or more contributor license agreements. Licensed under the Elastic License;
|
|
* you may not use this file except in compliance with the Elastic License.
|
|
*/
|
|
|
|
import {
|
|
IMPORT_BUFFER_SIZE,
|
|
IMPORT_TIMEOUT,
|
|
LIST_INDEX,
|
|
LIST_ITEM_INDEX,
|
|
MAX_IMPORT_PAYLOAD_BYTES,
|
|
} from '../common/constants.mock';
|
|
|
|
import { ConfigType } from './config';
|
|
|
|
export const getConfigMock = (): Partial<ConfigType> => ({
|
|
listIndex: LIST_INDEX,
|
|
listItemIndex: LIST_ITEM_INDEX,
|
|
});
|
|
|
|
export const getConfigMockDecoded = (): ConfigType => ({
|
|
enabled: true,
|
|
importBufferSize: IMPORT_BUFFER_SIZE,
|
|
importTimeout: IMPORT_TIMEOUT,
|
|
listIndex: LIST_INDEX,
|
|
listItemIndex: LIST_ITEM_INDEX,
|
|
maxImportPayloadBytes: MAX_IMPORT_PAYLOAD_BYTES,
|
|
});
|