Go to file
Frank Hassanabad 8f85593910
[Security Solution] Fixes assert unreachable to be within the common section and the type to never (#75798)
## Summary

Assert unreachable was created through advice given by both the Typescript community and through the techniques that TyepScript is trying to achieve type safety with switch statements.

This fixes recent bugs by:
* Re-adding the never type
* Reduces the two different types by putting the helper within the common section so there's not duplication
* Fixes on type that looks like it was a regular string rather than a one of the enum types

The reasoning for exhaustive checks within switch statements and techniques can be seen in numerous areas such as here:
https://stackoverflow.com/questions/39419170/how-do-i-check-that-a-switch-block-is-exhaustive-in-typescript

You can do it either way with TypeScript as long as you ensure you have a explicit return type and you do early return statements you can actually avoid having to call into the assertUnreachable.

If introduced and used correctly it is there to help out like this error it is telling us that this string type is not exhaustive:
<img width="921" alt="Screen Shot 2020-08-24 at 10 39 42 AM" src="https://user-images.githubusercontent.com/1151048/91075618-9b1ad380-e5fb-11ea-9200-1c355faf5dca.png">

You can notice that for this pull request I actually remove the assertion like so if someone accidentally removes one of the switch statements:
<img width="1014" alt="Screen Shot 2020-08-24 at 10 42 08 AM" src="https://user-images.githubusercontent.com/1151048/91075662-a968ef80-e5fb-11ea-8d74-a92eedd63892.png">

And since the function has an explicit return type it is not needed. You will see that TypeScript improved its never types behind the scenes where it actually will tell you that it will never reach the `assertUnreachable` and want to remove it as an auto-refactor. That is ok as long as we have explicit return types and what I did with one line of code here.

<img width="536" alt="Screen Shot 2020-08-24 at 11 21 05 AM" src="https://user-images.githubusercontent.com/1151048/91075861-efbe4e80-e5fb-11ea-9991-dda111a04f1d.png">

Without this fix, and having the never type become an unknown it introduces less safety where any code that is utilizing the assertUnknown without explicit return types will be prone to having run time errors being thrown when something new is added to their switch enum types.
2020-08-25 09:22:13 -06:00
.ci Add asciidoc support for generated plugin list (#72292) 2020-08-24 11:31:27 -04:00
.github Update CODEOWNERS for design (again) (#75801) 2020-08-24 17:03:25 -04:00
common/graphql
config Node options from cfg file for production (#62468) 2020-07-13 16:30:03 +01:00
data
docs IndexPattern class - no longer use getConfig or uiSettingsValues (#75717) 2020-08-25 08:20:17 -05:00
examples cleaning up embeddable types (#75560) 2020-08-25 09:31:03 +02:00
licenses
packages Add asciidoc support for generated plugin list (#72292) 2020-08-24 11:31:27 -04:00
rfcs Fixed grammar (#74725) 2020-08-11 06:40:22 -04:00
scripts [kbn/plugin-generator] remove sao, modernize (#75465) 2020-08-20 18:50:36 -07:00
src [src/dev/build] stop including public source in distributable (#75841) 2020-08-25 08:07:10 -07:00
tasks [CI] Add pipeline task queue framework and merge workers into one (#71268) 2020-08-04 13:13:51 -04:00
test Adding sorting test to scripted fields in discover (#75520) 2020-08-24 15:28:36 -07:00
typings Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) 2020-08-05 17:32:19 +02:00
utilities apply prettier styles 2020-05-22 09:08:58 +02:00
vars Fixed alerting_api_integration/security_and_spaces tests failing if actions proxy set on for parallel process running using commands 'scripts/functional_tests_server' and 'scripts/functional_test_runner' (#75232) 2020-08-24 16:43:44 -07:00
x-pack [Security Solution] Fixes assert unreachable to be within the common section and the type to never (#75798) 2020-08-25 09:22:13 -06:00
.backportrc.json chore(NA): setup backport tool for 7.9 and the new 7.x (#71861) 2020-07-15 09:32:13 -07:00
.browserslistrc Aligns BrowserList config with Support Matrix (#71876) 2020-07-16 10:56:07 -07:00
.editorconfig [editorconfig] disable insert_final_newline for package.json 2019-04-18 09:44:17 -07:00
.eslintignore [kbn/plugin-generator] remove sao, modernize (#75465) 2020-08-20 18:50:36 -07:00
.eslintrc.js [kbn/plugin-generator] remove sao, modernize (#75465) 2020-08-20 18:50:36 -07:00
.fossa.yml Adds FOSSA CLI configuration file (#70137) 2020-07-02 08:37:37 -07:00
.gitattributes
.gitignore [CI] Add pipeline task queue framework and merge workers into one (#71268) 2020-08-04 13:13:51 -04:00
.i18nrc.json Migrate timelion to the NP. (#69160) 2020-07-14 18:41:12 +03:00
.node-version Update Node.js to version 10.22.0 (#75254) 2020-08-19 12:14:54 +02:00
.nvmrc Update Node.js to version 10.22.0 (#75254) 2020-08-19 12:14:54 +02:00
.prettierrc
.sass-lint.yml Empty index patterns page re-design (#68819) 2020-08-12 15:58:16 -05:00
.telemetryrc.json [Usage Collection Schemas] Remove Legacy entries (#75652) 2020-08-21 07:23:39 -07:00
.yarnrc
api-documenter.json Normalize EOL symbol in platform docs (#56021) 2020-01-27 18:42:45 +01:00
CONTRIBUTING.md Improvements to our developer guide (#67764) 2020-07-13 10:47:01 -04:00
FAQ.md
github_checks_reporter.json implementing github checks - second attempt (#35757) 2019-05-01 16:02:33 -05:00
Gruntfile.js apply prettier styles 2020-05-22 09:08:58 +02:00
Jenkinsfile [CI] Add pipeline task queue framework and merge workers into one (#71268) 2020-08-04 13:13:51 -04:00
kibana.d.ts Update @typescript-eslint to ensure compatibility with TypeScript v3.9 (#74091) 2020-08-05 17:32:19 +02:00
LICENSE.txt
NOTICE.txt chore(NA): teardown dynamic dll plugin (#72096) 2020-07-17 11:04:14 +01:00
package.json Upgrade EUI to v27.4.1 (#75240) 2020-08-21 10:48:04 -06:00
preinstall_check.js
README.md Remove legacy optimizer (#73154) 2020-08-13 09:08:44 -07:00
renovate.json5 disable renovate masterIssue 2020-07-22 14:43:12 -07:00
STYLEGUIDE.md Remove legacy optimizer (#73154) 2020-08-13 09:08:44 -07:00
tsconfig.browser.json
tsconfig.json Bump jest related packages (#58095) 2020-06-20 21:05:09 +02:00
tsconfig.types.json [data.search.aggs]: Add AggConfig.toSerializedFieldFormat (#69114) 2020-06-24 07:52:21 -06:00
TYPESCRIPT.md Fixed grammar (#74725) 2020-08-11 06:40:22 -04:00
yarn.lock Fixed alerting_api_integration/security_and_spaces tests failing if actions proxy set on for parallel process running using commands 'scripts/functional_tests_server' and 'scripts/functional_test_runner' (#75232) 2020-08-24 16:43:44 -07:00

Kibana

Kibana is your window into the Elastic Stack. Specifically, it's a browser-based analytics and search dashboard for Elasticsearch.

Getting Started

If you just want to try Kibana out, check out the Elastic Stack Getting Started Page to give it a whirl.

If you're interested in diving a bit deeper and getting a taste of Kibana's capabilities, head over to the Kibana Getting Started Page.

Using a Kibana Release

If you want to use a Kibana release in production, give it a test run, or just play around:

Building and Running Kibana, and/or Contributing Code

You might want to build Kibana locally to contribute some code, test out the latest features, or try out an open PR:

Documentation

Visit Elastic.co for the full Kibana documentation.

For information about building the documentation, see the README in elastic/docs.

Version Compatibility with Elasticsearch

Ideally, you should be running Elasticsearch and Kibana with matching version numbers. If your Elasticsearch has an older version number or a newer major number than Kibana, then Kibana will fail to run. If Elasticsearch has a newer minor or patch number than Kibana, then the Kibana Server will log a warning.

Note: The version numbers below are only examples, meant to illustrate the relationships between different types of version numbers.

Situation Example Kibana version Example ES version Outcome
Versions are the same. 5.1.2 5.1.2 💚 OK
ES patch number is newer. 5.1.2 5.1.5 ⚠️ Logged warning
ES minor number is newer. 5.1.2 5.5.0 ⚠️ Logged warning
ES major number is newer. 5.1.2 6.0.0 🚫 Fatal error
ES patch number is older. 5.1.2 5.1.0 ⚠️ Logged warning
ES minor number is older. 5.1.2 5.0.0 🚫 Fatal error
ES major number is older. 5.1.2 4.0.0 🚫 Fatal error

Questions? Problems? Suggestions?

  • If you've found a bug or want to request a feature, please create a GitHub Issue. Please check to make sure someone else hasn't already created an issue for the same topic.
  • Need help using Kibana? Ask away on our Kibana Discuss Forum and a fellow community member or Elastic engineer will be glad to help you out.