kibana/x-pack/plugins/enterprise_search
Scotty Bollinger 9477df10d0
[Enterprise Search] Migrate shared role mapping components (#91723)
* Initial copy/paste of components

* Add types

* Add constants

* Replace EUI toSentenceCase with lodash startCase

EUI has not updated their types to include this util and no one else in Kibana uses it so falling back to the lodash equivalent

* Update paths

* Fix test

* Fix TypeScript issues

* Remove ability check for non-federated users

* Use Kibana React Router helpers

Also cleaned up shared type import

* Update comments

* Fix failing test

Also added new lines to match other places in Kibana

* Add i18n

* Add tests for smaller components

- AddRoleMappingButton
- DeleteMappingCallout
- RoleSelector

* Fix fallbacks

When trying to achieve coverage it was impossible to create a state that these fallbacks were ever triggered. It’s my assumption that these were added in ent-search to get around TypeScript  errors. Added typings instead.

* Add tests for AttributeSelector

* Add mocks and testSubj attrs

* Add tests for RoleMappingsTable

* Fix types

When actually implementing these I found that these types were wrong

* Refactor for better typing

* Remove return type

This was causing a TypeScript error and is not needed

* Rename interface

* Rename more interfaces

* PR feedback

* Add test for radio checked state

* Add false radio assertion to

* Update className

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-02-22 10:50:07 -05:00
..
common Elastic License 2.0 (#90099) 2021-02-03 18:12:39 -08:00
public [Enterprise Search] Migrate shared role mapping components (#91723) 2021-02-22 10:50:07 -05:00
server [HTTP] Apply the same behaviour to all 500 errors (except from custom responses) (#85541) 2021-02-18 17:31:18 +00:00
jest.config.js Elastic License 2.0 (#90099) 2021-02-03 18:12:39 -08:00
jest.sh
kibana.json
README.md
tsconfig.json

Enterprise Search

Overview

This plugin's goal is to provide a Kibana user interface to the Enterprise Search solution's products (App Search and Workplace Search). In it's current MVP state, the plugin provides the following with the goal of gathering user feedback and raising product awareness:

  • App Search: A basic engines overview with links into the product.
  • Workplace Search: A simple app overview with basic statistics, links to the sources, users (if standard auth), and product settings.

Development

  1. When developing locally, Enterprise Search should be running locally alongside Kibana on localhost:3002.
  2. Update config/kibana.dev.yml with enterpriseSearch.host: 'http://localhost:3002'
  3. For faster QA/development, run Enterprise Search on elasticsearch-native auth and log in as the elastic superuser on Kibana.

Kea

Enterprise Search uses Kea.js to manage our React/Redux state for us. Kea state is handled in our *Logic files and exposes values and actions for our components to get and set state with.

Advanced Kea usage

For the most part, we stick to the functionality described in Kea's core concepts. However, in some files, we also take advantage of props and events, as well as manually mounting some shared logic files on plugin init outside of React.

Debugging Kea

To debug Kea state in-browser, Kea recommends Redux Devtools. To facilitate debugging, we use the path key with snake_cased paths. The path key should always end with the logic filename (e.g. ['enterprise_search', 'some_logic']) to make it easy for devs to quickly find/jump to files via IDE tooling.

Testing

Unit tests

Documentation: https://www.elastic.co/guide/en/kibana/current/development-tests.html#_unit_testing

Jest tests can be run directly from the x-pack/plugins/enterprise_search folder. This also works for any subfolders or subcomponents.

yarn test:jest
yarn test:jest --watch

Unfortunately coverage collection does not work as automatically, and requires using our handy jest.sh script if you want to run tests on a specific folder and only get coverage numbers for that folder:

# Running the jest.sh script from the `x-pack/plugins/enterprise_search` folder (vs. kibana root)
# will save you time and allow you to Tab to complete folder dir names
sh jest.sh {YOUR_COMPONENT_DIR}
sh jest.sh public/applications/shared/kibana
sh jest.sh server/routes/app_search

E2E tests

See our functional test runner README.