kibana/x-pack/plugins/lens/public/xy_visualization/visualization.tsx
Marco Liberati 8e6d4ee2f8
[Lens] Fix wrong suggestions from Datatable to other visualizations (#93920)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-03-09 15:31:17 +01:00

520 lines
16 KiB
TypeScript

/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/
import React from 'react';
import _ from 'lodash';
import { render } from 'react-dom';
import { Position } from '@elastic/charts';
import { I18nProvider } from '@kbn/i18n/react';
import { i18n } from '@kbn/i18n';
import { PaletteRegistry } from 'src/plugins/charts/public';
import { DataPublicPluginStart } from 'src/plugins/data/public';
import { getSuggestions } from './xy_suggestions';
import { LayerContextMenu, XyToolbar, DimensionEditor } from './xy_config_panel';
import { Visualization, OperationMetadata, VisualizationType, AccessorConfig } from '../types';
import { State, SeriesType, visualizationTypes, XYLayerConfig } from './types';
import { isHorizontalChart } from './state_helpers';
import { toExpression, toPreviewExpression, getSortedAccessors } from './to_expression';
import { LensIconChartBarStacked } from '../assets/chart_bar_stacked';
import { LensIconChartMixedXy } from '../assets/chart_mixed_xy';
import { LensIconChartBarHorizontal } from '../assets/chart_bar_horizontal';
import { getAccessorColorConfig, getColorAssignments } from './color_assignment';
import { getColumnToLabelMap } from './state_helpers';
const defaultIcon = LensIconChartBarStacked;
const defaultSeriesType = 'bar_stacked';
const isNumericMetric = (op: OperationMetadata) => !op.isBucketed && op.dataType === 'number';
const isBucketed = (op: OperationMetadata) => op.isBucketed;
function getVisualizationType(state: State): VisualizationType | 'mixed' {
if (!state.layers.length) {
return (
visualizationTypes.find((t) => t.id === state.preferredSeriesType) ?? visualizationTypes[0]
);
}
const visualizationType = visualizationTypes.find((t) => t.id === state.layers[0].seriesType);
const seriesTypes = _.uniq(state.layers.map((l) => l.seriesType));
return visualizationType && seriesTypes.length === 1 ? visualizationType : 'mixed';
}
function getDescription(state?: State) {
if (!state) {
return {
icon: defaultIcon,
label: i18n.translate('xpack.lens.xyVisualization.xyLabel', {
defaultMessage: 'XY',
}),
};
}
const visualizationType = getVisualizationType(state);
if (visualizationType === 'mixed' && isHorizontalChart(state.layers)) {
return {
icon: LensIconChartBarHorizontal,
label: i18n.translate('xpack.lens.xyVisualization.mixedBarHorizontalLabel', {
defaultMessage: 'Mixed bar horizontal',
}),
};
}
if (visualizationType === 'mixed') {
return {
icon: LensIconChartMixedXy,
label: i18n.translate('xpack.lens.xyVisualization.mixedLabel', {
defaultMessage: 'Mixed XY',
}),
};
}
return {
icon: visualizationType.icon,
label: visualizationType.fullLabel || visualizationType.label,
};
}
export const getXyVisualization = ({
paletteService,
data,
}: {
paletteService: PaletteRegistry;
data: DataPublicPluginStart;
}): Visualization<State> => ({
id: 'lnsXY',
visualizationTypes,
getVisualizationTypeId(state) {
const type = getVisualizationType(state);
return type === 'mixed' ? type : type.id;
},
getLayerIds(state) {
return state.layers.map((l) => l.layerId);
},
removeLayer(state, layerId) {
return {
...state,
layers: state.layers.filter((l) => l.layerId !== layerId),
};
},
appendLayer(state, layerId) {
const usedSeriesTypes = _.uniq(state.layers.map((layer) => layer.seriesType));
return {
...state,
layers: [
...state.layers,
newLayerState(
usedSeriesTypes.length === 1 ? usedSeriesTypes[0] : state.preferredSeriesType,
layerId
),
],
};
},
clearLayer(state, layerId) {
return {
...state,
layers: state.layers.map((l) =>
l.layerId !== layerId ? l : newLayerState(state.preferredSeriesType, layerId)
),
};
},
getDescription(state) {
const { icon, label } = getDescription(state);
return {
icon: icon || defaultIcon,
label,
};
},
switchVisualizationType(seriesType: string, state: State) {
return {
...state,
preferredSeriesType: seriesType as SeriesType,
layers: state.layers.map((layer) => ({ ...layer, seriesType: seriesType as SeriesType })),
};
},
getSuggestions,
initialize(frame, state) {
return (
state || {
title: 'Empty XY chart',
legend: { isVisible: true, position: Position.Right },
valueLabels: 'hide',
preferredSeriesType: defaultSeriesType,
layers: [
{
layerId: frame.addNewLayer(),
accessors: [],
position: Position.Top,
seriesType: defaultSeriesType,
showGridlines: false,
},
],
}
);
},
getConfiguration({ state, frame, layerId }) {
const layer = state.layers.find((l) => l.layerId === layerId);
if (!layer) {
return { groups: [] };
}
const datasource = frame.datasourceLayers[layer.layerId];
const sortedAccessors: string[] = getSortedAccessors(datasource, layer);
let mappedAccessors: AccessorConfig[] = sortedAccessors.map((accessor) => ({
columnId: accessor,
}));
if (frame.activeData) {
const colorAssignments = getColorAssignments(
state.layers,
{ tables: frame.activeData },
data.fieldFormats.deserialize
);
mappedAccessors = getAccessorColorConfig(
colorAssignments,
frame,
{
...layer,
accessors: sortedAccessors.filter((sorted) => layer.accessors.includes(sorted)),
},
paletteService
);
}
const isHorizontal = isHorizontalChart(state.layers);
return {
groups: [
{
groupId: 'x',
groupLabel: getAxisName('x', { isHorizontal }),
accessors: layer.xAccessor ? [{ columnId: layer.xAccessor }] : [],
filterOperations: isBucketed,
supportsMoreColumns: !layer.xAccessor,
dataTestSubj: 'lnsXY_xDimensionPanel',
},
{
groupId: 'y',
groupLabel: getAxisName('y', { isHorizontal }),
accessors: mappedAccessors,
filterOperations: isNumericMetric,
supportsMoreColumns: true,
required: true,
dataTestSubj: 'lnsXY_yDimensionPanel',
enableDimensionEditor: true,
},
{
groupId: 'breakdown',
groupLabel: i18n.translate('xpack.lens.xyChart.splitSeries', {
defaultMessage: 'Break down by',
}),
accessors: layer.splitAccessor
? [
{
columnId: layer.splitAccessor,
triggerIcon: 'colorBy',
palette: paletteService
.get(layer.palette?.name || 'default')
.getColors(10, layer.palette?.params),
},
]
: [],
filterOperations: isBucketed,
supportsMoreColumns: !layer.splitAccessor,
dataTestSubj: 'lnsXY_splitDimensionPanel',
required: layer.seriesType.includes('percentage'),
enableDimensionEditor: true,
},
],
};
},
getMainPalette: (state) => {
if (!state || state.layers.length === 0) return;
return state.layers[0].palette;
},
setDimension({ prevState, layerId, columnId, groupId }) {
const newLayer = prevState.layers.find((l) => l.layerId === layerId);
if (!newLayer) {
return prevState;
}
if (groupId === 'x') {
newLayer.xAccessor = columnId;
}
if (groupId === 'y') {
newLayer.accessors = [...newLayer.accessors.filter((a) => a !== columnId), columnId];
}
if (groupId === 'breakdown') {
newLayer.splitAccessor = columnId;
}
return {
...prevState,
layers: prevState.layers.map((l) => (l.layerId === layerId ? newLayer : l)),
};
},
removeDimension({ prevState, layerId, columnId }) {
const newLayer = prevState.layers.find((l) => l.layerId === layerId);
if (!newLayer) {
return prevState;
}
if (newLayer.xAccessor === columnId) {
delete newLayer.xAccessor;
} else if (newLayer.splitAccessor === columnId) {
delete newLayer.splitAccessor;
// as the palette is associated with the break down by dimension, remove it together with the dimension
delete newLayer.palette;
} else if (newLayer.accessors.includes(columnId)) {
newLayer.accessors = newLayer.accessors.filter((a) => a !== columnId);
}
if (newLayer.yConfig) {
newLayer.yConfig = newLayer.yConfig.filter(({ forAccessor }) => forAccessor !== columnId);
}
return {
...prevState,
layers: prevState.layers.map((l) => (l.layerId === layerId ? newLayer : l)),
};
},
getLayerContextMenuIcon({ state, layerId }) {
const layer = state.layers.find((l) => l.layerId === layerId);
const visualizationType = visualizationTypes.find((t) => t.id === layer?.seriesType);
return {
icon: visualizationType?.icon || 'gear',
label: visualizationType?.label || '',
};
},
renderLayerContextMenu(domElement, props) {
render(
<I18nProvider>
<LayerContextMenu {...props} />
</I18nProvider>,
domElement
);
},
renderToolbar(domElement, props) {
render(
<I18nProvider>
<XyToolbar {...props} />
</I18nProvider>,
domElement
);
},
renderDimensionEditor(domElement, props) {
render(
<I18nProvider>
<DimensionEditor
{...props}
formatFactory={data.fieldFormats.deserialize}
paletteService={paletteService}
/>
</I18nProvider>,
domElement
);
},
toExpression: (state, layers, attributes) =>
toExpression(state, layers, paletteService, attributes),
toPreviewExpression: (state, layers) => toPreviewExpression(state, layers, paletteService),
getErrorMessages(state, datasourceLayers) {
// Data error handling below here
const hasNoAccessors = ({ accessors }: XYLayerConfig) =>
accessors == null || accessors.length === 0;
const hasNoSplitAccessor = ({ splitAccessor, seriesType }: XYLayerConfig) =>
seriesType.includes('percentage') && splitAccessor == null;
const errors: Array<{
shortMessage: string;
longMessage: string;
}> = [];
// check if the layers in the state are compatible with this type of chart
if (state && state.layers.length > 1) {
// Order is important here: Y Axis is fundamental to exist to make it valid
const checks: Array<[string, (layer: XYLayerConfig) => boolean]> = [
['Y', hasNoAccessors],
['Break down', hasNoSplitAccessor],
];
// filter out those layers with no accessors at all
const filteredLayers = state.layers.filter(
({ accessors, xAccessor, splitAccessor }: XYLayerConfig) =>
accessors.length > 0 || xAccessor != null || splitAccessor != null
);
for (const [dimension, criteria] of checks) {
const result = validateLayersForDimension(dimension, filteredLayers, criteria);
if (!result.valid) {
errors.push(result.payload);
}
}
}
if (datasourceLayers && state) {
for (const layer of state.layers) {
const datasourceAPI = datasourceLayers[layer.layerId];
if (datasourceAPI) {
for (const accessor of layer.accessors) {
const operation = datasourceAPI.getOperationForColumnId(accessor);
if (operation && operation.dataType !== 'number') {
errors.push({
shortMessage: i18n.translate('xpack.lens.xyVisualization.dataTypeFailureYShort', {
defaultMessage: `Wrong data type for {axis}.`,
values: {
axis: getAxisName('y', { isHorizontal: isHorizontalChart(state.layers) }),
},
}),
longMessage: i18n.translate('xpack.lens.xyVisualization.dataTypeFailureYLong', {
defaultMessage: `The dimension {label} provided for the {axis} has the wrong data type. Expected number but have {dataType}`,
values: {
label: operation.label,
dataType: operation.dataType,
axis: getAxisName('y', { isHorizontal: isHorizontalChart(state.layers) }),
},
}),
});
}
}
}
}
}
return errors.length ? errors : undefined;
},
getWarningMessages(state, frame) {
if (state?.layers.length === 0 || !frame.activeData) {
return;
}
const layers = state.layers;
const filteredLayers = layers.filter(({ accessors }: XYLayerConfig) => accessors.length > 0);
const accessorsWithArrayValues = [];
for (const layer of filteredLayers) {
const { layerId, accessors } = layer;
const rows = frame.activeData[layerId] && frame.activeData[layerId].rows;
if (!rows) {
break;
}
const columnToLabel = getColumnToLabelMap(layer, frame.datasourceLayers[layerId]);
for (const accessor of accessors) {
const hasArrayValues = rows.some((row) => Array.isArray(row[accessor]));
if (hasArrayValues) {
accessorsWithArrayValues.push(columnToLabel[accessor]);
}
}
}
return accessorsWithArrayValues.map((label) => (
<>
<strong>{label}</strong> contains array values. Your visualization may not render as
expected.
</>
));
},
});
function validateLayersForDimension(
dimension: string,
layers: XYLayerConfig[],
missingCriteria: (layer: XYLayerConfig) => boolean
):
| { valid: true }
| {
valid: false;
payload: { shortMessage: string; longMessage: string };
} {
// Multiple layers must be consistent:
// * either a dimension is missing in ALL of them
// * or should not miss on any
if (layers.every(missingCriteria) || !layers.some(missingCriteria)) {
return { valid: true };
}
// otherwise it's an error and it has to be reported
const layerMissingAccessors = layers.reduce((missing: number[], layer, i) => {
if (missingCriteria(layer)) {
missing.push(i);
}
return missing;
}, []);
return {
valid: false,
payload: getMessageIdsForDimension(dimension, layerMissingAccessors, isHorizontalChart(layers)),
};
}
function getAxisName(axis: 'x' | 'y', { isHorizontal }: { isHorizontal: boolean }) {
const vertical = i18n.translate('xpack.lens.xyChart.verticalAxisLabel', {
defaultMessage: 'Vertical axis',
});
const horizontal = i18n.translate('xpack.lens.xyChart.horizontalAxisLabel', {
defaultMessage: 'Horizontal axis',
});
if (axis === 'x') {
return isHorizontal ? vertical : horizontal;
}
return isHorizontal ? horizontal : vertical;
}
// i18n ids cannot be dynamically generated, hence the function below
function getMessageIdsForDimension(dimension: string, layers: number[], isHorizontal: boolean) {
const layersList = layers.map((i: number) => i + 1).join(', ');
switch (dimension) {
case 'Break down':
return {
shortMessage: i18n.translate('xpack.lens.xyVisualization.dataFailureSplitShort', {
defaultMessage: `Missing {axis}.`,
values: { axis: 'Break down by axis' },
}),
longMessage: i18n.translate('xpack.lens.xyVisualization.dataFailureSplitLong', {
defaultMessage: `{layers, plural, one {Layer} other {Layers}} {layersList} {layers, plural, one {requires} other {require}} a field for the {axis}.`,
values: { layers: layers.length, layersList, axis: 'Break down by axis' },
}),
};
case 'Y':
return {
shortMessage: i18n.translate('xpack.lens.xyVisualization.dataFailureYShort', {
defaultMessage: `Missing {axis}.`,
values: { axis: getAxisName('y', { isHorizontal }) },
}),
longMessage: i18n.translate('xpack.lens.xyVisualization.dataFailureYLong', {
defaultMessage: `{layers, plural, one {Layer} other {Layers}} {layersList} {layers, plural, one {requires} other {require}} a field for the {axis}.`,
values: { layers: layers.length, layersList, axis: getAxisName('y', { isHorizontal }) },
}),
};
}
return { shortMessage: '', longMessage: '' };
}
function newLayerState(seriesType: SeriesType, layerId: string): XYLayerConfig {
return {
layerId,
seriesType,
accessors: [],
};
}