* Move ui/flyout to overlay core service * Remove onClose in parameter (use FlyoutSession instead) * Fix tests * Remove old inspector tests * Proper TODO message * Convert flyout service to class * Use correct i18n * Resolving weird merge conflicts * Fix panel plugin test * Change new platform access * Add more tests * Remove commented tests * Revert test fix (core is actually not fixed yet) * Fix tests * Expose onClose as Observable * Use jest.doMock * Fix typos * Core start() -> setup() * Remove @extends EventEmitter docs * Refactor and test flyoutservice * Fix comments: promise -> observable * Fix tests * Explicitly define OverlaySetup * Fix OverlaySetup type signature * Update Core API review file and docs * Remove redudant if case * Change FlyoutRef.onClose into a promise * Remove redundante cleanup * Use promise.finally * Remove targetDomElement from openFlyout() There's no need to support multiple targetDomElements per FlyoutService and the current implementation handled this use case incorrectly. Instead of adding complexity to try to support it, remove this from the function signature. * Fix + test to ensure child components are unmounted when a new flyover is displayed * Wrap flyover in i18n Context component * TSlint -> ESlint + test improvements |
||
---|---|---|
.. | ||
core | ||
plugin | ||
security | ||
visualize | ||
add-data-guide.asciidoc | ||
core-development.asciidoc | ||
plugin-development.asciidoc | ||
pr-review.asciidoc |