kibana/x-pack/plugins/enterprise_search
Scotty Bollinger eaab783410
[Workplace Search] Add unit tests for top-level Sources components (#88918)
* Add full source mocks

The overview page recieves heavily annotated source data for display. This extends the existing mocks

* Refactor for easier readability

Uses optional chaining. Hide whitespace changes for easier reviewing of this commit

* Remove conditionals

The false case will never be true here because the line above only renders when there is a summary. Around line 109:

```
{!!summary &&
```

* Refactor GroupsSummary to variable

It was challenging to test the null in the original implementation so I refactored to cloer match the way we do this in other places by making the conditional rendering inline, rather than `null` in a function.

* Remove unused const

* Add overview test-subj attrs

* Add overview unit tests

* Add tests for SourceAdded

* Move meta to shared mock

* Add tests for SourceContent

* Add tests for SourceInfoCard

* Move redirect logic from component to logic file

We had this weird callback passing to trigger a redirect and we are already redirecting in the logic file for other things so I simplified this to have the logic file do the redirecting and not have to pass the callback around, which is hard to test and unnecessary complexity.

Also using the KibanaLogic navigateToUrl instead of history.push

# Conflicts:
#	x-pack/plugins/enterprise_search/public/applications/workplace_search/views/content_sources/source_logic.ts

* Add tests for SourceSettings

* Add tests for SourceSubNav

* I am the typo king

🤴🏼Prove me wrong.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2021-01-21 12:41:51 -06:00
..
common
public [Workplace Search] Add unit tests for top-level Sources components (#88918) 2021-01-21 12:41:51 -06:00
server [Workplace Search] Update routes to use new encodePathParams helper (#88899) 2021-01-21 09:01:42 -08:00
jest.config.js [Enterprise Search] Jest config & handy Jest script (#84839) 2020-12-17 08:19:33 -08:00
jest.sh [Enterprise Search] Jest config & handy Jest script (#84839) 2020-12-17 08:19:33 -08:00
kibana.json [App Search] Add AnalyticsChart component to EnginesOverview (#87752) 2021-01-12 11:43:01 -08:00
README.md [Enterprise Search] Jest config & handy Jest script (#84839) 2020-12-17 08:19:33 -08:00

Enterprise Search

Overview

This plugin's goal is to provide a Kibana user interface to the Enterprise Search solution's products (App Search and Workplace Search). In it's current MVP state, the plugin provides the following with the goal of gathering user feedback and raising product awareness:

  • App Search: A basic engines overview with links into the product.
  • Workplace Search: A simple app overview with basic statistics, links to the sources, users (if standard auth), and product settings.

Development

  1. When developing locally, Enterprise Search should be running locally alongside Kibana on localhost:3002.
  2. Update config/kibana.dev.yml with enterpriseSearch.host: 'http://localhost:3002'
  3. For faster QA/development, run Enterprise Search on elasticsearch-native auth and log in as the elastic superuser on Kibana.

Kea

Enterprise Search uses Kea.js to manage our React/Redux state for us. Kea state is handled in our *Logic files and exposes values and actions for our components to get and set state with.

Advanced Kea usage

For the most part, we stick to the functionality described in Kea's core concepts. However, in some files, we also take advantage of props and events, as well as manually mounting some shared logic files on plugin init outside of React.

Debugging Kea

To debug Kea state in-browser, Kea recommends Redux Devtools. To facilitate debugging, we use the path key with snake_cased paths. The path key should always end with the logic filename (e.g. ['enterprise_search', 'some_logic']) to make it easy for devs to quickly find/jump to files via IDE tooling.

Testing

Unit tests

Documentation: https://www.elastic.co/guide/en/kibana/current/development-tests.html#_unit_testing

Jest tests can be run directly from the x-pack/plugins/enterprise_search folder. This also works for any subfolders or subcomponents.

yarn test:jest
yarn test:jest --watch

Unfortunately coverage collection does not work as automatically, and requires using our handy jest.sh script if you want to run tests on a specific folder and only get coverage numbers for that folder:

# Running the jest.sh script from the `x-pack/plugins/enterprise_search` folder (vs. kibana root)
# will save you time and allow you to Tab to complete folder dir names
sh jest.sh {YOUR_COMPONENT_DIR}
sh jest.sh public/applications/shared/kibana
sh jest.sh server/routes/app_search

E2E tests

See our functional test runner README.