kibana/x-pack/plugins/enterprise_search
Constance ec3926433c
[App Search] Various engines fixes (#95127)
* [Misc] Update trash icon color

- should be danger/red to match other tables in Kibana

* Engine table - fix incorrect conditional around when users can delete engines

- The check for that should be around Dev/Editor/Analyst roles, not around whether the account has a platinum license

- Tests - DRY out reset mock
- ideally would be in a beforeEach, but mount/beforeAll perf makes that difficult

* Create engine button - wrap with canManageEngines check

- prevents Dev/Editor/Analyst roles from hitting a 404 page

- test cleanup - use describe blocks to convey conditional branching, combine 2 tests into 1

* Empty engines prompt - add canManageEngines check

+ switch from FormattedMessage to i18n (this view was created a long time ago before we settled on generally preferring i18n)

+ provide a more helpful body text when the user cannot create engines

* Update x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/engines_overview.test.tsx

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>

Co-authored-by: Jason Stoltzfus <jastoltz24@gmail.com>
2021-03-24 13:23:07 -04:00
..
common [Workplace Search] Persist OAuth token package during OAuth connect flow (#93210) 2021-03-08 16:17:35 -08:00
public [App Search] Various engines fixes (#95127) 2021-03-24 13:23:07 -04:00
server [App Search] Role mappings migration part 3 (#94763) 2021-03-23 15:18:11 -04:00
jest.config.js
jest.sh
kibana.json
README.md
tsconfig.json

Enterprise Search

Overview

This plugin's goal is to provide a Kibana user interface to the Enterprise Search solution's products (App Search and Workplace Search). In it's current MVP state, the plugin provides the following with the goal of gathering user feedback and raising product awareness:

  • App Search: A basic engines overview with links into the product.
  • Workplace Search: A simple app overview with basic statistics, links to the sources, users (if standard auth), and product settings.

Development

  1. When developing locally, Enterprise Search should be running locally alongside Kibana on localhost:3002.
  2. Update config/kibana.dev.yml with enterpriseSearch.host: 'http://localhost:3002'
  3. For faster QA/development, run Enterprise Search on elasticsearch-native auth and log in as the elastic superuser on Kibana.

Kea

Enterprise Search uses Kea.js to manage our React/Redux state for us. Kea state is handled in our *Logic files and exposes values and actions for our components to get and set state with.

Advanced Kea usage

For the most part, we stick to the functionality described in Kea's core concepts. However, in some files, we also take advantage of props and events, as well as manually mounting some shared logic files on plugin init outside of React.

Debugging Kea

To debug Kea state in-browser, Kea recommends Redux Devtools. To facilitate debugging, we use the path key with snake_cased paths. The path key should always end with the logic filename (e.g. ['enterprise_search', 'some_logic']) to make it easy for devs to quickly find/jump to files via IDE tooling.

Testing

Unit tests

Documentation: https://www.elastic.co/guide/en/kibana/current/development-tests.html#_unit_testing

Jest tests can be run directly from the x-pack/plugins/enterprise_search folder. This also works for any subfolders or subcomponents.

yarn test:jest
yarn test:jest --watch

Unfortunately coverage collection does not work as automatically, and requires using our handy jest.sh script if you want to run tests on a specific folder and only get coverage numbers for that folder:

# Running the jest.sh script from the `x-pack/plugins/enterprise_search` folder (vs. kibana root)
# will save you time and allow you to Tab to complete folder dir names
sh jest.sh {YOUR_COMPONENT_DIR}
sh jest.sh public/applications/shared/kibana
sh jest.sh server/routes/app_search

E2E tests

See our functional test runner README.