kibana/x-pack/plugins/canvas/i18n
Poff Poffenberger cda3627a79
[Reporting/PDF] Layout option for generating full-page Canvas reports (#84959)
* [Reporting/PDF] Custom layout option for Canvas

* fix snapshots

* --wip-- [skip ci]

* check pdf data

* add test

* functional tests work

* add fixme comment

* read strings from pdf for test

* Update reports.ts

* function name / comment improvment

* Add Canvas toggle to choose pdf layout type

* Fix Canvas pdf panel storybook test

* Update style for new Canvas report type switch

* Update canvas share menu snapshot

* Fix tests for validating Canvas PDF using inline snapshots

Run test server with:
node scripts/functional_tests_server.js --config x-pack/test/functional/config.js

Run test suite with:
node scripts/functional_test_runner.js --config x-pack/test/functional/config.js --grep 'Canvas PDF Report'

* Fix i18n and typo

* Add a test for removing borders

* Fix i18n

* Update snapshot

Co-authored-by: Timothy Sullivan <tsullivan@elastic.co>
Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-12-10 13:34:47 -06:00
..
elements
functions [Lens] Categorical color palettes (#75309) 2020-11-04 11:27:52 +01:00
templates
capabilities.ts
components.ts [Reporting/PDF] Layout option for generating full-page Canvas reports (#84959) 2020-12-10 13:34:47 -06:00
constants.ts
errors.ts
expression_types.ts
index.ts
lib.ts
README.md
renderers.ts
shortcuts.ts
tags.ts
transitions.ts
ui.ts Upgrade EUI to v30.1.1 (#81499) 2020-10-30 16:18:27 -06:00
units.ts

Canvas and Internationalization (i18n)

Creating i18n strings in Kibana requires use of the @kbn/i18n library. The following outlines the strategy for localizing strings in Canvas

Why i18n Dictionaries

In Canvas, we prefer to use "dictionaries" of i18n strings over including translation inline. There are a number of reasons for this.

API Signature is Lengthy

A call to localize a string can look something like this:

i18n.translate('xpack.canvas.functions.alterColumn.args.columnHelpText', {
  defaultMessage: 'The name of the column to alter.',
}),

But it can also look something like this:

i18n.translate('xpack.canvas.functions.alterColumnHelpText', {
  defaultMessage:
    'Converts between core types, including {list}, and {end}, and rename columns. ' +
    'See also {mapColumnFn} and {staticColumnFn}.',
  values: {
    list: Object.values(DATATABLE_COLUMN_TYPES)
      .slice(0, -1)
      .map(type => `\`${type}\``)
      .join(', '),
    end: Object.values(DATATABLE_COLUMN_TYPES).slice(-1)[0],
    mapColumnFn: '`mapColumn`',
    staticColumnFn: '`staticColumn`',
  },
});

In either case, including all of this code inline, where the string is ultimately utilized, makes the code look very uneven, or even complicated. By externalizing the construction of localized strings, we can reduce both of these examples:

import { FunctionStrings } from './some/i18n/dictionary';
const { AlterColumn: strings } = FunctionStrings;

const help = strings.getColumnHelpText();
const moreHelp = strings.getAlterColumnHelpText();

Reducing Duplication, Auditing

By externalizing our strings into these functional dictionaries, we also make identifying duplicate strings easier... thus removing workload from translation teams. We can also deprecate functions. And Since they're written in Typescript, finding usage is easier, so we can easily remove them if a string is no longer used.

It will also make writing more advanced auditing tools easier.

Creating i18n Dictionaries

There are some Best Practices™️ to follow when localizing Canvas strings:

  • Create dictionaries in /canvas/i18n.
    • Organize first by the top-level subject or directory, (e.g. functions, renderers, components, etc).
  • Don't create too many files. Prefer to eventually split up a dictionary rather than start with many small ones.
    • Let's avoid ten files with two strings apiece, for example.
  • Create functions that produce a string, rather than properties of strings.
    • Prefer getSomeString({...values}) => i18n.translate(...);.
    • Avoid someString: i18n.translate(...);.
    • Standardizes the practice, also allows for passing dynamic values to the localized string in the future.
    • Exception to this is the dictionary for Canvas Functions, which use a more complex dictionary, influenced by data/interpreter.

Constants

In some cases, there are proper nouns or other words that should not be translated, (e.g. 'Canvas', 'JavaScript', 'momentJS', etc). We've created /canvas/i18n/constants.ts to collect these words. Use and add to these constants as necessary.