kibana/x-pack/plugins/lens/public/xy_visualization/visualization.test.ts
Marco Liberati d3d3fa7bd2
[Lens] New value labels config option for bar charts (#81776)
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
2020-11-06 16:34:30 +01:00

627 lines
18 KiB
TypeScript

/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/
import { getXyVisualization } from './visualization';
import { Position } from '@elastic/charts';
import { Operation } from '../types';
import { State, SeriesType } from './types';
import { createMockDatasource, createMockFramePublicAPI } from '../editor_frame_service/mocks';
import { LensIconChartBar } from '../assets/chart_bar';
import { chartPluginMock } from '../../../../../src/plugins/charts/public/mocks';
function exampleState(): State {
return {
legend: { position: Position.Bottom, isVisible: true },
valueLabels: 'hide',
preferredSeriesType: 'bar',
layers: [
{
layerId: 'first',
seriesType: 'area',
splitAccessor: 'd',
xAccessor: 'a',
accessors: ['b', 'c'],
},
],
};
}
const xyVisualization = getXyVisualization({
paletteService: chartPluginMock.createPaletteRegistry(),
});
describe('xy_visualization', () => {
describe('#getDescription', () => {
function mixedState(...types: SeriesType[]) {
const state = exampleState();
return {
...state,
layers: types.map((t, i) => ({
...state.layers[0],
layerId: `layer_${i}`,
seriesType: t,
})),
};
}
it('should show mixed xy chart when multilple series types', () => {
const desc = xyVisualization.getDescription(mixedState('bar', 'line'));
expect(desc.label).toEqual('Mixed XY');
});
it('should show the preferredSeriesType if there are no layers', () => {
const desc = xyVisualization.getDescription(mixedState());
expect(desc.icon).toEqual(LensIconChartBar);
expect(desc.label).toEqual('Bar');
});
it('should show mixed horizontal bar chart when multiple horizontal bar types', () => {
const desc = xyVisualization.getDescription(
mixedState('bar_horizontal', 'bar_horizontal_stacked')
);
expect(desc.label).toEqual('Mixed H. bar');
});
it('should show bar chart when bar only', () => {
const desc = xyVisualization.getDescription(mixedState('bar_horizontal', 'bar_horizontal'));
expect(desc.label).toEqual('H. Bar');
});
it('should show the chart description if not mixed', () => {
expect(xyVisualization.getDescription(mixedState('area')).label).toEqual('Area');
expect(xyVisualization.getDescription(mixedState('line')).label).toEqual('Line');
expect(xyVisualization.getDescription(mixedState('area_stacked')).label).toEqual(
'Stacked area'
);
expect(xyVisualization.getDescription(mixedState('bar_horizontal_stacked')).label).toEqual(
'H. Stacked bar'
);
});
});
describe('#getVisualizationTypeId', () => {
function mixedState(...types: SeriesType[]) {
const state = exampleState();
return {
...state,
layers: types.map((t, i) => ({
...state.layers[0],
layerId: `layer_${i}`,
seriesType: t,
})),
};
}
it('should show mixed when each layer is different', () => {
expect(xyVisualization.getVisualizationTypeId(mixedState('bar', 'line'))).toEqual('mixed');
});
it('should show the preferredSeriesType if there are no layers', () => {
expect(xyVisualization.getVisualizationTypeId(mixedState())).toEqual('bar');
});
it('should combine multiple layers into one type', () => {
expect(
xyVisualization.getVisualizationTypeId(mixedState('bar_horizontal', 'bar_horizontal'))
).toEqual('bar_horizontal');
});
it('should return the subtype for single layers', () => {
expect(xyVisualization.getVisualizationTypeId(mixedState('area'))).toEqual('area');
expect(xyVisualization.getVisualizationTypeId(mixedState('line'))).toEqual('line');
expect(xyVisualization.getVisualizationTypeId(mixedState('area_stacked'))).toEqual(
'area_stacked'
);
expect(xyVisualization.getVisualizationTypeId(mixedState('bar_horizontal_stacked'))).toEqual(
'bar_horizontal_stacked'
);
});
});
describe('#initialize', () => {
it('loads default state', () => {
const mockFrame = createMockFramePublicAPI();
const initialState = xyVisualization.initialize(mockFrame);
expect(initialState.layers).toHaveLength(1);
expect(initialState.layers[0].xAccessor).not.toBeDefined();
expect(initialState.layers[0].accessors).toHaveLength(0);
expect(initialState).toMatchInlineSnapshot(`
Object {
"layers": Array [
Object {
"accessors": Array [],
"layerId": "",
"position": "top",
"seriesType": "bar_stacked",
"showGridlines": false,
},
],
"legend": Object {
"isVisible": true,
"position": "right",
},
"preferredSeriesType": "bar_stacked",
"title": "Empty XY chart",
"valueLabels": "hide",
}
`);
});
it('loads from persisted state', () => {
expect(xyVisualization.initialize(createMockFramePublicAPI(), exampleState())).toEqual(
exampleState()
);
});
});
describe('#removeLayer', () => {
it('removes the specified layer', () => {
const prevState: State = {
...exampleState(),
layers: [
...exampleState().layers,
{
layerId: 'second',
seriesType: 'area',
splitAccessor: 'e',
xAccessor: 'f',
accessors: ['g', 'h'],
},
],
};
expect(xyVisualization.removeLayer!(prevState, 'second')).toEqual(exampleState());
});
});
describe('#appendLayer', () => {
it('adds a layer', () => {
const layers = xyVisualization.appendLayer!(exampleState(), 'foo').layers;
expect(layers.length).toEqual(exampleState().layers.length + 1);
expect(layers[layers.length - 1]).toMatchObject({ layerId: 'foo' });
});
});
describe('#clearLayer', () => {
it('clears the specified layer', () => {
const layer = xyVisualization.clearLayer(exampleState(), 'first').layers[0];
expect(layer).toMatchObject({
accessors: [],
layerId: 'first',
seriesType: 'bar',
});
});
});
describe('#getLayerIds', () => {
it('returns layerids', () => {
expect(xyVisualization.getLayerIds(exampleState())).toEqual(['first']);
});
});
describe('#setDimension', () => {
it('sets the x axis', () => {
expect(
xyVisualization.setDimension({
prevState: {
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
},
],
},
layerId: 'first',
groupId: 'x',
columnId: 'newCol',
}).layers[0]
).toEqual({
layerId: 'first',
seriesType: 'area',
xAccessor: 'newCol',
accessors: [],
});
});
it('replaces the x axis', () => {
expect(
xyVisualization.setDimension({
prevState: {
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
],
},
layerId: 'first',
groupId: 'x',
columnId: 'newCol',
}).layers[0]
).toEqual({
layerId: 'first',
seriesType: 'area',
xAccessor: 'newCol',
accessors: [],
});
});
});
describe('#removeDimension', () => {
it('removes the x axis', () => {
expect(
xyVisualization.removeDimension({
prevState: {
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
],
},
layerId: 'first',
columnId: 'a',
}).layers[0]
).toEqual({
layerId: 'first',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
});
});
});
describe('#getConfiguration', () => {
let mockDatasource: ReturnType<typeof createMockDatasource>;
let frame: ReturnType<typeof createMockFramePublicAPI>;
beforeEach(() => {
frame = createMockFramePublicAPI();
mockDatasource = createMockDatasource('testDatasource');
mockDatasource.publicAPIMock.getTableSpec.mockReturnValue([
{ columnId: 'd' },
{ columnId: 'a' },
{ columnId: 'b' },
{ columnId: 'c' },
]);
frame.datasourceLayers = {
first: mockDatasource.publicAPIMock,
};
});
it('should return options for 3 dimensions', () => {
const options = xyVisualization.getConfiguration({
state: exampleState(),
frame,
layerId: 'first',
}).groups;
expect(options).toHaveLength(3);
expect(options.map((o) => o.groupId)).toEqual(['x', 'y', 'breakdown']);
});
it('should return the correct labels for the 3 dimensios', () => {
const options = xyVisualization.getConfiguration({
state: exampleState(),
frame,
layerId: 'first',
}).groups;
expect(options.map((o) => o.groupLabel)).toEqual([
'Horizontal axis',
'Vertical axis',
'Break down by',
]);
});
it('should return the correct labels for the 3 dimensios for a horizontal chart', () => {
const initialState = exampleState();
const state = {
...initialState,
layers: [{ ...initialState.layers[0], seriesType: 'bar_horizontal' as SeriesType }],
};
const options = xyVisualization.getConfiguration({
state,
frame,
layerId: 'first',
}).groups;
expect(options.map((o) => o.groupLabel)).toEqual([
'Vertical axis',
'Horizontal axis',
'Break down by',
]);
});
it('should only accept bucketed operations for x', () => {
const options = xyVisualization.getConfiguration({
state: exampleState(),
frame,
layerId: 'first',
}).groups;
const filterOperations = options.find((o) => o.groupId === 'x')!.filterOperations;
const exampleOperation: Operation = {
dataType: 'number',
isBucketed: false,
label: 'bar',
};
const bucketedOps: Operation[] = [
{ ...exampleOperation, isBucketed: true, dataType: 'number' },
{ ...exampleOperation, isBucketed: true, dataType: 'string' },
{ ...exampleOperation, isBucketed: true, dataType: 'boolean' },
{ ...exampleOperation, isBucketed: true, dataType: 'date' },
];
const ops: Operation[] = [
...bucketedOps,
{ ...exampleOperation, dataType: 'number' },
{ ...exampleOperation, dataType: 'string' },
{ ...exampleOperation, dataType: 'boolean' },
{ ...exampleOperation, dataType: 'date' },
];
expect(ops.filter(filterOperations)).toEqual(bucketedOps);
});
it('should not allow anything to be added to x', () => {
const options = xyVisualization.getConfiguration({
state: exampleState(),
frame,
layerId: 'first',
}).groups;
expect(options.find((o) => o.groupId === 'x')?.supportsMoreColumns).toBe(false);
});
it('should allow number operations on y', () => {
const options = xyVisualization.getConfiguration({
state: exampleState(),
frame,
layerId: 'first',
}).groups;
const filterOperations = options.find((o) => o.groupId === 'y')!.filterOperations;
const exampleOperation: Operation = {
dataType: 'number',
isBucketed: false,
label: 'bar',
};
const ops: Operation[] = [
{ ...exampleOperation, dataType: 'number' },
{ ...exampleOperation, dataType: 'string' },
{ ...exampleOperation, dataType: 'boolean' },
{ ...exampleOperation, dataType: 'date' },
];
expect(ops.filter(filterOperations).map((x) => x.dataType)).toEqual(['number']);
});
});
describe('#getErrorMessages', () => {
it("should not return an error when there's only one dimension (X or Y)", () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
],
},
createMockFramePublicAPI()
)
).not.toBeDefined();
});
it("should not return an error when there's only one dimension on multiple layers (same axis everywhere)", () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
{
layerId: 'second',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
],
},
createMockFramePublicAPI()
)
).not.toBeDefined();
});
it('should not return an error when mixing different valid configurations in multiple layers', () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: ['a'],
},
{
layerId: 'second',
seriesType: 'area',
xAccessor: undefined,
accessors: ['a'],
splitAccessor: 'a',
},
],
},
createMockFramePublicAPI()
)
).not.toBeDefined();
});
it("should not return an error when there's only one splitAccessor dimension configured", () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
splitAccessor: 'a',
},
],
},
createMockFramePublicAPI()
)
).not.toBeDefined();
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
splitAccessor: 'a',
},
{
layerId: 'second',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
splitAccessor: 'a',
},
],
},
createMockFramePublicAPI()
)
).not.toBeDefined();
});
it('should return an error when there are multiple layers, one axis configured for each layer (but different axis from each other)', () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
{
layerId: 'second',
seriesType: 'area',
xAccessor: undefined,
accessors: ['a'],
},
],
},
createMockFramePublicAPI()
)
).toEqual([
{
shortMessage: 'Missing Vertical axis.',
longMessage: 'Layer 1 requires a field for the Vertical axis.',
},
]);
});
it('should return an error with batched messages for the same error with multiple layers', () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: ['a'],
},
{
layerId: 'second',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
splitAccessor: 'a',
},
{
layerId: 'third',
seriesType: 'area',
xAccessor: undefined,
accessors: [],
splitAccessor: 'a',
},
],
},
createMockFramePublicAPI()
)
).toEqual([
{
shortMessage: 'Missing Vertical axis.',
longMessage: 'Layers 2, 3 require a field for the Vertical axis.',
},
]);
});
it("should return an error when some layers are complete but other layers aren't", () => {
expect(
xyVisualization.getErrorMessages(
{
...exampleState(),
layers: [
{
layerId: 'first',
seriesType: 'area',
xAccessor: 'a',
accessors: [],
},
{
layerId: 'second',
seriesType: 'area',
xAccessor: 'a',
accessors: ['a'],
},
{
layerId: 'third',
seriesType: 'area',
xAccessor: 'a',
accessors: ['a'],
},
],
},
createMockFramePublicAPI()
)
).toEqual([
{
shortMessage: 'Missing Vertical axis.',
longMessage: 'Layer 1 requires a field for the Vertical axis.',
},
]);
});
});
});