kibana/x-pack/plugins/watcher
Jean-Louis Leysens d662cb5f45
[ESUI] Move XJson Mode to src/plugins/es_ui_shared (#62758)
* Move XJson to x-pack/es_ui_shared

Also convert files to TS and clean up use of @ts-ignore

* Move console_lang to public

* Proper use of mocks

* Globally mock out .ace.worker.js modules

Having worker code exported in `public` of es_ui_shared poisoned
a lot of Jest tests with the need to mock out the ace worker.

Instead of adding mocks everywhere we handle the importing in
Jest by adding an entry to module mapper.

* Remove manual imports of mocks

* Delete es_ui_shared/public/mocks for now

* Put useXJson code in single place

* Import and instantiate xJsonMode

* Remove language mocks imports

Besides the fact that these paths are wrong these are no longer
needed because we mock at use Jest module mapper

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
2020-04-10 12:58:18 +02:00
..
__jest__/client_integration [ESUI] Move XJson Mode to src/plugins/es_ui_shared (#62758) 2020-04-10 12:58:18 +02:00
common
public [ESUI] Move XJson Mode to src/plugins/es_ui_shared (#62758) 2020-04-10 12:58:18 +02:00
server [Watcher] Preserve the watch active status after updates (#61999) 2020-04-10 12:28:55 +02:00
test/fixtures
kibana.json Fix plugin enabled config options (#60998) 2020-03-25 15:09:04 -06:00
README.md

Conventions

This plugins adopts some conventions in addition to or in place of conventions in Kibana (at the time of the plugin's creation):

Folder structure

common/
  constants/ // constants used across client and server
  lib/ // helpers used across client and server
  types/ // TS definitions
public/
  components/ // common React components
  constants/ // constants used on the client
  lib/ // helpers used on the client
  models/ // client models
  sections/ // Sections of the app with corresponding React components
    watch_edit
    watch_list
    watch_status
server/
  lib/
    screenshots/
      screenshots.js
      index.js // ONLY exposes screenshots service
      screenshot.js // helper service, not exposed in index.js
      __tests__/
        screenshots.js
        screenshot.js
    say_hello/
      index.js
      say_hello.js

Data Flow

We have a layered architecture in the Watcher UI codebase, with each layer performing a specific function to the data as it flows through it.

Elasticsearch APIs <---> Kibana server models <---> Kibana APIs <---> Kibana client services <---> Kibana client models <---> Kibana client code

Each of these layers is described below.

Elasticsearch APIs

This the ultimate source or destination of any persisted data: watches, watch history, etc.

Kibana server models

These set of classes translate data coming from Elasticsearch into a shape required by the Watcher UI codebase. Conversely, they translate data generated by the Watcher UI into a shape required by Elasticsearch APIs.

Kibana APIs

This layer is responsible for transporting data between the Kibana server and Kibana client (browser).

Kibana client services

This layer is responsible for calling Kibana APIs, using client models to parse responses from APIs or create requests for APIs.

Service methods should consume models as arguments and return models as much as possible. The exception to this might be services that perform an initial load of a piece of data from the API; in this case the service method may consume a scalar ID as it argument.

Kibana client models

Much like their server counterparts, these set of classes translate data coming from the Kibana APIs into in-memory representations for use in the Kibana client-side code or vice-versa. Unlike their server counterparts they typically don't change the shape of the data (as that is typically done by the server models already).

They do, however, serve as a consistent place in the data path for translating wire representations of certain types of data into more suitable in-memory representations, for example: converting an ISO8601-formatted timestamp into a moment instance.

They are also the right place for establishing relationships between models — for example, a watch contains many actions — and for encapsulating operations around such relationships — for example, updating the status of a watch's action.

Kibana client code

This layer deals almost exclusively with data in the form of client models. The one exception to this rule is when the client code needs to bootstrap a model instance from a bare JS object — for example, creating a new Watch model from the contents of the Add/Edit Watch Form.