2006-10-11 10:20:50 +02:00
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* linux/fs/ext4/inode.c
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
|
|
|
* Copyright (C) 1992, 1993, 1994, 1995
|
|
|
|
* Remy Card (card@masi.ibp.fr)
|
|
|
|
* Laboratoire MASI - Institut Blaise Pascal
|
|
|
|
* Universite Pierre et Marie Curie (Paris VI)
|
|
|
|
*
|
|
|
|
* from
|
|
|
|
*
|
|
|
|
* linux/fs/minix/inode.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 1991, 1992 Linus Torvalds
|
|
|
|
*
|
|
|
|
* 64-bit file support on 64-bit platforms by Jakub Jelinek
|
|
|
|
* (jj@sunsite.ms.mff.cuni.cz)
|
|
|
|
*
|
2006-10-11 10:20:53 +02:00
|
|
|
* Assorted race fixes, rewrite of ext4_get_block() by Al Viro, 2000
|
2006-10-11 10:20:50 +02:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/time.h>
|
|
|
|
#include <linux/highuid.h>
|
|
|
|
#include <linux/pagemap.h>
|
2015-09-08 23:58:40 +02:00
|
|
|
#include <linux/dax.h>
|
2006-10-11 10:20:50 +02:00
|
|
|
#include <linux/quotaops.h>
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/buffer_head.h>
|
|
|
|
#include <linux/writeback.h>
|
2008-07-12 01:27:31 +02:00
|
|
|
#include <linux/pagevec.h>
|
2006-10-11 10:20:50 +02:00
|
|
|
#include <linux/mpage.h>
|
2008-12-19 21:47:15 +01:00
|
|
|
#include <linux/namei.h>
|
2006-10-11 10:20:50 +02:00
|
|
|
#include <linux/uio.h>
|
|
|
|
#include <linux/bio.h>
|
2009-09-28 21:48:41 +02:00
|
|
|
#include <linux/workqueue.h>
|
2010-03-04 22:14:02 +01:00
|
|
|
#include <linux/kernel.h>
|
2011-01-13 01:59:13 +01:00
|
|
|
#include <linux/printk.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 09:04:11 +01:00
|
|
|
#include <linux/slab.h>
|
2014-03-30 16:20:01 +02:00
|
|
|
#include <linux/bitops.h>
|
2009-06-17 17:48:11 +02:00
|
|
|
|
2008-04-30 00:13:32 +02:00
|
|
|
#include "ext4_jbd2.h"
|
2006-10-11 10:20:50 +02:00
|
|
|
#include "xattr.h"
|
|
|
|
#include "acl.h"
|
2011-06-28 01:16:04 +02:00
|
|
|
#include "truncate.h"
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2009-06-17 17:48:11 +02:00
|
|
|
#include <trace/events/ext4.h>
|
|
|
|
|
2008-08-20 03:55:02 +02:00
|
|
|
#define MPAGE_DA_EXTENT_TAIL 0x01
|
|
|
|
|
2012-04-30 00:31:10 +02:00
|
|
|
static __u32 ext4_inode_csum(struct inode *inode, struct ext4_inode *raw,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
__u16 csum_lo;
|
|
|
|
__u16 csum_hi = 0;
|
|
|
|
__u32 csum;
|
|
|
|
|
2013-04-10 05:56:48 +02:00
|
|
|
csum_lo = le16_to_cpu(raw->i_checksum_lo);
|
2012-04-30 00:31:10 +02:00
|
|
|
raw->i_checksum_lo = 0;
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi)) {
|
2013-04-10 05:56:48 +02:00
|
|
|
csum_hi = le16_to_cpu(raw->i_checksum_hi);
|
2012-04-30 00:31:10 +02:00
|
|
|
raw->i_checksum_hi = 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
csum = ext4_chksum(sbi, ei->i_csum_seed, (__u8 *)raw,
|
|
|
|
EXT4_INODE_SIZE(inode->i_sb));
|
|
|
|
|
2013-04-10 05:56:48 +02:00
|
|
|
raw->i_checksum_lo = cpu_to_le16(csum_lo);
|
2012-04-30 00:31:10 +02:00
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi))
|
2013-04-10 05:56:48 +02:00
|
|
|
raw->i_checksum_hi = cpu_to_le16(csum_hi);
|
2012-04-30 00:31:10 +02:00
|
|
|
|
|
|
|
return csum;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext4_inode_csum_verify(struct inode *inode, struct ext4_inode *raw,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
__u32 provided, calculated;
|
|
|
|
|
|
|
|
if (EXT4_SB(inode->i_sb)->s_es->s_creator_os !=
|
|
|
|
cpu_to_le32(EXT4_OS_LINUX) ||
|
2014-10-13 09:36:16 +02:00
|
|
|
!ext4_has_metadata_csum(inode->i_sb))
|
2012-04-30 00:31:10 +02:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
provided = le16_to_cpu(raw->i_checksum_lo);
|
|
|
|
calculated = ext4_inode_csum(inode, raw, ei);
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi))
|
|
|
|
provided |= ((__u32)le16_to_cpu(raw->i_checksum_hi)) << 16;
|
|
|
|
else
|
|
|
|
calculated &= 0xFFFF;
|
|
|
|
|
|
|
|
return provided == calculated;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void ext4_inode_csum_set(struct inode *inode, struct ext4_inode *raw,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
__u32 csum;
|
|
|
|
|
|
|
|
if (EXT4_SB(inode->i_sb)->s_es->s_creator_os !=
|
|
|
|
cpu_to_le32(EXT4_OS_LINUX) ||
|
2014-10-13 09:36:16 +02:00
|
|
|
!ext4_has_metadata_csum(inode->i_sb))
|
2012-04-30 00:31:10 +02:00
|
|
|
return;
|
|
|
|
|
|
|
|
csum = ext4_inode_csum(inode, raw, ei);
|
|
|
|
raw->i_checksum_lo = cpu_to_le16(csum & 0xFFFF);
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw, ei, i_checksum_hi))
|
|
|
|
raw->i_checksum_hi = cpu_to_le16(csum >> 16);
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
static inline int ext4_begin_ordered_truncate(struct inode *inode,
|
|
|
|
loff_t new_size)
|
|
|
|
{
|
2010-11-08 19:51:33 +01:00
|
|
|
trace_ext4_begin_ordered_truncate(inode, new_size);
|
2011-01-10 18:29:43 +01:00
|
|
|
/*
|
|
|
|
* If jinode is zero, then we never opened the file for
|
|
|
|
* writing, so there's no need to call
|
|
|
|
* jbd2_journal_begin_ordered_truncate() since there's no
|
|
|
|
* outstanding writes we need to flush.
|
|
|
|
*/
|
|
|
|
if (!EXT4_I(inode)->jinode)
|
|
|
|
return 0;
|
|
|
|
return jbd2_journal_begin_ordered_truncate(EXT4_JOURNAL(inode),
|
|
|
|
EXT4_I(inode)->jinode,
|
|
|
|
new_size);
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
|
|
|
|
2013-05-22 05:17:23 +02:00
|
|
|
static void ext4_invalidatepage(struct page *page, unsigned int offset,
|
|
|
|
unsigned int length);
|
2010-10-28 03:30:09 +02:00
|
|
|
static int __ext4_journalled_writepage(struct page *page, unsigned int len);
|
|
|
|
static int ext4_bh_delay_or_unwritten(handle_t *handle, struct buffer_head *bh);
|
2013-06-04 19:01:11 +02:00
|
|
|
static int ext4_meta_trans_blocks(struct inode *inode, int lblocks,
|
|
|
|
int pextents);
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* Test whether an inode is a fast symlink.
|
|
|
|
*/
|
2015-04-16 07:55:00 +02:00
|
|
|
int ext4_inode_is_fast_symlink(struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2014-01-06 20:06:18 +01:00
|
|
|
int ea_blocks = EXT4_I(inode)->i_file_acl ?
|
|
|
|
EXT4_CLUSTER_SIZE(inode->i_sb) >> 9 : 0;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2014-06-02 16:48:22 +02:00
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return 0;
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
return (S_ISLNK(inode->i_mode) && inode->i_blocks - ea_blocks == 0);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Restart the transaction associated with *handle. This does a commit,
|
|
|
|
* so before we call here everything must be consistently dirtied against
|
|
|
|
* this transaction.
|
|
|
|
*/
|
2009-11-03 00:50:49 +01:00
|
|
|
int ext4_truncate_restart_trans(handle_t *handle, struct inode *inode,
|
2009-08-18 04:17:20 +02:00
|
|
|
int nblocks)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2009-08-18 04:17:20 +02:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
/*
|
2010-05-17 01:00:00 +02:00
|
|
|
* Drop i_data_sem to avoid deadlock with ext4_map_blocks. At this
|
2009-08-18 04:17:20 +02:00
|
|
|
* moment, get_block can be called only for blocks inside i_size since
|
|
|
|
* page cache has been already dropped and writes are blocked by
|
|
|
|
* i_mutex. So we can safely drop the i_data_sem here.
|
|
|
|
*/
|
2009-01-07 06:06:22 +01:00
|
|
|
BUG_ON(EXT4_JOURNAL(inode) == NULL);
|
2006-10-11 10:20:50 +02:00
|
|
|
jbd_debug(2, "restarting handle %p\n", handle);
|
2009-08-18 04:17:20 +02:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2011-02-28 05:32:12 +01:00
|
|
|
ret = ext4_journal_restart(handle, nblocks);
|
2009-08-18 04:17:20 +02:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2009-11-03 00:50:49 +01:00
|
|
|
ext4_discard_preallocations(inode);
|
2009-08-18 04:17:20 +02:00
|
|
|
|
|
|
|
return ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Called at the last iput() if i_nlink is zero.
|
|
|
|
*/
|
2010-06-07 19:16:22 +02:00
|
|
|
void ext4_evict_inode(struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
handle_t *handle;
|
2008-08-03 03:10:38 +02:00
|
|
|
int err;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2010-11-08 19:51:33 +01:00
|
|
|
trace_ext4_evict_inode(inode);
|
2011-08-13 18:17:13 +02:00
|
|
|
|
2010-06-07 19:16:22 +02:00
|
|
|
if (inode->i_nlink) {
|
2011-07-26 15:07:11 +02:00
|
|
|
/*
|
|
|
|
* When journalling data dirty buffers are tracked only in the
|
|
|
|
* journal. So although mm thinks everything is clean and
|
|
|
|
* ready for reaping the inode might still have some pages to
|
|
|
|
* write in the running transaction or waiting to be
|
|
|
|
* checkpointed. Thus calling jbd2_journal_invalidatepage()
|
|
|
|
* (via truncate_inode_pages()) to discard these buffers can
|
|
|
|
* cause data loss. Also even if we did not discard these
|
|
|
|
* buffers, we would have no way to find them after the inode
|
|
|
|
* is reaped and thus user could see stale data if he tries to
|
|
|
|
* read them before the transaction is checkpointed. So be
|
|
|
|
* careful and force everything to disk here... We use
|
|
|
|
* ei->i_datasync_tid to store the newest transaction
|
|
|
|
* containing inode's data.
|
|
|
|
*
|
|
|
|
* Note that directories do not have this problem because they
|
|
|
|
* don't use page cache.
|
|
|
|
*/
|
|
|
|
if (ext4_should_journal_data(inode) &&
|
ext4: fix data=journal fast mount/umount hang
In data=journal mode, if we unmount the file system before a
transaction has a chance to complete, when the journal inode is being
evicted, we can end up calling into jbd2_log_wait_commit() for the
last transaction, after the journalling machinery has been shut down.
Arguably we should adjust ext4_should_journal_data() to return FALSE
for the journal inode, but the only place it matters is
ext4_evict_inode(), and so to save a bit of CPU time, and to make the
patch much more obviously correct by inspection(tm), we'll fix it by
explicitly not trying to waiting for a journal commit when we are
evicting the journal inode, since it's guaranteed to never succeed in
this case.
This can be easily replicated via:
mount -t ext4 -o data=journal /dev/vdb /vdb ; umount /vdb
------------[ cut here ]------------
WARNING: at /usr/projects/linux/ext4/fs/jbd2/journal.c:542 __jbd2_log_start_commit+0xba/0xcd()
Hardware name: Bochs
JBD2: bad log_start_commit: 3005630206 3005630206 0 0
Modules linked in:
Pid: 2909, comm: umount Not tainted 3.8.0-rc3 #1020
Call Trace:
[<c015c0ef>] warn_slowpath_common+0x68/0x7d
[<c02b7e7d>] ? __jbd2_log_start_commit+0xba/0xcd
[<c015c177>] warn_slowpath_fmt+0x2b/0x2f
[<c02b7e7d>] __jbd2_log_start_commit+0xba/0xcd
[<c02b8075>] jbd2_log_start_commit+0x24/0x34
[<c0279ed5>] ext4_evict_inode+0x71/0x2e3
[<c021f0ec>] evict+0x94/0x135
[<c021f9aa>] iput+0x10a/0x110
[<c02b7836>] jbd2_journal_destroy+0x190/0x1ce
[<c0175284>] ? bit_waitqueue+0x50/0x50
[<c028d23f>] ext4_put_super+0x52/0x294
[<c020efe3>] generic_shutdown_super+0x48/0xb4
[<c020f071>] kill_block_super+0x22/0x60
[<c020f3e0>] deactivate_locked_super+0x22/0x49
[<c020f5d6>] deactivate_super+0x30/0x33
[<c0222795>] mntput_no_expire+0x107/0x10c
[<c02233a7>] sys_umount+0x2cf/0x2e0
[<c02233ca>] sys_oldumount+0x12/0x14
[<c08096b8>] syscall_call+0x7/0xb
---[ end trace 6a954cc790501c1f ]---
jbd2_log_wait_commit: error: j_commit_request=-1289337090, tid=0
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: stable@vger.kernel.org
2013-03-20 14:42:11 +01:00
|
|
|
(S_ISLNK(inode->i_mode) || S_ISREG(inode->i_mode)) &&
|
|
|
|
inode->i_ino != EXT4_JOURNAL_INO) {
|
2011-07-26 15:07:11 +02:00
|
|
|
journal_t *journal = EXT4_SB(inode->i_sb)->s_journal;
|
|
|
|
tid_t commit_tid = EXT4_I(inode)->i_datasync_tid;
|
|
|
|
|
ext4/jbd2: don't wait (forever) for stale tid caused by wraparound
In the case where an inode has a very stale transaction id (tid) in
i_datasync_tid or i_sync_tid, it's possible that after a very large
(2**31) number of transactions, that the tid number space might wrap,
causing tid_geq()'s calculations to fail.
Commit deeeaf13 "jbd2: fix fsync() tid wraparound bug", later modified
by commit e7b04ac0 "jbd2: don't wake kjournald unnecessarily",
attempted to fix this problem, but it only avoided kjournald spinning
forever by fixing the logic in jbd2_log_start_commit().
Unfortunately, in the codepaths in fs/ext4/fsync.c and fs/ext4/inode.c
that might call jbd2_log_start_commit() with a stale tid, those
functions will subsequently call jbd2_log_wait_commit() with the same
stale tid, and then wait for a very long time. To fix this, we
replace the calls to jbd2_log_start_commit() and
jbd2_log_wait_commit() with a call to a new function,
jbd2_complete_transaction(), which will correctly handle stale tid's.
As a bonus, jbd2_complete_transaction() will avoid locking
j_state_lock for writing unless a commit needs to be started. This
should have a small (but probably not measurable) improvement for
ext4's scalability.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Reported-by: George Barnett <gbarnett@atlassian.com>
Cc: stable@vger.kernel.org
2013-04-04 04:02:52 +02:00
|
|
|
jbd2_complete_transaction(journal, commit_tid);
|
2011-07-26 15:07:11 +02:00
|
|
|
filemap_write_and_wait(&inode->i_data);
|
|
|
|
}
|
2014-04-03 23:47:49 +02:00
|
|
|
truncate_inode_pages_final(&inode->i_data);
|
2013-06-04 20:46:12 +02:00
|
|
|
|
|
|
|
WARN_ON(atomic_read(&EXT4_I(inode)->i_ioend_count));
|
2010-06-07 19:16:22 +02:00
|
|
|
goto no_delete;
|
|
|
|
}
|
|
|
|
|
ext4: don't orphan or truncate the boot loader inode
The boot loader inode (inode #5) should never be visible in the
directory hierarchy, but it's possible if the file system is corrupted
that there will be a directory entry that points at inode #5. In
order to avoid accidentally trashing it, when such a directory inode
is opened, the inode will be marked as a bad inode, so that it's not
possible to modify (or read) the inode from userspace.
Unfortunately, when we unlink this (invalid/illegal) directory entry,
we will put the bad inode on the ophan list, and then when try to
unlink the directory, we don't actually remove the bad inode from the
orphan list before freeing in-memory inode structure. This means the
in-memory orphan list is corrupted, leading to a kernel oops.
In addition, avoid truncating a bad inode in ext4_destroy_inode(),
since truncating the boot loader inode is not a smart thing to do.
Reported-by: Sami Liedes <sami.liedes@iki.fi>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2014-10-06 04:47:07 +02:00
|
|
|
if (is_bad_inode(inode))
|
|
|
|
goto no_delete;
|
|
|
|
dquot_initialize(inode);
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
if (ext4_should_order_data(inode))
|
|
|
|
ext4_begin_ordered_truncate(inode, 0);
|
2014-04-03 23:47:49 +02:00
|
|
|
truncate_inode_pages_final(&inode->i_data);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2013-06-04 20:46:12 +02:00
|
|
|
WARN_ON(atomic_read(&EXT4_I(inode)->i_ioend_count));
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2012-06-12 16:20:38 +02:00
|
|
|
/*
|
|
|
|
* Protect us against freezing - iput() caller didn't have to have any
|
|
|
|
* protection against it
|
|
|
|
*/
|
|
|
|
sb_start_intwrite(inode->i_sb);
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_TRUNCATE,
|
|
|
|
ext4_blocks_for_truncate(inode)+3);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (IS_ERR(handle)) {
|
2008-08-03 03:10:38 +02:00
|
|
|
ext4_std_error(inode->i_sb, PTR_ERR(handle));
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* If we're going to skip the normal cleanup, we still need to
|
|
|
|
* make sure that the in-core orphan linked list is properly
|
|
|
|
* cleaned up.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_orphan_del(NULL, inode);
|
2012-06-12 16:20:38 +02:00
|
|
|
sb_end_intwrite(inode->i_sb);
|
2006-10-11 10:20:50 +02:00
|
|
|
goto no_delete;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (IS_SYNC(inode))
|
2009-01-07 06:06:22 +01:00
|
|
|
ext4_handle_sync(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
inode->i_size = 0;
|
2008-08-03 03:10:38 +02:00
|
|
|
err = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
if (err) {
|
2010-02-15 20:19:27 +01:00
|
|
|
ext4_warning(inode->i_sb,
|
2008-08-03 03:10:38 +02:00
|
|
|
"couldn't mark inode dirty (err %d)", err);
|
|
|
|
goto stop_handle;
|
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
if (inode->i_blocks)
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_truncate(inode);
|
2008-08-03 03:10:38 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* ext4_ext_truncate() doesn't reserve any slop when it
|
|
|
|
* restarts journal transactions; therefore there may not be
|
|
|
|
* enough credits left in the handle to remove the inode from
|
|
|
|
* the orphan list and set the dtime field.
|
|
|
|
*/
|
2009-01-07 06:06:22 +01:00
|
|
|
if (!ext4_handle_has_enough_credits(handle, 3)) {
|
2008-08-03 03:10:38 +02:00
|
|
|
err = ext4_journal_extend(handle, 3);
|
|
|
|
if (err > 0)
|
|
|
|
err = ext4_journal_restart(handle, 3);
|
|
|
|
if (err != 0) {
|
2010-02-15 20:19:27 +01:00
|
|
|
ext4_warning(inode->i_sb,
|
2008-08-03 03:10:38 +02:00
|
|
|
"couldn't extend journal (err %d)", err);
|
|
|
|
stop_handle:
|
|
|
|
ext4_journal_stop(handle);
|
2010-07-29 21:06:10 +02:00
|
|
|
ext4_orphan_del(NULL, inode);
|
2012-06-12 16:20:38 +02:00
|
|
|
sb_end_intwrite(inode->i_sb);
|
2008-08-03 03:10:38 +02:00
|
|
|
goto no_delete;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* Kill off the orphan record which ext4_truncate created.
|
2006-10-11 10:20:50 +02:00
|
|
|
* AKPM: I think this can be inside the above `if'.
|
2006-10-11 10:20:53 +02:00
|
|
|
* Note that ext4_orphan_del() has to be able to cope with the
|
2006-10-11 10:20:50 +02:00
|
|
|
* deletion of a non-existent orphan - this is because we don't
|
2006-10-11 10:20:53 +02:00
|
|
|
* know if ext4_truncate() actually created an orphan record.
|
2006-10-11 10:20:50 +02:00
|
|
|
* (Well, we could do this if we need to, but heck - it works)
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_orphan_del(handle, inode);
|
|
|
|
EXT4_I(inode)->i_dtime = get_seconds();
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* One subtle ordering requirement: if anything has gone wrong
|
|
|
|
* (transaction abort, IO errors, whatever), then we can still
|
|
|
|
* do these next steps (the fs will already have been marked as
|
|
|
|
* having errors), but we can't free the inode if the mark_dirty
|
|
|
|
* fails.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
if (ext4_mark_inode_dirty(handle, inode))
|
2006-10-11 10:20:50 +02:00
|
|
|
/* If that failed, just do the required in-core inode clear. */
|
2010-06-07 19:16:22 +02:00
|
|
|
ext4_clear_inode(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
else
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_free_inode(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
2012-06-12 16:20:38 +02:00
|
|
|
sb_end_intwrite(inode->i_sb);
|
2006-10-11 10:20:50 +02:00
|
|
|
return;
|
|
|
|
no_delete:
|
2010-06-07 19:16:22 +02:00
|
|
|
ext4_clear_inode(inode); /* We must guarantee clearing of inode... */
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2009-12-14 13:21:14 +01:00
|
|
|
#ifdef CONFIG_QUOTA
|
|
|
|
qsize_t *ext4_get_reserved_space(struct inode *inode)
|
2009-01-22 18:13:05 +01:00
|
|
|
{
|
2009-12-14 13:21:14 +01:00
|
|
|
return &EXT4_I(inode)->i_reserved_quota;
|
2009-01-22 18:13:05 +01:00
|
|
|
}
|
2009-12-14 13:21:14 +01:00
|
|
|
#endif
|
2010-01-01 08:41:30 +01:00
|
|
|
|
2009-12-30 20:20:45 +01:00
|
|
|
/*
|
|
|
|
* Called with i_data_sem down, which is important since we can call
|
|
|
|
* ext4_discard_preallocations() from here.
|
|
|
|
*/
|
2010-01-25 10:00:31 +01:00
|
|
|
void ext4_da_update_reserve_space(struct inode *inode,
|
|
|
|
int used, int quota_claim)
|
2008-07-17 22:12:08 +02:00
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2009-12-30 20:20:45 +01:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
|
|
|
|
spin_lock(&ei->i_block_reservation_lock);
|
2011-09-10 01:18:51 +02:00
|
|
|
trace_ext4_da_update_reserve_space(inode, used, quota_claim);
|
2009-12-30 20:20:45 +01:00
|
|
|
if (unlikely(used > ei->i_reserved_data_blocks)) {
|
2013-02-14 21:11:41 +01:00
|
|
|
ext4_warning(inode->i_sb, "%s: ino %lu, used %d "
|
2012-03-20 04:13:43 +01:00
|
|
|
"with only %d reserved data blocks",
|
2009-12-30 20:20:45 +01:00
|
|
|
__func__, inode->i_ino, used,
|
|
|
|
ei->i_reserved_data_blocks);
|
|
|
|
WARN_ON(1);
|
|
|
|
used = ei->i_reserved_data_blocks;
|
|
|
|
}
|
2008-07-17 22:12:08 +02:00
|
|
|
|
2009-12-30 20:20:45 +01:00
|
|
|
/* Update per-inode reservations */
|
|
|
|
ei->i_reserved_data_blocks -= used;
|
2014-07-15 12:02:38 +02:00
|
|
|
percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
|
2008-10-10 15:39:00 +02:00
|
|
|
|
2008-07-17 22:12:08 +02:00
|
|
|
spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
|
2009-01-22 18:13:05 +01:00
|
|
|
|
2010-05-16 17:00:00 +02:00
|
|
|
/* Update quota subsystem for data blocks */
|
|
|
|
if (quota_claim)
|
2011-09-10 01:04:51 +02:00
|
|
|
dquot_claim_block(inode, EXT4_C2B(sbi, used));
|
2010-05-16 17:00:00 +02:00
|
|
|
else {
|
2010-01-25 10:00:31 +01:00
|
|
|
/*
|
|
|
|
* We did fallocate with an offset that is already delayed
|
|
|
|
* allocated. So on delayed allocated writeback we should
|
2010-05-16 17:00:00 +02:00
|
|
|
* not re-claim the quota for fallocated blocks.
|
2010-01-25 10:00:31 +01:00
|
|
|
*/
|
2011-09-10 01:04:51 +02:00
|
|
|
dquot_release_reservation_block(inode, EXT4_C2B(sbi, used));
|
2010-01-25 10:00:31 +01:00
|
|
|
}
|
2009-03-28 03:36:43 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If we have done all the pending block allocations and if
|
|
|
|
* there aren't any writers on the inode, we can discard the
|
|
|
|
* inode's preallocations.
|
|
|
|
*/
|
2009-12-30 20:20:45 +01:00
|
|
|
if ((ei->i_reserved_data_blocks == 0) &&
|
|
|
|
(atomic_read(&inode->i_writecount) == 0))
|
2009-03-28 03:36:43 +01:00
|
|
|
ext4_discard_preallocations(inode);
|
2008-07-17 22:12:08 +02:00
|
|
|
}
|
|
|
|
|
2010-06-29 18:54:28 +02:00
|
|
|
static int __check_block_validity(struct inode *inode, const char *func,
|
2010-07-27 17:56:40 +02:00
|
|
|
unsigned int line,
|
|
|
|
struct ext4_map_blocks *map)
|
2009-05-17 21:38:01 +02:00
|
|
|
{
|
2010-05-17 03:00:00 +02:00
|
|
|
if (!ext4_data_block_valid(EXT4_SB(inode->i_sb), map->m_pblk,
|
|
|
|
map->m_len)) {
|
2010-07-27 17:56:40 +02:00
|
|
|
ext4_error_inode(inode, func, line, map->m_pblk,
|
|
|
|
"lblock %lu mapped to illegal pblock "
|
|
|
|
"(length %d)", (unsigned long) map->m_lblk,
|
|
|
|
map->m_len);
|
2015-10-17 22:16:04 +02:00
|
|
|
return -EFSCORRUPTED;
|
2009-05-17 21:38:01 +02:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-07 21:09:35 +01:00
|
|
|
int ext4_issue_zeroout(struct inode *inode, ext4_lblk_t lblk, ext4_fsblk_t pblk,
|
|
|
|
ext4_lblk_t len)
|
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
if (ext4_encrypted_inode(inode))
|
|
|
|
return ext4_encrypted_zeroout(inode, lblk, pblk, len);
|
|
|
|
|
|
|
|
ret = sb_issue_zeroout(inode->i_sb, pblk, len, GFP_NOFS);
|
|
|
|
if (ret > 0)
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-06-29 18:54:28 +02:00
|
|
|
#define check_block_validity(inode, map) \
|
2010-07-27 17:56:40 +02:00
|
|
|
__check_block_validity((inode), __func__, __LINE__, (map))
|
2010-06-29 18:54:28 +02:00
|
|
|
|
2013-03-11 02:01:03 +01:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
static void ext4_map_blocks_es_recheck(handle_t *handle,
|
|
|
|
struct inode *inode,
|
|
|
|
struct ext4_map_blocks *es_map,
|
|
|
|
struct ext4_map_blocks *map,
|
|
|
|
int flags)
|
|
|
|
{
|
|
|
|
int retval;
|
|
|
|
|
|
|
|
map->m_flags = 0;
|
|
|
|
/*
|
|
|
|
* There is a race window that the result is not the same.
|
|
|
|
* e.g. xfstests #223 when dioread_nolock enables. The reason
|
|
|
|
* is that we lookup a block mapping in extent status tree with
|
|
|
|
* out taking i_data_sem. So at the time the unwritten extent
|
|
|
|
* could be converted.
|
|
|
|
*/
|
2015-12-07 21:04:57 +01:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2013-03-11 02:01:03 +01:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
|
|
|
|
retval = ext4_ext_map_blocks(handle, inode, map, flags &
|
|
|
|
EXT4_GET_BLOCKS_KEEP_SIZE);
|
|
|
|
} else {
|
|
|
|
retval = ext4_ind_map_blocks(handle, inode, map, flags &
|
|
|
|
EXT4_GET_BLOCKS_KEEP_SIZE);
|
|
|
|
}
|
2015-12-07 21:04:57 +01:00
|
|
|
up_read((&EXT4_I(inode)->i_data_sem));
|
2013-03-11 02:01:03 +01:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We don't check m_len because extent will be collpased in status
|
|
|
|
* tree. So the m_len might not equal.
|
|
|
|
*/
|
|
|
|
if (es_map->m_lblk != map->m_lblk ||
|
|
|
|
es_map->m_flags != map->m_flags ||
|
|
|
|
es_map->m_pblk != map->m_pblk) {
|
2013-07-13 06:40:31 +02:00
|
|
|
printk("ES cache assertion failed for inode: %lu "
|
2013-03-11 02:01:03 +01:00
|
|
|
"es_cached ex [%d/%d/%llu/%x] != "
|
|
|
|
"found ex [%d/%d/%llu/%x] retval %d flags %x\n",
|
|
|
|
inode->i_ino, es_map->m_lblk, es_map->m_len,
|
|
|
|
es_map->m_pblk, es_map->m_flags, map->m_lblk,
|
|
|
|
map->m_len, map->m_pblk, map->m_flags,
|
|
|
|
retval, flags);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
#endif /* ES_AGGRESSIVE_TEST */
|
|
|
|
|
2008-02-25 21:29:55 +01:00
|
|
|
/*
|
2010-05-17 01:00:00 +02:00
|
|
|
* The ext4_map_blocks() function tries to look up the requested blocks,
|
2008-07-26 22:15:44 +02:00
|
|
|
* and returns if the blocks are already mapped.
|
2008-02-25 21:29:55 +01:00
|
|
|
*
|
|
|
|
* Otherwise it takes the write lock of the i_data_sem and allocate blocks
|
|
|
|
* and store the allocated blocks in the result buffer head and mark it
|
|
|
|
* mapped.
|
|
|
|
*
|
2010-05-17 01:00:00 +02:00
|
|
|
* If file type is extents based, it will call ext4_ext_map_blocks(),
|
|
|
|
* Otherwise, call with ext4_ind_map_blocks() to handle indirect mapping
|
2008-02-25 21:29:55 +01:00
|
|
|
* based files
|
|
|
|
*
|
2014-04-21 05:45:47 +02:00
|
|
|
* On success, it returns the number of blocks being mapped or allocated.
|
|
|
|
* if create==0 and the blocks are pre-allocated and unwritten block,
|
2008-02-25 21:29:55 +01:00
|
|
|
* the result buffer head is unmapped. If the create ==1, it will make sure
|
|
|
|
* the buffer head is mapped.
|
|
|
|
*
|
|
|
|
* It returns 0 if plain look up failed (blocks have not been allocated), in
|
2011-10-08 21:53:49 +02:00
|
|
|
* that case, buffer head is unmapped
|
2008-02-25 21:29:55 +01:00
|
|
|
*
|
|
|
|
* It returns the error in case of allocation failure.
|
|
|
|
*/
|
2010-05-17 01:00:00 +02:00
|
|
|
int ext4_map_blocks(handle_t *handle, struct inode *inode,
|
|
|
|
struct ext4_map_blocks *map, int flags)
|
2008-01-29 05:58:26 +01:00
|
|
|
{
|
2013-02-18 06:29:59 +01:00
|
|
|
struct extent_status es;
|
2008-01-29 05:58:26 +01:00
|
|
|
int retval;
|
2014-03-18 23:05:35 +01:00
|
|
|
int ret = 0;
|
2013-03-11 02:01:03 +01:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
struct ext4_map_blocks orig_map;
|
|
|
|
|
|
|
|
memcpy(&orig_map, map, sizeof(*map));
|
|
|
|
#endif
|
2008-02-25 21:29:55 +01:00
|
|
|
|
2010-05-17 01:00:00 +02:00
|
|
|
map->m_flags = 0;
|
|
|
|
ext_debug("ext4_map_blocks(): inode %lu, flag %d, max_blocks %u,"
|
|
|
|
"logical block %lu\n", inode->i_ino, flags, map->m_len,
|
|
|
|
(unsigned long) map->m_lblk);
|
2013-02-18 06:29:59 +01:00
|
|
|
|
ext4: avoid possible overflow in ext4_map_blocks()
The ext4_map_blocks() function returns the number of blocks which
satisfying the caller's request. This number of blocks requested by
the caller is specified by an unsigned integer, but the return value
of ext4_map_blocks() is a signed integer (to accomodate error codes
per the kernel's standard error signalling convention).
Historically, overflows could never happen since mballoc() will refuse
to allocate more than 2048 blocks at a time (which is something we
should fix), and if the blocks were already allocated, the fact that
there would be some number of intervening metadata blocks pretty much
guaranteed that there could never be a contiguous region of data
blocks that was greater than 2**31 blocks.
However, this is now possible if there is a file system which is a bit
bigger than 8TB, and is created using the new mke2fs hugeblock
feature, which can create a perfectly contiguous file. In that case,
if a userspace program attempted to call fallocate() on this already
fully allocated file, it's possible that ext4_map_blocks() could
return a number large enough that it would overflow a signed integer,
resulting in a ext4 thinking that the ext4_map_blocks() call had
failed with some strange error code.
Since ext4_map_blocks() is always free to return a smaller number of
blocks than what was requested by the caller, fix this by capping the
number of blocks that ext4_map_blocks() will ever try to map to 2**31
- 1. In practice this should never get hit, except by someone
deliberately trying to provke the above-described bug.
Thanks to the PaX team for asking whethre this could possibly happen
in some off-line discussions about using some static code checking
technology they are developing to find bugs in kernel code.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2014-02-20 18:54:05 +01:00
|
|
|
/*
|
|
|
|
* ext4_map_blocks returns an int, and m_len is an unsigned int
|
|
|
|
*/
|
|
|
|
if (unlikely(map->m_len > INT_MAX))
|
|
|
|
map->m_len = INT_MAX;
|
|
|
|
|
2014-04-07 16:53:28 +02:00
|
|
|
/* We can handle the block number less than EXT_MAX_BLOCKS */
|
|
|
|
if (unlikely(map->m_lblk >= EXT_MAX_BLOCKS))
|
2015-10-17 22:16:04 +02:00
|
|
|
return -EFSCORRUPTED;
|
2014-04-07 16:53:28 +02:00
|
|
|
|
2013-02-18 06:29:59 +01:00
|
|
|
/* Lookup extent status tree firstly */
|
|
|
|
if (ext4_es_lookup_extent(inode, map->m_lblk, &es)) {
|
|
|
|
if (ext4_es_is_written(&es) || ext4_es_is_unwritten(&es)) {
|
|
|
|
map->m_pblk = ext4_es_pblock(&es) +
|
|
|
|
map->m_lblk - es.es_lblk;
|
|
|
|
map->m_flags |= ext4_es_is_written(&es) ?
|
|
|
|
EXT4_MAP_MAPPED : EXT4_MAP_UNWRITTEN;
|
|
|
|
retval = es.es_len - (map->m_lblk - es.es_lblk);
|
|
|
|
if (retval > map->m_len)
|
|
|
|
retval = map->m_len;
|
|
|
|
map->m_len = retval;
|
|
|
|
} else if (ext4_es_is_delayed(&es) || ext4_es_is_hole(&es)) {
|
|
|
|
retval = 0;
|
|
|
|
} else {
|
|
|
|
BUG_ON(1);
|
|
|
|
}
|
2013-03-11 02:01:03 +01:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
ext4_map_blocks_es_recheck(handle, inode, map,
|
|
|
|
&orig_map, flags);
|
|
|
|
#endif
|
2013-02-18 06:29:59 +01:00
|
|
|
goto found;
|
|
|
|
}
|
|
|
|
|
2008-01-29 05:58:29 +01:00
|
|
|
/*
|
2009-05-14 06:54:29 +02:00
|
|
|
* Try to see if we can get the block without requesting a new
|
|
|
|
* file system block.
|
2008-01-29 05:58:29 +01:00
|
|
|
*/
|
2015-12-07 21:04:57 +01:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2010-05-17 04:00:00 +02:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
|
2011-10-25 14:15:12 +02:00
|
|
|
retval = ext4_ext_map_blocks(handle, inode, map, flags &
|
|
|
|
EXT4_GET_BLOCKS_KEEP_SIZE);
|
2008-01-29 05:58:26 +01:00
|
|
|
} else {
|
2011-10-25 14:15:12 +02:00
|
|
|
retval = ext4_ind_map_blocks(handle, inode, map, flags &
|
|
|
|
EXT4_GET_BLOCKS_KEEP_SIZE);
|
2008-01-29 05:58:26 +01:00
|
|
|
}
|
2013-02-18 06:28:47 +01:00
|
|
|
if (retval > 0) {
|
2013-08-17 03:22:41 +02:00
|
|
|
unsigned int status;
|
2013-02-18 06:28:47 +01:00
|
|
|
|
2013-07-29 18:51:42 +02:00
|
|
|
if (unlikely(retval != map->m_len)) {
|
|
|
|
ext4_warning(inode->i_sb,
|
|
|
|
"ES len assertion failed for inode "
|
|
|
|
"%lu: retval %d != map->m_len %d",
|
|
|
|
inode->i_ino, retval, map->m_len);
|
|
|
|
WARN_ON(1);
|
2013-03-11 02:01:03 +01:00
|
|
|
}
|
|
|
|
|
2013-02-18 06:28:47 +01:00
|
|
|
status = map->m_flags & EXT4_MAP_UNWRITTEN ?
|
|
|
|
EXTENT_STATUS_UNWRITTEN : EXTENT_STATUS_WRITTEN;
|
|
|
|
if (!(flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE) &&
|
2015-05-03 03:36:55 +02:00
|
|
|
!(status & EXTENT_STATUS_WRITTEN) &&
|
2013-02-18 06:28:47 +01:00
|
|
|
ext4_find_delalloc_range(inode, map->m_lblk,
|
|
|
|
map->m_lblk + map->m_len - 1))
|
|
|
|
status |= EXTENT_STATUS_DELAYED;
|
|
|
|
ret = ext4_es_insert_extent(inode, map->m_lblk,
|
|
|
|
map->m_len, map->m_pblk, status);
|
|
|
|
if (ret < 0)
|
|
|
|
retval = ret;
|
|
|
|
}
|
2015-12-07 21:04:57 +01:00
|
|
|
up_read((&EXT4_I(inode)->i_data_sem));
|
2008-02-25 21:29:55 +01:00
|
|
|
|
2013-02-18 06:29:59 +01:00
|
|
|
found:
|
2010-05-17 01:00:00 +02:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED) {
|
2014-03-18 23:05:35 +01:00
|
|
|
ret = check_block_validity(inode, map);
|
2009-05-17 21:38:01 +02:00
|
|
|
if (ret != 0)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-02-25 21:29:55 +01:00
|
|
|
/* If it is only a block(s) look up */
|
2009-05-14 06:58:52 +02:00
|
|
|
if ((flags & EXT4_GET_BLOCKS_CREATE) == 0)
|
2008-02-25 21:29:55 +01:00
|
|
|
return retval;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Returns if the blocks have already allocated
|
|
|
|
*
|
|
|
|
* Note that if blocks have been preallocated
|
2011-10-08 21:53:49 +02:00
|
|
|
* ext4_ext_get_block() returns the create = 0
|
2008-02-25 21:29:55 +01:00
|
|
|
* with buffer head unmapped.
|
|
|
|
*/
|
2010-05-17 01:00:00 +02:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED)
|
2014-03-18 23:05:35 +01:00
|
|
|
/*
|
|
|
|
* If we need to convert extent to unwritten
|
|
|
|
* we continue and do the actual work in
|
|
|
|
* ext4_ext_map_blocks()
|
|
|
|
*/
|
|
|
|
if (!(flags & EXT4_GET_BLOCKS_CONVERT_UNWRITTEN))
|
|
|
|
return retval;
|
2008-01-29 05:58:29 +01:00
|
|
|
|
2009-05-14 23:05:39 +02:00
|
|
|
/*
|
2013-02-18 06:28:04 +01:00
|
|
|
* Here we clear m_flags because after allocating an new extent,
|
|
|
|
* it will be set again.
|
2009-05-14 23:05:39 +02:00
|
|
|
*/
|
2013-02-18 06:28:04 +01:00
|
|
|
map->m_flags &= ~EXT4_MAP_FLAGS;
|
2009-05-14 23:05:39 +02:00
|
|
|
|
2008-01-29 05:58:29 +01:00
|
|
|
/*
|
2014-04-21 05:45:47 +02:00
|
|
|
* New blocks allocate and/or writing to unwritten extent
|
2008-02-25 21:29:55 +01:00
|
|
|
* will possibly result in updating i_data, so we take
|
2014-09-02 04:15:30 +02:00
|
|
|
* the write lock of i_data_sem, and call get_block()
|
2008-02-25 21:29:55 +01:00
|
|
|
* with create == 1 flag.
|
2008-01-29 05:58:29 +01:00
|
|
|
*/
|
2014-05-12 18:55:07 +02:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2008-07-14 23:52:37 +02:00
|
|
|
|
2008-01-29 05:58:29 +01:00
|
|
|
/*
|
|
|
|
* We need to check for EXT4 here because migrate
|
|
|
|
* could have changed the inode type in between
|
|
|
|
*/
|
2010-05-17 04:00:00 +02:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
|
2010-05-17 01:00:00 +02:00
|
|
|
retval = ext4_ext_map_blocks(handle, inode, map, flags);
|
2008-01-29 05:58:26 +01:00
|
|
|
} else {
|
2010-05-17 01:00:00 +02:00
|
|
|
retval = ext4_ind_map_blocks(handle, inode, map, flags);
|
2008-04-29 14:11:12 +02:00
|
|
|
|
2010-05-17 01:00:00 +02:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_NEW) {
|
2008-04-29 14:11:12 +02:00
|
|
|
/*
|
|
|
|
* We allocated new blocks which will result in
|
|
|
|
* i_data's format changing. Force the migrate
|
|
|
|
* to fail by clearing migrate flags
|
|
|
|
*/
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_EXT_MIGRATE);
|
2008-04-29 14:11:12 +02:00
|
|
|
}
|
2008-07-14 23:52:37 +02:00
|
|
|
|
2010-01-25 10:00:31 +01:00
|
|
|
/*
|
|
|
|
* Update reserved blocks/metadata blocks after successful
|
|
|
|
* block allocation which had been deferred till now. We don't
|
|
|
|
* support fallocate for non extent files. So we can update
|
|
|
|
* reserve space here.
|
|
|
|
*/
|
|
|
|
if ((retval > 0) &&
|
2010-01-15 07:27:59 +01:00
|
|
|
(flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE))
|
2010-01-25 10:00:31 +01:00
|
|
|
ext4_da_update_reserve_space(inode, retval, 1);
|
|
|
|
}
|
2009-05-14 19:57:08 +02:00
|
|
|
|
2013-02-18 06:28:47 +01:00
|
|
|
if (retval > 0) {
|
2013-08-17 03:22:41 +02:00
|
|
|
unsigned int status;
|
2013-02-18 06:28:47 +01:00
|
|
|
|
2013-07-29 18:51:42 +02:00
|
|
|
if (unlikely(retval != map->m_len)) {
|
|
|
|
ext4_warning(inode->i_sb,
|
|
|
|
"ES len assertion failed for inode "
|
|
|
|
"%lu: retval %d != map->m_len %d",
|
|
|
|
inode->i_ino, retval, map->m_len);
|
|
|
|
WARN_ON(1);
|
2013-03-11 02:01:03 +01:00
|
|
|
}
|
|
|
|
|
2015-12-07 21:10:26 +01:00
|
|
|
/*
|
|
|
|
* We have to zeroout blocks before inserting them into extent
|
|
|
|
* status tree. Otherwise someone could look them up there and
|
|
|
|
* use them before they are really zeroed.
|
|
|
|
*/
|
|
|
|
if (flags & EXT4_GET_BLOCKS_ZERO &&
|
|
|
|
map->m_flags & EXT4_MAP_MAPPED &&
|
|
|
|
map->m_flags & EXT4_MAP_NEW) {
|
|
|
|
ret = ext4_issue_zeroout(inode, map->m_lblk,
|
|
|
|
map->m_pblk, map->m_len);
|
|
|
|
if (ret) {
|
|
|
|
retval = ret;
|
|
|
|
goto out_sem;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-03-11 02:13:05 +01:00
|
|
|
/*
|
|
|
|
* If the extent has been zeroed out, we don't need to update
|
|
|
|
* extent status tree.
|
|
|
|
*/
|
|
|
|
if ((flags & EXT4_GET_BLOCKS_PRE_IO) &&
|
|
|
|
ext4_es_lookup_extent(inode, map->m_lblk, &es)) {
|
|
|
|
if (ext4_es_is_written(&es))
|
2015-12-07 21:10:26 +01:00
|
|
|
goto out_sem;
|
2013-03-11 02:13:05 +01:00
|
|
|
}
|
2013-02-18 06:28:47 +01:00
|
|
|
status = map->m_flags & EXT4_MAP_UNWRITTEN ?
|
|
|
|
EXTENT_STATUS_UNWRITTEN : EXTENT_STATUS_WRITTEN;
|
|
|
|
if (!(flags & EXT4_GET_BLOCKS_DELALLOC_RESERVE) &&
|
2015-05-03 03:36:55 +02:00
|
|
|
!(status & EXTENT_STATUS_WRITTEN) &&
|
2013-02-18 06:28:47 +01:00
|
|
|
ext4_find_delalloc_range(inode, map->m_lblk,
|
|
|
|
map->m_lblk + map->m_len - 1))
|
|
|
|
status |= EXTENT_STATUS_DELAYED;
|
|
|
|
ret = ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
|
|
|
|
map->m_pblk, status);
|
2015-12-07 21:10:26 +01:00
|
|
|
if (ret < 0) {
|
2013-02-18 06:28:47 +01:00
|
|
|
retval = ret;
|
2015-12-07 21:10:26 +01:00
|
|
|
goto out_sem;
|
|
|
|
}
|
2011-09-10 01:20:51 +02:00
|
|
|
}
|
|
|
|
|
2015-12-07 21:10:26 +01:00
|
|
|
out_sem:
|
2008-01-29 05:58:29 +01:00
|
|
|
up_write((&EXT4_I(inode)->i_data_sem));
|
2010-05-17 01:00:00 +02:00
|
|
|
if (retval > 0 && map->m_flags & EXT4_MAP_MAPPED) {
|
2014-03-18 23:05:35 +01:00
|
|
|
ret = check_block_validity(inode, map);
|
2009-05-17 21:38:01 +02:00
|
|
|
if (ret != 0)
|
|
|
|
return ret;
|
|
|
|
}
|
2008-01-29 05:58:26 +01:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-08-20 04:16:03 +02:00
|
|
|
/* Maximum number of blocks we map for direct IO at once. */
|
|
|
|
#define DIO_MAX_BLOCKS 4096
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
static int _ext4_get_block(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int flags)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2007-02-10 10:46:35 +01:00
|
|
|
handle_t *handle = ext4_journal_current_handle();
|
2010-05-17 02:00:00 +02:00
|
|
|
struct ext4_map_blocks map;
|
2008-02-10 07:08:38 +01:00
|
|
|
int ret = 0, started = 0;
|
2008-08-20 04:16:03 +02:00
|
|
|
int dio_credits;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2012-12-10 20:04:52 +01:00
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return -ERANGE;
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
map.m_lblk = iblock;
|
|
|
|
map.m_len = bh->b_size >> inode->i_blkbits;
|
|
|
|
|
2015-12-07 21:04:57 +01:00
|
|
|
if (flags && !handle) {
|
2008-02-10 07:08:38 +01:00
|
|
|
/* Direct IO write... */
|
2010-05-17 02:00:00 +02:00
|
|
|
if (map.m_len > DIO_MAX_BLOCKS)
|
|
|
|
map.m_len = DIO_MAX_BLOCKS;
|
|
|
|
dio_credits = ext4_chunk_trans_blocks(inode, map.m_len);
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_MAP_BLOCKS,
|
|
|
|
dio_credits);
|
2008-02-10 07:08:38 +01:00
|
|
|
if (IS_ERR(handle)) {
|
2006-10-11 10:20:50 +02:00
|
|
|
ret = PTR_ERR(handle);
|
2010-05-17 02:00:00 +02:00
|
|
|
return ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2008-02-10 07:08:38 +01:00
|
|
|
started = 1;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
ret = ext4_map_blocks(handle, inode, &map, flags);
|
2008-02-10 07:08:38 +01:00
|
|
|
if (ret > 0) {
|
2013-09-04 15:04:39 +02:00
|
|
|
ext4_io_end_t *io_end = ext4_inode_aio(inode);
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
map_bh(bh, inode->i_sb, map.m_pblk);
|
|
|
|
bh->b_state = (bh->b_state & ~EXT4_MAP_FLAGS) | map.m_flags;
|
2013-09-04 15:04:39 +02:00
|
|
|
if (io_end && io_end->flag & EXT4_IO_END_UNWRITTEN)
|
|
|
|
set_buffer_defer_completion(bh);
|
2010-05-17 02:00:00 +02:00
|
|
|
bh->b_size = inode->i_sb->s_blocksize * map.m_len;
|
2008-02-10 07:08:38 +01:00
|
|
|
ret = 0;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2008-02-10 07:08:38 +01:00
|
|
|
if (started)
|
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
int ext4_get_block(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int create)
|
|
|
|
{
|
|
|
|
return _ext4_get_block(inode, iblock, bh,
|
|
|
|
create ? EXT4_GET_BLOCKS_CREATE : 0);
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* `handle' can be NULL if create is zero
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
struct buffer_head *ext4_getblk(handle_t *handle, struct inode *inode,
|
2015-06-21 07:25:29 +02:00
|
|
|
ext4_lblk_t block, int map_flags)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2010-05-17 02:00:00 +02:00
|
|
|
struct ext4_map_blocks map;
|
|
|
|
struct buffer_head *bh;
|
2015-06-21 07:25:29 +02:00
|
|
|
int create = map_flags & EXT4_GET_BLOCKS_CREATE;
|
2014-08-30 02:51:32 +02:00
|
|
|
int err;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
J_ASSERT(handle != NULL || create == 0);
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
map.m_lblk = block;
|
|
|
|
map.m_len = 1;
|
2015-06-21 07:25:29 +02:00
|
|
|
err = ext4_map_blocks(handle, inode, &map, map_flags);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2014-08-30 02:51:32 +02:00
|
|
|
if (err == 0)
|
|
|
|
return create ? ERR_PTR(-ENOSPC) : NULL;
|
2010-05-17 02:00:00 +02:00
|
|
|
if (err < 0)
|
2014-08-30 02:51:32 +02:00
|
|
|
return ERR_PTR(err);
|
2010-05-17 02:00:00 +02:00
|
|
|
|
|
|
|
bh = sb_getblk(inode->i_sb, map.m_pblk);
|
2014-08-30 02:51:32 +02:00
|
|
|
if (unlikely(!bh))
|
|
|
|
return ERR_PTR(-ENOMEM);
|
2010-05-17 02:00:00 +02:00
|
|
|
if (map.m_flags & EXT4_MAP_NEW) {
|
|
|
|
J_ASSERT(create != 0);
|
|
|
|
J_ASSERT(handle != NULL);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
/*
|
|
|
|
* Now that we do not always journal data, we should
|
|
|
|
* keep in mind whether this should always journal the
|
|
|
|
* new buffer as metadata. For now, regular file
|
|
|
|
* writes use ext4_get_block instead, so it's not a
|
|
|
|
* problem.
|
|
|
|
*/
|
|
|
|
lock_buffer(bh);
|
|
|
|
BUFFER_TRACE(bh, "call get_create_access");
|
2014-08-30 02:51:32 +02:00
|
|
|
err = ext4_journal_get_create_access(handle, bh);
|
|
|
|
if (unlikely(err)) {
|
|
|
|
unlock_buffer(bh);
|
|
|
|
goto errout;
|
|
|
|
}
|
|
|
|
if (!buffer_uptodate(bh)) {
|
2010-05-17 02:00:00 +02:00
|
|
|
memset(bh->b_data, 0, inode->i_sb->s_blocksize);
|
|
|
|
set_buffer_uptodate(bh);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2010-05-17 02:00:00 +02:00
|
|
|
unlock_buffer(bh);
|
|
|
|
BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata");
|
|
|
|
err = ext4_handle_dirty_metadata(handle, inode, bh);
|
2014-08-30 02:51:32 +02:00
|
|
|
if (unlikely(err))
|
|
|
|
goto errout;
|
|
|
|
} else
|
2010-05-17 02:00:00 +02:00
|
|
|
BUFFER_TRACE(bh, "not a new buffer");
|
|
|
|
return bh;
|
2014-08-30 02:51:32 +02:00
|
|
|
errout:
|
|
|
|
brelse(bh);
|
|
|
|
return ERR_PTR(err);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
struct buffer_head *ext4_bread(handle_t *handle, struct inode *inode,
|
2015-06-21 07:25:29 +02:00
|
|
|
ext4_lblk_t block, int map_flags)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2008-09-09 04:25:24 +02:00
|
|
|
struct buffer_head *bh;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2015-06-21 07:25:29 +02:00
|
|
|
bh = ext4_getblk(handle, inode, block, map_flags);
|
2014-08-30 02:52:15 +02:00
|
|
|
if (IS_ERR(bh))
|
2006-10-11 10:20:50 +02:00
|
|
|
return bh;
|
2014-08-30 02:52:15 +02:00
|
|
|
if (!bh || buffer_uptodate(bh))
|
2006-10-11 10:20:50 +02:00
|
|
|
return bh;
|
2011-08-23 14:50:29 +02:00
|
|
|
ll_rw_block(READ | REQ_META | REQ_PRIO, 1, &bh);
|
2006-10-11 10:20:50 +02:00
|
|
|
wait_on_buffer(bh);
|
|
|
|
if (buffer_uptodate(bh))
|
|
|
|
return bh;
|
|
|
|
put_bh(bh);
|
2014-08-30 02:52:15 +02:00
|
|
|
return ERR_PTR(-EIO);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2012-12-10 20:05:51 +01:00
|
|
|
int ext4_walk_page_buffers(handle_t *handle,
|
|
|
|
struct buffer_head *head,
|
|
|
|
unsigned from,
|
|
|
|
unsigned to,
|
|
|
|
int *partial,
|
|
|
|
int (*fn)(handle_t *handle,
|
|
|
|
struct buffer_head *bh))
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
struct buffer_head *bh;
|
|
|
|
unsigned block_start, block_end;
|
|
|
|
unsigned blocksize = head->b_size;
|
|
|
|
int err, ret = 0;
|
|
|
|
struct buffer_head *next;
|
|
|
|
|
2008-09-09 04:25:24 +02:00
|
|
|
for (bh = head, block_start = 0;
|
|
|
|
ret == 0 && (bh != head || !block_start);
|
2009-06-14 23:45:34 +02:00
|
|
|
block_start = block_end, bh = next) {
|
2006-10-11 10:20:50 +02:00
|
|
|
next = bh->b_this_page;
|
|
|
|
block_end = block_start + blocksize;
|
|
|
|
if (block_end <= from || block_start >= to) {
|
|
|
|
if (partial && !buffer_uptodate(bh))
|
|
|
|
*partial = 1;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
err = (*fn)(handle, bh);
|
|
|
|
if (!ret)
|
|
|
|
ret = err;
|
|
|
|
}
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* To preserve ordering, it is essential that the hole instantiation and
|
|
|
|
* the data write be encapsulated in a single transaction. We cannot
|
2006-10-11 10:20:53 +02:00
|
|
|
* close off a transaction and start a new one between the ext4_get_block()
|
2006-10-11 10:21:01 +02:00
|
|
|
* and the commit_write(). So doing the jbd2_journal_start at the start of
|
2006-10-11 10:20:50 +02:00
|
|
|
* prepare_write() is the right place.
|
|
|
|
*
|
2013-01-28 15:30:52 +01:00
|
|
|
* Also, this function can nest inside ext4_writepage(). In that case, we
|
|
|
|
* *know* that ext4_writepage() has generated enough buffer credits to do the
|
|
|
|
* whole page. So we won't block on the journal in that case, which is good,
|
|
|
|
* because the caller may be PF_MEMALLOC.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
2006-10-11 10:20:53 +02:00
|
|
|
* By accident, ext4 can be reentered when a transaction is open via
|
2006-10-11 10:20:50 +02:00
|
|
|
* quota file writes. If we were to commit the transaction while thus
|
|
|
|
* reentered, there can be a deadlock - we would be holding a quota
|
|
|
|
* lock, and the commit would never complete if another thread had a
|
|
|
|
* transaction open and was blocking on the quota lock - a ranking
|
|
|
|
* violation.
|
|
|
|
*
|
2006-10-11 10:21:01 +02:00
|
|
|
* So what we do is to rely on the fact that jbd2_journal_stop/journal_start
|
2006-10-11 10:20:50 +02:00
|
|
|
* will _not_ run commit under these circumstances because handle->h_ref
|
|
|
|
* is elevated. We'll still have enough credits for the tiny quotafile
|
|
|
|
* write.
|
|
|
|
*/
|
2012-12-10 20:05:51 +01:00
|
|
|
int do_journal_get_write_access(handle_t *handle,
|
|
|
|
struct buffer_head *bh)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2010-08-05 20:41:42 +02:00
|
|
|
int dirty = buffer_dirty(bh);
|
|
|
|
int ret;
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!buffer_mapped(bh) || buffer_freed(bh))
|
|
|
|
return 0;
|
2010-08-05 20:41:42 +02:00
|
|
|
/*
|
2010-10-06 10:47:23 +02:00
|
|
|
* __block_write_begin() could have dirtied some buffers. Clean
|
2010-08-05 20:41:42 +02:00
|
|
|
* the dirty bit as jbd2_journal_get_write_access() could complain
|
|
|
|
* otherwise about fs integrity issues. Setting of the dirty bit
|
2010-10-06 10:47:23 +02:00
|
|
|
* by __block_write_begin() isn't a real problem here as we clear
|
2010-08-05 20:41:42 +02:00
|
|
|
* the bit before releasing a page lock and thus writeback cannot
|
|
|
|
* ever write the buffer.
|
|
|
|
*/
|
|
|
|
if (dirty)
|
|
|
|
clear_buffer_dirty(bh);
|
2014-05-13 04:06:43 +02:00
|
|
|
BUFFER_TRACE(bh, "get write access");
|
2010-08-05 20:41:42 +02:00
|
|
|
ret = ext4_journal_get_write_access(handle, bh);
|
|
|
|
if (!ret && dirty)
|
|
|
|
ret = ext4_handle_dirty_metadata(handle, NULL, bh);
|
|
|
|
return ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2015-04-12 06:55:10 +02:00
|
|
|
#ifdef CONFIG_EXT4_FS_ENCRYPTION
|
|
|
|
static int ext4_block_write_begin(struct page *page, loff_t pos, unsigned len,
|
|
|
|
get_block_t *get_block)
|
|
|
|
{
|
|
|
|
unsigned from = pos & (PAGE_CACHE_SIZE - 1);
|
|
|
|
unsigned to = from + len;
|
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
unsigned block_start, block_end;
|
|
|
|
sector_t block;
|
|
|
|
int err = 0;
|
|
|
|
unsigned blocksize = inode->i_sb->s_blocksize;
|
|
|
|
unsigned bbits;
|
|
|
|
struct buffer_head *bh, *head, *wait[2], **wait_bh = wait;
|
|
|
|
bool decrypt = false;
|
|
|
|
|
|
|
|
BUG_ON(!PageLocked(page));
|
|
|
|
BUG_ON(from > PAGE_CACHE_SIZE);
|
|
|
|
BUG_ON(to > PAGE_CACHE_SIZE);
|
|
|
|
BUG_ON(from > to);
|
|
|
|
|
|
|
|
if (!page_has_buffers(page))
|
|
|
|
create_empty_buffers(page, blocksize, 0);
|
|
|
|
head = page_buffers(page);
|
|
|
|
bbits = ilog2(blocksize);
|
|
|
|
block = (sector_t)page->index << (PAGE_CACHE_SHIFT - bbits);
|
|
|
|
|
|
|
|
for (bh = head, block_start = 0; bh != head || !block_start;
|
|
|
|
block++, block_start = block_end, bh = bh->b_this_page) {
|
|
|
|
block_end = block_start + blocksize;
|
|
|
|
if (block_end <= from || block_start >= to) {
|
|
|
|
if (PageUptodate(page)) {
|
|
|
|
if (!buffer_uptodate(bh))
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
}
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (buffer_new(bh))
|
|
|
|
clear_buffer_new(bh);
|
|
|
|
if (!buffer_mapped(bh)) {
|
|
|
|
WARN_ON(bh->b_size != blocksize);
|
|
|
|
err = get_block(inode, block, bh, 1);
|
|
|
|
if (err)
|
|
|
|
break;
|
|
|
|
if (buffer_new(bh)) {
|
|
|
|
unmap_underlying_metadata(bh->b_bdev,
|
|
|
|
bh->b_blocknr);
|
|
|
|
if (PageUptodate(page)) {
|
|
|
|
clear_buffer_new(bh);
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
mark_buffer_dirty(bh);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (block_end > to || block_start < from)
|
|
|
|
zero_user_segments(page, to, block_end,
|
|
|
|
block_start, from);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (PageUptodate(page)) {
|
|
|
|
if (!buffer_uptodate(bh))
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
|
|
|
|
!buffer_unwritten(bh) &&
|
|
|
|
(block_start < from || block_end > to)) {
|
|
|
|
ll_rw_block(READ, 1, &bh);
|
|
|
|
*wait_bh++ = bh;
|
|
|
|
decrypt = ext4_encrypted_inode(inode) &&
|
|
|
|
S_ISREG(inode->i_mode);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
/*
|
|
|
|
* If we issued read requests, let them complete.
|
|
|
|
*/
|
|
|
|
while (wait_bh > wait) {
|
|
|
|
wait_on_buffer(*--wait_bh);
|
|
|
|
if (!buffer_uptodate(*wait_bh))
|
|
|
|
err = -EIO;
|
|
|
|
}
|
|
|
|
if (unlikely(err))
|
|
|
|
page_zero_new_buffers(page, from, to);
|
|
|
|
else if (decrypt)
|
2015-10-03 16:49:26 +02:00
|
|
|
err = ext4_decrypt(page);
|
2015-04-12 06:55:10 +02:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2007-10-16 10:25:05 +02:00
|
|
|
static int ext4_write_begin(struct file *file, struct address_space *mapping,
|
2009-06-14 23:45:34 +02:00
|
|
|
loff_t pos, unsigned len, unsigned flags,
|
|
|
|
struct page **pagep, void **fsdata)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2008-09-09 04:25:24 +02:00
|
|
|
struct inode *inode = mapping->host;
|
2009-06-05 07:00:26 +02:00
|
|
|
int ret, needed_blocks;
|
2006-10-11 10:20:50 +02:00
|
|
|
handle_t *handle;
|
|
|
|
int retries = 0;
|
2008-09-09 04:25:24 +02:00
|
|
|
struct page *page;
|
2009-06-14 23:45:34 +02:00
|
|
|
pgoff_t index;
|
2008-09-09 04:25:24 +02:00
|
|
|
unsigned from, to;
|
2007-10-16 10:25:05 +02:00
|
|
|
|
2009-06-17 17:48:11 +02:00
|
|
|
trace_ext4_write_begin(inode, pos, len, flags);
|
2009-06-05 07:00:26 +02:00
|
|
|
/*
|
|
|
|
* Reserve one block more for addition to orphan list in case
|
|
|
|
* we allocate blocks but write fails for some reason
|
|
|
|
*/
|
|
|
|
needed_blocks = ext4_writepage_trans_blocks(inode) + 1;
|
2009-06-14 23:45:34 +02:00
|
|
|
index = pos >> PAGE_CACHE_SHIFT;
|
2008-09-09 04:25:24 +02:00
|
|
|
from = pos & (PAGE_CACHE_SIZE - 1);
|
|
|
|
to = from + len;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2012-12-10 20:05:51 +01:00
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
|
|
|
|
ret = ext4_try_to_write_inline_data(mapping, inode, pos, len,
|
|
|
|
flags, pagep);
|
|
|
|
if (ret < 0)
|
2013-02-09 15:24:14 +01:00
|
|
|
return ret;
|
|
|
|
if (ret == 1)
|
|
|
|
return 0;
|
2012-12-10 20:05:51 +01:00
|
|
|
}
|
|
|
|
|
2013-02-09 15:24:14 +01:00
|
|
|
/*
|
|
|
|
* grab_cache_page_write_begin() can take a long time if the
|
|
|
|
* system is thrashing due to memory pressure, or if the page
|
|
|
|
* is being written back. So grab it first before we start
|
|
|
|
* the transaction handle. This also allows us to allocate
|
|
|
|
* the page (if needed) without using GFP_NOFS.
|
|
|
|
*/
|
|
|
|
retry_grab:
|
|
|
|
page = grab_cache_page_write_begin(mapping, index, flags);
|
|
|
|
if (!page)
|
|
|
|
return -ENOMEM;
|
|
|
|
unlock_page(page);
|
|
|
|
|
|
|
|
retry_journal:
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE, needed_blocks);
|
2008-09-09 04:25:24 +02:00
|
|
|
if (IS_ERR(handle)) {
|
2013-02-09 15:24:14 +01:00
|
|
|
page_cache_release(page);
|
|
|
|
return PTR_ERR(handle);
|
2007-04-02 08:49:44 +02:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2013-02-09 15:24:14 +01:00
|
|
|
lock_page(page);
|
|
|
|
if (page->mapping != mapping) {
|
|
|
|
/* The page got truncated from under us */
|
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
2008-07-12 01:27:31 +02:00
|
|
|
ext4_journal_stop(handle);
|
2013-02-09 15:24:14 +01:00
|
|
|
goto retry_grab;
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
2013-08-28 20:30:47 +02:00
|
|
|
/* In case writeback began while the page was unlocked */
|
|
|
|
wait_for_stable_page(page);
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2015-04-12 06:55:10 +02:00
|
|
|
#ifdef CONFIG_EXT4_FS_ENCRYPTION
|
|
|
|
if (ext4_should_dioread_nolock(inode))
|
|
|
|
ret = ext4_block_write_begin(page, pos, len,
|
|
|
|
ext4_get_block_write);
|
|
|
|
else
|
|
|
|
ret = ext4_block_write_begin(page, pos, len,
|
|
|
|
ext4_get_block);
|
|
|
|
#else
|
2010-03-04 22:14:02 +01:00
|
|
|
if (ext4_should_dioread_nolock(inode))
|
2010-06-04 11:29:57 +02:00
|
|
|
ret = __block_write_begin(page, pos, len, ext4_get_block_write);
|
2010-03-04 22:14:02 +01:00
|
|
|
else
|
2010-06-04 11:29:57 +02:00
|
|
|
ret = __block_write_begin(page, pos, len, ext4_get_block);
|
2015-04-12 06:55:10 +02:00
|
|
|
#endif
|
2007-10-16 10:25:05 +02:00
|
|
|
if (!ret && ext4_should_journal_data(inode)) {
|
2012-12-10 20:05:51 +01:00
|
|
|
ret = ext4_walk_page_buffers(handle, page_buffers(page),
|
|
|
|
from, to, NULL,
|
|
|
|
do_journal_get_write_access);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2007-10-16 10:25:05 +02:00
|
|
|
|
|
|
|
if (ret) {
|
2008-09-09 04:25:24 +02:00
|
|
|
unlock_page(page);
|
2008-09-13 19:10:25 +02:00
|
|
|
/*
|
2010-06-04 11:29:57 +02:00
|
|
|
* __block_write_begin may have instantiated a few blocks
|
2008-09-13 19:10:25 +02:00
|
|
|
* outside i_size. Trim these off again. Don't need
|
|
|
|
* i_size_read because we hold i_mutex.
|
2009-06-05 07:00:26 +02:00
|
|
|
*
|
|
|
|
* Add inode to orphan list in case we crash before
|
|
|
|
* truncate finishes
|
2008-09-13 19:10:25 +02:00
|
|
|
*/
|
2009-07-13 22:22:22 +02:00
|
|
|
if (pos + len > inode->i_size && ext4_can_truncate(inode))
|
2009-06-05 07:00:26 +02:00
|
|
|
ext4_orphan_add(handle, inode);
|
|
|
|
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
if (pos + len > inode->i_size) {
|
2009-12-09 03:24:33 +01:00
|
|
|
ext4_truncate_failed_write(inode);
|
2009-06-14 23:45:34 +02:00
|
|
|
/*
|
2009-07-13 22:22:22 +02:00
|
|
|
* If truncate failed early the inode might
|
2009-06-05 07:00:26 +02:00
|
|
|
* still be on the orphan list; we need to
|
|
|
|
* make sure the inode is removed from the
|
|
|
|
* orphan list in that case.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
|
|
|
}
|
2007-10-16 10:25:05 +02:00
|
|
|
|
2013-02-09 15:24:14 +01:00
|
|
|
if (ret == -ENOSPC &&
|
|
|
|
ext4_should_retry_alloc(inode->i_sb, &retries))
|
|
|
|
goto retry_journal;
|
|
|
|
page_cache_release(page);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
*pagep = page;
|
2006-10-11 10:20:50 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2007-10-16 10:25:05 +02:00
|
|
|
/* For write_end() in data=journal mode */
|
|
|
|
static int write_end_fn(handle_t *handle, struct buffer_head *bh)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2013-04-21 22:45:54 +02:00
|
|
|
int ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!buffer_mapped(bh) || buffer_freed(bh))
|
|
|
|
return 0;
|
|
|
|
set_buffer_uptodate(bh);
|
2013-04-21 22:45:54 +02:00
|
|
|
ret = ext4_handle_dirty_metadata(handle, NULL, bh);
|
|
|
|
clear_buffer_meta(bh);
|
|
|
|
clear_buffer_prio(bh);
|
|
|
|
return ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2013-04-03 18:41:17 +02:00
|
|
|
/*
|
|
|
|
* We need to pick up the new inode size which generic_commit_write gave us
|
|
|
|
* `file' can be NULL - eg, when called from page_symlink().
|
|
|
|
*
|
|
|
|
* ext4 never places buffers on inode->i_mapping->private_list. metadata
|
|
|
|
* buffers are managed internally.
|
|
|
|
*/
|
|
|
|
static int ext4_write_end(struct file *file,
|
|
|
|
struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
|
|
|
struct page *page, void *fsdata)
|
2009-06-05 06:56:49 +02:00
|
|
|
{
|
|
|
|
handle_t *handle = ext4_journal_current_handle();
|
2013-04-03 18:41:17 +02:00
|
|
|
struct inode *inode = mapping->host;
|
2015-02-13 05:00:17 +01:00
|
|
|
loff_t old_size = inode->i_size;
|
2013-04-03 18:41:17 +02:00
|
|
|
int ret = 0, ret2;
|
|
|
|
int i_size_changed = 0;
|
|
|
|
|
|
|
|
trace_ext4_write_end(inode, pos, len, copied);
|
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_ORDERED_MODE)) {
|
|
|
|
ret = ext4_jbd2_file_inode(handle, inode);
|
|
|
|
if (ret) {
|
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
|
|
|
goto errout;
|
|
|
|
}
|
|
|
|
}
|
2009-06-05 06:56:49 +02:00
|
|
|
|
2013-07-01 14:12:39 +02:00
|
|
|
if (ext4_has_inline_data(inode)) {
|
|
|
|
ret = ext4_write_inline_data_end(inode, pos, len,
|
|
|
|
copied, page);
|
|
|
|
if (ret < 0)
|
|
|
|
goto errout;
|
|
|
|
copied = ret;
|
|
|
|
} else
|
2012-12-10 20:05:51 +01:00
|
|
|
copied = block_write_end(file, mapping, pos,
|
|
|
|
len, copied, page, fsdata);
|
2009-06-05 06:56:49 +02:00
|
|
|
/*
|
2014-08-23 23:48:28 +02:00
|
|
|
* it's important to update i_size while still holding page lock:
|
2009-06-05 06:56:49 +02:00
|
|
|
* page writeout could otherwise come in and zero beyond i_size.
|
|
|
|
*/
|
2014-08-23 23:48:28 +02:00
|
|
|
i_size_changed = ext4_update_inode_size(inode, pos + copied);
|
2009-06-05 06:56:49 +02:00
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
|
|
|
|
2015-02-13 05:00:17 +01:00
|
|
|
if (old_size < pos)
|
|
|
|
pagecache_isize_extended(inode, old_size, pos);
|
2009-06-05 06:56:49 +02:00
|
|
|
/*
|
|
|
|
* Don't mark the inode dirty under page lock. First, it unnecessarily
|
|
|
|
* makes the holding time of page lock longer. Second, it forces lock
|
|
|
|
* ordering of page lock and transaction start for journaling
|
|
|
|
* filesystems.
|
|
|
|
*/
|
|
|
|
if (i_size_changed)
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
|
|
|
|
2009-07-13 22:22:22 +02:00
|
|
|
if (pos + len > inode->i_size && ext4_can_truncate(inode))
|
2009-06-05 06:56:49 +02:00
|
|
|
/* if we have allocated more blocks and copied
|
|
|
|
* less. We will have blocks allocated outside
|
|
|
|
* inode->i_size. So truncate them
|
|
|
|
*/
|
|
|
|
ext4_orphan_add(handle, inode);
|
2013-04-03 18:39:17 +02:00
|
|
|
errout:
|
2006-10-11 10:20:53 +02:00
|
|
|
ret2 = ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
2007-10-16 10:25:05 +02:00
|
|
|
|
2009-06-05 06:56:49 +02:00
|
|
|
if (pos + len > inode->i_size) {
|
2009-12-09 03:24:33 +01:00
|
|
|
ext4_truncate_failed_write(inode);
|
2009-06-14 23:45:34 +02:00
|
|
|
/*
|
2009-07-13 22:22:22 +02:00
|
|
|
* If truncate failed early the inode might still be
|
2009-06-05 06:56:49 +02:00
|
|
|
* on the orphan list; we need to make sure the inode
|
|
|
|
* is removed from the orphan list in that case.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
|
|
|
}
|
|
|
|
|
2007-10-16 10:25:05 +02:00
|
|
|
return ret ? ret : copied;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2015-10-15 16:29:05 +02:00
|
|
|
/*
|
|
|
|
* This is a private version of page_zero_new_buffers() which doesn't
|
|
|
|
* set the buffer to be dirty, since in data=journalled mode we need
|
|
|
|
* to call ext4_handle_dirty_metadata() instead.
|
|
|
|
*/
|
|
|
|
static void zero_new_buffers(struct page *page, unsigned from, unsigned to)
|
|
|
|
{
|
|
|
|
unsigned int block_start = 0, block_end;
|
|
|
|
struct buffer_head *head, *bh;
|
|
|
|
|
|
|
|
bh = head = page_buffers(page);
|
|
|
|
do {
|
|
|
|
block_end = block_start + bh->b_size;
|
|
|
|
if (buffer_new(bh)) {
|
|
|
|
if (block_end > from && block_start < to) {
|
|
|
|
if (!PageUptodate(page)) {
|
|
|
|
unsigned start, size;
|
|
|
|
|
|
|
|
start = max(from, block_start);
|
|
|
|
size = min(to, block_end) - start;
|
|
|
|
|
|
|
|
zero_user(page, start, size);
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
}
|
|
|
|
clear_buffer_new(bh);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
block_start = block_end;
|
|
|
|
bh = bh->b_this_page;
|
|
|
|
} while (bh != head);
|
|
|
|
}
|
|
|
|
|
2007-10-16 10:25:05 +02:00
|
|
|
static int ext4_journalled_write_end(struct file *file,
|
2009-06-14 23:45:34 +02:00
|
|
|
struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
|
|
|
struct page *page, void *fsdata)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
handle_t *handle = ext4_journal_current_handle();
|
2007-10-16 10:25:05 +02:00
|
|
|
struct inode *inode = mapping->host;
|
2015-02-13 05:00:17 +01:00
|
|
|
loff_t old_size = inode->i_size;
|
2006-10-11 10:20:50 +02:00
|
|
|
int ret = 0, ret2;
|
|
|
|
int partial = 0;
|
2007-10-16 10:25:05 +02:00
|
|
|
unsigned from, to;
|
2014-08-23 23:48:28 +02:00
|
|
|
int size_changed = 0;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2009-06-17 17:48:11 +02:00
|
|
|
trace_ext4_journalled_write_end(inode, pos, len, copied);
|
2007-10-16 10:25:05 +02:00
|
|
|
from = pos & (PAGE_CACHE_SIZE - 1);
|
|
|
|
to = from + len;
|
|
|
|
|
ext4: Fix ext4_should_writeback_data() for no-journal mode
ext4_should_writeback_data() had an incorrect sequence of
tests to determine if it should return 0 or 1: in
particular, even in no-journal mode, 0 was being returned
for a non-regular-file inode.
This meant that, in non-journal mode, we would use
ext4_journalled_aops for directories, symlinks, and other
non-regular files. However, calling journalled aop
callbacks when there is no valid handle, can cause problems.
This would cause a kernel crash with Jan Kara's commit
2d859db3e4 ("ext4: fix data corruption in inodes with
journalled data"), because we now dereference 'handle' in
ext4_journalled_write_end().
I also added BUG_ONs to check for a valid handle in the
obviously journal-only aops callbacks.
I tested this running xfstests with a scratch device in
these modes:
- no-journal
- data=ordered
- data=writeback
- data=journal
All work fine; the data=journal run has many failures and a
crash in xfstests 074, but this is no different from a
vanilla kernel.
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
2011-08-13 17:25:18 +02:00
|
|
|
BUG_ON(!ext4_handle_valid(handle));
|
|
|
|
|
2012-12-10 20:05:57 +01:00
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
copied = ext4_write_inline_data_end(inode, pos, len,
|
|
|
|
copied, page);
|
|
|
|
else {
|
|
|
|
if (copied < len) {
|
|
|
|
if (!PageUptodate(page))
|
|
|
|
copied = 0;
|
2015-10-15 16:29:05 +02:00
|
|
|
zero_new_buffers(page, from+copied, to);
|
2012-12-10 20:05:57 +01:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2012-12-10 20:05:57 +01:00
|
|
|
ret = ext4_walk_page_buffers(handle, page_buffers(page), from,
|
|
|
|
to, &partial, write_end_fn);
|
|
|
|
if (!partial)
|
|
|
|
SetPageUptodate(page);
|
|
|
|
}
|
2014-08-23 23:48:28 +02:00
|
|
|
size_changed = ext4_update_inode_size(inode, pos + copied);
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_JDATA);
|
2011-07-26 15:07:11 +02:00
|
|
|
EXT4_I(inode)->i_datasync_tid = handle->h_transaction->t_tid;
|
2014-08-23 23:48:28 +02:00
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
|
|
|
|
2015-02-13 05:00:17 +01:00
|
|
|
if (old_size < pos)
|
|
|
|
pagecache_isize_extended(inode, old_size, pos);
|
|
|
|
|
2014-08-23 23:48:28 +02:00
|
|
|
if (size_changed) {
|
2006-10-11 10:20:53 +02:00
|
|
|
ret2 = ext4_mark_inode_dirty(handle, inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
|
|
|
}
|
2007-10-16 10:25:05 +02:00
|
|
|
|
2009-07-13 22:22:22 +02:00
|
|
|
if (pos + len > inode->i_size && ext4_can_truncate(inode))
|
2009-06-05 06:56:49 +02:00
|
|
|
/* if we have allocated more blocks and copied
|
|
|
|
* less. We will have blocks allocated outside
|
|
|
|
* inode->i_size. So truncate them
|
|
|
|
*/
|
|
|
|
ext4_orphan_add(handle, inode);
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
ret2 = ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
2009-06-05 06:56:49 +02:00
|
|
|
if (pos + len > inode->i_size) {
|
2009-12-09 03:24:33 +01:00
|
|
|
ext4_truncate_failed_write(inode);
|
2009-06-14 23:45:34 +02:00
|
|
|
/*
|
2009-07-13 22:22:22 +02:00
|
|
|
* If truncate failed early the inode might still be
|
2009-06-05 06:56:49 +02:00
|
|
|
* on the orphan list; we need to make sure the inode
|
|
|
|
* is removed from the orphan list in that case.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
|
|
|
}
|
2007-10-16 10:25:05 +02:00
|
|
|
|
|
|
|
return ret ? ret : copied;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2008-07-14 23:52:37 +02:00
|
|
|
|
2010-01-01 08:41:30 +01:00
|
|
|
/*
|
2015-06-22 03:37:05 +02:00
|
|
|
* Reserve space for a single cluster
|
2010-01-01 08:41:30 +01:00
|
|
|
*/
|
2015-06-22 03:37:05 +02:00
|
|
|
static int ext4_da_reserve_space(struct inode *inode)
|
2008-07-14 23:52:37 +02:00
|
|
|
{
|
2009-01-22 18:13:05 +01:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2009-12-30 20:20:45 +01:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2010-03-03 15:05:00 +01:00
|
|
|
int ret;
|
2012-07-23 06:00:20 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We will charge metadata quota at writeout time; this saves
|
|
|
|
* us from metadata over-estimation, though we may go over by
|
|
|
|
* a small amount in the end. Here we just reserve for data.
|
|
|
|
*/
|
|
|
|
ret = dquot_reserve_block(inode, EXT4_C2B(sbi, 1));
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2008-07-14 23:52:37 +02:00
|
|
|
|
2009-12-30 20:20:45 +01:00
|
|
|
spin_lock(&ei->i_block_reservation_lock);
|
2014-07-15 12:02:38 +02:00
|
|
|
if (ext4_claim_free_clusters(sbi, 1, 0)) {
|
2012-07-23 06:00:20 +02:00
|
|
|
spin_unlock(&ei->i_block_reservation_lock);
|
|
|
|
dquot_release_reservation_block(inode, EXT4_C2B(sbi, 1));
|
2008-07-14 23:52:37 +02:00
|
|
|
return -ENOSPC;
|
|
|
|
}
|
2010-01-01 08:41:30 +01:00
|
|
|
ei->i_reserved_data_blocks++;
|
2015-06-22 03:37:05 +02:00
|
|
|
trace_ext4_da_reserve_space(inode);
|
2009-12-30 20:20:45 +01:00
|
|
|
spin_unlock(&ei->i_block_reservation_lock);
|
2009-12-10 17:36:27 +01:00
|
|
|
|
2008-07-14 23:52:37 +02:00
|
|
|
return 0; /* success */
|
|
|
|
}
|
|
|
|
|
2008-07-17 22:12:08 +02:00
|
|
|
static void ext4_da_release_space(struct inode *inode, int to_free)
|
2008-07-14 23:52:37 +02:00
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2009-12-30 20:20:45 +01:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2008-07-14 23:52:37 +02:00
|
|
|
|
2008-08-20 04:16:59 +02:00
|
|
|
if (!to_free)
|
|
|
|
return; /* Nothing to release, exit */
|
|
|
|
|
2008-07-14 23:52:37 +02:00
|
|
|
spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
|
2008-08-20 04:16:59 +02:00
|
|
|
|
2010-05-17 08:00:00 +02:00
|
|
|
trace_ext4_da_release_space(inode, to_free);
|
2009-12-30 20:20:45 +01:00
|
|
|
if (unlikely(to_free > ei->i_reserved_data_blocks)) {
|
2008-08-20 04:16:59 +02:00
|
|
|
/*
|
2009-12-30 20:20:45 +01:00
|
|
|
* if there aren't enough reserved blocks, then the
|
|
|
|
* counter is messed up somewhere. Since this
|
|
|
|
* function is called from invalidate page, it's
|
|
|
|
* harmless to return without any action.
|
2008-08-20 04:16:59 +02:00
|
|
|
*/
|
2013-02-14 21:11:41 +01:00
|
|
|
ext4_warning(inode->i_sb, "ext4_da_release_space: "
|
2009-12-30 20:20:45 +01:00
|
|
|
"ino %lu, to_free %d with only %d reserved "
|
2012-03-20 04:13:43 +01:00
|
|
|
"data blocks", inode->i_ino, to_free,
|
2009-12-30 20:20:45 +01:00
|
|
|
ei->i_reserved_data_blocks);
|
|
|
|
WARN_ON(1);
|
|
|
|
to_free = ei->i_reserved_data_blocks;
|
2008-08-20 04:16:59 +02:00
|
|
|
}
|
2009-12-30 20:20:45 +01:00
|
|
|
ei->i_reserved_data_blocks -= to_free;
|
2008-08-20 04:16:59 +02:00
|
|
|
|
2010-05-16 17:00:00 +02:00
|
|
|
/* update fs dirty data blocks counter */
|
2011-09-10 00:56:51 +02:00
|
|
|
percpu_counter_sub(&sbi->s_dirtyclusters_counter, to_free);
|
2008-07-14 23:52:37 +02:00
|
|
|
|
|
|
|
spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
|
2009-01-22 18:13:05 +01:00
|
|
|
|
2011-09-10 01:04:51 +02:00
|
|
|
dquot_release_reservation_block(inode, EXT4_C2B(sbi, to_free));
|
2008-07-14 23:52:37 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static void ext4_da_page_release_reservation(struct page *page,
|
2013-05-22 05:25:01 +02:00
|
|
|
unsigned int offset,
|
|
|
|
unsigned int length)
|
2008-07-14 23:52:37 +02:00
|
|
|
{
|
2015-07-04 03:13:55 +02:00
|
|
|
int to_release = 0, contiguous_blks = 0;
|
2008-07-14 23:52:37 +02:00
|
|
|
struct buffer_head *head, *bh;
|
|
|
|
unsigned int curr_off = 0;
|
2011-09-10 01:04:51 +02:00
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2013-05-22 05:25:01 +02:00
|
|
|
unsigned int stop = offset + length;
|
2011-09-10 01:04:51 +02:00
|
|
|
int num_clusters;
|
2012-11-09 03:57:32 +01:00
|
|
|
ext4_fsblk_t lblk;
|
2008-07-14 23:52:37 +02:00
|
|
|
|
2013-05-22 05:25:01 +02:00
|
|
|
BUG_ON(stop > PAGE_CACHE_SIZE || stop < length);
|
|
|
|
|
2008-07-14 23:52:37 +02:00
|
|
|
head = page_buffers(page);
|
|
|
|
bh = head;
|
|
|
|
do {
|
|
|
|
unsigned int next_off = curr_off + bh->b_size;
|
|
|
|
|
2013-05-22 05:25:01 +02:00
|
|
|
if (next_off > stop)
|
|
|
|
break;
|
|
|
|
|
2008-07-14 23:52:37 +02:00
|
|
|
if ((offset <= curr_off) && (buffer_delay(bh))) {
|
|
|
|
to_release++;
|
2015-07-04 03:13:55 +02:00
|
|
|
contiguous_blks++;
|
2008-07-14 23:52:37 +02:00
|
|
|
clear_buffer_delay(bh);
|
2015-07-04 03:13:55 +02:00
|
|
|
} else if (contiguous_blks) {
|
|
|
|
lblk = page->index <<
|
|
|
|
(PAGE_CACHE_SHIFT - inode->i_blkbits);
|
|
|
|
lblk += (curr_off >> inode->i_blkbits) -
|
|
|
|
contiguous_blks;
|
|
|
|
ext4_es_remove_extent(inode, lblk, contiguous_blks);
|
|
|
|
contiguous_blks = 0;
|
2008-07-14 23:52:37 +02:00
|
|
|
}
|
|
|
|
curr_off = next_off;
|
|
|
|
} while ((bh = bh->b_this_page) != head);
|
2011-09-10 01:04:51 +02:00
|
|
|
|
2015-07-04 03:13:55 +02:00
|
|
|
if (contiguous_blks) {
|
2012-11-09 03:57:32 +01:00
|
|
|
lblk = page->index << (PAGE_CACHE_SHIFT - inode->i_blkbits);
|
2015-07-04 03:13:55 +02:00
|
|
|
lblk += (curr_off >> inode->i_blkbits) - contiguous_blks;
|
|
|
|
ext4_es_remove_extent(inode, lblk, contiguous_blks);
|
2012-11-09 03:57:32 +01:00
|
|
|
}
|
|
|
|
|
2011-09-10 01:04:51 +02:00
|
|
|
/* If we have released all the blocks belonging to a cluster, then we
|
|
|
|
* need to release the reserved space for that cluster. */
|
|
|
|
num_clusters = EXT4_NUM_B2C(sbi, to_release);
|
|
|
|
while (num_clusters > 0) {
|
|
|
|
lblk = (page->index << (PAGE_CACHE_SHIFT - inode->i_blkbits)) +
|
|
|
|
((num_clusters - 1) << sbi->s_cluster_bits);
|
|
|
|
if (sbi->s_cluster_ratio == 1 ||
|
2012-11-09 03:57:35 +01:00
|
|
|
!ext4_find_delalloc_cluster(inode, lblk))
|
2011-09-10 01:04:51 +02:00
|
|
|
ext4_da_release_space(inode, 1);
|
|
|
|
|
|
|
|
num_clusters--;
|
|
|
|
}
|
2008-07-14 23:52:37 +02:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
|
|
|
* Delayed allocation stuff
|
|
|
|
*/
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
struct mpage_da_data {
|
|
|
|
struct inode *inode;
|
|
|
|
struct writeback_control *wbc;
|
2013-06-04 19:21:11 +02:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
pgoff_t first_page; /* The first page to write */
|
|
|
|
pgoff_t next_page; /* Current page to examine */
|
|
|
|
pgoff_t last_page; /* Last page to examine */
|
2009-01-06 03:50:43 +01:00
|
|
|
/*
|
2013-06-04 19:17:40 +02:00
|
|
|
* Extent to map - this can be after first_page because that can be
|
|
|
|
* fully mapped. We somewhat abuse m_flags to store whether the extent
|
|
|
|
* is delalloc or unwritten.
|
2009-01-06 03:50:43 +01:00
|
|
|
*/
|
2013-06-04 19:17:40 +02:00
|
|
|
struct ext4_map_blocks map;
|
|
|
|
struct ext4_io_submit io_submit; /* IO submission data */
|
|
|
|
};
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
static void mpage_release_unused_pages(struct mpage_da_data *mpd,
|
|
|
|
bool invalidate)
|
2008-08-20 03:08:18 +02:00
|
|
|
{
|
|
|
|
int nr_pages, i;
|
|
|
|
pgoff_t index, end;
|
|
|
|
struct pagevec pvec;
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2013-06-04 19:17:40 +02:00
|
|
|
|
|
|
|
/* This is necessary when next_page == 0. */
|
|
|
|
if (mpd->first_page >= mpd->next_page)
|
|
|
|
return;
|
2008-08-20 03:08:18 +02:00
|
|
|
|
2011-02-26 18:27:52 +01:00
|
|
|
index = mpd->first_page;
|
|
|
|
end = mpd->next_page - 1;
|
2013-06-04 19:17:40 +02:00
|
|
|
if (invalidate) {
|
|
|
|
ext4_lblk_t start, last;
|
|
|
|
start = index << (PAGE_CACHE_SHIFT - inode->i_blkbits);
|
|
|
|
last = end << (PAGE_CACHE_SHIFT - inode->i_blkbits);
|
|
|
|
ext4_es_remove_extent(inode, start, last - start + 1);
|
|
|
|
}
|
2012-11-09 03:57:32 +01:00
|
|
|
|
2012-11-15 04:22:05 +01:00
|
|
|
pagevec_init(&pvec, 0);
|
2008-08-20 03:08:18 +02:00
|
|
|
while (index <= end) {
|
|
|
|
nr_pages = pagevec_lookup(&pvec, mapping, index, PAGEVEC_SIZE);
|
|
|
|
if (nr_pages == 0)
|
|
|
|
break;
|
|
|
|
for (i = 0; i < nr_pages; i++) {
|
|
|
|
struct page *page = pvec.pages[i];
|
2010-03-03 22:19:32 +01:00
|
|
|
if (page->index > end)
|
2008-08-20 03:08:18 +02:00
|
|
|
break;
|
|
|
|
BUG_ON(!PageLocked(page));
|
|
|
|
BUG_ON(PageWriteback(page));
|
2013-06-04 19:17:40 +02:00
|
|
|
if (invalidate) {
|
|
|
|
block_invalidatepage(page, 0, PAGE_CACHE_SIZE);
|
|
|
|
ClearPageUptodate(page);
|
|
|
|
}
|
2008-08-20 03:08:18 +02:00
|
|
|
unlock_page(page);
|
|
|
|
}
|
2010-03-03 22:19:32 +01:00
|
|
|
index = pvec.pages[nr_pages - 1]->index + 1;
|
|
|
|
pagevec_release(&pvec);
|
2008-08-20 03:08:18 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-09-09 05:05:34 +02:00
|
|
|
static void ext4_print_free_blocks(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
2012-03-20 04:41:49 +01:00
|
|
|
struct super_block *sb = inode->i_sb;
|
2013-04-04 05:33:30 +02:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2012-03-20 04:41:49 +01:00
|
|
|
|
|
|
|
ext4_msg(sb, KERN_CRIT, "Total free blocks count %lld",
|
2011-09-10 01:10:51 +02:00
|
|
|
EXT4_C2B(EXT4_SB(inode->i_sb),
|
2013-04-04 05:33:30 +02:00
|
|
|
ext4_count_free_clusters(sb)));
|
2012-03-20 04:41:49 +01:00
|
|
|
ext4_msg(sb, KERN_CRIT, "Free/Dirty block details");
|
|
|
|
ext4_msg(sb, KERN_CRIT, "free_blocks=%lld",
|
2013-04-04 05:33:30 +02:00
|
|
|
(long long) EXT4_C2B(EXT4_SB(sb),
|
2011-09-10 00:56:51 +02:00
|
|
|
percpu_counter_sum(&sbi->s_freeclusters_counter)));
|
2012-03-20 04:41:49 +01:00
|
|
|
ext4_msg(sb, KERN_CRIT, "dirty_blocks=%lld",
|
2013-04-04 05:33:30 +02:00
|
|
|
(long long) EXT4_C2B(EXT4_SB(sb),
|
2011-09-10 01:04:51 +02:00
|
|
|
percpu_counter_sum(&sbi->s_dirtyclusters_counter)));
|
2012-03-20 04:41:49 +01:00
|
|
|
ext4_msg(sb, KERN_CRIT, "Block reservation details");
|
|
|
|
ext4_msg(sb, KERN_CRIT, "i_reserved_data_blocks=%u",
|
2013-04-04 05:33:30 +02:00
|
|
|
ei->i_reserved_data_blocks);
|
2008-09-09 05:05:34 +02:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-06-14 23:57:10 +02:00
|
|
|
static int ext4_bh_delay_or_unwritten(handle_t *handle, struct buffer_head *bh)
|
2009-05-12 22:30:27 +02:00
|
|
|
{
|
2009-06-14 23:57:10 +02:00
|
|
|
return (buffer_delay(bh) || buffer_unwritten(bh)) && buffer_dirty(bh);
|
2009-05-12 22:30:27 +02:00
|
|
|
}
|
|
|
|
|
2011-09-10 01:20:51 +02:00
|
|
|
/*
|
|
|
|
* This function is grabs code from the very beginning of
|
|
|
|
* ext4_map_blocks, but assumes that the caller is from delayed write
|
|
|
|
* time. This function looks up the requested blocks and sets the
|
|
|
|
* buffer delay bit under the protection of i_data_sem.
|
|
|
|
*/
|
|
|
|
static int ext4_da_map_blocks(struct inode *inode, sector_t iblock,
|
|
|
|
struct ext4_map_blocks *map,
|
|
|
|
struct buffer_head *bh)
|
|
|
|
{
|
2013-02-18 06:29:59 +01:00
|
|
|
struct extent_status es;
|
2011-09-10 01:20:51 +02:00
|
|
|
int retval;
|
|
|
|
sector_t invalid_block = ~((sector_t) 0xffff);
|
2013-03-11 02:01:03 +01:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
struct ext4_map_blocks orig_map;
|
|
|
|
|
|
|
|
memcpy(&orig_map, map, sizeof(*map));
|
|
|
|
#endif
|
2011-09-10 01:20:51 +02:00
|
|
|
|
|
|
|
if (invalid_block < ext4_blocks_count(EXT4_SB(inode->i_sb)->s_es))
|
|
|
|
invalid_block = ~0;
|
|
|
|
|
|
|
|
map->m_flags = 0;
|
|
|
|
ext_debug("ext4_da_map_blocks(): inode %lu, max_blocks %u,"
|
|
|
|
"logical block %lu\n", inode->i_ino, map->m_len,
|
|
|
|
(unsigned long) map->m_lblk);
|
2013-02-18 06:29:59 +01:00
|
|
|
|
|
|
|
/* Lookup extent status tree firstly */
|
|
|
|
if (ext4_es_lookup_extent(inode, iblock, &es)) {
|
|
|
|
if (ext4_es_is_hole(&es)) {
|
|
|
|
retval = 0;
|
2014-05-12 18:55:07 +02:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2013-02-18 06:29:59 +01:00
|
|
|
goto add_delayed;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Delayed extent could be allocated by fallocate.
|
|
|
|
* So we need to check it.
|
|
|
|
*/
|
|
|
|
if (ext4_es_is_delayed(&es) && !ext4_es_is_unwritten(&es)) {
|
|
|
|
map_bh(bh, inode->i_sb, invalid_block);
|
|
|
|
set_buffer_new(bh);
|
|
|
|
set_buffer_delay(bh);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
map->m_pblk = ext4_es_pblock(&es) + iblock - es.es_lblk;
|
|
|
|
retval = es.es_len - (iblock - es.es_lblk);
|
|
|
|
if (retval > map->m_len)
|
|
|
|
retval = map->m_len;
|
|
|
|
map->m_len = retval;
|
|
|
|
if (ext4_es_is_written(&es))
|
|
|
|
map->m_flags |= EXT4_MAP_MAPPED;
|
|
|
|
else if (ext4_es_is_unwritten(&es))
|
|
|
|
map->m_flags |= EXT4_MAP_UNWRITTEN;
|
|
|
|
else
|
|
|
|
BUG_ON(1);
|
|
|
|
|
2013-03-11 02:01:03 +01:00
|
|
|
#ifdef ES_AGGRESSIVE_TEST
|
|
|
|
ext4_map_blocks_es_recheck(NULL, inode, map, &orig_map, 0);
|
|
|
|
#endif
|
2013-02-18 06:29:59 +01:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2011-09-10 01:20:51 +02:00
|
|
|
/*
|
|
|
|
* Try to see if we can get the block without requesting a new
|
|
|
|
* file system block.
|
|
|
|
*/
|
2014-05-12 18:55:07 +02:00
|
|
|
down_read(&EXT4_I(inode)->i_data_sem);
|
2014-11-25 17:41:49 +01:00
|
|
|
if (ext4_has_inline_data(inode))
|
2012-12-10 20:05:57 +01:00
|
|
|
retval = 0;
|
2014-11-25 17:41:49 +01:00
|
|
|
else if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
2014-11-25 17:44:37 +01:00
|
|
|
retval = ext4_ext_map_blocks(NULL, inode, map, 0);
|
2011-09-10 01:20:51 +02:00
|
|
|
else
|
2014-11-25 17:44:37 +01:00
|
|
|
retval = ext4_ind_map_blocks(NULL, inode, map, 0);
|
2011-09-10 01:20:51 +02:00
|
|
|
|
2013-02-18 06:29:59 +01:00
|
|
|
add_delayed:
|
2011-09-10 01:20:51 +02:00
|
|
|
if (retval == 0) {
|
2013-02-18 06:28:47 +01:00
|
|
|
int ret;
|
2011-09-10 01:20:51 +02:00
|
|
|
/*
|
|
|
|
* XXX: __block_prepare_write() unmaps passed block,
|
|
|
|
* is it OK?
|
|
|
|
*/
|
2013-03-11 03:50:00 +01:00
|
|
|
/*
|
|
|
|
* If the block was allocated from previously allocated cluster,
|
|
|
|
* then we don't need to reserve it again. However we still need
|
|
|
|
* to reserve metadata for every block we're going to write.
|
|
|
|
*/
|
2015-06-22 03:37:05 +02:00
|
|
|
if (EXT4_SB(inode->i_sb)->s_cluster_ratio == 1 ||
|
2014-11-25 17:41:49 +01:00
|
|
|
!ext4_find_delalloc_cluster(inode, map->m_lblk)) {
|
2015-06-22 03:37:05 +02:00
|
|
|
ret = ext4_da_reserve_space(inode);
|
2013-02-18 06:28:47 +01:00
|
|
|
if (ret) {
|
2011-09-10 01:20:51 +02:00
|
|
|
/* not enough space to reserve */
|
2013-02-18 06:28:47 +01:00
|
|
|
retval = ret;
|
2011-09-10 01:20:51 +02:00
|
|
|
goto out_unlock;
|
2013-02-18 06:28:47 +01:00
|
|
|
}
|
2011-09-10 01:20:51 +02:00
|
|
|
}
|
|
|
|
|
2013-02-18 06:28:47 +01:00
|
|
|
ret = ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
|
|
|
|
~0, EXTENT_STATUS_DELAYED);
|
|
|
|
if (ret) {
|
|
|
|
retval = ret;
|
2012-11-09 03:57:32 +01:00
|
|
|
goto out_unlock;
|
2013-02-18 06:28:47 +01:00
|
|
|
}
|
2012-11-09 03:57:32 +01:00
|
|
|
|
2011-09-10 01:20:51 +02:00
|
|
|
map_bh(bh, inode->i_sb, invalid_block);
|
|
|
|
set_buffer_new(bh);
|
|
|
|
set_buffer_delay(bh);
|
2013-02-18 06:28:47 +01:00
|
|
|
} else if (retval > 0) {
|
|
|
|
int ret;
|
2013-08-17 03:22:41 +02:00
|
|
|
unsigned int status;
|
2013-02-18 06:28:47 +01:00
|
|
|
|
2013-07-29 18:51:42 +02:00
|
|
|
if (unlikely(retval != map->m_len)) {
|
|
|
|
ext4_warning(inode->i_sb,
|
|
|
|
"ES len assertion failed for inode "
|
|
|
|
"%lu: retval %d != map->m_len %d",
|
|
|
|
inode->i_ino, retval, map->m_len);
|
|
|
|
WARN_ON(1);
|
2013-03-11 02:01:03 +01:00
|
|
|
}
|
|
|
|
|
2013-02-18 06:28:47 +01:00
|
|
|
status = map->m_flags & EXT4_MAP_UNWRITTEN ?
|
|
|
|
EXTENT_STATUS_UNWRITTEN : EXTENT_STATUS_WRITTEN;
|
|
|
|
ret = ext4_es_insert_extent(inode, map->m_lblk, map->m_len,
|
|
|
|
map->m_pblk, status);
|
|
|
|
if (ret != 0)
|
|
|
|
retval = ret;
|
2011-09-10 01:20:51 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
out_unlock:
|
|
|
|
up_read((&EXT4_I(inode)->i_data_sem));
|
|
|
|
|
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
2014-09-02 04:15:30 +02:00
|
|
|
* This is a special get_block_t callback which is used by
|
2009-05-14 06:54:29 +02:00
|
|
|
* ext4_da_write_begin(). It will either return mapped block or
|
|
|
|
* reserve space for a single block.
|
2009-05-12 22:30:27 +02:00
|
|
|
*
|
|
|
|
* For delayed buffer_head we have BH_Mapped, BH_New, BH_Delay set.
|
|
|
|
* We also have b_blocknr = -1 and b_bdev initialized properly
|
|
|
|
*
|
|
|
|
* For unwritten buffer_head we have BH_Mapped, BH_New, BH_Unwritten set.
|
|
|
|
* We also have b_blocknr = physicalblock mapping unwritten extent and b_bdev
|
|
|
|
* initialized properly.
|
2008-07-12 01:27:31 +02:00
|
|
|
*/
|
2012-12-10 20:05:57 +01:00
|
|
|
int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh, int create)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
2010-05-17 02:00:00 +02:00
|
|
|
struct ext4_map_blocks map;
|
2008-07-12 01:27:31 +02:00
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
BUG_ON(create == 0);
|
2010-05-17 02:00:00 +02:00
|
|
|
BUG_ON(bh->b_size != inode->i_sb->s_blocksize);
|
|
|
|
|
|
|
|
map.m_lblk = iblock;
|
|
|
|
map.m_len = 1;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* first, we need to know whether the block is allocated already
|
|
|
|
* preallocated blocks are unmapped but should treated
|
|
|
|
* the same as allocated blocks.
|
|
|
|
*/
|
2011-09-10 01:20:51 +02:00
|
|
|
ret = ext4_da_map_blocks(inode, iblock, &map, bh);
|
|
|
|
if (ret <= 0)
|
2010-05-17 02:00:00 +02:00
|
|
|
return ret;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
map_bh(bh, inode->i_sb, map.m_pblk);
|
|
|
|
bh->b_state = (bh->b_state & ~EXT4_MAP_FLAGS) | map.m_flags;
|
|
|
|
|
|
|
|
if (buffer_unwritten(bh)) {
|
|
|
|
/* A delayed write to unwritten bh should be marked
|
|
|
|
* new and mapped. Mapped ensures that we don't do
|
|
|
|
* get_block multiple times when we write to the same
|
|
|
|
* offset and new ensures that we do proper zero out
|
|
|
|
* for partial write.
|
|
|
|
*/
|
|
|
|
set_buffer_new(bh);
|
2011-04-11 04:30:07 +02:00
|
|
|
set_buffer_mapped(bh);
|
2010-05-17 02:00:00 +02:00
|
|
|
}
|
|
|
|
return 0;
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2009-06-14 23:59:34 +02:00
|
|
|
static int bget_one(handle_t *handle, struct buffer_head *bh)
|
|
|
|
{
|
|
|
|
get_bh(bh);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int bput_one(handle_t *handle, struct buffer_head *bh)
|
|
|
|
{
|
|
|
|
put_bh(bh);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __ext4_journalled_writepage(struct page *page,
|
|
|
|
unsigned int len)
|
|
|
|
{
|
|
|
|
struct address_space *mapping = page->mapping;
|
|
|
|
struct inode *inode = mapping->host;
|
2012-12-10 20:05:57 +01:00
|
|
|
struct buffer_head *page_bufs = NULL;
|
2009-06-14 23:59:34 +02:00
|
|
|
handle_t *handle = NULL;
|
2012-12-10 20:05:57 +01:00
|
|
|
int ret = 0, err = 0;
|
|
|
|
int inline_data = ext4_has_inline_data(inode);
|
|
|
|
struct buffer_head *inode_bh = NULL;
|
2009-06-14 23:59:34 +02:00
|
|
|
|
2010-10-28 03:30:09 +02:00
|
|
|
ClearPageChecked(page);
|
2012-12-10 20:05:57 +01:00
|
|
|
|
|
|
|
if (inline_data) {
|
|
|
|
BUG_ON(page->index != 0);
|
|
|
|
BUG_ON(len > ext4_get_max_inline_size(inode));
|
|
|
|
inode_bh = ext4_journalled_write_inline_data(inode, len, page);
|
|
|
|
if (inode_bh == NULL)
|
|
|
|
goto out;
|
|
|
|
} else {
|
|
|
|
page_bufs = page_buffers(page);
|
|
|
|
if (!page_bufs) {
|
|
|
|
BUG();
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
ext4_walk_page_buffers(handle, page_bufs, 0, len,
|
|
|
|
NULL, bget_one);
|
|
|
|
}
|
ext4: fix race between truncate and __ext4_journalled_writepage()
The commit cf108bca465d: "ext4: Invert the locking order of page_lock
and transaction start" caused __ext4_journalled_writepage() to drop
the page lock before the page was written back, as part of changing
the locking order to jbd2_journal_start -> page_lock. However, this
introduced a potential race if there was a truncate racing with the
data=journalled writeback mode.
Fix this by grabbing the page lock after starting the journal handle,
and then checking to see if page had gotten truncated out from under
us.
This fixes a number of different warnings or BUG_ON's when running
xfstests generic/086 in data=journalled mode, including:
jbd2_journal_dirty_metadata: vdc-8: bad jh for block 115643: transaction (ee3fe7
c0, 164), jh->b_transaction ( (null), 0), jh->b_next_transaction ( (null), 0), jlist 0
- and -
kernel BUG at /usr/projects/linux/ext4/fs/jbd2/transaction.c:2200!
...
Call Trace:
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c02b2de5>] __ext4_journalled_invalidatepage+0x10f/0x117
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c027d883>] ? lock_buffer+0x36/0x36
[<c02b2dfa>] ext4_journalled_invalidatepage+0xd/0x22
[<c0229139>] do_invalidatepage+0x22/0x26
[<c0229198>] truncate_inode_page+0x5b/0x85
[<c022934b>] truncate_inode_pages_range+0x156/0x38c
[<c0229592>] truncate_inode_pages+0x11/0x15
[<c022962d>] truncate_pagecache+0x55/0x71
[<c02b913b>] ext4_setattr+0x4a9/0x560
[<c01ca542>] ? current_kernel_time+0x10/0x44
[<c026c4d8>] notify_change+0x1c7/0x2be
[<c0256a00>] do_truncate+0x65/0x85
[<c0226f31>] ? file_ra_state_init+0x12/0x29
- and -
WARNING: CPU: 1 PID: 1331 at /usr/projects/linux/ext4/fs/jbd2/transaction.c:1396
irty_metadata+0x14a/0x1ae()
...
Call Trace:
[<c01b879f>] ? console_unlock+0x3a1/0x3ce
[<c082cbb4>] dump_stack+0x48/0x60
[<c0178b65>] warn_slowpath_common+0x89/0xa0
[<c02ef2cf>] ? jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c0178bef>] warn_slowpath_null+0x14/0x18
[<c02ef2cf>] jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c02d8615>] __ext4_handle_dirty_metadata+0xd4/0x19d
[<c02b2f44>] write_end_fn+0x40/0x53
[<c02b4a16>] ext4_walk_page_buffers+0x4e/0x6a
[<c02b59e7>] ext4_writepage+0x354/0x3b8
[<c02b2f04>] ? mpage_release_unused_pages+0xd4/0xd4
[<c02b1b21>] ? wait_on_buffer+0x2c/0x2c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b5a5b>] __writepage+0x10/0x2e
[<c0225956>] write_cache_pages+0x22d/0x32c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b6ee8>] ext4_writepages+0x102/0x607
[<c019adfe>] ? sched_clock_local+0x10/0x10e
[<c01a8a7c>] ? __lock_is_held+0x2e/0x44
[<c01a8ad5>] ? lock_is_held+0x43/0x51
[<c0226dff>] do_writepages+0x1c/0x29
[<c0276bed>] __writeback_single_inode+0xc3/0x545
[<c0277c07>] writeback_sb_inodes+0x21f/0x36d
...
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2015-06-13 05:45:33 +02:00
|
|
|
/*
|
|
|
|
* We need to release the page lock before we start the
|
|
|
|
* journal, so grab a reference so the page won't disappear
|
|
|
|
* out from under us.
|
|
|
|
*/
|
|
|
|
get_page(page);
|
2009-06-14 23:59:34 +02:00
|
|
|
unlock_page(page);
|
|
|
|
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE,
|
|
|
|
ext4_writepage_trans_blocks(inode));
|
2009-06-14 23:59:34 +02:00
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
ext4: fix race between truncate and __ext4_journalled_writepage()
The commit cf108bca465d: "ext4: Invert the locking order of page_lock
and transaction start" caused __ext4_journalled_writepage() to drop
the page lock before the page was written back, as part of changing
the locking order to jbd2_journal_start -> page_lock. However, this
introduced a potential race if there was a truncate racing with the
data=journalled writeback mode.
Fix this by grabbing the page lock after starting the journal handle,
and then checking to see if page had gotten truncated out from under
us.
This fixes a number of different warnings or BUG_ON's when running
xfstests generic/086 in data=journalled mode, including:
jbd2_journal_dirty_metadata: vdc-8: bad jh for block 115643: transaction (ee3fe7
c0, 164), jh->b_transaction ( (null), 0), jh->b_next_transaction ( (null), 0), jlist 0
- and -
kernel BUG at /usr/projects/linux/ext4/fs/jbd2/transaction.c:2200!
...
Call Trace:
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c02b2de5>] __ext4_journalled_invalidatepage+0x10f/0x117
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c027d883>] ? lock_buffer+0x36/0x36
[<c02b2dfa>] ext4_journalled_invalidatepage+0xd/0x22
[<c0229139>] do_invalidatepage+0x22/0x26
[<c0229198>] truncate_inode_page+0x5b/0x85
[<c022934b>] truncate_inode_pages_range+0x156/0x38c
[<c0229592>] truncate_inode_pages+0x11/0x15
[<c022962d>] truncate_pagecache+0x55/0x71
[<c02b913b>] ext4_setattr+0x4a9/0x560
[<c01ca542>] ? current_kernel_time+0x10/0x44
[<c026c4d8>] notify_change+0x1c7/0x2be
[<c0256a00>] do_truncate+0x65/0x85
[<c0226f31>] ? file_ra_state_init+0x12/0x29
- and -
WARNING: CPU: 1 PID: 1331 at /usr/projects/linux/ext4/fs/jbd2/transaction.c:1396
irty_metadata+0x14a/0x1ae()
...
Call Trace:
[<c01b879f>] ? console_unlock+0x3a1/0x3ce
[<c082cbb4>] dump_stack+0x48/0x60
[<c0178b65>] warn_slowpath_common+0x89/0xa0
[<c02ef2cf>] ? jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c0178bef>] warn_slowpath_null+0x14/0x18
[<c02ef2cf>] jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c02d8615>] __ext4_handle_dirty_metadata+0xd4/0x19d
[<c02b2f44>] write_end_fn+0x40/0x53
[<c02b4a16>] ext4_walk_page_buffers+0x4e/0x6a
[<c02b59e7>] ext4_writepage+0x354/0x3b8
[<c02b2f04>] ? mpage_release_unused_pages+0xd4/0xd4
[<c02b1b21>] ? wait_on_buffer+0x2c/0x2c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b5a5b>] __writepage+0x10/0x2e
[<c0225956>] write_cache_pages+0x22d/0x32c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b6ee8>] ext4_writepages+0x102/0x607
[<c019adfe>] ? sched_clock_local+0x10/0x10e
[<c01a8a7c>] ? __lock_is_held+0x2e/0x44
[<c01a8ad5>] ? lock_is_held+0x43/0x51
[<c0226dff>] do_writepages+0x1c/0x29
[<c0276bed>] __writeback_single_inode+0xc3/0x545
[<c0277c07>] writeback_sb_inodes+0x21f/0x36d
...
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2015-06-13 05:45:33 +02:00
|
|
|
put_page(page);
|
|
|
|
goto out_no_pagelock;
|
2009-06-14 23:59:34 +02:00
|
|
|
}
|
ext4: Fix ext4_should_writeback_data() for no-journal mode
ext4_should_writeback_data() had an incorrect sequence of
tests to determine if it should return 0 or 1: in
particular, even in no-journal mode, 0 was being returned
for a non-regular-file inode.
This meant that, in non-journal mode, we would use
ext4_journalled_aops for directories, symlinks, and other
non-regular files. However, calling journalled aop
callbacks when there is no valid handle, can cause problems.
This would cause a kernel crash with Jan Kara's commit
2d859db3e4 ("ext4: fix data corruption in inodes with
journalled data"), because we now dereference 'handle' in
ext4_journalled_write_end().
I also added BUG_ONs to check for a valid handle in the
obviously journal-only aops callbacks.
I tested this running xfstests with a scratch device in
these modes:
- no-journal
- data=ordered
- data=writeback
- data=journal
All work fine; the data=journal run has many failures and a
crash in xfstests 074, but this is no different from a
vanilla kernel.
Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
2011-08-13 17:25:18 +02:00
|
|
|
BUG_ON(!ext4_handle_valid(handle));
|
|
|
|
|
ext4: fix race between truncate and __ext4_journalled_writepage()
The commit cf108bca465d: "ext4: Invert the locking order of page_lock
and transaction start" caused __ext4_journalled_writepage() to drop
the page lock before the page was written back, as part of changing
the locking order to jbd2_journal_start -> page_lock. However, this
introduced a potential race if there was a truncate racing with the
data=journalled writeback mode.
Fix this by grabbing the page lock after starting the journal handle,
and then checking to see if page had gotten truncated out from under
us.
This fixes a number of different warnings or BUG_ON's when running
xfstests generic/086 in data=journalled mode, including:
jbd2_journal_dirty_metadata: vdc-8: bad jh for block 115643: transaction (ee3fe7
c0, 164), jh->b_transaction ( (null), 0), jh->b_next_transaction ( (null), 0), jlist 0
- and -
kernel BUG at /usr/projects/linux/ext4/fs/jbd2/transaction.c:2200!
...
Call Trace:
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c02b2de5>] __ext4_journalled_invalidatepage+0x10f/0x117
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c027d883>] ? lock_buffer+0x36/0x36
[<c02b2dfa>] ext4_journalled_invalidatepage+0xd/0x22
[<c0229139>] do_invalidatepage+0x22/0x26
[<c0229198>] truncate_inode_page+0x5b/0x85
[<c022934b>] truncate_inode_pages_range+0x156/0x38c
[<c0229592>] truncate_inode_pages+0x11/0x15
[<c022962d>] truncate_pagecache+0x55/0x71
[<c02b913b>] ext4_setattr+0x4a9/0x560
[<c01ca542>] ? current_kernel_time+0x10/0x44
[<c026c4d8>] notify_change+0x1c7/0x2be
[<c0256a00>] do_truncate+0x65/0x85
[<c0226f31>] ? file_ra_state_init+0x12/0x29
- and -
WARNING: CPU: 1 PID: 1331 at /usr/projects/linux/ext4/fs/jbd2/transaction.c:1396
irty_metadata+0x14a/0x1ae()
...
Call Trace:
[<c01b879f>] ? console_unlock+0x3a1/0x3ce
[<c082cbb4>] dump_stack+0x48/0x60
[<c0178b65>] warn_slowpath_common+0x89/0xa0
[<c02ef2cf>] ? jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c0178bef>] warn_slowpath_null+0x14/0x18
[<c02ef2cf>] jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c02d8615>] __ext4_handle_dirty_metadata+0xd4/0x19d
[<c02b2f44>] write_end_fn+0x40/0x53
[<c02b4a16>] ext4_walk_page_buffers+0x4e/0x6a
[<c02b59e7>] ext4_writepage+0x354/0x3b8
[<c02b2f04>] ? mpage_release_unused_pages+0xd4/0xd4
[<c02b1b21>] ? wait_on_buffer+0x2c/0x2c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b5a5b>] __writepage+0x10/0x2e
[<c0225956>] write_cache_pages+0x22d/0x32c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b6ee8>] ext4_writepages+0x102/0x607
[<c019adfe>] ? sched_clock_local+0x10/0x10e
[<c01a8a7c>] ? __lock_is_held+0x2e/0x44
[<c01a8ad5>] ? lock_is_held+0x43/0x51
[<c0226dff>] do_writepages+0x1c/0x29
[<c0276bed>] __writeback_single_inode+0xc3/0x545
[<c0277c07>] writeback_sb_inodes+0x21f/0x36d
...
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2015-06-13 05:45:33 +02:00
|
|
|
lock_page(page);
|
|
|
|
put_page(page);
|
|
|
|
if (page->mapping != mapping) {
|
|
|
|
/* The page got truncated from under us */
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
ret = 0;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2012-12-10 20:05:57 +01:00
|
|
|
if (inline_data) {
|
2014-05-13 04:06:43 +02:00
|
|
|
BUFFER_TRACE(inode_bh, "get write access");
|
2012-12-10 20:05:57 +01:00
|
|
|
ret = ext4_journal_get_write_access(handle, inode_bh);
|
2009-06-14 23:59:34 +02:00
|
|
|
|
2012-12-10 20:05:57 +01:00
|
|
|
err = ext4_handle_dirty_metadata(handle, inode, inode_bh);
|
|
|
|
|
|
|
|
} else {
|
|
|
|
ret = ext4_walk_page_buffers(handle, page_bufs, 0, len, NULL,
|
|
|
|
do_journal_get_write_access);
|
|
|
|
|
|
|
|
err = ext4_walk_page_buffers(handle, page_bufs, 0, len, NULL,
|
|
|
|
write_end_fn);
|
|
|
|
}
|
2009-06-14 23:59:34 +02:00
|
|
|
if (ret == 0)
|
|
|
|
ret = err;
|
2011-07-26 15:07:11 +02:00
|
|
|
EXT4_I(inode)->i_datasync_tid = handle->h_transaction->t_tid;
|
2009-06-14 23:59:34 +02:00
|
|
|
err = ext4_journal_stop(handle);
|
|
|
|
if (!ret)
|
|
|
|
ret = err;
|
|
|
|
|
2012-12-10 20:05:57 +01:00
|
|
|
if (!ext4_has_inline_data(inode))
|
2014-01-07 19:08:03 +01:00
|
|
|
ext4_walk_page_buffers(NULL, page_bufs, 0, len,
|
2012-12-10 20:05:57 +01:00
|
|
|
NULL, bput_one);
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_JDATA);
|
2009-06-14 23:59:34 +02:00
|
|
|
out:
|
ext4: fix race between truncate and __ext4_journalled_writepage()
The commit cf108bca465d: "ext4: Invert the locking order of page_lock
and transaction start" caused __ext4_journalled_writepage() to drop
the page lock before the page was written back, as part of changing
the locking order to jbd2_journal_start -> page_lock. However, this
introduced a potential race if there was a truncate racing with the
data=journalled writeback mode.
Fix this by grabbing the page lock after starting the journal handle,
and then checking to see if page had gotten truncated out from under
us.
This fixes a number of different warnings or BUG_ON's when running
xfstests generic/086 in data=journalled mode, including:
jbd2_journal_dirty_metadata: vdc-8: bad jh for block 115643: transaction (ee3fe7
c0, 164), jh->b_transaction ( (null), 0), jh->b_next_transaction ( (null), 0), jlist 0
- and -
kernel BUG at /usr/projects/linux/ext4/fs/jbd2/transaction.c:2200!
...
Call Trace:
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c02b2de5>] __ext4_journalled_invalidatepage+0x10f/0x117
[<c02b2ded>] ? __ext4_journalled_invalidatepage+0x117/0x117
[<c027d883>] ? lock_buffer+0x36/0x36
[<c02b2dfa>] ext4_journalled_invalidatepage+0xd/0x22
[<c0229139>] do_invalidatepage+0x22/0x26
[<c0229198>] truncate_inode_page+0x5b/0x85
[<c022934b>] truncate_inode_pages_range+0x156/0x38c
[<c0229592>] truncate_inode_pages+0x11/0x15
[<c022962d>] truncate_pagecache+0x55/0x71
[<c02b913b>] ext4_setattr+0x4a9/0x560
[<c01ca542>] ? current_kernel_time+0x10/0x44
[<c026c4d8>] notify_change+0x1c7/0x2be
[<c0256a00>] do_truncate+0x65/0x85
[<c0226f31>] ? file_ra_state_init+0x12/0x29
- and -
WARNING: CPU: 1 PID: 1331 at /usr/projects/linux/ext4/fs/jbd2/transaction.c:1396
irty_metadata+0x14a/0x1ae()
...
Call Trace:
[<c01b879f>] ? console_unlock+0x3a1/0x3ce
[<c082cbb4>] dump_stack+0x48/0x60
[<c0178b65>] warn_slowpath_common+0x89/0xa0
[<c02ef2cf>] ? jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c0178bef>] warn_slowpath_null+0x14/0x18
[<c02ef2cf>] jbd2_journal_dirty_metadata+0x14a/0x1ae
[<c02d8615>] __ext4_handle_dirty_metadata+0xd4/0x19d
[<c02b2f44>] write_end_fn+0x40/0x53
[<c02b4a16>] ext4_walk_page_buffers+0x4e/0x6a
[<c02b59e7>] ext4_writepage+0x354/0x3b8
[<c02b2f04>] ? mpage_release_unused_pages+0xd4/0xd4
[<c02b1b21>] ? wait_on_buffer+0x2c/0x2c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b5a5b>] __writepage+0x10/0x2e
[<c0225956>] write_cache_pages+0x22d/0x32c
[<c02b5a4b>] ? ext4_writepage+0x3b8/0x3b8
[<c02b6ee8>] ext4_writepages+0x102/0x607
[<c019adfe>] ? sched_clock_local+0x10/0x10e
[<c01a8a7c>] ? __lock_is_held+0x2e/0x44
[<c01a8ad5>] ? lock_is_held+0x43/0x51
[<c0226dff>] do_writepages+0x1c/0x29
[<c0276bed>] __writeback_single_inode+0xc3/0x545
[<c0277c07>] writeback_sb_inodes+0x21f/0x36d
...
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2015-06-13 05:45:33 +02:00
|
|
|
unlock_page(page);
|
|
|
|
out_no_pagelock:
|
2012-12-10 20:05:57 +01:00
|
|
|
brelse(inode_bh);
|
2009-06-14 23:59:34 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
2009-06-14 23:58:45 +02:00
|
|
|
* Note that we don't need to start a transaction unless we're journaling data
|
|
|
|
* because we should have holes filled from ext4_page_mkwrite(). We even don't
|
|
|
|
* need to file the inode to the transaction's list in ordered mode because if
|
|
|
|
* we are writing back data added by write(), the inode is already there and if
|
2011-03-31 03:57:33 +02:00
|
|
|
* we are writing back data modified via mmap(), no one guarantees in which
|
2009-06-14 23:58:45 +02:00
|
|
|
* transaction the data will hit the disk. In case we are journaling data, we
|
|
|
|
* cannot start transaction directly because transaction start ranks above page
|
|
|
|
* lock so we have to do some magic.
|
|
|
|
*
|
2009-05-14 06:54:29 +02:00
|
|
|
* This function can get called via...
|
2013-06-06 20:00:46 +02:00
|
|
|
* - ext4_writepages after taking page lock (have journal handle)
|
2009-05-14 06:54:29 +02:00
|
|
|
* - journal_submit_inode_data_buffers (no journal handle)
|
2012-07-25 17:12:04 +02:00
|
|
|
* - shrink_page_list via the kswapd/direct reclaim (no journal handle)
|
2009-05-14 06:54:29 +02:00
|
|
|
* - grab_page_cache when doing write_begin (have journal handle)
|
2009-06-14 23:58:45 +02:00
|
|
|
*
|
|
|
|
* We don't do any block allocation in this function. If we have page with
|
|
|
|
* multiple blocks we need to write those buffer_heads that are mapped. This
|
|
|
|
* is important for mmaped based write. So if we do with blocksize 1K
|
|
|
|
* truncate(f, 1024);
|
|
|
|
* a = mmap(f, 0, 4096);
|
|
|
|
* a[0] = 'a';
|
|
|
|
* truncate(f, 4096);
|
|
|
|
* we have in the page first buffer_head mapped via page_mkwrite call back
|
2011-12-05 13:00:34 +01:00
|
|
|
* but other buffer_heads would be unmapped but dirty (dirty done via the
|
2009-06-14 23:58:45 +02:00
|
|
|
* do_wp_page). So writepage should write the first block. If we modify
|
|
|
|
* the mmap area beyond 1024 we will again get a page_fault and the
|
|
|
|
* page_mkwrite callback will do the block allocation and mark the
|
|
|
|
* buffer_heads mapped.
|
|
|
|
*
|
|
|
|
* We redirty the page if we have any buffer_heads that is either delay or
|
|
|
|
* unwritten in the page.
|
|
|
|
*
|
|
|
|
* We can get recursively called as show below.
|
|
|
|
*
|
|
|
|
* ext4_writepage() -> kmalloc() -> __alloc_pages() -> page_launder() ->
|
|
|
|
* ext4_writepage()
|
|
|
|
*
|
|
|
|
* But since we don't do any block allocation we should not deadlock.
|
|
|
|
* Page also have the dirty flag cleared so we don't get recurive page_lock.
|
2008-07-12 01:27:31 +02:00
|
|
|
*/
|
2009-06-14 23:58:45 +02:00
|
|
|
static int ext4_writepage(struct page *page,
|
2009-06-14 23:59:34 +02:00
|
|
|
struct writeback_control *wbc)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
2013-01-28 18:55:08 +01:00
|
|
|
int ret = 0;
|
2008-07-12 01:27:31 +02:00
|
|
|
loff_t size;
|
2008-11-05 06:14:04 +01:00
|
|
|
unsigned int len;
|
2010-03-04 22:14:02 +01:00
|
|
|
struct buffer_head *page_bufs = NULL;
|
2008-07-12 01:27:31 +02:00
|
|
|
struct inode *inode = page->mapping->host;
|
2013-01-28 15:30:52 +01:00
|
|
|
struct ext4_io_submit io_submit;
|
2014-05-12 14:12:25 +02:00
|
|
|
bool keep_towrite = false;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2011-06-06 15:51:52 +02:00
|
|
|
trace_ext4_writepage(page);
|
2008-07-12 01:27:31 +02:00
|
|
|
size = i_size_read(inode);
|
|
|
|
if (page->index == size >> PAGE_CACHE_SHIFT)
|
|
|
|
len = size & ~PAGE_CACHE_MASK;
|
|
|
|
else
|
|
|
|
len = PAGE_CACHE_SIZE;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2010-10-28 03:30:09 +02:00
|
|
|
page_bufs = page_buffers(page);
|
|
|
|
/*
|
2013-01-29 03:06:42 +01:00
|
|
|
* We cannot do block allocation or other extent handling in this
|
|
|
|
* function. If there are buffers needing that, we have to redirty
|
|
|
|
* the page. But we may reach here when we do a journal commit via
|
|
|
|
* journal_submit_inode_data_buffers() and in that case we must write
|
|
|
|
* allocated buffers to achieve data=ordered mode guarantees.
|
2015-10-03 16:49:23 +02:00
|
|
|
*
|
|
|
|
* Also, if there is only one buffer per page (the fs block
|
|
|
|
* size == the page size), if one buffer needs block
|
|
|
|
* allocation or needs to modify the extent tree to clear the
|
|
|
|
* unwritten flag, we know that the page can't be written at
|
|
|
|
* all, so we might as well refuse the write immediately.
|
|
|
|
* Unfortunately if the block size != page size, we can't as
|
|
|
|
* easily detect this case using ext4_walk_page_buffers(), but
|
|
|
|
* for the extremely common case, this is an optimization that
|
|
|
|
* skips a useless round trip through ext4_bio_write_page().
|
2010-10-28 03:30:09 +02:00
|
|
|
*/
|
2012-12-10 20:05:51 +01:00
|
|
|
if (ext4_walk_page_buffers(NULL, page_bufs, 0, len, NULL,
|
|
|
|
ext4_bh_delay_or_unwritten)) {
|
2013-01-28 18:55:08 +01:00
|
|
|
redirty_page_for_writepage(wbc, page);
|
2015-10-03 16:49:23 +02:00
|
|
|
if ((current->flags & PF_MEMALLOC) ||
|
|
|
|
(inode->i_sb->s_blocksize == PAGE_CACHE_SIZE)) {
|
2013-01-29 03:06:42 +01:00
|
|
|
/*
|
|
|
|
* For memory cleaning there's no point in writing only
|
|
|
|
* some buffers. So just bail out. Warn if we came here
|
|
|
|
* from direct reclaim.
|
|
|
|
*/
|
|
|
|
WARN_ON_ONCE((current->flags & (PF_MEMALLOC|PF_KSWAPD))
|
|
|
|
== PF_MEMALLOC);
|
2008-07-12 01:27:31 +02:00
|
|
|
unlock_page(page);
|
|
|
|
return 0;
|
|
|
|
}
|
2014-05-12 14:12:25 +02:00
|
|
|
keep_towrite = true;
|
2010-10-28 03:30:09 +02:00
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2010-10-28 03:30:09 +02:00
|
|
|
if (PageChecked(page) && ext4_should_journal_data(inode))
|
2009-06-14 23:58:45 +02:00
|
|
|
/*
|
|
|
|
* It's mmapped pagecache. Add buffers and journal it. There
|
|
|
|
* doesn't seem much point in redirtying the page here.
|
|
|
|
*/
|
2009-11-24 17:15:44 +01:00
|
|
|
return __ext4_journalled_writepage(page, len);
|
2009-06-14 23:58:45 +02:00
|
|
|
|
2013-06-04 17:58:58 +02:00
|
|
|
ext4_io_submit_init(&io_submit, wbc);
|
|
|
|
io_submit.io_end = ext4_init_io_end(inode, GFP_NOFS);
|
|
|
|
if (!io_submit.io_end) {
|
|
|
|
redirty_page_for_writepage(wbc, page);
|
|
|
|
unlock_page(page);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
2014-05-12 14:12:25 +02:00
|
|
|
ret = ext4_bio_write_page(&io_submit, page, len, wbc, keep_towrite);
|
2013-01-28 15:30:52 +01:00
|
|
|
ext4_io_submit(&io_submit);
|
2013-06-04 17:58:58 +02:00
|
|
|
/* Drop io_end reference we got from init */
|
|
|
|
ext4_put_io_end_defer(io_submit.io_end);
|
2008-07-12 01:27:31 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2013-08-17 16:02:33 +02:00
|
|
|
static int mpage_submit_page(struct mpage_da_data *mpd, struct page *page)
|
|
|
|
{
|
|
|
|
int len;
|
|
|
|
loff_t size = i_size_read(mpd->inode);
|
|
|
|
int err;
|
|
|
|
|
|
|
|
BUG_ON(page->index != mpd->first_page);
|
|
|
|
if (page->index == size >> PAGE_CACHE_SHIFT)
|
|
|
|
len = size & ~PAGE_CACHE_MASK;
|
|
|
|
else
|
|
|
|
len = PAGE_CACHE_SIZE;
|
|
|
|
clear_page_dirty_for_io(page);
|
2014-05-12 14:12:25 +02:00
|
|
|
err = ext4_bio_write_page(&mpd->io_submit, page, len, mpd->wbc, false);
|
2013-08-17 16:02:33 +02:00
|
|
|
if (!err)
|
|
|
|
mpd->wbc->nr_to_write--;
|
|
|
|
mpd->first_page++;
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
#define BH_FLAGS ((1 << BH_Unwritten) | (1 << BH_Delay))
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
2013-06-04 19:01:11 +02:00
|
|
|
* mballoc gives us at most this number of blocks...
|
|
|
|
* XXX: That seems to be only a limitation of ext4_mb_normalize_request().
|
2013-08-28 20:40:12 +02:00
|
|
|
* The rest of mballoc seems to handle chunks up to full group size.
|
2008-07-12 01:27:31 +02:00
|
|
|
*/
|
2013-06-04 19:01:11 +02:00
|
|
|
#define MAX_WRITEPAGES_EXTENT_LEN 2048
|
2008-08-20 04:15:58 +02:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
/*
|
|
|
|
* mpage_add_bh_to_extent - try to add bh to extent of blocks to map
|
|
|
|
*
|
|
|
|
* @mpd - extent of blocks
|
|
|
|
* @lblk - logical number of the block in the file
|
2013-08-17 15:57:56 +02:00
|
|
|
* @bh - buffer head we want to add to the extent
|
2013-06-04 19:17:40 +02:00
|
|
|
*
|
2013-08-17 15:57:56 +02:00
|
|
|
* The function is used to collect contig. blocks in the same state. If the
|
|
|
|
* buffer doesn't require mapping for writeback and we haven't started the
|
|
|
|
* extent of buffers to map yet, the function returns 'true' immediately - the
|
|
|
|
* caller can write the buffer right away. Otherwise the function returns true
|
|
|
|
* if the block has been added to the extent, false if the block couldn't be
|
|
|
|
* added.
|
2013-06-04 19:17:40 +02:00
|
|
|
*/
|
2013-08-17 15:57:56 +02:00
|
|
|
static bool mpage_add_bh_to_extent(struct mpage_da_data *mpd, ext4_lblk_t lblk,
|
|
|
|
struct buffer_head *bh)
|
2013-06-04 19:17:40 +02:00
|
|
|
{
|
|
|
|
struct ext4_map_blocks *map = &mpd->map;
|
|
|
|
|
2013-08-17 15:57:56 +02:00
|
|
|
/* Buffer that doesn't need mapping for writeback? */
|
|
|
|
if (!buffer_dirty(bh) || !buffer_mapped(bh) ||
|
|
|
|
(!buffer_delay(bh) && !buffer_unwritten(bh))) {
|
|
|
|
/* So far no extent to map => we write the buffer right away */
|
|
|
|
if (map->m_len == 0)
|
|
|
|
return true;
|
|
|
|
return false;
|
|
|
|
}
|
2013-06-04 19:17:40 +02:00
|
|
|
|
|
|
|
/* First block in the extent? */
|
|
|
|
if (map->m_len == 0) {
|
|
|
|
map->m_lblk = lblk;
|
|
|
|
map->m_len = 1;
|
2013-08-17 15:57:56 +02:00
|
|
|
map->m_flags = bh->b_state & BH_FLAGS;
|
|
|
|
return true;
|
2013-06-04 19:17:40 +02:00
|
|
|
}
|
|
|
|
|
2013-08-17 15:57:56 +02:00
|
|
|
/* Don't go larger than mballoc is willing to allocate */
|
|
|
|
if (map->m_len >= MAX_WRITEPAGES_EXTENT_LEN)
|
|
|
|
return false;
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
/* Can we merge the block to our big extent? */
|
|
|
|
if (lblk == map->m_lblk + map->m_len &&
|
2013-08-17 15:57:56 +02:00
|
|
|
(bh->b_state & BH_FLAGS) == map->m_flags) {
|
2013-06-04 19:17:40 +02:00
|
|
|
map->m_len++;
|
2013-08-17 15:57:56 +02:00
|
|
|
return true;
|
2013-06-04 19:17:40 +02:00
|
|
|
}
|
2013-08-17 15:57:56 +02:00
|
|
|
return false;
|
2013-06-04 19:17:40 +02:00
|
|
|
}
|
|
|
|
|
2013-08-17 16:02:33 +02:00
|
|
|
/*
|
|
|
|
* mpage_process_page_bufs - submit page buffers for IO or add them to extent
|
|
|
|
*
|
|
|
|
* @mpd - extent of blocks for mapping
|
|
|
|
* @head - the first buffer in the page
|
|
|
|
* @bh - buffer we should start processing from
|
|
|
|
* @lblk - logical number of the block in the file corresponding to @bh
|
|
|
|
*
|
|
|
|
* Walk through page buffers from @bh upto @head (exclusive) and either submit
|
|
|
|
* the page for IO if all buffers in this page were mapped and there's no
|
|
|
|
* accumulated extent of buffers to map or add buffers in the page to the
|
|
|
|
* extent of buffers to map. The function returns 1 if the caller can continue
|
|
|
|
* by processing the next page, 0 if it should stop adding buffers to the
|
|
|
|
* extent to map because we cannot extend it anymore. It can also return value
|
|
|
|
* < 0 in case of error during IO submission.
|
|
|
|
*/
|
|
|
|
static int mpage_process_page_bufs(struct mpage_da_data *mpd,
|
|
|
|
struct buffer_head *head,
|
|
|
|
struct buffer_head *bh,
|
|
|
|
ext4_lblk_t lblk)
|
2013-06-04 19:17:40 +02:00
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
2013-08-17 16:02:33 +02:00
|
|
|
int err;
|
2013-06-04 19:17:40 +02:00
|
|
|
ext4_lblk_t blocks = (i_size_read(inode) + (1 << inode->i_blkbits) - 1)
|
|
|
|
>> inode->i_blkbits;
|
|
|
|
|
|
|
|
do {
|
|
|
|
BUG_ON(buffer_locked(bh));
|
|
|
|
|
2013-08-17 15:57:56 +02:00
|
|
|
if (lblk >= blocks || !mpage_add_bh_to_extent(mpd, lblk, bh)) {
|
2013-06-04 19:17:40 +02:00
|
|
|
/* Found extent to map? */
|
|
|
|
if (mpd->map.m_len)
|
2013-08-17 16:02:33 +02:00
|
|
|
return 0;
|
2013-08-17 15:57:56 +02:00
|
|
|
/* Everything mapped so far and we hit EOF */
|
2013-08-17 16:02:33 +02:00
|
|
|
break;
|
2013-06-04 19:17:40 +02:00
|
|
|
}
|
|
|
|
} while (lblk++, (bh = bh->b_this_page) != head);
|
2013-08-17 16:02:33 +02:00
|
|
|
/* So far everything mapped? Submit the page for IO. */
|
|
|
|
if (mpd->map.m_len == 0) {
|
|
|
|
err = mpage_submit_page(mpd, head->b_page);
|
|
|
|
if (err < 0)
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
return lblk < blocks;
|
2013-06-04 19:17:40 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* mpage_map_buffers - update buffers corresponding to changed extent and
|
|
|
|
* submit fully mapped pages for IO
|
|
|
|
*
|
|
|
|
* @mpd - description of extent to map, on return next extent to map
|
|
|
|
*
|
|
|
|
* Scan buffers corresponding to changed extent (we expect corresponding pages
|
|
|
|
* to be already locked) and update buffer state according to new extent state.
|
|
|
|
* We map delalloc buffers to their physical location, clear unwritten bits,
|
2014-04-21 05:45:47 +02:00
|
|
|
* and mark buffers as uninit when we perform writes to unwritten extents
|
2013-06-04 19:17:40 +02:00
|
|
|
* and do extent conversion after IO is finished. If the last page is not fully
|
|
|
|
* mapped, we update @map to the next extent in the last page that needs
|
|
|
|
* mapping. Otherwise we submit the page for IO.
|
|
|
|
*/
|
|
|
|
static int mpage_map_and_submit_buffers(struct mpage_da_data *mpd)
|
|
|
|
{
|
|
|
|
struct pagevec pvec;
|
|
|
|
int nr_pages, i;
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct buffer_head *head, *bh;
|
|
|
|
int bpp_bits = PAGE_CACHE_SHIFT - inode->i_blkbits;
|
|
|
|
pgoff_t start, end;
|
|
|
|
ext4_lblk_t lblk;
|
|
|
|
sector_t pblock;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
start = mpd->map.m_lblk >> bpp_bits;
|
|
|
|
end = (mpd->map.m_lblk + mpd->map.m_len - 1) >> bpp_bits;
|
|
|
|
lblk = start << bpp_bits;
|
|
|
|
pblock = mpd->map.m_pblk;
|
|
|
|
|
|
|
|
pagevec_init(&pvec, 0);
|
|
|
|
while (start <= end) {
|
|
|
|
nr_pages = pagevec_lookup(&pvec, inode->i_mapping, start,
|
|
|
|
PAGEVEC_SIZE);
|
|
|
|
if (nr_pages == 0)
|
|
|
|
break;
|
|
|
|
for (i = 0; i < nr_pages; i++) {
|
|
|
|
struct page *page = pvec.pages[i];
|
|
|
|
|
|
|
|
if (page->index > end)
|
|
|
|
break;
|
2013-08-28 20:40:12 +02:00
|
|
|
/* Up to 'end' pages must be contiguous */
|
2013-06-04 19:17:40 +02:00
|
|
|
BUG_ON(page->index != start);
|
|
|
|
bh = head = page_buffers(page);
|
|
|
|
do {
|
|
|
|
if (lblk < mpd->map.m_lblk)
|
|
|
|
continue;
|
|
|
|
if (lblk >= mpd->map.m_lblk + mpd->map.m_len) {
|
|
|
|
/*
|
|
|
|
* Buffer after end of mapped extent.
|
|
|
|
* Find next buffer in the page to map.
|
|
|
|
*/
|
|
|
|
mpd->map.m_len = 0;
|
|
|
|
mpd->map.m_flags = 0;
|
2013-08-17 16:02:33 +02:00
|
|
|
/*
|
|
|
|
* FIXME: If dioread_nolock supports
|
|
|
|
* blocksize < pagesize, we need to make
|
|
|
|
* sure we add size mapped so far to
|
|
|
|
* io_end->size as the following call
|
|
|
|
* can submit the page for IO.
|
|
|
|
*/
|
|
|
|
err = mpage_process_page_bufs(mpd, head,
|
|
|
|
bh, lblk);
|
2013-06-04 19:17:40 +02:00
|
|
|
pagevec_release(&pvec);
|
2013-08-17 16:02:33 +02:00
|
|
|
if (err > 0)
|
|
|
|
err = 0;
|
|
|
|
return err;
|
2013-06-04 19:17:40 +02:00
|
|
|
}
|
|
|
|
if (buffer_delay(bh)) {
|
|
|
|
clear_buffer_delay(bh);
|
|
|
|
bh->b_blocknr = pblock++;
|
|
|
|
}
|
|
|
|
clear_buffer_unwritten(bh);
|
2013-08-17 16:02:33 +02:00
|
|
|
} while (lblk++, (bh = bh->b_this_page) != head);
|
2013-06-04 19:17:40 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* FIXME: This is going to break if dioread_nolock
|
|
|
|
* supports blocksize < pagesize as we will try to
|
|
|
|
* convert potentially unmapped parts of inode.
|
|
|
|
*/
|
|
|
|
mpd->io_submit.io_end->size += PAGE_CACHE_SIZE;
|
|
|
|
/* Page fully mapped - let IO run! */
|
|
|
|
err = mpage_submit_page(mpd, page);
|
|
|
|
if (err < 0) {
|
|
|
|
pagevec_release(&pvec);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
start++;
|
|
|
|
}
|
|
|
|
pagevec_release(&pvec);
|
|
|
|
}
|
|
|
|
/* Extent fully mapped and matches with page boundary. We are done. */
|
|
|
|
mpd->map.m_len = 0;
|
|
|
|
mpd->map.m_flags = 0;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int mpage_map_one_extent(handle_t *handle, struct mpage_da_data *mpd)
|
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct ext4_map_blocks *map = &mpd->map;
|
|
|
|
int get_blocks_flags;
|
2014-04-21 05:44:47 +02:00
|
|
|
int err, dioread_nolock;
|
2013-06-04 19:17:40 +02:00
|
|
|
|
|
|
|
trace_ext4_da_write_pages_extent(inode, map);
|
|
|
|
/*
|
|
|
|
* Call ext4_map_blocks() to allocate any delayed allocation blocks, or
|
2014-04-21 05:45:47 +02:00
|
|
|
* to convert an unwritten extent to be initialized (in the case
|
2013-06-04 19:17:40 +02:00
|
|
|
* where we have written into one or more preallocated blocks). It is
|
|
|
|
* possible that we're going to need more metadata blocks than
|
|
|
|
* previously reserved. However we must not fail because we're in
|
|
|
|
* writeback and there is nothing we can do about it so it might result
|
|
|
|
* in data loss. So use reserved blocks to allocate metadata if
|
|
|
|
* possible.
|
|
|
|
*
|
2014-09-05 00:08:22 +02:00
|
|
|
* We pass in the magic EXT4_GET_BLOCKS_DELALLOC_RESERVE if
|
|
|
|
* the blocks in question are delalloc blocks. This indicates
|
|
|
|
* that the blocks and quotas has already been checked when
|
|
|
|
* the data was copied into the page cache.
|
2013-06-04 19:17:40 +02:00
|
|
|
*/
|
|
|
|
get_blocks_flags = EXT4_GET_BLOCKS_CREATE |
|
|
|
|
EXT4_GET_BLOCKS_METADATA_NOFAIL;
|
2014-04-21 05:44:47 +02:00
|
|
|
dioread_nolock = ext4_should_dioread_nolock(inode);
|
|
|
|
if (dioread_nolock)
|
2013-06-04 19:17:40 +02:00
|
|
|
get_blocks_flags |= EXT4_GET_BLOCKS_IO_CREATE_EXT;
|
|
|
|
if (map->m_flags & (1 << BH_Delay))
|
|
|
|
get_blocks_flags |= EXT4_GET_BLOCKS_DELALLOC_RESERVE;
|
|
|
|
|
|
|
|
err = ext4_map_blocks(handle, inode, map, get_blocks_flags);
|
|
|
|
if (err < 0)
|
|
|
|
return err;
|
2014-04-21 05:44:47 +02:00
|
|
|
if (dioread_nolock && (map->m_flags & EXT4_MAP_UNWRITTEN)) {
|
2013-06-04 19:21:11 +02:00
|
|
|
if (!mpd->io_submit.io_end->handle &&
|
|
|
|
ext4_handle_valid(handle)) {
|
|
|
|
mpd->io_submit.io_end->handle = handle->h_rsv_handle;
|
|
|
|
handle->h_rsv_handle = NULL;
|
|
|
|
}
|
2013-06-04 19:19:34 +02:00
|
|
|
ext4_set_io_unwritten_flag(inode, mpd->io_submit.io_end);
|
2013-06-04 19:21:11 +02:00
|
|
|
}
|
2013-06-04 19:17:40 +02:00
|
|
|
|
|
|
|
BUG_ON(map->m_len == 0);
|
|
|
|
if (map->m_flags & EXT4_MAP_NEW) {
|
|
|
|
struct block_device *bdev = inode->i_sb->s_bdev;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
for (i = 0; i < map->m_len; i++)
|
|
|
|
unmap_underlying_metadata(bdev, map->m_pblk + i);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* mpage_map_and_submit_extent - map extent starting at mpd->lblk of length
|
|
|
|
* mpd->len and submit pages underlying it for IO
|
|
|
|
*
|
|
|
|
* @handle - handle for journal operations
|
|
|
|
* @mpd - extent to map
|
2013-10-16 14:26:08 +02:00
|
|
|
* @give_up_on_write - we set this to true iff there is a fatal error and there
|
|
|
|
* is no hope of writing the data. The caller should discard
|
|
|
|
* dirty pages to avoid infinite loops.
|
2013-06-04 19:17:40 +02:00
|
|
|
*
|
|
|
|
* The function maps extent starting at mpd->lblk of length mpd->len. If it is
|
|
|
|
* delayed, blocks are allocated, if it is unwritten, we may need to convert
|
|
|
|
* them to initialized or split the described range from larger unwritten
|
|
|
|
* extent. Note that we need not map all the described range since allocation
|
|
|
|
* can return less blocks or the range is covered by more unwritten extents. We
|
|
|
|
* cannot map more because we are limited by reserved transaction credits. On
|
|
|
|
* the other hand we always make sure that the last touched page is fully
|
|
|
|
* mapped so that it can be written out (and thus forward progress is
|
|
|
|
* guaranteed). After mapping we submit all mapped pages for IO.
|
|
|
|
*/
|
|
|
|
static int mpage_map_and_submit_extent(handle_t *handle,
|
2013-07-01 14:12:40 +02:00
|
|
|
struct mpage_da_data *mpd,
|
|
|
|
bool *give_up_on_write)
|
2013-06-04 19:17:40 +02:00
|
|
|
{
|
|
|
|
struct inode *inode = mpd->inode;
|
|
|
|
struct ext4_map_blocks *map = &mpd->map;
|
|
|
|
int err;
|
|
|
|
loff_t disksize;
|
2014-08-28 00:40:03 +02:00
|
|
|
int progress = 0;
|
2013-06-04 19:17:40 +02:00
|
|
|
|
|
|
|
mpd->io_submit.io_end->offset =
|
|
|
|
((loff_t)map->m_lblk) << inode->i_blkbits;
|
2013-07-06 03:57:22 +02:00
|
|
|
do {
|
2013-06-04 19:17:40 +02:00
|
|
|
err = mpage_map_one_extent(handle, mpd);
|
|
|
|
if (err < 0) {
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
|
2013-07-01 14:12:40 +02:00
|
|
|
if (EXT4_SB(sb)->s_mount_flags & EXT4_MF_FS_ABORTED)
|
|
|
|
goto invalidate_dirty_pages;
|
2013-06-04 19:17:40 +02:00
|
|
|
/*
|
2013-07-01 14:12:40 +02:00
|
|
|
* Let the uper layers retry transient errors.
|
|
|
|
* In the case of ENOSPC, if ext4_count_free_blocks()
|
|
|
|
* is non-zero, a commit should free up blocks.
|
2013-06-04 19:17:40 +02:00
|
|
|
*/
|
2013-07-01 14:12:40 +02:00
|
|
|
if ((err == -ENOMEM) ||
|
2014-08-28 00:40:03 +02:00
|
|
|
(err == -ENOSPC && ext4_count_free_clusters(sb))) {
|
|
|
|
if (progress)
|
|
|
|
goto update_disksize;
|
2013-07-01 14:12:40 +02:00
|
|
|
return err;
|
2014-08-28 00:40:03 +02:00
|
|
|
}
|
2013-07-01 14:12:40 +02:00
|
|
|
ext4_msg(sb, KERN_CRIT,
|
|
|
|
"Delayed block allocation failed for "
|
|
|
|
"inode %lu at logical offset %llu with"
|
|
|
|
" max blocks %u with error %d",
|
|
|
|
inode->i_ino,
|
|
|
|
(unsigned long long)map->m_lblk,
|
|
|
|
(unsigned)map->m_len, -err);
|
|
|
|
ext4_msg(sb, KERN_CRIT,
|
|
|
|
"This should not happen!! Data will "
|
|
|
|
"be lost\n");
|
|
|
|
if (err == -ENOSPC)
|
|
|
|
ext4_print_free_blocks(inode);
|
|
|
|
invalidate_dirty_pages:
|
|
|
|
*give_up_on_write = true;
|
2013-06-04 19:17:40 +02:00
|
|
|
return err;
|
|
|
|
}
|
2014-08-28 00:40:03 +02:00
|
|
|
progress = 1;
|
2013-06-04 19:17:40 +02:00
|
|
|
/*
|
|
|
|
* Update buffer state, submit mapped pages, and get us new
|
|
|
|
* extent to map
|
|
|
|
*/
|
|
|
|
err = mpage_map_and_submit_buffers(mpd);
|
|
|
|
if (err < 0)
|
2014-08-28 00:40:03 +02:00
|
|
|
goto update_disksize;
|
2013-07-06 03:57:22 +02:00
|
|
|
} while (map->m_len);
|
2013-06-04 19:17:40 +02:00
|
|
|
|
2014-08-28 00:40:03 +02:00
|
|
|
update_disksize:
|
2014-04-11 16:35:17 +02:00
|
|
|
/*
|
|
|
|
* Update on-disk size after IO is submitted. Races with
|
|
|
|
* truncate are avoided by checking i_size under i_data_sem.
|
|
|
|
*/
|
2013-06-04 19:17:40 +02:00
|
|
|
disksize = ((loff_t)mpd->first_page) << PAGE_CACHE_SHIFT;
|
|
|
|
if (disksize > EXT4_I(inode)->i_disksize) {
|
|
|
|
int err2;
|
2014-04-11 16:35:17 +02:00
|
|
|
loff_t i_size;
|
|
|
|
|
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
i_size = i_size_read(inode);
|
|
|
|
if (disksize > i_size)
|
|
|
|
disksize = i_size;
|
|
|
|
if (disksize > EXT4_I(inode)->i_disksize)
|
|
|
|
EXT4_I(inode)->i_disksize = disksize;
|
2013-06-04 19:17:40 +02:00
|
|
|
err2 = ext4_mark_inode_dirty(handle, inode);
|
2014-04-11 16:35:17 +02:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2013-06-04 19:17:40 +02:00
|
|
|
if (err2)
|
|
|
|
ext4_error(inode->i_sb,
|
|
|
|
"Failed to mark inode %lu dirty",
|
|
|
|
inode->i_ino);
|
|
|
|
if (!err)
|
|
|
|
err = err2;
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2013-06-04 19:01:11 +02:00
|
|
|
/*
|
|
|
|
* Calculate the total number of credits to reserve for one writepages
|
2013-06-06 20:00:46 +02:00
|
|
|
* iteration. This is called from ext4_writepages(). We map an extent of
|
2013-08-28 20:40:12 +02:00
|
|
|
* up to MAX_WRITEPAGES_EXTENT_LEN blocks and then we go on and finish mapping
|
2013-06-04 19:01:11 +02:00
|
|
|
* the last partial page. So in total we can map MAX_WRITEPAGES_EXTENT_LEN +
|
|
|
|
* bpp - 1 blocks in bpp different extents.
|
|
|
|
*/
|
2008-08-20 04:15:58 +02:00
|
|
|
static int ext4_da_writepages_trans_blocks(struct inode *inode)
|
|
|
|
{
|
2013-06-04 19:01:11 +02:00
|
|
|
int bpp = ext4_journal_blocks_per_page(inode);
|
2008-08-20 04:15:58 +02:00
|
|
|
|
2013-06-04 19:01:11 +02:00
|
|
|
return ext4_meta_trans_blocks(inode,
|
|
|
|
MAX_WRITEPAGES_EXTENT_LEN + bpp - 1, bpp);
|
2008-08-20 04:15:58 +02:00
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2010-05-17 00:00:00 +02:00
|
|
|
/*
|
2013-06-04 19:17:40 +02:00
|
|
|
* mpage_prepare_extent_to_map - find & lock contiguous range of dirty pages
|
|
|
|
* and underlying extent to map
|
|
|
|
*
|
|
|
|
* @mpd - where to look for pages
|
|
|
|
*
|
|
|
|
* Walk dirty pages in the mapping. If they are fully mapped, submit them for
|
|
|
|
* IO immediately. When we find a page which isn't mapped we start accumulating
|
|
|
|
* extent of buffers underlying these pages that needs mapping (formed by
|
|
|
|
* either delayed or unwritten buffers). We also lock the pages containing
|
|
|
|
* these buffers. The extent found is returned in @mpd structure (starting at
|
|
|
|
* mpd->lblk with length mpd->len blocks).
|
|
|
|
*
|
|
|
|
* Note that this function can attach bios to one io_end structure which are
|
|
|
|
* neither logically nor physically contiguous. Although it may seem as an
|
|
|
|
* unnecessary complication, it is actually inevitable in blocksize < pagesize
|
|
|
|
* case as we need to track IO to all buffers underlying a page in one io_end.
|
2010-05-17 00:00:00 +02:00
|
|
|
*/
|
2013-06-04 19:17:40 +02:00
|
|
|
static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
|
2010-05-17 00:00:00 +02:00
|
|
|
{
|
2013-06-04 19:17:40 +02:00
|
|
|
struct address_space *mapping = mpd->inode->i_mapping;
|
|
|
|
struct pagevec pvec;
|
|
|
|
unsigned int nr_pages;
|
2013-10-18 00:56:16 +02:00
|
|
|
long left = mpd->wbc->nr_to_write;
|
2013-06-04 19:17:40 +02:00
|
|
|
pgoff_t index = mpd->first_page;
|
|
|
|
pgoff_t end = mpd->last_page;
|
|
|
|
int tag;
|
|
|
|
int i, err = 0;
|
|
|
|
int blkbits = mpd->inode->i_blkbits;
|
|
|
|
ext4_lblk_t lblk;
|
|
|
|
struct buffer_head *head;
|
2010-05-17 00:00:00 +02:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
if (mpd->wbc->sync_mode == WB_SYNC_ALL || mpd->wbc->tagged_writepages)
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 03:30:13 +02:00
|
|
|
tag = PAGECACHE_TAG_TOWRITE;
|
|
|
|
else
|
|
|
|
tag = PAGECACHE_TAG_DIRTY;
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
pagevec_init(&pvec, 0);
|
|
|
|
mpd->map.m_len = 0;
|
|
|
|
mpd->next_page = index;
|
2011-02-26 20:07:37 +01:00
|
|
|
while (index <= end) {
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 03:30:13 +02:00
|
|
|
nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, tag,
|
2010-05-17 00:00:00 +02:00
|
|
|
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1);
|
|
|
|
if (nr_pages == 0)
|
2013-06-04 19:17:40 +02:00
|
|
|
goto out;
|
2010-05-17 00:00:00 +02:00
|
|
|
|
|
|
|
for (i = 0; i < nr_pages; i++) {
|
|
|
|
struct page *page = pvec.pages[i];
|
|
|
|
|
|
|
|
/*
|
|
|
|
* At this point, the page may be truncated or
|
|
|
|
* invalidated (changing page->mapping to NULL), or
|
|
|
|
* even swizzled back from swapper_space to tmpfs file
|
|
|
|
* mapping. However, page->index will not change
|
|
|
|
* because we have a reference on the page.
|
|
|
|
*/
|
2011-02-26 20:07:37 +01:00
|
|
|
if (page->index > end)
|
|
|
|
goto out;
|
2010-05-17 00:00:00 +02:00
|
|
|
|
2013-10-18 00:56:16 +02:00
|
|
|
/*
|
|
|
|
* Accumulated enough dirty pages? This doesn't apply
|
|
|
|
* to WB_SYNC_ALL mode. For integrity sync we have to
|
|
|
|
* keep going because someone may be concurrently
|
|
|
|
* dirtying pages, and we might have synced a lot of
|
|
|
|
* newly appeared dirty pages, but have not synced all
|
|
|
|
* of the old dirty pages.
|
|
|
|
*/
|
|
|
|
if (mpd->wbc->sync_mode == WB_SYNC_NONE && left <= 0)
|
|
|
|
goto out;
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
/* If we can't merge this page, we are done. */
|
|
|
|
if (mpd->map.m_len > 0 && mpd->next_page != page->index)
|
|
|
|
goto out;
|
2011-02-26 20:09:14 +01:00
|
|
|
|
2010-05-17 00:00:00 +02:00
|
|
|
lock_page(page);
|
|
|
|
/*
|
2013-06-04 19:17:40 +02:00
|
|
|
* If the page is no longer dirty, or its mapping no
|
|
|
|
* longer corresponds to inode we are writing (which
|
|
|
|
* means it has been truncated or invalidated), or the
|
|
|
|
* page is already under writeback and we are not doing
|
|
|
|
* a data integrity writeback, skip the page
|
2010-05-17 00:00:00 +02:00
|
|
|
*/
|
2011-02-26 20:07:37 +01:00
|
|
|
if (!PageDirty(page) ||
|
|
|
|
(PageWriteback(page) &&
|
2013-06-04 19:17:40 +02:00
|
|
|
(mpd->wbc->sync_mode == WB_SYNC_NONE)) ||
|
2011-02-26 20:07:37 +01:00
|
|
|
unlikely(page->mapping != mapping)) {
|
2010-05-17 00:00:00 +02:00
|
|
|
unlock_page(page);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2011-05-18 19:53:20 +02:00
|
|
|
wait_on_page_writeback(page);
|
2010-05-17 00:00:00 +02:00
|
|
|
BUG_ON(PageWriteback(page));
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
if (mpd->map.m_len == 0)
|
2011-02-26 20:07:31 +01:00
|
|
|
mpd->first_page = page->index;
|
|
|
|
mpd->next_page = page->index + 1;
|
2013-01-28 18:55:08 +01:00
|
|
|
/* Add all dirty buffers to mpd */
|
2013-06-04 19:17:40 +02:00
|
|
|
lblk = ((ext4_lblk_t)page->index) <<
|
|
|
|
(PAGE_CACHE_SHIFT - blkbits);
|
2013-01-28 18:55:08 +01:00
|
|
|
head = page_buffers(page);
|
2013-08-17 16:02:33 +02:00
|
|
|
err = mpage_process_page_bufs(mpd, head, head, lblk);
|
|
|
|
if (err <= 0)
|
2013-06-04 19:17:40 +02:00
|
|
|
goto out;
|
2013-08-17 16:02:33 +02:00
|
|
|
err = 0;
|
2013-10-18 00:56:16 +02:00
|
|
|
left--;
|
2010-05-17 00:00:00 +02:00
|
|
|
}
|
|
|
|
pagevec_release(&pvec);
|
|
|
|
cond_resched();
|
|
|
|
}
|
2011-02-26 20:07:37 +01:00
|
|
|
return 0;
|
2011-02-26 20:07:31 +01:00
|
|
|
out:
|
|
|
|
pagevec_release(&pvec);
|
2013-06-04 19:17:40 +02:00
|
|
|
return err;
|
2010-05-17 00:00:00 +02:00
|
|
|
}
|
|
|
|
|
2013-06-06 20:00:46 +02:00
|
|
|
static int __writepage(struct page *page, struct writeback_control *wbc,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
struct address_space *mapping = data;
|
|
|
|
int ret = ext4_writepage(page, wbc);
|
|
|
|
mapping_set_error(mapping, ret);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext4_writepages(struct address_space *mapping,
|
|
|
|
struct writeback_control *wbc)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
2013-06-04 19:17:40 +02:00
|
|
|
pgoff_t writeback_index = 0;
|
|
|
|
long nr_to_write = wbc->nr_to_write;
|
2008-10-16 16:10:36 +02:00
|
|
|
int range_whole = 0;
|
2013-06-04 19:17:40 +02:00
|
|
|
int cycled = 1;
|
2008-07-12 01:27:31 +02:00
|
|
|
handle_t *handle = NULL;
|
2008-09-09 05:05:34 +02:00
|
|
|
struct mpage_da_data mpd;
|
2008-08-19 00:00:57 +02:00
|
|
|
struct inode *inode = mapping->host;
|
2013-06-04 19:21:11 +02:00
|
|
|
int needed_blocks, rsv_blocks = 0, ret = 0;
|
2008-08-19 00:00:57 +02:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(mapping->host->i_sb);
|
2013-06-04 19:17:40 +02:00
|
|
|
bool done;
|
2011-10-18 16:55:51 +02:00
|
|
|
struct blk_plug plug;
|
2013-07-01 14:12:40 +02:00
|
|
|
bool give_up_on_write = false;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2013-06-06 20:00:46 +02:00
|
|
|
trace_ext4_writepages(inode, wbc);
|
2009-01-04 02:03:21 +01:00
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
|
|
|
* No pages to write? This is mainly a kludge to avoid starting
|
|
|
|
* a transaction for special inodes like journal inode on last iput()
|
|
|
|
* because that could violate lock ordering on umount
|
|
|
|
*/
|
2008-08-20 03:55:02 +02:00
|
|
|
if (!mapping->nrpages || !mapping_tagged(mapping, PAGECACHE_TAG_DIRTY))
|
2013-10-30 12:27:16 +01:00
|
|
|
goto out_writepages;
|
2008-11-05 15:22:24 +01:00
|
|
|
|
2013-06-06 20:00:46 +02:00
|
|
|
if (ext4_should_journal_data(inode)) {
|
|
|
|
struct blk_plug plug;
|
|
|
|
|
|
|
|
blk_start_plug(&plug);
|
|
|
|
ret = write_cache_pages(mapping, wbc, __writepage, mapping);
|
|
|
|
blk_finish_plug(&plug);
|
2013-10-30 12:27:16 +01:00
|
|
|
goto out_writepages;
|
2013-06-06 20:00:46 +02:00
|
|
|
}
|
|
|
|
|
2008-11-05 15:22:24 +01:00
|
|
|
/*
|
|
|
|
* If the filesystem has aborted, it is read-only, so return
|
|
|
|
* right away instead of dumping stack traces later on that
|
|
|
|
* will obscure the real source of the problem. We test
|
2009-06-13 16:09:36 +02:00
|
|
|
* EXT4_MF_FS_ABORTED instead of sb->s_flag's MS_RDONLY because
|
2008-11-05 15:22:24 +01:00
|
|
|
* the latter could be true if the filesystem is mounted
|
2013-06-06 20:00:46 +02:00
|
|
|
* read-only, and in that case, ext4_writepages should
|
2008-11-05 15:22:24 +01:00
|
|
|
* *never* be called, so if that ever happens, we would want
|
|
|
|
* the stack trace.
|
|
|
|
*/
|
2013-10-30 12:27:16 +01:00
|
|
|
if (unlikely(sbi->s_mount_flags & EXT4_MF_FS_ABORTED)) {
|
|
|
|
ret = -EROFS;
|
|
|
|
goto out_writepages;
|
|
|
|
}
|
2008-11-05 15:22:24 +01:00
|
|
|
|
2013-06-04 19:21:11 +02:00
|
|
|
if (ext4_should_dioread_nolock(inode)) {
|
|
|
|
/*
|
2013-08-28 20:40:12 +02:00
|
|
|
* We may need to convert up to one extent per block in
|
2013-06-04 19:21:11 +02:00
|
|
|
* the page and we may dirty the inode.
|
|
|
|
*/
|
|
|
|
rsv_blocks = 1 + (PAGE_CACHE_SIZE >> inode->i_blkbits);
|
|
|
|
}
|
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
/*
|
|
|
|
* If we have inline data and arrive here, it means that
|
|
|
|
* we will soon create the block for the 1st page, so
|
|
|
|
* we'd better clear the inline data here.
|
|
|
|
*/
|
|
|
|
if (ext4_has_inline_data(inode)) {
|
|
|
|
/* Just inode will be modified... */
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 1);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
|
|
|
goto out_writepages;
|
|
|
|
}
|
|
|
|
BUG_ON(ext4_test_inode_state(inode,
|
|
|
|
EXT4_STATE_MAY_INLINE_DATA));
|
|
|
|
ext4_destroy_inline_data(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
}
|
|
|
|
|
2008-10-16 16:10:36 +02:00
|
|
|
if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX)
|
|
|
|
range_whole = 1;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2009-02-14 16:42:58 +01:00
|
|
|
if (wbc->range_cyclic) {
|
2013-06-04 19:17:40 +02:00
|
|
|
writeback_index = mapping->writeback_index;
|
|
|
|
if (writeback_index)
|
2009-02-14 16:42:58 +01:00
|
|
|
cycled = 0;
|
2013-06-04 19:17:40 +02:00
|
|
|
mpd.first_page = writeback_index;
|
|
|
|
mpd.last_page = -1;
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 03:30:13 +02:00
|
|
|
} else {
|
2013-06-04 19:17:40 +02:00
|
|
|
mpd.first_page = wbc->range_start >> PAGE_CACHE_SHIFT;
|
|
|
|
mpd.last_page = wbc->range_end >> PAGE_CACHE_SHIFT;
|
ext4: implement writeback livelock avoidance using page tagging
This is analogous to Jan Kara's commit,
f446daaea9d4a420d16c606f755f3689dcb2d0ce
mm: implement writeback livelock avoidance using page tagging
but since we forked write_cache_pages, we need to reimplement
it there (and in ext4_da_writepages, since range_cyclic handling
was moved to there)
If you start a large buffered IO to a file, and then set
fsync after it, you'll find that fsync does not complete
until the other IO stops.
If you continue re-dirtying the file (say, putting dd
with conv=notrunc in a loop), when fsync finally completes
(after all IO is done), it reports via tracing that
it has written many more pages than the file contains;
in other words it has synced and re-synced pages in
the file multiple times.
This then leads to problems with our writeback_index
update, since it advances it by pages written, and
essentially sets writeback_index off the end of the
file...
With the following patch, we only sync as much as was
dirty at the time of the sync.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2010-10-28 03:30:13 +02:00
|
|
|
}
|
2008-08-20 03:55:02 +02:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
mpd.inode = inode;
|
|
|
|
mpd.wbc = wbc;
|
|
|
|
ext4_io_submit_init(&mpd.io_submit, wbc);
|
2009-02-14 16:42:58 +01:00
|
|
|
retry:
|
2010-06-06 18:38:15 +02:00
|
|
|
if (wbc->sync_mode == WB_SYNC_ALL || wbc->tagged_writepages)
|
2013-06-04 19:17:40 +02:00
|
|
|
tag_pages_for_writeback(mapping, mpd.first_page, mpd.last_page);
|
|
|
|
done = false;
|
2011-10-18 16:55:51 +02:00
|
|
|
blk_start_plug(&plug);
|
2013-06-04 19:17:40 +02:00
|
|
|
while (!done && mpd.first_page <= mpd.last_page) {
|
|
|
|
/* For each extent of pages we use new io_end */
|
|
|
|
mpd.io_submit.io_end = ext4_init_io_end(inode, GFP_KERNEL);
|
|
|
|
if (!mpd.io_submit.io_end) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
break;
|
|
|
|
}
|
2008-08-20 03:55:02 +02:00
|
|
|
|
|
|
|
/*
|
2013-06-04 19:17:40 +02:00
|
|
|
* We have two constraints: We find one extent to map and we
|
|
|
|
* must always write out whole page (makes a difference when
|
|
|
|
* blocksize < pagesize) so that we don't block on IO when we
|
|
|
|
* try to write out the rest of the page. Journalled mode is
|
|
|
|
* not supported by delalloc.
|
2008-08-20 03:55:02 +02:00
|
|
|
*/
|
|
|
|
BUG_ON(ext4_should_journal_data(inode));
|
2008-08-20 04:15:58 +02:00
|
|
|
needed_blocks = ext4_da_writepages_trans_blocks(inode);
|
2008-08-20 03:55:02 +02:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
/* start a new transaction */
|
2013-06-04 19:21:11 +02:00
|
|
|
handle = ext4_journal_start_with_reserve(inode,
|
|
|
|
EXT4_HT_WRITE_PAGE, needed_blocks, rsv_blocks);
|
2008-07-12 01:27:31 +02:00
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
2009-09-26 23:43:59 +02:00
|
|
|
ext4_msg(inode->i_sb, KERN_CRIT, "%s: jbd2_start: "
|
2010-05-16 19:00:00 +02:00
|
|
|
"%ld pages, ino %lu; err %d", __func__,
|
2008-08-20 03:55:02 +02:00
|
|
|
wbc->nr_to_write, inode->i_ino, ret);
|
2013-06-04 19:17:40 +02:00
|
|
|
/* Release allocated io_end */
|
|
|
|
ext4_put_io_end(mpd.io_submit.io_end);
|
|
|
|
break;
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
2009-02-23 22:42:39 +01:00
|
|
|
|
2013-06-04 19:17:40 +02:00
|
|
|
trace_ext4_da_write_pages(inode, mpd.first_page, mpd.wbc);
|
|
|
|
ret = mpage_prepare_extent_to_map(&mpd);
|
|
|
|
if (!ret) {
|
|
|
|
if (mpd.map.m_len)
|
2013-07-01 14:12:40 +02:00
|
|
|
ret = mpage_map_and_submit_extent(handle, &mpd,
|
|
|
|
&give_up_on_write);
|
2013-06-04 19:17:40 +02:00
|
|
|
else {
|
|
|
|
/*
|
|
|
|
* We scanned the whole range (or exhausted
|
|
|
|
* nr_to_write), submitted what was mapped and
|
|
|
|
* didn't find anything needing mapping. We are
|
|
|
|
* done.
|
|
|
|
*/
|
|
|
|
done = true;
|
|
|
|
}
|
2009-02-23 22:42:39 +01:00
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
ext4_journal_stop(handle);
|
2013-06-04 19:17:40 +02:00
|
|
|
/* Submit prepared bio */
|
|
|
|
ext4_io_submit(&mpd.io_submit);
|
|
|
|
/* Unlock pages we didn't use */
|
2013-07-01 14:12:40 +02:00
|
|
|
mpage_release_unused_pages(&mpd, give_up_on_write);
|
2013-06-04 19:17:40 +02:00
|
|
|
/* Drop our io_end reference we got from init */
|
|
|
|
ext4_put_io_end(mpd.io_submit.io_end);
|
|
|
|
|
|
|
|
if (ret == -ENOSPC && sbi->s_journal) {
|
|
|
|
/*
|
|
|
|
* Commit the transaction which would
|
2008-10-16 16:10:36 +02:00
|
|
|
* free blocks released in the transaction
|
|
|
|
* and try again
|
|
|
|
*/
|
2008-09-09 05:05:34 +02:00
|
|
|
jbd2_journal_force_commit_nested(sbi->s_journal);
|
2008-10-16 16:10:36 +02:00
|
|
|
ret = 0;
|
2013-06-04 19:17:40 +02:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
/* Fatal error - ENOMEM, EIO... */
|
|
|
|
if (ret)
|
2008-07-12 01:27:31 +02:00
|
|
|
break;
|
2008-08-20 03:55:02 +02:00
|
|
|
}
|
2011-10-18 16:55:51 +02:00
|
|
|
blk_finish_plug(&plug);
|
2013-09-16 14:24:26 +02:00
|
|
|
if (!ret && !cycled && wbc->nr_to_write > 0) {
|
2009-02-14 16:42:58 +01:00
|
|
|
cycled = 1;
|
2013-06-04 19:17:40 +02:00
|
|
|
mpd.last_page = writeback_index - 1;
|
|
|
|
mpd.first_page = 0;
|
2009-02-14 16:42:58 +01:00
|
|
|
goto retry;
|
|
|
|
}
|
2008-10-16 16:10:36 +02:00
|
|
|
|
|
|
|
/* Update index */
|
|
|
|
if (wbc->range_cyclic || (range_whole && wbc->nr_to_write > 0))
|
|
|
|
/*
|
2013-06-04 19:17:40 +02:00
|
|
|
* Set the writeback_index so that range_cyclic
|
2008-10-16 16:10:36 +02:00
|
|
|
* mode will write it back later
|
|
|
|
*/
|
2013-06-04 19:17:40 +02:00
|
|
|
mapping->writeback_index = mpd.first_page;
|
2008-08-20 03:55:02 +02:00
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
out_writepages:
|
2013-06-06 20:00:46 +02:00
|
|
|
trace_ext4_writepages_result(inode, wbc, ret,
|
|
|
|
nr_to_write - wbc->nr_to_write);
|
2008-07-12 01:27:31 +02:00
|
|
|
return ret;
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
|
|
|
|
2008-10-09 05:13:30 +02:00
|
|
|
static int ext4_nonda_switch(struct super_block *sb)
|
|
|
|
{
|
2013-04-09 15:27:31 +02:00
|
|
|
s64 free_clusters, dirty_clusters;
|
2008-10-09 05:13:30 +02:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(sb);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* switch to non delalloc mode if we are running low
|
|
|
|
* on free block. The free block accounting via percpu
|
2009-01-06 23:41:04 +01:00
|
|
|
* counters can get slightly wrong with percpu_counter_batch getting
|
2008-10-09 05:13:30 +02:00
|
|
|
* accumulated on each CPU without updating global counters
|
|
|
|
* Delalloc need an accurate free block accounting. So switch
|
|
|
|
* to non delalloc when we are near to error range.
|
|
|
|
*/
|
2013-04-09 15:27:31 +02:00
|
|
|
free_clusters =
|
|
|
|
percpu_counter_read_positive(&sbi->s_freeclusters_counter);
|
|
|
|
dirty_clusters =
|
|
|
|
percpu_counter_read_positive(&sbi->s_dirtyclusters_counter);
|
ext4: fix potential deadlock in ext4_nonda_switch()
In ext4_nonda_switch(), if the file system is getting full we used to
call writeback_inodes_sb_if_idle(). The problem is that we can be
holding i_mutex already, and this causes a potential deadlock when
writeback_inodes_sb_if_idle() when it tries to take s_umount. (See
lockdep output below).
As it turns out we don't need need to hold s_umount; the fact that we
are in the middle of the write(2) system call will keep the superblock
pinned. Unfortunately writeback_inodes_sb() checks to make sure
s_umount is taken, and the VFS uses a different mechanism for making
sure the file system doesn't get unmounted out from under us. The
simplest way of dealing with this is to just simply grab s_umount
using a trylock, and skip kicking the writeback flusher thread in the
very unlikely case that we can't take a read lock on s_umount without
blocking.
Also, we now check the cirteria for kicking the writeback thread
before we decide to whether to fall back to non-delayed writeback, so
if there are any outstanding delayed allocation writes, we try to get
them resolved as soon as possible.
[ INFO: possible circular locking dependency detected ]
3.6.0-rc1-00042-gce894ca #367 Not tainted
-------------------------------------------------------
dd/8298 is trying to acquire lock:
(&type->s_umount_key#18){++++..}, at: [<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
but task is already holding lock:
(&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
which lock already depends on the new lock.
2 locks held by dd/8298:
#0: (sb_writers#2){.+.+.+}, at: [<c01ddcc5>] generic_file_aio_write+0x56/0xd3
#1: (&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
stack backtrace:
Pid: 8298, comm: dd Not tainted 3.6.0-rc1-00042-gce894ca #367
Call Trace:
[<c015b79c>] ? console_unlock+0x345/0x372
[<c06d62a1>] print_circular_bug+0x190/0x19d
[<c019906c>] __lock_acquire+0x86d/0xb6c
[<c01999db>] ? mark_held_locks+0x5c/0x7b
[<c0199724>] lock_acquire+0x66/0xb9
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c06db935>] down_read+0x28/0x58
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
[<c026f3b2>] ext4_nonda_switch+0xe1/0xf4
[<c0271ece>] ext4_da_write_begin+0x27/0x193
[<c01dcdb0>] generic_file_buffered_write+0xc8/0x1bb
[<c01ddc47>] __generic_file_aio_write+0x1dd/0x205
[<c01ddce7>] generic_file_aio_write+0x78/0xd3
[<c026d336>] ext4_file_write+0x480/0x4a6
[<c0198c1d>] ? __lock_acquire+0x41e/0xb6c
[<c0180944>] ? sched_clock_cpu+0x11a/0x13e
[<c01967e9>] ? trace_hardirqs_off+0xb/0xd
[<c018099f>] ? local_clock+0x37/0x4e
[<c0209f2c>] do_sync_write+0x67/0x9d
[<c0209ec5>] ? wait_on_retry_sync_kiocb+0x44/0x44
[<c020a7b9>] vfs_write+0x7b/0xe6
[<c020a9a6>] sys_write+0x3b/0x64
[<c06dd4bd>] syscall_call+0x7/0xb
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2012-09-20 04:42:36 +02:00
|
|
|
/*
|
|
|
|
* Start pushing delalloc when 1/2 of free blocks are dirty.
|
|
|
|
*/
|
2013-04-09 15:27:31 +02:00
|
|
|
if (dirty_clusters && (free_clusters < 2 * dirty_clusters))
|
2013-01-10 06:47:57 +01:00
|
|
|
try_to_writeback_inodes_sb(sb, WB_REASON_FS_FREE_SPACE);
|
ext4: fix potential deadlock in ext4_nonda_switch()
In ext4_nonda_switch(), if the file system is getting full we used to
call writeback_inodes_sb_if_idle(). The problem is that we can be
holding i_mutex already, and this causes a potential deadlock when
writeback_inodes_sb_if_idle() when it tries to take s_umount. (See
lockdep output below).
As it turns out we don't need need to hold s_umount; the fact that we
are in the middle of the write(2) system call will keep the superblock
pinned. Unfortunately writeback_inodes_sb() checks to make sure
s_umount is taken, and the VFS uses a different mechanism for making
sure the file system doesn't get unmounted out from under us. The
simplest way of dealing with this is to just simply grab s_umount
using a trylock, and skip kicking the writeback flusher thread in the
very unlikely case that we can't take a read lock on s_umount without
blocking.
Also, we now check the cirteria for kicking the writeback thread
before we decide to whether to fall back to non-delayed writeback, so
if there are any outstanding delayed allocation writes, we try to get
them resolved as soon as possible.
[ INFO: possible circular locking dependency detected ]
3.6.0-rc1-00042-gce894ca #367 Not tainted
-------------------------------------------------------
dd/8298 is trying to acquire lock:
(&type->s_umount_key#18){++++..}, at: [<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
but task is already holding lock:
(&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
which lock already depends on the new lock.
2 locks held by dd/8298:
#0: (sb_writers#2){.+.+.+}, at: [<c01ddcc5>] generic_file_aio_write+0x56/0xd3
#1: (&sb->s_type->i_mutex_key#8){+.+...}, at: [<c01ddcce>] generic_file_aio_write+0x5f/0xd3
stack backtrace:
Pid: 8298, comm: dd Not tainted 3.6.0-rc1-00042-gce894ca #367
Call Trace:
[<c015b79c>] ? console_unlock+0x345/0x372
[<c06d62a1>] print_circular_bug+0x190/0x19d
[<c019906c>] __lock_acquire+0x86d/0xb6c
[<c01999db>] ? mark_held_locks+0x5c/0x7b
[<c0199724>] lock_acquire+0x66/0xb9
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c06db935>] down_read+0x28/0x58
[<c02277d4>] ? writeback_inodes_sb_if_idle+0x28/0x46
[<c02277d4>] writeback_inodes_sb_if_idle+0x28/0x46
[<c026f3b2>] ext4_nonda_switch+0xe1/0xf4
[<c0271ece>] ext4_da_write_begin+0x27/0x193
[<c01dcdb0>] generic_file_buffered_write+0xc8/0x1bb
[<c01ddc47>] __generic_file_aio_write+0x1dd/0x205
[<c01ddce7>] generic_file_aio_write+0x78/0xd3
[<c026d336>] ext4_file_write+0x480/0x4a6
[<c0198c1d>] ? __lock_acquire+0x41e/0xb6c
[<c0180944>] ? sched_clock_cpu+0x11a/0x13e
[<c01967e9>] ? trace_hardirqs_off+0xb/0xd
[<c018099f>] ? local_clock+0x37/0x4e
[<c0209f2c>] do_sync_write+0x67/0x9d
[<c0209ec5>] ? wait_on_retry_sync_kiocb+0x44/0x44
[<c020a7b9>] vfs_write+0x7b/0xe6
[<c020a9a6>] sys_write+0x3b/0x64
[<c06dd4bd>] syscall_call+0x7/0xb
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
2012-09-20 04:42:36 +02:00
|
|
|
|
2013-04-09 15:27:31 +02:00
|
|
|
if (2 * free_clusters < 3 * dirty_clusters ||
|
|
|
|
free_clusters < (dirty_clusters + EXT4_FREECLUSTERS_WATERMARK)) {
|
2008-10-09 05:13:30 +02:00
|
|
|
/*
|
2009-12-23 13:58:12 +01:00
|
|
|
* free block count is less than 150% of dirty blocks
|
|
|
|
* or free blocks is less than watermark
|
2008-10-09 05:13:30 +02:00
|
|
|
*/
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-10-12 01:51:17 +02:00
|
|
|
/* We always reserve for an inode update; the superblock could be there too */
|
|
|
|
static int ext4_da_write_credits(struct inode *inode, loff_t pos, unsigned len)
|
|
|
|
{
|
2015-10-17 22:18:43 +02:00
|
|
|
if (likely(ext4_has_feature_large_file(inode->i_sb)))
|
2014-10-12 01:51:17 +02:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
if (pos + len <= 0x7fffffffULL)
|
|
|
|
return 1;
|
|
|
|
|
|
|
|
/* We might need to update the superblock to set LARGE_FILE */
|
|
|
|
return 2;
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
|
2009-06-14 23:45:34 +02:00
|
|
|
loff_t pos, unsigned len, unsigned flags,
|
|
|
|
struct page **pagep, void **fsdata)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
2010-05-16 17:00:00 +02:00
|
|
|
int ret, retries = 0;
|
2008-07-12 01:27:31 +02:00
|
|
|
struct page *page;
|
|
|
|
pgoff_t index;
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
handle_t *handle;
|
|
|
|
|
|
|
|
index = pos >> PAGE_CACHE_SHIFT;
|
2008-10-09 05:13:30 +02:00
|
|
|
|
|
|
|
if (ext4_nonda_switch(inode->i_sb)) {
|
|
|
|
*fsdata = (void *)FALL_BACK_TO_NONDELALLOC;
|
|
|
|
return ext4_write_begin(file, mapping, pos,
|
|
|
|
len, flags, pagep, fsdata);
|
|
|
|
}
|
|
|
|
*fsdata = (void *)0;
|
2009-06-17 17:48:11 +02:00
|
|
|
trace_ext4_da_write_begin(inode, pos, len, flags);
|
2012-12-10 20:05:57 +01:00
|
|
|
|
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
|
|
|
|
ret = ext4_da_write_inline_data_begin(mapping, inode,
|
|
|
|
pos, len, flags,
|
|
|
|
pagep, fsdata);
|
|
|
|
if (ret < 0)
|
2013-02-09 15:24:14 +01:00
|
|
|
return ret;
|
|
|
|
if (ret == 1)
|
|
|
|
return 0;
|
2012-12-10 20:05:57 +01:00
|
|
|
}
|
|
|
|
|
2013-02-09 15:24:14 +01:00
|
|
|
/*
|
|
|
|
* grab_cache_page_write_begin() can take a long time if the
|
|
|
|
* system is thrashing due to memory pressure, or if the page
|
|
|
|
* is being written back. So grab it first before we start
|
|
|
|
* the transaction handle. This also allows us to allocate
|
|
|
|
* the page (if needed) without using GFP_NOFS.
|
|
|
|
*/
|
|
|
|
retry_grab:
|
|
|
|
page = grab_cache_page_write_begin(mapping, index, flags);
|
|
|
|
if (!page)
|
|
|
|
return -ENOMEM;
|
|
|
|
unlock_page(page);
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
|
|
|
* With delayed allocation, we don't log the i_disksize update
|
|
|
|
* if there is delayed block allocation. But we still need
|
|
|
|
* to journalling the i_disksize update if writes to the end
|
|
|
|
* of file which has an already mapped buffer.
|
|
|
|
*/
|
2013-02-09 15:24:14 +01:00
|
|
|
retry_journal:
|
2014-10-12 01:51:17 +02:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE,
|
|
|
|
ext4_da_write_credits(inode, pos, len));
|
2008-07-12 01:27:31 +02:00
|
|
|
if (IS_ERR(handle)) {
|
2013-02-09 15:24:14 +01:00
|
|
|
page_cache_release(page);
|
|
|
|
return PTR_ERR(handle);
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
|
|
|
|
2013-02-09 15:24:14 +01:00
|
|
|
lock_page(page);
|
|
|
|
if (page->mapping != mapping) {
|
|
|
|
/* The page got truncated from under us */
|
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
2008-08-03 00:51:06 +02:00
|
|
|
ext4_journal_stop(handle);
|
2013-02-09 15:24:14 +01:00
|
|
|
goto retry_grab;
|
2008-08-03 00:51:06 +02:00
|
|
|
}
|
2013-02-09 15:24:14 +01:00
|
|
|
/* In case writeback began while the page was unlocked */
|
2013-08-28 20:30:47 +02:00
|
|
|
wait_for_stable_page(page);
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2015-04-12 06:55:10 +02:00
|
|
|
#ifdef CONFIG_EXT4_FS_ENCRYPTION
|
|
|
|
ret = ext4_block_write_begin(page, pos, len,
|
|
|
|
ext4_da_get_block_prep);
|
|
|
|
#else
|
2010-06-04 11:29:57 +02:00
|
|
|
ret = __block_write_begin(page, pos, len, ext4_da_get_block_prep);
|
2015-04-12 06:55:10 +02:00
|
|
|
#endif
|
2008-07-12 01:27:31 +02:00
|
|
|
if (ret < 0) {
|
|
|
|
unlock_page(page);
|
|
|
|
ext4_journal_stop(handle);
|
2008-09-13 19:10:25 +02:00
|
|
|
/*
|
|
|
|
* block_write_begin may have instantiated a few blocks
|
|
|
|
* outside i_size. Trim these off again. Don't need
|
|
|
|
* i_size_read because we hold i_mutex.
|
|
|
|
*/
|
|
|
|
if (pos + len > inode->i_size)
|
2009-12-09 03:24:33 +01:00
|
|
|
ext4_truncate_failed_write(inode);
|
2013-02-09 15:24:14 +01:00
|
|
|
|
|
|
|
if (ret == -ENOSPC &&
|
|
|
|
ext4_should_retry_alloc(inode->i_sb, &retries))
|
|
|
|
goto retry_journal;
|
|
|
|
|
|
|
|
page_cache_release(page);
|
|
|
|
return ret;
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
|
|
|
|
2013-02-09 15:24:14 +01:00
|
|
|
*pagep = page;
|
2008-07-12 01:27:31 +02:00
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
|
|
|
* Check if we should update i_disksize
|
|
|
|
* when write to the end of file but not require block allocation
|
|
|
|
*/
|
|
|
|
static int ext4_da_should_update_i_disksize(struct page *page,
|
2009-06-14 23:45:34 +02:00
|
|
|
unsigned long offset)
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
{
|
|
|
|
struct buffer_head *bh;
|
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
unsigned int idx;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
bh = page_buffers(page);
|
|
|
|
idx = offset >> inode->i_blkbits;
|
|
|
|
|
2008-09-09 04:25:24 +02:00
|
|
|
for (i = 0; i < idx; i++)
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
bh = bh->b_this_page;
|
|
|
|
|
2009-05-12 22:30:27 +02:00
|
|
|
if (!buffer_mapped(bh) || (buffer_delay(bh)) || buffer_unwritten(bh))
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
return 0;
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
static int ext4_da_write_end(struct file *file,
|
2009-06-14 23:45:34 +02:00
|
|
|
struct address_space *mapping,
|
|
|
|
loff_t pos, unsigned len, unsigned copied,
|
|
|
|
struct page *page, void *fsdata)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
int ret = 0, ret2;
|
|
|
|
handle_t *handle = ext4_journal_current_handle();
|
|
|
|
loff_t new_i_size;
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
unsigned long start, end;
|
2008-10-09 05:13:30 +02:00
|
|
|
int write_mode = (int)(unsigned long)fsdata;
|
|
|
|
|
2013-04-03 18:39:17 +02:00
|
|
|
if (write_mode == FALL_BACK_TO_NONDELALLOC)
|
|
|
|
return ext4_write_end(file, mapping, pos,
|
|
|
|
len, copied, page, fsdata);
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
|
2009-06-17 17:48:11 +02:00
|
|
|
trace_ext4_da_write_end(inode, pos, len, copied);
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
start = pos & (PAGE_CACHE_SIZE - 1);
|
2008-09-09 04:25:24 +02:00
|
|
|
end = start + copied - 1;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* generic_write_end() will run mark_inode_dirty() if i_size
|
|
|
|
* changes. So let's piggyback the i_disksize mark_inode_dirty
|
|
|
|
* into that.
|
|
|
|
*/
|
|
|
|
new_i_size = pos + copied;
|
ext4: avoid hangs in ext4_da_should_update_i_disksize()
If the pte mapping in generic_perform_write() is unmapped between
iov_iter_fault_in_readable() and iov_iter_copy_from_user_atomic(), the
"copied" parameter to ->end_write can be zero. ext4 couldn't cope with
it with delayed allocations enabled. This skips the i_disksize
enlargement logic if copied is zero and no new data was appeneded to
the inode.
gdb> bt
#0 0xffffffff811afe80 in ext4_da_should_update_i_disksize (file=0xffff88003f606a80, mapping=0xffff88001d3824e0, pos=0x1\
08000, len=0x1000, copied=0x0, page=0xffffea0000d792e8, fsdata=0x0) at fs/ext4/inode.c:2467
#1 ext4_da_write_end (file=0xffff88003f606a80, mapping=0xffff88001d3824e0, pos=0x108000, len=0x1000, copied=0x0, page=0\
xffffea0000d792e8, fsdata=0x0) at fs/ext4/inode.c:2512
#2 0xffffffff810d97f1 in generic_perform_write (iocb=<value optimized out>, iov=<value optimized out>, nr_segs=<value o\
ptimized out>, pos=0x108000, ppos=0xffff88001e26be40, count=<value optimized out>, written=0x0) at mm/filemap.c:2440
#3 generic_file_buffered_write (iocb=<value optimized out>, iov=<value optimized out>, nr_segs=<value optimized out>, p\
os=0x108000, ppos=0xffff88001e26be40, count=<value optimized out>, written=0x0) at mm/filemap.c:2482
#4 0xffffffff810db5d1 in __generic_file_aio_write (iocb=0xffff88001e26bde8, iov=0xffff88001e26bec8, nr_segs=0x1, ppos=0\
xffff88001e26be40) at mm/filemap.c:2600
#5 0xffffffff810db853 in generic_file_aio_write (iocb=0xffff88001e26bde8, iov=0xffff88001e26bec8, nr_segs=<value optimi\
zed out>, pos=<value optimized out>) at mm/filemap.c:2632
#6 0xffffffff811a71aa in ext4_file_write (iocb=0xffff88001e26bde8, iov=0xffff88001e26bec8, nr_segs=0x1, pos=0x108000) a\
t fs/ext4/file.c:136
#7 0xffffffff811375aa in do_sync_write (filp=0xffff88003f606a80, buf=<value optimized out>, len=<value optimized out>, \
ppos=0xffff88001e26bf48) at fs/read_write.c:406
#8 0xffffffff81137e56 in vfs_write (file=0xffff88003f606a80, buf=0x1ec2960 <Address 0x1ec2960 out of bounds>, count=0x4\
000, pos=0xffff88001e26bf48) at fs/read_write.c:435
#9 0xffffffff8113816c in sys_write (fd=<value optimized out>, buf=0x1ec2960 <Address 0x1ec2960 out of bounds>, count=0x\
4000) at fs/read_write.c:487
#10 <signal handler called>
#11 0x00007f120077a390 in __brk_reservation_fn_dmi_alloc__ ()
#12 0x0000000000000000 in ?? ()
gdb> print offset
$22 = 0xffffffffffffffff
gdb> print idx
$23 = 0xffffffff
gdb> print inode->i_blkbits
$24 = 0xc
gdb> up
#1 ext4_da_write_end (file=0xffff88003f606a80, mapping=0xffff88001d3824e0, pos=0x108000, len=0x1000, copied=0x0, page=0\
xffffea0000d792e8, fsdata=0x0) at fs/ext4/inode.c:2512
2512 if (ext4_da_should_update_i_disksize(page, end)) {
gdb> print start
$25 = 0x0
gdb> print end
$26 = 0xffffffffffffffff
gdb> print pos
$27 = 0x108000
gdb> print new_i_size
$28 = 0x108000
gdb> print ((struct ext4_inode_info *)((char *)inode-((int)(&((struct ext4_inode_info *)0)->vfs_inode))))->i_disksize
$29 = 0xd9000
gdb> down
2467 for (i = 0; i < idx; i++)
gdb> print i
$30 = 0xd44acbee
This is 100% reproducible with some autonuma development code tuned in
a very aggressive manner (not normal way even for knumad) which does
"exotic" changes to the ptes. It wouldn't normally trigger but I don't
see why it can't happen normally if the page is added to swap cache in
between the two faults leading to "copied" being zero (which then
hangs in ext4). So it should be fixed. Especially possible with lumpy
reclaim (albeit disabled if compaction is enabled) as that would
ignore the young bits in the ptes.
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
2011-12-14 03:41:15 +01:00
|
|
|
if (copied && new_i_size > EXT4_I(inode)->i_disksize) {
|
2012-12-10 20:05:57 +01:00
|
|
|
if (ext4_has_inline_data(inode) ||
|
|
|
|
ext4_da_should_update_i_disksize(page, end)) {
|
2014-08-31 05:34:06 +02:00
|
|
|
ext4_update_i_disksize(inode, new_i_size);
|
2008-09-13 19:06:18 +02:00
|
|
|
/* We need to mark inode dirty even if
|
|
|
|
* new_i_size is less that inode->i_size
|
|
|
|
* bu greater than i_disksize.(hint delalloc)
|
|
|
|
*/
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
ext4: fix delalloc i_disksize early update issue
Ext4_da_write_end() used walk_page_buffers() with a callback function of
ext4_bh_unmapped_or_delay() to check if it extended the file size
without allocating any blocks (since in this case i_disksize needs to be
updated). However, this is didn't work proprely because the buffer head
has not been marked dirty yet --- this is done later in
block_commit_write() --- which caused ext4_bh_unmapped_or_delay() to
always return false.
In addition, walk_page_buffers() checks all of the buffer heads covering
the page, and the only buffer_head that should be checked is the one
covering the end of the write. Otherwise, given a 1k blocksize
filesystem and a 4k page size, the buffer head covering the first 1k
stripe of the file could be unmapped (because it was a sparse file), and
the second or third buffer_head covering that page could be mapped, and
using walk_page_buffers() would fail in this case since it would stop at
the first unmapped buffer_head and return true.
The core problem is that walk_page_buffers() was intended to do work in
a callback function, and a non-zero return value indicated a failure,
which termined the walk of the buffer heads covering the page. It was
not intended to be used with a boolean function, such as
ext4_bh_unmapped_or_delay().
Add addtional fix from Aneesh to protect i_disksize update rave with truncate.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-07-12 01:27:31 +02:00
|
|
|
}
|
2012-12-10 20:05:57 +01:00
|
|
|
|
|
|
|
if (write_mode != CONVERT_INLINE_DATA &&
|
|
|
|
ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA) &&
|
|
|
|
ext4_has_inline_data(inode))
|
|
|
|
ret2 = ext4_da_write_inline_data_end(inode, pos, len, copied,
|
|
|
|
page);
|
|
|
|
else
|
|
|
|
ret2 = generic_write_end(file, mapping, pos, len, copied,
|
2008-07-12 01:27:31 +02:00
|
|
|
page, fsdata);
|
2012-12-10 20:05:57 +01:00
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
copied = ret2;
|
|
|
|
if (ret2 < 0)
|
|
|
|
ret = ret2;
|
|
|
|
ret2 = ext4_journal_stop(handle);
|
|
|
|
if (!ret)
|
|
|
|
ret = ret2;
|
|
|
|
|
|
|
|
return ret ? ret : copied;
|
|
|
|
}
|
|
|
|
|
2013-05-22 05:17:23 +02:00
|
|
|
static void ext4_da_invalidatepage(struct page *page, unsigned int offset,
|
|
|
|
unsigned int length)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
|
|
|
/*
|
|
|
|
* Drop reserved blocks
|
|
|
|
*/
|
|
|
|
BUG_ON(!PageLocked(page));
|
|
|
|
if (!page_has_buffers(page))
|
|
|
|
goto out;
|
|
|
|
|
2013-05-22 05:25:01 +02:00
|
|
|
ext4_da_page_release_reservation(page, offset, length);
|
2008-07-12 01:27:31 +02:00
|
|
|
|
|
|
|
out:
|
2013-05-22 05:17:23 +02:00
|
|
|
ext4_invalidatepage(page, offset, length);
|
2008-07-12 01:27:31 +02:00
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-02-26 07:04:07 +01:00
|
|
|
/*
|
|
|
|
* Force all delayed allocation blocks to be allocated for a given inode.
|
|
|
|
*/
|
|
|
|
int ext4_alloc_da_blocks(struct inode *inode)
|
|
|
|
{
|
2009-09-17 01:30:40 +02:00
|
|
|
trace_ext4_alloc_da_blocks(inode);
|
|
|
|
|
2014-07-15 12:02:38 +02:00
|
|
|
if (!EXT4_I(inode)->i_reserved_data_blocks)
|
2009-02-26 07:04:07 +01:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We do something simple for now. The filemap_flush() will
|
|
|
|
* also start triggering a write of the data blocks, which is
|
|
|
|
* not strictly speaking necessary (and for users of
|
|
|
|
* laptop_mode, not even desirable). However, to do otherwise
|
|
|
|
* would require replicating code paths in:
|
2009-06-14 23:45:34 +02:00
|
|
|
*
|
2013-06-06 20:00:46 +02:00
|
|
|
* ext4_writepages() ->
|
2009-02-26 07:04:07 +01:00
|
|
|
* write_cache_pages() ---> (via passed in callback function)
|
|
|
|
* __mpage_da_writepage() -->
|
|
|
|
* mpage_add_bh_to_extent()
|
|
|
|
* mpage_da_map_blocks()
|
|
|
|
*
|
|
|
|
* The problem is that write_cache_pages(), located in
|
|
|
|
* mm/page-writeback.c, marks pages clean in preparation for
|
|
|
|
* doing I/O, which is not desirable if we're not planning on
|
|
|
|
* doing I/O at all.
|
|
|
|
*
|
|
|
|
* We could call write_cache_pages(), and then redirty all of
|
2010-11-11 12:23:29 +01:00
|
|
|
* the pages by calling redirty_page_for_writepage() but that
|
2009-02-26 07:04:07 +01:00
|
|
|
* would be ugly in the extreme. So instead we would need to
|
|
|
|
* replicate parts of the code in the above functions,
|
2011-03-31 03:57:33 +02:00
|
|
|
* simplifying them because we wouldn't actually intend to
|
2009-02-26 07:04:07 +01:00
|
|
|
* write out the pages, but rather only collect contiguous
|
|
|
|
* logical block extents, call the multi-block allocator, and
|
|
|
|
* then update the buffer heads with the block allocations.
|
2009-06-14 23:45:34 +02:00
|
|
|
*
|
2009-02-26 07:04:07 +01:00
|
|
|
* For now, though, we'll cheat by calling filemap_flush(),
|
|
|
|
* which will map the blocks, and start the I/O, but not
|
|
|
|
* actually wait for the I/O to complete.
|
|
|
|
*/
|
|
|
|
return filemap_flush(inode->i_mapping);
|
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* bmap() is special. It gets used by applications such as lilo and by
|
|
|
|
* the swapper to find the on-disk block of a specific piece of data.
|
|
|
|
*
|
|
|
|
* Naturally, this is dangerous if the block concerned is still in the
|
2006-10-11 10:20:53 +02:00
|
|
|
* journal. If somebody makes a swapfile on an ext4 data-journaling
|
2006-10-11 10:20:50 +02:00
|
|
|
* filesystem and enables swap, then they may get a nasty shock when the
|
|
|
|
* data getting swapped to that swapfile suddenly gets overwritten by
|
|
|
|
* the original zero's written out previously to the journal and
|
|
|
|
* awaiting writeback in the kernel's buffer cache.
|
|
|
|
*
|
|
|
|
* So, if we see any bmap calls here on a modified, data-journaled file,
|
|
|
|
* take extra steps to flush any blocks which might be in the cache.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
static sector_t ext4_bmap(struct address_space *mapping, sector_t block)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
journal_t *journal;
|
|
|
|
int err;
|
|
|
|
|
2012-12-10 20:04:52 +01:00
|
|
|
/*
|
|
|
|
* We can get here for an inline file via the FIBMAP ioctl
|
|
|
|
*/
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return 0;
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
if (mapping_tagged(mapping, PAGECACHE_TAG_DIRTY) &&
|
|
|
|
test_opt(inode->i_sb, DELALLOC)) {
|
|
|
|
/*
|
|
|
|
* With delalloc we want to sync the file
|
|
|
|
* so that we can make sure we allocate
|
|
|
|
* blocks for file
|
|
|
|
*/
|
|
|
|
filemap_write_and_wait(mapping);
|
|
|
|
}
|
|
|
|
|
2010-01-24 20:34:07 +01:00
|
|
|
if (EXT4_JOURNAL(inode) &&
|
|
|
|
ext4_test_inode_state(inode, EXT4_STATE_JDATA)) {
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* This is a REALLY heavyweight approach, but the use of
|
|
|
|
* bmap on dirty files is expected to be extremely rare:
|
|
|
|
* only if we run lilo or swapon on a freshly made file
|
|
|
|
* do we expect this to happen.
|
|
|
|
*
|
|
|
|
* (bmap requires CAP_SYS_RAWIO so this does not
|
|
|
|
* represent an unprivileged user DOS attack --- we'd be
|
|
|
|
* in trouble if mortal users could trigger this path at
|
|
|
|
* will.)
|
|
|
|
*
|
2006-10-11 10:20:53 +02:00
|
|
|
* NB. EXT4_STATE_JDATA is not set on files other than
|
2006-10-11 10:20:50 +02:00
|
|
|
* regular files. If somebody wants to bmap a directory
|
|
|
|
* or symlink and gets confused because the buffer
|
|
|
|
* hasn't yet been flushed to disk, they deserve
|
|
|
|
* everything they get.
|
|
|
|
*/
|
|
|
|
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_JDATA);
|
2006-10-11 10:20:53 +02:00
|
|
|
journal = EXT4_JOURNAL(inode);
|
2006-10-11 10:21:01 +02:00
|
|
|
jbd2_journal_lock_updates(journal);
|
|
|
|
err = jbd2_journal_flush(journal);
|
|
|
|
jbd2_journal_unlock_updates(journal);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
if (err)
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-09-09 04:25:24 +02:00
|
|
|
return generic_block_bmap(mapping, block, ext4_get_block);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
static int ext4_readpage(struct file *file, struct page *page)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2012-12-10 20:04:52 +01:00
|
|
|
int ret = -EAGAIN;
|
|
|
|
struct inode *inode = page->mapping->host;
|
|
|
|
|
2011-03-22 02:38:05 +01:00
|
|
|
trace_ext4_readpage(page);
|
2012-12-10 20:04:52 +01:00
|
|
|
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
ret = ext4_readpage_inline(inode, page);
|
|
|
|
|
|
|
|
if (ret == -EAGAIN)
|
2015-04-08 06:00:32 +02:00
|
|
|
return ext4_mpage_readpages(page->mapping, NULL, page, 1);
|
2012-12-10 20:04:52 +01:00
|
|
|
|
|
|
|
return ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
static int
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_readpages(struct file *file, struct address_space *mapping,
|
2006-10-11 10:20:50 +02:00
|
|
|
struct list_head *pages, unsigned nr_pages)
|
|
|
|
{
|
2012-12-10 20:04:52 +01:00
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
|
|
|
|
/* If the file has inline data, no need to do readpages. */
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return 0;
|
|
|
|
|
2015-04-08 06:00:32 +02:00
|
|
|
return ext4_mpage_readpages(mapping, pages, NULL, nr_pages);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2013-05-22 05:17:23 +02:00
|
|
|
static void ext4_invalidatepage(struct page *page, unsigned int offset,
|
|
|
|
unsigned int length)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2013-05-22 05:25:01 +02:00
|
|
|
trace_ext4_invalidatepage(page, offset, length);
|
2011-03-22 02:38:05 +01:00
|
|
|
|
2012-12-25 19:28:54 +01:00
|
|
|
/* No journalling happens on data buffers when this function is used */
|
|
|
|
WARN_ON(page_has_buffers(page) && buffer_jbd(page_buffers(page)));
|
|
|
|
|
2013-05-22 05:25:01 +02:00
|
|
|
block_invalidatepage(page, offset, length);
|
2012-12-25 19:28:54 +01:00
|
|
|
}
|
|
|
|
|
2012-12-25 19:29:52 +01:00
|
|
|
static int __ext4_journalled_invalidatepage(struct page *page,
|
2013-05-22 05:25:01 +02:00
|
|
|
unsigned int offset,
|
|
|
|
unsigned int length)
|
2012-12-25 19:28:54 +01:00
|
|
|
{
|
|
|
|
journal_t *journal = EXT4_JOURNAL(page->mapping->host);
|
|
|
|
|
2013-05-22 05:25:01 +02:00
|
|
|
trace_ext4_journalled_invalidatepage(page, offset, length);
|
2012-12-25 19:28:54 +01:00
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* If it's a full truncate we just forget about the pending dirtying
|
|
|
|
*/
|
2013-05-22 05:25:01 +02:00
|
|
|
if (offset == 0 && length == PAGE_CACHE_SIZE)
|
2006-10-11 10:20:50 +02:00
|
|
|
ClearPageChecked(page);
|
|
|
|
|
2013-05-22 05:25:01 +02:00
|
|
|
return jbd2_journal_invalidatepage(journal, page, offset, length);
|
2012-12-25 19:29:52 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Wrapper for aops... */
|
|
|
|
static void ext4_journalled_invalidatepage(struct page *page,
|
2013-05-22 05:17:23 +02:00
|
|
|
unsigned int offset,
|
|
|
|
unsigned int length)
|
2012-12-25 19:29:52 +01:00
|
|
|
{
|
2013-05-22 05:25:01 +02:00
|
|
|
WARN_ON(__ext4_journalled_invalidatepage(page, offset, length) < 0);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
static int ext4_releasepage(struct page *page, gfp_t wait)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
journal_t *journal = EXT4_JOURNAL(page->mapping->host);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2011-03-22 02:38:05 +01:00
|
|
|
trace_ext4_releasepage(page);
|
|
|
|
|
2013-03-11 03:19:00 +01:00
|
|
|
/* Page has dirty journalled data -> cannot release */
|
|
|
|
if (PageChecked(page))
|
2006-10-11 10:20:50 +02:00
|
|
|
return 0;
|
2009-01-07 06:06:22 +01:00
|
|
|
if (journal)
|
|
|
|
return jbd2_journal_try_to_free_buffers(journal, page, wait);
|
|
|
|
else
|
|
|
|
return try_to_free_buffers(page);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2010-05-17 02:00:00 +02:00
|
|
|
/*
|
|
|
|
* ext4_get_block used when preparing for a DIO write or buffer write.
|
|
|
|
* We allocate an uinitialized extent if blocks haven't been allocated.
|
|
|
|
* The extent will be converted to initialized after the IO is complete.
|
|
|
|
*/
|
2012-12-10 20:05:51 +01:00
|
|
|
int ext4_get_block_write(struct inode *inode, sector_t iblock,
|
2009-09-28 21:48:41 +02:00
|
|
|
struct buffer_head *bh_result, int create)
|
|
|
|
{
|
2010-03-02 19:28:44 +01:00
|
|
|
ext4_debug("ext4_get_block_write: inode %lu, create flag %d\n",
|
2009-09-28 21:48:29 +02:00
|
|
|
inode->i_ino, create);
|
2010-05-17 02:00:00 +02:00
|
|
|
return _ext4_get_block(inode, iblock, bh_result,
|
|
|
|
EXT4_GET_BLOCKS_IO_CREATE_EXT);
|
2009-09-28 21:48:41 +02:00
|
|
|
}
|
|
|
|
|
2015-12-07 21:04:57 +01:00
|
|
|
static int ext4_get_block_overwrite(struct inode *inode, sector_t iblock,
|
2012-11-08 21:07:16 +01:00
|
|
|
struct buffer_head *bh_result, int create)
|
2012-07-09 22:29:29 +02:00
|
|
|
{
|
2015-12-07 21:04:57 +01:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
ext4_debug("ext4_get_block_overwrite: inode %lu, create flag %d\n",
|
2012-11-08 21:07:16 +01:00
|
|
|
inode->i_ino, create);
|
2015-12-07 21:04:57 +01:00
|
|
|
ret = _ext4_get_block(inode, iblock, bh_result, 0);
|
|
|
|
/*
|
|
|
|
* Blocks should have been preallocated! ext4_file_write_iter() checks
|
|
|
|
* that.
|
|
|
|
*/
|
|
|
|
WARN_ON_ONCE(!buffer_mapped(bh_result));
|
|
|
|
|
|
|
|
return ret;
|
2012-07-09 22:29:29 +02:00
|
|
|
}
|
|
|
|
|
2015-12-07 21:10:44 +01:00
|
|
|
#ifdef CONFIG_FS_DAX
|
|
|
|
int ext4_dax_mmap_get_block(struct inode *inode, sector_t iblock,
|
|
|
|
struct buffer_head *bh_result, int create)
|
2015-09-08 23:59:20 +02:00
|
|
|
{
|
2015-12-07 21:10:44 +01:00
|
|
|
int ret, err;
|
|
|
|
int credits;
|
|
|
|
struct ext4_map_blocks map;
|
|
|
|
handle_t *handle = NULL;
|
|
|
|
int flags = 0;
|
2015-12-07 21:10:26 +01:00
|
|
|
|
2015-12-07 21:10:44 +01:00
|
|
|
ext4_debug("ext4_dax_mmap_get_block: inode %lu, create flag %d\n",
|
2015-09-08 23:59:20 +02:00
|
|
|
inode->i_ino, create);
|
2015-12-07 21:10:44 +01:00
|
|
|
map.m_lblk = iblock;
|
|
|
|
map.m_len = bh_result->b_size >> inode->i_blkbits;
|
|
|
|
credits = ext4_chunk_trans_blocks(inode, map.m_len);
|
|
|
|
if (create) {
|
|
|
|
flags |= EXT4_GET_BLOCKS_PRE_IO | EXT4_GET_BLOCKS_CREATE_ZERO;
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_MAP_BLOCKS, credits);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = ext4_map_blocks(handle, inode, &map, flags);
|
|
|
|
if (create) {
|
|
|
|
err = ext4_journal_stop(handle);
|
|
|
|
if (ret >= 0 && err < 0)
|
|
|
|
ret = err;
|
|
|
|
}
|
|
|
|
if (ret <= 0)
|
|
|
|
goto out;
|
|
|
|
if (map.m_flags & EXT4_MAP_UNWRITTEN) {
|
|
|
|
int err2;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We are protected by i_mmap_sem so we know block cannot go
|
|
|
|
* away from under us even though we dropped i_data_sem.
|
|
|
|
* Convert extent to written and write zeros there.
|
|
|
|
*
|
|
|
|
* Note: We may get here even when create == 0.
|
|
|
|
*/
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_MAP_BLOCKS, credits);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
err = ext4_map_blocks(handle, inode, &map,
|
|
|
|
EXT4_GET_BLOCKS_CONVERT | EXT4_GET_BLOCKS_CREATE_ZERO);
|
|
|
|
if (err < 0)
|
|
|
|
ret = err;
|
|
|
|
err2 = ext4_journal_stop(handle);
|
|
|
|
if (err2 < 0 && ret > 0)
|
|
|
|
ret = err2;
|
|
|
|
}
|
|
|
|
out:
|
|
|
|
WARN_ON_ONCE(ret == 0 && create);
|
|
|
|
if (ret > 0) {
|
|
|
|
map_bh(bh_result, inode->i_sb, map.m_pblk);
|
|
|
|
bh_result->b_state = (bh_result->b_state & ~EXT4_MAP_FLAGS) |
|
|
|
|
map.m_flags;
|
|
|
|
/*
|
|
|
|
* At least for now we have to clear BH_New so that DAX code
|
|
|
|
* doesn't attempt to zero blocks again in a racy way.
|
|
|
|
*/
|
|
|
|
bh_result->b_state &= ~(1 << BH_New);
|
|
|
|
bh_result->b_size = map.m_len << inode->i_blkbits;
|
|
|
|
ret = 0;
|
|
|
|
}
|
|
|
|
return ret;
|
2015-09-08 23:59:20 +02:00
|
|
|
}
|
2015-12-07 21:10:44 +01:00
|
|
|
#endif
|
2015-09-08 23:59:20 +02:00
|
|
|
|
2009-09-28 21:48:41 +02:00
|
|
|
static void ext4_end_io_dio(struct kiocb *iocb, loff_t offset,
|
2013-09-04 15:04:39 +02:00
|
|
|
ssize_t size, void *private)
|
2009-09-28 21:48:41 +02:00
|
|
|
{
|
|
|
|
ext4_io_end_t *io_end = iocb->private;
|
|
|
|
|
2013-06-04 17:58:58 +02:00
|
|
|
/* if not async direct IO just return */
|
2013-09-04 15:04:39 +02:00
|
|
|
if (!io_end)
|
2013-06-04 17:58:58 +02:00
|
|
|
return;
|
2009-11-03 20:44:54 +01:00
|
|
|
|
2011-12-29 01:00:25 +01:00
|
|
|
ext_debug("ext4_end_io_dio(): io_end 0x%p "
|
2012-03-20 04:11:43 +01:00
|
|
|
"for inode %lu, iocb 0x%p, offset %llu, size %zd\n",
|
2009-09-28 21:48:29 +02:00
|
|
|
iocb->private, io_end->inode->i_ino, iocb, offset,
|
|
|
|
size);
|
|
|
|
|
2011-12-12 16:53:02 +01:00
|
|
|
iocb->private = NULL;
|
2009-09-28 21:48:41 +02:00
|
|
|
io_end->offset = offset;
|
|
|
|
io_end->size = size;
|
2013-09-04 15:04:39 +02:00
|
|
|
ext4_put_io_end(io_end);
|
2009-09-28 21:48:41 +02:00
|
|
|
}
|
2010-03-02 19:28:44 +01:00
|
|
|
|
2009-09-28 21:48:41 +02:00
|
|
|
/*
|
|
|
|
* For ext4 extent files, ext4 will do direct-io write to holes,
|
|
|
|
* preallocated extents, and those write extend the file, no need to
|
|
|
|
* fall back to buffered IO.
|
|
|
|
*
|
2014-04-21 05:45:47 +02:00
|
|
|
* For holes, we fallocate those blocks, mark them as unwritten
|
2012-11-30 03:13:48 +01:00
|
|
|
* If those blocks were preallocated, we mark sure they are split, but
|
2014-04-21 05:45:47 +02:00
|
|
|
* still keep the range to write as unwritten.
|
2009-09-28 21:48:41 +02:00
|
|
|
*
|
2012-11-30 03:13:48 +01:00
|
|
|
* The unwritten extents will be converted to written when DIO is completed.
|
2009-09-28 21:48:29 +02:00
|
|
|
* For async direct IO, since the IO may still pending when return, we
|
2011-03-31 03:57:33 +02:00
|
|
|
* set up an end_io call back function, which will do the conversion
|
2009-09-28 21:48:29 +02:00
|
|
|
* when async direct IO completed.
|
2009-09-28 21:48:41 +02:00
|
|
|
*
|
|
|
|
* If the O_DIRECT write will extend the file then add this inode to the
|
|
|
|
* orphan list. So recovery will truncate it back to the original size
|
|
|
|
* if the machine crashes during the write.
|
|
|
|
*
|
|
|
|
*/
|
2015-03-16 12:33:52 +01:00
|
|
|
static ssize_t ext4_ext_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
|
|
|
|
loff_t offset)
|
2009-09-28 21:48:41 +02:00
|
|
|
{
|
|
|
|
struct file *file = iocb->ki_filp;
|
|
|
|
struct inode *inode = file->f_mapping->host;
|
|
|
|
ssize_t ret;
|
2014-03-05 04:38:00 +01:00
|
|
|
size_t count = iov_iter_count(iter);
|
2012-11-30 03:13:48 +01:00
|
|
|
int overwrite = 0;
|
|
|
|
get_block_t *get_block_func = NULL;
|
|
|
|
int dio_flags = 0;
|
2009-09-28 21:48:41 +02:00
|
|
|
loff_t final_size = offset + count;
|
2013-06-04 17:58:58 +02:00
|
|
|
ext4_io_end_t *io_end = NULL;
|
2012-07-09 22:29:29 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
/* Use the old path for reads and writes beyond i_size. */
|
2015-03-16 12:33:52 +01:00
|
|
|
if (iov_iter_rw(iter) != WRITE || final_size > inode->i_size)
|
|
|
|
return ext4_ind_direct_IO(iocb, iter, offset);
|
2012-07-23 02:19:31 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
BUG_ON(iocb->private == NULL);
|
2012-07-23 02:19:31 +02:00
|
|
|
|
2013-06-04 20:27:38 +02:00
|
|
|
/*
|
|
|
|
* Make all waiters for direct IO properly wait also for extent
|
|
|
|
* conversion. This also disallows race between truncate() and
|
|
|
|
* overwrite DIO as i_dio_count needs to be incremented under i_mutex.
|
|
|
|
*/
|
2015-03-16 12:33:52 +01:00
|
|
|
if (iov_iter_rw(iter) == WRITE)
|
direct-io: only inc/dec inode->i_dio_count for file systems
do_blockdev_direct_IO() increments and decrements the inode
->i_dio_count for each IO operation. It does this to protect against
truncate of a file. Block devices don't need this sort of protection.
For a capable multiqueue setup, this atomic int is the only shared
state between applications accessing the device for O_DIRECT, and it
presents a scaling wall for that. In my testing, as much as 30% of
system time is spent incrementing and decrementing this value. A mixed
read/write workload improved from ~2.5M IOPS to ~9.6M IOPS, with
better latencies too. Before:
clat percentiles (usec):
| 1.00th=[ 33], 5.00th=[ 34], 10.00th=[ 34], 20.00th=[ 34],
| 30.00th=[ 34], 40.00th=[ 34], 50.00th=[ 35], 60.00th=[ 35],
| 70.00th=[ 35], 80.00th=[ 35], 90.00th=[ 37], 95.00th=[ 80],
| 99.00th=[ 98], 99.50th=[ 151], 99.90th=[ 155], 99.95th=[ 155],
| 99.99th=[ 165]
After:
clat percentiles (usec):
| 1.00th=[ 95], 5.00th=[ 108], 10.00th=[ 129], 20.00th=[ 149],
| 30.00th=[ 155], 40.00th=[ 161], 50.00th=[ 167], 60.00th=[ 171],
| 70.00th=[ 177], 80.00th=[ 185], 90.00th=[ 201], 95.00th=[ 270],
| 99.00th=[ 390], 99.50th=[ 398], 99.90th=[ 418], 99.95th=[ 422],
| 99.99th=[ 438]
In other setups, Robert Elliott reported seeing good performance
improvements:
https://lkml.org/lkml/2015/4/3/557
The more applications accessing the device, the worse it gets.
Add a new direct-io flags, DIO_SKIP_DIO_COUNT, which tells
do_blockdev_direct_IO() that it need not worry about incrementing
or decrementing the inode i_dio_count for this caller.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Elliott, Robert (Server Storage) <elliott@hp.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2015-04-16 01:05:48 +02:00
|
|
|
inode_dio_begin(inode);
|
2013-06-04 20:27:38 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
/* If we do a overwrite dio, i_mutex locking can be released */
|
|
|
|
overwrite = *((int *)iocb->private);
|
2012-07-23 02:19:31 +02:00
|
|
|
|
2015-12-07 21:04:57 +01:00
|
|
|
if (overwrite)
|
2016-01-22 21:40:57 +01:00
|
|
|
inode_unlock(inode);
|
2009-09-28 21:48:29 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
/*
|
|
|
|
* We could direct write to holes and fallocate.
|
|
|
|
*
|
|
|
|
* Allocated blocks to fill the hole are marked as
|
2014-04-21 05:45:47 +02:00
|
|
|
* unwritten to prevent parallel buffered read to expose
|
2012-11-30 03:13:48 +01:00
|
|
|
* the stale data before DIO complete the data IO.
|
|
|
|
*
|
|
|
|
* As to previously fallocated extents, ext4 get_block will
|
|
|
|
* just simply mark the buffer mapped but still keep the
|
2014-04-21 05:45:47 +02:00
|
|
|
* extents unwritten.
|
2012-11-30 03:13:48 +01:00
|
|
|
*
|
|
|
|
* For non AIO case, we will convert those unwritten extents
|
|
|
|
* to written after return back from blockdev_direct_IO.
|
|
|
|
*
|
|
|
|
* For async DIO, the conversion needs to be deferred when the
|
|
|
|
* IO is completed. The ext4 end_io callback function will be
|
|
|
|
* called to take care of the conversion work. Here for async
|
|
|
|
* case, we allocate an io_end structure to hook to the iocb.
|
|
|
|
*/
|
|
|
|
iocb->private = NULL;
|
|
|
|
ext4_inode_aio_set(inode, NULL);
|
|
|
|
if (!is_sync_kiocb(iocb)) {
|
2013-06-04 17:58:58 +02:00
|
|
|
io_end = ext4_init_io_end(inode, GFP_NOFS);
|
2012-11-30 03:13:48 +01:00
|
|
|
if (!io_end) {
|
|
|
|
ret = -ENOMEM;
|
|
|
|
goto retake_lock;
|
2012-11-08 21:07:16 +01:00
|
|
|
}
|
2013-06-04 17:58:58 +02:00
|
|
|
/*
|
|
|
|
* Grab reference for DIO. Will be dropped in ext4_end_io_dio()
|
|
|
|
*/
|
|
|
|
iocb->private = ext4_get_io_end(io_end);
|
2009-09-28 21:48:29 +02:00
|
|
|
/*
|
2012-11-30 03:13:48 +01:00
|
|
|
* we save the io structure for current async direct
|
|
|
|
* IO, so that later ext4_map_blocks() could flag the
|
|
|
|
* io structure whether there is a unwritten extents
|
|
|
|
* needs to be converted when IO is completed.
|
2009-09-28 21:48:29 +02:00
|
|
|
*/
|
2012-11-30 03:13:48 +01:00
|
|
|
ext4_inode_aio_set(inode, io_end);
|
|
|
|
}
|
2012-07-23 02:19:31 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
if (overwrite) {
|
2015-12-07 21:04:57 +01:00
|
|
|
get_block_func = ext4_get_block_overwrite;
|
2012-11-30 03:13:48 +01:00
|
|
|
} else {
|
|
|
|
get_block_func = ext4_get_block_write;
|
|
|
|
dio_flags = DIO_LOCKING;
|
|
|
|
}
|
2015-04-12 06:55:10 +02:00
|
|
|
#ifdef CONFIG_EXT4_FS_ENCRYPTION
|
|
|
|
BUG_ON(ext4_encrypted_inode(inode) && S_ISREG(inode->i_mode));
|
|
|
|
#endif
|
2015-02-17 00:59:38 +01:00
|
|
|
if (IS_DAX(inode))
|
2015-03-16 12:33:51 +01:00
|
|
|
ret = dax_do_io(iocb, inode, iter, offset, get_block_func,
|
2015-02-17 00:59:38 +01:00
|
|
|
ext4_end_io_dio, dio_flags);
|
|
|
|
else
|
2015-03-16 12:33:50 +01:00
|
|
|
ret = __blockdev_direct_IO(iocb, inode,
|
2015-02-17 00:59:38 +01:00
|
|
|
inode->i_sb->s_bdev, iter, offset,
|
|
|
|
get_block_func,
|
|
|
|
ext4_end_io_dio, NULL, dio_flags);
|
2012-11-30 03:13:48 +01:00
|
|
|
|
|
|
|
/*
|
2013-06-04 17:58:58 +02:00
|
|
|
* Put our reference to io_end. This can free the io_end structure e.g.
|
|
|
|
* in sync IO case or in case of error. It can even perform extent
|
|
|
|
* conversion if all bios we submitted finished before we got here.
|
|
|
|
* Note that in that case iocb->private can be already set to NULL
|
|
|
|
* here.
|
2012-11-30 03:13:48 +01:00
|
|
|
*/
|
2013-06-04 17:58:58 +02:00
|
|
|
if (io_end) {
|
|
|
|
ext4_inode_aio_set(inode, NULL);
|
|
|
|
ext4_put_io_end(io_end);
|
|
|
|
/*
|
|
|
|
* When no IO was submitted ext4_end_io_dio() was not
|
|
|
|
* called so we have to put iocb's reference.
|
|
|
|
*/
|
|
|
|
if (ret <= 0 && ret != -EIOCBQUEUED && iocb->private) {
|
|
|
|
WARN_ON(iocb->private != io_end);
|
|
|
|
WARN_ON(io_end->flag & EXT4_IO_END_UNWRITTEN);
|
|
|
|
ext4_put_io_end(io_end);
|
|
|
|
iocb->private = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (ret > 0 && !overwrite && ext4_test_inode_state(inode,
|
2012-11-30 03:13:48 +01:00
|
|
|
EXT4_STATE_DIO_UNWRITTEN)) {
|
|
|
|
int err;
|
|
|
|
/*
|
|
|
|
* for non AIO case, since the IO is already
|
|
|
|
* completed, we could do the conversion right here
|
|
|
|
*/
|
2013-06-04 19:21:11 +02:00
|
|
|
err = ext4_convert_unwritten_extents(NULL, inode,
|
2012-11-30 03:13:48 +01:00
|
|
|
offset, ret);
|
|
|
|
if (err < 0)
|
|
|
|
ret = err;
|
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_DIO_UNWRITTEN);
|
|
|
|
}
|
2012-07-23 02:19:31 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
retake_lock:
|
2015-03-16 12:33:52 +01:00
|
|
|
if (iov_iter_rw(iter) == WRITE)
|
direct-io: only inc/dec inode->i_dio_count for file systems
do_blockdev_direct_IO() increments and decrements the inode
->i_dio_count for each IO operation. It does this to protect against
truncate of a file. Block devices don't need this sort of protection.
For a capable multiqueue setup, this atomic int is the only shared
state between applications accessing the device for O_DIRECT, and it
presents a scaling wall for that. In my testing, as much as 30% of
system time is spent incrementing and decrementing this value. A mixed
read/write workload improved from ~2.5M IOPS to ~9.6M IOPS, with
better latencies too. Before:
clat percentiles (usec):
| 1.00th=[ 33], 5.00th=[ 34], 10.00th=[ 34], 20.00th=[ 34],
| 30.00th=[ 34], 40.00th=[ 34], 50.00th=[ 35], 60.00th=[ 35],
| 70.00th=[ 35], 80.00th=[ 35], 90.00th=[ 37], 95.00th=[ 80],
| 99.00th=[ 98], 99.50th=[ 151], 99.90th=[ 155], 99.95th=[ 155],
| 99.99th=[ 165]
After:
clat percentiles (usec):
| 1.00th=[ 95], 5.00th=[ 108], 10.00th=[ 129], 20.00th=[ 149],
| 30.00th=[ 155], 40.00th=[ 161], 50.00th=[ 167], 60.00th=[ 171],
| 70.00th=[ 177], 80.00th=[ 185], 90.00th=[ 201], 95.00th=[ 270],
| 99.00th=[ 390], 99.50th=[ 398], 99.90th=[ 418], 99.95th=[ 422],
| 99.99th=[ 438]
In other setups, Robert Elliott reported seeing good performance
improvements:
https://lkml.org/lkml/2015/4/3/557
The more applications accessing the device, the worse it gets.
Add a new direct-io flags, DIO_SKIP_DIO_COUNT, which tells
do_blockdev_direct_IO() that it need not worry about incrementing
or decrementing the inode i_dio_count for this caller.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Elliott, Robert (Server Storage) <elliott@hp.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
2015-04-16 01:05:48 +02:00
|
|
|
inode_dio_end(inode);
|
2012-11-30 03:13:48 +01:00
|
|
|
/* take i_mutex locking again if we do a ovewrite dio */
|
2015-12-07 21:04:57 +01:00
|
|
|
if (overwrite)
|
2016-01-22 21:40:57 +01:00
|
|
|
inode_lock(inode);
|
2009-09-28 21:48:29 +02:00
|
|
|
|
2012-11-30 03:13:48 +01:00
|
|
|
return ret;
|
2009-09-28 21:48:41 +02:00
|
|
|
}
|
|
|
|
|
2015-03-16 12:33:53 +01:00
|
|
|
static ssize_t ext4_direct_IO(struct kiocb *iocb, struct iov_iter *iter,
|
|
|
|
loff_t offset)
|
2009-09-28 21:48:41 +02:00
|
|
|
{
|
|
|
|
struct file *file = iocb->ki_filp;
|
|
|
|
struct inode *inode = file->f_mapping->host;
|
2014-03-05 04:38:00 +01:00
|
|
|
size_t count = iov_iter_count(iter);
|
2011-03-22 02:38:05 +01:00
|
|
|
ssize_t ret;
|
2009-09-28 21:48:41 +02:00
|
|
|
|
2015-04-12 06:55:10 +02:00
|
|
|
#ifdef CONFIG_EXT4_FS_ENCRYPTION
|
|
|
|
if (ext4_encrypted_inode(inode) && S_ISREG(inode->i_mode))
|
|
|
|
return 0;
|
|
|
|
#endif
|
|
|
|
|
2011-08-31 17:56:51 +02:00
|
|
|
/*
|
|
|
|
* If we are doing data journalling we don't support O_DIRECT
|
|
|
|
*/
|
|
|
|
if (ext4_should_journal_data(inode))
|
|
|
|
return 0;
|
|
|
|
|
2012-12-10 20:04:52 +01:00
|
|
|
/* Let buffer I/O handle the inline data case. */
|
|
|
|
if (ext4_has_inline_data(inode))
|
|
|
|
return 0;
|
|
|
|
|
2015-03-16 12:33:52 +01:00
|
|
|
trace_ext4_direct_IO_enter(inode, offset, count, iov_iter_rw(iter));
|
2010-05-17 04:00:00 +02:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
2015-03-16 12:33:52 +01:00
|
|
|
ret = ext4_ext_direct_IO(iocb, iter, offset);
|
2011-03-22 02:38:05 +01:00
|
|
|
else
|
2015-03-16 12:33:52 +01:00
|
|
|
ret = ext4_ind_direct_IO(iocb, iter, offset);
|
|
|
|
trace_ext4_direct_IO_exit(inode, offset, count, iov_iter_rw(iter), ret);
|
2011-03-22 02:38:05 +01:00
|
|
|
return ret;
|
2009-09-28 21:48:41 +02:00
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* Pages can be marked dirty completely asynchronously from ext4's journalling
|
2006-10-11 10:20:50 +02:00
|
|
|
* activity. By filemap_sync_pte(), try_to_unmap_one(), etc. We cannot do
|
|
|
|
* much here because ->set_page_dirty is called under VFS locks. The page is
|
|
|
|
* not necessarily locked.
|
|
|
|
*
|
|
|
|
* We cannot just dirty the page and leave attached buffers clean, because the
|
|
|
|
* buffers' dirty state is "definitive". We cannot just set the buffers dirty
|
|
|
|
* or jbddirty because all the journalling code will explode.
|
|
|
|
*
|
|
|
|
* So what we do is to mark the page "pending dirty" and next time writepage
|
|
|
|
* is called, propagate that into the buffers appropriately.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
static int ext4_journalled_set_page_dirty(struct page *page)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
SetPageChecked(page);
|
|
|
|
return __set_page_dirty_nobuffers(page);
|
|
|
|
}
|
|
|
|
|
2013-04-03 18:39:17 +02:00
|
|
|
static const struct address_space_operations ext4_aops = {
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.readpage = ext4_readpage,
|
|
|
|
.readpages = ext4_readpages,
|
2009-06-14 23:58:45 +02:00
|
|
|
.writepage = ext4_writepage,
|
2013-06-06 20:00:46 +02:00
|
|
|
.writepages = ext4_writepages,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.write_begin = ext4_write_begin,
|
2013-04-03 18:39:17 +02:00
|
|
|
.write_end = ext4_write_end,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.bmap = ext4_bmap,
|
|
|
|
.invalidatepage = ext4_invalidatepage,
|
|
|
|
.releasepage = ext4_releasepage,
|
|
|
|
.direct_IO = ext4_direct_IO,
|
|
|
|
.migratepage = buffer_migrate_page,
|
|
|
|
.is_partially_uptodate = block_is_partially_uptodate,
|
2009-09-16 11:50:16 +02:00
|
|
|
.error_remove_page = generic_error_remove_page,
|
2006-10-11 10:20:50 +02:00
|
|
|
};
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
static const struct address_space_operations ext4_journalled_aops = {
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.readpage = ext4_readpage,
|
|
|
|
.readpages = ext4_readpages,
|
2009-06-14 23:58:45 +02:00
|
|
|
.writepage = ext4_writepage,
|
2013-06-06 20:00:46 +02:00
|
|
|
.writepages = ext4_writepages,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.write_begin = ext4_write_begin,
|
|
|
|
.write_end = ext4_journalled_write_end,
|
|
|
|
.set_page_dirty = ext4_journalled_set_page_dirty,
|
|
|
|
.bmap = ext4_bmap,
|
2012-12-25 19:28:54 +01:00
|
|
|
.invalidatepage = ext4_journalled_invalidatepage,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.releasepage = ext4_releasepage,
|
2011-08-31 17:56:51 +02:00
|
|
|
.direct_IO = ext4_direct_IO,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.is_partially_uptodate = block_is_partially_uptodate,
|
2009-09-16 11:50:16 +02:00
|
|
|
.error_remove_page = generic_error_remove_page,
|
2006-10-11 10:20:50 +02:00
|
|
|
};
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
static const struct address_space_operations ext4_da_aops = {
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.readpage = ext4_readpage,
|
|
|
|
.readpages = ext4_readpages,
|
2009-06-14 23:58:45 +02:00
|
|
|
.writepage = ext4_writepage,
|
2013-06-06 20:00:46 +02:00
|
|
|
.writepages = ext4_writepages,
|
vfs: pagecache usage optimization for pagesize!=blocksize
When we read some part of a file through pagecache, if there is a
pagecache of corresponding index but this page is not uptodate, read IO
is issued and this page will be uptodate.
I think this is good for pagesize == blocksize environment but there is
room for improvement on pagesize != blocksize environment. Because in
this case a page can have multiple buffers and even if a page is not
uptodate, some buffers can be uptodate.
So I suggest that when all buffers which correspond to a part of a file
that we want to read are uptodate, use this pagecache and copy data from
this pagecache to user buffer even if a page is not uptodate. This can
reduce read IO and improve system throughput.
I wrote a benchmark program and got result number with this program.
This benchmark do:
1: mount and open a test file.
2: create a 512MB file.
3: close a file and umount.
4: mount and again open a test file.
5: pwrite randomly 300000 times on a test file. offset is aligned
by IO size(1024bytes).
6: measure time of preading randomly 100000 times on a test file.
The result was:
2.6.26
330 sec
2.6.26-patched
226 sec
Arch:i386
Filesystem:ext3
Blocksize:1024 bytes
Memory: 1GB
On ext3/4, a file is written through buffer/block. So random read/write
mixed workloads or random read after random write workloads are optimized
with this patch under pagesize != blocksize environment. This test result
showed this.
The benchmark program is as follows:
#include <stdio.h>
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
#include <unistd.h>
#include <time.h>
#include <stdlib.h>
#include <string.h>
#include <sys/mount.h>
#define LEN 1024
#define LOOP 1024*512 /* 512MB */
main(void)
{
unsigned long i, offset, filesize;
int fd;
char buf[LEN];
time_t t1, t2;
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
memset(buf, 0, LEN);
fd = open("/root/test1/testfile", O_CREAT|O_RDWR|O_TRUNC);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
for (i = 0; i < LOOP; i++)
write(fd, buf, LEN);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
if (mount("/dev/sda1", "/root/test1/", "ext3", 0, 0) < 0) {
perror("cannot mount\n");
exit(1);
}
fd = open("/root/test1/testfile", O_RDWR);
if (fd < 0) {
perror("cannot open file\n");
exit(1);
}
filesize = LEN * LOOP;
for (i = 0; i < 300000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pwrite(fd, buf, LEN, offset);
}
printf("start test\n");
time(&t1);
for (i = 0; i < 100000; i++){
offset = (random() % filesize) & (~(LEN - 1));
pread(fd, buf, LEN, offset);
}
time(&t2);
printf("%ld sec\n", t2-t1);
close(fd);
if (umount("/root/test1/") < 0) {
perror("cannot umount\n");
exit(1);
}
}
Signed-off-by: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>
Cc: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Jan Kara <jack@ucw.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-29 00:46:36 +02:00
|
|
|
.write_begin = ext4_da_write_begin,
|
|
|
|
.write_end = ext4_da_write_end,
|
|
|
|
.bmap = ext4_bmap,
|
|
|
|
.invalidatepage = ext4_da_invalidatepage,
|
|
|
|
.releasepage = ext4_releasepage,
|
|
|
|
.direct_IO = ext4_direct_IO,
|
|
|
|
.migratepage = buffer_migrate_page,
|
|
|
|
.is_partially_uptodate = block_is_partially_uptodate,
|
2009-09-16 11:50:16 +02:00
|
|
|
.error_remove_page = generic_error_remove_page,
|
2008-07-12 01:27:31 +02:00
|
|
|
};
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
void ext4_set_aops(struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2012-02-20 23:53:00 +01:00
|
|
|
switch (ext4_inode_journal_mode(inode)) {
|
|
|
|
case EXT4_INODE_ORDERED_DATA_MODE:
|
2013-04-03 18:39:17 +02:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_ORDERED_MODE);
|
2012-02-20 23:53:00 +01:00
|
|
|
break;
|
|
|
|
case EXT4_INODE_WRITEBACK_DATA_MODE:
|
2013-04-03 18:39:17 +02:00
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_ORDERED_MODE);
|
2012-02-20 23:53:00 +01:00
|
|
|
break;
|
|
|
|
case EXT4_INODE_JOURNAL_DATA_MODE:
|
2006-10-11 10:20:53 +02:00
|
|
|
inode->i_mapping->a_ops = &ext4_journalled_aops;
|
2013-04-03 18:39:17 +02:00
|
|
|
return;
|
2012-02-20 23:53:00 +01:00
|
|
|
default:
|
|
|
|
BUG();
|
|
|
|
}
|
2013-04-03 18:39:17 +02:00
|
|
|
if (test_opt(inode->i_sb, DELALLOC))
|
|
|
|
inode->i_mapping->a_ops = &ext4_da_aops;
|
|
|
|
else
|
|
|
|
inode->i_mapping->a_ops = &ext4_aops;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2015-02-17 00:59:38 +01:00
|
|
|
static int __ext4_block_zero_page_range(handle_t *handle,
|
2013-05-28 05:32:35 +02:00
|
|
|
struct address_space *mapping, loff_t from, loff_t length)
|
|
|
|
{
|
|
|
|
ext4_fsblk_t index = from >> PAGE_CACHE_SHIFT;
|
|
|
|
unsigned offset = from & (PAGE_CACHE_SIZE-1);
|
2015-02-17 00:59:38 +01:00
|
|
|
unsigned blocksize, pos;
|
2013-05-28 05:32:35 +02:00
|
|
|
ext4_lblk_t iblock;
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
struct buffer_head *bh;
|
|
|
|
struct page *page;
|
|
|
|
int err = 0;
|
|
|
|
|
|
|
|
page = find_or_create_page(mapping, from >> PAGE_CACHE_SHIFT,
|
2015-11-07 01:28:49 +01:00
|
|
|
mapping_gfp_constraint(mapping, ~__GFP_FS));
|
2013-05-28 05:32:35 +02:00
|
|
|
if (!page)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
blocksize = inode->i_sb->s_blocksize;
|
|
|
|
|
|
|
|
iblock = index << (PAGE_CACHE_SHIFT - inode->i_sb->s_blocksize_bits);
|
|
|
|
|
|
|
|
if (!page_has_buffers(page))
|
|
|
|
create_empty_buffers(page, blocksize, 0);
|
|
|
|
|
|
|
|
/* Find the buffer that contains "offset" */
|
|
|
|
bh = page_buffers(page);
|
|
|
|
pos = blocksize;
|
|
|
|
while (offset >= pos) {
|
|
|
|
bh = bh->b_this_page;
|
|
|
|
iblock++;
|
|
|
|
pos += blocksize;
|
|
|
|
}
|
|
|
|
if (buffer_freed(bh)) {
|
|
|
|
BUFFER_TRACE(bh, "freed: skip");
|
|
|
|
goto unlock;
|
|
|
|
}
|
|
|
|
if (!buffer_mapped(bh)) {
|
|
|
|
BUFFER_TRACE(bh, "unmapped");
|
|
|
|
ext4_get_block(inode, iblock, bh, 0);
|
|
|
|
/* unmapped? It's a hole - nothing to do */
|
|
|
|
if (!buffer_mapped(bh)) {
|
|
|
|
BUFFER_TRACE(bh, "still unmapped");
|
|
|
|
goto unlock;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Ok, it's mapped. Make sure it's up-to-date */
|
|
|
|
if (PageUptodate(page))
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
|
|
|
|
if (!buffer_uptodate(bh)) {
|
|
|
|
err = -EIO;
|
|
|
|
ll_rw_block(READ, 1, &bh);
|
|
|
|
wait_on_buffer(bh);
|
|
|
|
/* Uhhuh. Read error. Complain and punt. */
|
|
|
|
if (!buffer_uptodate(bh))
|
|
|
|
goto unlock;
|
2015-04-12 06:56:10 +02:00
|
|
|
if (S_ISREG(inode->i_mode) &&
|
|
|
|
ext4_encrypted_inode(inode)) {
|
|
|
|
/* We expect the key to be set. */
|
|
|
|
BUG_ON(!ext4_has_encryption_key(inode));
|
|
|
|
BUG_ON(blocksize != PAGE_CACHE_SIZE);
|
2015-10-03 16:49:26 +02:00
|
|
|
WARN_ON_ONCE(ext4_decrypt(page));
|
2015-04-12 06:56:10 +02:00
|
|
|
}
|
2013-05-28 05:32:35 +02:00
|
|
|
}
|
|
|
|
if (ext4_should_journal_data(inode)) {
|
|
|
|
BUFFER_TRACE(bh, "get write access");
|
|
|
|
err = ext4_journal_get_write_access(handle, bh);
|
|
|
|
if (err)
|
|
|
|
goto unlock;
|
|
|
|
}
|
|
|
|
zero_user(page, offset, length);
|
|
|
|
BUFFER_TRACE(bh, "zeroed end of block");
|
|
|
|
|
|
|
|
if (ext4_should_journal_data(inode)) {
|
|
|
|
err = ext4_handle_dirty_metadata(handle, inode, bh);
|
2013-05-28 05:32:35 +02:00
|
|
|
} else {
|
2013-07-01 14:12:39 +02:00
|
|
|
err = 0;
|
2013-05-28 05:32:35 +02:00
|
|
|
mark_buffer_dirty(bh);
|
2013-05-28 05:32:35 +02:00
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_ORDERED_MODE))
|
|
|
|
err = ext4_jbd2_file_inode(handle, inode);
|
|
|
|
}
|
2013-05-28 05:32:35 +02:00
|
|
|
|
|
|
|
unlock:
|
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2015-02-17 00:59:38 +01:00
|
|
|
/*
|
|
|
|
* ext4_block_zero_page_range() zeros out a mapping of length 'length'
|
|
|
|
* starting from file offset 'from'. The range to be zero'd must
|
|
|
|
* be contained with in one block. If the specified range exceeds
|
|
|
|
* the end of the block it will be shortened to end of the block
|
|
|
|
* that cooresponds to 'from'
|
|
|
|
*/
|
|
|
|
static int ext4_block_zero_page_range(handle_t *handle,
|
|
|
|
struct address_space *mapping, loff_t from, loff_t length)
|
|
|
|
{
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
unsigned offset = from & (PAGE_CACHE_SIZE-1);
|
|
|
|
unsigned blocksize = inode->i_sb->s_blocksize;
|
|
|
|
unsigned max = blocksize - (offset & (blocksize - 1));
|
|
|
|
|
|
|
|
/*
|
|
|
|
* correct length if it does not fall between
|
|
|
|
* 'from' and the end of the block
|
|
|
|
*/
|
|
|
|
if (length > max || length < 0)
|
|
|
|
length = max;
|
|
|
|
|
|
|
|
if (IS_DAX(inode))
|
|
|
|
return dax_zero_page_range(inode, from, length, ext4_get_block);
|
|
|
|
return __ext4_block_zero_page_range(handle, mapping, from, length);
|
|
|
|
}
|
|
|
|
|
2014-03-24 20:09:16 +01:00
|
|
|
/*
|
|
|
|
* ext4_block_truncate_page() zeroes out a mapping from file offset `from'
|
|
|
|
* up to the end of the block which corresponds to `from'.
|
|
|
|
* This required during truncate. We need to physically zero the tail end
|
|
|
|
* of that block so it doesn't yield old data if the file is later grown.
|
|
|
|
*/
|
2014-05-12 16:50:23 +02:00
|
|
|
static int ext4_block_truncate_page(handle_t *handle,
|
2014-03-24 20:09:16 +01:00
|
|
|
struct address_space *mapping, loff_t from)
|
|
|
|
{
|
|
|
|
unsigned offset = from & (PAGE_CACHE_SIZE-1);
|
|
|
|
unsigned length;
|
|
|
|
unsigned blocksize;
|
|
|
|
struct inode *inode = mapping->host;
|
|
|
|
|
|
|
|
blocksize = inode->i_sb->s_blocksize;
|
|
|
|
length = blocksize - (offset & (blocksize - 1));
|
|
|
|
|
|
|
|
return ext4_block_zero_page_range(handle, mapping, from, length);
|
|
|
|
}
|
|
|
|
|
2013-05-28 05:32:35 +02:00
|
|
|
int ext4_zero_partial_blocks(handle_t *handle, struct inode *inode,
|
|
|
|
loff_t lstart, loff_t length)
|
|
|
|
{
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2013-07-01 14:12:39 +02:00
|
|
|
unsigned partial_start, partial_end;
|
2013-05-28 05:32:35 +02:00
|
|
|
ext4_fsblk_t start, end;
|
|
|
|
loff_t byte_end = (lstart + length - 1);
|
|
|
|
int err = 0;
|
|
|
|
|
2013-07-01 14:12:39 +02:00
|
|
|
partial_start = lstart & (sb->s_blocksize - 1);
|
|
|
|
partial_end = byte_end & (sb->s_blocksize - 1);
|
|
|
|
|
2013-05-28 05:32:35 +02:00
|
|
|
start = lstart >> sb->s_blocksize_bits;
|
|
|
|
end = byte_end >> sb->s_blocksize_bits;
|
|
|
|
|
|
|
|
/* Handle partial zero within the single block */
|
2013-07-01 14:12:39 +02:00
|
|
|
if (start == end &&
|
|
|
|
(partial_start || (partial_end != sb->s_blocksize - 1))) {
|
2013-05-28 05:32:35 +02:00
|
|
|
err = ext4_block_zero_page_range(handle, mapping,
|
|
|
|
lstart, length);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
/* Handle partial zero out on the start of the range */
|
2013-07-01 14:12:39 +02:00
|
|
|
if (partial_start) {
|
2013-05-28 05:32:35 +02:00
|
|
|
err = ext4_block_zero_page_range(handle, mapping,
|
|
|
|
lstart, sb->s_blocksize);
|
|
|
|
if (err)
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
/* Handle partial zero out on the end of the range */
|
2013-07-01 14:12:39 +02:00
|
|
|
if (partial_end != sb->s_blocksize - 1)
|
2013-05-28 05:32:35 +02:00
|
|
|
err = ext4_block_zero_page_range(handle, mapping,
|
2013-07-01 14:12:39 +02:00
|
|
|
byte_end - partial_end,
|
|
|
|
partial_end + 1);
|
2013-05-28 05:32:35 +02:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
int ext4_can_truncate(struct inode *inode)
|
|
|
|
{
|
|
|
|
if (S_ISREG(inode->i_mode))
|
|
|
|
return 1;
|
|
|
|
if (S_ISDIR(inode->i_mode))
|
|
|
|
return 1;
|
|
|
|
if (S_ISLNK(inode->i_mode))
|
|
|
|
return !ext4_inode_is_fast_symlink(inode);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-12-07 20:34:49 +01:00
|
|
|
/*
|
|
|
|
* We have to make sure i_disksize gets properly updated before we truncate
|
|
|
|
* page cache due to hole punching or zero range. Otherwise i_disksize update
|
|
|
|
* can get lost as it may have been postponed to submission of writeback but
|
|
|
|
* that will never happen after we truncate page cache.
|
|
|
|
*/
|
|
|
|
int ext4_update_disksize_before_punch(struct inode *inode, loff_t offset,
|
|
|
|
loff_t len)
|
|
|
|
{
|
|
|
|
handle_t *handle;
|
|
|
|
loff_t size = i_size_read(inode);
|
|
|
|
|
2016-01-22 21:40:57 +01:00
|
|
|
WARN_ON(!inode_is_locked(inode));
|
2015-12-07 20:34:49 +01:00
|
|
|
if (offset > size || offset + len < size)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
if (EXT4_I(inode)->i_disksize >= size)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_MISC, 1);
|
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
|
|
|
ext4_update_i_disksize(inode, size);
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-05-25 13:41:50 +02:00
|
|
|
/*
|
|
|
|
* ext4_punch_hole: punches a hole in a file by releaseing the blocks
|
|
|
|
* associated with the given offset and length
|
|
|
|
*
|
|
|
|
* @inode: File inode
|
|
|
|
* @offset: The offset where the hole will begin
|
|
|
|
* @len: The length of the hole
|
|
|
|
*
|
2012-09-01 19:31:09 +02:00
|
|
|
* Returns: 0 on success or negative on failure
|
2011-05-25 13:41:50 +02:00
|
|
|
*/
|
|
|
|
|
2013-07-01 14:12:38 +02:00
|
|
|
int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length)
|
2011-05-25 13:41:50 +02:00
|
|
|
{
|
2013-04-03 18:45:17 +02:00
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
ext4_lblk_t first_block, stop_block;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2013-05-28 05:32:35 +02:00
|
|
|
loff_t first_block_offset, last_block_offset;
|
2013-04-03 18:45:17 +02:00
|
|
|
handle_t *handle;
|
|
|
|
unsigned int credits;
|
|
|
|
int ret = 0;
|
|
|
|
|
2011-05-25 13:41:50 +02:00
|
|
|
if (!S_ISREG(inode->i_mode))
|
2012-03-22 03:23:31 +01:00
|
|
|
return -EOPNOTSUPP;
|
2011-05-25 13:41:50 +02:00
|
|
|
|
2014-03-18 23:05:35 +01:00
|
|
|
trace_ext4_punch_hole(inode, offset, length, 0);
|
2013-01-17 02:21:26 +01:00
|
|
|
|
2013-04-03 18:45:17 +02:00
|
|
|
/*
|
|
|
|
* Write out all dirty pages to avoid race conditions
|
|
|
|
* Then release them.
|
|
|
|
*/
|
|
|
|
if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) {
|
|
|
|
ret = filemap_write_and_wait_range(mapping, offset,
|
|
|
|
offset + length - 1);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2016-01-22 21:40:57 +01:00
|
|
|
inode_lock(inode);
|
2014-04-12 15:47:00 +02:00
|
|
|
|
2013-04-03 18:45:17 +02:00
|
|
|
/* No need to punch hole beyond i_size */
|
|
|
|
if (offset >= inode->i_size)
|
|
|
|
goto out_mutex;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the hole extends beyond i_size, set the hole
|
|
|
|
* to end after the page that contains i_size
|
|
|
|
*/
|
|
|
|
if (offset + length > inode->i_size) {
|
|
|
|
length = inode->i_size +
|
|
|
|
PAGE_CACHE_SIZE - (inode->i_size & (PAGE_CACHE_SIZE - 1)) -
|
|
|
|
offset;
|
|
|
|
}
|
|
|
|
|
2013-08-17 03:19:41 +02:00
|
|
|
if (offset & (sb->s_blocksize - 1) ||
|
|
|
|
(offset + length) & (sb->s_blocksize - 1)) {
|
|
|
|
/*
|
|
|
|
* Attach jinode to inode for jbd2 if we do any zeroing of
|
|
|
|
* partial block
|
|
|
|
*/
|
|
|
|
ret = ext4_inode_attach_jinode(inode);
|
|
|
|
if (ret < 0)
|
|
|
|
goto out_mutex;
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2015-12-07 20:28:03 +01:00
|
|
|
/* Wait all existing dio workers, newcomers will block on i_mutex */
|
|
|
|
ext4_inode_block_unlocked_dio(inode);
|
|
|
|
inode_dio_wait(inode);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Prevent page faults from reinstantiating pages we have released from
|
|
|
|
* page cache.
|
|
|
|
*/
|
|
|
|
down_write(&EXT4_I(inode)->i_mmap_sem);
|
2013-05-28 05:32:35 +02:00
|
|
|
first_block_offset = round_up(offset, sb->s_blocksize);
|
|
|
|
last_block_offset = round_down((offset + length), sb->s_blocksize) - 1;
|
2013-04-03 18:45:17 +02:00
|
|
|
|
2013-05-28 05:32:35 +02:00
|
|
|
/* Now release the pages and zero block aligned part of pages*/
|
2015-12-07 20:34:49 +01:00
|
|
|
if (last_block_offset > first_block_offset) {
|
|
|
|
ret = ext4_update_disksize_before_punch(inode, offset, length);
|
|
|
|
if (ret)
|
|
|
|
goto out_dio;
|
2013-05-28 05:32:35 +02:00
|
|
|
truncate_pagecache_range(inode, first_block_offset,
|
|
|
|
last_block_offset);
|
2015-12-07 20:34:49 +01:00
|
|
|
}
|
2013-04-03 18:45:17 +02:00
|
|
|
|
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
credits = ext4_writepage_trans_blocks(inode);
|
|
|
|
else
|
|
|
|
credits = ext4_blocks_for_truncate(inode);
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_TRUNCATE, credits);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ret = PTR_ERR(handle);
|
|
|
|
ext4_std_error(sb, ret);
|
|
|
|
goto out_dio;
|
|
|
|
}
|
|
|
|
|
2013-05-28 05:32:35 +02:00
|
|
|
ret = ext4_zero_partial_blocks(handle, inode, offset,
|
|
|
|
length);
|
|
|
|
if (ret)
|
|
|
|
goto out_stop;
|
2013-04-03 18:45:17 +02:00
|
|
|
|
|
|
|
first_block = (offset + sb->s_blocksize - 1) >>
|
|
|
|
EXT4_BLOCK_SIZE_BITS(sb);
|
|
|
|
stop_block = (offset + length) >> EXT4_BLOCK_SIZE_BITS(sb);
|
|
|
|
|
|
|
|
/* If there are no blocks to remove, return now */
|
|
|
|
if (first_block >= stop_block)
|
|
|
|
goto out_stop;
|
|
|
|
|
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
ext4_discard_preallocations(inode);
|
|
|
|
|
|
|
|
ret = ext4_es_remove_extent(inode, first_block,
|
|
|
|
stop_block - first_block);
|
|
|
|
if (ret) {
|
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
goto out_stop;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
ret = ext4_ext_remove_space(inode, first_block,
|
|
|
|
stop_block - 1);
|
|
|
|
else
|
2014-07-15 12:03:38 +02:00
|
|
|
ret = ext4_ind_remove_space(handle, inode, first_block,
|
2013-04-03 18:45:17 +02:00
|
|
|
stop_block);
|
|
|
|
|
2013-04-03 18:47:17 +02:00
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2013-04-03 18:45:17 +02:00
|
|
|
if (IS_SYNC(inode))
|
|
|
|
ext4_handle_sync(handle);
|
2014-02-20 22:58:05 +01:00
|
|
|
|
2013-04-03 18:45:17 +02:00
|
|
|
inode->i_mtime = inode->i_ctime = ext4_current_time(inode);
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
|
|
|
out_stop:
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
out_dio:
|
2015-12-07 20:28:03 +01:00
|
|
|
up_write(&EXT4_I(inode)->i_mmap_sem);
|
2013-04-03 18:45:17 +02:00
|
|
|
ext4_inode_resume_unlocked_dio(inode);
|
|
|
|
out_mutex:
|
2016-01-22 21:40:57 +01:00
|
|
|
inode_unlock(inode);
|
2013-04-03 18:45:17 +02:00
|
|
|
return ret;
|
2011-05-25 13:41:50 +02:00
|
|
|
}
|
|
|
|
|
2013-08-17 03:19:41 +02:00
|
|
|
int ext4_inode_attach_jinode(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
struct jbd2_inode *jinode;
|
|
|
|
|
|
|
|
if (ei->jinode || !EXT4_SB(inode->i_sb)->s_journal)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
jinode = jbd2_alloc_inode(GFP_KERNEL);
|
|
|
|
spin_lock(&inode->i_lock);
|
|
|
|
if (!ei->jinode) {
|
|
|
|
if (!jinode) {
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
ei->jinode = jinode;
|
|
|
|
jbd2_journal_init_jbd_inode(ei->jinode, inode);
|
|
|
|
jinode = NULL;
|
|
|
|
}
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
if (unlikely(jinode != NULL))
|
|
|
|
jbd2_free_inode(jinode);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_truncate()
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
2006-10-11 10:20:53 +02:00
|
|
|
* We block out ext4_get_block() block instantiations across the entire
|
|
|
|
* transaction, and VFS/VM ensures that ext4_truncate() cannot run
|
2006-10-11 10:20:50 +02:00
|
|
|
* simultaneously on behalf of the same inode.
|
|
|
|
*
|
2011-11-29 05:31:00 +01:00
|
|
|
* As we work through the truncate and commit bits of it to the journal there
|
2006-10-11 10:20:50 +02:00
|
|
|
* is one core, guiding principle: the file's tree must always be consistent on
|
|
|
|
* disk. We must be able to restart the truncate after a crash.
|
|
|
|
*
|
|
|
|
* The file's tree may be transiently inconsistent in memory (although it
|
|
|
|
* probably isn't), but whenever we close off and commit a journal transaction,
|
|
|
|
* the contents of (the filesystem + the journal) must be consistent and
|
|
|
|
* restartable. It's pretty simple, really: bottom up, right to left (although
|
|
|
|
* left-to-right works OK too).
|
|
|
|
*
|
|
|
|
* Note that at recovery time, journal replay occurs *before* the restart of
|
|
|
|
* truncate against the orphan inode list.
|
|
|
|
*
|
|
|
|
* The committed inode has the new, desired i_size (which is the same as
|
2006-10-11 10:20:53 +02:00
|
|
|
* i_disksize in this case). After a crash, ext4_orphan_cleanup() will see
|
2006-10-11 10:20:50 +02:00
|
|
|
* that this inode's truncate did not complete and it will again call
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_truncate() to have another go. So there will be instantiated blocks
|
|
|
|
* to the right of the truncation point in a crashed ext4 filesystem. But
|
2006-10-11 10:20:50 +02:00
|
|
|
* that's fine - as long as they are linked from the inode, the post-crash
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_truncate() run will find them and release them.
|
2006-10-11 10:20:50 +02:00
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
void ext4_truncate(struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2013-04-03 18:47:17 +02:00
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
unsigned int credits;
|
|
|
|
handle_t *handle;
|
|
|
|
struct address_space *mapping = inode->i_mapping;
|
|
|
|
|
2013-04-04 03:58:52 +02:00
|
|
|
/*
|
|
|
|
* There is a possibility that we're either freeing the inode
|
2014-03-24 20:15:07 +01:00
|
|
|
* or it's a completely new inode. In those cases we might not
|
2013-04-04 03:58:52 +02:00
|
|
|
* have i_mutex locked because it's not necessary.
|
|
|
|
*/
|
|
|
|
if (!(inode->i_state & (I_NEW|I_FREEING)))
|
2016-01-22 21:40:57 +01:00
|
|
|
WARN_ON(!inode_is_locked(inode));
|
2011-03-22 02:38:05 +01:00
|
|
|
trace_ext4_truncate_enter(inode);
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
if (!ext4_can_truncate(inode))
|
2006-10-11 10:20:50 +02:00
|
|
|
return;
|
|
|
|
|
2010-05-17 04:00:00 +02:00
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_EOFBLOCKS);
|
2010-02-24 15:52:53 +01:00
|
|
|
|
2009-09-17 15:34:16 +02:00
|
|
|
if (inode->i_size == 0 && !test_opt(inode->i_sb, NO_AUTO_DA_ALLOC))
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_DA_ALLOC_CLOSE);
|
2009-02-24 14:21:14 +01:00
|
|
|
|
2012-12-10 20:06:02 +01:00
|
|
|
if (ext4_has_inline_data(inode)) {
|
|
|
|
int has_inline = 1;
|
|
|
|
|
|
|
|
ext4_inline_data_truncate(inode, &has_inline);
|
|
|
|
if (has_inline)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-08-17 03:19:41 +02:00
|
|
|
/* If we zero-out tail of the page, we have to create jinode for jbd2 */
|
|
|
|
if (inode->i_size & (inode->i_sb->s_blocksize - 1)) {
|
|
|
|
if (ext4_inode_attach_jinode(inode) < 0)
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-04-03 18:47:17 +02:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
|
|
|
credits = ext4_writepage_trans_blocks(inode);
|
|
|
|
else
|
|
|
|
credits = ext4_blocks_for_truncate(inode);
|
|
|
|
|
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_TRUNCATE, credits);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
ext4_std_error(inode->i_sb, PTR_ERR(handle));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2013-05-28 05:32:35 +02:00
|
|
|
if (inode->i_size & (inode->i_sb->s_blocksize - 1))
|
|
|
|
ext4_block_truncate_page(handle, mapping, inode->i_size);
|
2013-04-03 18:47:17 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* We add the inode to the orphan list, so that if this
|
|
|
|
* truncate spans multiple transactions, and we crash, we will
|
|
|
|
* resume the truncate when the filesystem recovers. It also
|
|
|
|
* marks the inode dirty, to catch the new size.
|
|
|
|
*
|
|
|
|
* Implication: the file must always be in a sane, consistent
|
|
|
|
* truncatable state while each transaction commits.
|
|
|
|
*/
|
|
|
|
if (ext4_orphan_add(handle, inode))
|
|
|
|
goto out_stop;
|
|
|
|
|
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
|
|
|
|
|
|
|
ext4_discard_preallocations(inode);
|
|
|
|
|
2011-06-27 22:36:31 +02:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
|
2013-04-03 18:47:17 +02:00
|
|
|
ext4_ext_truncate(handle, inode);
|
2011-06-27 22:36:31 +02:00
|
|
|
else
|
2013-04-03 18:47:17 +02:00
|
|
|
ext4_ind_truncate(handle, inode);
|
|
|
|
|
|
|
|
up_write(&ei->i_data_sem);
|
|
|
|
|
|
|
|
if (IS_SYNC(inode))
|
|
|
|
ext4_handle_sync(handle);
|
|
|
|
|
|
|
|
out_stop:
|
|
|
|
/*
|
|
|
|
* If this was a simple ftruncate() and the file will remain alive,
|
|
|
|
* then we need to clear up the orphan record which we created above.
|
|
|
|
* However, if this was a real unlink then we were called by
|
2014-11-25 22:17:29 +01:00
|
|
|
* ext4_evict_inode(), and we allow that function to clean up the
|
2013-04-03 18:47:17 +02:00
|
|
|
* orphan info for us.
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink)
|
|
|
|
ext4_orphan_del(handle, inode);
|
|
|
|
|
|
|
|
inode->i_mtime = inode->i_ctime = ext4_current_time(inode);
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2011-03-22 02:38:05 +01:00
|
|
|
trace_ext4_truncate_exit(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_get_inode_loc returns with an extra refcount against the inode's
|
2006-10-11 10:20:50 +02:00
|
|
|
* underlying buffer_head on success. If 'in_mem' is true, we have all
|
|
|
|
* data in memory that is needed to recreate the on-disk version of this
|
|
|
|
* inode.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
static int __ext4_get_inode_loc(struct inode *inode,
|
|
|
|
struct ext4_iloc *iloc, int in_mem)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2008-10-10 05:53:47 +02:00
|
|
|
struct ext4_group_desc *gdp;
|
|
|
|
struct buffer_head *bh;
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
ext4_fsblk_t block;
|
|
|
|
int inodes_per_block, inode_offset;
|
|
|
|
|
2008-11-22 21:04:59 +01:00
|
|
|
iloc->bh = NULL;
|
2008-10-10 05:53:47 +02:00
|
|
|
if (!ext4_valid_inum(sb, inode->i_ino))
|
2015-10-17 22:16:04 +02:00
|
|
|
return -EFSCORRUPTED;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2008-10-10 05:53:47 +02:00
|
|
|
iloc->block_group = (inode->i_ino - 1) / EXT4_INODES_PER_GROUP(sb);
|
|
|
|
gdp = ext4_get_group_desc(sb, iloc->block_group, NULL);
|
|
|
|
if (!gdp)
|
2006-10-11 10:20:50 +02:00
|
|
|
return -EIO;
|
|
|
|
|
2008-10-10 05:53:47 +02:00
|
|
|
/*
|
|
|
|
* Figure out the offset within the block group inode table
|
|
|
|
*/
|
2011-05-09 16:26:41 +02:00
|
|
|
inodes_per_block = EXT4_SB(sb)->s_inodes_per_block;
|
2008-10-10 05:53:47 +02:00
|
|
|
inode_offset = ((inode->i_ino - 1) %
|
|
|
|
EXT4_INODES_PER_GROUP(sb));
|
|
|
|
block = ext4_inode_table(sb, gdp) + (inode_offset / inodes_per_block);
|
|
|
|
iloc->offset = (inode_offset % inodes_per_block) * EXT4_INODE_SIZE(sb);
|
|
|
|
|
|
|
|
bh = sb_getblk(sb, block);
|
2013-01-12 22:28:47 +01:00
|
|
|
if (unlikely(!bh))
|
2013-01-12 22:19:36 +01:00
|
|
|
return -ENOMEM;
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!buffer_uptodate(bh)) {
|
|
|
|
lock_buffer(bh);
|
2008-07-26 22:39:26 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* If the buffer has the write error flag, we have failed
|
|
|
|
* to write out another inode in the same block. In this
|
|
|
|
* case, we don't have to read the block because we may
|
|
|
|
* read the old inode data successfully.
|
|
|
|
*/
|
|
|
|
if (buffer_write_io_error(bh) && !buffer_uptodate(bh))
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
if (buffer_uptodate(bh)) {
|
|
|
|
/* someone brought it uptodate while we waited */
|
|
|
|
unlock_buffer(bh);
|
|
|
|
goto has_buffer;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If we have all information of the inode in memory and this
|
|
|
|
* is the only valid inode in the block, we need not read the
|
|
|
|
* block.
|
|
|
|
*/
|
|
|
|
if (in_mem) {
|
|
|
|
struct buffer_head *bitmap_bh;
|
2008-10-10 05:53:47 +02:00
|
|
|
int i, start;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2008-10-10 05:53:47 +02:00
|
|
|
start = inode_offset & ~(inodes_per_block - 1);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2008-10-10 05:53:47 +02:00
|
|
|
/* Is the inode bitmap in cache? */
|
|
|
|
bitmap_bh = sb_getblk(sb, ext4_inode_bitmap(sb, gdp));
|
2013-01-12 22:28:47 +01:00
|
|
|
if (unlikely(!bitmap_bh))
|
2006-10-11 10:20:50 +02:00
|
|
|
goto make_io;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the inode bitmap isn't in cache then the
|
|
|
|
* optimisation may end up performing two reads instead
|
|
|
|
* of one, so skip it.
|
|
|
|
*/
|
|
|
|
if (!buffer_uptodate(bitmap_bh)) {
|
|
|
|
brelse(bitmap_bh);
|
|
|
|
goto make_io;
|
|
|
|
}
|
2008-10-10 05:53:47 +02:00
|
|
|
for (i = start; i < start + inodes_per_block; i++) {
|
2006-10-11 10:20:50 +02:00
|
|
|
if (i == inode_offset)
|
|
|
|
continue;
|
2006-10-11 10:20:53 +02:00
|
|
|
if (ext4_test_bit(i, bitmap_bh->b_data))
|
2006-10-11 10:20:50 +02:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
brelse(bitmap_bh);
|
2008-10-10 05:53:47 +02:00
|
|
|
if (i == start + inodes_per_block) {
|
2006-10-11 10:20:50 +02:00
|
|
|
/* all other inodes are free, so skip I/O */
|
|
|
|
memset(bh->b_data, 0, bh->b_size);
|
|
|
|
set_buffer_uptodate(bh);
|
|
|
|
unlock_buffer(bh);
|
|
|
|
goto has_buffer;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
make_io:
|
2008-10-10 05:53:47 +02:00
|
|
|
/*
|
|
|
|
* If we need to do any I/O, try to pre-readahead extra
|
|
|
|
* blocks from the inode table.
|
|
|
|
*/
|
|
|
|
if (EXT4_SB(sb)->s_inode_readahead_blks) {
|
|
|
|
ext4_fsblk_t b, end, table;
|
|
|
|
unsigned num;
|
2013-04-23 14:59:35 +02:00
|
|
|
__u32 ra_blks = EXT4_SB(sb)->s_inode_readahead_blks;
|
2008-10-10 05:53:47 +02:00
|
|
|
|
|
|
|
table = ext4_inode_table(sb, gdp);
|
2009-03-31 15:11:14 +02:00
|
|
|
/* s_inode_readahead_blks is always a power of 2 */
|
2013-04-23 14:59:35 +02:00
|
|
|
b = block & ~((ext4_fsblk_t) ra_blks - 1);
|
2008-10-10 05:53:47 +02:00
|
|
|
if (table > b)
|
|
|
|
b = table;
|
2013-04-23 14:59:35 +02:00
|
|
|
end = b + ra_blks;
|
2008-10-10 05:53:47 +02:00
|
|
|
num = EXT4_INODES_PER_GROUP(sb);
|
2012-04-30 00:45:10 +02:00
|
|
|
if (ext4_has_group_desc_csum(sb))
|
2009-01-06 04:20:24 +01:00
|
|
|
num -= ext4_itable_unused_count(sb, gdp);
|
2008-10-10 05:53:47 +02:00
|
|
|
table += num / inodes_per_block;
|
|
|
|
if (end > table)
|
|
|
|
end = table;
|
|
|
|
while (b <= end)
|
|
|
|
sb_breadahead(sb, b++);
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* There are other valid inodes in the buffer, this inode
|
|
|
|
* has in-inode xattrs, or we don't have this inode in memory.
|
|
|
|
* Read the block from disk.
|
|
|
|
*/
|
2011-03-22 02:38:05 +01:00
|
|
|
trace_ext4_load_inode(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
get_bh(bh);
|
|
|
|
bh->b_end_io = end_buffer_read_sync;
|
2011-08-23 14:50:29 +02:00
|
|
|
submit_bh(READ | REQ_META | REQ_PRIO, bh);
|
2006-10-11 10:20:50 +02:00
|
|
|
wait_on_buffer(bh);
|
|
|
|
if (!buffer_uptodate(bh)) {
|
2010-07-27 17:56:40 +02:00
|
|
|
EXT4_ERROR_INODE_BLOCK(inode, block,
|
|
|
|
"unable to read itable block");
|
2006-10-11 10:20:50 +02:00
|
|
|
brelse(bh);
|
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
has_buffer:
|
|
|
|
iloc->bh = bh;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
int ext4_get_inode_loc(struct inode *inode, struct ext4_iloc *iloc)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
/* We have all inode data except xattrs in memory here. */
|
2006-10-11 10:20:53 +02:00
|
|
|
return __ext4_get_inode_loc(inode, iloc,
|
2010-01-24 20:34:07 +01:00
|
|
|
!ext4_test_inode_state(inode, EXT4_STATE_XATTR));
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
void ext4_set_inode_flags(struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
unsigned int flags = EXT4_I(inode)->i_flags;
|
2014-03-30 16:20:01 +02:00
|
|
|
unsigned int new_fl = 0;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
if (flags & EXT4_SYNC_FL)
|
2014-03-30 16:20:01 +02:00
|
|
|
new_fl |= S_SYNC;
|
2006-10-11 10:20:53 +02:00
|
|
|
if (flags & EXT4_APPEND_FL)
|
2014-03-30 16:20:01 +02:00
|
|
|
new_fl |= S_APPEND;
|
2006-10-11 10:20:53 +02:00
|
|
|
if (flags & EXT4_IMMUTABLE_FL)
|
2014-03-30 16:20:01 +02:00
|
|
|
new_fl |= S_IMMUTABLE;
|
2006-10-11 10:20:53 +02:00
|
|
|
if (flags & EXT4_NOATIME_FL)
|
2014-03-30 16:20:01 +02:00
|
|
|
new_fl |= S_NOATIME;
|
2006-10-11 10:20:53 +02:00
|
|
|
if (flags & EXT4_DIRSYNC_FL)
|
2014-03-30 16:20:01 +02:00
|
|
|
new_fl |= S_DIRSYNC;
|
2015-02-17 00:59:38 +01:00
|
|
|
if (test_opt(inode->i_sb, DAX))
|
|
|
|
new_fl |= S_DAX;
|
2014-03-24 19:43:12 +01:00
|
|
|
inode_set_flags(inode, new_fl,
|
2015-02-17 00:59:38 +01:00
|
|
|
S_SYNC|S_APPEND|S_IMMUTABLE|S_NOATIME|S_DIRSYNC|S_DAX);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2007-07-18 15:24:20 +02:00
|
|
|
/* Propagate flags from i_flags to EXT4_I(inode)->i_flags */
|
|
|
|
void ext4_get_inode_flags(struct ext4_inode_info *ei)
|
|
|
|
{
|
2010-06-05 17:51:27 +02:00
|
|
|
unsigned int vfs_fl;
|
|
|
|
unsigned long old_fl, new_fl;
|
|
|
|
|
|
|
|
do {
|
|
|
|
vfs_fl = ei->vfs_inode.i_flags;
|
|
|
|
old_fl = ei->i_flags;
|
|
|
|
new_fl = old_fl & ~(EXT4_SYNC_FL|EXT4_APPEND_FL|
|
|
|
|
EXT4_IMMUTABLE_FL|EXT4_NOATIME_FL|
|
|
|
|
EXT4_DIRSYNC_FL);
|
|
|
|
if (vfs_fl & S_SYNC)
|
|
|
|
new_fl |= EXT4_SYNC_FL;
|
|
|
|
if (vfs_fl & S_APPEND)
|
|
|
|
new_fl |= EXT4_APPEND_FL;
|
|
|
|
if (vfs_fl & S_IMMUTABLE)
|
|
|
|
new_fl |= EXT4_IMMUTABLE_FL;
|
|
|
|
if (vfs_fl & S_NOATIME)
|
|
|
|
new_fl |= EXT4_NOATIME_FL;
|
|
|
|
if (vfs_fl & S_DIRSYNC)
|
|
|
|
new_fl |= EXT4_DIRSYNC_FL;
|
|
|
|
} while (cmpxchg(&ei->i_flags, old_fl, new_fl) != old_fl);
|
2007-07-18 15:24:20 +02:00
|
|
|
}
|
2009-06-14 23:45:34 +02:00
|
|
|
|
2008-01-29 05:58:26 +01:00
|
|
|
static blkcnt_t ext4_inode_blocks(struct ext4_inode *raw_inode,
|
2009-06-14 23:45:34 +02:00
|
|
|
struct ext4_inode_info *ei)
|
2008-01-29 05:58:26 +01:00
|
|
|
{
|
|
|
|
blkcnt_t i_blocks ;
|
2008-01-29 05:58:27 +01:00
|
|
|
struct inode *inode = &(ei->vfs_inode);
|
|
|
|
struct super_block *sb = inode->i_sb;
|
2008-01-29 05:58:26 +01:00
|
|
|
|
2015-10-17 22:18:43 +02:00
|
|
|
if (ext4_has_feature_huge_file(sb)) {
|
2008-01-29 05:58:26 +01:00
|
|
|
/* we are using combined 48 bit field */
|
|
|
|
i_blocks = ((u64)le16_to_cpu(raw_inode->i_blocks_high)) << 32 |
|
|
|
|
le32_to_cpu(raw_inode->i_blocks_lo);
|
2010-06-14 15:54:48 +02:00
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_HUGE_FILE)) {
|
2008-01-29 05:58:27 +01:00
|
|
|
/* i_blocks represent file system block size */
|
|
|
|
return i_blocks << (inode->i_blkbits - 9);
|
|
|
|
} else {
|
|
|
|
return i_blocks;
|
|
|
|
}
|
2008-01-29 05:58:26 +01:00
|
|
|
} else {
|
|
|
|
return le32_to_cpu(raw_inode->i_blocks_lo);
|
|
|
|
}
|
|
|
|
}
|
2007-07-18 15:24:20 +02:00
|
|
|
|
2012-12-02 17:13:24 +01:00
|
|
|
static inline void ext4_iget_extra_inode(struct inode *inode,
|
|
|
|
struct ext4_inode *raw_inode,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
__le32 *magic = (void *)raw_inode +
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize;
|
2012-12-10 20:04:46 +01:00
|
|
|
if (*magic == cpu_to_le32(EXT4_XATTR_MAGIC)) {
|
2012-12-02 17:13:24 +01:00
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_XATTR);
|
2012-12-10 20:04:46 +01:00
|
|
|
ext4_find_inline_data_nolock(inode);
|
2012-12-10 20:05:51 +01:00
|
|
|
} else
|
|
|
|
EXT4_I(inode)->i_inline_off = 0;
|
2012-12-02 17:13:24 +01:00
|
|
|
}
|
|
|
|
|
2016-01-08 22:01:21 +01:00
|
|
|
int ext4_get_projid(struct inode *inode, kprojid_t *projid)
|
|
|
|
{
|
|
|
|
if (!EXT4_HAS_RO_COMPAT_FEATURE(inode->i_sb, EXT4_FEATURE_RO_COMPAT_PROJECT))
|
|
|
|
return -EOPNOTSUPP;
|
|
|
|
*projid = EXT4_I(inode)->i_projid;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-02-07 09:15:37 +01:00
|
|
|
struct inode *ext4_iget(struct super_block *sb, unsigned long ino)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
struct ext4_iloc iloc;
|
|
|
|
struct ext4_inode *raw_inode;
|
2008-02-07 09:15:37 +01:00
|
|
|
struct ext4_inode_info *ei;
|
|
|
|
struct inode *inode;
|
2009-12-09 05:51:10 +01:00
|
|
|
journal_t *journal = EXT4_SB(sb)->s_journal;
|
2008-02-07 09:15:37 +01:00
|
|
|
long ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
int block;
|
2012-02-08 00:41:49 +01:00
|
|
|
uid_t i_uid;
|
|
|
|
gid_t i_gid;
|
2016-01-08 22:01:21 +01:00
|
|
|
projid_t i_projid;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2008-02-07 09:15:37 +01:00
|
|
|
inode = iget_locked(sb, ino);
|
|
|
|
if (!inode)
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
if (!(inode->i_state & I_NEW))
|
|
|
|
return inode;
|
|
|
|
|
|
|
|
ei = EXT4_I(inode);
|
2011-02-22 03:01:42 +01:00
|
|
|
iloc.bh = NULL;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2008-02-07 09:15:37 +01:00
|
|
|
ret = __ext4_get_inode_loc(inode, &iloc, 0);
|
|
|
|
if (ret < 0)
|
2006-10-11 10:20:50 +02:00
|
|
|
goto bad_inode;
|
2006-10-11 10:20:53 +02:00
|
|
|
raw_inode = ext4_raw_inode(&iloc);
|
2012-04-30 00:31:10 +02:00
|
|
|
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
|
|
|
ei->i_extra_isize = le16_to_cpu(raw_inode->i_extra_isize);
|
|
|
|
if (EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize >
|
|
|
|
EXT4_INODE_SIZE(inode->i_sb)) {
|
|
|
|
EXT4_ERROR_INODE(inode, "bad extra_isize (%u != %u)",
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE + ei->i_extra_isize,
|
|
|
|
EXT4_INODE_SIZE(inode->i_sb));
|
2015-10-17 22:16:04 +02:00
|
|
|
ret = -EFSCORRUPTED;
|
2012-04-30 00:31:10 +02:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
} else
|
|
|
|
ei->i_extra_isize = 0;
|
|
|
|
|
|
|
|
/* Precompute checksum seed for inode metadata */
|
2014-10-13 09:36:16 +02:00
|
|
|
if (ext4_has_metadata_csum(sb)) {
|
2012-04-30 00:31:10 +02:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
__u32 csum;
|
|
|
|
__le32 inum = cpu_to_le32(inode->i_ino);
|
|
|
|
__le32 gen = raw_inode->i_generation;
|
|
|
|
csum = ext4_chksum(sbi, sbi->s_csum_seed, (__u8 *)&inum,
|
|
|
|
sizeof(inum));
|
|
|
|
ei->i_csum_seed = ext4_chksum(sbi, csum, (__u8 *)&gen,
|
|
|
|
sizeof(gen));
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!ext4_inode_csum_verify(inode, raw_inode, ei)) {
|
|
|
|
EXT4_ERROR_INODE(inode, "checksum invalid");
|
2015-10-17 22:16:04 +02:00
|
|
|
ret = -EFSBADCRC;
|
2012-04-30 00:31:10 +02:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
inode->i_mode = le16_to_cpu(raw_inode->i_mode);
|
2012-02-08 00:41:49 +01:00
|
|
|
i_uid = (uid_t)le16_to_cpu(raw_inode->i_uid_low);
|
|
|
|
i_gid = (gid_t)le16_to_cpu(raw_inode->i_gid_low);
|
2016-01-08 22:01:21 +01:00
|
|
|
if (EXT4_HAS_RO_COMPAT_FEATURE(sb, EXT4_FEATURE_RO_COMPAT_PROJECT) &&
|
|
|
|
EXT4_INODE_SIZE(sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw_inode, ei, i_projid))
|
|
|
|
i_projid = (projid_t)le32_to_cpu(raw_inode->i_projid);
|
|
|
|
else
|
|
|
|
i_projid = EXT4_DEF_PROJID;
|
|
|
|
|
2008-09-09 04:25:24 +02:00
|
|
|
if (!(test_opt(inode->i_sb, NO_UID32))) {
|
2012-02-08 00:41:49 +01:00
|
|
|
i_uid |= le16_to_cpu(raw_inode->i_uid_high) << 16;
|
|
|
|
i_gid |= le16_to_cpu(raw_inode->i_gid_high) << 16;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2012-02-08 00:41:49 +01:00
|
|
|
i_uid_write(inode, i_uid);
|
|
|
|
i_gid_write(inode, i_gid);
|
2016-01-08 22:01:21 +01:00
|
|
|
ei->i_projid = make_kprojid(&init_user_ns, i_projid);
|
2011-10-28 14:13:29 +02:00
|
|
|
set_nlink(inode, le16_to_cpu(raw_inode->i_links_count));
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2011-01-10 18:18:25 +01:00
|
|
|
ext4_clear_state_flags(ei); /* Only relevant on 32-bit archs */
|
2012-12-10 20:04:46 +01:00
|
|
|
ei->i_inline_off = 0;
|
2006-10-11 10:20:50 +02:00
|
|
|
ei->i_dir_start_lookup = 0;
|
|
|
|
ei->i_dtime = le32_to_cpu(raw_inode->i_dtime);
|
|
|
|
/* We now have enough fields to check if the inode was active or not.
|
|
|
|
* This is needed because nfsd might try to access dead inodes
|
|
|
|
* the test is that same one that e2fsck uses
|
|
|
|
* NeilBrown 1999oct15
|
|
|
|
*/
|
|
|
|
if (inode->i_nlink == 0) {
|
2013-04-08 18:54:05 +02:00
|
|
|
if ((inode->i_mode == 0 ||
|
|
|
|
!(EXT4_SB(inode->i_sb)->s_mount_state & EXT4_ORPHAN_FS)) &&
|
|
|
|
ino != EXT4_BOOT_LOADER_INO) {
|
2006-10-11 10:20:50 +02:00
|
|
|
/* this inode is deleted */
|
2008-02-07 09:15:37 +01:00
|
|
|
ret = -ESTALE;
|
2006-10-11 10:20:50 +02:00
|
|
|
goto bad_inode;
|
|
|
|
}
|
|
|
|
/* The only unlinked inodes we let through here have
|
|
|
|
* valid i_mode and are being read by the orphan
|
|
|
|
* recovery code: that's fine, we're about to complete
|
2013-04-08 18:54:05 +02:00
|
|
|
* the process of deleting those.
|
|
|
|
* OR it is the EXT4_BOOT_LOADER_INO which is
|
|
|
|
* not initialized on a new filesystem. */
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
ei->i_flags = le32_to_cpu(raw_inode->i_flags);
|
2008-01-29 05:58:26 +01:00
|
|
|
inode->i_blocks = ext4_inode_blocks(raw_inode, ei);
|
2008-01-29 05:58:27 +01:00
|
|
|
ei->i_file_acl = le32_to_cpu(raw_inode->i_file_acl_lo);
|
2015-10-17 22:18:43 +02:00
|
|
|
if (ext4_has_feature_64bit(sb))
|
2006-10-11 10:21:09 +02:00
|
|
|
ei->i_file_acl |=
|
|
|
|
((__u64)le16_to_cpu(raw_inode->i_file_acl_high)) << 32;
|
2008-01-29 05:58:27 +01:00
|
|
|
inode->i_size = ext4_isize(raw_inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
ei->i_disksize = inode->i_size;
|
2009-12-14 13:21:14 +01:00
|
|
|
#ifdef CONFIG_QUOTA
|
|
|
|
ei->i_reserved_quota = 0;
|
|
|
|
#endif
|
2006-10-11 10:20:50 +02:00
|
|
|
inode->i_generation = le32_to_cpu(raw_inode->i_generation);
|
|
|
|
ei->i_block_group = iloc.block_group;
|
2009-03-12 17:18:34 +01:00
|
|
|
ei->i_last_alloc_group = ~0;
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* NOTE! The in-memory inode i_data array is in little-endian order
|
|
|
|
* even on big-endian machines: we do NOT byteswap the block numbers!
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
for (block = 0; block < EXT4_N_BLOCKS; block++)
|
2006-10-11 10:20:50 +02:00
|
|
|
ei->i_data[block] = raw_inode->i_block[block];
|
|
|
|
INIT_LIST_HEAD(&ei->i_orphan);
|
|
|
|
|
2009-12-09 05:51:10 +01:00
|
|
|
/*
|
|
|
|
* Set transaction id's of transactions that have to be committed
|
|
|
|
* to finish f[data]sync. We set them to currently running transaction
|
|
|
|
* as we cannot be sure that the inode or some of its metadata isn't
|
|
|
|
* part of the transaction - the inode could have been reclaimed and
|
|
|
|
* now it is reread from disk.
|
|
|
|
*/
|
|
|
|
if (journal) {
|
|
|
|
transaction_t *transaction;
|
|
|
|
tid_t tid;
|
|
|
|
|
2010-08-04 03:35:12 +02:00
|
|
|
read_lock(&journal->j_state_lock);
|
2009-12-09 05:51:10 +01:00
|
|
|
if (journal->j_running_transaction)
|
|
|
|
transaction = journal->j_running_transaction;
|
|
|
|
else
|
|
|
|
transaction = journal->j_committing_transaction;
|
|
|
|
if (transaction)
|
|
|
|
tid = transaction->t_tid;
|
|
|
|
else
|
|
|
|
tid = journal->j_commit_sequence;
|
2010-08-04 03:35:12 +02:00
|
|
|
read_unlock(&journal->j_state_lock);
|
2009-12-09 05:51:10 +01:00
|
|
|
ei->i_sync_tid = tid;
|
|
|
|
ei->i_datasync_tid = tid;
|
|
|
|
}
|
|
|
|
|
2008-02-06 04:36:43 +01:00
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
2006-10-11 10:20:50 +02:00
|
|
|
if (ei->i_extra_isize == 0) {
|
|
|
|
/* The extra space is currently unused. Use it. */
|
2006-10-11 10:20:53 +02:00
|
|
|
ei->i_extra_isize = sizeof(struct ext4_inode) -
|
|
|
|
EXT4_GOOD_OLD_INODE_SIZE;
|
2006-10-11 10:20:50 +02:00
|
|
|
} else {
|
2012-12-02 17:13:24 +01:00
|
|
|
ext4_iget_extra_inode(inode, raw_inode, ei);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2012-04-30 00:31:10 +02:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2007-07-18 15:15:20 +02:00
|
|
|
EXT4_INODE_GET_XTIME(i_ctime, inode, raw_inode);
|
|
|
|
EXT4_INODE_GET_XTIME(i_mtime, inode, raw_inode);
|
|
|
|
EXT4_INODE_GET_XTIME(i_atime, inode, raw_inode);
|
|
|
|
EXT4_EINODE_GET_XTIME(i_crtime, ei, raw_inode);
|
|
|
|
|
2014-03-24 19:09:06 +01:00
|
|
|
if (likely(!test_opt2(inode->i_sb, HURD_COMPAT))) {
|
2014-03-20 05:32:57 +01:00
|
|
|
inode->i_version = le32_to_cpu(raw_inode->i_disk_version);
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE) {
|
|
|
|
if (EXT4_FITS_IN_INODE(raw_inode, ei, i_version_hi))
|
|
|
|
inode->i_version |=
|
|
|
|
(__u64)(le32_to_cpu(raw_inode->i_version_hi)) << 32;
|
|
|
|
}
|
2008-01-29 05:58:27 +01:00
|
|
|
}
|
|
|
|
|
ext4: Do not try to validate extents on special files
The EXTENTS_FL flag should never be set on special files, but if it
is, don't bother trying to validate that the extents tree is valid,
since only files, directories, and non-fast symlinks will ever have an
extent data structure. We perhaps should flag the filesystem as being
corrupted if we see a special file (named pipes, device nodes, Unix
domain sockets, etc.) with the EXTENTS_FL flag, but e2fsck doesn't
currently check this case, so we'll just ignore this for now, since
it's harmless.
Without this fix, a special device with the extents flag is flagged as
an error by the kernel, so it is impossible to access or delete the
inode, but e2fsck doesn't see it as a problem, leading to
confused/frustrated users.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2009-04-25 00:45:35 +02:00
|
|
|
ret = 0;
|
2009-04-24 19:43:20 +02:00
|
|
|
if (ei->i_file_acl &&
|
2009-11-15 21:29:56 +01:00
|
|
|
!ext4_data_block_valid(EXT4_SB(sb), ei->i_file_acl, 1)) {
|
2010-05-17 03:00:00 +02:00
|
|
|
EXT4_ERROR_INODE(inode, "bad extended attribute block %llu",
|
|
|
|
ei->i_file_acl);
|
2015-10-17 22:16:04 +02:00
|
|
|
ret = -EFSCORRUPTED;
|
2009-04-24 19:43:20 +02:00
|
|
|
goto bad_inode;
|
2012-12-10 20:05:51 +01:00
|
|
|
} else if (!ext4_has_inline_data(inode)) {
|
|
|
|
if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) {
|
|
|
|
if ((S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
|
|
|
|
(S_ISLNK(inode->i_mode) &&
|
|
|
|
!ext4_inode_is_fast_symlink(inode))))
|
|
|
|
/* Validate extent which is part of inode */
|
|
|
|
ret = ext4_ext_check_inode(inode);
|
|
|
|
} else if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
|
|
|
|
(S_ISLNK(inode->i_mode) &&
|
|
|
|
!ext4_inode_is_fast_symlink(inode))) {
|
|
|
|
/* Validate block references which are part of inode */
|
|
|
|
ret = ext4_ind_check_inode(inode);
|
|
|
|
}
|
2009-03-31 14:36:10 +02:00
|
|
|
}
|
2009-11-14 14:19:05 +01:00
|
|
|
if (ret)
|
2009-06-14 23:45:34 +02:00
|
|
|
goto bad_inode;
|
2009-03-27 21:39:58 +01:00
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
if (S_ISREG(inode->i_mode)) {
|
2006-10-11 10:20:53 +02:00
|
|
|
inode->i_op = &ext4_file_inode_operations;
|
2015-04-16 01:15:17 +02:00
|
|
|
inode->i_fop = &ext4_file_operations;
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_set_aops(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
} else if (S_ISDIR(inode->i_mode)) {
|
2006-10-11 10:20:53 +02:00
|
|
|
inode->i_op = &ext4_dir_inode_operations;
|
|
|
|
inode->i_fop = &ext4_dir_operations;
|
2006-10-11 10:20:50 +02:00
|
|
|
} else if (S_ISLNK(inode->i_mode)) {
|
2015-04-27 23:51:30 +02:00
|
|
|
if (ext4_encrypted_inode(inode)) {
|
|
|
|
inode->i_op = &ext4_encrypted_symlink_inode_operations;
|
|
|
|
ext4_set_aops(inode);
|
|
|
|
} else if (ext4_inode_is_fast_symlink(inode)) {
|
2015-05-02 16:13:58 +02:00
|
|
|
inode->i_link = (char *)ei->i_data;
|
2006-10-11 10:20:53 +02:00
|
|
|
inode->i_op = &ext4_fast_symlink_inode_operations;
|
2008-12-19 21:47:15 +01:00
|
|
|
nd_terminate_link(ei->i_data, inode->i_size,
|
|
|
|
sizeof(ei->i_data) - 1);
|
|
|
|
} else {
|
2006-10-11 10:20:53 +02:00
|
|
|
inode->i_op = &ext4_symlink_inode_operations;
|
|
|
|
ext4_set_aops(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2015-11-17 07:07:57 +01:00
|
|
|
inode_nohighmem(inode);
|
2009-03-26 05:06:19 +01:00
|
|
|
} else if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode) ||
|
|
|
|
S_ISFIFO(inode->i_mode) || S_ISSOCK(inode->i_mode)) {
|
2006-10-11 10:20:53 +02:00
|
|
|
inode->i_op = &ext4_special_inode_operations;
|
2006-10-11 10:20:50 +02:00
|
|
|
if (raw_inode->i_block[0])
|
|
|
|
init_special_inode(inode, inode->i_mode,
|
|
|
|
old_decode_dev(le32_to_cpu(raw_inode->i_block[0])));
|
|
|
|
else
|
|
|
|
init_special_inode(inode, inode->i_mode,
|
|
|
|
new_decode_dev(le32_to_cpu(raw_inode->i_block[1])));
|
2013-04-08 18:54:05 +02:00
|
|
|
} else if (ino == EXT4_BOOT_LOADER_INO) {
|
|
|
|
make_bad_inode(inode);
|
2009-03-26 05:06:19 +01:00
|
|
|
} else {
|
2015-10-17 22:16:04 +02:00
|
|
|
ret = -EFSCORRUPTED;
|
2010-05-17 03:00:00 +02:00
|
|
|
EXT4_ERROR_INODE(inode, "bogus i_mode (%o)", inode->i_mode);
|
2009-03-26 05:06:19 +01:00
|
|
|
goto bad_inode;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
2008-09-09 04:25:24 +02:00
|
|
|
brelse(iloc.bh);
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_set_inode_flags(inode);
|
2008-02-07 09:15:37 +01:00
|
|
|
unlock_new_inode(inode);
|
|
|
|
return inode;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
bad_inode:
|
2009-11-14 14:19:05 +01:00
|
|
|
brelse(iloc.bh);
|
2008-02-07 09:15:37 +01:00
|
|
|
iget_failed(inode);
|
|
|
|
return ERR_PTR(ret);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
ext4: add ext4_iget_normal() which is to be used for dir tree lookups
If there is a corrupted file system which has directory entries that
point at reserved, metadata inodes, prohibit them from being used by
treating them the same way we treat Boot Loader inodes --- that is,
mark them to be bad inodes. This prohibits them from being opened,
deleted, or modified via chmod, chown, utimes, etc.
In particular, this prevents a corrupted file system which has a
directory entry which points at the journal inode from being deleted
and its blocks released, after which point Much Hilarity Ensues.
Reported-by: Sami Liedes <sami.liedes@iki.fi>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2014-10-06 04:56:00 +02:00
|
|
|
struct inode *ext4_iget_normal(struct super_block *sb, unsigned long ino)
|
|
|
|
{
|
|
|
|
if (ino < EXT4_FIRST_INO(sb) && ino != EXT4_ROOT_INO)
|
2015-10-17 22:16:04 +02:00
|
|
|
return ERR_PTR(-EFSCORRUPTED);
|
ext4: add ext4_iget_normal() which is to be used for dir tree lookups
If there is a corrupted file system which has directory entries that
point at reserved, metadata inodes, prohibit them from being used by
treating them the same way we treat Boot Loader inodes --- that is,
mark them to be bad inodes. This prohibits them from being opened,
deleted, or modified via chmod, chown, utimes, etc.
In particular, this prevents a corrupted file system which has a
directory entry which points at the journal inode from being deleted
and its blocks released, after which point Much Hilarity Ensues.
Reported-by: Sami Liedes <sami.liedes@iki.fi>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
2014-10-06 04:56:00 +02:00
|
|
|
return ext4_iget(sb, ino);
|
|
|
|
}
|
|
|
|
|
2008-01-29 05:58:26 +01:00
|
|
|
static int ext4_inode_blocks_set(handle_t *handle,
|
|
|
|
struct ext4_inode *raw_inode,
|
|
|
|
struct ext4_inode_info *ei)
|
|
|
|
{
|
|
|
|
struct inode *inode = &(ei->vfs_inode);
|
|
|
|
u64 i_blocks = inode->i_blocks;
|
|
|
|
struct super_block *sb = inode->i_sb;
|
|
|
|
|
|
|
|
if (i_blocks <= ~0U) {
|
|
|
|
/*
|
2012-09-01 19:31:09 +02:00
|
|
|
* i_blocks can be represented in a 32 bit variable
|
2008-01-29 05:58:26 +01:00
|
|
|
* as multiple of 512 bytes
|
|
|
|
*/
|
2008-01-29 05:58:27 +01:00
|
|
|
raw_inode->i_blocks_lo = cpu_to_le32(i_blocks);
|
2008-01-29 05:58:26 +01:00
|
|
|
raw_inode->i_blocks_high = 0;
|
2010-06-05 17:51:27 +02:00
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_HUGE_FILE);
|
2008-10-17 04:50:48 +02:00
|
|
|
return 0;
|
|
|
|
}
|
2015-10-17 22:18:43 +02:00
|
|
|
if (!ext4_has_feature_huge_file(sb))
|
2008-10-17 04:50:48 +02:00
|
|
|
return -EFBIG;
|
|
|
|
|
|
|
|
if (i_blocks <= 0xffffffffffffULL) {
|
2008-01-29 05:58:26 +01:00
|
|
|
/*
|
|
|
|
* i_blocks can be represented in a 48 bit variable
|
|
|
|
* as multiple of 512 bytes
|
|
|
|
*/
|
2008-01-29 05:58:27 +01:00
|
|
|
raw_inode->i_blocks_lo = cpu_to_le32(i_blocks);
|
2008-01-29 05:58:26 +01:00
|
|
|
raw_inode->i_blocks_high = cpu_to_le16(i_blocks >> 32);
|
2010-06-05 17:51:27 +02:00
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_HUGE_FILE);
|
2008-01-29 05:58:26 +01:00
|
|
|
} else {
|
2010-06-05 17:51:27 +02:00
|
|
|
ext4_set_inode_flag(inode, EXT4_INODE_HUGE_FILE);
|
2008-01-29 05:58:27 +01:00
|
|
|
/* i_block is stored in file system block size */
|
|
|
|
i_blocks = i_blocks >> (inode->i_blkbits - 9);
|
|
|
|
raw_inode->i_blocks_lo = cpu_to_le32(i_blocks);
|
|
|
|
raw_inode->i_blocks_high = cpu_to_le16(i_blocks >> 32);
|
2008-01-29 05:58:26 +01:00
|
|
|
}
|
2008-10-17 04:50:48 +02:00
|
|
|
return 0;
|
2008-01-29 05:58:26 +01:00
|
|
|
}
|
|
|
|
|
2015-02-02 06:37:02 +01:00
|
|
|
struct other_inode {
|
|
|
|
unsigned long orig_ino;
|
|
|
|
struct ext4_inode *raw_inode;
|
|
|
|
};
|
|
|
|
|
|
|
|
static int other_inode_match(struct inode * inode, unsigned long ino,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
struct other_inode *oi = (struct other_inode *) data;
|
|
|
|
|
|
|
|
if ((inode->i_ino != ino) ||
|
|
|
|
(inode->i_state & (I_FREEING | I_WILL_FREE | I_NEW |
|
|
|
|
I_DIRTY_SYNC | I_DIRTY_DATASYNC)) ||
|
|
|
|
((inode->i_state & I_DIRTY_TIME) == 0))
|
|
|
|
return 0;
|
|
|
|
spin_lock(&inode->i_lock);
|
|
|
|
if (((inode->i_state & (I_FREEING | I_WILL_FREE | I_NEW |
|
|
|
|
I_DIRTY_SYNC | I_DIRTY_DATASYNC)) == 0) &&
|
|
|
|
(inode->i_state & I_DIRTY_TIME)) {
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
|
|
|
|
|
|
|
inode->i_state &= ~(I_DIRTY_TIME | I_DIRTY_TIME_EXPIRED);
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
|
|
|
|
spin_lock(&ei->i_raw_lock);
|
|
|
|
EXT4_INODE_SET_XTIME(i_ctime, inode, oi->raw_inode);
|
|
|
|
EXT4_INODE_SET_XTIME(i_mtime, inode, oi->raw_inode);
|
|
|
|
EXT4_INODE_SET_XTIME(i_atime, inode, oi->raw_inode);
|
|
|
|
ext4_inode_csum_set(inode, oi->raw_inode, ei);
|
|
|
|
spin_unlock(&ei->i_raw_lock);
|
|
|
|
trace_ext4_other_inode_update_time(inode, oi->orig_ino);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
spin_unlock(&inode->i_lock);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Opportunistically update the other time fields for other inodes in
|
|
|
|
* the same inode table block.
|
|
|
|
*/
|
|
|
|
static void ext4_update_other_inodes_time(struct super_block *sb,
|
|
|
|
unsigned long orig_ino, char *buf)
|
|
|
|
{
|
|
|
|
struct other_inode oi;
|
|
|
|
unsigned long ino;
|
|
|
|
int i, inodes_per_block = EXT4_SB(sb)->s_inodes_per_block;
|
|
|
|
int inode_size = EXT4_INODE_SIZE(sb);
|
|
|
|
|
|
|
|
oi.orig_ino = orig_ino;
|
2015-07-02 05:37:46 +02:00
|
|
|
/*
|
|
|
|
* Calculate the first inode in the inode table block. Inode
|
|
|
|
* numbers are one-based. That is, the first inode in a block
|
|
|
|
* (assuming 4k blocks and 256 byte inodes) is (n*16 + 1).
|
|
|
|
*/
|
|
|
|
ino = ((orig_ino - 1) & ~(inodes_per_block - 1)) + 1;
|
2015-02-02 06:37:02 +01:00
|
|
|
for (i = 0; i < inodes_per_block; i++, ino++, buf += inode_size) {
|
|
|
|
if (ino == orig_ino)
|
|
|
|
continue;
|
|
|
|
oi.raw_inode = (struct ext4_inode *) buf;
|
|
|
|
(void) find_inode_nowait(sb, ino, other_inode_match, &oi);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* Post the struct inode info into an on-disk inode location in the
|
|
|
|
* buffer-cache. This gobbles the caller's reference to the
|
|
|
|
* buffer_head in the inode location struct.
|
|
|
|
*
|
|
|
|
* The caller must have write access to iloc->bh.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
static int ext4_do_update_inode(handle_t *handle,
|
2006-10-11 10:20:50 +02:00
|
|
|
struct inode *inode,
|
2009-09-29 16:07:47 +02:00
|
|
|
struct ext4_iloc *iloc)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
struct ext4_inode *raw_inode = ext4_raw_inode(iloc);
|
|
|
|
struct ext4_inode_info *ei = EXT4_I(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
struct buffer_head *bh = iloc->bh;
|
2014-04-21 20:37:55 +02:00
|
|
|
struct super_block *sb = inode->i_sb;
|
2006-10-11 10:20:50 +02:00
|
|
|
int err = 0, rc, block;
|
2014-04-21 20:37:55 +02:00
|
|
|
int need_datasync = 0, set_large_file = 0;
|
2012-02-08 00:41:49 +01:00
|
|
|
uid_t i_uid;
|
|
|
|
gid_t i_gid;
|
2016-01-08 22:01:21 +01:00
|
|
|
projid_t i_projid;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2014-04-21 20:37:55 +02:00
|
|
|
spin_lock(&ei->i_raw_lock);
|
|
|
|
|
|
|
|
/* For fields not tracked in the in-memory inode,
|
2006-10-11 10:20:50 +02:00
|
|
|
* initialise them to zero for new inodes. */
|
2010-01-24 20:34:07 +01:00
|
|
|
if (ext4_test_inode_state(inode, EXT4_STATE_NEW))
|
2006-10-11 10:20:53 +02:00
|
|
|
memset(raw_inode, 0, EXT4_SB(inode->i_sb)->s_inode_size);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2007-07-18 15:24:20 +02:00
|
|
|
ext4_get_inode_flags(ei);
|
2006-10-11 10:20:50 +02:00
|
|
|
raw_inode->i_mode = cpu_to_le16(inode->i_mode);
|
2012-02-08 00:41:49 +01:00
|
|
|
i_uid = i_uid_read(inode);
|
|
|
|
i_gid = i_gid_read(inode);
|
2016-01-08 22:01:21 +01:00
|
|
|
i_projid = from_kprojid(&init_user_ns, ei->i_projid);
|
2008-09-09 04:25:24 +02:00
|
|
|
if (!(test_opt(inode->i_sb, NO_UID32))) {
|
2012-02-08 00:41:49 +01:00
|
|
|
raw_inode->i_uid_low = cpu_to_le16(low_16_bits(i_uid));
|
|
|
|
raw_inode->i_gid_low = cpu_to_le16(low_16_bits(i_gid));
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* Fix up interoperability with old kernels. Otherwise, old inodes get
|
|
|
|
* re-used with the upper 16 bits of the uid/gid intact
|
|
|
|
*/
|
2008-09-09 04:25:24 +02:00
|
|
|
if (!ei->i_dtime) {
|
2006-10-11 10:20:50 +02:00
|
|
|
raw_inode->i_uid_high =
|
2012-02-08 00:41:49 +01:00
|
|
|
cpu_to_le16(high_16_bits(i_uid));
|
2006-10-11 10:20:50 +02:00
|
|
|
raw_inode->i_gid_high =
|
2012-02-08 00:41:49 +01:00
|
|
|
cpu_to_le16(high_16_bits(i_gid));
|
2006-10-11 10:20:50 +02:00
|
|
|
} else {
|
|
|
|
raw_inode->i_uid_high = 0;
|
|
|
|
raw_inode->i_gid_high = 0;
|
|
|
|
}
|
|
|
|
} else {
|
2012-02-08 00:41:49 +01:00
|
|
|
raw_inode->i_uid_low = cpu_to_le16(fs_high2lowuid(i_uid));
|
|
|
|
raw_inode->i_gid_low = cpu_to_le16(fs_high2lowgid(i_gid));
|
2006-10-11 10:20:50 +02:00
|
|
|
raw_inode->i_uid_high = 0;
|
|
|
|
raw_inode->i_gid_high = 0;
|
|
|
|
}
|
|
|
|
raw_inode->i_links_count = cpu_to_le16(inode->i_nlink);
|
2007-07-18 15:15:20 +02:00
|
|
|
|
|
|
|
EXT4_INODE_SET_XTIME(i_ctime, inode, raw_inode);
|
|
|
|
EXT4_INODE_SET_XTIME(i_mtime, inode, raw_inode);
|
|
|
|
EXT4_INODE_SET_XTIME(i_atime, inode, raw_inode);
|
|
|
|
EXT4_EINODE_SET_XTIME(i_crtime, ei, raw_inode);
|
|
|
|
|
2014-10-02 04:11:06 +02:00
|
|
|
err = ext4_inode_blocks_set(handle, raw_inode, ei);
|
|
|
|
if (err) {
|
2014-04-21 20:37:55 +02:00
|
|
|
spin_unlock(&ei->i_raw_lock);
|
2008-01-29 05:58:26 +01:00
|
|
|
goto out_brelse;
|
2014-04-21 20:37:55 +02:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
raw_inode->i_dtime = cpu_to_le32(ei->i_dtime);
|
2011-01-10 18:18:25 +01:00
|
|
|
raw_inode->i_flags = cpu_to_le32(ei->i_flags & 0xFFFFFFFF);
|
2014-03-24 19:09:06 +01:00
|
|
|
if (likely(!test_opt2(inode->i_sb, HURD_COMPAT)))
|
2006-10-11 10:21:09 +02:00
|
|
|
raw_inode->i_file_acl_high =
|
|
|
|
cpu_to_le16(ei->i_file_acl >> 32);
|
2008-01-29 05:58:27 +01:00
|
|
|
raw_inode->i_file_acl_lo = cpu_to_le32(ei->i_file_acl);
|
2012-09-27 03:52:20 +02:00
|
|
|
if (ei->i_disksize != ext4_isize(raw_inode)) {
|
|
|
|
ext4_isize_set(raw_inode, ei->i_disksize);
|
|
|
|
need_datasync = 1;
|
|
|
|
}
|
2008-01-29 05:58:27 +01:00
|
|
|
if (ei->i_disksize > 0x7fffffffULL) {
|
2015-10-17 22:18:43 +02:00
|
|
|
if (!ext4_has_feature_large_file(sb) ||
|
2008-01-29 05:58:27 +01:00
|
|
|
EXT4_SB(sb)->s_es->s_rev_level ==
|
2014-04-21 20:37:55 +02:00
|
|
|
cpu_to_le32(EXT4_GOOD_OLD_REV))
|
|
|
|
set_large_file = 1;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
raw_inode->i_generation = cpu_to_le32(inode->i_generation);
|
|
|
|
if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {
|
|
|
|
if (old_valid_dev(inode->i_rdev)) {
|
|
|
|
raw_inode->i_block[0] =
|
|
|
|
cpu_to_le32(old_encode_dev(inode->i_rdev));
|
|
|
|
raw_inode->i_block[1] = 0;
|
|
|
|
} else {
|
|
|
|
raw_inode->i_block[0] = 0;
|
|
|
|
raw_inode->i_block[1] =
|
|
|
|
cpu_to_le32(new_encode_dev(inode->i_rdev));
|
|
|
|
raw_inode->i_block[2] = 0;
|
|
|
|
}
|
2012-12-10 20:05:51 +01:00
|
|
|
} else if (!ext4_has_inline_data(inode)) {
|
2009-06-14 23:45:34 +02:00
|
|
|
for (block = 0; block < EXT4_N_BLOCKS; block++)
|
|
|
|
raw_inode->i_block[block] = ei->i_data[block];
|
2012-12-10 20:05:51 +01:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2014-03-24 19:09:06 +01:00
|
|
|
if (likely(!test_opt2(inode->i_sb, HURD_COMPAT))) {
|
2014-03-20 05:32:57 +01:00
|
|
|
raw_inode->i_disk_version = cpu_to_le32(inode->i_version);
|
|
|
|
if (ei->i_extra_isize) {
|
|
|
|
if (EXT4_FITS_IN_INODE(raw_inode, ei, i_version_hi))
|
|
|
|
raw_inode->i_version_hi =
|
|
|
|
cpu_to_le32(inode->i_version >> 32);
|
|
|
|
raw_inode->i_extra_isize =
|
|
|
|
cpu_to_le16(ei->i_extra_isize);
|
|
|
|
}
|
2008-01-29 05:58:27 +01:00
|
|
|
}
|
2016-01-08 22:01:21 +01:00
|
|
|
|
|
|
|
BUG_ON(!EXT4_HAS_RO_COMPAT_FEATURE(inode->i_sb,
|
|
|
|
EXT4_FEATURE_RO_COMPAT_PROJECT) &&
|
|
|
|
i_projid != EXT4_DEF_PROJID);
|
|
|
|
|
|
|
|
if (EXT4_INODE_SIZE(inode->i_sb) > EXT4_GOOD_OLD_INODE_SIZE &&
|
|
|
|
EXT4_FITS_IN_INODE(raw_inode, ei, i_projid))
|
|
|
|
raw_inode->i_projid = cpu_to_le32(i_projid);
|
|
|
|
|
2012-04-30 00:31:10 +02:00
|
|
|
ext4_inode_csum_set(inode, raw_inode, ei);
|
2014-04-21 20:37:55 +02:00
|
|
|
spin_unlock(&ei->i_raw_lock);
|
2015-02-02 06:37:02 +01:00
|
|
|
if (inode->i_sb->s_flags & MS_LAZYTIME)
|
|
|
|
ext4_update_other_inodes_time(inode->i_sb, inode->i_ino,
|
|
|
|
bh->b_data);
|
2014-04-21 20:37:55 +02:00
|
|
|
|
2009-09-29 16:07:47 +02:00
|
|
|
BUFFER_TRACE(bh, "call ext4_handle_dirty_metadata");
|
2010-02-16 21:06:29 +01:00
|
|
|
rc = ext4_handle_dirty_metadata(handle, NULL, bh);
|
2009-09-29 16:07:47 +02:00
|
|
|
if (!err)
|
|
|
|
err = rc;
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_clear_inode_state(inode, EXT4_STATE_NEW);
|
2014-04-21 20:37:55 +02:00
|
|
|
if (set_large_file) {
|
2014-05-13 04:06:43 +02:00
|
|
|
BUFFER_TRACE(EXT4_SB(sb)->s_sbh, "get write access");
|
2014-04-21 20:37:55 +02:00
|
|
|
err = ext4_journal_get_write_access(handle, EXT4_SB(sb)->s_sbh);
|
|
|
|
if (err)
|
|
|
|
goto out_brelse;
|
|
|
|
ext4_update_dynamic_rev(sb);
|
2015-10-17 22:18:43 +02:00
|
|
|
ext4_set_feature_large_file(sb);
|
2014-04-21 20:37:55 +02:00
|
|
|
ext4_handle_sync(handle);
|
|
|
|
err = ext4_handle_dirty_super(handle, sb);
|
|
|
|
}
|
2012-09-27 03:52:20 +02:00
|
|
|
ext4_update_inode_fsync_trans(handle, inode, need_datasync);
|
2006-10-11 10:20:50 +02:00
|
|
|
out_brelse:
|
2008-09-09 04:25:24 +02:00
|
|
|
brelse(bh);
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 10:20:50 +02:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_write_inode()
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
|
|
|
* We are called from a few places:
|
|
|
|
*
|
2014-04-08 17:38:28 +02:00
|
|
|
* - Within generic_file_aio_write() -> generic_write_sync() for O_SYNC files.
|
2006-10-11 10:20:50 +02:00
|
|
|
* Here, there will be no transaction running. We wait for any running
|
2012-09-01 19:31:09 +02:00
|
|
|
* transaction to commit.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
2014-04-08 17:38:28 +02:00
|
|
|
* - Within flush work (sys_sync(), kupdate and such).
|
|
|
|
* We wait on commit, if told to.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
2014-04-08 17:38:28 +02:00
|
|
|
* - Within iput_final() -> write_inode_now()
|
|
|
|
* We wait on commit, if told to.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
|
|
|
* In all cases it is actually safe for us to return without doing anything,
|
|
|
|
* because the inode has been copied into a raw inode buffer in
|
2014-04-08 17:38:28 +02:00
|
|
|
* ext4_mark_inode_dirty(). This is a correctness thing for WB_SYNC_ALL
|
|
|
|
* writeback.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
|
|
|
* Note that we are absolutely dependent upon all inode dirtiers doing the
|
|
|
|
* right thing: they *must* call mark_inode_dirty() after dirtying info in
|
|
|
|
* which we are interested.
|
|
|
|
*
|
|
|
|
* It would be a bug for them to not do this. The code:
|
|
|
|
*
|
|
|
|
* mark_inode_dirty(inode)
|
|
|
|
* stuff();
|
|
|
|
* inode->i_size = expr;
|
|
|
|
*
|
2014-04-08 17:38:28 +02:00
|
|
|
* is in error because write_inode() could occur while `stuff()' is running,
|
|
|
|
* and the new i_size will be lost. Plus the inode will no longer be on the
|
|
|
|
* superblock's dirty inode list.
|
2006-10-11 10:20:50 +02:00
|
|
|
*/
|
2010-03-05 09:21:37 +01:00
|
|
|
int ext4_write_inode(struct inode *inode, struct writeback_control *wbc)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2009-09-10 04:33:47 +02:00
|
|
|
int err;
|
|
|
|
|
2014-04-08 17:38:28 +02:00
|
|
|
if (WARN_ON_ONCE(current->flags & PF_MEMALLOC))
|
2006-10-11 10:20:50 +02:00
|
|
|
return 0;
|
|
|
|
|
2009-09-10 04:33:47 +02:00
|
|
|
if (EXT4_SB(inode->i_sb)->s_journal) {
|
|
|
|
if (ext4_journal_current_handle()) {
|
|
|
|
jbd_debug(1, "called recursively, non-PF_MEMALLOC!\n");
|
|
|
|
dump_stack();
|
|
|
|
return -EIO;
|
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2014-03-04 16:50:50 +01:00
|
|
|
/*
|
|
|
|
* No need to force transaction in WB_SYNC_NONE mode. Also
|
|
|
|
* ext4_sync_fs() will force the commit after everything is
|
|
|
|
* written.
|
|
|
|
*/
|
|
|
|
if (wbc->sync_mode != WB_SYNC_ALL || wbc->for_sync)
|
2009-09-10 04:33:47 +02:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
err = ext4_force_commit(inode->i_sb);
|
|
|
|
} else {
|
|
|
|
struct ext4_iloc iloc;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2010-04-03 22:45:06 +02:00
|
|
|
err = __ext4_get_inode_loc(inode, &iloc, 0);
|
2009-09-10 04:33:47 +02:00
|
|
|
if (err)
|
|
|
|
return err;
|
2014-03-04 16:50:50 +01:00
|
|
|
/*
|
|
|
|
* sync(2) will flush the whole buffer cache. No need to do
|
|
|
|
* it here separately for each inode.
|
|
|
|
*/
|
|
|
|
if (wbc->sync_mode == WB_SYNC_ALL && !wbc->for_sync)
|
2009-09-29 16:07:47 +02:00
|
|
|
sync_dirty_buffer(iloc.bh);
|
|
|
|
if (buffer_req(iloc.bh) && !buffer_uptodate(iloc.bh)) {
|
2010-07-27 17:56:40 +02:00
|
|
|
EXT4_ERROR_INODE_BLOCK(inode, iloc.bh->b_blocknr,
|
|
|
|
"IO error syncing inode");
|
2009-09-29 16:07:47 +02:00
|
|
|
err = -EIO;
|
|
|
|
}
|
2010-04-03 23:44:16 +02:00
|
|
|
brelse(iloc.bh);
|
2009-09-10 04:33:47 +02:00
|
|
|
}
|
|
|
|
return err;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2012-12-25 19:29:52 +01:00
|
|
|
/*
|
|
|
|
* In data=journal mode ext4_journalled_invalidatepage() may fail to invalidate
|
|
|
|
* buffers that are attached to a page stradding i_size and are undergoing
|
|
|
|
* commit. In that case we have to wait for commit to finish and try again.
|
|
|
|
*/
|
|
|
|
static void ext4_wait_for_tail_page_commit(struct inode *inode)
|
|
|
|
{
|
|
|
|
struct page *page;
|
|
|
|
unsigned offset;
|
|
|
|
journal_t *journal = EXT4_SB(inode->i_sb)->s_journal;
|
|
|
|
tid_t commit_tid = 0;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
offset = inode->i_size & (PAGE_CACHE_SIZE - 1);
|
|
|
|
/*
|
|
|
|
* All buffers in the last page remain valid? Then there's nothing to
|
|
|
|
* do. We do the check mainly to optimize the common PAGE_CACHE_SIZE ==
|
|
|
|
* blocksize case
|
|
|
|
*/
|
|
|
|
if (offset > PAGE_CACHE_SIZE - (1 << inode->i_blkbits))
|
|
|
|
return;
|
|
|
|
while (1) {
|
|
|
|
page = find_lock_page(inode->i_mapping,
|
|
|
|
inode->i_size >> PAGE_CACHE_SHIFT);
|
|
|
|
if (!page)
|
|
|
|
return;
|
2013-05-22 05:25:01 +02:00
|
|
|
ret = __ext4_journalled_invalidatepage(page, offset,
|
|
|
|
PAGE_CACHE_SIZE - offset);
|
2012-12-25 19:29:52 +01:00
|
|
|
unlock_page(page);
|
|
|
|
page_cache_release(page);
|
|
|
|
if (ret != -EBUSY)
|
|
|
|
return;
|
|
|
|
commit_tid = 0;
|
|
|
|
read_lock(&journal->j_state_lock);
|
|
|
|
if (journal->j_committing_transaction)
|
|
|
|
commit_tid = journal->j_committing_transaction->t_tid;
|
|
|
|
read_unlock(&journal->j_state_lock);
|
|
|
|
if (commit_tid)
|
|
|
|
jbd2_log_wait_commit(journal, commit_tid);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_setattr()
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
|
|
|
* Called from notify_change.
|
|
|
|
*
|
|
|
|
* We want to trap VFS attempts to truncate the file as soon as
|
|
|
|
* possible. In particular, we want to make sure that when the VFS
|
|
|
|
* shrinks i_size, we put the inode on the orphan list and modify
|
|
|
|
* i_disksize immediately, so that during the subsequent flushing of
|
|
|
|
* dirty pages and freeing of disk blocks, we can guarantee that any
|
|
|
|
* commit will leave the blocks being flushed in an unused state on
|
|
|
|
* disk. (On recovery, the inode will get truncated and the blocks will
|
|
|
|
* be freed, so we have a strong guarantee that no future commit will
|
|
|
|
* leave these blocks visible to the user.)
|
|
|
|
*
|
2008-07-12 01:27:31 +02:00
|
|
|
* Another thing we have to assure is that if we are in ordered mode
|
|
|
|
* and inode is still attached to the committing transaction, we must
|
|
|
|
* we start writeout of all the dirty pages which are being truncated.
|
|
|
|
* This way we are sure that all the data written in the previous
|
|
|
|
* transaction are already on disk (truncate waits for pages under
|
|
|
|
* writeback).
|
|
|
|
*
|
|
|
|
* Called with inode->i_mutex down.
|
2006-10-11 10:20:50 +02:00
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
int ext4_setattr(struct dentry *dentry, struct iattr *attr)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2015-03-17 23:25:59 +01:00
|
|
|
struct inode *inode = d_inode(dentry);
|
2006-10-11 10:20:50 +02:00
|
|
|
int error, rc = 0;
|
2010-10-28 04:08:46 +02:00
|
|
|
int orphan = 0;
|
2006-10-11 10:20:50 +02:00
|
|
|
const unsigned int ia_valid = attr->ia_valid;
|
|
|
|
|
|
|
|
error = inode_change_ok(inode, attr);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
|
2015-06-29 16:22:54 +02:00
|
|
|
if (is_quota_modification(inode, attr)) {
|
|
|
|
error = dquot_initialize(inode);
|
|
|
|
if (error)
|
|
|
|
return error;
|
|
|
|
}
|
2012-02-08 00:41:49 +01:00
|
|
|
if ((ia_valid & ATTR_UID && !uid_eq(attr->ia_uid, inode->i_uid)) ||
|
|
|
|
(ia_valid & ATTR_GID && !gid_eq(attr->ia_gid, inode->i_gid))) {
|
2006-10-11 10:20:50 +02:00
|
|
|
handle_t *handle;
|
|
|
|
|
|
|
|
/* (user+group)*(old+new) structure, inode write (sb,
|
|
|
|
* inode block, ? - but truncate inode update has it) */
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_QUOTA,
|
|
|
|
(EXT4_MAXQUOTAS_INIT_BLOCKS(inode->i_sb) +
|
|
|
|
EXT4_MAXQUOTAS_DEL_BLOCKS(inode->i_sb)) + 3);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
error = PTR_ERR(handle);
|
|
|
|
goto err_out;
|
|
|
|
}
|
2010-03-03 15:05:03 +01:00
|
|
|
error = dquot_transfer(inode, attr);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (error) {
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
return error;
|
|
|
|
}
|
|
|
|
/* Update corresponding info in inode so that everything is in
|
|
|
|
* one transaction */
|
|
|
|
if (attr->ia_valid & ATTR_UID)
|
|
|
|
inode->i_uid = attr->ia_uid;
|
|
|
|
if (attr->ia_valid & ATTR_GID)
|
|
|
|
inode->i_gid = attr->ia_gid;
|
2006-10-11 10:20:53 +02:00
|
|
|
error = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
|
2015-06-22 06:31:26 +02:00
|
|
|
if (attr->ia_valid & ATTR_SIZE) {
|
2013-08-17 16:07:17 +02:00
|
|
|
handle_t *handle;
|
2015-06-22 06:31:26 +02:00
|
|
|
loff_t oldsize = inode->i_size;
|
|
|
|
int shrink = (attr->ia_size <= inode->i_size);
|
2011-06-24 20:29:45 +02:00
|
|
|
|
2010-05-17 04:00:00 +02:00
|
|
|
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))) {
|
2008-01-29 05:58:27 +01:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
|
2010-07-27 17:56:06 +02:00
|
|
|
if (attr->ia_size > sbi->s_bitmap_maxbytes)
|
|
|
|
return -EFBIG;
|
2008-01-29 05:58:27 +01:00
|
|
|
}
|
2015-06-22 06:31:26 +02:00
|
|
|
if (!S_ISREG(inode->i_mode))
|
|
|
|
return -EINVAL;
|
2013-11-19 16:17:07 +01:00
|
|
|
|
|
|
|
if (IS_I_VERSION(inode) && attr->ia_size != inode->i_size)
|
|
|
|
inode_inc_iversion(inode);
|
|
|
|
|
2015-06-22 06:31:26 +02:00
|
|
|
if (ext4_should_order_data(inode) &&
|
2013-08-17 16:07:17 +02:00
|
|
|
(attr->ia_size < inode->i_size)) {
|
2015-06-22 06:31:26 +02:00
|
|
|
error = ext4_begin_ordered_truncate(inode,
|
2008-07-12 01:27:31 +02:00
|
|
|
attr->ia_size);
|
2015-06-22 06:31:26 +02:00
|
|
|
if (error)
|
|
|
|
goto err_out;
|
|
|
|
}
|
|
|
|
if (attr->ia_size != inode->i_size) {
|
2013-08-17 16:07:17 +02:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 3);
|
|
|
|
if (IS_ERR(handle)) {
|
|
|
|
error = PTR_ERR(handle);
|
|
|
|
goto err_out;
|
|
|
|
}
|
2015-06-22 06:31:26 +02:00
|
|
|
if (ext4_handle_valid(handle) && shrink) {
|
2013-08-17 16:07:17 +02:00
|
|
|
error = ext4_orphan_add(handle, inode);
|
|
|
|
orphan = 1;
|
|
|
|
}
|
2015-07-28 21:08:41 +02:00
|
|
|
/*
|
|
|
|
* Update c/mtime on truncate up, ext4_truncate() will
|
|
|
|
* update c/mtime in shrink case below
|
|
|
|
*/
|
|
|
|
if (!shrink) {
|
|
|
|
inode->i_mtime = ext4_current_time(inode);
|
|
|
|
inode->i_ctime = inode->i_mtime;
|
|
|
|
}
|
2013-08-17 16:09:31 +02:00
|
|
|
down_write(&EXT4_I(inode)->i_data_sem);
|
2013-08-17 16:07:17 +02:00
|
|
|
EXT4_I(inode)->i_disksize = attr->ia_size;
|
|
|
|
rc = ext4_mark_inode_dirty(handle, inode);
|
|
|
|
if (!error)
|
|
|
|
error = rc;
|
2013-08-17 16:09:31 +02:00
|
|
|
/*
|
|
|
|
* We have to update i_size under i_data_sem together
|
|
|
|
* with i_disksize to avoid races with writeback code
|
|
|
|
* running ext4_wb_update_i_disksize().
|
|
|
|
*/
|
|
|
|
if (!error)
|
|
|
|
i_size_write(inode, attr->ia_size);
|
|
|
|
up_write(&EXT4_I(inode)->i_data_sem);
|
2013-08-17 16:07:17 +02:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
if (error) {
|
2015-06-22 06:31:26 +02:00
|
|
|
if (orphan)
|
|
|
|
ext4_orphan_del(NULL, inode);
|
2008-07-12 01:27:31 +02:00
|
|
|
goto err_out;
|
|
|
|
}
|
2014-10-02 03:49:46 +02:00
|
|
|
}
|
2015-06-22 06:31:26 +02:00
|
|
|
if (!shrink)
|
|
|
|
pagecache_isize_extended(inode, oldsize, inode->i_size);
|
2012-12-25 19:29:52 +01:00
|
|
|
|
2013-08-17 16:07:17 +02:00
|
|
|
/*
|
|
|
|
* Blocks are going to be removed from the inode. Wait
|
|
|
|
* for dio in flight. Temporarily disable
|
|
|
|
* dioread_nolock to prevent livelock.
|
|
|
|
*/
|
|
|
|
if (orphan) {
|
|
|
|
if (!ext4_should_journal_data(inode)) {
|
|
|
|
ext4_inode_block_unlocked_dio(inode);
|
|
|
|
inode_dio_wait(inode);
|
|
|
|
ext4_inode_resume_unlocked_dio(inode);
|
|
|
|
} else
|
|
|
|
ext4_wait_for_tail_page_commit(inode);
|
2012-09-29 06:55:23 +02:00
|
|
|
}
|
2015-12-07 20:28:03 +01:00
|
|
|
down_write(&EXT4_I(inode)->i_mmap_sem);
|
2013-08-17 16:07:17 +02:00
|
|
|
/*
|
|
|
|
* Truncate pagecache after we've waited for commit
|
|
|
|
* in data=journal mode to make pages freeable.
|
|
|
|
*/
|
2015-02-17 00:59:38 +01:00
|
|
|
truncate_pagecache(inode, inode->i_size);
|
2015-06-22 06:31:26 +02:00
|
|
|
if (shrink)
|
|
|
|
ext4_truncate(inode);
|
2015-12-07 20:28:03 +01:00
|
|
|
up_write(&EXT4_I(inode)->i_mmap_sem);
|
2011-05-23 21:13:02 +02:00
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2010-06-04 11:30:02 +02:00
|
|
|
if (!rc) {
|
|
|
|
setattr_copy(inode, attr);
|
|
|
|
mark_inode_dirty(inode);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* If the call to ext4_truncate failed to get a transaction handle at
|
|
|
|
* all, we need to clean up the in-core orphan list manually.
|
|
|
|
*/
|
2010-10-28 04:08:46 +02:00
|
|
|
if (orphan && inode->i_nlink)
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_orphan_del(NULL, inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
if (!rc && (ia_valid & ATTR_MODE))
|
2013-12-20 14:16:44 +01:00
|
|
|
rc = posix_acl_chmod(inode, inode->i_mode);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
err_out:
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_std_error(inode->i_sb, error);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!error)
|
|
|
|
error = rc;
|
|
|
|
return error;
|
|
|
|
}
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
int ext4_getattr(struct vfsmount *mnt, struct dentry *dentry,
|
|
|
|
struct kstat *stat)
|
|
|
|
{
|
|
|
|
struct inode *inode;
|
2013-06-01 01:39:56 +02:00
|
|
|
unsigned long long delalloc_blocks;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2015-03-17 23:25:59 +01:00
|
|
|
inode = d_inode(dentry);
|
2008-07-12 01:27:31 +02:00
|
|
|
generic_fillattr(inode, stat);
|
|
|
|
|
2013-11-12 04:38:12 +01:00
|
|
|
/*
|
|
|
|
* If there is inline data in the inode, the inode will normally not
|
|
|
|
* have data blocks allocated (it may have an external xattr block).
|
|
|
|
* Report at least one sector for such files, so tools like tar, rsync,
|
|
|
|
* others doen't incorrectly think the file is completely sparse.
|
|
|
|
*/
|
|
|
|
if (unlikely(ext4_has_inline_data(inode)))
|
|
|
|
stat->blocks += (stat->size + 511) >> 9;
|
|
|
|
|
2008-07-12 01:27:31 +02:00
|
|
|
/*
|
|
|
|
* We can't update i_blocks if the block allocation is delayed
|
|
|
|
* otherwise in the case of system crash before the real block
|
|
|
|
* allocation is done, we will have i_blocks inconsistent with
|
|
|
|
* on-disk file blocks.
|
|
|
|
* We always keep i_blocks updated together with real
|
|
|
|
* allocation. But to not confuse with user, stat
|
|
|
|
* will return the blocks that include the delayed allocation
|
|
|
|
* blocks for this file.
|
|
|
|
*/
|
2012-06-01 04:54:16 +02:00
|
|
|
delalloc_blocks = EXT4_C2B(EXT4_SB(inode->i_sb),
|
2013-11-12 04:38:12 +01:00
|
|
|
EXT4_I(inode)->i_reserved_data_blocks);
|
|
|
|
stat->blocks += delalloc_blocks << (inode->i_sb->s_blocksize_bits - 9);
|
2008-07-12 01:27:31 +02:00
|
|
|
return 0;
|
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2013-06-04 19:01:11 +02:00
|
|
|
static int ext4_index_trans_blocks(struct inode *inode, int lblocks,
|
|
|
|
int pextents)
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
{
|
2010-05-17 04:00:00 +02:00
|
|
|
if (!(ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)))
|
2013-06-04 19:01:11 +02:00
|
|
|
return ext4_ind_trans_blocks(inode, lblocks);
|
|
|
|
return ext4_ext_index_trans_blocks(inode, pextents);
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
}
|
2008-11-06 22:49:36 +01:00
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
* Account for index blocks, block groups bitmaps and block group
|
|
|
|
* descriptor blocks if modify datablocks and index blocks
|
|
|
|
* worse case, the indexs blocks spread over different block groups
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
* If datablocks are discontiguous, they are possible to spread over
|
2012-09-01 19:31:09 +02:00
|
|
|
* different block groups too. If they are contiguous, with flexbg,
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
* they could still across block group boundary.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
* Also account for superblock, inode, quota and xattr blocks
|
|
|
|
*/
|
2013-06-04 19:01:11 +02:00
|
|
|
static int ext4_meta_trans_blocks(struct inode *inode, int lblocks,
|
|
|
|
int pextents)
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
{
|
2009-05-01 14:50:38 +02:00
|
|
|
ext4_group_t groups, ngroups = ext4_get_groups_count(inode->i_sb);
|
|
|
|
int gdpblocks;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
int idxblocks;
|
|
|
|
int ret = 0;
|
|
|
|
|
|
|
|
/*
|
2013-06-04 19:01:11 +02:00
|
|
|
* How many index blocks need to touch to map @lblocks logical blocks
|
|
|
|
* to @pextents physical extents?
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
*/
|
2013-06-04 19:01:11 +02:00
|
|
|
idxblocks = ext4_index_trans_blocks(inode, lblocks, pextents);
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
|
|
|
|
ret = idxblocks;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now let's see how many group bitmaps and group descriptors need
|
|
|
|
* to account
|
|
|
|
*/
|
2013-06-04 19:01:11 +02:00
|
|
|
groups = idxblocks + pextents;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
gdpblocks = groups;
|
2009-05-01 14:50:38 +02:00
|
|
|
if (groups > ngroups)
|
|
|
|
groups = ngroups;
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
if (groups > EXT4_SB(inode->i_sb)->s_gdb_count)
|
|
|
|
gdpblocks = EXT4_SB(inode->i_sb)->s_gdb_count;
|
|
|
|
|
|
|
|
/* bitmaps and block group descriptor blocks */
|
|
|
|
ret += groups + gdpblocks;
|
|
|
|
|
|
|
|
/* Blocks for super block, inode, quota and xattr blocks */
|
|
|
|
ret += EXT4_META_TRANS_BLOCKS(inode->i_sb);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2011-03-31 03:57:33 +02:00
|
|
|
* Calculate the total number of credits to reserve to fit
|
2008-08-20 04:16:03 +02:00
|
|
|
* the modification of a single pages into a single transaction,
|
|
|
|
* which may include multiple chunks of block allocations.
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
2008-08-20 04:15:58 +02:00
|
|
|
* This could be called via ext4_write_begin()
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
2008-08-20 04:15:58 +02:00
|
|
|
* We need to consider the worse case, when
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
* one new block per extent.
|
2006-10-11 10:20:50 +02:00
|
|
|
*/
|
2006-10-11 10:21:03 +02:00
|
|
|
int ext4_writepage_trans_blocks(struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
int bpp = ext4_journal_blocks_per_page(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
int ret;
|
|
|
|
|
2013-06-04 19:01:11 +02:00
|
|
|
ret = ext4_meta_trans_blocks(inode, bpp, bpp);
|
2006-10-11 10:21:03 +02:00
|
|
|
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
/* Account for data blocks for journalled mode */
|
2006-10-11 10:20:53 +02:00
|
|
|
if (ext4_should_journal_data(inode))
|
ext4: journal credits calulation cleanup and fix for non-extent writepage
When considering how many journal credits are needed for modifying a
chunk of data, we need to account for the super block, inode block,
quota blocks and xattr block, indirect/index blocks, also, group bitmap
and group descriptor blocks for new allocation (including data and
indirect/index blocks). There are many places in ext4 do the calculation
on their own and often missed one or two meta blocks, and often they
assume single block allocation, and did not considering the multile
chunk of allocation case.
This patch is trying to cleanup current journal credit code, provides
some common helper funtion to calculate the journal credits, to be used
for writepage, writepages, DIO, fallocate, migration, defrag, and for
both nonextent and extent files.
This patch modified the writepage/write_begin credit caculation for
nonextent files, to use the new helper function. It also fixed the
problem that writepage on nonextent files did not consider the case
blocksize <pagesize, thus could possibelly need multiple block
allocation in a single transaction.
Signed-off-by: Mingming Cao <cmm@us.ibm.com>
Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
2008-08-20 04:16:07 +02:00
|
|
|
ret += bpp;
|
2006-10-11 10:20:50 +02:00
|
|
|
return ret;
|
|
|
|
}
|
2008-08-20 04:16:03 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Calculate the journal credits for a chunk of data modification.
|
|
|
|
*
|
|
|
|
* This is called from DIO, fallocate or whoever calling
|
2010-07-27 17:56:07 +02:00
|
|
|
* ext4_map_blocks() to map/allocate a chunk of contiguous disk blocks.
|
2008-08-20 04:16:03 +02:00
|
|
|
*
|
|
|
|
* journal buffers for data blocks are not included here, as DIO
|
|
|
|
* and fallocate do no need to journal data buffers.
|
|
|
|
*/
|
|
|
|
int ext4_chunk_trans_blocks(struct inode *inode, int nrblocks)
|
|
|
|
{
|
|
|
|
return ext4_meta_trans_blocks(inode, nrblocks, 1);
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* The caller must have previously called ext4_reserve_inode_write().
|
2006-10-11 10:20:50 +02:00
|
|
|
* Give this, we know that the caller already has write access to iloc->bh.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
int ext4_mark_iloc_dirty(handle_t *handle,
|
2009-06-14 23:45:34 +02:00
|
|
|
struct inode *inode, struct ext4_iloc *iloc)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
int err = 0;
|
|
|
|
|
2012-03-02 18:23:11 +01:00
|
|
|
if (IS_I_VERSION(inode))
|
2008-01-29 05:58:27 +01:00
|
|
|
inode_inc_iversion(inode);
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/* the do_update_inode consumes one bh->b_count */
|
|
|
|
get_bh(iloc->bh);
|
|
|
|
|
2006-10-11 10:21:01 +02:00
|
|
|
/* ext4_do_update_inode() does jbd2_journal_dirty_metadata */
|
2009-09-29 16:07:47 +02:00
|
|
|
err = ext4_do_update_inode(handle, inode, iloc);
|
2006-10-11 10:20:50 +02:00
|
|
|
put_bh(iloc->bh);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* On success, We end up with an outstanding reference count against
|
|
|
|
* iloc->bh. This _must_ be cleaned up later.
|
|
|
|
*/
|
|
|
|
|
|
|
|
int
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_reserve_inode_write(handle_t *handle, struct inode *inode,
|
|
|
|
struct ext4_iloc *iloc)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2009-01-07 06:06:22 +01:00
|
|
|
int err;
|
|
|
|
|
|
|
|
err = ext4_get_inode_loc(inode, iloc);
|
|
|
|
if (!err) {
|
|
|
|
BUFFER_TRACE(iloc->bh, "get_write_access");
|
|
|
|
err = ext4_journal_get_write_access(handle, iloc->bh);
|
|
|
|
if (err) {
|
|
|
|
brelse(iloc->bh);
|
|
|
|
iloc->bh = NULL;
|
2006-10-11 10:20:50 +02:00
|
|
|
}
|
|
|
|
}
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 10:20:50 +02:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2007-07-18 15:19:57 +02:00
|
|
|
/*
|
|
|
|
* Expand an inode by new_extra_isize bytes.
|
|
|
|
* Returns 0 on success or negative error number on failure.
|
|
|
|
*/
|
2008-01-29 05:58:27 +01:00
|
|
|
static int ext4_expand_extra_isize(struct inode *inode,
|
|
|
|
unsigned int new_extra_isize,
|
|
|
|
struct ext4_iloc iloc,
|
|
|
|
handle_t *handle)
|
2007-07-18 15:19:57 +02:00
|
|
|
{
|
|
|
|
struct ext4_inode *raw_inode;
|
|
|
|
struct ext4_xattr_ibody_header *header;
|
|
|
|
|
|
|
|
if (EXT4_I(inode)->i_extra_isize >= new_extra_isize)
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
raw_inode = ext4_raw_inode(&iloc);
|
|
|
|
|
|
|
|
header = IHDR(inode, raw_inode);
|
|
|
|
|
|
|
|
/* No extended attributes present */
|
2010-01-24 20:34:07 +01:00
|
|
|
if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR) ||
|
|
|
|
header->h_magic != cpu_to_le32(EXT4_XATTR_MAGIC)) {
|
2007-07-18 15:19:57 +02:00
|
|
|
memset((void *)raw_inode + EXT4_GOOD_OLD_INODE_SIZE, 0,
|
|
|
|
new_extra_isize);
|
|
|
|
EXT4_I(inode)->i_extra_isize = new_extra_isize;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* try to expand with EAs present */
|
|
|
|
return ext4_expand_extra_isize_ea(inode, new_extra_isize,
|
|
|
|
raw_inode, handle);
|
|
|
|
}
|
|
|
|
|
2006-10-11 10:20:50 +02:00
|
|
|
/*
|
|
|
|
* What we do here is to mark the in-core inode as clean with respect to inode
|
|
|
|
* dirtiness (it may still be data-dirty).
|
|
|
|
* This means that the in-core inode may be reaped by prune_icache
|
|
|
|
* without having to perform any I/O. This is a very good thing,
|
|
|
|
* because *any* task may call prune_icache - even ones which
|
|
|
|
* have a transaction open against a different journal.
|
|
|
|
*
|
|
|
|
* Is this cheating? Not really. Sure, we haven't written the
|
|
|
|
* inode out, but prune_icache isn't a user-visible syncing function.
|
|
|
|
* Whenever the user wants stuff synced (sys_sync, sys_msync, sys_fsync)
|
|
|
|
* we start and wait on commits.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
struct ext4_iloc iloc;
|
2007-07-18 15:19:57 +02:00
|
|
|
struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
|
|
|
|
static unsigned int mnt_count;
|
|
|
|
int err, ret;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
might_sleep();
|
2010-11-08 19:51:33 +01:00
|
|
|
trace_ext4_mark_inode_dirty(inode, _RET_IP_);
|
2006-10-11 10:20:53 +02:00
|
|
|
err = ext4_reserve_inode_write(handle, inode, &iloc);
|
2009-01-07 06:06:22 +01:00
|
|
|
if (ext4_handle_valid(handle) &&
|
|
|
|
EXT4_I(inode)->i_extra_isize < sbi->s_want_extra_isize &&
|
2010-01-24 20:34:07 +01:00
|
|
|
!ext4_test_inode_state(inode, EXT4_STATE_NO_EXPAND)) {
|
2007-07-18 15:19:57 +02:00
|
|
|
/*
|
|
|
|
* We need extra buffer credits since we may write into EA block
|
|
|
|
* with this same handle. If journal_extend fails, then it will
|
|
|
|
* only result in a minor loss of functionality for that inode.
|
|
|
|
* If this is felt to be critical, then e2fsck should be run to
|
|
|
|
* force a large enough s_min_extra_isize.
|
|
|
|
*/
|
|
|
|
if ((jbd2_journal_extend(handle,
|
|
|
|
EXT4_DATA_TRANS_BLOCKS(inode->i_sb))) == 0) {
|
|
|
|
ret = ext4_expand_extra_isize(inode,
|
|
|
|
sbi->s_want_extra_isize,
|
|
|
|
iloc, handle);
|
|
|
|
if (ret) {
|
2010-01-24 20:34:07 +01:00
|
|
|
ext4_set_inode_state(inode,
|
|
|
|
EXT4_STATE_NO_EXPAND);
|
2007-10-17 00:38:25 +02:00
|
|
|
if (mnt_count !=
|
|
|
|
le16_to_cpu(sbi->s_es->s_mnt_count)) {
|
2010-02-15 20:19:27 +01:00
|
|
|
ext4_warning(inode->i_sb,
|
2007-07-18 15:19:57 +02:00
|
|
|
"Unable to expand inode %lu. Delete"
|
|
|
|
" some EAs or run e2fsck.",
|
|
|
|
inode->i_ino);
|
2007-10-17 00:38:25 +02:00
|
|
|
mnt_count =
|
|
|
|
le16_to_cpu(sbi->s_es->s_mnt_count);
|
2007-07-18 15:19:57 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!err)
|
2006-10-11 10:20:53 +02:00
|
|
|
err = ext4_mark_iloc_dirty(handle, inode, &iloc);
|
2006-10-11 10:20:50 +02:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_dirty_inode() is called from __mark_inode_dirty()
|
2006-10-11 10:20:50 +02:00
|
|
|
*
|
|
|
|
* We're really interested in the case where a file is being extended.
|
|
|
|
* i_size has been changed by generic_commit_write() and we thus need
|
|
|
|
* to include the updated inode in the current transaction.
|
|
|
|
*
|
2010-03-03 15:05:00 +01:00
|
|
|
* Also, dquot_alloc_block() will always dirty the inode when blocks
|
2006-10-11 10:20:50 +02:00
|
|
|
* are allocated to the file.
|
|
|
|
*
|
|
|
|
* If the inode is marked synchronous, we don't honour that here - doing
|
|
|
|
* so would cause a commit on atime updates, which we don't bother doing.
|
|
|
|
* We handle synchronous inodes at the highest possible level.
|
2015-02-02 06:37:00 +01:00
|
|
|
*
|
|
|
|
* If only the I_DIRTY_TIME flag is set, we can skip everything. If
|
|
|
|
* I_DIRTY_TIME and I_DIRTY_SYNC is set, the only inode fields we need
|
|
|
|
* to copy into the on-disk inode structure are the timestamp files.
|
2006-10-11 10:20:50 +02:00
|
|
|
*/
|
2011-05-27 12:53:02 +02:00
|
|
|
void ext4_dirty_inode(struct inode *inode, int flags)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
handle_t *handle;
|
|
|
|
|
2015-02-02 06:37:00 +01:00
|
|
|
if (flags == I_DIRTY_TIME)
|
|
|
|
return;
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 2);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (IS_ERR(handle))
|
|
|
|
goto out;
|
2009-09-29 22:06:01 +02:00
|
|
|
|
|
|
|
ext4_mark_inode_dirty(handle, inode);
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_journal_stop(handle);
|
2006-10-11 10:20:50 +02:00
|
|
|
out:
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
#if 0
|
|
|
|
/*
|
|
|
|
* Bind an inode's backing buffer_head into this transaction, to prevent
|
|
|
|
* it from being flushed to disk early. Unlike
|
2006-10-11 10:20:53 +02:00
|
|
|
* ext4_reserve_inode_write, this leaves behind no bh reference and
|
2006-10-11 10:20:50 +02:00
|
|
|
* returns no iloc structure, so the caller needs to repeat the iloc
|
|
|
|
* lookup to mark the inode dirty later.
|
|
|
|
*/
|
2006-10-11 10:20:53 +02:00
|
|
|
static int ext4_pin_inode(handle_t *handle, struct inode *inode)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
2006-10-11 10:20:53 +02:00
|
|
|
struct ext4_iloc iloc;
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
int err = 0;
|
|
|
|
if (handle) {
|
2006-10-11 10:20:53 +02:00
|
|
|
err = ext4_get_inode_loc(inode, &iloc);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!err) {
|
|
|
|
BUFFER_TRACE(iloc.bh, "get_write_access");
|
2006-10-11 10:21:01 +02:00
|
|
|
err = jbd2_journal_get_write_access(handle, iloc.bh);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (!err)
|
2009-01-07 06:06:22 +01:00
|
|
|
err = ext4_handle_dirty_metadata(handle,
|
2010-02-16 21:06:29 +01:00
|
|
|
NULL,
|
2009-01-07 06:06:22 +01:00
|
|
|
iloc.bh);
|
2006-10-11 10:20:50 +02:00
|
|
|
brelse(iloc.bh);
|
|
|
|
}
|
|
|
|
}
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 10:20:50 +02:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
int ext4_change_inode_journal_flag(struct inode *inode, int val)
|
2006-10-11 10:20:50 +02:00
|
|
|
{
|
|
|
|
journal_t *journal;
|
|
|
|
handle_t *handle;
|
|
|
|
int err;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We have to be very careful here: changing a data block's
|
|
|
|
* journaling status dynamically is dangerous. If we write a
|
|
|
|
* data block to the journal, change the status and then delete
|
|
|
|
* that block, we risk forgetting to revoke the old log record
|
|
|
|
* from the journal and so a subsequent replay can corrupt data.
|
|
|
|
* So, first we make sure that the journal is empty and that
|
|
|
|
* nobody is changing anything.
|
|
|
|
*/
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
journal = EXT4_JOURNAL(inode);
|
2009-01-07 06:06:22 +01:00
|
|
|
if (!journal)
|
|
|
|
return 0;
|
2007-07-18 14:33:51 +02:00
|
|
|
if (is_journal_aborted(journal))
|
2006-10-11 10:20:50 +02:00
|
|
|
return -EROFS;
|
2011-12-28 18:02:13 +01:00
|
|
|
/* We have to allocate physical blocks for delalloc blocks
|
|
|
|
* before flushing journal. otherwise delalloc blocks can not
|
|
|
|
* be allocated any more. even more truncate on delalloc blocks
|
|
|
|
* could trigger BUG by flushing delalloc blocks in journal.
|
|
|
|
* There is no delalloc block in non-journal data mode.
|
|
|
|
*/
|
|
|
|
if (val && test_opt(inode->i_sb, DELALLOC)) {
|
|
|
|
err = ext4_alloc_da_blocks(inode);
|
|
|
|
if (err < 0)
|
|
|
|
return err;
|
|
|
|
}
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2012-09-29 06:41:21 +02:00
|
|
|
/* Wait for all existing dio workers */
|
|
|
|
ext4_inode_block_unlocked_dio(inode);
|
|
|
|
inode_dio_wait(inode);
|
|
|
|
|
2006-10-11 10:21:01 +02:00
|
|
|
jbd2_journal_lock_updates(journal);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
/*
|
|
|
|
* OK, there are no updates running now, and all cached data is
|
|
|
|
* synced to disk. We are now in a completely consistent state
|
|
|
|
* which doesn't have anything in the journal, and we know that
|
|
|
|
* no filesystem updates are running, so it is safe to modify
|
|
|
|
* the inode's in-core data-journaling state flag now.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (val)
|
2010-05-17 04:00:00 +02:00
|
|
|
ext4_set_inode_flag(inode, EXT4_INODE_JOURNAL_DATA);
|
2011-12-28 19:55:51 +01:00
|
|
|
else {
|
2014-10-30 15:53:17 +01:00
|
|
|
err = jbd2_journal_flush(journal);
|
|
|
|
if (err < 0) {
|
|
|
|
jbd2_journal_unlock_updates(journal);
|
|
|
|
ext4_inode_resume_unlocked_dio(inode);
|
|
|
|
return err;
|
|
|
|
}
|
2010-05-17 04:00:00 +02:00
|
|
|
ext4_clear_inode_flag(inode, EXT4_INODE_JOURNAL_DATA);
|
2011-12-28 19:55:51 +01:00
|
|
|
}
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_set_aops(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
2006-10-11 10:21:01 +02:00
|
|
|
jbd2_journal_unlock_updates(journal);
|
2012-09-29 06:41:21 +02:00
|
|
|
ext4_inode_resume_unlocked_dio(inode);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
/* Finally we can mark the inode as dirty. */
|
|
|
|
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_INODE, 1);
|
2006-10-11 10:20:50 +02:00
|
|
|
if (IS_ERR(handle))
|
|
|
|
return PTR_ERR(handle);
|
|
|
|
|
2006-10-11 10:20:53 +02:00
|
|
|
err = ext4_mark_inode_dirty(handle, inode);
|
2009-01-07 06:06:22 +01:00
|
|
|
ext4_handle_sync(handle);
|
2006-10-11 10:20:53 +02:00
|
|
|
ext4_journal_stop(handle);
|
|
|
|
ext4_std_error(inode->i_sb, err);
|
2006-10-11 10:20:50 +02:00
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
|
|
|
|
static int ext4_bh_unmapped(handle_t *handle, struct buffer_head *bh)
|
|
|
|
{
|
|
|
|
return !buffer_mapped(bh);
|
|
|
|
}
|
|
|
|
|
2009-04-01 00:23:21 +02:00
|
|
|
int ext4_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
|
2008-07-12 01:27:31 +02:00
|
|
|
{
|
2009-04-01 00:23:21 +02:00
|
|
|
struct page *page = vmf->page;
|
2008-07-12 01:27:31 +02:00
|
|
|
loff_t size;
|
|
|
|
unsigned long len;
|
2011-06-24 20:29:41 +02:00
|
|
|
int ret;
|
2008-07-12 01:27:31 +02:00
|
|
|
struct file *file = vma->vm_file;
|
2013-01-23 23:07:38 +01:00
|
|
|
struct inode *inode = file_inode(file);
|
2008-07-12 01:27:31 +02:00
|
|
|
struct address_space *mapping = inode->i_mapping;
|
2011-06-24 20:29:41 +02:00
|
|
|
handle_t *handle;
|
|
|
|
get_block_t *get_block;
|
|
|
|
int retries = 0;
|
2008-07-12 01:27:31 +02:00
|
|
|
|
2012-06-12 16:20:38 +02:00
|
|
|
sb_start_pagefault(inode->i_sb);
|
2012-10-01 05:04:56 +02:00
|
|
|
file_update_time(vma->vm_file);
|
2015-12-07 20:28:03 +01:00
|
|
|
|
|
|
|
down_read(&EXT4_I(inode)->i_mmap_sem);
|
2011-06-24 20:29:41 +02:00
|
|
|
/* Delalloc case is easy... */
|
|
|
|
if (test_opt(inode->i_sb, DELALLOC) &&
|
|
|
|
!ext4_should_journal_data(inode) &&
|
|
|
|
!ext4_nonda_switch(inode->i_sb)) {
|
|
|
|
do {
|
2015-10-14 00:51:02 +02:00
|
|
|
ret = block_page_mkwrite(vma, vmf,
|
2011-06-24 20:29:41 +02:00
|
|
|
ext4_da_get_block_prep);
|
|
|
|
} while (ret == -ENOSPC &&
|
|
|
|
ext4_should_retry_alloc(inode->i_sb, &retries));
|
|
|
|
goto out_ret;
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
2011-05-18 19:55:20 +02:00
|
|
|
|
|
|
|
lock_page(page);
|
2011-06-24 20:29:41 +02:00
|
|
|
size = i_size_read(inode);
|
|
|
|
/* Page got truncated from under us? */
|
|
|
|
if (page->mapping != mapping || page_offset(page) > size) {
|
|
|
|
unlock_page(page);
|
|
|
|
ret = VM_FAULT_NOPAGE;
|
|
|
|
goto out;
|
2011-05-18 19:55:20 +02:00
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
|
|
|
|
if (page->index == size >> PAGE_CACHE_SHIFT)
|
|
|
|
len = size & ~PAGE_CACHE_MASK;
|
|
|
|
else
|
|
|
|
len = PAGE_CACHE_SIZE;
|
2009-09-10 04:36:03 +02:00
|
|
|
/*
|
2011-06-24 20:29:41 +02:00
|
|
|
* Return if we have all the buffers mapped. This avoids the need to do
|
|
|
|
* journal_start/journal_stop which can block and take a long time
|
2009-09-10 04:36:03 +02:00
|
|
|
*/
|
2008-07-12 01:27:31 +02:00
|
|
|
if (page_has_buffers(page)) {
|
2012-12-10 20:05:51 +01:00
|
|
|
if (!ext4_walk_page_buffers(NULL, page_buffers(page),
|
|
|
|
0, len, NULL,
|
|
|
|
ext4_bh_unmapped)) {
|
2011-06-24 20:29:41 +02:00
|
|
|
/* Wait so that we don't change page under IO */
|
mm: only enforce stable page writes if the backing device requires it
Create a helper function to check if a backing device requires stable
page writes and, if so, performs the necessary wait. Then, make it so
that all points in the memory manager that handle making pages writable
use the helper function. This should provide stable page write support
to most filesystems, while eliminating unnecessary waiting for devices
that don't require the feature.
Before this patchset, all filesystems would block, regardless of whether
or not it was necessary. ext3 would wait, but still generate occasional
checksum errors. The network filesystems were left to do their own
thing, so they'd wait too.
After this patchset, all the disk filesystems except ext3 and btrfs will
wait only if the hardware requires it. ext3 (if necessary) snapshots
pages instead of blocking, and btrfs provides its own bdi so the mm will
never wait. Network filesystems haven't been touched, so either they
provide their own stable page guarantees or they don't block at all.
The blocking behavior is back to what it was before 3.0 if you don't
have a disk requiring stable page writes.
Here's the result of using dbench to test latency on ext2:
3.8.0-rc3:
Operation Count AvgLat MaxLat
----------------------------------------
WriteX 109347 0.028 59.817
ReadX 347180 0.004 3.391
Flush 15514 29.828 287.283
Throughput 57.429 MB/sec 4 clients 4 procs max_latency=287.290 ms
3.8.0-rc3 + patches:
WriteX 105556 0.029 4.273
ReadX 335004 0.005 4.112
Flush 14982 30.540 298.634
Throughput 55.4496 MB/sec 4 clients 4 procs max_latency=298.650 ms
As you can see, the maximum write latency drops considerably with this
patch enabled. The other filesystems (ext3/ext4/xfs/btrfs) behave
similarly, but see the cover letter for those results.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@sandia.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-22 01:42:51 +01:00
|
|
|
wait_for_stable_page(page);
|
2011-06-24 20:29:41 +02:00
|
|
|
ret = VM_FAULT_LOCKED;
|
|
|
|
goto out;
|
2009-09-10 04:36:03 +02:00
|
|
|
}
|
2008-07-12 01:27:31 +02:00
|
|
|
}
|
2009-09-10 04:36:03 +02:00
|
|
|
unlock_page(page);
|
2011-06-24 20:29:41 +02:00
|
|
|
/* OK, we need to fill the hole... */
|
|
|
|
if (ext4_should_dioread_nolock(inode))
|
|
|
|
get_block = ext4_get_block_write;
|
|
|
|
else
|
|
|
|
get_block = ext4_get_block;
|
|
|
|
retry_alloc:
|
2013-02-09 03:59:22 +01:00
|
|
|
handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE,
|
|
|
|
ext4_writepage_trans_blocks(inode));
|
2011-06-24 20:29:41 +02:00
|
|
|
if (IS_ERR(handle)) {
|
2009-04-01 00:23:21 +02:00
|
|
|
ret = VM_FAULT_SIGBUS;
|
2011-06-24 20:29:41 +02:00
|
|
|
goto out;
|
|
|
|
}
|
2015-10-14 00:51:02 +02:00
|
|
|
ret = block_page_mkwrite(vma, vmf, get_block);
|
2011-06-24 20:29:41 +02:00
|
|
|
if (!ret && ext4_should_journal_data(inode)) {
|
2012-12-10 20:05:51 +01:00
|
|
|
if (ext4_walk_page_buffers(handle, page_buffers(page), 0,
|
2011-06-24 20:29:41 +02:00
|
|
|
PAGE_CACHE_SIZE, NULL, do_journal_get_write_access)) {
|
|
|
|
unlock_page(page);
|
|
|
|
ret = VM_FAULT_SIGBUS;
|
2011-10-26 11:00:19 +02:00
|
|
|
ext4_journal_stop(handle);
|
2011-06-24 20:29:41 +02:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
ext4_set_inode_state(inode, EXT4_STATE_JDATA);
|
|
|
|
}
|
|
|
|
ext4_journal_stop(handle);
|
|
|
|
if (ret == -ENOSPC && ext4_should_retry_alloc(inode->i_sb, &retries))
|
|
|
|
goto retry_alloc;
|
|
|
|
out_ret:
|
|
|
|
ret = block_page_mkwrite_return(ret);
|
|
|
|
out:
|
2015-12-07 20:28:03 +01:00
|
|
|
up_read(&EXT4_I(inode)->i_mmap_sem);
|
2012-06-12 16:20:38 +02:00
|
|
|
sb_end_pagefault(inode->i_sb);
|
2008-07-12 01:27:31 +02:00
|
|
|
return ret;
|
|
|
|
}
|
2015-12-07 20:28:03 +01:00
|
|
|
|
|
|
|
int ext4_filemap_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
|
|
|
|
{
|
|
|
|
struct inode *inode = file_inode(vma->vm_file);
|
|
|
|
int err;
|
|
|
|
|
|
|
|
down_read(&EXT4_I(inode)->i_mmap_sem);
|
|
|
|
err = filemap_fault(vma, vmf);
|
|
|
|
up_read(&EXT4_I(inode)->i_mmap_sem);
|
|
|
|
|
|
|
|
return err;
|
|
|
|
}
|