2005-04-17 00:20:36 +02:00
|
|
|
/*
|
|
|
|
* linux/fs/ext2/namei.c
|
|
|
|
*
|
|
|
|
* Rewrite to pagecache. Almost all code had been changed, so blame me
|
|
|
|
* if the things go wrong. Please, send bug reports to
|
|
|
|
* viro@parcelfarce.linux.theplanet.co.uk
|
|
|
|
*
|
|
|
|
* Stuff here is basically a glue between the VFS and generic UNIXish
|
|
|
|
* filesystem that keeps everything in pagecache. All knowledge of the
|
|
|
|
* directory layout is in fs/ext2/dir.c - it turned out to be easily separatable
|
|
|
|
* and it's easier to debug that way. In principle we might want to
|
|
|
|
* generalize that a bit and turn it into a library. Or not.
|
|
|
|
*
|
|
|
|
* The only non-static object here is ext2_dir_inode_operations.
|
|
|
|
*
|
|
|
|
* TODO: get rid of kmap() use, add readahead.
|
|
|
|
*
|
|
|
|
* Copyright (C) 1992, 1993, 1994, 1995
|
|
|
|
* Remy Card (card@masi.ibp.fr)
|
|
|
|
* Laboratoire MASI - Institut Blaise Pascal
|
|
|
|
* Universite Pierre et Marie Curie (Paris VI)
|
|
|
|
*
|
|
|
|
* from
|
|
|
|
*
|
|
|
|
* linux/fs/minix/namei.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 1991, 1992 Linus Torvalds
|
|
|
|
*
|
|
|
|
* Big-endian to little-endian byte-swapping/bitmaps by
|
|
|
|
* David S. Miller (davem@caip.rutgers.edu), 1995
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/pagemap.h>
|
2010-03-03 15:05:06 +01:00
|
|
|
#include <linux/quotaops.h>
|
2005-04-17 00:20:36 +02:00
|
|
|
#include "ext2.h"
|
|
|
|
#include "xattr.h"
|
|
|
|
#include "acl.h"
|
|
|
|
|
|
|
|
static inline int ext2_add_nondir(struct dentry *dentry, struct inode *inode)
|
|
|
|
{
|
|
|
|
int err = ext2_add_link(dentry, inode);
|
|
|
|
if (!err) {
|
2008-12-30 07:52:35 +01:00
|
|
|
unlock_new_inode(inode);
|
2012-07-19 07:18:15 +02:00
|
|
|
d_instantiate(dentry, inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
return 0;
|
|
|
|
}
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(inode);
|
2008-12-30 07:52:35 +01:00
|
|
|
unlock_new_inode(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
iput(inode);
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Methods themselves.
|
|
|
|
*/
|
|
|
|
|
2012-06-10 23:13:09 +02:00
|
|
|
static struct dentry *ext2_lookup(struct inode * dir, struct dentry *dentry, unsigned int flags)
|
2005-04-17 00:20:36 +02:00
|
|
|
{
|
|
|
|
struct inode * inode;
|
|
|
|
ino_t ino;
|
|
|
|
|
|
|
|
if (dentry->d_name.len > EXT2_NAME_LEN)
|
|
|
|
return ERR_PTR(-ENAMETOOLONG);
|
|
|
|
|
2008-08-24 13:28:39 +02:00
|
|
|
ino = ext2_inode_by_name(dir, &dentry->d_name);
|
2005-04-17 00:20:36 +02:00
|
|
|
inode = NULL;
|
|
|
|
if (ino) {
|
2008-02-07 09:15:35 +01:00
|
|
|
inode = ext2_iget(dir->i_sb, ino);
|
2011-07-09 03:20:11 +02:00
|
|
|
if (inode == ERR_PTR(-ESTALE)) {
|
|
|
|
ext2_error(dir->i_sb, __func__,
|
|
|
|
"deleted inode referenced: %lu",
|
|
|
|
(unsigned long) ino);
|
|
|
|
return ERR_PTR(-EIO);
|
2009-06-30 20:41:24 +02:00
|
|
|
}
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
2006-01-14 22:21:07 +01:00
|
|
|
return d_splice_alias(inode, dentry);
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
struct dentry *ext2_get_parent(struct dentry *child)
|
|
|
|
{
|
2012-05-10 22:14:12 +02:00
|
|
|
struct qstr dotdot = QSTR_INIT("..", 2);
|
2015-03-17 23:25:59 +01:00
|
|
|
unsigned long ino = ext2_inode_by_name(d_inode(child), &dotdot);
|
2005-04-17 00:20:36 +02:00
|
|
|
if (!ino)
|
|
|
|
return ERR_PTR(-ENOENT);
|
2015-03-17 23:25:59 +01:00
|
|
|
return d_obtain_alias(ext2_iget(d_inode(child)->i_sb, ino));
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* By the time this is called, we already have created
|
|
|
|
* the directory cache entry for the new file, but it
|
|
|
|
* is so far negative - it has no inode.
|
|
|
|
*
|
|
|
|
* If the create succeeds, we fill in the inode information
|
|
|
|
* with d_instantiate().
|
|
|
|
*/
|
2012-06-11 00:05:36 +02:00
|
|
|
static int ext2_create (struct inode * dir, struct dentry * dentry, umode_t mode, bool excl)
|
2005-04-17 00:20:36 +02:00
|
|
|
{
|
2010-03-03 15:05:06 +01:00
|
|
|
struct inode *inode;
|
2015-06-29 16:08:45 +02:00
|
|
|
int err;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(dir);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2011-02-01 17:05:39 +01:00
|
|
|
inode = ext2_new_inode(dir, mode, &dentry->d_name);
|
2010-03-03 15:05:06 +01:00
|
|
|
if (IS_ERR(inode))
|
|
|
|
return PTR_ERR(inode);
|
|
|
|
|
|
|
|
inode->i_op = &ext2_file_inode_operations;
|
2015-04-16 01:15:17 +02:00
|
|
|
if (test_opt(inode->i_sb, NOBH)) {
|
2010-03-03 15:05:06 +01:00
|
|
|
inode->i_mapping->a_ops = &ext2_nobh_aops;
|
|
|
|
inode->i_fop = &ext2_file_operations;
|
|
|
|
} else {
|
|
|
|
inode->i_mapping->a_ops = &ext2_aops;
|
|
|
|
inode->i_fop = &ext2_file_operations;
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
2010-03-03 15:05:06 +01:00
|
|
|
mark_inode_dirty(inode);
|
|
|
|
return ext2_add_nondir(dentry, inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
|
2013-06-07 07:20:27 +02:00
|
|
|
static int ext2_tmpfile(struct inode *dir, struct dentry *dentry, umode_t mode)
|
|
|
|
{
|
|
|
|
struct inode *inode = ext2_new_inode(dir, mode, NULL);
|
|
|
|
if (IS_ERR(inode))
|
|
|
|
return PTR_ERR(inode);
|
|
|
|
|
|
|
|
inode->i_op = &ext2_file_inode_operations;
|
2015-04-16 01:15:17 +02:00
|
|
|
if (test_opt(inode->i_sb, NOBH)) {
|
2013-06-07 07:20:27 +02:00
|
|
|
inode->i_mapping->a_ops = &ext2_nobh_aops;
|
|
|
|
inode->i_fop = &ext2_file_operations;
|
|
|
|
} else {
|
|
|
|
inode->i_mapping->a_ops = &ext2_aops;
|
|
|
|
inode->i_fop = &ext2_file_operations;
|
|
|
|
}
|
|
|
|
mark_inode_dirty(inode);
|
|
|
|
d_tmpfile(dentry, inode);
|
|
|
|
unlock_new_inode(inode);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2011-07-26 07:52:52 +02:00
|
|
|
static int ext2_mknod (struct inode * dir, struct dentry *dentry, umode_t mode, dev_t rdev)
|
2005-04-17 00:20:36 +02:00
|
|
|
{
|
|
|
|
struct inode * inode;
|
|
|
|
int err;
|
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(dir);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2011-02-01 17:05:39 +01:00
|
|
|
inode = ext2_new_inode (dir, mode, &dentry->d_name);
|
2005-04-17 00:20:36 +02:00
|
|
|
err = PTR_ERR(inode);
|
|
|
|
if (!IS_ERR(inode)) {
|
|
|
|
init_special_inode(inode, inode->i_mode, rdev);
|
|
|
|
#ifdef CONFIG_EXT2_FS_XATTR
|
|
|
|
inode->i_op = &ext2_special_inode_operations;
|
|
|
|
#endif
|
|
|
|
mark_inode_dirty(inode);
|
|
|
|
err = ext2_add_nondir(dentry, inode);
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext2_symlink (struct inode * dir, struct dentry * dentry,
|
|
|
|
const char * symname)
|
|
|
|
{
|
|
|
|
struct super_block * sb = dir->i_sb;
|
|
|
|
int err = -ENAMETOOLONG;
|
|
|
|
unsigned l = strlen(symname)+1;
|
|
|
|
struct inode * inode;
|
|
|
|
|
|
|
|
if (l > sb->s_blocksize)
|
|
|
|
goto out;
|
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(dir);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2011-02-01 17:05:39 +01:00
|
|
|
inode = ext2_new_inode (dir, S_IFLNK | S_IRWXUGO, &dentry->d_name);
|
2005-04-17 00:20:36 +02:00
|
|
|
err = PTR_ERR(inode);
|
|
|
|
if (IS_ERR(inode))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
if (l > sizeof (EXT2_I(inode)->i_data)) {
|
|
|
|
/* slow symlink */
|
|
|
|
inode->i_op = &ext2_symlink_inode_operations;
|
2015-11-17 07:07:57 +01:00
|
|
|
inode_nohighmem(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
if (test_opt(inode->i_sb, NOBH))
|
|
|
|
inode->i_mapping->a_ops = &ext2_nobh_aops;
|
|
|
|
else
|
|
|
|
inode->i_mapping->a_ops = &ext2_aops;
|
|
|
|
err = page_symlink(inode, symname, l);
|
|
|
|
if (err)
|
|
|
|
goto out_fail;
|
|
|
|
} else {
|
|
|
|
/* fast symlink */
|
|
|
|
inode->i_op = &ext2_fast_symlink_inode_operations;
|
2015-05-02 16:02:46 +02:00
|
|
|
inode->i_link = (char*)EXT2_I(inode)->i_data;
|
|
|
|
memcpy(inode->i_link, symname, l);
|
2005-04-17 00:20:36 +02:00
|
|
|
inode->i_size = l-1;
|
|
|
|
}
|
|
|
|
mark_inode_dirty(inode);
|
|
|
|
|
|
|
|
err = ext2_add_nondir(dentry, inode);
|
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
|
|
|
|
out_fail:
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(inode);
|
2008-12-30 07:52:35 +01:00
|
|
|
unlock_new_inode(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
iput (inode);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext2_link (struct dentry * old_dentry, struct inode * dir,
|
|
|
|
struct dentry *dentry)
|
|
|
|
{
|
2015-03-17 23:25:59 +01:00
|
|
|
struct inode *inode = d_inode(old_dentry);
|
2008-12-30 07:52:35 +01:00
|
|
|
int err;
|
2005-04-17 00:20:36 +02:00
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(dir);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2005-04-17 00:20:36 +02:00
|
|
|
inode->i_ctime = CURRENT_TIME_SEC;
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_inc_link_count(inode);
|
2010-10-23 17:11:40 +02:00
|
|
|
ihold(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
|
2008-12-30 07:52:35 +01:00
|
|
|
err = ext2_add_link(dentry, inode);
|
|
|
|
if (!err) {
|
|
|
|
d_instantiate(dentry, inode);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
inode_dec_link_count(inode);
|
|
|
|
iput(inode);
|
|
|
|
return err;
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
|
2011-07-26 07:41:39 +02:00
|
|
|
static int ext2_mkdir(struct inode * dir, struct dentry * dentry, umode_t mode)
|
2005-04-17 00:20:36 +02:00
|
|
|
{
|
|
|
|
struct inode * inode;
|
2012-02-06 18:45:27 +01:00
|
|
|
int err;
|
2005-04-17 00:20:36 +02:00
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(dir);
|
|
|
|
if (err)
|
|
|
|
return err;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_inc_link_count(dir);
|
2005-04-17 00:20:36 +02:00
|
|
|
|
2011-02-01 17:05:39 +01:00
|
|
|
inode = ext2_new_inode(dir, S_IFDIR | mode, &dentry->d_name);
|
2005-04-17 00:20:36 +02:00
|
|
|
err = PTR_ERR(inode);
|
|
|
|
if (IS_ERR(inode))
|
|
|
|
goto out_dir;
|
|
|
|
|
|
|
|
inode->i_op = &ext2_dir_inode_operations;
|
|
|
|
inode->i_fop = &ext2_dir_operations;
|
|
|
|
if (test_opt(inode->i_sb, NOBH))
|
|
|
|
inode->i_mapping->a_ops = &ext2_nobh_aops;
|
|
|
|
else
|
|
|
|
inode->i_mapping->a_ops = &ext2_aops;
|
|
|
|
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_inc_link_count(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
|
|
|
|
err = ext2_make_empty(inode, dir);
|
|
|
|
if (err)
|
|
|
|
goto out_fail;
|
|
|
|
|
|
|
|
err = ext2_add_link(dentry, inode);
|
|
|
|
if (err)
|
|
|
|
goto out_fail;
|
|
|
|
|
2008-12-30 07:52:35 +01:00
|
|
|
unlock_new_inode(inode);
|
2012-07-19 07:18:15 +02:00
|
|
|
d_instantiate(dentry, inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
|
|
|
|
out_fail:
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(inode);
|
|
|
|
inode_dec_link_count(inode);
|
2008-12-30 07:52:35 +01:00
|
|
|
unlock_new_inode(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
iput(inode);
|
|
|
|
out_dir:
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(dir);
|
2005-04-17 00:20:36 +02:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext2_unlink(struct inode * dir, struct dentry *dentry)
|
|
|
|
{
|
2015-03-17 23:25:59 +01:00
|
|
|
struct inode * inode = d_inode(dentry);
|
2005-04-17 00:20:36 +02:00
|
|
|
struct ext2_dir_entry_2 * de;
|
|
|
|
struct page * page;
|
2015-06-29 16:08:45 +02:00
|
|
|
int err;
|
2005-04-17 00:20:36 +02:00
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(dir);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2008-08-24 13:28:39 +02:00
|
|
|
de = ext2_find_entry (dir, &dentry->d_name, &page);
|
2015-06-29 16:08:45 +02:00
|
|
|
if (!de) {
|
|
|
|
err = -ENOENT;
|
2005-04-17 00:20:36 +02:00
|
|
|
goto out;
|
2015-06-29 16:08:45 +02:00
|
|
|
}
|
2005-04-17 00:20:36 +02:00
|
|
|
|
|
|
|
err = ext2_delete_entry (de, page);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
inode->i_ctime = dir->i_ctime;
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
err = 0;
|
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext2_rmdir (struct inode * dir, struct dentry *dentry)
|
|
|
|
{
|
2015-03-17 23:25:59 +01:00
|
|
|
struct inode * inode = d_inode(dentry);
|
2005-04-17 00:20:36 +02:00
|
|
|
int err = -ENOTEMPTY;
|
|
|
|
|
|
|
|
if (ext2_empty_dir(inode)) {
|
|
|
|
err = ext2_unlink(dir, dentry);
|
|
|
|
if (!err) {
|
|
|
|
inode->i_size = 0;
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(inode);
|
|
|
|
inode_dec_link_count(dir);
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int ext2_rename (struct inode * old_dir, struct dentry * old_dentry,
|
|
|
|
struct inode * new_dir, struct dentry * new_dentry )
|
|
|
|
{
|
2015-03-17 23:25:59 +01:00
|
|
|
struct inode * old_inode = d_inode(old_dentry);
|
|
|
|
struct inode * new_inode = d_inode(new_dentry);
|
2005-04-17 00:20:36 +02:00
|
|
|
struct page * dir_page = NULL;
|
|
|
|
struct ext2_dir_entry_2 * dir_de = NULL;
|
|
|
|
struct page * old_page;
|
|
|
|
struct ext2_dir_entry_2 * old_de;
|
2015-06-29 16:08:45 +02:00
|
|
|
int err;
|
2005-04-17 00:20:36 +02:00
|
|
|
|
2015-06-29 16:08:45 +02:00
|
|
|
err = dquot_initialize(old_dir);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
err = dquot_initialize(new_dir);
|
|
|
|
if (err)
|
|
|
|
goto out;
|
2010-03-03 15:05:06 +01:00
|
|
|
|
2008-08-24 13:28:39 +02:00
|
|
|
old_de = ext2_find_entry (old_dir, &old_dentry->d_name, &old_page);
|
2015-06-29 16:08:45 +02:00
|
|
|
if (!old_de) {
|
|
|
|
err = -ENOENT;
|
2005-04-17 00:20:36 +02:00
|
|
|
goto out;
|
2015-06-29 16:08:45 +02:00
|
|
|
}
|
2005-04-17 00:20:36 +02:00
|
|
|
|
|
|
|
if (S_ISDIR(old_inode->i_mode)) {
|
|
|
|
err = -EIO;
|
|
|
|
dir_de = ext2_dotdot(old_inode, &dir_page);
|
|
|
|
if (!dir_de)
|
|
|
|
goto out_old;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (new_inode) {
|
|
|
|
struct page *new_page;
|
|
|
|
struct ext2_dir_entry_2 *new_de;
|
|
|
|
|
|
|
|
err = -ENOTEMPTY;
|
|
|
|
if (dir_de && !ext2_empty_dir (new_inode))
|
|
|
|
goto out_dir;
|
|
|
|
|
|
|
|
err = -ENOENT;
|
2008-08-24 13:28:39 +02:00
|
|
|
new_de = ext2_find_entry (new_dir, &new_dentry->d_name, &new_page);
|
2005-04-17 00:20:36 +02:00
|
|
|
if (!new_de)
|
|
|
|
goto out_dir;
|
ext2: Do not update mtime of a moved directory
One of our users is complaining that his backup tool is upset on ext2
(while it's happy on ext3, xfs, ...) because of the mtime change.
The problem is:
mkdir foo
mkdir bar
mkdir foo/a
Now under ext2:
mv foo/a foo/b
changes mtime of 'foo/a' (foo/b after the move). That does not really
make sense and it does not happen under any other filesystem I've seen.
More complicated is:
mv foo/a bar/a
This changes mtime of foo/a (bar/a after the move) and it makes some
sense since we had to update parent directory pointer of foo/a. But
again, no other filesystem does this. So after some thoughts I'd vote
for consistency and change ext2 to behave the same as other filesystems.
Do not update mtime of a moved directory. Specs don't say anything
about it (neither that it should, nor that it should not be updated) and
other common filesystems (ext3, ext4, xfs, reiserfs, fat, ...) don't do
it. So let's become more consistent.
Spotted by ronny.pretzsch@dfs.de, initial fix by Jörn Engel.
Reported-by: <ronny.pretzsch@dfs.de>
Cc: <hare@suse.de>
Cc: Jörn Engel <joern@logfs.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-06-18 01:26:20 +02:00
|
|
|
ext2_set_link(new_dir, new_de, new_page, old_inode, 1);
|
2005-04-17 00:20:36 +02:00
|
|
|
new_inode->i_ctime = CURRENT_TIME_SEC;
|
|
|
|
if (dir_de)
|
2006-10-01 08:29:03 +02:00
|
|
|
drop_nlink(new_inode);
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(new_inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
} else {
|
|
|
|
err = ext2_add_link(new_dentry, old_inode);
|
2011-02-24 11:48:22 +01:00
|
|
|
if (err)
|
2005-04-17 00:20:36 +02:00
|
|
|
goto out_dir;
|
|
|
|
if (dir_de)
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_inc_link_count(new_dir);
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Like most other Unix systems, set the ctime for inodes on a
|
|
|
|
* rename.
|
|
|
|
*/
|
|
|
|
old_inode->i_ctime = CURRENT_TIME_SEC;
|
2011-02-24 11:48:22 +01:00
|
|
|
mark_inode_dirty(old_inode);
|
2005-04-17 00:20:36 +02:00
|
|
|
|
|
|
|
ext2_delete_entry (old_de, old_page);
|
|
|
|
|
|
|
|
if (dir_de) {
|
ext2: Do not update mtime of a moved directory
One of our users is complaining that his backup tool is upset on ext2
(while it's happy on ext3, xfs, ...) because of the mtime change.
The problem is:
mkdir foo
mkdir bar
mkdir foo/a
Now under ext2:
mv foo/a foo/b
changes mtime of 'foo/a' (foo/b after the move). That does not really
make sense and it does not happen under any other filesystem I've seen.
More complicated is:
mv foo/a bar/a
This changes mtime of foo/a (bar/a after the move) and it makes some
sense since we had to update parent directory pointer of foo/a. But
again, no other filesystem does this. So after some thoughts I'd vote
for consistency and change ext2 to behave the same as other filesystems.
Do not update mtime of a moved directory. Specs don't say anything
about it (neither that it should, nor that it should not be updated) and
other common filesystems (ext3, ext4, xfs, reiserfs, fat, ...) don't do
it. So let's become more consistent.
Spotted by ronny.pretzsch@dfs.de, initial fix by Jörn Engel.
Reported-by: <ronny.pretzsch@dfs.de>
Cc: <hare@suse.de>
Cc: Jörn Engel <joern@logfs.org>
Signed-off-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2009-06-18 01:26:20 +02:00
|
|
|
if (old_dir != new_dir)
|
|
|
|
ext2_set_link(old_inode, dir_de, dir_page, new_dir, 0);
|
2009-09-05 06:25:37 +02:00
|
|
|
else {
|
|
|
|
kunmap(dir_page);
|
|
|
|
page_cache_release(dir_page);
|
|
|
|
}
|
2006-03-23 12:00:53 +01:00
|
|
|
inode_dec_link_count(old_dir);
|
2005-04-17 00:20:36 +02:00
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
|
|
out_dir:
|
|
|
|
if (dir_de) {
|
|
|
|
kunmap(dir_page);
|
|
|
|
page_cache_release(dir_page);
|
|
|
|
}
|
|
|
|
out_old:
|
|
|
|
kunmap(old_page);
|
|
|
|
page_cache_release(old_page);
|
|
|
|
out:
|
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
2007-02-12 09:55:38 +01:00
|
|
|
const struct inode_operations ext2_dir_inode_operations = {
|
2005-04-17 00:20:36 +02:00
|
|
|
.create = ext2_create,
|
|
|
|
.lookup = ext2_lookup,
|
|
|
|
.link = ext2_link,
|
|
|
|
.unlink = ext2_unlink,
|
|
|
|
.symlink = ext2_symlink,
|
|
|
|
.mkdir = ext2_mkdir,
|
|
|
|
.rmdir = ext2_rmdir,
|
|
|
|
.mknod = ext2_mknod,
|
|
|
|
.rename = ext2_rename,
|
|
|
|
#ifdef CONFIG_EXT2_FS_XATTR
|
|
|
|
.setxattr = generic_setxattr,
|
|
|
|
.getxattr = generic_getxattr,
|
|
|
|
.listxattr = ext2_listxattr,
|
|
|
|
.removexattr = generic_removexattr,
|
|
|
|
#endif
|
|
|
|
.setattr = ext2_setattr,
|
2011-07-23 17:37:31 +02:00
|
|
|
.get_acl = ext2_get_acl,
|
2013-12-20 14:16:44 +01:00
|
|
|
.set_acl = ext2_set_acl,
|
2013-06-07 07:20:27 +02:00
|
|
|
.tmpfile = ext2_tmpfile,
|
2005-04-17 00:20:36 +02:00
|
|
|
};
|
|
|
|
|
2007-02-12 09:55:38 +01:00
|
|
|
const struct inode_operations ext2_special_inode_operations = {
|
2005-04-17 00:20:36 +02:00
|
|
|
#ifdef CONFIG_EXT2_FS_XATTR
|
|
|
|
.setxattr = generic_setxattr,
|
|
|
|
.getxattr = generic_getxattr,
|
|
|
|
.listxattr = ext2_listxattr,
|
|
|
|
.removexattr = generic_removexattr,
|
|
|
|
#endif
|
|
|
|
.setattr = ext2_setattr,
|
2011-07-23 17:37:31 +02:00
|
|
|
.get_acl = ext2_get_acl,
|
2013-12-20 14:16:44 +01:00
|
|
|
.set_acl = ext2_set_acl,
|
2005-04-17 00:20:36 +02:00
|
|
|
};
|