maxmustermann/linux
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

net: ax88796c: Remove pointless check in ax88796c_open()

Browse source 
Clang warns:

drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of
array 'ax_local->phydev->advertising' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
        if (ax_local->phydev->advertising &&
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~

advertising cannot be NULL here if ax_local is not NULL, which cannot
happen due to the check in ax88796c_probe(). Remove the check.

Link: https://github.com/ClangBuiltLinux/linux/issues/1492
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Nathan Chancellor 2021-10-25 14:12:39 -07:00 committed by David S. Miller
parent 3c5548812a
commit 971f5c4079
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/net/ethernet/asix/ax88796c_main.c
View file

@ -850,11 +850,10 @@ ax88796c_open(struct net_device *ndev)
/* Setup flow-control configuration */
phy_support_asym_pause(ax_local->phydev);
if (ax_local->phydev->advertising &&
(linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
ax_local->phydev->advertising) ||
linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
ax_local->phydev->advertising)))
if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
ax_local->phydev->advertising) ||
linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
ax_local->phydev->advertising))
fc |= AX_FC_ANEG;
fc |= linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,