2016-12-16 07:26:15 +01:00
|
|
|
/*
|
2019-08-27 20:37:47 +02:00
|
|
|
* MinIO Cloud Storage, (C) 2016-2019 MinIO, Inc.
|
2016-12-16 07:26:15 +01:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
|
|
|
package cmd
|
|
|
|
|
|
|
|
import (
|
2017-01-17 19:02:58 +01:00
|
|
|
"bytes"
|
2018-03-15 21:27:16 +01:00
|
|
|
"context"
|
2016-12-16 07:26:15 +01:00
|
|
|
"encoding/json"
|
2017-03-17 17:25:49 +01:00
|
|
|
"io"
|
2017-01-17 23:25:59 +01:00
|
|
|
"io/ioutil"
|
2016-12-16 07:26:15 +01:00
|
|
|
"net/http"
|
|
|
|
"net/http/httptest"
|
2017-01-04 08:39:22 +01:00
|
|
|
"net/url"
|
2018-09-28 02:16:30 +02:00
|
|
|
"sync"
|
2016-12-16 07:26:15 +01:00
|
|
|
"testing"
|
|
|
|
|
2018-04-22 04:23:54 +02:00
|
|
|
"github.com/gorilla/mux"
|
2017-10-31 19:54:32 +01:00
|
|
|
"github.com/minio/minio/pkg/auth"
|
2018-01-22 23:54:55 +01:00
|
|
|
"github.com/minio/minio/pkg/madmin"
|
2016-12-16 07:26:15 +01:00
|
|
|
)
|
|
|
|
|
2017-01-23 09:32:55 +01:00
|
|
|
// adminXLTestBed - encapsulates subsystems that need to be setup for
|
|
|
|
// admin-handler unit tests.
|
|
|
|
type adminXLTestBed struct {
|
2019-02-13 13:59:36 +01:00
|
|
|
xlDirs []string
|
|
|
|
objLayer ObjectLayer
|
|
|
|
router *mux.Router
|
2017-01-23 09:32:55 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// prepareAdminXLTestBed - helper function that setups a single-node
|
|
|
|
// XL backend for admin-handler tests.
|
|
|
|
func prepareAdminXLTestBed() (*adminXLTestBed, error) {
|
|
|
|
// reset global variables to start afresh.
|
|
|
|
resetTestGlobals()
|
2017-02-07 21:51:43 +01:00
|
|
|
|
2020-01-16 03:30:32 +01:00
|
|
|
// Set globalIsXL to indicate that the setup uses an erasure
|
|
|
|
// code backend.
|
|
|
|
globalIsXL = true
|
|
|
|
|
2017-01-23 09:32:55 +01:00
|
|
|
// Initializing objectLayer for HealFormatHandler.
|
|
|
|
objLayer, xlDirs, xlErr := initTestXLObjLayer()
|
|
|
|
if xlErr != nil {
|
|
|
|
return nil, xlErr
|
|
|
|
}
|
|
|
|
|
2018-08-15 06:41:47 +02:00
|
|
|
// Initialize minio server config.
|
|
|
|
if err := newTestConfig(globalMinioDefaultRegion, objLayer); err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
2017-02-08 09:13:02 +01:00
|
|
|
// Initialize boot time
|
2017-03-18 19:28:41 +01:00
|
|
|
globalBootTime = UTCNow()
|
2017-02-08 09:13:02 +01:00
|
|
|
|
2019-11-20 02:42:27 +01:00
|
|
|
globalEndpoints = mustGetZoneEndpoints(xlDirs...)
|
2017-01-23 09:32:55 +01:00
|
|
|
|
2019-02-12 10:25:52 +01:00
|
|
|
globalConfigSys = NewConfigSys()
|
|
|
|
|
|
|
|
globalIAMSys = NewIAMSys()
|
|
|
|
globalIAMSys.Init(objLayer)
|
2018-03-15 21:03:41 +01:00
|
|
|
|
2019-10-02 02:05:02 +02:00
|
|
|
buckets, err := objLayer.ListBuckets(context.Background())
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
globalPolicySys = NewPolicySys()
|
2019-10-02 02:05:02 +02:00
|
|
|
globalPolicySys.Init(buckets, objLayer)
|
2019-02-12 10:25:52 +01:00
|
|
|
|
2019-11-09 18:27:23 +01:00
|
|
|
globalNotificationSys = NewNotificationSys(globalEndpoints)
|
2019-10-02 02:05:02 +02:00
|
|
|
globalNotificationSys.Init(buckets, objLayer)
|
2018-04-25 00:53:30 +02:00
|
|
|
|
2017-01-23 09:32:55 +01:00
|
|
|
// Setup admin mgmt REST API handlers.
|
2018-04-22 04:23:54 +02:00
|
|
|
adminRouter := mux.NewRouter()
|
2019-01-23 20:10:59 +01:00
|
|
|
registerAdminRouter(adminRouter, true, true)
|
2017-01-23 09:32:55 +01:00
|
|
|
|
|
|
|
return &adminXLTestBed{
|
2018-08-15 06:41:47 +02:00
|
|
|
xlDirs: xlDirs,
|
|
|
|
objLayer: objLayer,
|
|
|
|
router: adminRouter,
|
2017-01-23 09:32:55 +01:00
|
|
|
}, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// TearDown - method that resets the test bed for subsequent unit
|
|
|
|
// tests to start afresh.
|
|
|
|
func (atb *adminXLTestBed) TearDown() {
|
|
|
|
removeRoots(atb.xlDirs)
|
|
|
|
resetTestGlobals()
|
|
|
|
}
|
|
|
|
|
|
|
|
// initTestObjLayer - Helper function to initialize an XL-based object
|
|
|
|
// layer and set globalObjectAPI.
|
|
|
|
func initTestXLObjLayer() (ObjectLayer, []string, error) {
|
2018-02-16 02:45:57 +01:00
|
|
|
xlDirs, err := getRandomDisks(16)
|
|
|
|
if err != nil {
|
|
|
|
return nil, nil, err
|
|
|
|
}
|
2019-11-20 02:42:27 +01:00
|
|
|
endpoints := mustGetNewEndpoints(xlDirs...)
|
2020-01-18 00:39:07 +01:00
|
|
|
format, err := waitForFormatXL(true, endpoints, 1, 1, 16, "")
|
2018-02-16 02:45:57 +01:00
|
|
|
if err != nil {
|
|
|
|
removeRoots(xlDirs)
|
|
|
|
return nil, nil, err
|
2017-01-23 09:32:55 +01:00
|
|
|
}
|
2018-02-16 02:45:57 +01:00
|
|
|
|
2018-06-06 21:52:56 +02:00
|
|
|
globalPolicySys = NewPolicySys()
|
2018-02-16 02:45:57 +01:00
|
|
|
objLayer, err := newXLSets(endpoints, format, 1, 16)
|
|
|
|
if err != nil {
|
|
|
|
return nil, nil, err
|
|
|
|
}
|
|
|
|
|
2017-01-23 09:32:55 +01:00
|
|
|
// Make objLayer available to all internal services via globalObjectAPI.
|
|
|
|
globalObjLayerMutex.Lock()
|
|
|
|
globalObjectAPI = objLayer
|
|
|
|
globalObjLayerMutex.Unlock()
|
|
|
|
return objLayer, xlDirs, nil
|
|
|
|
}
|
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// cmdType - Represents different service subcomands like status, stop
|
|
|
|
// and restart.
|
2016-12-16 07:26:15 +01:00
|
|
|
type cmdType int
|
|
|
|
|
|
|
|
const (
|
2019-08-29 00:04:43 +02:00
|
|
|
restartCmd cmdType = iota
|
2018-01-22 23:54:55 +01:00
|
|
|
stopCmd
|
2016-12-16 07:26:15 +01:00
|
|
|
)
|
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// toServiceSignal - Helper function that translates a given cmdType
|
|
|
|
// value to its corresponding serviceSignal value.
|
2016-12-16 07:26:15 +01:00
|
|
|
func (c cmdType) toServiceSignal() serviceSignal {
|
|
|
|
switch c {
|
|
|
|
case restartCmd:
|
|
|
|
return serviceRestart
|
2018-01-22 23:54:55 +01:00
|
|
|
case stopCmd:
|
|
|
|
return serviceStop
|
2016-12-16 07:26:15 +01:00
|
|
|
}
|
2019-08-29 00:04:43 +02:00
|
|
|
return serviceRestart
|
2016-12-16 07:26:15 +01:00
|
|
|
}
|
|
|
|
|
2019-08-27 20:37:47 +02:00
|
|
|
func (c cmdType) toServiceAction() madmin.ServiceAction {
|
2018-01-22 23:54:55 +01:00
|
|
|
switch c {
|
|
|
|
case restartCmd:
|
2019-08-27 20:37:47 +02:00
|
|
|
return madmin.ServiceActionRestart
|
2018-01-22 23:54:55 +01:00
|
|
|
case stopCmd:
|
2019-08-27 20:37:47 +02:00
|
|
|
return madmin.ServiceActionStop
|
2018-01-22 23:54:55 +01:00
|
|
|
}
|
2019-08-29 00:04:43 +02:00
|
|
|
return madmin.ServiceActionRestart
|
2018-01-22 23:54:55 +01:00
|
|
|
}
|
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// testServiceSignalReceiver - Helper function that simulates a
|
|
|
|
// go-routine waiting on service signal.
|
2016-12-16 07:26:15 +01:00
|
|
|
func testServiceSignalReceiver(cmd cmdType, t *testing.T) {
|
|
|
|
expectedCmd := cmd.toServiceSignal()
|
|
|
|
serviceCmd := <-globalServiceSignalCh
|
|
|
|
if serviceCmd != expectedCmd {
|
|
|
|
t.Errorf("Expected service command %v but received %v", expectedCmd, serviceCmd)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// getServiceCmdRequest - Constructs a management REST API request for service
|
|
|
|
// subcommands for a given cmdType value.
|
2019-08-27 20:37:47 +02:00
|
|
|
func getServiceCmdRequest(cmd cmdType, cred auth.Credentials) (*http.Request, error) {
|
|
|
|
queryVal := url.Values{}
|
|
|
|
queryVal.Set("action", string(cmd.toServiceAction()))
|
2019-11-04 18:30:59 +01:00
|
|
|
resource := adminPathPrefix + adminAPIVersionPrefix + "/service?" + queryVal.Encode()
|
2019-08-27 20:37:47 +02:00
|
|
|
req, err := newTestRequest(http.MethodPost, resource, 0, nil)
|
2016-12-16 07:26:15 +01:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
2017-01-04 08:39:22 +01:00
|
|
|
|
|
|
|
// management REST API uses signature V4 for authentication.
|
2016-12-26 19:21:23 +01:00
|
|
|
err = signRequestV4(req, cred.AccessKey, cred.SecretKey)
|
2016-12-16 07:26:15 +01:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
return req, nil
|
|
|
|
}
|
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// testServicesCmdHandler - parametrizes service subcommand tests on
|
|
|
|
// cmdType value.
|
2017-01-24 17:08:36 +01:00
|
|
|
func testServicesCmdHandler(cmd cmdType, t *testing.T) {
|
2017-01-23 09:32:55 +01:00
|
|
|
adminTestBed, err := prepareAdminXLTestBed()
|
2016-12-16 07:26:15 +01:00
|
|
|
if err != nil {
|
2017-01-23 09:32:55 +01:00
|
|
|
t.Fatal("Failed to initialize a single node XL backend for admin handler tests.")
|
2016-12-16 07:26:15 +01:00
|
|
|
}
|
2017-01-23 09:32:55 +01:00
|
|
|
defer adminTestBed.TearDown()
|
2016-12-16 07:26:15 +01:00
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// Initialize admin peers to make admin RPC calls. Note: In a
|
|
|
|
// single node setup, this degenerates to a simple function
|
|
|
|
// call under the hood.
|
2017-04-12 00:44:27 +02:00
|
|
|
globalMinioAddr = "127.0.0.1:9000"
|
2016-12-16 07:26:15 +01:00
|
|
|
|
2018-09-28 02:16:30 +02:00
|
|
|
var wg sync.WaitGroup
|
|
|
|
|
2018-04-22 04:23:54 +02:00
|
|
|
// Setting up a go routine to simulate ServerRouter's
|
2016-12-16 07:26:15 +01:00
|
|
|
// handleServiceSignals for stop and restart commands.
|
2017-01-17 23:25:59 +01:00
|
|
|
if cmd == restartCmd {
|
2018-09-28 02:16:30 +02:00
|
|
|
wg.Add(1)
|
|
|
|
go func() {
|
|
|
|
defer wg.Done()
|
|
|
|
testServiceSignalReceiver(cmd, t)
|
|
|
|
}()
|
2016-12-16 07:26:15 +01:00
|
|
|
}
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2018-01-22 23:54:55 +01:00
|
|
|
|
2019-08-27 20:37:47 +02:00
|
|
|
req, err := getServiceCmdRequest(cmd, credentials)
|
2016-12-16 07:26:15 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to build service status request %v", err)
|
|
|
|
}
|
2017-01-17 23:25:59 +01:00
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
2018-04-22 04:23:54 +02:00
|
|
|
adminTestBed.router.ServeHTTP(rec, req)
|
2016-12-16 07:26:15 +01:00
|
|
|
|
2019-08-27 20:37:47 +02:00
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
resp, _ := ioutil.ReadAll(rec.Body)
|
|
|
|
t.Errorf("Expected to receive %d status code but received %d. Body (%s)",
|
|
|
|
http.StatusOK, rec.Code, string(resp))
|
|
|
|
}
|
2016-12-16 07:26:15 +01:00
|
|
|
|
2018-09-28 02:16:30 +02:00
|
|
|
// Wait until testServiceSignalReceiver() called in a goroutine quits.
|
|
|
|
wg.Wait()
|
2016-12-16 07:26:15 +01:00
|
|
|
}
|
|
|
|
|
2017-01-04 08:39:22 +01:00
|
|
|
// Test for service restart management REST API.
|
2016-12-16 07:26:15 +01:00
|
|
|
func TestServiceRestartHandler(t *testing.T) {
|
2017-01-24 17:08:36 +01:00
|
|
|
testServicesCmdHandler(restartCmd, t)
|
2017-01-17 23:25:59 +01:00
|
|
|
}
|
|
|
|
|
2017-03-17 17:25:49 +01:00
|
|
|
// buildAdminRequest - helper function to build an admin API request.
|
2018-01-22 23:54:55 +01:00
|
|
|
func buildAdminRequest(queryVal url.Values, method, path string,
|
2017-03-17 17:25:49 +01:00
|
|
|
contentLength int64, bodySeeker io.ReadSeeker) (*http.Request, error) {
|
2018-01-22 23:54:55 +01:00
|
|
|
|
|
|
|
req, err := newTestRequest(method,
|
2019-11-04 18:30:59 +01:00
|
|
|
adminPathPrefix+adminAPIVersionPrefix+path+"?"+queryVal.Encode(),
|
2018-01-22 23:54:55 +01:00
|
|
|
contentLength, bodySeeker)
|
2017-03-17 17:25:49 +01:00
|
|
|
if err != nil {
|
2018-04-06 00:04:40 +02:00
|
|
|
return nil, err
|
2017-03-17 17:25:49 +01:00
|
|
|
}
|
|
|
|
|
2019-10-23 07:59:13 +02:00
|
|
|
cred := globalActiveCred
|
2017-03-17 17:25:49 +01:00
|
|
|
err = signRequestV4(req, cred.AccessKey, cred.SecretKey)
|
|
|
|
if err != nil {
|
2018-04-06 00:04:40 +02:00
|
|
|
return nil, err
|
2017-03-17 17:25:49 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return req, nil
|
|
|
|
}
|
|
|
|
|
2017-04-07 08:08:33 +02:00
|
|
|
func TestAdminServerInfo(t *testing.T) {
|
|
|
|
adminTestBed, err := prepareAdminXLTestBed()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Failed to initialize a single node XL backend for admin handler tests.")
|
|
|
|
}
|
2020-03-03 01:29:30 +01:00
|
|
|
|
2017-04-07 08:08:33 +02:00
|
|
|
defer adminTestBed.TearDown()
|
|
|
|
|
|
|
|
// Initialize admin peers to make admin RPC calls.
|
2017-04-12 00:44:27 +02:00
|
|
|
globalMinioAddr = "127.0.0.1:9000"
|
2017-04-07 08:08:33 +02:00
|
|
|
|
|
|
|
// Prepare query params for set-config mgmt REST API.
|
|
|
|
queryVal := url.Values{}
|
|
|
|
queryVal.Set("info", "")
|
|
|
|
|
2018-01-22 23:54:55 +01:00
|
|
|
req, err := buildAdminRequest(queryVal, http.MethodGet, "/info", 0, nil)
|
2017-04-07 08:08:33 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to construct get-config object request - %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
2018-04-22 04:23:54 +02:00
|
|
|
adminTestBed.router.ServeHTTP(rec, req)
|
2017-04-07 08:08:33 +02:00
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Errorf("Expected to succeed but failed with %d", rec.Code)
|
|
|
|
}
|
|
|
|
|
2019-12-13 20:33:11 +01:00
|
|
|
results := madmin.InfoMessage{}
|
2017-04-21 16:15:53 +02:00
|
|
|
err = json.NewDecoder(rec.Body).Decode(&results)
|
2017-04-07 08:08:33 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to decode set config result json %v", err)
|
|
|
|
}
|
|
|
|
|
2019-12-13 20:33:11 +01:00
|
|
|
if results.Region != globalMinioDefaultRegion {
|
|
|
|
t.Errorf("Expected %s, got %s", globalMinioDefaultRegion, results.Region)
|
2017-04-07 08:08:33 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-02-12 10:25:52 +01:00
|
|
|
// TestToAdminAPIErrCode - test for toAdminAPIErrCode helper function.
|
|
|
|
func TestToAdminAPIErrCode(t *testing.T) {
|
2017-02-27 20:40:27 +01:00
|
|
|
testCases := []struct {
|
|
|
|
err error
|
|
|
|
expectedAPIErr APIErrorCode
|
|
|
|
}{
|
|
|
|
// 1. Server not in quorum.
|
|
|
|
{
|
|
|
|
err: errXLWriteQuorum,
|
|
|
|
expectedAPIErr: ErrAdminConfigNoQuorum,
|
|
|
|
},
|
|
|
|
// 2. No error.
|
|
|
|
{
|
|
|
|
err: nil,
|
|
|
|
expectedAPIErr: ErrNone,
|
|
|
|
},
|
|
|
|
// 3. Non-admin API specific error.
|
|
|
|
{
|
|
|
|
err: errDiskNotFound,
|
2018-11-12 20:07:43 +01:00
|
|
|
expectedAPIErr: toAPIErrorCode(context.Background(), errDiskNotFound),
|
2017-02-27 20:40:27 +01:00
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for i, test := range testCases {
|
2018-11-12 20:07:43 +01:00
|
|
|
actualErr := toAdminAPIErrCode(context.Background(), test.err)
|
2017-02-27 20:40:27 +01:00
|
|
|
if actualErr != test.expectedAPIErr {
|
|
|
|
t.Errorf("Test %d: Expected %v but received %v",
|
|
|
|
i+1, test.expectedAPIErr, actualErr)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-08-29 22:53:27 +02:00
|
|
|
|
|
|
|
func TestExtractHealInitParams(t *testing.T) {
|
|
|
|
mkParams := func(clientToken string, forceStart, forceStop bool) url.Values {
|
|
|
|
v := url.Values{}
|
|
|
|
if clientToken != "" {
|
|
|
|
v.Add(string(mgmtClientToken), clientToken)
|
|
|
|
}
|
|
|
|
if forceStart {
|
|
|
|
v.Add(string(mgmtForceStart), "")
|
|
|
|
}
|
|
|
|
if forceStop {
|
|
|
|
v.Add(string(mgmtForceStop), "")
|
|
|
|
}
|
|
|
|
return v
|
|
|
|
}
|
|
|
|
qParmsArr := []url.Values{
|
|
|
|
// Invalid cases
|
|
|
|
mkParams("", true, true),
|
|
|
|
mkParams("111", true, true),
|
|
|
|
mkParams("111", true, false),
|
|
|
|
mkParams("111", false, true),
|
|
|
|
// Valid cases follow
|
|
|
|
mkParams("", true, false),
|
|
|
|
mkParams("", false, true),
|
|
|
|
mkParams("", false, false),
|
|
|
|
mkParams("111", false, false),
|
|
|
|
}
|
|
|
|
varsArr := []map[string]string{
|
|
|
|
// Invalid cases
|
|
|
|
{string(mgmtPrefix): "objprefix"},
|
|
|
|
// Valid cases
|
|
|
|
{},
|
|
|
|
{string(mgmtBucket): "bucket"},
|
|
|
|
{string(mgmtBucket): "bucket", string(mgmtPrefix): "objprefix"},
|
|
|
|
}
|
|
|
|
|
|
|
|
// Body is always valid - we do not test JSON decoding.
|
|
|
|
body := `{"recursive": false, "dryRun": true, "remove": false, "scanMode": 0}`
|
|
|
|
|
|
|
|
// Test all combinations!
|
|
|
|
for pIdx, parms := range qParmsArr {
|
|
|
|
for vIdx, vars := range varsArr {
|
|
|
|
_, err := extractHealInitParams(vars, parms, bytes.NewBuffer([]byte(body)))
|
|
|
|
isErrCase := false
|
|
|
|
if pIdx < 4 || vIdx < 1 {
|
|
|
|
isErrCase = true
|
|
|
|
}
|
|
|
|
|
|
|
|
if err != ErrNone && !isErrCase {
|
|
|
|
t.Errorf("Got unexpected error: %v %v %v", pIdx, vIdx, err)
|
|
|
|
} else if err == ErrNone && isErrCase {
|
|
|
|
t.Errorf("Got no error but expected one: %v %v", pIdx, vIdx)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|