2016-04-29 05:01:11 +02:00
|
|
|
/*
|
2017-01-18 21:24:34 +01:00
|
|
|
* Minio Cloud Storage, (C) 2015, 2016, 2017 Minio, Inc.
|
2016-04-29 05:01:11 +02:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
2016-08-19 01:23:42 +02:00
|
|
|
package cmd
|
2016-04-29 05:01:11 +02:00
|
|
|
|
|
|
|
import (
|
|
|
|
"bytes"
|
2018-04-06 00:04:40 +02:00
|
|
|
"context"
|
2016-04-29 05:01:11 +02:00
|
|
|
"encoding/xml"
|
|
|
|
"io/ioutil"
|
|
|
|
"net/http"
|
2017-08-13 04:25:43 +02:00
|
|
|
"os"
|
2016-07-23 05:31:45 +02:00
|
|
|
"reflect"
|
2017-03-13 22:41:13 +01:00
|
|
|
"strings"
|
2016-04-29 05:01:11 +02:00
|
|
|
"testing"
|
|
|
|
)
|
|
|
|
|
|
|
|
// Tests validate bucket LocationConstraint.
|
|
|
|
func TestIsValidLocationContraint(t *testing.T) {
|
2018-08-15 06:41:47 +02:00
|
|
|
obj, fsDir, err := prepareFS()
|
2016-07-19 06:20:17 +02:00
|
|
|
if err != nil {
|
2018-08-15 06:41:47 +02:00
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
defer os.RemoveAll(fsDir)
|
|
|
|
if err = newTestConfig(globalMinioDefaultRegion, obj); err != nil {
|
|
|
|
t.Fatal(err)
|
2016-07-19 06:20:17 +02:00
|
|
|
}
|
|
|
|
|
2016-09-20 19:40:46 +02:00
|
|
|
// Test with corrupted XML
|
|
|
|
malformedReq := &http.Request{
|
|
|
|
Body: ioutil.NopCloser(bytes.NewBuffer([]byte("<>"))),
|
|
|
|
ContentLength: int64(len("<>")),
|
|
|
|
}
|
2017-04-03 23:50:09 +02:00
|
|
|
if _, err := parseLocationConstraint(malformedReq); err != ErrMalformedXML {
|
2016-09-20 19:40:46 +02:00
|
|
|
t.Fatal("Unexpected error: ", err)
|
|
|
|
}
|
|
|
|
|
2016-04-29 05:01:11 +02:00
|
|
|
// generates the input request with XML bucket configuration set to the request body.
|
|
|
|
createExpectedRequest := func(req *http.Request, location string) (*http.Request, error) {
|
|
|
|
createBucketConfig := createBucketLocationConfiguration{}
|
|
|
|
createBucketConfig.Location = location
|
|
|
|
var createBucketConfigBytes []byte
|
|
|
|
createBucketConfigBytes, e := xml.Marshal(createBucketConfig)
|
|
|
|
if e != nil {
|
|
|
|
return nil, e
|
|
|
|
}
|
|
|
|
createBucketConfigBuffer := bytes.NewBuffer(createBucketConfigBytes)
|
|
|
|
req.Body = ioutil.NopCloser(createBucketConfigBuffer)
|
2016-07-19 06:20:17 +02:00
|
|
|
req.ContentLength = int64(createBucketConfigBuffer.Len())
|
2016-04-29 05:01:11 +02:00
|
|
|
return req, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
locationForInputRequest string
|
|
|
|
serverConfigRegion string
|
|
|
|
expectedCode APIErrorCode
|
|
|
|
}{
|
|
|
|
// Test case - 1.
|
2017-01-18 21:24:34 +01:00
|
|
|
{globalMinioDefaultRegion, globalMinioDefaultRegion, ErrNone},
|
2016-04-29 05:01:11 +02:00
|
|
|
// Test case - 2.
|
|
|
|
// In case of empty request body ErrNone is returned.
|
2017-01-18 21:24:34 +01:00
|
|
|
{"", globalMinioDefaultRegion, ErrNone},
|
2016-04-29 05:01:11 +02:00
|
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
|
|
inputRequest, e := createExpectedRequest(&http.Request{}, testCase.locationForInputRequest)
|
|
|
|
if e != nil {
|
|
|
|
t.Fatalf("Test %d: Failed to Marshal bucket configuration", i+1)
|
|
|
|
}
|
2017-11-29 22:12:47 +01:00
|
|
|
globalServerConfig.SetRegion(testCase.serverConfigRegion)
|
2017-04-03 23:50:09 +02:00
|
|
|
_, actualCode := parseLocationConstraint(inputRequest)
|
2016-04-29 05:01:11 +02:00
|
|
|
if testCase.expectedCode != actualCode {
|
|
|
|
t.Errorf("Test %d: Expected the APIErrCode to be %d, but instead found %d", i+1, testCase.expectedCode, actualCode)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-07-23 05:31:45 +02:00
|
|
|
|
2017-03-13 22:41:13 +01:00
|
|
|
// Test validate form field size.
|
|
|
|
func TestValidateFormFieldSize(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
header http.Header
|
|
|
|
err error
|
|
|
|
}{
|
|
|
|
// Empty header returns error as nil,
|
|
|
|
{
|
|
|
|
header: nil,
|
|
|
|
err: nil,
|
|
|
|
},
|
|
|
|
// Valid header returns error as nil.
|
|
|
|
{
|
|
|
|
header: http.Header{
|
|
|
|
"Content-Type": []string{"image/png"},
|
|
|
|
},
|
|
|
|
err: nil,
|
|
|
|
},
|
|
|
|
// Invalid header value > maxFormFieldSize+1
|
|
|
|
{
|
|
|
|
header: http.Header{
|
|
|
|
"Garbage": []string{strings.Repeat("a", int(maxFormFieldSize)+1)},
|
|
|
|
},
|
|
|
|
err: errSizeUnexpected,
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
// Run validate form field size check under all test cases.
|
|
|
|
for i, testCase := range testCases {
|
2018-04-06 00:04:40 +02:00
|
|
|
err := validateFormFieldSize(context.Background(), testCase.header)
|
2017-03-13 22:41:13 +01:00
|
|
|
if err != nil {
|
2018-04-10 18:36:37 +02:00
|
|
|
if err.Error() != testCase.err.Error() {
|
2017-03-13 22:41:13 +01:00
|
|
|
t.Errorf("Test %d: Expected error %s, got %s", i+1, testCase.err, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-07-23 05:31:45 +02:00
|
|
|
// Tests validate metadata extraction from http headers.
|
|
|
|
func TestExtractMetadataHeaders(t *testing.T) {
|
|
|
|
testCases := []struct {
|
2017-07-06 01:56:10 +02:00
|
|
|
header http.Header
|
|
|
|
metadata map[string]string
|
|
|
|
shouldFail bool
|
2016-07-23 05:31:45 +02:00
|
|
|
}{
|
|
|
|
// Validate if there a known 'content-type'.
|
|
|
|
{
|
|
|
|
header: http.Header{
|
|
|
|
"Content-Type": []string{"image/png"},
|
|
|
|
},
|
|
|
|
metadata: map[string]string{
|
|
|
|
"content-type": "image/png",
|
|
|
|
},
|
2017-07-06 01:56:10 +02:00
|
|
|
shouldFail: false,
|
2016-07-23 05:31:45 +02:00
|
|
|
},
|
|
|
|
// Validate if there are no keys to extract.
|
|
|
|
{
|
|
|
|
header: http.Header{
|
2017-07-06 01:56:10 +02:00
|
|
|
"Test-1": []string{"123"},
|
2016-07-23 05:31:45 +02:00
|
|
|
},
|
2017-07-06 01:56:10 +02:00
|
|
|
metadata: map[string]string{},
|
|
|
|
shouldFail: false,
|
2016-07-23 05:31:45 +02:00
|
|
|
},
|
2017-07-06 01:56:10 +02:00
|
|
|
// Validate that there are all headers extracted
|
2016-09-20 19:40:46 +02:00
|
|
|
{
|
|
|
|
header: http.Header{
|
|
|
|
"X-Amz-Meta-Appid": []string{"amz-meta"},
|
|
|
|
"X-Minio-Meta-Appid": []string{"minio-meta"},
|
|
|
|
},
|
|
|
|
metadata: map[string]string{
|
|
|
|
"X-Amz-Meta-Appid": "amz-meta",
|
2017-07-06 01:56:10 +02:00
|
|
|
"X-Minio-Meta-Appid": "minio-meta",
|
|
|
|
},
|
|
|
|
shouldFail: false,
|
|
|
|
},
|
|
|
|
// Fail if header key is not in canonicalized form
|
|
|
|
{
|
|
|
|
header: http.Header{
|
|
|
|
"x-amz-meta-appid": []string{"amz-meta"},
|
|
|
|
},
|
|
|
|
metadata: map[string]string{
|
2018-07-11 05:27:10 +02:00
|
|
|
"x-amz-meta-appid": "amz-meta",
|
2017-07-06 01:56:10 +02:00
|
|
|
},
|
2018-07-11 05:27:10 +02:00
|
|
|
shouldFail: false,
|
2016-09-20 19:40:46 +02:00
|
|
|
},
|
2018-11-02 19:32:18 +01:00
|
|
|
// Support multiple values
|
|
|
|
{
|
|
|
|
header: http.Header{
|
|
|
|
"x-amz-meta-key": []string{"amz-meta1", "amz-meta2"},
|
|
|
|
},
|
|
|
|
metadata: map[string]string{
|
|
|
|
"x-amz-meta-key": "amz-meta1,amz-meta2",
|
|
|
|
},
|
|
|
|
shouldFail: false,
|
|
|
|
},
|
2017-03-13 22:41:13 +01:00
|
|
|
// Empty header input returns empty metadata.
|
|
|
|
{
|
2017-07-06 01:56:10 +02:00
|
|
|
header: nil,
|
|
|
|
metadata: nil,
|
|
|
|
shouldFail: true,
|
2017-03-13 22:41:13 +01:00
|
|
|
},
|
2016-07-23 05:31:45 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Validate if the extracting headers.
|
|
|
|
for i, testCase := range testCases {
|
2018-07-11 05:27:10 +02:00
|
|
|
metadata := make(map[string]string)
|
|
|
|
err := extractMetadataFromMap(context.Background(), testCase.header, metadata)
|
2017-07-06 01:56:10 +02:00
|
|
|
if err != nil && !testCase.shouldFail {
|
|
|
|
t.Fatalf("Test %d failed to extract metadata: %v", i+1, err)
|
|
|
|
}
|
|
|
|
if err == nil && testCase.shouldFail {
|
|
|
|
t.Fatalf("Test %d should fail, but it passed", i+1)
|
|
|
|
}
|
|
|
|
if err == nil && !reflect.DeepEqual(metadata, testCase.metadata) {
|
2016-07-23 05:31:45 +02:00
|
|
|
t.Fatalf("Test %d failed: Expected \"%#v\", got \"%#v\"", i+1, testCase.metadata, metadata)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2017-11-15 01:56:24 +01:00
|
|
|
|
|
|
|
// Test getResource()
|
|
|
|
func TestGetResource(t *testing.T) {
|
|
|
|
testCases := []struct {
|
|
|
|
p string
|
|
|
|
host string
|
|
|
|
domain string
|
|
|
|
expectedResource string
|
|
|
|
}{
|
|
|
|
{"/a/b/c", "test.mydomain.com", "mydomain.com", "/test/a/b/c"},
|
|
|
|
{"/a/b/c", "test.mydomain.com", "notmydomain.com", "/a/b/c"},
|
|
|
|
{"/a/b/c", "test.mydomain.com", "", "/a/b/c"},
|
|
|
|
}
|
|
|
|
for i, test := range testCases {
|
|
|
|
gotResource, err := getResource(test.p, test.host, test.domain)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if gotResource != test.expectedResource {
|
|
|
|
t.Fatalf("test %d: expected %s got %s", i+1, test.expectedResource, gotResource)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|