2016-08-16 01:13:03 +02:00
|
|
|
/*
|
2019-04-09 20:39:42 +02:00
|
|
|
* MinIO Cloud Storage, (C) 2016, 2017, 2018 MinIO, Inc.
|
2016-08-16 01:13:03 +02:00
|
|
|
*
|
|
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
* you may not use this file except in compliance with the License.
|
|
|
|
* You may obtain a copy of the License at
|
|
|
|
*
|
|
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
*
|
|
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
* See the License for the specific language governing permissions and
|
|
|
|
* limitations under the License.
|
|
|
|
*/
|
|
|
|
|
2016-08-19 01:23:42 +02:00
|
|
|
package cmd
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
import (
|
2017-02-09 08:39:08 +01:00
|
|
|
"archive/zip"
|
2016-08-16 01:13:03 +02:00
|
|
|
"bytes"
|
2018-03-15 21:27:16 +01:00
|
|
|
"context"
|
2017-02-09 08:39:08 +01:00
|
|
|
"crypto/md5"
|
|
|
|
"encoding/hex"
|
|
|
|
"encoding/json"
|
2017-01-11 22:26:42 +01:00
|
|
|
"fmt"
|
2017-02-09 08:39:08 +01:00
|
|
|
"io"
|
2016-08-16 01:13:03 +02:00
|
|
|
"io/ioutil"
|
|
|
|
"net/http"
|
|
|
|
"net/http/httptest"
|
2016-09-23 08:06:45 +02:00
|
|
|
"reflect"
|
2016-08-16 01:13:03 +02:00
|
|
|
"strconv"
|
2016-09-23 01:35:12 +02:00
|
|
|
"strings"
|
2016-08-16 01:13:03 +02:00
|
|
|
"testing"
|
2016-08-30 19:04:50 +02:00
|
|
|
|
2017-09-19 21:37:56 +02:00
|
|
|
jwtgo "github.com/dgrijalva/jwt-go"
|
2016-11-23 03:18:22 +01:00
|
|
|
humanize "github.com/dustin/go-humanize"
|
2019-05-30 01:35:12 +02:00
|
|
|
miniogopolicy "github.com/minio/minio-go/v6/pkg/policy"
|
2020-01-31 03:59:22 +01:00
|
|
|
xjwt "github.com/minio/minio/cmd/jwt"
|
2019-10-23 07:59:13 +02:00
|
|
|
"github.com/minio/minio/pkg/auth"
|
2020-01-27 23:12:34 +01:00
|
|
|
"github.com/minio/minio/pkg/bucket/policy"
|
|
|
|
"github.com/minio/minio/pkg/bucket/policy/condition"
|
2017-10-22 07:30:34 +02:00
|
|
|
"github.com/minio/minio/pkg/hash"
|
2019-10-23 07:59:13 +02:00
|
|
|
"github.com/minio/minio/pkg/madmin"
|
2016-08-16 01:13:03 +02:00
|
|
|
)
|
|
|
|
|
2018-03-15 21:03:41 +01:00
|
|
|
// Implement a dummy flush writer.
|
|
|
|
type flushWriter struct {
|
|
|
|
io.Writer
|
|
|
|
}
|
|
|
|
|
|
|
|
// Flush writer is a dummy writer compatible with http.Flusher and http.ResponseWriter.
|
|
|
|
func (f *flushWriter) Flush() {}
|
|
|
|
func (f *flushWriter) Write(b []byte) (n int, err error) { return f.Writer.Write(b) }
|
|
|
|
func (f *flushWriter) Header() http.Header { return http.Header{} }
|
|
|
|
func (f *flushWriter) WriteHeader(code int) {}
|
|
|
|
|
|
|
|
func newFlushWriter(writer io.Writer) http.ResponseWriter {
|
|
|
|
return &flushWriter{writer}
|
|
|
|
}
|
|
|
|
|
2016-11-02 22:45:11 +01:00
|
|
|
// Tests private function writeWebErrorResponse.
|
|
|
|
func TestWriteWebErrorResponse(t *testing.T) {
|
|
|
|
var buffer bytes.Buffer
|
|
|
|
testCases := []struct {
|
|
|
|
webErr error
|
|
|
|
apiErrCode APIErrorCode
|
|
|
|
}{
|
|
|
|
// List of various errors and their corresponding API errors.
|
|
|
|
{
|
|
|
|
webErr: StorageFull{},
|
|
|
|
apiErrCode: ErrStorageFull,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: BucketNotFound{},
|
|
|
|
apiErrCode: ErrNoSuchBucket,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: BucketNameInvalid{},
|
|
|
|
apiErrCode: ErrInvalidBucketName,
|
|
|
|
},
|
|
|
|
{
|
2017-10-22 07:30:34 +02:00
|
|
|
webErr: hash.BadDigest{},
|
2016-11-02 22:45:11 +01:00
|
|
|
apiErrCode: ErrBadDigest,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: IncompleteBody{},
|
|
|
|
apiErrCode: ErrIncompleteBody,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: ObjectExistsAsDirectory{},
|
|
|
|
apiErrCode: ErrObjectExistsAsDirectory,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: ObjectNotFound{},
|
|
|
|
apiErrCode: ErrNoSuchKey,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: ObjectNameInvalid{},
|
|
|
|
apiErrCode: ErrNoSuchKey,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: InsufficientWriteQuorum{},
|
|
|
|
apiErrCode: ErrWriteQuorum,
|
|
|
|
},
|
|
|
|
{
|
|
|
|
webErr: InsufficientReadQuorum{},
|
|
|
|
apiErrCode: ErrReadQuorum,
|
|
|
|
},
|
2017-06-08 04:31:23 +02:00
|
|
|
{
|
|
|
|
webErr: NotImplemented{},
|
|
|
|
apiErrCode: ErrNotImplemented,
|
|
|
|
},
|
2016-11-02 22:45:11 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// Validate all the test cases.
|
|
|
|
for i, testCase := range testCases {
|
|
|
|
writeWebErrorResponse(newFlushWriter(&buffer), testCase.webErr)
|
|
|
|
desc := getAPIError(testCase.apiErrCode).Description
|
2017-06-08 04:31:23 +02:00
|
|
|
if testCase.apiErrCode == ErrNotImplemented {
|
|
|
|
desc = "Functionality not implemented"
|
|
|
|
}
|
2016-11-02 22:45:11 +01:00
|
|
|
recvDesc := buffer.Bytes()
|
|
|
|
// Check if the written desc is same as the one expected.
|
|
|
|
if !bytes.Equal(recvDesc, []byte(desc)) {
|
2019-02-13 13:59:36 +01:00
|
|
|
t.Errorf("Test %d: Unexpected response, expecting %s, got %s", i+1, desc, buffer.String())
|
2016-11-02 22:45:11 +01:00
|
|
|
}
|
|
|
|
buffer.Reset()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-08-16 01:13:03 +02:00
|
|
|
// Authenticate and get JWT token - will be called before every webrpc handler invocation
|
|
|
|
func getWebRPCToken(apiRouter http.Handler, accessKey, secretKey string) (token string, err error) {
|
2018-06-06 10:51:56 +02:00
|
|
|
return authenticateWeb(accessKey, secretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling Login Web Handler
|
|
|
|
func TestWebHandlerLogin(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testLoginWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testLoginWebHandler - Test login web handler
|
|
|
|
func testLoginWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
// test cases with sample input and expected output.
|
|
|
|
testCases := []struct {
|
|
|
|
username string
|
|
|
|
password string
|
|
|
|
success bool
|
|
|
|
}{
|
|
|
|
{"", "", false},
|
|
|
|
{"azerty", "foo", false},
|
|
|
|
{"", "foo", false},
|
|
|
|
{"azerty", "", false},
|
|
|
|
{"azerty", "foo", false},
|
2017-01-03 10:33:00 +01:00
|
|
|
{"azerty", "azerty123", false},
|
2016-12-26 19:21:23 +01:00
|
|
|
{credentials.AccessKey, credentials.SecretKey, true},
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Iterating over the test cases, calling the function under test and asserting the response.
|
|
|
|
for i, testCase := range testCases {
|
|
|
|
_, err := getWebRPCToken(apiRouter, testCase.username, testCase.password)
|
|
|
|
if err != nil && testCase.success {
|
|
|
|
t.Fatalf("Test %d: Expected to succeed but it failed, %v", i+1, err)
|
|
|
|
}
|
|
|
|
if err == nil && !testCase.success {
|
|
|
|
t.Fatalf("Test %d: Expected to fail but it didn't, %v", i+1, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling StorageInfo Web Handler
|
|
|
|
func TestWebHandlerStorageInfo(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testStorageInfoWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testStorageInfoWebHandler - Test StorageInfo web handler
|
|
|
|
func testStorageInfoWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// get random bucket name.
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
2019-04-18 08:16:27 +02:00
|
|
|
storageInfoRequest := &WebGenericArgs{}
|
2016-08-16 01:13:03 +02:00
|
|
|
storageInfoReply := &StorageInfoRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.StorageInfo", authorization, storageInfoRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
2018-05-24 02:30:25 +02:00
|
|
|
if err = getTestWebRPCResponse(rec, &storageInfoReply); err != nil {
|
2016-08-16 01:13:03 +02:00
|
|
|
t.Fatalf("Failed %v", err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling ServerInfo Web Handler
|
|
|
|
func TestWebHandlerServerInfo(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testServerInfoWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testServerInfoWebHandler - Test ServerInfo web handler
|
|
|
|
func testServerInfoWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
2019-04-18 08:16:27 +02:00
|
|
|
serverInfoRequest := &WebGenericArgs{}
|
2016-08-16 01:13:03 +02:00
|
|
|
serverInfoReply := &ServerInfoRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.ServerInfo", authorization, serverInfoRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &serverInfoReply)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
2016-08-19 01:23:42 +02:00
|
|
|
if serverInfoReply.MinioVersion != Version {
|
2016-08-16 01:13:03 +02:00
|
|
|
t.Fatalf("Cannot get minio version from server info handler")
|
|
|
|
}
|
2020-05-02 08:55:53 +02:00
|
|
|
serverInfoReply.MinioGlobalInfo["domains"] = []string(nil)
|
2017-05-25 06:09:23 +02:00
|
|
|
globalInfo := getGlobalInfo()
|
|
|
|
if !reflect.DeepEqual(serverInfoReply.MinioGlobalInfo, globalInfo) {
|
|
|
|
t.Fatalf("Global info did not match got %#v, expected %#v", serverInfoReply.MinioGlobalInfo, globalInfo)
|
|
|
|
}
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling MakeBucket Web Handler
|
|
|
|
func TestWebHandlerMakeBucket(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testMakeBucketWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testMakeBucketWebHandler - Test MakeBucket web handler
|
|
|
|
func testMakeBucketWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
bucketName string
|
|
|
|
success bool
|
|
|
|
}{
|
|
|
|
{"", false},
|
|
|
|
{".", false},
|
|
|
|
{"ab", false},
|
2017-03-03 12:01:42 +01:00
|
|
|
{"minio", false},
|
2017-06-13 02:40:28 +02:00
|
|
|
{minioMetaBucket, false},
|
2016-08-16 01:13:03 +02:00
|
|
|
{bucketName, true},
|
|
|
|
}
|
|
|
|
|
|
|
|
for i, testCase := range testCases {
|
|
|
|
makeBucketRequest := MakeBucketArgs{BucketName: testCase.bucketName}
|
|
|
|
makeBucketReply := &WebGenericRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.MakeBucket", authorization, makeBucketRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Test %d: Failed to create HTTP request: <ERROR> %v", i+1, err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Test %d: Expected the response status to be 200, but instead found `%d`", i+1, rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &makeBucketReply)
|
|
|
|
if testCase.success && err != nil {
|
|
|
|
t.Fatalf("Test %d: Should succeed but it didn't, %v", i+1, err)
|
|
|
|
}
|
|
|
|
if !testCase.success && err == nil {
|
|
|
|
t.Fatalf("Test %d: Should fail but it didn't (%s)", i+1, testCase.bucketName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-12-29 14:15:44 +01:00
|
|
|
// Wrapper for calling DeleteBucket handler
|
|
|
|
func TestWebHandlerDeleteBucket(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testDeleteBucketWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testDeleteBucketWebHandler - Test DeleteBucket web handler
|
|
|
|
func testDeleteBucketWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
|
|
|
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2017-12-29 14:15:44 +01:00
|
|
|
token, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("could not get RPC token, %s", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
2018-09-10 18:42:43 +02:00
|
|
|
var opts ObjectOptions
|
|
|
|
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2017-12-29 14:15:44 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("failed to create bucket: %s (%s)", err.Error(), instanceType)
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
bucketName string
|
|
|
|
// Whether or not to put an object into the bucket.
|
|
|
|
initWithObject bool
|
|
|
|
token string
|
|
|
|
// Expected error (error must only contain this string to pass test)
|
|
|
|
// Empty string = no error
|
|
|
|
expect string
|
|
|
|
}{
|
2019-04-04 08:10:37 +02:00
|
|
|
{"", false, token, "The specified bucket is not valid"},
|
2017-12-29 14:15:44 +01:00
|
|
|
{".", false, "auth", "Authentication failed"},
|
2019-04-04 08:10:37 +02:00
|
|
|
{".", false, token, "The specified bucket is not valid"},
|
|
|
|
{"..", false, token, "The specified bucket is not valid"},
|
|
|
|
{"ab", false, token, "The specified bucket is not valid"},
|
2017-12-29 14:15:44 +01:00
|
|
|
{"minio", false, "false token", "Authentication failed"},
|
2019-04-04 08:10:37 +02:00
|
|
|
{"minio", false, token, "The specified bucket is not valid"},
|
2017-12-29 14:15:44 +01:00
|
|
|
{bucketName, false, token, ""},
|
2019-08-21 22:01:46 +02:00
|
|
|
{bucketName, true, token, "The bucket you tried to delete is not empty"},
|
2018-10-18 01:23:09 +02:00
|
|
|
{bucketName, false, "", "JWT token missing"},
|
2017-12-29 14:15:44 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
for _, test := range testCases {
|
|
|
|
if test.initWithObject {
|
|
|
|
data := bytes.NewBufferString("hello")
|
2019-02-09 06:31:06 +01:00
|
|
|
_, err = obj.PutObject(context.Background(), test.bucketName, "object", mustGetPutObjReader(t, data, int64(data.Len()), "", ""), opts)
|
2017-12-29 14:15:44 +01:00
|
|
|
// _, err = obj.PutObject(test.bucketName, "object", int64(data.Len()), data, nil, "")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("could not put object to %s, %s", test.bucketName, err.Error())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
makeBucketRequest := MakeBucketArgs{BucketName: test.bucketName}
|
|
|
|
makeBucketReply := &WebGenericRep{}
|
|
|
|
|
|
|
|
req, err := newTestWebRPCRequest("Web.DeleteBucket", test.token, makeBucketRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Errorf("expected the response status to be `%d`, but instead found `%d`", http.StatusOK, rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &makeBucketReply)
|
|
|
|
|
|
|
|
if test.expect != "" {
|
|
|
|
if err == nil {
|
|
|
|
// If we expected an error, but didn't get one.
|
|
|
|
t.Errorf("expected `..%s..` but got nil error", test.expect)
|
|
|
|
} else if !strings.Contains(err.Error(), test.expect) {
|
|
|
|
// If we got an error that wasn't what we expected.
|
|
|
|
t.Errorf("expected `..%s..` but got `%s`", test.expect, err.Error())
|
|
|
|
}
|
|
|
|
} else if test.expect == "" && err != nil {
|
|
|
|
t.Errorf("expected test success, but got `%s`", err.Error())
|
|
|
|
}
|
|
|
|
|
|
|
|
// If we created the bucket with an object, now delete the object to cleanup.
|
|
|
|
if test.initWithObject {
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.DeleteObject(context.Background(), test.bucketName, "object")
|
2017-12-29 14:15:44 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("could not delete object, %s", err.Error())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// If it did not succeed in deleting the bucket, don't try and recreate it.
|
|
|
|
// Or, it'll fail if there was an object.
|
|
|
|
if err != nil || test.initWithObject {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2017-12-29 14:15:44 +01:00
|
|
|
if err != nil {
|
|
|
|
// failed to create new bucket, abort.
|
|
|
|
t.Fatalf("failed to create new bucket (%s): %s", instanceType, err.Error())
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-08-16 01:13:03 +02:00
|
|
|
// Wrapper for calling ListBuckets Web Handler
|
|
|
|
func TestWebHandlerListBuckets(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testListBucketsWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testListBucketsHandler - Test ListBuckets web handler
|
|
|
|
func testListBucketsWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
listBucketsRequest := WebGenericArgs{}
|
|
|
|
listBucketsReply := &ListBucketsRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.ListBuckets", authorization, listBucketsRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &listBucketsReply)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
|
|
|
if len(listBucketsReply.Buckets) == 0 {
|
|
|
|
t.Fatalf("Cannot find the bucket already created by MakeBucket")
|
|
|
|
}
|
|
|
|
if listBucketsReply.Buckets[0].Name != bucketName {
|
2020-03-19 00:19:29 +01:00
|
|
|
t.Fatalf("Found another bucket %q other than already created by MakeBucket", listBucketsReply.Buckets[0].Name)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling ListObjects Web Handler
|
|
|
|
func TestWebHandlerListObjects(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testListObjectsWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testListObjectsHandler - Test ListObjects web handler
|
|
|
|
func testListObjectsWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
|
|
|
objectName := "object"
|
2016-11-23 03:18:22 +01:00
|
|
|
objectSize := 1 * humanize.KiByte
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
data := bytes.Repeat([]byte("a"), objectSize)
|
2017-09-19 21:40:27 +02:00
|
|
|
metadata := map[string]string{"etag": "c9a34cfc85d982698c6ac89f76071abd"}
|
2019-02-09 06:31:06 +01:00
|
|
|
_, err = obj.PutObject(context.Background(), bucketName, objectName, mustGetPutObjReader(t, bytes.NewReader(data), int64(len(data)), metadata["etag"], ""), ObjectOptions{UserDefined: metadata})
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Was not able to upload an object, %v", err)
|
|
|
|
}
|
|
|
|
|
2019-02-13 13:59:36 +01:00
|
|
|
test := func(token string) (*ListObjectsRep, error) {
|
2017-01-11 22:26:42 +01:00
|
|
|
listObjectsRequest := ListObjectsArgs{BucketName: bucketName, Prefix: ""}
|
|
|
|
listObjectsReply := &ListObjectsRep{}
|
|
|
|
var req *http.Request
|
|
|
|
req, err = newTestWebRPCRequest("Web.ListObjects", token, listObjectsRequest)
|
|
|
|
if err != nil {
|
2019-02-13 13:59:36 +01:00
|
|
|
return nil, err
|
2017-01-11 22:26:42 +01:00
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
2019-02-13 13:59:36 +01:00
|
|
|
return listObjectsReply, fmt.Errorf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
2017-01-11 22:26:42 +01:00
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &listObjectsReply)
|
|
|
|
if err != nil {
|
2019-02-13 13:59:36 +01:00
|
|
|
return listObjectsReply, err
|
2017-01-11 22:26:42 +01:00
|
|
|
}
|
2019-02-13 13:59:36 +01:00
|
|
|
return listObjectsReply, nil
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
2017-01-11 22:26:42 +01:00
|
|
|
verifyReply := func(reply *ListObjectsRep) {
|
|
|
|
if len(reply.Objects) == 0 {
|
|
|
|
t.Fatalf("Cannot find the object")
|
|
|
|
}
|
|
|
|
if reply.Objects[0].Key != objectName {
|
|
|
|
t.Fatalf("Found another object other than already created by PutObject")
|
|
|
|
}
|
|
|
|
if reply.Objects[0].Size != int64(objectSize) {
|
|
|
|
t.Fatalf("Found a object with the same name but with a different size")
|
|
|
|
}
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
2017-01-11 22:26:42 +01:00
|
|
|
|
|
|
|
// Authenticated ListObjects should succeed.
|
2019-02-13 13:59:36 +01:00
|
|
|
reply, err := test(authorization)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
2017-01-11 22:26:42 +01:00
|
|
|
t.Fatal(err)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
2017-01-11 22:26:42 +01:00
|
|
|
verifyReply(reply)
|
|
|
|
|
|
|
|
// Unauthenticated ListObjects should fail.
|
2019-02-13 13:59:36 +01:00
|
|
|
_, err = test("")
|
2017-01-11 22:26:42 +01:00
|
|
|
if err == nil {
|
|
|
|
t.Fatalf("Expected error `%s`", err)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
2017-01-11 22:26:42 +01:00
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
bucketPolicy := &policy.Policy{
|
|
|
|
Version: policy.DefaultVersion,
|
|
|
|
Statements: []policy.Statement{policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
2018-12-14 05:15:09 +01:00
|
|
|
policy.NewActionSet(policy.ListBucketAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "")),
|
2018-04-25 00:53:30 +02:00
|
|
|
condition.NewFunctions(),
|
|
|
|
)},
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
if err = obj.SetBucketPolicy(context.Background(), bucketName, bucketPolicy); err != nil {
|
|
|
|
t.Fatalf("unexpected error. %v", err)
|
|
|
|
}
|
2020-05-04 18:42:58 +02:00
|
|
|
globalPolicySys.Set(bucketName, bucketPolicy)
|
2018-04-25 00:53:30 +02:00
|
|
|
defer globalPolicySys.Remove(bucketName)
|
2017-01-11 22:26:42 +01:00
|
|
|
|
|
|
|
// Unauthenticated ListObjects with READ bucket policy should succeed.
|
2019-02-13 13:59:36 +01:00
|
|
|
reply, err = test("")
|
2017-01-11 22:26:42 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
verifyReply(reply)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling RemoveObject Web Handler
|
|
|
|
func TestWebHandlerRemoveObject(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testRemoveObjectWebHandler)
|
|
|
|
}
|
|
|
|
|
2017-04-27 08:27:48 +02:00
|
|
|
// testRemoveObjectWebHandler - Test RemoveObjectObject web handler
|
2016-08-16 01:13:03 +02:00
|
|
|
func testRemoveObjectWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
|
|
|
objectName := "object"
|
2016-11-23 03:18:22 +01:00
|
|
|
objectSize := 1 * humanize.KiByte
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
data := bytes.Repeat([]byte("a"), objectSize)
|
2017-09-19 21:40:27 +02:00
|
|
|
metadata := map[string]string{"etag": "c9a34cfc85d982698c6ac89f76071abd"}
|
2019-02-09 06:31:06 +01:00
|
|
|
_, err = obj.PutObject(context.Background(), bucketName, objectName, mustGetPutObjReader(t, bytes.NewReader(data), int64(len(data)), metadata["etag"], ""), ObjectOptions{UserDefined: metadata})
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Was not able to upload an object, %v", err)
|
|
|
|
}
|
|
|
|
|
2017-03-01 04:07:28 +01:00
|
|
|
objectName = "a/object"
|
2017-09-19 21:40:27 +02:00
|
|
|
metadata = map[string]string{"etag": "c9a34cfc85d982698c6ac89f76071abd"}
|
2019-02-09 06:31:06 +01:00
|
|
|
_, err = obj.PutObject(context.Background(), bucketName, objectName, mustGetPutObjReader(t, bytes.NewReader(data), int64(len(data)), metadata["etag"], ""), ObjectOptions{UserDefined: metadata})
|
2017-03-01 04:07:28 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Was not able to upload an object, %v", err)
|
|
|
|
}
|
|
|
|
|
2017-04-27 08:27:48 +02:00
|
|
|
removeRequest := RemoveObjectArgs{BucketName: bucketName, Objects: []string{"a/", "object"}}
|
|
|
|
removeReply := &WebGenericRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.RemoveObject", authorization, removeRequest)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
2017-04-27 08:27:48 +02:00
|
|
|
err = getTestWebRPCResponse(rec, &removeReply)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
2016-11-22 20:12:38 +01:00
|
|
|
|
2017-04-27 08:27:48 +02:00
|
|
|
removeRequest = RemoveObjectArgs{BucketName: bucketName, Objects: []string{"a/", "object"}}
|
|
|
|
removeReply = &WebGenericRep{}
|
|
|
|
req, err = newTestWebRPCRequest("Web.RemoveObject", authorization, removeRequest)
|
2016-11-22 20:12:38 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
2017-04-27 08:27:48 +02:00
|
|
|
err = getTestWebRPCResponse(rec, &removeReply)
|
2016-11-22 20:12:38 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
2017-04-27 08:27:48 +02:00
|
|
|
|
|
|
|
removeRequest = RemoveObjectArgs{BucketName: bucketName}
|
|
|
|
removeReply = &WebGenericRep{}
|
|
|
|
req, err = newTestWebRPCRequest("Web.RemoveObject", authorization, removeRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
b, err := ioutil.ReadAll(rec.Body)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
if !bytes.Contains(b, []byte("Invalid arguments specified")) {
|
|
|
|
t.Fatalf("Expected response wrong %s", string(b))
|
|
|
|
}
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling Generate Auth Handler
|
|
|
|
func TestWebHandlerGenerateAuth(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testGenerateAuthWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testGenerateAuthWebHandler - Test GenerateAuth web handler
|
|
|
|
func testGenerateAuthWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
generateAuthRequest := WebGenericArgs{}
|
|
|
|
generateAuthReply := &GenerateAuthReply{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.GenerateAuth", authorization, generateAuthRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &generateAuthReply)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
if generateAuthReply.AccessKey == "" || generateAuthReply.SecretKey == "" {
|
|
|
|
t.Fatalf("Failed to generate auth keys")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Wrapper for calling Set Auth Handler
|
|
|
|
func TestWebHandlerSetAuth(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testSetAuthWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testSetAuthWebHandler - Test SetAuth web handler
|
|
|
|
func testSetAuthWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials, err := auth.GetNewCredentials()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
globalIAMSys.SetUser(credentials.AccessKey, madmin.UserInfo{
|
|
|
|
SecretKey: credentials.SecretKey,
|
|
|
|
Status: madmin.AccountEnabled,
|
|
|
|
})
|
2016-08-16 01:13:03 +02:00
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
2019-05-29 22:18:46 +02:00
|
|
|
currentAccessKey string
|
|
|
|
currentSecretKey string
|
|
|
|
newAccessKey string
|
|
|
|
newSecretKey string
|
|
|
|
success bool
|
2016-08-16 01:13:03 +02:00
|
|
|
}{
|
2019-05-29 22:18:46 +02:00
|
|
|
{"", "", "", "", false},
|
|
|
|
{"1", "1", "1", "1", false},
|
2019-05-30 14:14:35 +02:00
|
|
|
{credentials.AccessKey, credentials.SecretKey, "azerty", "bar", false},
|
2019-05-29 22:18:46 +02:00
|
|
|
{credentials.AccessKey, credentials.SecretKey, "azerty", "foooooooooooooo", true},
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Iterating over the test cases, calling the function under test and asserting the response.
|
|
|
|
for i, testCase := range testCases {
|
2019-05-29 22:18:46 +02:00
|
|
|
setAuthRequest := SetAuthArgs{CurrentAccessKey: testCase.currentAccessKey, CurrentSecretKey: testCase.currentSecretKey, NewAccessKey: testCase.newAccessKey, NewSecretKey: testCase.newSecretKey}
|
2016-08-16 01:13:03 +02:00
|
|
|
setAuthReply := &SetAuthReply{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.SetAuth", authorization, setAuthRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Test %d: Failed to create HTTP request: <ERROR> %v", i+1, err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Test %d: Expected the response status to be 200, but instead found `%d`", i+1, rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &setAuthReply)
|
|
|
|
if testCase.success && err != nil {
|
|
|
|
t.Fatalf("Test %d: Supposed to succeed but failed, %v", i+1, err)
|
|
|
|
}
|
|
|
|
if !testCase.success && err == nil {
|
|
|
|
t.Fatalf("Test %d: Supposed to fail but succeeded, %v", i+1, err)
|
|
|
|
}
|
|
|
|
if testCase.success && setAuthReply.Token == "" {
|
|
|
|
t.Fatalf("Test %d: Failed to set auth keys", i+1)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-07-24 21:46:37 +02:00
|
|
|
func TestWebCreateURLToken(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testCreateURLToken)
|
|
|
|
}
|
|
|
|
|
2017-09-19 21:37:56 +02:00
|
|
|
func getTokenString(accessKey, secretKey string) (string, error) {
|
2020-01-31 03:59:22 +01:00
|
|
|
claims := xjwt.NewMapClaims()
|
|
|
|
claims.SetExpiry(UTCNow().Add(defaultJWTExpiry))
|
|
|
|
claims.SetAccessKey(accessKey)
|
|
|
|
token := jwtgo.NewWithClaims(jwtgo.SigningMethodHS512, claims)
|
2017-09-19 21:37:56 +02:00
|
|
|
return token.SignedString([]byte(secretKey))
|
|
|
|
}
|
|
|
|
|
2017-07-24 21:46:37 +02:00
|
|
|
func testCreateURLToken(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2017-07-24 21:46:37 +02:00
|
|
|
|
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
args := WebGenericArgs{}
|
|
|
|
tokenReply := &URLTokenReply{}
|
|
|
|
|
|
|
|
req, err := newTestWebRPCRequest("Web.CreateURLToken", authorization, args)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
|
|
|
|
err = getTestWebRPCResponse(rec, &tokenReply)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Ensure the token is valid now. It will expire later.
|
|
|
|
if !isAuthTokenValid(tokenReply.Token) {
|
|
|
|
t.Fatalf("token is not valid")
|
|
|
|
}
|
2017-09-19 21:37:56 +02:00
|
|
|
|
|
|
|
// Token is invalid.
|
|
|
|
if isAuthTokenValid("") {
|
|
|
|
t.Fatalf("token shouldn't be valid, but it is")
|
|
|
|
}
|
|
|
|
|
|
|
|
token, err := getTokenString("invalid-access", credentials.SecretKey)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Token has invalid access key.
|
|
|
|
if isAuthTokenValid(token) {
|
|
|
|
t.Fatalf("token shouldn't be valid, but it is")
|
|
|
|
}
|
2017-07-24 21:46:37 +02:00
|
|
|
}
|
|
|
|
|
2016-08-16 01:13:03 +02:00
|
|
|
// Wrapper for calling Upload Handler
|
|
|
|
func TestWebHandlerUpload(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testUploadWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testUploadWebHandler - Test Upload web handler
|
|
|
|
func testUploadWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2017-02-07 21:51:43 +01:00
|
|
|
content := []byte("temporary file's content")
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
objectName := "test.file"
|
|
|
|
bucketName := getRandomBucketName()
|
2017-01-11 22:26:42 +01:00
|
|
|
|
2017-02-02 19:45:00 +01:00
|
|
|
test := func(token string, sendContentLength bool) int {
|
2017-01-11 22:26:42 +01:00
|
|
|
rec := httptest.NewRecorder()
|
2019-08-06 21:08:58 +02:00
|
|
|
req, rErr := http.NewRequest("PUT", "/minio/upload/"+bucketName+SlashSeparator+objectName, nil)
|
2017-02-02 19:45:00 +01:00
|
|
|
if rErr != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", rErr)
|
2017-01-11 22:26:42 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
req.Header.Set("x-amz-date", "20160814T114029Z")
|
|
|
|
req.Header.Set("Accept", "*/*")
|
2019-08-13 02:05:30 +02:00
|
|
|
req.Header.Set("User-Agent", "Mozilla")
|
2017-02-02 19:45:00 +01:00
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
req.Body = ioutil.NopCloser(bytes.NewReader(content))
|
|
|
|
|
2017-02-02 19:45:00 +01:00
|
|
|
if !sendContentLength {
|
|
|
|
req.ContentLength = -1
|
|
|
|
} else {
|
|
|
|
req.ContentLength = int64(len(content))
|
|
|
|
}
|
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
if token != "" {
|
|
|
|
req.Header.Set("Authorization", "Bearer "+authorization)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
return rec.Code
|
|
|
|
}
|
2016-08-16 01:13:03 +02:00
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
// Authenticated upload should succeed.
|
2017-02-02 19:45:00 +01:00
|
|
|
code := test(authorization, true)
|
2017-01-11 22:26:42 +01:00
|
|
|
if code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", code)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
var byteBuffer bytes.Buffer
|
2018-09-10 18:42:43 +02:00
|
|
|
err = obj.GetObject(context.Background(), bucketName, objectName, 0, int64(len(content)), &byteBuffer, "", ObjectOptions{})
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
|
|
|
|
2017-03-08 19:00:47 +01:00
|
|
|
if !bytes.Equal(byteBuffer.Bytes(), content) {
|
2016-08-16 01:13:03 +02:00
|
|
|
t.Fatalf("The upload file is different from the download file")
|
|
|
|
}
|
2017-01-11 22:26:42 +01:00
|
|
|
|
2017-02-02 19:45:00 +01:00
|
|
|
// Authenticated upload without content-length should fail
|
|
|
|
code = test(authorization, false)
|
|
|
|
if code != http.StatusBadRequest {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", code)
|
|
|
|
}
|
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
// Unauthenticated upload should fail.
|
2017-02-02 19:45:00 +01:00
|
|
|
code = test("", true)
|
2017-01-11 22:26:42 +01:00
|
|
|
if code != http.StatusForbidden {
|
|
|
|
t.Fatalf("Expected the response status to be 403, but instead found `%d`", code)
|
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
bucketPolicy := &policy.Policy{
|
|
|
|
Version: policy.DefaultVersion,
|
|
|
|
Statements: []policy.Statement{policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.PutObjectAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "*")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
)},
|
2017-01-11 22:26:42 +01:00
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
if err := obj.SetBucketPolicy(context.Background(), bucketName, bucketPolicy); err != nil {
|
|
|
|
t.Fatalf("unexpected error. %v", err)
|
|
|
|
}
|
2020-05-04 18:42:58 +02:00
|
|
|
globalPolicySys.Set(bucketName, bucketPolicy)
|
2018-04-25 00:53:30 +02:00
|
|
|
defer globalPolicySys.Remove(bucketName)
|
2017-01-11 22:26:42 +01:00
|
|
|
|
|
|
|
// Unauthenticated upload with WRITE policy should succeed.
|
2017-02-02 19:45:00 +01:00
|
|
|
code = test("", true)
|
2017-01-11 22:26:42 +01:00
|
|
|
if code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", code)
|
|
|
|
}
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
2017-02-02 19:45:00 +01:00
|
|
|
// Wrapper for calling Download Handler
|
2016-08-16 01:13:03 +02:00
|
|
|
func TestWebHandlerDownload(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testDownloadWebHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testDownloadWebHandler - Test Download web handler
|
|
|
|
func testDownloadWebHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
objectName := "test.file"
|
|
|
|
bucketName := getRandomBucketName()
|
2017-01-11 22:26:42 +01:00
|
|
|
|
|
|
|
test := func(token string) (int, []byte) {
|
|
|
|
rec := httptest.NewRecorder()
|
2019-08-06 21:08:58 +02:00
|
|
|
path := "/minio/download/" + bucketName + SlashSeparator + objectName + "?token="
|
2017-01-11 22:26:42 +01:00
|
|
|
if token != "" {
|
|
|
|
path = path + token
|
|
|
|
}
|
|
|
|
var req *http.Request
|
|
|
|
req, err = http.NewRequest("GET", path, nil)
|
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", err)
|
|
|
|
}
|
|
|
|
|
2019-08-13 02:05:30 +02:00
|
|
|
req.Header.Set("User-Agent", "Mozilla")
|
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
return rec.Code, rec.Body.Bytes()
|
|
|
|
}
|
|
|
|
|
2016-08-16 01:13:03 +02:00
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
content := []byte("temporary file's content")
|
2017-09-19 21:40:27 +02:00
|
|
|
metadata := map[string]string{"etag": "01ce59706106fe5e02e7f55fffda7f34"}
|
2019-02-09 06:31:06 +01:00
|
|
|
_, err = obj.PutObject(context.Background(), bucketName, objectName, mustGetPutObjReader(t, bytes.NewReader(content), int64(len(content)), metadata["etag"], ""), ObjectOptions{UserDefined: metadata})
|
2016-08-16 01:13:03 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Was not able to upload an object, %v", err)
|
|
|
|
}
|
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
// Authenticated download should succeed.
|
|
|
|
code, bodyContent := test(authorization)
|
2016-08-16 01:13:03 +02:00
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
if code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", code)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
2017-03-08 19:00:47 +01:00
|
|
|
if !bytes.Equal(bodyContent, content) {
|
2017-01-11 22:26:42 +01:00
|
|
|
t.Fatalf("The downloaded file is corrupted")
|
|
|
|
}
|
|
|
|
|
2017-07-24 21:46:37 +02:00
|
|
|
// Temporary token should succeed.
|
|
|
|
tmpToken, err := authenticateURL(credentials.AccessKey, credentials.SecretKey)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
|
|
|
|
code, bodyContent = test(tmpToken)
|
|
|
|
|
|
|
|
if code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", code)
|
|
|
|
}
|
|
|
|
|
|
|
|
if !bytes.Equal(bodyContent, content) {
|
|
|
|
t.Fatalf("The downloaded file is corrupted")
|
|
|
|
}
|
|
|
|
|
|
|
|
// Old token should fail.
|
|
|
|
code, bodyContent = test("eyJhbGciOiJIUzUxMiIsInR5cCI6IkpXVCJ9.eyJleHAiOjE1MDAzMzIwOTUsImlhdCI6MTUwMDMzMjAzNSwic3ViIjoiRFlLSU01VlRZNDBJMVZQSE5VMTkifQ.tXQ45GJc8eOFet_a4VWVyeqJEOPWybotQYNr2zVxBpEOICkGbu_YWGhd9TkLLe1E65oeeiLHPdXSN8CzcbPoRA")
|
|
|
|
if code != http.StatusForbidden {
|
|
|
|
t.Fatalf("Expected the response status to be 403, but instead found `%d`", code)
|
|
|
|
}
|
|
|
|
|
|
|
|
if !bytes.Equal(bodyContent, bytes.NewBufferString("Authentication failed, check your access credentials").Bytes()) {
|
2020-01-31 03:59:22 +01:00
|
|
|
t.Fatalf("Expected authentication error message, got %s", string(bodyContent))
|
2017-07-24 21:46:37 +02:00
|
|
|
}
|
|
|
|
|
2017-01-11 22:26:42 +01:00
|
|
|
// Unauthenticated download should fail.
|
2017-01-17 02:05:00 +01:00
|
|
|
code, _ = test("")
|
2017-01-11 22:26:42 +01:00
|
|
|
if code != http.StatusForbidden {
|
|
|
|
t.Fatalf("Expected the response status to be 403, but instead found `%d`", code)
|
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
bucketPolicy := &policy.Policy{
|
|
|
|
Version: policy.DefaultVersion,
|
|
|
|
Statements: []policy.Statement{policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.GetObjectAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "*")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
)},
|
2017-01-11 22:26:42 +01:00
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
if err := obj.SetBucketPolicy(context.Background(), bucketName, bucketPolicy); err != nil {
|
|
|
|
t.Fatalf("unexpected error. %v", err)
|
|
|
|
}
|
2020-05-04 18:42:58 +02:00
|
|
|
globalPolicySys.Set(bucketName, bucketPolicy)
|
2018-04-25 00:53:30 +02:00
|
|
|
defer globalPolicySys.Remove(bucketName)
|
2017-01-11 22:26:42 +01:00
|
|
|
|
|
|
|
// Unauthenticated download with READ policy should succeed.
|
|
|
|
code, bodyContent = test("")
|
|
|
|
if code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", code)
|
2016-08-16 01:13:03 +02:00
|
|
|
}
|
|
|
|
|
2017-03-08 19:00:47 +01:00
|
|
|
if !bytes.Equal(bodyContent, content) {
|
2016-08-16 01:13:03 +02:00
|
|
|
t.Fatalf("The downloaded file is corrupted")
|
|
|
|
}
|
|
|
|
}
|
2016-08-30 19:04:50 +02:00
|
|
|
|
2017-02-09 08:39:08 +01:00
|
|
|
// Test web.DownloadZip
|
|
|
|
func TestWebHandlerDownloadZip(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testWebHandlerDownloadZip)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testWebHandlerDownloadZip(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2018-09-10 18:42:43 +02:00
|
|
|
var opts ObjectOptions
|
2017-02-09 08:39:08 +01:00
|
|
|
|
2017-07-24 21:46:37 +02:00
|
|
|
authorization, err := authenticateURL(credentials.AccessKey, credentials.SecretKey)
|
2017-02-09 08:39:08 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
bucket := getRandomBucketName()
|
|
|
|
fileOne := "aaaaaaaaaaaaaa"
|
|
|
|
fileTwo := "bbbbbbbbbbbbbb"
|
|
|
|
fileThree := "cccccccccccccc"
|
|
|
|
|
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucket, "")
|
2017-02-09 08:39:08 +01:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
2019-02-09 06:31:06 +01:00
|
|
|
obj.PutObject(context.Background(), bucket, "a/one", mustGetPutObjReader(t, strings.NewReader(fileOne), int64(len(fileOne)), "", ""), opts)
|
|
|
|
obj.PutObject(context.Background(), bucket, "a/b/two", mustGetPutObjReader(t, strings.NewReader(fileTwo), int64(len(fileTwo)), "", ""), opts)
|
|
|
|
obj.PutObject(context.Background(), bucket, "a/c/three", mustGetPutObjReader(t, strings.NewReader(fileThree), int64(len(fileThree)), "", ""), opts)
|
2017-02-09 08:39:08 +01:00
|
|
|
|
|
|
|
test := func(token string) (int, []byte) {
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
path := "/minio/zip" + "?token="
|
|
|
|
if token != "" {
|
|
|
|
path = path + token
|
|
|
|
}
|
|
|
|
args := DownloadZipArgs{
|
|
|
|
Objects: []string{"one", "b/", "c/"},
|
|
|
|
Prefix: "a/",
|
|
|
|
BucketName: bucket,
|
|
|
|
}
|
|
|
|
|
|
|
|
var argsData []byte
|
|
|
|
argsData, err = json.Marshal(args)
|
|
|
|
if err != nil {
|
|
|
|
return 0, nil
|
|
|
|
}
|
|
|
|
var req *http.Request
|
2017-02-22 23:51:38 +01:00
|
|
|
req, err = http.NewRequest("POST", path, bytes.NewBuffer(argsData))
|
2017-02-09 08:39:08 +01:00
|
|
|
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", err)
|
|
|
|
}
|
|
|
|
|
2019-08-13 02:05:30 +02:00
|
|
|
req.Header.Set("User-Agent", "Mozilla")
|
|
|
|
|
2017-02-09 08:39:08 +01:00
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
return rec.Code, rec.Body.Bytes()
|
|
|
|
}
|
2017-04-14 17:00:04 +02:00
|
|
|
code, _ := test("")
|
2017-02-09 08:39:08 +01:00
|
|
|
if code != 403 {
|
|
|
|
t.Fatal("Expected to receive authentication error")
|
|
|
|
}
|
2017-04-14 17:00:04 +02:00
|
|
|
code, data := test(authorization)
|
2017-02-09 08:39:08 +01:00
|
|
|
if code != 200 {
|
|
|
|
t.Fatal("web.DownloadsZip() failed")
|
|
|
|
}
|
|
|
|
reader, err := zip.NewReader(bytes.NewReader(data), int64(len(data)))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
h := md5.New()
|
|
|
|
for _, file := range reader.File {
|
|
|
|
fileReader, err := file.Open()
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
io.Copy(h, fileReader)
|
|
|
|
}
|
|
|
|
// Verify the md5 of the response.
|
|
|
|
if hex.EncodeToString(h.Sum(nil)) != "ac7196449b14bea42775d29e8bb29f50" {
|
|
|
|
t.Fatal("Incorrect zip contents")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-09-23 10:24:49 +02:00
|
|
|
// Wrapper for calling PresignedGet handler
|
|
|
|
func TestWebHandlerPresignedGetHandler(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testWebPresignedGetHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testWebPresignedGetHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-09-23 10:24:49 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-09-23 10:24:49 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
|
|
|
objectName := "object"
|
2016-11-23 03:18:22 +01:00
|
|
|
objectSize := 1 * humanize.KiByte
|
2016-09-23 10:24:49 +02:00
|
|
|
|
|
|
|
// Create bucket.
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2016-09-23 10:24:49 +02:00
|
|
|
if err != nil {
|
|
|
|
// failed to create newbucket, abort.
|
|
|
|
t.Fatalf("%s : %s", instanceType, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
data := bytes.Repeat([]byte("a"), objectSize)
|
2017-09-19 21:40:27 +02:00
|
|
|
metadata := map[string]string{"etag": "c9a34cfc85d982698c6ac89f76071abd"}
|
2019-02-09 06:31:06 +01:00
|
|
|
_, err = obj.PutObject(context.Background(), bucketName, objectName, mustGetPutObjReader(t, bytes.NewReader(data), int64(len(data)), metadata["etag"], ""), ObjectOptions{UserDefined: metadata})
|
2016-09-23 10:24:49 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Was not able to upload an object, %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
presignGetReq := PresignedGetArgs{
|
|
|
|
HostName: "",
|
|
|
|
BucketName: bucketName,
|
|
|
|
ObjectName: objectName,
|
2016-11-22 20:12:38 +01:00
|
|
|
Expiry: 1000,
|
2016-09-23 10:24:49 +02:00
|
|
|
}
|
|
|
|
presignGetRep := &PresignedGetRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.PresignedGet", authorization, presignGetReq)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &presignGetRep)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter = initTestAPIEndPoints(obj, []string{"GetObject"})
|
|
|
|
|
|
|
|
// Initialize a new api recorder.
|
|
|
|
arec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
req, err = newTestRequest("GET", presignGetRep.URL, 0, nil)
|
|
|
|
req.Header.Del("x-amz-content-sha256")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Failed to initialized a new request", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(arec, req)
|
|
|
|
if arec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", arec.Code)
|
|
|
|
}
|
|
|
|
savedData, err := ioutil.ReadAll(arec.Body)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Reading body failed", err)
|
|
|
|
}
|
|
|
|
if !bytes.Equal(data, savedData) {
|
|
|
|
t.Fatal("Read data is not equal was what was expected")
|
|
|
|
}
|
2016-10-23 21:32:35 +02:00
|
|
|
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter = initTestWebRPCEndPoint(obj)
|
|
|
|
|
|
|
|
presignGetReq = PresignedGetArgs{
|
|
|
|
HostName: "",
|
|
|
|
BucketName: "",
|
|
|
|
ObjectName: "",
|
|
|
|
}
|
|
|
|
presignGetRep = &PresignedGetRep{}
|
|
|
|
req, err = newTestWebRPCRequest("Web.PresignedGet", authorization, presignGetReq)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &presignGetRep)
|
|
|
|
if err == nil {
|
|
|
|
t.Fatalf("Failed, %v", err)
|
|
|
|
}
|
2016-11-22 20:12:38 +01:00
|
|
|
if err.Error() != "Bucket and Object are mandatory arguments." {
|
|
|
|
t.Fatalf("Unexpected, expected `Bucket and Object are mandatory arguments`, got %s", err)
|
2016-10-23 21:32:35 +02:00
|
|
|
}
|
2016-09-23 10:24:49 +02:00
|
|
|
}
|
|
|
|
|
2016-08-30 19:04:50 +02:00
|
|
|
// Wrapper for calling GetBucketPolicy Handler
|
|
|
|
func TestWebHandlerGetBucketPolicyHandler(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testWebGetBucketPolicyHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testWebGetBucketPolicyHandler - Test GetBucketPolicy web handler
|
|
|
|
func testWebGetBucketPolicyHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-08-30 19:04:50 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-08-30 19:04:50 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
2018-04-25 00:53:30 +02:00
|
|
|
if err = obj.MakeBucketWithLocation(context.Background(), bucketName, ""); err != nil {
|
2016-09-23 01:35:12 +02:00
|
|
|
t.Fatal("Unexpected error: ", err)
|
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
bucketPolicy := &policy.Policy{
|
|
|
|
Version: policy.DefaultVersion,
|
2017-10-28 01:14:06 +02:00
|
|
|
Statements: []policy.Statement{
|
2018-04-25 00:53:30 +02:00
|
|
|
policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.GetBucketLocationAction, policy.ListBucketAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
),
|
|
|
|
policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.GetObjectAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "*")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
),
|
2016-10-13 18:19:04 +02:00
|
|
|
},
|
|
|
|
}
|
2018-04-25 00:53:30 +02:00
|
|
|
|
2018-10-09 23:00:01 +02:00
|
|
|
if err = savePolicyConfig(context.Background(), obj, bucketName, bucketPolicy); err != nil {
|
2016-09-22 01:38:50 +02:00
|
|
|
t.Fatal("Unexpected error: ", err)
|
|
|
|
}
|
2016-08-30 19:04:50 +02:00
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
bucketName string
|
|
|
|
prefix string
|
2018-04-25 00:53:30 +02:00
|
|
|
expectedResult miniogopolicy.BucketPolicy
|
2016-08-30 19:04:50 +02:00
|
|
|
}{
|
2018-04-25 00:53:30 +02:00
|
|
|
{bucketName, "", miniogopolicy.BucketPolicyReadOnly},
|
2016-08-30 19:04:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
for i, testCase := range testCases {
|
|
|
|
args := &GetBucketPolicyArgs{BucketName: testCase.bucketName, Prefix: testCase.prefix}
|
|
|
|
reply := &GetBucketPolicyRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.GetBucketPolicy", authorization, args)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Test %d: Failed to create HTTP request: <ERROR> %v", i+1, err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Test %d: Expected the response status to be 200, but instead found `%d`", i+1, rec.Code)
|
|
|
|
}
|
|
|
|
if err = getTestWebRPCResponse(rec, &reply); err != nil {
|
|
|
|
t.Fatalf("Test %d: Should succeed but it didn't, %v", i+1, err)
|
|
|
|
}
|
|
|
|
if testCase.expectedResult != reply.Policy {
|
|
|
|
t.Fatalf("Test %d: expected: %v, got: %v", i+1, testCase.expectedResult, reply.Policy)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-09-22 01:38:50 +02:00
|
|
|
|
2016-09-26 06:53:19 +02:00
|
|
|
// Wrapper for calling ListAllBucketPolicies Handler
|
|
|
|
func TestWebHandlerListAllBucketPoliciesHandler(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testWebListAllBucketPoliciesHandler)
|
2016-09-23 08:06:45 +02:00
|
|
|
}
|
|
|
|
|
2016-09-26 06:53:19 +02:00
|
|
|
// testWebListAllBucketPoliciesHandler - Test ListAllBucketPolicies web handler
|
|
|
|
func testWebListAllBucketPoliciesHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
2016-09-23 08:06:45 +02:00
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-09-23 08:06:45 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-09-23 08:06:45 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
bucketName := getRandomBucketName()
|
2018-04-25 00:53:30 +02:00
|
|
|
if err = obj.MakeBucketWithLocation(context.Background(), bucketName, ""); err != nil {
|
2016-09-23 08:06:45 +02:00
|
|
|
t.Fatal("Unexpected error: ", err)
|
|
|
|
}
|
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
func1, err := condition.NewStringEqualsFunc(condition.S3Prefix, "hello")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Unable to create string equals condition function. %v", err)
|
|
|
|
}
|
2017-10-28 01:14:06 +02:00
|
|
|
|
2018-04-25 00:53:30 +02:00
|
|
|
bucketPolicy := &policy.Policy{
|
|
|
|
Version: policy.DefaultVersion,
|
2017-10-28 01:14:06 +02:00
|
|
|
Statements: []policy.Statement{
|
2018-04-25 00:53:30 +02:00
|
|
|
policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.GetBucketLocationAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
),
|
|
|
|
policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.ListBucketAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "")),
|
|
|
|
condition.NewFunctions(func1),
|
|
|
|
),
|
|
|
|
policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(policy.ListBucketMultipartUploadsAction),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
),
|
|
|
|
policy.NewStatement(
|
|
|
|
policy.Allow,
|
|
|
|
policy.NewPrincipal("*"),
|
|
|
|
policy.NewActionSet(
|
|
|
|
policy.AbortMultipartUploadAction,
|
|
|
|
policy.DeleteObjectAction,
|
|
|
|
policy.GetObjectAction,
|
|
|
|
policy.ListMultipartUploadPartsAction,
|
|
|
|
policy.PutObjectAction,
|
|
|
|
),
|
|
|
|
policy.NewResourceSet(policy.NewResource(bucketName, "hello*")),
|
|
|
|
condition.NewFunctions(),
|
|
|
|
),
|
2016-10-13 18:19:04 +02:00
|
|
|
},
|
|
|
|
}
|
2018-04-25 00:53:30 +02:00
|
|
|
|
2018-10-09 23:00:01 +02:00
|
|
|
if err = savePolicyConfig(context.Background(), obj, bucketName, bucketPolicy); err != nil {
|
2016-09-23 08:06:45 +02:00
|
|
|
t.Fatal("Unexpected error: ", err)
|
|
|
|
}
|
|
|
|
|
2017-03-16 20:21:58 +01:00
|
|
|
testCaseResult1 := []BucketAccessPolicy{{
|
2018-02-28 04:14:49 +01:00
|
|
|
Bucket: bucketName,
|
|
|
|
Prefix: "hello",
|
2018-04-25 00:53:30 +02:00
|
|
|
Policy: miniogopolicy.BucketPolicyReadWrite,
|
2016-09-26 06:53:19 +02:00
|
|
|
}}
|
2016-09-23 08:06:45 +02:00
|
|
|
testCases := []struct {
|
|
|
|
bucketName string
|
2017-03-16 20:21:58 +01:00
|
|
|
expectedResult []BucketAccessPolicy
|
2016-09-23 08:06:45 +02:00
|
|
|
}{
|
|
|
|
{bucketName, testCaseResult1},
|
|
|
|
}
|
|
|
|
|
|
|
|
for i, testCase := range testCases {
|
2016-09-26 06:53:19 +02:00
|
|
|
args := &ListAllBucketPoliciesArgs{BucketName: testCase.bucketName}
|
|
|
|
reply := &ListAllBucketPoliciesRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.ListAllBucketPolicies", authorization, args)
|
2016-09-23 08:06:45 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Test %d: Failed to create HTTP request: <ERROR> %v", i+1, err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Test %d: Expected the response status to be 200, but instead found `%d`", i+1, rec.Code)
|
|
|
|
}
|
|
|
|
if err = getTestWebRPCResponse(rec, &reply); err != nil {
|
|
|
|
t.Fatalf("Test %d: Should succeed but it didn't, %v", i+1, err)
|
|
|
|
}
|
|
|
|
if !reflect.DeepEqual(testCase.expectedResult, reply.Policies) {
|
|
|
|
t.Fatalf("Test %d: expected: %v, got: %v", i+1, testCase.expectedResult, reply.Policies)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-09-22 01:38:50 +02:00
|
|
|
// Wrapper for calling SetBucketPolicy Handler
|
|
|
|
func TestWebHandlerSetBucketPolicyHandler(t *testing.T) {
|
|
|
|
ExecObjectLayerTest(t, testWebSetBucketPolicyHandler)
|
|
|
|
}
|
|
|
|
|
|
|
|
// testWebSetBucketPolicyHandler - Test SetBucketPolicy web handler
|
|
|
|
func testWebSetBucketPolicyHandler(obj ObjectLayer, instanceType string, t TestErrHandler) {
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-09-22 01:38:50 +02:00
|
|
|
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-09-22 01:38:50 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate")
|
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
// Create a bucket
|
|
|
|
bucketName := getRandomBucketName()
|
2018-03-15 21:27:16 +01:00
|
|
|
if err = obj.MakeBucketWithLocation(context.Background(), bucketName, ""); err != nil {
|
2016-09-22 01:38:50 +02:00
|
|
|
t.Fatal("Unexpected error: ", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
testCases := []struct {
|
|
|
|
bucketName string
|
|
|
|
prefix string
|
|
|
|
policy string
|
|
|
|
pass bool
|
|
|
|
}{
|
|
|
|
// Invalid bucket name
|
|
|
|
{"", "", "readonly", false},
|
|
|
|
// Invalid policy
|
|
|
|
{bucketName, "", "foo", false},
|
|
|
|
// Valid parameters
|
|
|
|
{bucketName, "", "readwrite", true},
|
2016-09-26 12:11:22 +02:00
|
|
|
// None is valid and policy should be removed.
|
|
|
|
{bucketName, "", "none", true},
|
|
|
|
// Setting none again meants should return an error.
|
|
|
|
{bucketName, "", "none", false},
|
2016-09-22 01:38:50 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
for i, testCase := range testCases {
|
2018-04-25 00:53:30 +02:00
|
|
|
args := &SetBucketPolicyWebArgs{BucketName: testCase.bucketName, Prefix: testCase.prefix, Policy: testCase.policy}
|
2016-09-22 01:38:50 +02:00
|
|
|
reply := &WebGenericRep{}
|
|
|
|
// Call SetBucketPolicy RPC
|
|
|
|
req, err := newTestWebRPCRequest("Web.SetBucketPolicy", authorization, args)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Test %d: Failed to create HTTP request: <ERROR> %v", i+1, err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
// Check if we have 200 OK
|
2016-09-26 12:11:22 +02:00
|
|
|
if testCase.pass && rec.Code != http.StatusOK {
|
2016-09-22 01:38:50 +02:00
|
|
|
t.Fatalf("Test %d: Expected the response status to be 200, but instead found `%d`", i+1, rec.Code)
|
|
|
|
}
|
|
|
|
// Parse RPC response
|
|
|
|
err = getTestWebRPCResponse(rec, &reply)
|
|
|
|
if testCase.pass && err != nil {
|
2017-10-28 01:14:06 +02:00
|
|
|
t.Fatalf("Test %d: Should succeed but it didn't, %#v", i+1, err)
|
2016-09-22 01:38:50 +02:00
|
|
|
}
|
|
|
|
if !testCase.pass && err == nil {
|
|
|
|
t.Fatalf("Test %d: Should fail it didn't", i+1)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-09-23 01:35:12 +02:00
|
|
|
|
|
|
|
// TestWebCheckAuthorization - Test Authorization for all web handlers
|
|
|
|
func TestWebCheckAuthorization(t *testing.T) {
|
2020-04-15 02:52:38 +02:00
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
|
|
defer cancel()
|
|
|
|
|
2016-09-23 01:35:12 +02:00
|
|
|
// Prepare XL backend
|
2020-04-15 02:52:38 +02:00
|
|
|
obj, fsDirs, err := prepareXL16(ctx)
|
2016-10-05 21:48:07 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Initialization of object layer failed for XL setup: %s", err)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
// Executing the object layer tests for XL.
|
|
|
|
defer removeRoots(fsDirs)
|
|
|
|
|
|
|
|
// Register the API end points with XL/FS object layer.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2018-08-15 06:41:47 +02:00
|
|
|
|
2016-09-23 01:35:12 +02:00
|
|
|
// initialize the server and obtain the credentials and root.
|
|
|
|
// credentials are necessary to sign the HTTP request.
|
2018-08-15 06:41:47 +02:00
|
|
|
err = newTestConfig(globalMinioDefaultRegion, obj)
|
2016-10-05 21:48:07 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Init Test config failed", err)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
|
|
|
// Check if web rpc calls return unauthorized request with an incorrect token
|
2016-11-02 22:45:11 +01:00
|
|
|
webRPCs := []string{
|
|
|
|
"ServerInfo", "StorageInfo", "MakeBucket",
|
|
|
|
"ListBuckets", "ListObjects", "RemoveObject",
|
2019-05-29 22:18:46 +02:00
|
|
|
"GenerateAuth", "SetAuth",
|
2016-11-02 22:45:11 +01:00
|
|
|
"GetBucketPolicy", "SetBucketPolicy", "ListAllBucketPolicies",
|
|
|
|
"PresignedGet",
|
|
|
|
}
|
2016-09-23 01:35:12 +02:00
|
|
|
for _, rpcCall := range webRPCs {
|
|
|
|
reply := &WebGenericRep{}
|
2019-04-18 08:16:27 +02:00
|
|
|
req, nerr := newTestWebRPCRequest("Web."+rpcCall, "Bearer fooauthorization", &WebGenericArgs{})
|
2016-10-05 21:48:07 +02:00
|
|
|
if nerr != nil {
|
|
|
|
t.Fatalf("Test %s: Failed to create HTTP request: <ERROR> %v", rpcCall, nerr)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Test %s: Expected the response status to be 200, but instead found `%d`", rpcCall, rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &reply)
|
|
|
|
if err == nil {
|
|
|
|
t.Fatalf("Test %s: Should fail", rpcCall)
|
|
|
|
} else {
|
2016-11-02 22:45:11 +01:00
|
|
|
if !strings.Contains(err.Error(), errAuthentication.Error()) {
|
2016-09-23 01:35:12 +02:00
|
|
|
t.Fatalf("Test %s: should fail with Unauthorized request. Found error: %v", rpcCall, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-11-02 22:45:11 +01:00
|
|
|
rec = httptest.NewRecorder()
|
2016-09-23 01:35:12 +02:00
|
|
|
// Test authorization of Web.Download
|
|
|
|
req, err := http.NewRequest("GET", "/minio/download/bucket/object?token=wrongauth", nil)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", err)
|
|
|
|
}
|
2019-08-13 02:05:30 +02:00
|
|
|
req.Header.Set("User-Agent", "Mozilla")
|
2016-09-23 01:35:12 +02:00
|
|
|
apiRouter.ServeHTTP(rec, req)
|
2016-11-02 22:45:11 +01:00
|
|
|
if rec.Code != http.StatusForbidden {
|
|
|
|
t.Fatalf("Expected the response status to be 403, but instead found `%d`", rec.Code)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
2019-02-13 13:59:36 +01:00
|
|
|
resp := rec.Body.String()
|
2016-11-02 22:45:11 +01:00
|
|
|
if !strings.EqualFold(resp, errAuthentication.Error()) {
|
|
|
|
t.Fatalf("Unexpected error message, expected: %s, found: `%s`", errAuthentication, resp)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
|
2016-11-02 22:45:11 +01:00
|
|
|
rec = httptest.NewRecorder()
|
2016-09-23 01:35:12 +02:00
|
|
|
// Test authorization of Web.Upload
|
|
|
|
content := []byte("temporary file's content")
|
|
|
|
req, err = http.NewRequest("PUT", "/minio/upload/bucket/object", nil)
|
|
|
|
req.Header.Set("Authorization", "Bearer foo-authorization")
|
2019-08-13 02:05:30 +02:00
|
|
|
req.Header.Set("User-Agent", "Mozilla")
|
2016-09-23 01:35:12 +02:00
|
|
|
req.Header.Set("Content-Length", strconv.Itoa(len(content)))
|
|
|
|
req.Header.Set("x-amz-date", "20160814T114029Z")
|
|
|
|
req.Header.Set("Accept", "*/*")
|
|
|
|
req.Body = ioutil.NopCloser(bytes.NewReader(content))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
2016-11-02 22:45:11 +01:00
|
|
|
if rec.Code != http.StatusForbidden {
|
|
|
|
t.Fatalf("Expected the response status to be 403, but instead found `%d`", rec.Code)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
2019-02-13 13:59:36 +01:00
|
|
|
resp = rec.Body.String()
|
2016-11-02 22:45:11 +01:00
|
|
|
if !strings.EqualFold(resp, errAuthentication.Error()) {
|
|
|
|
t.Fatalf("Unexpected error message, expected: `%s`, found: `%s`", errAuthentication, resp)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// TestWebObjectLayerFaultyDisks - Test Web RPC responses with faulty disks
|
|
|
|
func TestWebObjectLayerFaultyDisks(t *testing.T) {
|
2020-04-15 02:52:38 +02:00
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
|
|
defer cancel()
|
|
|
|
|
2016-09-23 01:35:12 +02:00
|
|
|
// Prepare XL backend
|
2020-04-15 02:52:38 +02:00
|
|
|
obj, fsDirs, err := prepareXL16(ctx)
|
2016-10-05 21:48:07 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Initialization of object layer failed for XL setup: %s", err)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
// Executing the object layer tests for XL.
|
|
|
|
defer removeRoots(fsDirs)
|
|
|
|
|
2018-08-15 06:41:47 +02:00
|
|
|
// initialize the server and obtain the credentials and root.
|
|
|
|
// credentials are necessary to sign the HTTP request.
|
|
|
|
err = newTestConfig(globalMinioDefaultRegion, obj)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Init Test config failed", err)
|
|
|
|
}
|
|
|
|
|
2017-03-04 00:46:28 +01:00
|
|
|
bucketName := "mybucket"
|
2018-03-15 21:27:16 +01:00
|
|
|
err = obj.MakeBucketWithLocation(context.Background(), bucketName, "")
|
2017-03-04 00:46:28 +01:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot make bucket:", err)
|
|
|
|
}
|
|
|
|
|
2016-09-23 01:35:12 +02:00
|
|
|
// Set faulty disks to XL backend
|
2019-11-20 02:42:27 +01:00
|
|
|
z := obj.(*xlZones)
|
|
|
|
xl := z.zones[0].sets[0]
|
|
|
|
xlDisks := xl.getDisks()
|
2020-01-23 20:50:09 +01:00
|
|
|
z.zones[0].xlDisksMu.Lock()
|
2019-11-20 02:42:27 +01:00
|
|
|
xl.getDisks = func() []StorageAPI {
|
|
|
|
for i, d := range xlDisks {
|
|
|
|
xlDisks[i] = newNaughtyDisk(d, nil, errFaultyDisk)
|
|
|
|
}
|
|
|
|
return xlDisks
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
2020-01-23 20:50:09 +01:00
|
|
|
z.zones[0].xlDisksMu.Unlock()
|
2016-09-23 01:35:12 +02:00
|
|
|
|
2016-10-05 21:48:07 +02:00
|
|
|
// Initialize web rpc endpoint.
|
|
|
|
apiRouter := initTestWebRPCEndPoint(obj)
|
2016-09-23 01:35:12 +02:00
|
|
|
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
|
2019-10-23 07:59:13 +02:00
|
|
|
credentials := globalActiveCred
|
2016-12-26 19:21:23 +01:00
|
|
|
authorization, err := getWebRPCToken(apiRouter, credentials.AccessKey, credentials.SecretKey)
|
2016-10-05 21:48:07 +02:00
|
|
|
if err != nil {
|
|
|
|
t.Fatal("Cannot authenticate", err)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// Check if web rpc calls return errors with faulty disks. ServerInfo, GenerateAuth, SetAuth, GetAuth are not concerned
|
2017-03-04 00:46:28 +01:00
|
|
|
// RemoveObject is also not concerned since it always returns success.
|
|
|
|
webRPCs := []struct {
|
|
|
|
webRPCName string
|
|
|
|
ReqArgs interface{}
|
|
|
|
RepArgs interface{}
|
|
|
|
}{
|
|
|
|
{"MakeBucket", MakeBucketArgs{BucketName: bucketName}, WebGenericRep{}},
|
2019-04-18 08:16:27 +02:00
|
|
|
{"ListBuckets", WebGenericArgs{}, ListBucketsRep{}},
|
2017-03-04 00:46:28 +01:00
|
|
|
{"ListObjects", ListObjectsArgs{BucketName: bucketName, Prefix: ""}, ListObjectsRep{}},
|
|
|
|
{"GetBucketPolicy", GetBucketPolicyArgs{BucketName: bucketName, Prefix: ""}, GetBucketPolicyRep{}},
|
2018-04-25 00:53:30 +02:00
|
|
|
{"SetBucketPolicy", SetBucketPolicyWebArgs{BucketName: bucketName, Prefix: "", Policy: "none"}, WebGenericRep{}},
|
2017-03-04 00:46:28 +01:00
|
|
|
}
|
2016-09-23 01:35:12 +02:00
|
|
|
|
|
|
|
for _, rpcCall := range webRPCs {
|
2017-03-04 00:46:28 +01:00
|
|
|
args := &rpcCall.ReqArgs
|
|
|
|
reply := &rpcCall.RepArgs
|
|
|
|
req, nerr := newTestWebRPCRequest("Web."+rpcCall.webRPCName, authorization, args)
|
2016-10-05 21:48:07 +02:00
|
|
|
if nerr != nil {
|
|
|
|
t.Fatalf("Test %s: Failed to create HTTP request: <ERROR> %v", rpcCall, nerr)
|
2016-09-23 01:35:12 +02:00
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Test %s: Expected the response status to be 200, but instead found `%d`", rpcCall, rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &reply)
|
|
|
|
if err == nil {
|
|
|
|
t.Errorf("Test %s: Should fail", rpcCall)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test Web.StorageInfo
|
2019-04-18 08:16:27 +02:00
|
|
|
storageInfoRequest := &WebGenericArgs{}
|
2016-09-23 01:35:12 +02:00
|
|
|
storageInfoReply := &StorageInfoRep{}
|
|
|
|
req, err := newTestWebRPCRequest("Web.StorageInfo", authorization, storageInfoRequest)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed to create HTTP request: <ERROR> %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
err = getTestWebRPCResponse(rec, &storageInfoReply)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Failed %v", err)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test authorization of Web.Download
|
|
|
|
req, err = http.NewRequest("GET", "/minio/download/bucket/object?token="+authorization, nil)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test authorization of Web.Upload
|
|
|
|
content := []byte("temporary file's content")
|
|
|
|
req, err = http.NewRequest("PUT", "/minio/upload/bucket/object", nil)
|
|
|
|
req.Header.Set("Authorization", "Bearer "+authorization)
|
|
|
|
req.Header.Set("Content-Length", strconv.Itoa(len(content)))
|
|
|
|
req.Header.Set("x-amz-date", "20160814T114029Z")
|
|
|
|
req.Header.Set("Accept", "*/*")
|
|
|
|
req.Body = ioutil.NopCloser(bytes.NewReader(content))
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Cannot create upload request, %v", err)
|
|
|
|
}
|
|
|
|
apiRouter.ServeHTTP(rec, req)
|
|
|
|
if rec.Code != http.StatusOK {
|
|
|
|
t.Fatalf("Expected the response status to be 200, but instead found `%d`", rec.Code)
|
|
|
|
}
|
|
|
|
}
|