maxmustermann
/
minio
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

fix: honor system umask for file creates (#12601) 

use 0666 os.FileMode to honor system umask
This commit is contained in:
Harshavardhana 2021-07-06 12:54:16 -07:00 committed by GitHub
parent 6503c6ac21
commit 039978640f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/format-erasure.go
View File

@ -242,7 +242,7 @@ func formatErasureMigrateV1ToV2(export, version string) error {
if err != nil {
return err
}
return ioutil.WriteFile(formatPath, b, 0644)
return ioutil.WriteFile(formatPath, b, 0666)
}
// Migrates V2 for format.json to V3 (Flat hierarchy for multipart)
@ -284,7 +284,7 @@ func formatErasureMigrateV2ToV3(export, version string) error {
if err != nil {
return err
}
return ioutil.WriteFile(formatPath, b, 0644)
return ioutil.WriteFile(formatPath, b, 0666)
}
// countErrs - count a specific error.

2
cmd/fs-v1-multipart.go
View File

@ -241,7 +241,7 @@ func (fs *FSObjects) NewMultipartUpload(ctx context.Context, bucket, object stri
return "", err
}
if err = ioutil.WriteFile(pathJoin(uploadIDDir, fs.metaJSONFile), fsMetaBytes, 0644); err != nil {
if err = ioutil.WriteFile(pathJoin(uploadIDDir, fs.metaJSONFile), fsMetaBytes, 0666); err != nil {
logger.LogIf(ctx, err)
return "", err
}

2
cmd/tier-journal.go
View File

@ -255,7 +255,7 @@ func (jd *tierDiskJournal) Open() error {
}
var err error
jd.file, err = os.OpenFile(jd.JournalPath(), os.O_APPEND|os.O_CREATE|os.O_WRONLY|writeMode, 0644)
jd.file, err = os.OpenFile(jd.JournalPath(), os.O_APPEND|os.O_CREATE|os.O_WRONLY|writeMode, 0666)
if err != nil {
return err
}

4
internal/ioutil/append-file_windows.go
View File

@ -26,13 +26,13 @@ import (
// AppendFile - appends the file "src" to the file "dst"
func AppendFile(dst string, src string, osync bool) error {
appendFile, err := lock.Open(dst, os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0644)
appendFile, err := lock.Open(dst, os.O_WRONLY|os.O_APPEND|os.O_CREATE, 0666)
if err != nil {
return err
}
defer appendFile.Close()
srcFile, err := lock.Open(src, os.O_RDONLY, 0644)
srcFile, err := lock.Open(src, os.O_RDONLY, 0666)
if err != nil {
return err
}