maxmustermann/minio
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

Fix readiness to return 200 for read-only mode (#8728)

Browse source 
- We should declare a cluster ready even if read quorum is achieved (atleast n/2 disks are online).
- Such that, all the zones should have enough read quorum. Thus making the cluster ready for reads.
This commit is contained in:
Praveen raj Mani 2020-01-02 18:35:01 +05:30 committed by kannappanr
parent 97d799b9f0
commit 157721f694
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/healthcheck-handler.go
View file

@ -26,7 +26,7 @@ import (
// ReadinessCheckHandler -- Checks if the quorum number of disks are available.
// For FS - Checks if the backend disk is available
// For Zones - Checks if all the zones have enough quorum
// For Zones - Checks if all the zones have enough read quorum
func ReadinessCheckHandler(w http.ResponseWriter, r *http.Request) {
ctx := newContext(r, w, "ReadinessCheckHandler")

6
cmd/xl-sets.go
View file

@ -1657,7 +1657,7 @@ func (s *xlSets) GetMetrics(ctx context.Context) (*Metrics, error) {
return &Metrics{}, NotImplemented{}
}
// IsReady - Returns true if more than n/2 disks (quorum) are online
// IsReady - Returns true if atleast n/2 disks (read quorum) are online
func (s *xlSets) IsReady(_ context.Context) bool {
s.xlDisksMu.RLock()
defer s.xlDisksMu.RUnlock()
@ -1674,8 +1674,8 @@ func (s *xlSets) IsReady(_ context.Context) bool {
if s.xlDisks[i][j].IsOnline() {
activeDisks++
}
// Return if more than n/2 disks are online.
if activeDisks > len(s.endpoints)/2 {
// Return true if read quorum is available.
if activeDisks >= len(s.endpoints)/2 {
return true
}
}