maxmustermann/minio
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

fs: Update object modtime when metadata is updated (#12818)

Browse source 
Follow S3 behavior of updating object modtime when object metadata is
updated.
This commit is contained in:
Anis Elleuch 2021-07-28 15:36:38 +01:00 committed by GitHub
parent a78bc7bfdb
commit 20cacc3b04
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
cmd/fs-v1-helpers.go
View file

@ -24,6 +24,7 @@ import (
pathutil "path"
"runtime"
"strings"
"time"
"github.com/minio/minio/internal/lock"
"github.com/minio/minio/internal/logger"
@ -168,6 +169,25 @@ func fsStat(ctx context.Context, statLoc string) (os.FileInfo, error) {
return fi, nil
}
// fsTouch updates a file access & modtime with current time
func fsTouch(ctx context.Context, statLoc string) error {
if statLoc == "" {
logger.LogIf(ctx, errInvalidArgument)
return errInvalidArgument
}
if err := checkPathLength(statLoc); err != nil {
logger.LogIf(ctx, err)
return err
}
now := time.Now()
if err := os.Chtimes(statLoc, now, now); err != nil {
logger.LogIf(ctx, err)
return err
}
return nil
}
// Lookup if volume exists, returns volume attributes upon success.
func fsStatVolume(ctx context.Context, volume string) (os.FileInfo, error) {
fi, err := fsStat(ctx, volume)

11
cmd/fs-v1.go
View file

@ -682,8 +682,15 @@ func (fs *FSObjects) CopyObject(ctx context.Context, srcBucket, srcObject, dstBu
return oi, toObjectErr(err, srcBucket, srcObject)
}
// Stat the file to get file size.
fi, err := fsStatFile(ctx, pathJoin(fs.fsPath, srcBucket, srcObject))
fsObjectPath := pathJoin(fs.fsPath, srcBucket, srcObject)
// Update object modtime
err = fsTouch(ctx, fsObjectPath)
if err != nil {
return oi, toObjectErr(err, srcBucket, srcObject)
}
// Stat the file to get object info
fi, err := fsStatFile(ctx, fsObjectPath)
if err != nil {
return oi, toObjectErr(err, srcBucket, srcObject)
}