Nitish Tiwari
ad53c5d859
Remove body from POST request in webhook ( #5067 )
...
When webhook notification is configured, Minio server tries to lookup the
webhook endpoint by making a POST request with body set as releasetag.
We can remove the body from the POST request as the POST body does not
add any specific value.
This discussion on IETF group says empty POSTs are okay
http://lists.w3.org/Archives/Public/ietf-http-wg/2010JulSep/0272.html
Fixes: https://github.com/minio/minio/issues/5066
2017-10-13 13:29:01 +05:30
Bala FA
88938340b3
remove all dead codes ( #5019 )
...
Fixes #5012
2017-10-05 12:25:45 -07:00
Harshavardhana
330f79b40e
Remove pre go1.8 code and cleanup ( #4933 )
...
We don't need certain go1.7.x custom code anymore, since
we have migrated to go1.8
2017-09-22 14:03:31 -07:00
Harshavardhana
df027a8f51
Webhook endpoints can fail, we must start the server. ( #4255 )
...
This PR fixes a regression introduced in #4060
2017-05-04 13:43:54 -07:00
Harshavardhana
6b4f368dfe
notify: Webhook endpoints can fail, but we must start the server. ( #4060 )
...
Ignore any network errors when registering a webhook
notifier during Minio startup sequence. This way server
can be started even if the webhook endpoint is not available
and unreachable.
2017-04-08 01:13:55 -07:00
Anis Elleuch
fbe8b3259d
webhook: Add support of custom CAs ( #4000 )
2017-03-29 13:42:55 -07:00
Anis Elleuch
8426cf9aec
config: Accept more address format + unit test ( #3915 )
...
checkURL() is a generic function to check if a passed address
is valid. This commit adds support for addresses like `m1`
and `172.16.3.1` which is needed in MySQL and NATS. This commit
also adds tests.
2017-03-16 11:44:01 -07:00
Anis Elleuch
ae4361cc45
config: Check for duplicated entries in all scopes ( #3872 )
...
Validate Minio config by checking if there is double json key
in any scope level. The returned error contains the json path
to the duplicated key.
2017-03-15 16:30:34 -07:00
Harshavardhana
1b4bb94ac4
config: setter/getter for Notifier and Logger into its own struct. ( #3721 )
...
This is an attempt cleanup code and keep the top level config
functions simpler and easy to understand where as move the
notifier related code and logger setter/getter methods as part
of their own struct.
Locks are now held properly not globally by configMutex, but
instead as private variables.
Final fix for #3700
2017-02-09 15:20:54 -08:00
Alex Ellis
02194ee3c6
Fix issue with webhook events not closing Response body, leaving connections open with remote server ( #3645 )
2017-01-27 09:50:08 -08:00
Harshavardhana
7b85756c64
notify/webhook: Handle webendpoints without port ( #3568 )
...
Fixes and issue initializing webhook notification
```
FATA[0000] Initializing object layer failed cause=Unable to initialize event \
notification. dial tcp: missing port in address requestb.in source=[server-main.go:448:serverMain()]
```
2017-01-12 20:08:00 -08:00
Alex
d6a327fbc5
Add notifications by webhook.
...
Add a new config entry moving to version 13.
```
"webhook": {
"1": {
"enable": true,
"address": "http://requestb.in/1i9al7m1 "
}
}
```
2017-01-12 10:19:59 -08:00
