This PR fixes a security issue where an IAM user based on his policy is granted more privileges than restricted by the users IAM policy. This is due to an issue of prefix based Matcher() function which was incorrectly matching prefix based on resource prefixes instead of exact match.
223 lines
7.2 KiB
Go
223 lines
7.2 KiB
Go
/*
|
|
* MinIO Cloud Storage, (C) 2018 MinIO, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package iampolicy
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"reflect"
|
|
"testing"
|
|
)
|
|
|
|
func TestResourceIsBucketPattern(t *testing.T) {
|
|
testCases := []struct {
|
|
resource Resource
|
|
expectedResult bool
|
|
}{
|
|
{NewResource("*", ""), true},
|
|
{NewResource("mybucket", ""), true},
|
|
{NewResource("mybucket*", ""), true},
|
|
{NewResource("mybucket?0", ""), true},
|
|
{NewResource("", "*"), false},
|
|
{NewResource("*", "*"), false},
|
|
{NewResource("mybucket", "*"), false},
|
|
{NewResource("mybucket*", "/myobject"), false},
|
|
{NewResource("mybucket?0", "/2010/photos/*"), false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
result := testCase.resource.isBucketPattern()
|
|
|
|
if result != testCase.expectedResult {
|
|
t.Fatalf("case %v: expected: %v, got: %v", i+1, testCase.expectedResult, result)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestResourceIsObjectPattern(t *testing.T) {
|
|
testCases := []struct {
|
|
resource Resource
|
|
expectedResult bool
|
|
}{
|
|
{NewResource("*", ""), true},
|
|
{NewResource("mybucket*", ""), true},
|
|
{NewResource("", "*"), true},
|
|
{NewResource("*", "*"), true},
|
|
{NewResource("mybucket", "*"), true},
|
|
{NewResource("mybucket*", "/myobject"), true},
|
|
{NewResource("mybucket?0", "/2010/photos/*"), true},
|
|
{NewResource("mybucket", ""), false},
|
|
{NewResource("mybucket?0", ""), false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
result := testCase.resource.isObjectPattern()
|
|
|
|
if result != testCase.expectedResult {
|
|
t.Fatalf("case %v: expected: %v, got: %v", i+1, testCase.expectedResult, result)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestResourceIsValid(t *testing.T) {
|
|
testCases := []struct {
|
|
resource Resource
|
|
expectedResult bool
|
|
}{
|
|
{NewResource("*", ""), true},
|
|
{NewResource("mybucket*", ""), true},
|
|
{NewResource("*", "*"), true},
|
|
{NewResource("mybucket", "*"), true},
|
|
{NewResource("mybucket*", "/myobject"), true},
|
|
{NewResource("mybucket?0", "/2010/photos/*"), true},
|
|
{NewResource("mybucket", ""), true},
|
|
{NewResource("mybucket?0", ""), true},
|
|
{NewResource("", "*"), true},
|
|
{NewResource("", ""), false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
result := testCase.resource.IsValid()
|
|
|
|
if result != testCase.expectedResult {
|
|
t.Fatalf("case %v: expected: %v, got: %v", i+1, testCase.expectedResult, result)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestResourceMatch(t *testing.T) {
|
|
testCases := []struct {
|
|
resource Resource
|
|
objectName string
|
|
expectedResult bool
|
|
}{
|
|
{NewResource("*", ""), "mybucket", true},
|
|
{NewResource("*", ""), "mybucket/myobject", true},
|
|
{NewResource("mybucket*", ""), "mybucket", true},
|
|
{NewResource("mybucket*", ""), "mybucket/myobject", true},
|
|
{NewResource("", "*"), "/myobject", true},
|
|
{NewResource("*", "*"), "mybucket/myobject", true},
|
|
{NewResource("mybucket", "*"), "mybucket/myobject", true},
|
|
{NewResource("mybucket*", "/myobject"), "mybucket/myobject", true},
|
|
{NewResource("mybucket*", "/myobject"), "mybucket100/myobject", true},
|
|
{NewResource("mybucket?0", "/2010/photos/*"), "mybucket20/2010/photos/1.jpg", true},
|
|
{NewResource("mybucket", ""), "mybucket", true},
|
|
{NewResource("mybucket?0", ""), "mybucket30", true},
|
|
{NewResource("", "*"), "mybucket/myobject", false},
|
|
{NewResource("*", "*"), "mybucket", false},
|
|
{NewResource("mybucket", "*"), "mybucket10/myobject", false},
|
|
{NewResource("mybucket?0", "/2010/photos/*"), "mybucket0/2010/photos/1.jpg", false},
|
|
{NewResource("mybucket", ""), "mybucket/myobject", false},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
testCase := testCase
|
|
t.Run(fmt.Sprintf("Test%d", i+1), func(t *testing.T) {
|
|
result := testCase.resource.Match(testCase.objectName, nil)
|
|
if result != testCase.expectedResult {
|
|
t.Errorf("case %v: expected: %v, got: %v", i+1, testCase.expectedResult, result)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestResourceMarshalJSON(t *testing.T) {
|
|
testCases := []struct {
|
|
resource Resource
|
|
expectedResult []byte
|
|
expectErr bool
|
|
}{
|
|
{NewResource("*", ""), []byte(`"arn:aws:s3:::*"`), false},
|
|
{NewResource("mybucket*", ""), []byte(`"arn:aws:s3:::mybucket*"`), false},
|
|
{NewResource("mybucket", ""), []byte(`"arn:aws:s3:::mybucket"`), false},
|
|
{NewResource("*", "*"), []byte(`"arn:aws:s3:::*/*"`), false},
|
|
{NewResource("", "*"), []byte(`"arn:aws:s3:::/*"`), false},
|
|
{NewResource("mybucket", "*"), []byte(`"arn:aws:s3:::mybucket/*"`), false},
|
|
{NewResource("mybucket*", "myobject"), []byte(`"arn:aws:s3:::mybucket*/myobject"`), false},
|
|
{NewResource("mybucket?0", "/2010/photos/*"), []byte(`"arn:aws:s3:::mybucket?0/2010/photos/*"`), false},
|
|
{Resource{}, nil, true},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
result, err := json.Marshal(testCase.resource)
|
|
expectErr := (err != nil)
|
|
|
|
if expectErr != testCase.expectErr {
|
|
t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr)
|
|
}
|
|
|
|
if !testCase.expectErr {
|
|
if !reflect.DeepEqual(result, testCase.expectedResult) {
|
|
t.Fatalf("case %v: result: expected: %v, got: %v", i+1, string(testCase.expectedResult), string(result))
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestResourceUnmarshalJSON(t *testing.T) {
|
|
testCases := []struct {
|
|
data []byte
|
|
expectedResult Resource
|
|
expectErr bool
|
|
}{
|
|
{[]byte(`"arn:aws:s3:::*"`), NewResource("*", ""), false},
|
|
{[]byte(`"arn:aws:s3:::mybucket*"`), NewResource("mybucket*", ""), false},
|
|
{[]byte(`"arn:aws:s3:::mybucket"`), NewResource("mybucket", ""), false},
|
|
{[]byte(`"arn:aws:s3:::*/*"`), NewResource("*", "*"), false},
|
|
{[]byte(`"arn:aws:s3:::mybucket/*"`), NewResource("mybucket", "*"), false},
|
|
{[]byte(`"arn:aws:s3:::mybucket*/myobject"`), NewResource("mybucket*", "myobject"), false},
|
|
{[]byte(`"arn:aws:s3:::mybucket?0/2010/photos/*"`), NewResource("mybucket?0", "/2010/photos/*"), false},
|
|
{[]byte(`"mybucket/myobject*"`), Resource{}, true},
|
|
{[]byte(`"arn:aws:s3:::/*"`), Resource{}, true},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
var result Resource
|
|
err := json.Unmarshal(testCase.data, &result)
|
|
expectErr := (err != nil)
|
|
|
|
if expectErr != testCase.expectErr {
|
|
t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr)
|
|
}
|
|
|
|
if !testCase.expectErr {
|
|
if !reflect.DeepEqual(result, testCase.expectedResult) {
|
|
t.Fatalf("case %v: result: expected: %v, got: %v", i+1, testCase.expectedResult, result)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestResourceValidate(t *testing.T) {
|
|
testCases := []struct {
|
|
resource Resource
|
|
expectErr bool
|
|
}{
|
|
{NewResource("mybucket", "/myobject*"), false},
|
|
{NewResource("", "/myobject*"), false},
|
|
{NewResource("", ""), true},
|
|
}
|
|
|
|
for i, testCase := range testCases {
|
|
err := testCase.resource.Validate()
|
|
expectErr := (err != nil)
|
|
|
|
if expectErr != testCase.expectErr {
|
|
t.Fatalf("case %v: error: expected: %v, got: %v", i+1, testCase.expectErr, expectErr)
|
|
}
|
|
}
|
|
}
|